[PATCH v3 0/6] usb: usbip: Fix ports and port status

2017-04-05 Thread Yuyang Du
The commit 0775a9cbc694e8c7 ("usbip: vhci extension: modifications to vhci driver") introduced several bugs relating to the number of ports amd the port status. In addition, a small improvement is made to the vhci_hcd module. v3: - Check both ends of the nports - Check the return of ncontrollers

[PATCH v3 3/6] usb: usbip tool: Check the return of get_nports()

2017-04-05 Thread Yuyang Du
If we get nonpositive number of ports, there is no sense to continue, then fail gracefully. In addition, the commit 0775a9cbc694e8c72 ("usbip: vhci extension: modifications to vhci driver") introduced configurable numbers of controllers and ports, but we have a static port number maximum, MAXNPORT

[PATCH v3 2/6] usb: usbip tool: Fix get_nports()

2017-04-05 Thread Yuyang Du
The commit 0775a9cbc694e8c72 ("usbip: vhci extension: modifications to vhci driver") introduced multiple controllers, and nports as a sys file, and claimed to read the nports from it, but it didn't. In addition, the get_nports() has been so wrong that even with 8 port lines for instance, it gets 7

[PATCH v3 4/6] usb: usbip tool: Add ncontrollers in vhci_driver structure

2017-04-05 Thread Yuyang Du
A new field ncontrollers is added to the vhci_driver structure. And this field is stored by scanning the vhci_hcd* dirs in the platform udev. Suggested-by: Krzysztof Opasiak Signed-off-by: Yuyang Du --- tools/usb/usbip/libsrc/vhci_driver.c | 36 tools/usb/us

[PATCH v3 1/6] usb: usbip: Remove unnecessary get_vdev()

2017-04-05 Thread Yuyang Du
vhci_tx_urb() should be able to get the vhci_device from its caller vhci_urb_enqueue(), instead of brutal-force searching it. Reviewed-by: Krzysztof Opasiak Signed-off-by: Yuyang Du Acked-by: Shuah Khan --- drivers/usb/usbip/vhci_hcd.c | 32 ++-- 1 file changed, 2 i

[PATCH v3 6/6] usb: usbip tool: Fix parse_status()

2017-04-05 Thread Yuyang Du
In parse_status(), all nports number of idev's are initiated to 0 by memset(), it is simply wrong, because parse_status() reads the status sys file one by one, therefore, it can only update the according vhci_driver->idev's for it to parse. Reviewed-by: Krzysztof Opasiak Signed-off-by: Yuyang Du

[PATCH v3 5/6] usb: usbip tool: Fix refresh_imported_device_list()

2017-04-05 Thread Yuyang Du
The commit 0775a9cbc694e8c7 ("usbip: vhci extension: modifications to vhci driver") introduced multiple controllers, but the status of the ports are only extracted from the first status file, fix it. Reviewed-by: Krzysztof Opasiak Signed-off-by: Yuyang Du --- tools/usb/usbip/libsrc/vhci_driver.

[PATCH V8 1/4] dt-bindings: phy: Add support for QUSB2 phy

2017-04-05 Thread Vivek Gautam
Qualcomm chipsets have QUSB2 phy controller that provides HighSpeed functionality for DWC3 controller. Adding dt binding information for the same. Signed-off-by: Vivek Gautam Reviewed-by: Stephen Boyd Acked-by: Rob Herring --- Changes since v7: - None, just added Stephen's Reviewed-by tag. C

[PATCH V8 0/4] phy: USB and PCIe phy drivers for Qcom chipsets

2017-04-05 Thread Vivek Gautam
Hi Kishon, Here's the series with fixed checkpatch warnings/checks. Please pick it for phy/next. This patch series adds couple of PHY drivers for Qualcomm chipsets. a) qcom-qusb2 phy driver: that provides High Speed USB functionality. b) qcom-qmp phy driver: that is a combo phy providing support f

[PATCH V8 4/4] phy: qcom-qmp: new qmp phy driver for qcom-chipsets

2017-04-05 Thread Vivek Gautam
Qualcomm SOCs have QMP phy controller that provides support to a number of controller, viz. PCIe, UFS, and USB. Add a new driver, based on generic phy framework, for this phy controller. Signed-off-by: Vivek Gautam Tested-by: Srinivas Kandagatla Reviewed-by: Stephen Boyd --- Changes since v7:

[PATCH V8 3/4] dt-bindings: phy: Add support for QMP phy

2017-04-05 Thread Vivek Gautam
Qualcomm chipsets have QMP phy controller that provides support to a number of controller, viz. PCIe, UFS, and USB. Adding dt binding information for the same. Signed-off-by: Vivek Gautam Reviewed-by: Stephen Boyd Acked-by: Rob Herring --- Changes since v7: - None, just added Stephen's Review

[PATCH V8 2/4] phy: qcom-qusb2: New driver for QUSB2 PHY on Qcom chips

2017-04-05 Thread Vivek Gautam
PHY transceiver driver for QUSB2 phy controller that provides HighSpeed functionality for DWC3 controller present on Qualcomm chipsets. Signed-off-by: Vivek Gautam Reviewed-by: Stephen Boyd --- Changes since v7: - Fixed 'checkpatch --strict' alignment warnings/checks. Changes since v6: - Dro

Re: [PATCH V7 4/4] phy: qcom-qmp: new qmp phy driver for qcom-chipsets

2017-04-05 Thread Stephen Boyd
On 04/05, Vivek Gautam wrote: > Qualcomm SOCs have QMP phy controller that provides support > to a number of controller, viz. PCIe, UFS, and USB. > Add a new driver, based on generic phy framework, for this > phy controller. > > Signed-off-by: Vivek Gautam > Tested-by: Srinivas Kandagatla > ---

Re: [PATCH V7 3/4] dt-bindings: phy: Add support for QMP phy

2017-04-05 Thread Stephen Boyd
On 04/05, Vivek Gautam wrote: > Qualcomm chipsets have QMP phy controller that provides > support to a number of controller, viz. PCIe, UFS, and USB. > Adding dt binding information for the same. > > Signed-off-by: Vivek Gautam > Acked-by: Rob Herring > --- Reviewed-by: Stephen Boyd -- Qualc

Re: [PATCH V7 1/4] dt-bindings: phy: Add support for QUSB2 phy

2017-04-05 Thread Stephen Boyd
On 04/05, Vivek Gautam wrote: > Qualcomm chipsets have QUSB2 phy controller that provides > HighSpeed functionality for DWC3 controller. > Adding dt binding information for the same. > > Signed-off-by: Vivek Gautam > Acked-by: Rob Herring > --- Reviewed-by: Stephen Boyd -- Qualcomm Innovatio

[PATCH v2] ARM: davinci: Add the clock for the CPPI 4.1 DMA engine

2017-04-05 Thread Alexandre Bailon
The CPPI 4.1 DMA is sharing its clock with the USB OTG, and most of the time, the clock will be enabled by USB. But during the init of the DMA, USB is not enabled (waiting for DMA), and then we must enable the clock before doing anything. Add the clock for the CPPI 4.1 DMA engine. Signed-off-by: A

Re: [PATCH] ARM: davinci: Add the clock for the CPPI 4.1 DMA engine

2017-04-05 Thread Alexandre Bailon
On 04/04/2017 08:16 AM, Sekhar Nori wrote: On Wednesday 29 March 2017 09:39 PM, Alexandre Bailon wrote: The CPPI 4.1 DMA is sharing its clock with the USB OTG, and most of the time, the clock will be enabled by USB. But during the init of the DMA, USB is not enabled (waiting for DMA), and then

[PATCH][linux-next] dmaengine: cppi41: Fix an Oops happening in cppi41_dma_probe()

2017-04-05 Thread Alexandre Bailon
This fix an Oops happening on all platforms using the old dt bindings (all platforms but da8xx). This update cppi41_dma_probe() to use the index variable which is required to keep compatibility between old and new dt bindings. Fixes: 8e3ba95f4190 ("dmaengine: cppi41: use managed functions devm_*()

Re: usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8)

2017-04-05 Thread Tony Lindgren
* Tony Lindgren [170405 06:53]: > * Peter Ujfalusi [170405 00:15]: > > To be precise this is what I have tried: > > - boot w/o cable connected > > - boot w/ board connected to PC (device mode) > > - boot w/ OTG-A cable with USB keyboard > > - boot w/ OTG-A cable connected to powered USB hub and t

Re: [PATCH V7 0/4] phy: USB and PCIe phy drivers for Qcom chipsets

2017-04-05 Thread Vivek Gautam
Hi Kishon, On Wed, Apr 5, 2017 at 7:08 PM, Kishon Vijay Abraham I wrote: > Hi Vivek, > > On Wednesday 05 April 2017 06:02 PM, Vivek Gautam wrote: >> This patch series adds couple of PHY drivers for Qualcomm chipsets. >> a) qcom-qusb2 phy driver: that provides High Speed USB functionality. >> b)

Re: [PATCH v3 1/3] usb: udc: allow adding and removing the same gadget device

2017-04-05 Thread Alan Stern
On Wed, 5 Apr 2017, Felipe Balbi wrote: > >> >> --- a/drivers/usb/gadget/udc/core.c > >> >> +++ b/drivers/usb/gadget/udc/core.c > >> >> @@ -1273,6 +1273,7 @@ void usb_del_gadget_udc(struct usb_gadget *gadget) > >> >> flush_work(&gadget->work); > >> >> device_unregister(&udc->dev);

[PATCH 3/3] usb: dwc2: Power off the phy on shutdown

2017-04-05 Thread Sjoerd Simons
On a board with a usb->sata bridge behind a usb hub, the bridge only appears on cold boot and becomes non-functional after a reboot. Testing thusfar shows that it gets confused during reboot if the usb hub is left on (Interestingly a similar setup without the usb hub in between doesn't have the iss

[PATCH 0/3] rockchip dwc2: Turn off vbus on shutdown

2017-04-05 Thread Sjoerd Simons
A board I'm working on seems to get its usb->sata bridge in a rather confused state during reboot, which unfortunately can't be recovered on the next boot (only hard reset helps). This seems to be avoidable by turning off vbus, which turns the internal usb hub off on shutdown. First patch add the

[PATCH v2 24/24] usb: xhci: bInterval quirk for TI TUSB73x0

2017-04-05 Thread Mathias Nyman
From: Roger Quadros As per [1] issue #4, "The periodic EP scheduler always tries to schedule the EPs that have large intervals (interval equal to or greater than 128 microframes) into different microframes. So it maintains an internal counter and increments for each large interval EP added. When

Re: [PATCH v2 3/6] usb: usbip tool: Add ncontrollers in vhci_driver structure

2017-04-05 Thread Krzysztof Opasiak
On 04/05/2017 04:03 AM, Yuyang Du wrote: On Wed, Apr 05, 2017 at 11:46:06AM +0200, Krzysztof Opasiak wrote: On 04/04/2017 09:08 PM, Yuyang Du wrote: Hi Krzysztof, On Tue, Apr 04, 2017 at 04:52:32PM +0200, Krzysztof Opasiak wrote: On 03/31/2017 02:28 AM, Yuyang Du wrote: A new field nco

[PATCH v3] usb: document that URB transfer_buffer should be aligned

2017-04-05 Thread Mauro Carvalho Chehab
Several host controllers, commonly found on ARM, like dwc2, require buffers that are CPU-word aligned for they to work. Failing to do that will cause buffer overflows at the caller drivers, with could cause data corruption. Such data corruption was found, in practice, with the uvcdriver. Documen

Re: usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8)

2017-04-05 Thread Tony Lindgren
* Peter Ujfalusi [170405 00:15]: > Tony, > > On 2017-04-05 03:36, Tony Lindgren wrote: > > * Tony Lindgren [170404 07:06]: > > > * Bin Liu [170404 05:30]: > > > > On Tue, Apr 04, 2017 at 10:09:50AM +0300, Peter Ujfalusi wrote: > > > > > Tony, > > > > > > > > > > since 4.9 (4.8 was fine) I can

Re: [PATCH V7 0/4] phy: USB and PCIe phy drivers for Qcom chipsets

2017-04-05 Thread Kishon Vijay Abraham I
Hi Vivek, On Wednesday 05 April 2017 06:02 PM, Vivek Gautam wrote: > This patch series adds couple of PHY drivers for Qualcomm chipsets. > a) qcom-qusb2 phy driver: that provides High Speed USB functionality. > b) qcom-qmp phy driver: that is a combo phy providing support for >USB3, PCIe, UFS

[PATCH v2 21/21] docs-rst: fix usb cross-references

2017-04-05 Thread Mauro Carvalho Chehab
As some USB documentation files got moved, adjust their cross-references to their new place. Signed-off-by: Mauro Carvalho Chehab --- Documentation/ABI/stable/sysfs-bus-usb| 2 +- Documentation/driver-api/usb/URB.rst | 2 ++ Documentation/driver-api/usb/callbacks.rst

[PATCH v2 13/21] error-codes.rst: convert to ReST and add to driver-api book

2017-04-05 Thread Mauro Carvalho Chehab
This document describe some USB core features. Add it to the driver-api book. Signed-off-by: Mauro Carvalho Chehab --- Documentation/driver-api/usb/error-codes.rst | 205 +++ Documentation/driver-api/usb/index.rst | 1 + Documentation/usb/error-codes.txt

[PATCH v2 08/21] usb/anchors.txt: convert to ReST and add to driver-api book

2017-04-05 Thread Mauro Carvalho Chehab
This document describe some USB core functions. Add it to the driver-api book. Signed-off-by: Mauro Carvalho Chehab --- .../anchors.txt => driver-api/usb/anchors.rst} | 36 -- Documentation/driver-api/usb/index.rst | 1 + 2 files changed, 21 insertions(+), 16

[PATCH v2 04/21] usb.rst: Enrich its ReST representation

2017-04-05 Thread Mauro Carvalho Chehab
- use the proper warning and note markups; - add references for parts of the document that will be cross-referenced on other USB docs; - some minor adjustments to make it better to read in text mode and in html. Signed-off-by: Mauro Carvalho Chehab --- Documentation/driver-api/usb/usb.rst |

[PATCH v2 02/21] driver-api/basics.rst: add device table header

2017-04-05 Thread Mauro Carvalho Chehab
The structs there at device table are used by other documentation at the Kernel. So, add it to the driver API. Signed-off-by: Mauro Carvalho Chehab --- Documentation/driver-api/basics.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/driver-api/basics.rst b/Documentati

[PATCH v2 09/21] usb/bulk-streams.txt: convert to ReST and add to driver-api book

2017-04-05 Thread Mauro Carvalho Chehab
This document describe some USB core functions. Add it to the driver-api book. Signed-off-by: Mauro Carvalho Chehab --- .../bulk-streams.txt => driver-api/usb/bulk-streams.rst}| 13 + Documentation/driver-api/usb/index.rst | 1 + 2 files changed, 10 insertio

[PATCH v2 12/21] usb/dma.txt: convert to ReST and add to driver-api book

2017-04-05 Thread Mauro Carvalho Chehab
This document describe some USB core features. Add it to the driver-api book. Signed-off-by: Mauro Carvalho Chehab --- .../{usb/dma.txt => driver-api/usb/dma.rst}| 51 -- Documentation/driver-api/usb/index.rst | 1 + 2 files changed, 28 insertions(+), 24

[PATCH v2 17/21] usb.rst: get rid of some Sphinx errors

2017-04-05 Thread Mauro Carvalho Chehab
Get rid of those warnings: Documentation/driver-api/usb/usb.rst:615: ERROR: Unknown target name: "usb_type". Documentation/driver-api/usb/usb.rst:615: ERROR: Unknown target name: "usb_dir". Documentation/driver-api/usb/usb.rst:615: ERROR: Unknown target name: "usb_recip". Docume

[PATCH v2 18/21] usb: get rid of some ReST doc build errors

2017-04-05 Thread Mauro Carvalho Chehab
We need an space before a numbered list to avoid those warnings: ./drivers/usb/core/message.c:478: ERROR: Unexpected indentation. ./drivers/usb/core/message.c:479: WARNING: Block quote ends without a blank line; unexpected unindent. ./include/linux/usb/composite.h:455: ERROR: Unexpected indentati

[PATCH v2 19/21] usb: composite.h: fix two warnings when building docs

2017-04-05 Thread Mauro Carvalho Chehab
By definition, we use /* private: */ tag when we won't be documenting a parameter. However, those two parameters are documented: ./include/linux/usb/composite.h:510: warning: Excess struct/union/enum/typedef member 'setup_pending' description in 'usb_composite_dev' ./include/linux/usb/composite.h

[PATCH v2 15/21] usb/persist.txt: convert to ReST and add to driver-api book

2017-04-05 Thread Mauro Carvalho Chehab
This document describe some USB core features. Add it to the driver-api book. Signed-off-by: Mauro Carvalho Chehab --- Documentation/driver-api/usb/index.rst | 1 + .../persist.txt => driver-api/usb/persist.rst} | 22 +- 2 files changed, 14 insertions(+), 9 d

[PATCH v2 10/21] usb/callbacks.txt: convert to ReST and add to driver-api book

2017-04-05 Thread Mauro Carvalho Chehab
This document describe some USB core functions. Add it to the driver-api book. Signed-off-by: Mauro Carvalho Chehab --- .../callbacks.txt => driver-api/usb/callbacks.rst} | 61 +++--- Documentation/driver-api/usb/index.rst | 1 + 2 files changed, 43 insertions(+), 19

[PATCH v2 14/21] usb/hotplug.txt: convert to ReST and add to driver-api book

2017-04-05 Thread Mauro Carvalho Chehab
This document describe some USB core features. Add it to the driver-api book. Signed-off-by: Mauro Carvalho Chehab --- .../hotplug.txt => driver-api/usb/hotplug.rst} | 66 -- Documentation/driver-api/usb/index.rst | 1 + 2 files changed, 37 insertions(+), 30

[PATCH v2 01/21] tmplcvt: make the tool more robust

2017-04-05 Thread Mauro Carvalho Chehab
Currently, the script just assumes to be called at Documentation/sphinx/. Change it to work on any directory, and make it abort if something gets wrong. Also, be sure that both parameters are specified. That should avoid troubles like this: $ Documentation/sphinx/tmplcvt Documentation/DocBook/wr

[PATCH v2 20/21] usb: gadget.h: be consistent at kernel doc macros

2017-04-05 Thread Mauro Carvalho Chehab
There's one value that use spaces instead of tabs to ident. That causes the following warning: ./include/linux/usb/gadget.h:193: ERROR: Unexpected indentation. Signed-off-by: Mauro Carvalho Chehab --- include/linux/usb/gadget.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v2 00/21] Convert USB documentation to ReST format

2017-04-05 Thread Mauro Carvalho Chehab
Currently, there are several USB core documents that are at either written in plain text or in DocBook format. Convert them to ReST and add to the driver-api book. Mauro Carvalho Chehab (21): tmplcvt: make the tool more robust driver-api/basics.rst: add device table header docs-rst: convert

[PATCH v2 05/21] gadget.rst: Enrich its ReST representation and add kernel-doc tag

2017-04-05 Thread Mauro Carvalho Chehab
The pandoc conversion is not perfect. Do handwork in order to: - add a title to this chapter; - use the proper warning and note markups; - use kernel-doc to include Kernel header and c files; - remove legacy notes with regards to DocBook; - some other minor adjustments to make it better to read in

[PATCH v2 11/21] usb/power-management.txt: convert to ReST and add to driver-api book

2017-04-05 Thread Mauro Carvalho Chehab
This document describe some USB core functions. Add it to the driver-api book. Signed-off-by: Mauro Carvalho Chehab --- Documentation/driver-api/usb/index.rst | 1 + .../usb/power-management.rst} | 404 +++-- 2 files changed, 214 insertions(+),

[PATCH v2 07/21] writing_musb_glue_layer.rst: Enrich its ReST representation

2017-04-05 Thread Mauro Carvalho Chehab
This file is actually quite complex, and required several manual handwork: - add a title for the document; - use the right tags for monospaced fonts; - use c references where needed; - adjust cross-reference to writing_usb_driver.rst - hightlight cross-referenced lines. With regards to C code sni

[PATCH v2 16/21] usb/URB.txt: convert to ReST and update it

2017-04-05 Thread Mauro Carvalho Chehab
The URB doc describes the Kernel mechanism that do USB transfers. While the functions are already described at urb.h, there are a number of concepts and theory that are important for USB driver developers. Convert it to ReST and use C ref links to point to the places at usb.h where each function a

[PATCH v2 06/21] writing_usb_driver.rst: Enrich its ReST representation

2017-04-05 Thread Mauro Carvalho Chehab
The pandoc conversion is not perfect. Do handwork in order to: - add a title to this chapter; - adjust function and struct references; - use monospaced fonts for C code names; - some other minor adjustments to make it better to read in text mode and in html. Signed-off-by: Mauro Carvalho Chehab

Re: dwc2_hc_chhltd_intr_dma - ChHltd set errors?

2017-04-05 Thread Minas Harutyunyan
Hi, On 4/4/2017 11:03 PM, John Stultz wrote: > On Tue, Apr 4, 2017 at 12:38 AM, Felipe Balbi > wrote: >> >> Hi, >> >> Minas Harutyunyan writes: We've noticed that when using usb ethernet adapters on HiKey, we occasionally see errors like: dwc2 f72c.usb:

Re: [PATCH v2 01/22] tmplcvt: make the tool more robust

2017-04-05 Thread Mauro Carvalho Chehab
Em Sun, 2 Apr 2017 15:32:31 -0600 Jonathan Corbet escreveu: > On Thu, 30 Mar 2017 07:45:35 -0300 > Mauro Carvalho Chehab wrote: > > > Currently, the script just assumes to be called at > > Documentation/sphinx/. Change it to work on any directory, > > and make it abort if something gets wrong.

Re: [PATCH linux-next v3 2/4] usb: gadget: udc: atmel: Minor code cleanup

2017-04-05 Thread Felipe Balbi
Hi, cristian.bir...@microchip.com writes: > From: Cristian Birsan > > Minor code cleanup based on feedback received on mailinglist. > > Signed-off-by: Cristian Birsan > Acked-by: Nicolas Ferre patch 1 applied fine, patch 2 didn't. Please rebase on testing/next -- balbi signature.asc Descr

[PATCH V7 4/4] phy: qcom-qmp: new qmp phy driver for qcom-chipsets

2017-04-05 Thread Vivek Gautam
Qualcomm SOCs have QMP phy controller that provides support to a number of controller, viz. PCIe, UFS, and USB. Add a new driver, based on generic phy framework, for this phy controller. Signed-off-by: Vivek Gautam Tested-by: Srinivas Kandagatla --- Changes since v6: - Rebased on phy/next and

[PATCH V7 3/4] dt-bindings: phy: Add support for QMP phy

2017-04-05 Thread Vivek Gautam
Qualcomm chipsets have QMP phy controller that provides support to a number of controller, viz. PCIe, UFS, and USB. Adding dt binding information for the same. Signed-off-by: Vivek Gautam Acked-by: Rob Herring --- Changes since v6: - none. Changes since v5: - Added Rob's 'Ack' for the new ch

[PATCH V7 1/4] dt-bindings: phy: Add support for QUSB2 phy

2017-04-05 Thread Vivek Gautam
Qualcomm chipsets have QUSB2 phy controller that provides HighSpeed functionality for DWC3 controller. Adding dt binding information for the same. Signed-off-by: Vivek Gautam Acked-by: Rob Herring --- Changes since v6: - Dropped 'vdd-phy-supply' that used pm8994_s2 regulator, from bindings.

[PATCH V7 2/4] phy: qcom-qusb2: New driver for QUSB2 PHY on Qcom chips

2017-04-05 Thread Vivek Gautam
PHY transceiver driver for QUSB2 phy controller that provides HighSpeed functionality for DWC3 controller present on Qualcomm chipsets. Signed-off-by: Vivek Gautam Reviewed-by: Stephen Boyd --- Changes since v6: - Dropped 'vdd-phy' from list of regulators. - Rebased on phy/next and *not* incl

[PATCH V7 0/4] phy: USB and PCIe phy drivers for Qcom chipsets

2017-04-05 Thread Vivek Gautam
This patch series adds couple of PHY drivers for Qualcomm chipsets. a) qcom-qusb2 phy driver: that provides High Speed USB functionality. b) qcom-qmp phy driver: that is a combo phy providing support for USB3, PCIe, UFS and few other controllers. The patches are based on next branch of linux-ph

Re: [PATCH v2 1/2] usb: gadget: udc: avoid use of freed pointer

2017-04-05 Thread Felipe Balbi
Hi, "Gustavo A. R. Silva" writes: > Rewrite udc_free_dma_chain() function to avoid use of pointer after free. > > Addresses-Coverity-ID: 1091172 > Acked-by: Michal Nazarewicz > Reviewed-by: Greg Kroah-Hartman > Signed-off-by: Gustavo A. R. Silva doesn't apply to testing/next. Care to rebase?

Re: [PATCH v4 0/3] phy: Group phy drivers based on vendor listing

2017-04-05 Thread Kishon Vijay Abraham I
Hi Vivek, On Wednesday 05 April 2017 05:07 PM, Vivek Gautam wrote: > Hi Kishon, > > > On 04/05/2017 04:34 PM, Kishon Vijay Abraham I wrote: >> Hi Vivek, >> >> On Monday 20 March 2017 06:49 PM, Vivek Gautam wrote: >>> This is the next version to an earlier posted series [1]. >>> Missed Cc'ing the

Re: [PATCH v3 0/3] add support of usb2-phy for rk3328

2017-04-05 Thread Kishon Vijay Abraham I
On Monday 06 March 2017 06:59 AM, Meng Dongyang wrote: > The config information of RK3328 about address and port property > is different from other platform. So adds config information in the > data of match table and the device tree bindings description for > usb2-phy. > > Changes in v2: > - m

Re: Fw: New Defects reported by Coverity Scan for Linux

2017-04-05 Thread Oliver Neukum
Am Dienstag, den 04.04.2017, 13:55 +0200 schrieb Bjørn Mork: > Oliver Neukum writes: > > > > Am Montag, den 03.04.2017, 12:48 -0700 schrieb Stephen Hemminger: > > > > > > Looks like new warnings in usbnet > > > > > > > > > ** CID 751368: Null pointer dereferences (FORWARD_NULL) > > > /driver

Re: [PATCH v4 0/3] phy: Group phy drivers based on vendor listing

2017-04-05 Thread Kishon Vijay Abraham I
Hi Vivek, On Monday 20 March 2017 06:49 PM, Vivek Gautam wrote: > This is the next version to an earlier posted series [1]. > Missed Cc'ing the first patch of the previous series [1] to lkml. > Posting out this series now after addressing comments > and after adding the received 'Acked-by' and 'Re

Re: [PATCH v2 3/6] usb: usbip tool: Add ncontrollers in vhci_driver structure

2017-04-05 Thread Yuyang Du
On Wed, Apr 05, 2017 at 11:46:06AM +0200, Krzysztof Opasiak wrote: > > > On 04/04/2017 09:08 PM, Yuyang Du wrote: > >Hi Krzysztof, > > > >On Tue, Apr 04, 2017 at 04:52:32PM +0200, Krzysztof Opasiak wrote: > >> > >> > >>On 03/31/2017 02:28 AM, Yuyang Du wrote: > >>>A new field ncontrollers is adde

Re: Periodic reconnects of USB mouse on Dell PowerEdge R730

2017-04-05 Thread Oliver Neukum
Am Mittwoch, den 05.04.2017, 11:14 +0200 schrieb Paul Menzel: Hi, > > > but did anything come out of this? Do we need to add a quirk? > > Dell said they tried to reproduce this, and couldn’t. Maybe it’s mouse > dependent, there are different revisions, and the ID stays the same. Could you tes

Re: Periodic reconnects of USB mouse on Dell PowerEdge R730

2017-04-05 Thread Johan Hovold
On Wed, Apr 05, 2017 at 11:14:49AM +0200, Paul Menzel wrote: > On 04/05/17 10:31, Oliver Neukum wrote: > > but did anything come out of this? Do we need to add a quirk? > > Dell said they tried to reproduce this, and couldn’t. Maybe it’s mouse > dependent, there are different revisions, and the

Re: Periodic reconnects of USB mouse on Dell PowerEdge R730

2017-04-05 Thread Paul Menzel
Dear Johan, On 04/05/17 11:49, Johan Hovold wrote: On Wed, Apr 05, 2017 at 11:14:49AM +0200, Paul Menzel wrote: On 04/05/17 10:31, Oliver Neukum wrote: but did anything come out of this? Do we need to add a quirk? Dell said they tried to reproduce this, and couldn’t. Maybe it’s mouse dep

Re: [PATCH v2 3/6] usb: usbip tool: Add ncontrollers in vhci_driver structure

2017-04-05 Thread Krzysztof Opasiak
On 04/04/2017 09:08 PM, Yuyang Du wrote: Hi Krzysztof, On Tue, Apr 04, 2017 at 04:52:32PM +0200, Krzysztof Opasiak wrote: On 03/31/2017 02:28 AM, Yuyang Du wrote: A new field ncontrollers is added to the vhci_driver structure. And this field is stored by scanning the vhci_hcd* dirs in the

Re: Periodic reconnects of USB mouse on Dell PowerEdge R730

2017-04-05 Thread Paul Menzel
Dear Oliver, On 04/05/17 10:31, Oliver Neukum wrote: Am Donnerstag, den 09.02.2017, 17:30 +0100 schrieb Paul Menzel: On 02/08/17 17:54, Johan Hovold wrote: On Wed, Feb 08, 2017 at 05:41:33PM +0100, Paul Menzel wrote: On 02/08/17 16:50, Johan Hovold wrote: On Wed, Feb 08, 2017 at 04:15:

Re: [PATCH v6 1/4] dt-bindings: phy: Add support for QUSB2 phy

2017-04-05 Thread Vivek Gautam
On 04/04/2017 11:58 PM, Stephen Boyd wrote: On 03/20, Vivek Gautam wrote: diff --git a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt new file mode 100644 index ..a6d19acde9e0 --- /dev/null +++ b/Documentation/de

Re: [PATCH 24/24] usb: xhci: bInterval quirk for TI TUSB73x0

2017-04-05 Thread Oliver Neukum
Am Dienstag, den 04.04.2017, 15:55 +0300 schrieb Mathias Nyman: > From: Roger Quadros > > This results in Bandwidth error when devices with periodic > endpoints (ISO/INT) having bInterval > 7 are plugged and > unplugged several times on a TUSB73x0 XHCI host. > > Workaround this issue by limiting

Re: [PATCH v3 1/3] usb: udc: allow adding and removing the same gadget device

2017-04-05 Thread Felipe Balbi
Hi, Alan Stern writes: >> >> allow usb_del_gadget_udc() and usb add_gadget_udc() to be called >> >> repeatedly on the same gadget->dev structure. >> >> >> >> We need to clear the gadget->dev structure so that kobject_init() >> >> doesn't complain about already initialized object. >> >> >> >> S

Re: [PATCH] usb: dwc3: gadget: skip Set/Clear Halt when invalid

2017-04-05 Thread Felipe Balbi
Hi, John Youn writes: >> Felipe Balbi writes: >>> At least macOS seems to be sending >>> ClearFeature(ENDPOINT_HALT) to endpoints which >>> aren't Halted. This makes DWC3's CLEARSTALL command >>> time out which causes several issues for the driver. >>> >>> Instead, let's just return 0 and bail

Re: Periodic reconnects of USB mouse on Dell PowerEdge R730

2017-04-05 Thread Oliver Neukum
Am Donnerstag, den 09.02.2017, 17:30 +0100 schrieb Paul Menzel: > Dear Johan, > > > On 02/08/17 17:54, Johan Hovold wrote: > > > > On Wed, Feb 08, 2017 at 05:41:33PM +0100, Paul Menzel wrote: > > > > > > On 02/08/17 16:50, Johan Hovold wrote: > > > > > > > > On Wed, Feb 08, 2017 at 04:15:02PM

Re: [PATCH v7 2/3] usb: musb: Add support of CPPI 4.1 DMA controller to DA8xx

2017-04-05 Thread Alexandre Bailon
On 04/03/2017 04:59 PM, Bin Liu wrote: On Wed, Mar 29, 2017 at 06:24:31PM +0200, Alexandre Bailon wrote: Currently, only the PIO mode is supported. This add support of CPPI 4.1 to DA8xx. As the In DA8xx the CPPI 4.1 DMA is a part of the USB. Create the CPPI 4.1 device as a child of USB. Signed-

Re: [1/2] wireless: ath9k_htc: fix NULL-deref at probe

2017-04-05 Thread Kalle Valo
Johan Hovold wrote: > Make sure to check the number of endpoints to avoid dereferencing a > NULL-pointer or accessing memory beyond the endpoint array should a > malicious device lack the expected endpoints. > > Fixes: 36bcce430657 ("ath9k_htc: Handle storage devices") > Cc: Sujith Manoharan > S

Re: usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8)

2017-04-05 Thread Peter Ujfalusi
On 2017-04-05 10:13, Peter Ujfalusi wrote: I had similar hunch first, but did not worked. I have tested this patch and did not helped. To be precise this is what I have tried: - boot w/o cable connected - boot w/ board connected to PC (device mode) - boot w/ OTG-A cable with USB keyboard - boot

Re: usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8)

2017-04-05 Thread Peter Ujfalusi
Tony, On 2017-04-05 03:36, Tony Lindgren wrote: * Tony Lindgren [170404 07:06]: * Bin Liu [170404 05:30]: On Tue, Apr 04, 2017 at 10:09:50AM +0300, Peter Ujfalusi wrote: Tony, since 4.9 (4.8 was fine) I can not boot omap4-panda-es if the musb is compiled in. The kernel will stuck printing: