Re: Bug in DWC2 UDC driver on Raspberry PI [was: g_mass_storage emulation of flash drive - difficulties with passing vendor/product ID]

2017-07-10 Thread Alan Robertson
On Mon, Jul 10, 2017 at 11:09 PM, Alan Robertson wrote: > On Mon, Jul 10, 2017 at 5:43 PM, Alan Robertson > wrote: >> On Mon, Jul 10, 2017 at 3:46 PM, Alan Stern >> wrote: >>> On Mon, 10 Jul 2017, Alan Robertson

Re: Bug in DWC2 UDC driver on Raspberry PI [was: g_mass_storage emulation of flash drive - difficulties with passing vendor/product ID]

2017-07-10 Thread Alan Robertson
On Mon, Jul 10, 2017 at 5:43 PM, Alan Robertson wrote: > On Mon, Jul 10, 2017 at 3:46 PM, Alan Stern wrote: >> On Mon, 10 Jul 2017, Alan Robertson wrote: >> >>> On Sat, Jul 8, 2017 at 5:26 PM, Alan Robertson >>>

RE: [PATCH v5] xhci: Bad Ethernet performance plugged in ASM1042A host

2017-07-10 Thread Mario.Limonciello
> -Original Message- > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Monday, July 10, 2017 3:57 PM > To: Limonciello, Mario > Cc: Mathias Nyman ; USB u...@vger.kernel.org>; mathias.ny...@intel.com;

Re: [PATCH v5] xhci: Bad Ethernet performance plugged in ASM1042A host

2017-07-10 Thread Andy Shevchenko
On Mon, Jul 10, 2017 at 11:38 PM, wrote: >> -Original Message- >> From: Jiahau Chang [mailto:jia...@gmail.com] >> Sent: Thursday, July 6, 2017 8:58 PM >> To: Mathias Nyman >> Cc: linux-usb@vger.kernel.org;

RE: [PATCH v5] xhci: Bad Ethernet performance plugged in ASM1042A host

2017-07-10 Thread Mario.Limonciello
> -Original Message- > From: Jiahau Chang [mailto:jia...@gmail.com] > Sent: Thursday, July 6, 2017 8:58 PM > To: Mathias Nyman > Cc: linux-usb@vger.kernel.org; mathias.ny...@intel.com; > david.lai...@aculab.com; gre...@linuxfoundation.org; >

Re: JMS567 USB3.0 scsi scan error

2017-07-10 Thread Alan Stern
On Mon, 10 Jul 2017, Oliver Neukum wrote: > > > The old storage driver unconditionally limits inquiries to 36 bytes. UAS > > > does not > > > have that limit. That seems to be a bit optimistic. Could you test the > > > attached patch? > > > > If there's no particular benefit to 96-byte

Re: [PATCH] usb: isp1760: compress return logic into one line

2017-07-10 Thread Gustavo A. R. Silva
Hi Oliver, Quoting Oliver Neukum : Am Sonntag, den 09.07.2017, 21:00 -0500 schrieb Gustavo A. R. Silva : Simplify return logic to avoid unnecessary variable assignment. This issue was detected using Coccinelle and the following semantic patch: Hi, I need to ask: Where

Re: JMS567 USB3.0 scsi scan error

2017-07-10 Thread Oliver Neukum
Am Montag, den 10.07.2017, 10:30 -0400 schrieb Alan Stern: > On Mon, 10 Jul 2017, Oliver Neukum wrote: > > > Am Donnerstag, den 06.07.2017, 14:32 -0700 schrieb Grégoire Gentil : > > > > Hi, > > > > > This might be a follow-up of: > > > https://www.spinics.net/lists/linux-usb/msg157437.html > >

Re: [PATCH 0/2] Workaround for uPD72020x USB3 chips

2017-07-10 Thread Ard Biesheuvel
On 10 July 2017 at 16:52, Marc Zyngier wrote: > Ard and myself have just spent quite some time lately trying to pin > down an issue in the DMA code which was taking the form of a PCIe USB3 > controller issuing a DMA access at some bizarre address, and being > caught

Re: Bug in DWC2 UDC driver on Raspberry PI [was: g_mass_storage emulation of flash drive - difficulties with passing vendor/product ID]

2017-07-10 Thread Alan Robertson
On Mon, Jul 10, 2017 at 3:46 PM, Alan Stern wrote: > On Mon, 10 Jul 2017, Alan Robertson wrote: > >> On Sat, Jul 8, 2017 at 5:26 PM, Alan Robertson >> wrote: >> > On Sat, Jul 8, 2017 at 4:52 PM, Alan Stern >> >

[PATCH 1/2] PCI: Implement pci_reset_function_locked

2017-07-10 Thread Marc Zyngier
The implementation of PCI workarounds may require that the device is reset from its probe function. This implies that the PCI device lock is already held, and makes calling pci_reset_function impossible (since it will itself try to take that lock). This patch introduces pci_reset_function_locked,

[PATCH 2/2] usb: host: pci_quirks: Force hard reset of Renesas uPD72020x USB controller

2017-07-10 Thread Marc Zyngier
The Renesas uPD72020x XHCI controller seems to suffer from a really annoying bug, where it may retain some of its DMA programming across a XHCI reset, and despite the driver correctly programming new DMA addresses. This is visible if the device has been using 64bit DMA addresses, and is then

Re: [PATCH] usb: dwc2: gadget: On disconnect reset device address to zero

2017-07-10 Thread Minas Harutyunyan
Hi Filipe, On 7/10/2017 6:14 PM, Felipe Balbi wrote: > > Hi again, > > Felipe Balbi writes: >> Hi, >> >> Minas Harutyunyan writes: >>> USB CV driver stack doesn't perform USB RESET after device disconnect/ >>> connect, so need to reset to zero

Re: [PATCH] usb: dwc2: gadget: On disconnect reset device address to zero

2017-07-10 Thread Minas Harutyunyan
Hi Filipe, On 7/10/2017 6:06 PM, Felipe Balbi wrote: > > Hi, > > Minas Harutyunyan writes: >> USB CV driver stack doesn't perform USB RESET after device disconnect/ >> connect, so need to reset to zero DEVADDR field in DCFG to pass >> enumeration again. >> >>

Bug in DWC2 UDC driver on Raspberry PI [was: g_mass_storage emulation of flash drive - difficulties with passing vendor/product ID]

2017-07-10 Thread Alan Stern
On Mon, 10 Jul 2017, Alan Robertson wrote: > On Sat, Jul 8, 2017 at 5:26 PM, Alan Robertson > wrote: > > On Sat, Jul 8, 2017 at 4:52 PM, Alan Stern > > wrote: > >> On Sat, 8 Jul 2017, Alan Robertson wrote: > >> > >>> On Sat, Jul 8, 2017 at

Re: JMS567 USB3.0 scsi scan error

2017-07-10 Thread Alan Stern
On Mon, 10 Jul 2017, Oliver Neukum wrote: > Am Donnerstag, den 06.07.2017, 14:32 -0700 schrieb Grégoire Gentil : > > Hi, > > > This might be a follow-up of: > > https://www.spinics.net/lists/linux-usb/msg157437.html > > https://www.spinics.net/lists/linux-usb/msg153647.html > > It does not

Re: [PATCH] usb: dwc2: gadget: On disconnect reset device address to zero

2017-07-10 Thread Felipe Balbi
Hi again, Felipe Balbi writes: > Hi, > > Minas Harutyunyan writes: >> USB CV driver stack doesn't perform USB RESET after device disconnect/ >> connect, so need to reset to zero DEVADDR field in DCFG to pass >> enumeration again. >> >>

Re: [PATCH] usb: dwc2: gadget: On disconnect reset device address to zero

2017-07-10 Thread Felipe Balbi
Hi, Minas Harutyunyan writes: > USB CV driver stack doesn't perform USB RESET after device disconnect/ > connect, so need to reset to zero DEVADDR field in DCFG to pass > enumeration again. > > Signed-off-by: Minas Harutyunyan > --- >

Re: g_mass_storage emulation of flash drive - difficulties with passing vendor/product ID

2017-07-10 Thread Alan Robertson
On Sat, Jul 8, 2017 at 5:26 PM, Alan Robertson wrote: > On Sat, Jul 8, 2017 at 4:52 PM, Alan Stern wrote: >> On Sat, 8 Jul 2017, Alan Robertson wrote: >> >>> On Sat, Jul 8, 2017 at 2:04 AM, Alan Stern >>> wrote: >>>

Re: g_mass_storage emulation of flash drive - difficulties with passing vendor/product ID

2017-07-10 Thread Alan Robertson
On Mon, Jul 10, 2017 at 11:07 AM, Felipe Balbi wrote: > > Hi, > > Paul Zimmerman writes: > > Did you try enabling verbose debugging in g_mass_storage? This > > requires setting CONFIG_USB_GADGET_DEBUG and CONFIG_USB_GADGET_VERBOSE >

Re: JMS567 USB3.0 scsi scan error

2017-07-10 Thread Oliver Neukum
Am Donnerstag, den 06.07.2017, 14:32 -0700 schrieb Grégoire Gentil : Hi, > This might be a follow-up of: > https://www.spinics.net/lists/linux-usb/msg157437.html > https://www.spinics.net/lists/linux-usb/msg153647.html It does not look like that. > I have bought this adapter: >

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

2017-07-10 Thread Johan Hovold
On Thu, Jul 06, 2017 at 10:49:16PM +0200, Anatolij Gustschin wrote: > Add USB part with common functions for USB-GPIO/I2C/SPI master > adapters. These allow communication with chip's control, transmit > and receive endpoints and will be used by various FT232H drivers. > +static const struct

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

2017-07-10 Thread Johan Hovold
On Fri, Jul 07, 2017 at 11:53:29AM +0200, Anatolij Gustschin wrote: > On Fri, 07 Jul 2017 09:48:48 +0200 > Bjørn Mork bj...@mork.no wrote: > > >[adding Johan on the CC list] > > > >Anatolij Gustschin writes: > > > >> +static struct usb_device_id ftdi_mfd_table[] = { > >> + {

Re: [PATCH 1/2] usb: core: unlink urbs from the tail of the endpoint's urb_list

2017-07-10 Thread Bin Liu
On Fri, Jul 07, 2017 at 08:19:08PM -0400, Alan Stern wrote: > On Fri, 7 Jul 2017, Bin Liu wrote: > > > On Fri, Jul 07, 2017 at 11:56:53AM -0400, Alan Stern wrote: > > > On Fri, 7 Jul 2017, Bin Liu wrote: > > > > > > > While unlink an urb, if the urb has been programmed in the controller, > > > >

Re: Warning dump on OMAP-L138 when g_zero module is removed

2017-07-10 Thread Sekhar Nori
On Thursday 06 July 2017 10:43 PM, Alexandre Bailon wrote: > On 06/29/2017 03:50 PM, Sekhar Nori wrote: >> Hi Alexandre, Bin, >> >> With latest linux-next, I see a warning dump when I remove g_zero[1] on >> OMAP-L138 LCDK board. I am building the kernel with davinci_all_defconfig. >> >> It is not

Re: g_mass_storage emulation of flash drive - difficulties with passing vendor/product ID

2017-07-10 Thread Felipe Balbi
Hi, Paul Zimmerman writes: > Did you try enabling verbose debugging in g_mass_storage? This > requires setting CONFIG_USB_GADGET_DEBUG and CONFIG_USB_GADGET_VERBOSE > in the kernel configuration and then rebuilding g_mass_storage.ko. > And at runtime you

Re: [PATCH] usb: isp1760: compress return logic into one line

2017-07-10 Thread Oliver Neukum
Am Sonntag, den 09.07.2017, 21:00 -0500 schrieb Gustavo A. R. Silva : > Simplify return logic to avoid unnecessary variable assignment. > > This issue was detected using Coccinelle and the following > semantic patch: > Hi, I need to ask: Where is the improvement? The compiler does not bother

Re: [PATCH] usb: gadget: udc-xilinx: compress return logic into one line

2017-07-10 Thread Michal Simek
On 10.7.2017 05:04, Gustavo A. R. Silva wrote: > Simplify return logic to avoid unnecessary variable assignment. > > This issue was detected using Coccinelle and the following > semantic patch: > > @@ > local idexpression ret; > expression e; > @@ > > -ret = > +return > e; > -return ret; >