Re: [PATCH 1/2] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

2017-07-20 Thread Baolin Wang
Hi Manu, On 20 July 2017 at 19:12, Manu Gautam wrote: > Hi, > > > On 7/13/2017 1:13 PM, Baolin Wang wrote: >> Hi, >> >> On 13 July 2017 at 15:26, Manu Gautam wrote: >>> >>> On 7/13/2017 11:33 AM, Baolin Wang wrote: On 12 July 2017 at 16:58,

Re: xhci_hcd 0000:00:14.0: WARN Event TRB for slot 1 ep 2 with no TDs queued?

2017-07-20 Thread Yaroslav Isakov
Yes, I can definitely test the patch 2017-07-20 19:16 GMT+03:00 Mathias Nyman : > On 20.07.2017 18:07, Yaroslav Isakov wrote: >> >> Here it is >> >> 2017-07-20 18:06 GMT+03:00 Mathias Nyman : >>> >>> On 20.07.2017 17:43, Yaroslav

Re: xhci_hcd 0000:00:14.0: WARN Event TRB for slot 1 ep 2 with no TDs queued?

2017-07-20 Thread Mathias Nyman
On 20.07.2017 18:07, Yaroslav Isakov wrote: Here it is 2017-07-20 18:06 GMT+03:00 Mathias Nyman : On 20.07.2017 17:43, Yaroslav Isakov wrote: Hello everyone! I saw this thread some months ago, but do not know how to properly reply to it. I have the same

Re: [PATCH 2/2] usb: dwc3: pci: Runtime resume child device from wq

2017-07-20 Thread Manu Gautam
Hi, On 7/3/2017 4:55 PM, Manu Gautam wrote: > Driver currently resumes and increments pm usage_count > of its child device (dwc3 main) from its runtime_resume > handler. This requires dwc3 runtime_resume to perform > pm_runtime_put to decrement the pm usage_count. However > runtime_put from dwc3

Re: xhci_hcd 0000:00:14.0: WARN Event TRB for slot 1 ep 2 with no TDs queued?

2017-07-20 Thread Yaroslav Isakov
Here it is 2017-07-20 18:06 GMT+03:00 Mathias Nyman : > On 20.07.2017 17:43, Yaroslav Isakov wrote: >> >> Hello everyone! I saw this thread some months ago, but do not know how >> to properly reply to it. I have the same problem, and it's just not >> few messages -

Re: xhci_hcd 0000:00:14.0: WARN Event TRB for slot 1 ep 2 with no TDs queued?

2017-07-20 Thread Mathias Nyman
On 20.07.2017 17:43, Yaroslav Isakov wrote: Hello everyone! I saw this thread some months ago, but do not know how to properly reply to it. I have the same problem, and it's just not few messages - it was about 40k messages in 10 minutes. No functional of my USB device (which is CCID USB token)

xhci_hcd 0000:00:14.0: WARN Event TRB for slot 1 ep 2 with no TDs queued?

2017-07-20 Thread Yaroslav Isakov
Hello everyone! I saw this thread some months ago, but do not know how to properly reply to it. I have the same problem, and it's just not few messages - it was about 40k messages in 10 minutes. No functional of my USB device (which is CCID USB token) is broken, just enormous amount of spam in the

Re: [PATCH] powerpc/asm/cacheflush: Cleanup cacheflush function params

2017-07-20 Thread Michael Ellerman
Geert Uytterhoeven writes: > On Thu, Jul 20, 2017 at 1:43 PM, Michael Ellerman wrote: >> Matt Brown writes: >>> The cacheflush prototypes currently use start and stop values and each >>> call requires typecasting the

Re: [PATCH] powerpc/asm/cacheflush: Cleanup cacheflush function params

2017-07-20 Thread Geert Uytterhoeven
On Thu, Jul 20, 2017 at 1:43 PM, Michael Ellerman wrote: > Matt Brown writes: >> The cacheflush prototypes currently use start and stop values and each >> call requires typecasting the address to an unsigned long. >> This patch changes the

[PATCH 6/6] xhci: fix memleak in xhci_run()

2017-07-20 Thread Mathias Nyman
From: Shu Wang Found this issue by kmemleak. xhci_run() did not check return val and free command for xhci_queue_vendor_command() unreferenced object 0x88011c0be500 (size 64): comm "kworker/0:1", pid 58, jiffies 4294670908 (age 50.420s) hex dump (first 32 bytes):

[PATCH 2/6] xhci: Bad Ethernet performance plugged in ASM1042A host

2017-07-20 Thread Mathias Nyman
From: Jiahau Chang When USB Ethernet is plugged in ASMEDIA ASM1042A xHCI host, bad performance was manifesting in Web browser use (like download large file such as ISO image). It is known limitation of ASM1042A that is not compatible with driver scheduling, As a workaround we

[PATCH 3/6] usb: xhci: Issue stop EP command only when the EP state is running

2017-07-20 Thread Mathias Nyman
From: Shyam Sundar S K on AMD platforms with SNPS 3.1 USB controller if stop endpoint command is issued the controller does not respond, when the EP is not in running state. HW completes the command execution and reports "Context State Error" completion code. This is as

[PATCH 5/6] usb: xhci: fix spinlock recursion for USB2 test mode

2017-07-20 Thread Mathias Nyman
From: Peter Chen Both xhci_hub_control and xhci_disable_slot tries to hold spinlock, the spinlock recursion occurs when enters USB2 test mode. Fix it by unlock spinlock before calling xhci_disable_slot. Cc: Fixes: 0f1d832ed1fb ("usb: xhci: Add port

[PATCH 1/6] xhci: Fix NULL pointer dereference when cleaning up streams for removed host

2017-07-20 Thread Mathias Nyman
This off by one in stream_id indexing caused NULL pointer dereference and soft lockup on machines with USB attached SCSI devices connected to a hotpluggable xhci controller. The code that cleans up pending URBs for dead hosts tried to dereference a stream ring at the invalid stream_id 0.

[PATCH 4/6] xhci: fix 20000ms port resume timeout

2017-07-20 Thread Mathias Nyman
A uncleared PLC (port link change) bit will prevent furuther port event interrupts for that port. Leaving it uncleared caused get_port_status() to timeout after 2ms while waiting to get the final port event interrupt for resume -> U0 state change. This is a targeted fix for a specific case

Re: [PATCH] xhci: fix memleak in xhci_run()

2017-07-20 Thread Mathias Nyman
On 20.07.2017 08:40, shuw...@redhat.com wrote: From: Shu Wang Found this issue by kmemleak. xhci_run() did not check return val and free command for xhci_queue_vendor_command() unreferenced object 0x88011c0be500 (size 64): comm "kworker/0:1", pid 58, jiffies

[PATCH 0/6] xhci fixes for usb-linus 4.13-rc

2017-07-20 Thread Mathias Nyman
Hi Greg This series contain ASMedia and AMD host specific fixes, streams null pointer fix, and rare timeout, memleak and locking issues. Thanks Mathias Jiahau Chang (1): xhci: Bad Ethernet performance plugged in ASM1042A host Mathias Nyman (2): xhci: Fix NULL pointer dereference when

Re: [PATCH] powerpc/asm/cacheflush: Cleanup cacheflush function params

2017-07-20 Thread Michael Ellerman
Hi Matt, Thanks for tackling this mess. Matt Brown writes: > The cacheflush prototypes currently use start and stop values and each > call requires typecasting the address to an unsigned long. > This patch changes the cacheflush prototypes to follow the x86 style of

Re: [PATCH 1/2] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

2017-07-20 Thread Manu Gautam
Hi, On 7/13/2017 1:13 PM, Baolin Wang wrote: > Hi, > > On 13 July 2017 at 15:26, Manu Gautam wrote: >> >> On 7/13/2017 11:33 AM, Baolin Wang wrote: >>> On 12 July 2017 at 16:58, Manu Gautam wrote: On 7/12/2017 2:06 PM, Baolin Wang wrote:

Re: [PATCH 1/1] usb: xhci: fix spinlock recursion for USB2 test mode

2017-07-20 Thread Mathias Nyman
On 19.07.2017 10:28, Peter Chen wrote: Both xhci_hub_control and xhci_disable_slot tries to hold spinlock, the spinlock recursion occurs when enters USB2 test mode. Fix it by unlock spinlock before calling xhci_disable_slot. Cc: Fixes: 0f1d832ed1fb ("usb: xhci: Add port

Re: [PATCH v16 2/7] power: add power sequence library

2017-07-20 Thread Peter Chen
On Wed, Jul 19, 2017 at 01:34:11PM +0200, Rafael J. Wysocki wrote: > On Wednesday, July 19, 2017 10:56:00 AM Peter Chen wrote: > > On Tue, Jul 18, 2017 at 07:06:05PM +0200, Rafael J. Wysocki wrote: > > > On Tue, Jul 18, 2017 at 6:29 AM, Peter Chen wrote: > > > > On Mon, Jul

Re: [PATCH] powerpc/asm/cacheflush: Cleanup cacheflush function params

2017-07-20 Thread Geert Uytterhoeven
On Thu, Jul 20, 2017 at 8:28 AM, Matt Brown wrote: > The cacheflush prototypes currently use start and stop values and each > call requires typecasting the address to an unsigned long. > This patch changes the cacheflush prototypes to follow the x86 style of > using a

[PATCH] powerpc/asm/cacheflush: Cleanup cacheflush function params

2017-07-20 Thread Matt Brown
The cacheflush prototypes currently use start and stop values and each call requires typecasting the address to an unsigned long. This patch changes the cacheflush prototypes to follow the x86 style of using a base and size values, with base being a void pointer. All callers of the cacheflush