Re: [PATCH v2] usb: musb: sunxi: Explicitly release USB PHY on exit

2017-10-16 Thread Bin Liu
On Mon, Oct 16, 2017 at 11:54:27PM +1100, Jonathan Liu wrote: > On 16 October 2017 at 23:49, Bin Liu wrote: > > On Mon, Oct 16, 2017 at 04:13:51PM +1100, Jonathan Liu wrote: > >> On 10 October 2017 at 14:22, Bin Liu wrote: > >> > On Tue, Oct 10, 2017 at 01:45:25PM +1100, Jonathan Liu wrote: > >>

RE: [PATCH 2/2] ARM: dts: r8a7743: Add xhci support to SoC dtsi

2017-10-16 Thread Yoshihiro Shimoda
Hi Biju-san, IIUC, when we submitted a patch for dts[i] file, we don't need to submit such a patch to usb maintainers. > From: Biju Das, Sent: Monday, October 16, 2017 7:13 PM > > From: Fabrizio Castro > > Add node for xhci. Boards DT files will enable it if needed. > > Signed-off-by: Fabrizi

RE: [PATCH 1/2] dt-bindings: usb-xhci: Document r8a7743 support

2017-10-16 Thread Yoshihiro Shimoda
Hi Biju-san, (and added Mathias-san of the XHCI maintainer as TO) Thank you for the patch! > From: Biju Das, Sent: Monday, October 16, 2017 7:13 PM > > From: Fabrizio Castro > > Document r8a7743 xhci support. The driver will use the fallback > compatible string "renesas,rcar-gen2-xhci", theref

[PATCH 07/58] net/usb/usbnet: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Since the callback is called from both a timer and a tasklet, adjust the tasklet to pass the timer address to

[PATCH 48/58] net: usb: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Woojung Huh Cc: Microchip Linux Driver Support Cc: "David S. Miller" Cc: Ben Hutchings Cc: Philippe

Re: [PATCH v2 09/15] ACPI: configfs: make config_item_type const

2017-10-16 Thread Rafael J. Wysocki
On Monday, October 16, 2017 5:18:48 PM CEST Bhumika Goyal wrote: > Make these structures const as they are either passed to the functions > having the argument as const or stored as a reference in the "ci_type" > const field of a config_item structure. > > Done using Coccienlle. > > Signed-off-by

[PATCH] usb: phy: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Signed-off-by: Kees Cook --- drive

[PATCH] usb/gadget/snps_udc_core: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. If the probe fails, udc_remove() will not be called, so there is no reason to make del_timer_sync() calls co

[PATCH] usb: isp1301-omap: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Cc: linux-o...@vger.kernel.org Signe

[PATCH] xhci: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Mathias Nyman Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Signed-off-by: Kees Cook --- driv

Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey

2017-10-16 Thread John Stultz
On Mon, Oct 16, 2017 at 1:36 AM, Minas Harutyunyan wrote: > On b-plug disconnect should asserted GOTGINT.SesEndDet interrupt. > According previously sent by you register dump (GHWCFG2 = 0x23affc70) > your core OTG_MODE=0. > Bellow fragment from programming guide on Device disconnect: > > "7.3Devic

Re: [PATCH v2 2/2] dt-bindings: max3421: Add bindings documentation

2017-10-16 Thread Jules Maselbas
Thanks Sergei, Is it better if the documentation say: " Optional property: - interrupt-parent: the phandle of the associated interrupt controller. " or should I also add that "it may be inherited from the parent nodes."? Jules Maselbas. - Mail original - De: "Sergei Shtylyov" À: "Jules

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

2017-10-16 Thread Julius Werner
> d9a14b00 339317035 C Ii:1:004:1 -32:1 0 > d9a14b00 339317049 S Ii:1:004:1 -115:1 10 < > d9a14b00 339318040 C Ii:1:004:1 -32:1 0 > d9a14b00 339318057 S Ii:1:004:1 -115:1 10 < > d9a14b00 339319042 C Ii:1:004:1 -32:1 0 > d9a14b00 339319056 S Ii:1:004:1 -115:1 10 < > d9a14b00 339329551 C Ii:1:004:1 -

Re: [PATCH v2 2/2] dt-bindings: max3421: Add bindings documentation

2017-10-16 Thread Sergei Shtylyov
On 10/16/2017 12:04 PM, Sergei Shtylyov wrote: Adds bindings documentation for the max3421 driver. Signed-off-by: Jules Maselbas --- .../devicetree/bindings/usb/maxim,max3421.txt | 24 ++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetr

Re: [PATCH] usb: hub: Allow reset retry for USB2 devices on connect bounce

2017-10-16 Thread Alan Stern
On Mon, 16 Oct 2017, Mathias Nyman wrote: > If the connect status change is set during reset signaling, but > the status remains connected just retry port reset. > > This solves an issue with connecting a 90W HP Thunderbolt 3 dock > with a Lenovo Carbon x1 (5th generation) which causes a 30min lo

Re: [PATCH 4.14 REGRESSION fix] USB: devio: Revert "USB: devio: Don't corrupt user memory"

2017-10-16 Thread Alan Stern
On Mon, 16 Oct 2017, Hans de Goede wrote: > Taking the uurb->buffer_length userspace passes in as a maximum for the > actual urbs transfer_buffer_length causes 2 serious issues: > > 1) It breaks isochronous support for all userspace apps using libusb, >as existing libusb versions pass in 0 fo

Re: [PATCH v2 04/15] iio: make function argument and some structures const

2017-10-16 Thread Jonathan Cameron
On 16 October 2017 16:18:43 BST, Bhumika Goyal wrote: >Make the argument of the functions iio_sw{d/t}_group_init_type_name >const >as they are only passed to the function config_group_init_type_name >having >the argument as const. > >Make the config_item_type structures const as they are either

Re: [PATCH v2 06/15] PCI: endpoint: make config_item_type const

2017-10-16 Thread Bjorn Helgaas
On Mon, Oct 16, 2017 at 05:18:45PM +0200, Bhumika Goyal wrote: > Make config_item_type structures const as they are either passed to a > function having the argument as const or stored in the const "ci_type" > field of a config_item structure. > > Done using Coccinelle. > > Signed-off-by: Bhumika

Re: [PATCH] usb: dwc2: disable erroneous overcurrent condition

2017-10-16 Thread Marek Vasut
On 10/16/2017 03:57 PM, Dinh Nguyen wrote: > For the case where an external VBUS is used, we should enable the external > VBUS comparator in the driver. This would prevent an unnecessary > overcurrent error which would then disable the host port. > > This patch uses the standard 'disable-over-curr

Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7

2017-10-16 Thread Alexandre Torgue
Hi Amélie, On 08/28/2017 04:20 PM, Amelie Delaunay wrote: The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB OTG FS and the other is USB OTG HS. The USB FS core only works with its internal phy whilst the USB HS core can work in HS with external ULPI phy or in FS/LS with the o

[PATCH v2 01/15] configfs: make ci_type field, some pointers and function arguments const

2017-10-16 Thread Bhumika Goyal
The ci_type field of the config_item structure do not modify the fields of the config_item_type structure it points to. And the other pointers initialized with ci_type do not modify the fields as well. So, make the ci_type field and the pointers initialized with ci_type as const. Make the struct c

[PATCH v2 02/15] usb: gadget: make config_item_type structures const

2017-10-16 Thread Bhumika Goyal
Make these structures const as they are only passed to the const argument of the functions config_{group/item}_init_type_name. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the followup patches and the constification patches into a series. drivers/usb/gadget/function/f_acm.c

[PATCH v2 04/15] iio: make function argument and some structures const

2017-10-16 Thread Bhumika Goyal
Make the argument of the functions iio_sw{d/t}_group_init_type_name const as they are only passed to the function config_group_init_type_name having the argument as const. Make the config_item_type structures const as they are either passed to the functions having the argument as const or they are

[PATCH v2 05/15] ocfs2/cluster: make config_item_type const

2017-10-16 Thread Bhumika Goyal
Make these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure. Done using Coccinelle. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the followup patches and the

[PATCH v2 07/15] usb: gadget: configfs: make config_item_type const

2017-10-16 Thread Bhumika Goyal
Make config_item_type structures const as they are either passed to a function having the argument as const or stored in the const "ci_type" field of a config_item structure. Done using Coccinelle. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the followup patches and the constif

[PATCH v2 08/15] nvmet: make config_item_type const

2017-10-16 Thread Bhumika Goyal
Make config_item_type structures const as they are either passed to a function having the argument as const or used inside an if statement or stored in the const "ci_type" field of a config_item structure. Done using Coccinelle Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the fo

[PATCH v2 06/15] PCI: endpoint: make config_item_type const

2017-10-16 Thread Bhumika Goyal
Make config_item_type structures const as they are either passed to a function having the argument as const or stored in the const "ci_type" field of a config_item structure. Done using Coccinelle. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the followup patches and the constif

[PATCH v2 09/15] ACPI: configfs: make config_item_type const

2017-10-16 Thread Bhumika Goyal
Make these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure. Done using Coccienlle. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the followup patches and the

[PATCH v2 10/15] nullb: make config_item_type const

2017-10-16 Thread Bhumika Goyal
Make these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure. Done using Coccienlle. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the followup patches and the

[PATCH v2 12/15] RDMA/cma: make config_item_type const

2017-10-16 Thread Bhumika Goyal
Make these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the followup patches and the constification patches i

[PATCH v2 11/15] stm class: make config_item_type const

2017-10-16 Thread Bhumika Goyal
Make config_item_type structures const as they are either passed to a function having the argument as const or used inside a if statement or stored in the const "ci_type" field of a config_item structure. Done using Coccinelle. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the fo

[PATCH v2 14/15] dlm: make config_item_type const

2017-10-16 Thread Bhumika Goyal
Make config_item_type structures const as they are either passed to a function having the argument as const or stored in the const "ci_type" field of a config_item structure. Done using Coccinelle. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the followup patches and the constif

[PATCH v2 15/15] configfs: make config_item_type const

2017-10-16 Thread Bhumika Goyal
Make config_item_type structures const as they are either passed to a function having the argument as const or stored in the const "ci_type" field of a config_item structure. Done using Coccinelle. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the followup patches and the constif

[PATCH v2 13/15] netconsole: make config_item_type const

2017-10-16 Thread Bhumika Goyal
Make these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure. Done using Coccienlle. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the followup patches and the

[PATCH v2 00/15] make structure field, function arguments and structures const

2017-10-16 Thread Bhumika Goyal
Make the ci_type field and some function arguments as const. After this change, make config_item_type structures as const. * Changes in v2- Combine all the followup patches and the constification patches into a series. Bhumika Goyal (15): configfs: make ci_type field, some pointers and function

[PATCH v2 03/15] target: make config_item_type const

2017-10-16 Thread Bhumika Goyal
Make these structures const as they are either passed to the functions having the argument as const or stored as a reference in the "ci_type" const field of a config_item structure. Done using Coccinelle. Signed-off-by: Bhumika Goyal --- * Changes in v2- Combine all the followup patches and the

Re: dwc2 - ChHltd set, but reason is unknown

2017-10-16 Thread Anders Montonen
On Mon, 16 Oct 2017, Minas Harutyunyan wrote: On 10/16/2017 12:12 PM, Anders Montonen wrote: On Mon, 16 Oct 2017, Minas Harutyunyan wrote: On 10/10/2017 4:35 PM, Anders Montonen wrote: On Mon, 9 Oct 2017, Minas Harutyunyan wrote: On 10/9/2017 5:15 PM, Anders Montonen wrote: We have a custo

[PATCH 4.14 REGRESSION fix] USB: devio: Revert "USB: devio: Don't corrupt user memory"

2017-10-16 Thread Hans de Goede
Taking the uurb->buffer_length userspace passes in as a maximum for the actual urbs transfer_buffer_length causes 2 serious issues: 1) It breaks isochronous support for all userspace apps using libusb, as existing libusb versions pass in 0 for uurb->buffer_length, relying on the kernel using

[PATCH] usb: dwc2: disable erroneous overcurrent condition

2017-10-16 Thread Dinh Nguyen
For the case where an external VBUS is used, we should enable the external VBUS comparator in the driver. This would prevent an unnecessary overcurrent error which would then disable the host port. This patch uses the standard 'disable-over-current' binding to allow of the option of disabling the

[PATCH] usb: hub: Allow reset retry for USB2 devices on connect bounce

2017-10-16 Thread Mathias Nyman
If the connect status change is set during reset signaling, but the status remains connected just retry port reset. This solves an issue with connecting a 90W HP Thunderbolt 3 dock with a Lenovo Carbon x1 (5th generation) which causes a 30min loop of a high speed device being re-discovererd before

Re: VL805 xHCI DMA read faults

2017-10-16 Thread Hao Wei Tee
On 16/10/2017 20:23, Robin Murphy wrote: > Is your VL805 on the motherboard or an add-on card? One other possibly > important difference that comes to mind is that on my arm64 system Linux > is the only agent to ever touch the xHCI - UEFI doesn't even try to > probe it. It seems likely that a full-

Re: [PATCH v2] usb: musb: sunxi: Explicitly release USB PHY on exit

2017-10-16 Thread Jonathan Liu
On 16 October 2017 at 23:49, Bin Liu wrote: > On Mon, Oct 16, 2017 at 04:13:51PM +1100, Jonathan Liu wrote: >> On 10 October 2017 at 14:22, Bin Liu wrote: >> > On Tue, Oct 10, 2017 at 01:45:25PM +1100, Jonathan Liu wrote: >> >> This fixes a kernel oops when unloading the driver due to usb_put_phy

Re: [PATCH v2] usb: musb: sunxi: Explicitly release USB PHY on exit

2017-10-16 Thread Bin Liu
On Mon, Oct 16, 2017 at 04:13:51PM +1100, Jonathan Liu wrote: > On 10 October 2017 at 14:22, Bin Liu wrote: > > On Tue, Oct 10, 2017 at 01:45:25PM +1100, Jonathan Liu wrote: > >> This fixes a kernel oops when unloading the driver due to usb_put_phy > >> being called after usb_phy_generic_unregiste

Re: VL805 xHCI DMA read faults

2017-10-16 Thread Robin Murphy
On 16/10/17 12:54, Hao Wei Tee wrote: > On 12/10/2017 21:36, Mathias Nyman wrote: >> You could try booting with xhci_hcd.dyndbg=+p added to the kernel command >> line. > > I can't find anything relevant... Hmm. Is your VL805 on the motherboard or an add-on card? One other possibly important diff

Re: VL805 xHCI DMA read faults

2017-10-16 Thread Hao Wei Tee
On 12/10/2017 21:36, Mathias Nyman wrote: > You could try booting with xhci_hcd.dyndbg=+p added to the kernel command > line. I can't find anything relevant... Hmm. Command line: BOOT_IMAGE=/boot/vmlinuz-linux root=... rw intel_iommu=on xhci_hcd.dyndbg=+p ACPI: DMAR 0xDE2C20E0 78 (v

Re: [PATCH] usb: cdc_acm: Add quirk for Elatec TWN3

2017-10-16 Thread Oliver Neukum
Am Mittwoch, den 11.10.2017, 11:10 +0300 schrieb Maksim Salau: > Elatec TWN3 has the union descriptor on data interface. This results in > failure to bind the device to the driver with the following log: >   usb 1-1.2: new full speed USB device using streamplug-ehci and address 4 >   usb 1-1.2: New

Re: xhci_hcd 0000:00:14.0: WARN Event TRB for slot 1 ep 2 with no TDs queued?

2017-10-16 Thread Mathias Nyman
On 13.10.2017 14:46, Yaroslav Isakov wrote: Hello, Mathias! Did you get a chance to look into this bug? Other things came up and this got a bit delayed. Attached is a patch to test -Mathias 2017-07-20 19:15 GMT+03:00 Yaroslav Isakov : Yes, I can definitely test the patch 2017-07-20 19:16 G

[PATCH 2/2] ARM: dts: r8a7743: Add xhci support to SoC dtsi

2017-10-16 Thread Biju Das
From: Fabrizio Castro Add node for xhci. Boards DT files will enable it if needed. Signed-off-by: Fabrizio Castro --- arch/arm/boot/dts/r8a7743.dtsi | 20 1 file changed, 20 insertions(+) diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi index 6

[PATCH 1/2] dt-bindings: usb-xhci: Document r8a7743 support

2017-10-16 Thread Biju Das
From: Fabrizio Castro Document r8a7743 xhci support. The driver will use the fallback compatible string "renesas,rcar-gen2-xhci", therefore no driver change is needed. Signed-off-by: Fabrizio Castro --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 4 +++- 1 file changed, 3 insertions(+

[PATCH 0/2] Add XHCI support

2017-10-16 Thread Biju Das
Hello, This series aims to add USB XHCI support for iWave RZ/G1M (R8A7743) board. This series has been tested against renesas-dev tag 20171013-v4.14-rc4. Regards, Fabrizio Castro (2): dt-bindings: usb-xhci: Document r8a7743 support ARM: dts: r8a7743: Add xhci support to SoC dtsi Documentat

Re: [PATCH v2 2/2] dt-bindings: max3421: Add bindings documentation

2017-10-16 Thread Sergei Shtylyov
Hello! On 10/16/2017 2:43 AM, Jules Maselbas wrote: Adds bindings documentation for the max3421 driver. Signed-off-by: Jules Maselbas --- .../devicetree/bindings/usb/maxim,max3421.txt | 24 ++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devi

Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey

2017-10-16 Thread Minas Harutyunyan
On 10/12/2017 10:06 PM, John Stultz wrote: > On Thu, Oct 12, 2017 at 12:59 AM, Minas Harutyunyan > wrote: >> >> 1. Vardan's patch fixing issue when dwc2 switched from host to device >> mode. It's allow to make functional device after reconnecting without >> tracking UDC state. > > While I'm sure

Re: dwc2 - ChHltd set, but reason is unknown

2017-10-16 Thread Minas Harutyunyan
On 10/16/2017 12:12 PM, Anders Montonen wrote: > On Mon, 16 Oct 2017, Minas Harutyunyan wrote: >> On 10/10/2017 4:35 PM, Anders Montonen wrote: >>> On Mon, 9 Oct 2017, Minas Harutyunyan wrote: On 10/9/2017 5:15 PM, Anders Montonen wrote: >>> > We have a custom Altera Cyclone V SoCFPGA boar

Re: dwc2 - ChHltd set, but reason is unknown

2017-10-16 Thread Anders Montonen
On Mon, 16 Oct 2017, Minas Harutyunyan wrote: On 10/10/2017 4:35 PM, Anders Montonen wrote: On Mon, 9 Oct 2017, Minas Harutyunyan wrote: On 10/9/2017 5:15 PM, Anders Montonen wrote: We have a custom Altera Cyclone V SoCFPGA board, where connecting a particular brand of USB memory sticks prod

Re: dwc2 - ChHltd set, but reason is unknown

2017-10-16 Thread Minas Harutyunyan
On 10/10/2017 4:35 PM, Anders Montonen wrote: > Hi, > > On Mon, 9 Oct 2017, Minas Harutyunyan wrote: >> On 10/9/2017 5:15 PM, Anders Montonen wrote: > >>> We have a custom Altera Cyclone V SoCFPGA board, where connecting a >>> particular brand of USB memory sticks produces and enless stream of >>