Re: [PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs

Hi David, Johan, Quoting Johan Hovold : On Mon, Oct 30, 2017 at 11:54:33AM +, David Laight wrote: From: Bjørn Mork > Sent: 28 October 2017 11:57 > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > where we are expecting to fall through. > > > >

Re: [PATCH v7 usb-next 3/4] usb: core: hcd: integrate the PHY roothub wrapper

Hi Manu, thank you for reviewing this! On Thu, Oct 26, 2017 at 7:42 AM, Manu Gautam wrote: > Hi, > > > On 10/24/2017 3:27 AM, Martin Blumenstingl wrote: >> This integrates the PHY roothub wrapper into the core hcd >> infrastructure. Multiple PHYs which are part of the

Re: [PATCH v7 usb-next 4/4] dt-bindings: usb: xhci: include the roothub and a device in the example

Hi Arnd, On Mon, Oct 30, 2017 at 3:08 PM, Arnd Bergmann wrote: > On Sat, Oct 28, 2017 at 3:33 PM, Martin Blumenstingl > wrote: >> On Fri, Oct 27, 2017 at 9:55 PM, Alan Stern >> wrote: >>> On Fri, 27 Oct 2017, Martin

Re: [PATCH] usb: musb: dsps: remove the duplicated timer

On Mon, Oct 30, 2017 at 02:29:54PM -0700, Kees Cook wrote: > On Mon, Oct 30, 2017 at 9:29 AM, Bin Liu wrote: > > Now struct musb has the timer (dev_timer) for glue drivers, so let's > > remove the duplicated timer defined in dsps glue driver, and use > > dev_timer defined in struct

Re: [PATCH] usb: musb: dsps: remove the duplicated timer

On Mon, Oct 30, 2017 at 9:29 AM, Bin Liu wrote: > Now struct musb has the timer (dev_timer) for glue drivers, so let's > remove the duplicated timer defined in dsps glue driver, and use > dev_timer defined in struct musb. > > Signed-off-by: Bin Liu Reviewed-by: Kees

Re: [PATCH v3 2/2] usb: dwc2: host: Convert hcd_queue to timer_setup

On Mon, Oct 30, 2017 at 10:08 AM, Douglas Anderson wrote: > Convert the timers in hcd_queue to use the new timer_setup() call > introduced in commit 686fef928bba ("timer: Prepare to change timer > callback argument type"). > > Suggested-by: Stefan Wahren

Re: xhci_hcd WARN Event TRB for slot ep with no TDs queued?

On Mon, Oct 30, 2017 at 04:16:29PM +0100, Juan Simón wrote: > Hi, > I have read this thread > (https://marc.info/?l=linux-usb=150056183628924=2) and supposedly > the problem was solved in version 4.13.7 but in my case it's not like > that. > I use Arch Linux. I've tested several versions of kernel

Re: [PATCH v2 1/3] usb: host: remove ehci-msm.c

On Thu 26 Oct 08:06 PDT 2017, Alan Stern wrote: > On Thu, 26 Oct 2017, Alex Elder wrote: > > > No Qualcomm SoC requires the "ehci-msm.c" code any more. So remove it. > > What about old Qualcomm SoCs? What should they use instead? > These drivers where unfortunately broken by design (host

Re: DWC3 Gadget backtrace

Felipe, On 10/30/2017 15:28, Felipe Balbi wrote: > > Hi, > > "Howey, Dylan" writes: > > Felipe, > > > > It's also happening in v4.14-rc7. > > Please make sure to also Cc: linux-usb@vger.kernel.org and send > plain-text emails, also avoid top-posting :-) > > > [

Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

Hi, On Mon, Oct 30, 2017 at 1:32 AM, Felipe Balbi wrote: > > Hi, > > Doug Anderson writes: >> Hi, >> >> On Sat, Oct 28, 2017 at 8:51 AM, Stefan Wahren >> wrote: >>> Hi Doug, >>> >>> [add Felipe since this should go through his

[PATCH v3 2/2] usb: dwc2: host: Convert hcd_queue to timer_setup

Convert the timers in hcd_queue to use the new timer_setup() call introduced in commit 686fef928bba ("timer: Prepare to change timer callback argument type"). Suggested-by: Stefan Wahren Signed-off-by: Douglas Anderson Cc: Kees Cook

[PATCH v3 1/2] usb: dwc2: host: Don't retry NAKed transactions right away

On rk3288-veyron devices on Chrome OS it was found that plugging in an Arduino-based USB device could cause the system to lockup, especially if the CPU Frequency was at one of the slower operating points (like 100 MHz / 200 MHz). Upon tracing, I found that the following was happening: * The USB

State of USB-C PD on the linux kernel

Hello everyone, I see this is primarily a development mailing list, but I didn't find a corresponding users mailing list. If there's a better place to ask this question, just let me know. What is the state of USB-C Power Delivery on the Linux kernel? Does it even need software support, or is it

Linux and usb device drivers using functionfs

Hello, I have implemented a USB device function using Linux functionfs and now there is a problem being reported. I need to ask this group for advice. The problem is this: 1) device boots 2) some usb transfers happen, all are OK 3) a device app runs to completion (USB quiescent during

Re: [PATCH] usb: musb: Convert timers to use timer_setup()

On Mon, Oct 30, 2017 at 09:52:15AM +0100, Greg Kroah-Hartman wrote: > On Fri, Oct 27, 2017 at 11:24:22AM -0500, Bin Liu wrote: > > Hi, > > > > On Tue, Oct 24, 2017 at 03:08:35AM -0700, Kees Cook wrote: > > > In preparation for unconditionally passing the struct timer_list pointer > > > to > > >

[PATCH] usb: musb: dsps: remove the duplicated timer

Now struct musb has the timer (dev_timer) for glue drivers, so let's remove the duplicated timer defined in dsps glue driver, and use dev_timer defined in struct musb. Signed-off-by: Bin Liu --- This is the fixup patch for [1]. [1] https://marc.info/?l=linux-usb=150936947225302=2

xhci_hcd WARN Event TRB for slot ep with no TDs queued?

Hi, I have read this thread (https://marc.info/?l=linux-usb=150056183628924=2) and supposedly the problem was solved in version 4.13.7 but in my case it's not like that. I use Arch Linux. I've tested several versions of kernel 4.13.x and they all fail me. The kernels 4.12.x works well. I have

Re: [PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs

On Mon, Oct 30, 2017 at 11:54:33AM +, David Laight wrote: > From: Bjørn Mork > > Sent: 28 October 2017 11:57 > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > > where we are expecting to fall through. > > > > > > Notice that in this particular case I replaced

RE: [PATCH] lan78xx: Use common error handling code in lan78xx_phy_init()

> From: SF Markus Elfring [mailto:elfr...@users.sourceforge.net] > Sent: Saturday, October 28, 2017 4:57 PM > To: net...@vger.kernel.org; linux-usb@vger.kernel.org; UNGLinuxDriver; > Woojung Huh - C21699 > Cc: LKML; kernel-janit...@vger.kernel.org > Subject: [PATCH] lan78xx: Use common error

Re: [PATCH] usb: serial: kobil_sct: mark expected switch fall-through

On Tue, Oct 24, 2017 at 11:52:46AM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 115014 > Signed-off-by: Gustavo A. R. Silva Now applied,

Re: [PATCH] rndis_host: support Novatel Verizon USB730L — Linux USB

On Mon, Oct 30, 2017 at 11:38:34AM +, Gal Shalif wrote: > The following was used to switch the Novatel USB730L from user mode > (product ID 0x9030) to enterprise mode (product ID 0x9032): > > > * Kernel patche: add Novatel USB730L enterprise mode serial interface > > $ git show 9bacb30

Re: [PATCH v7 usb-next 4/4] dt-bindings: usb: xhci: include the roothub and a device in the example

On Sat, Oct 28, 2017 at 3:33 PM, Martin Blumenstingl wrote: > On Fri, Oct 27, 2017 at 9:55 PM, Alan Stern wrote: >> On Fri, 27 Oct 2017, Martin Blumenstingl wrote: >>> >> diff --git

Re: DWC3 Gadget backtrace

Hi, "Howey, Dylan" writes: > Felipe, > > It's also happening in v4.14-rc7. Please make sure to also Cc: linux-usb@vger.kernel.org and send plain-text emails, also avoid top-posting :-) > [ 59.716702] [ cut here ] > [ 59.721365] WARNING:

Re: [PATCH] usb: musb_core: mark expected switch fall-through

On Mon, Oct 30, 2017 at 09:51:18AM +0100, Greg Kroah-Hartman wrote: > On Fri, Oct 27, 2017 at 11:56:14AM -0500, Bin Liu wrote: > > On Fri, Oct 27, 2017 at 06:49:49PM +0200, Greg Kroah-Hartman wrote: > > > On Fri, Oct 27, 2017 at 11:44:47AM -0500, Bin Liu wrote: > > > > Hi, > > > > > > > > On Mon,

Re: [PATCH] usb: musb: Convert timers to use timer_setup()

On Mon, Oct 30, 2017 at 09:52:15AM +0100, Greg Kroah-Hartman wrote: > On Fri, Oct 27, 2017 at 11:24:22AM -0500, Bin Liu wrote: > > Hi, > > > > On Tue, Oct 24, 2017 at 03:08:35AM -0700, Kees Cook wrote: > > > In preparation for unconditionally passing the struct timer_list pointer > > > to > > >

Re: [PATCH] mmc: vub300: Use common code in __download_offload_pseudocode()

On 30 October 2017 at 13:15, Dan Carpenter wrote: > On Mon, Oct 30, 2017 at 12:40:39PM +0100, Ulf Hansson wrote: >> On 27 October 2017 at 21:31, SF Markus Elfring >> wrote: >> > From: Markus Elfring >> >

Re: [PATCH] mmc: vub300: Use common code in __download_offload_pseudocode()

On Mon, Oct 30, 2017 at 12:40:39PM +0100, Ulf Hansson wrote: > On 27 October 2017 at 21:31, SF Markus Elfring > wrote: > > From: Markus Elfring > > Date: Fri, 27 Oct 2017 21:21:40 +0200 > > > > Add a jump target so that a specific

RE: [PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs

From: Bjørn Mork > Sent: 28 October 2017 11:57 > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > where we are expecting to fall through. > > > > Notice that in this particular case I replaced "...drop on through" > > comments with a proper "fall through" comment on its

Re: [PATCH] mmc: vub300: Use common code in __download_offload_pseudocode()

On 27 October 2017 at 21:31, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 27 Oct 2017 21:21:40 +0200 > > Add a jump target so that a specific string copy operation is stored > only once at the end of this function

Re: [PATCH] mmc: Convert timers to use timer_setup()

On 24 October 2017 at 17:03, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Ludovic Desroches

Re: [PATCH] rndis_host: support Novatel Verizon USB730L — Linux USB

Hello Bjorn, Thanks for your help, the problem is solved and the blame go to the usb_modeswitch executable that failed to change the configuration. However, changing the configuration was successful when writing directly into the kernel :-) My Linux system already use the latest usb_modeswitch

Re: [PATCH] sr9800: Use common error handling code in sr9800_phy_powerup()

Hi Markus, On Sun, Oct 29, 2017 at 1:03 PM, SF Markus Elfring wrote: >>> @@ -700,10 +700,9 @@ static int sr9800_phy_powerup(struct usbnet *dev) >>> >>> /* set the embedded Ethernet PHY in power-up state */ >>> ret = sr_sw_reset(dev,

[PATCH 2/2] usb: ohci-platform: use reset array API

Generic drivers like this need to control arbitrary numbers of reset lines. Instead of hard-coding the maximum number of resets, use the reset array API. It can manage a bunch of resets behind the scene. Signed-off-by: Masahiro Yamada ---

[PATCH 1/2] usb: ehci-platform: use reset array API

Generic drivers like this need to control arbitrary numbers of reset lines. Instead of hard-coding the maximum number of resets, use the reset array API. It can manage a bunch of resets behind the scene. Signed-off-by: Masahiro Yamada ---

Re: [PATCH] usb: musb: Convert timers to use timer_setup()

On Fri, Oct 27, 2017 at 11:24:22AM -0500, Bin Liu wrote: > Hi, > > On Tue, Oct 24, 2017 at 03:08:35AM -0700, Kees Cook wrote: > > In preparation for unconditionally passing the struct timer_list pointer to > > all timer callbacks, switch to using the new timer_setup() and from_timer() > > to pass

Re: [PATCH] usb: musb_core: mark expected switch fall-through

On Fri, Oct 27, 2017 at 11:56:14AM -0500, Bin Liu wrote: > On Fri, Oct 27, 2017 at 06:49:49PM +0200, Greg Kroah-Hartman wrote: > > On Fri, Oct 27, 2017 at 11:44:47AM -0500, Bin Liu wrote: > > > Hi, > > > > > > On Mon, Oct 23, 2017 at 10:10:43PM -0500, Gustavo A. R. Silva wrote: > > > > In

Re: [GIT PULL] usb: chipidea changes for v4.15-rc1

On Mon, Oct 30, 2017 at 10:09:12AM +0800, Peter Chen wrote: > The following changes since commit 38502ef49f96f7fe25fcb3aaa904a570df955c2c: > > usb: storage: make const arrays static, reduces object code size > (2017-09-18 12:44:11 +0200) > > are available in the git repository at: > >

Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

Hi, Doug Anderson writes: > Hi, > > On Sat, Oct 28, 2017 at 8:51 AM, Stefan Wahren wrote: >> Hi Doug, >> >> [add Felipe since this should go through his tree] > > Ah. Sorry Felipe! I know you've landed some dwc2 stuff in the past No problems