[PATCH] usb: host: xhci-plat: move clk to plat own private structure

2017-11-27 Thread Jisheng Zhang
commit 4efb2f694114 ("usb: host: xhci-plat: add struct xhci_plat_priv") introduced struct xhci_plat_priv to hold the plat driver's specific variables. The clk is only for plat driver, so let's move it to the proper structure. Signed-off-by: Jisheng Zhang --- drivers/usb/host/xhci-plat.c | 17 +++

Re: [PATCH] usbhid: add quirk for another PIXART OEM mouse used by HP

2017-11-27 Thread Benjamin Tissoires
On Nov 25 2017 or thereabouts, Dave Young wrote: > This mouse keep disconnecting in runleve 3 like below, add it needs the > quirk to mute the anoying messages. > > [ 111.230555] usb 2-2: USB disconnect, device number 6 > [ 112.718156] usb 2-2: new low-speed USB device number 7 using xhci_hcd >

Re: [PATCH] usbhid: add quirk for another PIXART OEM mouse used by HP

2017-11-27 Thread Greg KH
On Mon, Nov 27, 2017 at 09:16:31AM +0100, Benjamin Tissoires wrote: > On Nov 25 2017 or thereabouts, Dave Young wrote: > > This mouse keep disconnecting in runleve 3 like below, add it needs the > > quirk to mute the anoying messages. > > > > [ 111.230555] usb 2-2: USB disconnect, device number 6

Re: [PATCH] usbhid: add quirk for another PIXART OEM mouse used by HP

2017-11-27 Thread Benjamin Tissoires
On Nov 27 2017 or thereabouts, Greg KH wrote: > On Mon, Nov 27, 2017 at 09:16:31AM +0100, Benjamin Tissoires wrote: > > On Nov 25 2017 or thereabouts, Dave Young wrote: > > > This mouse keep disconnecting in runleve 3 like below, add it needs the > > > quirk to mute the anoying messages. > > > > >

Re: [PATCH] usbhid: add quirk for another PIXART OEM mouse used by HP

2017-11-27 Thread Dave Young
On 11/27/17 at 09:49am, Benjamin Tissoires wrote: > On Nov 27 2017 or thereabouts, Greg KH wrote: > > On Mon, Nov 27, 2017 at 09:16:31AM +0100, Benjamin Tissoires wrote: > > > On Nov 25 2017 or thereabouts, Dave Young wrote: > > > > This mouse keep disconnecting in runleve 3 like below, add it need

Re: 4.14 dwc3 gadget mode panic

2017-11-27 Thread Felipe Balbi
Hi, Vincent Pelletier writes: > On Sat, 25 Nov 2017 16:39:52 +, Vincent Pelletier > wrote: >> To my surprise, the error symptom do not seem to change: > > Having read some more on kernel debugging and especially critical > sections, I realise that while the general issue is still there, the

Re: [PATCH] USB: option: add Quectel BG96 2c7c:0296

2017-11-27 Thread Johan Hovold
On Mon, Nov 20, 2017 at 07:29:32PM +0100, Sebastian Sjoholm wrote: > Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both > CAT-M and NB-IoT. Tested hardware is BG96 mounted on Quectel > development board (EVB). The USB id is added to option.c to allow > DIAG,GPS,AT and modem com

Re: [PATCH] USB: serial: Correct return value on read

2017-11-27 Thread Johan Hovold
On Sun, Nov 26, 2017 at 04:18:51PM +, Gimcuan Hui wrote: > It's meaningless to return buf[0] on read. Because the caller of this > interface checks the return value negative or not. Instead, we should > return the result variable. It's not really meaningless, it's just that the return value is

Re: [PATCH] [stable only]USB: fix buffer overflows with parsing CDC headers

2017-11-27 Thread Oliver Neukum
Am Freitag, den 24.11.2017, 17:13 +0100 schrieb Greg KH: > On Thu, Nov 23, 2017 at 04:20:05PM +0100, Oliver Neukum wrote: > > > > drivers/net/usb/cdc_ether.c | 9 - > > drivers/usb/class/cdc-acm.c | 2 +- > > drivers/usb/class/cdc-wdm.c | 2 ++ > > 3 files changed, 11 insertions(+), 2 del

Re: New CP210x device

2017-11-27 Thread Johan Hovold
On Sun, Nov 26, 2017 at 04:11:10PM -0600, Frederick E. Stevens wrote: > Hello, > > I have a USB device which I just obtained as part of my medical > utilities.  It is a OneTouch Verio IQ glucometer.  After plugging it in > to my Linux machine running 4.4.95 I obtained the device vendor and Id >

Re: [PATCH] usb: f_fs: Drop check on Reserved1 field on OS_DESC_EXT_COMPAT

2017-11-27 Thread Felipe Balbi
Hi, John Keeping writes: > On Mon, 13 Nov 2017 12:57:21 +0200, Felipe Balbi wrote: >> Good point. Then how about we just force the value to 1 in f_fs.c and >> remove the check? > > That seems reasonable. Something like this? > > -- >8 -- > Subject: [PATCH] usb: f_fs: Force Reserved1=1 in OS_DES

Re: dwc2/dwc_otg drivers

2017-11-27 Thread Felipe Balbi
Hi, Billy Araujo writes: > Hi Felipe and Minas, > > > Firstly, thank you very much for your responses. > > I work as a software engineer at Fluke. > We compile our own version of the kernel but I am not the Linux kernel > maintainer at Fluke, I work mostly on the application side using Qt and >

Re: [PATCH] ARM: dts: bcm283x: Fix fifo size for EP 6,7

2017-11-27 Thread Minas Harutyunyan
Hi Stefan, On 11/23/2017 10:29 PM, Stefan Wahren wrote: > Hi Minas, > >> Minas Harutyunyan hat am 23. November 2017 >> um 11:00 geschrieben: >> >> >> Hi Stefan, >> >> ... >> >> In addition to above patches please apply this one: >> >> diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core

Re: [PATCH] USB: serial: iuu_phoenix: remove redundant assignment of DIV to itself

2017-11-27 Thread Johan Hovold
On Mon, Nov 20, 2017 at 05:40:15PM +, Colin King wrote: > From: Colin Ian King > > The assignment of DIV to itself is redundant and can be removed. > > Signed-off-by: Colin Ian King Now applied, thanks. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the b

Re: [PATCH] USB: serial: iuu_phoenix: remove redundant assignment of DIV to itself

2017-11-27 Thread Johan Hovold
On Mon, Nov 20, 2017 at 09:15:27PM +0100, walter harms wrote: > Am 20.11.2017 18:40, schrieb Colin King: > > From: Colin Ian King > > > > The assignment of DIV to itself is redundant and can be removed. > > > > Signed-off-by: Colin Ian King > > --- > > drivers/usb/serial/iuu_phoenix.c | 1 - >

Re: [RFC PATCH v2 6/7] typec: tcpm: Represent source supply through power_supply class

2017-11-27 Thread Heikki Krogerus
On Sat, Nov 25, 2017 at 03:03:02PM +0100, Hans de Goede wrote: > > Is it OK to everybody that the type of the psy is changed like that? > > Hans?! > > > > We do have drivers that already change the type, for example > > drivers/power/supply/isp1704_charger.c, but what does the user space > > expec

RE: [RFC PATCH v2 6/7] typec: tcpm: Represent source supply through power_supply class

2017-11-27 Thread Adam Thomson
On 25 November 2017 14:03, Hans de Goede wrote: > Hi, > > On 11/24/2017 01:19 PM, Heikki Krogerus wrote: > > Hi, > > > > On Tue, Nov 14, 2017 at 11:44:47AM +, Adam Thomson wrote: > >> diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c > >> index 78983e1..7c26c3d 100644 > >> ---

Re: [RFC PATCH v2 6/7] typec: tcpm: Represent source supply through power_supply class

2017-11-27 Thread Heikki Krogerus
Hi Adam, On Fri, Nov 24, 2017 at 02:05:27PM +, Adam Thomson wrote: > On 24 November 2017 12:19, Heikki Krogerus wrote: > > Is it OK to everybody that the type of the psy is changed like that? > > Hans?! > > > > We do have drivers that already change the type, for example > > drivers/power/sup

Re: [PATCH] USB: serial: Correct return value on read

2017-11-27 Thread saks cuso
On 27 November 2017 at 10:21, Johan Hovold wrote: > On Sun, Nov 26, 2017 at 04:18:51PM +, Gimcuan Hui wrote: >> It's meaningless to return buf[0] on read. Because the caller of this >> interface checks the return value negative or not. Instead, we should >> return the result variable. > > It's

Re: Performance regression in dwc3 ecm for linux 4.4

2017-11-27 Thread Felipe Balbi
Hi, Arjav Parikh writes: > Hi Felipe, > > Hope you are doing good. > > Currently I am facing an bandwidth issue in dwc3 driver using ecm gadget > with linux kernel version 4.4. > > Actually I am checking the USB 3.0 throughput using iperf between my > embedded device having *ARMV7* processor and

[PATCH] usb: dwc2: gadget: fix dwc2_check_param_tx_fifo_sizes

2017-11-27 Thread Amelie Delaunay
In case of OTG mode, with an OTG adapter plugged, the dwc2_check_param_tx_fifo_sizes function reads DPTXFSIZN registers while the controller is in Host mode, and, because DPTXFSIZN registers are Device specific registers, the values read are 0. Then, g_tx_fifo_size[fifo] values are considered inval

RE: [PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-27 Thread Mario.Limonciello
> -Original Message- > From: Kai Heng Feng [mailto:kai.heng.f...@canonical.com] > Sent: Friday, November 24, 2017 3:00 AM > To: Greg KH > Cc: David Miller ; hayesw...@realtek.co; linux- > u...@vger.kernel.org; net...@vger.kernel.org; LKML ker...@vger.kernel.org>; Limonciello, Mario > Sub

RE: [PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-27 Thread Mario.Limonciello
> -Original Message- > From: Kai Heng Feng [mailto:kai.heng.f...@canonical.com] > Sent: Thursday, November 23, 2017 9:44 PM > To: Greg KH > Cc: David Miller ; hayesw...@realtek.co; linux- > u...@vger.kernel.org; net...@vger.kernel.org; LKML ker...@vger.kernel.org>; Limonciello, Mario > S

Re: 4.14 dwc3 gadget mode panic

2017-11-27 Thread Vincent Pelletier
On Mon, 27 Nov 2017 11:17:54 +0200, Felipe Balbi wrote: > as I said, the *only* thing that schedules from inside > dwc3_gadget_ep_dequeue() is wait_event_lock_irq(). Which works fine > unless usb_ep_dequeue() is called with locks held and IRQs disabled. This I understand, yes. What puzzles me is

Re: [PATCH] usb: dwc2: add optional usb ecc reset bit

2017-11-27 Thread Dinh Nguyen
Hi John, was wondering if you have gotten a chance to review this? Thank, Dinh On 11/01/2017 10:34 AM, Dinh Nguyen wrote: > The dwc2 USB controller in Stratix10 has an additional ECC reset bit that > needs to get de-asserted in order for the controller to work properly. > > Signed-off-by: Dinh

[PATCH] USB: serial: Clean up the return values of read_reg and write_reg

2017-11-27 Thread Gimcuan Hui
write_reg returns 0 on success, we can make it more explicit by returning number 0 instead of result variable. read_reg should return 0 on success since this is a more common pattern. The user of read_reg has been clean-up and should be at the same commit. Signed-off-by: Gimcuan Hui --- driver

Re: [RFC v3] Add support for Sony PS2 OHCI

2017-11-27 Thread Alan Stern
On Sun, 26 Nov 2017, Fredrik Noring wrote: > Hi Alan Stern, > > > > Be aware that your driver should utilize ohci_init_driver(), like > > > several of the other platform-specific OHCI drivers do. Unless there's > > > some very good reason, new drivers should never use the old interface. > > > >

RE: [RFC PATCH v2 6/7] typec: tcpm: Represent source supply through power_supply class

2017-11-27 Thread Adam Thomson
On 27 November 2017 14:12, Heikki Krogerus wrote: > Hi Adam, > > On Fri, Nov 24, 2017 at 02:05:27PM +, Adam Thomson wrote: > > On 24 November 2017 12:19, Heikki Krogerus wrote: > > > Is it OK to everybody that the type of the psy is changed like that? > > > Hans?! > > > > > > We do have drive

[PATCH v2] usb: f_fs: Force Reserved1=1 in OS_DESC_EXT_COMPAT

2017-11-27 Thread John Keeping
The specification says that the Reserved1 field in OS_DESC_EXT_COMPAT must have the value "1", but when this feature was first implemented we rejected any non-zero values. This was adjusted to accept all non-zero values (while now rejecting zero) in commit 53642399aa71 ("usb: gadget: f_fs: Fix wro

EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-27 Thread Ladislav Michl
Hi there, USB hosts do not discover any connected device on OMAP3 based board with CONFIG_PM=n. Just enabling this option is enough to restore working behaviour. Nothing unusual in log. Tested 4.14.2 and 4.15-rc1. I know a lot of stuff depends on CONFIG_PM, but is this expected behaviour? Neither

Re: [PATCH 2/2 v7] typec: tcpm: Only request matching pdos

2017-11-27 Thread Badhri Jagan Sridharan
On Thu, Nov 23, 2017 at 3:10 AM, Adam Thomson wrote: > On 16 November 2017 01:02, Badhri Jagan Sridharan wrote: > >> At present, TCPM code assumes that local device supports >> variable/batt pdos and always selects the pdo with highest >> possible power within the board limit. This assumption >> m

Re: [PATCH 2/2 v7] typec: tcpm: Only request matching pdos

2017-11-27 Thread Guenter Roeck
On 11/27/2017 05:38 PM, Badhri Jagan Sridharan wrote: On Thu, Nov 23, 2017 at 3:10 AM, Adam Thomson wrote: On 16 November 2017 01:02, Badhri Jagan Sridharan wrote: At present, TCPM code assumes that local device supports variable/batt pdos and always selects the pdo with highest possible powe

Fwd: Performance regression in dwc3 ecm for linux 4.4.60

2017-11-27 Thread Arjav Parikh
Hi Team, Hope you all are doing good. Currently I am facing an bandwidth issue in dwc3 driver using ecm gadget with linux kernel version 4.4. I will quickly brief through my problem and the troubleshooting steps taken to debug the problem ISSUE : I have an embedded device with Qualcomm SOC and

[PATCH 1/1] usb: serial: usb_debug: Add new USB device id

2017-11-27 Thread Lu Baolu
USB vendor id and product id for Linux USB Debug Target is added. Signed-off-by: Lu Baolu --- drivers/usb/serial/usb_debug.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/serial/usb_debug.c b/drivers/usb/serial/usb_debug.c index ab5a2ac..47636b6 100644 --- a/drivers/usb/seria

[PATCH 1/1] usb: gadget: u_serial: Use kfifo instead of homemade circular buffer

2017-11-27 Thread Lu Baolu
The kernel FIFO implementation, kfifo, provides interfaces to manipulate a first-in-first-out circular buffer. Use kfifo instead of the homemade one to make the code more concise and readable. Signed-off-by: Lu Baolu --- drivers/usb/gadget/function/u_serial.c | 192 +

[PATCH 1/1] usb: early: Correct the endpoint type value for bulk in endpoint

2017-11-27 Thread Lu Baolu
This corrects the endpiont type value set to the DbC bulk in endpoint. The previous value doesn't cause any problems because that we now only use the bulk out endpoint. Set the hardware with the correct value any way. Signed-off-by: Lu Baolu --- drivers/usb/early/xhci-dbc.c | 2 +- 1 file change

Re: [PATCH 1/1] usb: early: Correct the endpoint type value for bulk in endpoint

2017-11-27 Thread Greg Kroah-Hartman
On Tue, Nov 28, 2017 at 12:52:24PM +0800, Lu Baolu wrote: > This corrects the endpiont type value set to the DbC bulk in endpoint. > The previous value doesn't cause any problems because that we now only > use the bulk out endpoint. Set the hardware with the correct value any > way. > > Signed-off

Re: Fwd: Performance regression in dwc3 ecm for linux 4.4.60

2017-11-27 Thread Greg KH
On Tue, Nov 28, 2017 at 09:48:57AM +0530, Arjav Parikh wrote: > Hi Team, > > Hope you all are doing good. > > Currently I am facing an bandwidth issue in dwc3 driver using ecm > gadget with linux kernel version 4.4. > > I will quickly brief through my problem and the troubleshooting steps > take

Re: EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-27 Thread Greg KH
On Mon, Nov 27, 2017 at 11:08:33PM +0100, Ladislav Michl wrote: > Hi there, > > USB hosts do not discover any connected device on OMAP3 based board > with CONFIG_PM=n. Just enabling this option is enough to restore working > behaviour. Nothing unusual in log. Tested 4.14.2 and 4.15-rc1. I know > a

Re: [PATCH 1/1] usb: early: Correct the endpoint type value for bulk in endpoint

2017-11-27 Thread Lu Baolu
Hi, On 11/28/2017 03:29 PM, Greg Kroah-Hartman wrote: > On Tue, Nov 28, 2017 at 12:52:24PM +0800, Lu Baolu wrote: >> This corrects the endpiont type value set to the DbC bulk in endpoint. >> The previous value doesn't cause any problems because that we now only >> use the bulk out endpoint. Set th