Re: [PATCH v3 14/16] phy: Add notify_speed callback

2017-12-19 Thread Kishon Vijay Abraham I
Hi, On Wednesday 20 December 2017 11:59 AM, Manu Gautam wrote: > Hi, > > > On 12/20/2017 11:19 AM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Tuesday 12 December 2017 08:54 PM, Manu Gautam wrote: >>> Hi, >>> >>> >>> On 12/12/2017 5:13 PM, Kishon Vijay Abraham I wrote: Hi, On Tu

Re: [PATCH v3 14/16] phy: Add notify_speed callback

2017-12-19 Thread Manu Gautam
Hi, On 12/20/2017 11:19 AM, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 12 December 2017 08:54 PM, Manu Gautam wrote: >> Hi, >> >> >> On 12/12/2017 5:13 PM, Kishon Vijay Abraham I wrote: >>> Hi, >>> >>> On Tuesday 21 November 2017 02:53 PM, Manu Gautam wrote: QCOM USB PHYs can monitor

Re: [PATCH v3 14/16] phy: Add notify_speed callback

2017-12-19 Thread Kishon Vijay Abraham I
Hi, On Tuesday 12 December 2017 08:54 PM, Manu Gautam wrote: > Hi, > > > On 12/12/2017 5:13 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Tuesday 21 November 2017 02:53 PM, Manu Gautam wrote: >>> QCOM USB PHYs can monitor resume/remote-wakeup event in >>> suspended state. However PHY driver

Re: [PATCH v3 02/16] phy: qcom-qmp: Adapt to clk_bulk_* APIs

2017-12-19 Thread Manu Gautam
On 12/20/2017 8:07 AM, Vivek Gautam wrote: > Hi Manu, > > [snip] > >> @@ -998,29 +992,17 @@ static int qcom_qmp_phy_reset_init(struct device *dev) >> static int qcom_qmp_phy_clk_init(struct device *dev) >> { >> struct qcom_qmp *qmp = dev_get_drvdata(dev); >> - int ret, i; >> +

Re: [PATCH v3 02/16] phy: qcom-qmp: Adapt to clk_bulk_* APIs

2017-12-19 Thread Vivek Gautam
Hi Manu, On Tue, Nov 21, 2017 at 2:53 PM, Manu Gautam wrote: > From: Vivek Gautam > > Move from using array of clocks to clk_bulk_* APIs that > are available now. > > Signed-off-by: Vivek Gautam > Signed-off-by: Manu Gautam > --- > drivers/phy/qualcomm/phy-qcom-qmp.c | 50 >

Re: [PATCH 4/5 v5] i2c: i2c-piix4: Use request_declared_muxed_region()

2017-12-19 Thread Guenter Roeck
On 12/18/2017 12:48 AM, Zoltan Boszormenyi wrote: From: Böszörményi Zoltán Use the new request_declared_muxed_region() macro to synchronize access to the I/O port pair 0xcd6 / 0xcd7. At the same time, remove the long lifetime request_region() call to reserve these I/O ports, so the sp5100_tco

Re: [PATCH 1/2] usb: musb: un-break davinci glue layer

2017-12-19 Thread Bin Liu
On Tue, Dec 19, 2017 at 05:33:14PM +, Alejandro Mery wrote: > Hi Bin, > > On 19/12/17 17:22, Bin Liu wrote: > > Hi Alejandro, > > > > On Fri, Dec 08, 2017 at 07:23:54PM +, Alejandro Mery wrote: > >> MUSB's davinci glue was made to depend on BROKEN by Felipe Balbi back in > >> 2013 because

Re: [-next PATCH 0/4] sysfs and DEVICE_ATTR_

2017-12-19 Thread Corey Minyard
On 12/19/2017 12:15 PM, Joe Perches wrote: drivers/char/ipmi/ipmi_msghandler.c| 17 +++--- For ipmi: Acked-by: Corey Minyard -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [-next PATCH 0/4] sysfs and DEVICE_ATTR_

2017-12-19 Thread Jani Nikula
On Tue, 19 Dec 2017, Joe Perches wrote: > drivers/gpu/drm/i915/i915_sysfs.c | 12 ++-- For i915, Acked-by: Jani Nikula -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majo

Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2017-12-19 Thread Andy Shevchenko
On Tue, Dec 19, 2017 at 8:15 PM, Joe Perches wrote: > Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible. > > Done with perl script: > > $ git grep -w --name-only DEVICE_ATTR | \ > xargs perl -i -e 'local $/; while (<>) { > s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(\s*S_IRUGO\s*\|\s*S_IWUSR

Re: [PATCH v2 4/4] usb: host: ehci-tegra: Remove USB_PHY dependencies from Kconfig

2017-12-19 Thread Dmitry Osipenko
On 19.12.2017 20:52, Alan Stern wrote: > On Sun, 17 Dec 2017, Dmitry Osipenko wrote: > >> Previously tegra-phy driver was built only when ehci-tegra was, now >> tegra-phy has its own Kconfig entry. Remove the USB_PHY dependencies >> from ehci-tegra's Kconfig since they aren't useful anymore. > >

[-next PATCH 0/4] sysfs and DEVICE_ATTR_

2017-12-19 Thread Joe Perches
Joe Perches (4): sysfs.h: Use octal permissions treewide: Use DEVICE_ATTR_RW treewide: Use DEVICE_ATTR_RO treewide: Use DEVICE_ATTR_WO arch/arm/mach-pxa/sharpsl_pm.c | 4 +- arch/s390/kernel/smp.c | 2 +- arch/s390/kernel/topology.c

[PATCH v1] uwb: Replace mac address parsing

2017-12-19 Thread Andy Shevchenko
Replace sscanf() with mac_pton(). Signed-off-by: Andy Shevchenko --- drivers/uwb/Kconfig | 1 + drivers/uwb/address.c | 14 -- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/uwb/Kconfig b/drivers/uwb/Kconfig index c204094e1bb4..afac2588dab4 100644 --- a/dr

[-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2017-12-19 Thread Joe Perches
Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible. Done with perl script: $ git grep -w --name-only DEVICE_ATTR | \ xargs perl -i -e 'local $/; while (<>) { s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(\s*S_IRUGO\s*\|\s*S_IWUSR|\s*S_IWUSR\s*\|\s*S_IRUGO\s*|\s*0644\s*)\)?\s*,\s*\1_show\s*,\s*

[PATCH] USB: core: Fix misuse of USB_DT_USB_SSP_CAP_SIZE()

2017-12-19 Thread Masakazu Mokuno
As USB_DT_USB_SSP_CAP_SIZE() takes SSAC value as an argument, the low bound of the size for struct usb_ssp_cap_descriptor should be described by USB_DT_USB_SSP_CAP_SIZE(0), not by USB_DT_USB_SSP_CAP_SIZE(1) The type-specific length check patch was added to stable and needs to be fixed as well. Fi

Re: [PATCH v2 4/4] usb: host: ehci-tegra: Remove USB_PHY dependencies from Kconfig

2017-12-19 Thread Alan Stern
On Sun, 17 Dec 2017, Dmitry Osipenko wrote: > Previously tegra-phy driver was built only when ehci-tegra was, now > tegra-phy has its own Kconfig entry. Remove the USB_PHY dependencies > from ehci-tegra's Kconfig since they aren't useful anymore. Are you sure they aren't useful? Does this mean i

Re: [PATCH] USB: Fix off by one in type-specific length check of BOS SSP capability

2017-12-19 Thread Masakazu Mokuno
Hi Mathias, On Tue, 19 Dec 2017 11:14:42 +0200 Mathias Nyman wrote: > USB 3.1 devices are not detected as 3.1 capable since 4.15-rc3 due to a > off by one in commit 81cf4a45360f ("USB: core: Add type-specific length > check of BOS descriptors") > > It uses USB_DT_USB_SSP_CAP_SIZE() to get SSP c

Re: [PATCH 1/2] usb: musb: un-break davinci glue layer

2017-12-19 Thread Bin Liu
Hi Alejandro, On Fri, Dec 08, 2017 at 07:23:54PM +, Alejandro Mery wrote: > MUSB's davinci glue was made to depend on BROKEN by Felipe Balbi back in > 2013 because of lack of active development. needed changes were actually > trivial > > Fixes: 787f5627bec8 (usb: musb: make davinci and da8xx

Re: [PATCH v4] usb: dwc2: host: Don't retry NAKed transactions right away

2017-12-19 Thread Doug Anderson
Hi, On Tue, Dec 19, 2017 at 8:56 AM, Stefan Wahren wrote: > Hi Doug, > >> Doug Anderson hat am 19. Dezember 2017 um 16:57 >> geschrieben: >> >> >> Felipe, >> >> On Tue, Dec 12, 2017 at 10:30 AM, Douglas Anderson >> wrote: >> ... >> >> I don't mean to be a pest, but I'm hoping that we can land

Re: [PATCH 2/5 v3] Modify behaviour of request_*muxed_region()

2017-12-19 Thread Guenter Roeck
On Tue, Dec 19, 2017 at 07:11:11AM +0100, Boszormenyi Zoltan wrote: > 2017-12-18 20:07 keltezéssel, Guenter Roeck írta: > >On Mon, Dec 18, 2017 at 09:48:38AM +0100, Zoltan Boszormenyi wrote: > >>From: Böszörményi Zoltán > >> > >>In order to make request_*muxed_region() behave more like > >>mutex_l

Re: [PATCH v4] usb: dwc2: host: Don't retry NAKed transactions right away

2017-12-19 Thread Stefan Wahren
Hi Doug, > Doug Anderson hat am 19. Dezember 2017 um 16:57 > geschrieben: > > > Felipe, > > On Tue, Dec 12, 2017 at 10:30 AM, Douglas Anderson > wrote: > ... > > I don't mean to be a pest, but I'm hoping that we can land this > somewhere (if nothing else in your /next tree) just so it doesn

Re: [PATCH v4] usb: dwc2: host: Don't retry NAKed transactions right away

2017-12-19 Thread Doug Anderson
Felipe, On Tue, Dec 12, 2017 at 10:30 AM, Douglas Anderson wrote: > On rk3288-veyron devices on Chrome OS it was found that plugging in an > Arduino-based USB device could cause the system to lockup, especially > if the CPU Frequency was at one of the slower operating points (like > 100 MHz / 200

Re: [GIT PULL] usb: chipidea fix for v4.15-rc5

2017-12-19 Thread Greg KH
On Tue, Dec 19, 2017 at 05:01:39PM +0800, Peter Chen wrote: > The following changes since commit 72b663a99c074a8d073e7ecdae446cfb024ef551: > > usb: xhci: fix TDS for MTK xHCI1.1 (2017-12-08 18:26:34 +0100) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/ker

Re: failure due to 140cb81ac8c625942a1d695875932c615767a526

2017-12-19 Thread Johan Hovold
On Tue, Dec 19, 2017 at 02:51:08PM +0100, Oliver Neukum wrote: > Hi Johan, > > I got a report from a user that their device fails with > > > cdc_acm 2-1.2:1.1: acm_start_wb - usb_submit_urb(write bulk) failed: -22 > > cdc_acm 2-1.2:1.1: acm_start_wb - usb_submit_urb(write bulk) failed: -22 > > cd

Re: MX25 USB timeout on ID 0951:1665 Kingston Technology Digital DataTraveler SE9 64GB

2017-12-19 Thread Michael Nazzareno Trimarchi
Hi Peter On Thu, Nov 16, 2017 at 10:20 AM, Peter Chen wrote: > >> > >> > All USB registers, including USB transceiver, USB non-core, and USB core. >> >> I need to have some time to go to the platform again. It will be possible >> this weekend. >> Have you any idea to restrict the debug apart reg

failure due to 140cb81ac8c625942a1d695875932c615767a526

2017-12-19 Thread Oliver Neukum
Hi Johan, I got a report from a user that their device fails with > cdc_acm 2-1.2:1.1: acm_start_wb - usb_submit_urb(write bulk) failed: -22 > cdc_acm 2-1.2:1.1: acm_start_wb - usb_submit_urb(write bulk) failed: -22 > cdc_acm 2-1.2:1.1: acm_start_wb - usb_submit_urb(write bulk) failed: -22 > cdc_

[PATCH] USB: clarify USB_DT_USB_SSP_CAP_SIZE(ssac) definition

2017-12-19 Thread Mathias Nyman
USB_DT_USB_SSP_CAP_SIZE(ssac) gives the size of the SSP capability descriptor. The descriptor consists of 12 bytes plus a array of SSA entries. The number of SSA entries is stored in a SSAC value in the first 12 bytes, The USB3.1 specification 9.6.2.5 defines SSAC as zero based: "The number of Sub

RE: [PATCH v2] USB: serial: option: adding support for YUGA CLM920-NC5

2017-12-19 Thread 林上智
> On Tue, Dec 19, 2017 at 11:14:37AM +0100, Johan Hovold wrote: > > On Tue, Dec 19, 2017 at 11:11:43AM +0100, Johan Hovold wrote: > > > On Tue, Dec 19, 2017 at 05:40:32PM +0800, SZ Lin (林上智) wrote: > > > > This patch adds support for YUGA CLM920-NC5 PID 0x9625 USB modem > > > > to option driver. >

[PATCH v4 3/3] usb: host: Implement workaround for Erratum A-009668

2017-12-19 Thread yinbo.zhu
From: yinbo.zhu This issue is observed in USB 2.0 mode when the USB 3.0 host controller is connected to a FS/LS device via a hub. The host controller issues start-split (SSPLIT) and (CSPLIT) tokens to accomplish a split-transaction. A split-transaction consists of a SSPLIT token, token/data consi

[PATCH v4 1/3] usb: host: Implement workaround for Erratum A-007463

2017-12-19 Thread yinbo.zhu
From: yinbo.zhu When a transaction error (defined in Section 4.10.2.3, "USB Transaction Error" of the xHCI Specification) occurs on the USB, the host controller reports this through a transfer event with the completion code "USB Transaction Error". When this happens, the endpoint is placed in the

[PATCH v4 2/3] usb: host: Implement workaround for Erratum A-009611

2017-12-19 Thread yinbo.zhu
From: yinbo.zhu This is a occasional problem where the software issues an End Transfer command while a USB transfer is in progress, resulting in the TxFIFO being flushed when the lower layer is waiting for data, causing the super speed (ss) transmit to get blocked. If the End Transfer command is

Re: [PATCH v2] USB: serial: option: adding support for YUGA CLM920-NC5

2017-12-19 Thread Johan Hovold
On Tue, Dec 19, 2017 at 11:14:37AM +0100, Johan Hovold wrote: > On Tue, Dec 19, 2017 at 11:11:43AM +0100, Johan Hovold wrote: > > On Tue, Dec 19, 2017 at 05:40:32PM +0800, SZ Lin (林上智) wrote: > > > This patch adds support for YUGA CLM920-NC5 PID 0x9625 USB modem to option > > > driver. > > > > > >

RE: [PATCH v2] USB: serial: option: adding support for YUGA CLM920-NC5

2017-12-19 Thread 林上智
> -Original Message- > From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold > Sent: Tuesday, December 19, 2017 6:12 PM > To: SZ Lin (林上智) > Cc: bj...@mork.no; Taiyi TY Wu (吳泰毅); Johan Hovold; Greg Kroah-Hartman; > linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org >

Re: [PATCH v2] USB: serial: option: adding support for YUGA CLM920-NC5

2017-12-19 Thread Johan Hovold
On Tue, Dec 19, 2017 at 11:11:43AM +0100, Johan Hovold wrote: > On Tue, Dec 19, 2017 at 05:40:32PM +0800, SZ Lin (林上智) wrote: > > This patch adds support for YUGA CLM920-NC5 PID 0x9625 USB modem to option > > driver. > > > > Interface layout: > > 0: QCDM/DIAG > > 1: ADB > > 2: MODEM > > 3: AT > >

[PATCH v3 3/3] usb: host: Implement workaround for Erratum A-009668

2017-12-19 Thread yinbo.zhu
From: yinbo.zhu This issue is observed in USB 2.0 mode when the USB 3.0 host controller is connected to a FS/LS device via a hub. The host controller issues start-split (SSPLIT) and (CSPLIT) tokens to accomplish a split-transaction. A split-transaction consists of a SSPLIT token, token/data consi

[PATCH v3 2/3] usb: host: Implement workaround for Erratum A-009611

2017-12-19 Thread yinbo.zhu
From: yinbo.zhu This is a occasional problem where the software issues an End Transfer command while a USB transfer is in progress, resulting in the TxFIFO being flushed when the lower layer is waiting for data, causing the super speed (ss) transmit to get blocked. If the End Transfer command is

[PATCH v3 1/3] usb: host: Implement workaround for Erratum A-007463

2017-12-19 Thread yinbo.zhu
From: yinbo.zhu When a transaction error (defined in Section 4.10.2.3, "USB Transaction Error" of the xHCI Specification) occurs on the USB, the host controller reports this through a transfer event with the completion code "USB Transaction Error". When this happens, the endpoint is placed in the

Re: [PATCH v2] USB: serial: option: adding support for YUGA CLM920-NC5

2017-12-19 Thread Johan Hovold
On Tue, Dec 19, 2017 at 05:40:32PM +0800, SZ Lin (林上智) wrote: > This patch adds support for YUGA CLM920-NC5 PID 0x9625 USB modem to option > driver. > > Interface layout: > 0: QCDM/DIAG > 1: ADB > 2: MODEM > 3: AT > 4: RMNET > > Signed-off-by: Taiyi Wu > Signed-off-by: SZ Lin (林上智) > --- > Chan

[PATCH v2] USB: serial: option: adding support for YUGA CLM920-NC5

2017-12-19 Thread 林上智
This patch adds support for YUGA CLM920-NC5 PID 0x9625 USB modem to option driver. Interface layout: 0: QCDM/DIAG 1: ADB 2: MODEM 3: AT 4: RMNET Signed-off-by: Taiyi Wu Signed-off-by: SZ Lin (林上智) --- Changes from v1: - Fix typo - Remove QCDM/DIAG interface in blacklist drivers/usb/serial/opt

[PATCH] USB: Fix off by one in type-specific length check of BOS SSP capability

2017-12-19 Thread Mathias Nyman
USB 3.1 devices are not detected as 3.1 capable since 4.15-rc3 due to a off by one in commit 81cf4a45360f ("USB: core: Add type-specific length check of BOS descriptors") It uses USB_DT_USB_SSP_CAP_SIZE() to get SSP capability size which takes the zero based SSAC as argument, not the actual count

[GIT PULL] usb: chipidea fix for v4.15-rc5

2017-12-19 Thread Peter Chen
The following changes since commit 72b663a99c074a8d073e7ecdae446cfb024ef551: usb: xhci: fix TDS for MTK xHCI1.1 (2017-12-08 18:26:34 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git/ tags/usb-ci-v4.15-rc5 for you to fetch chang

Re: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5

2017-12-19 Thread Johan Hovold
On Tue, Dec 19, 2017 at 07:14:17AM +0100, Bjørn Mork wrote: > "SZ Lin (林上智)" writes: > >> Johan Hovold writes: > >> > >> >> +static const struct option_blacklist_info yuga_clm920_nc5_blacklist = { > >> >> + .reserved = BIT(0) | BIT(1) | BIT(4), }; > >> > > >> > Do you really need to blackl

Re: [PATCH] USB: core: Add type-specific length check of BOS descriptors

2017-12-19 Thread Mathias Nyman
On 09.11.2017 18:25, Masakazu Mokuno wrote: As most of BOS descriptors are longer in length than their header 'struct usb_dev_cap_header', comparing solely with it is not sufficient to avoid out-of-bounds access to BOS descriptors. This patch adds descriptor type specific length check in usb_ge