Re: need help debugging keyboard/mouse reset issue (ehci-spear in 2.6.32.16 kernel)

2018-01-19 Thread Greg KH
On Sat, Jan 20, 2018 at 03:06:10AM +0530, Mohan R wrote: > Hi, > > I'm very new to kernel, so apologies if anything i'm typing here is wrong > > 1. I'm working on a device (ST-SPEAR600-EVB) with 2.6.32.16 kernel That is a _very_ old and obsolete kernel version from many years ago. There have bee

Problem with xhci_hcd on Gigabyte Z170X Gaming 7-EK

2018-01-19 Thread Herbert Poetzl
I've recently acquired a Gigabyte Z170X Gaming 7-EK motherboard with the Intel Z170 chipset and Sunrise Point-H USB 3.0 xHCI Controller for running Linux. Now most things seem to work fine (some problems with UEFI but that was kind of expected), but the xhci_hcd module is filling up my log files

Re: [PATCH] dts-bindings: usb-uhci: Document newly added properties

2018-01-19 Thread Benjamin Herrenschmidt
On Fri, 2018-01-19 at 17:22 -0600, Rob Herring wrote: > On Tue, Jan 16, 2018 at 11:06:15AM +1100, Benjamin Herrenschmidt wrote: > > Commit 4642d34a439f80e16af0d56ed6258a33abae257a > > "usb/uhci: Add support for Aspeed BMC SoCs" added > > support for a new #ports property, along with > > Aspeed spec

Re: [PATCH] dts-bindings: usb-uhci: Document newly added properties

2018-01-19 Thread Rob Herring
On Tue, Jan 16, 2018 at 11:06:15AM +1100, Benjamin Herrenschmidt wrote: > Commit 4642d34a439f80e16af0d56ed6258a33abae257a > "usb/uhci: Add support for Aspeed BMC SoCs" added > support for a new #ports property, along with > Aspeed specific compatible strings. This adds > documentation for them. >

need help debugging keyboard/mouse reset issue (ehci-spear in 2.6.32.16 kernel)

2018-01-19 Thread Mohan R
Hi, I'm very new to kernel, so apologies if anything i'm typing here is wrong 1. I'm working on a device (ST-SPEAR600-EVB) with 2.6.32.16 kernel 2. At random time USB keyboard/mouse disconnects and reconnects automatically 3. I tried dumping portstatus and portchange registers in drivers/usb/core

Re: Not enough bandwidth with Magewell XI100DUSB-HDMI

2018-01-19 Thread Philipp Zabel
Hi, On Fri, Jan 19, 2018 at 2:10 PM, Michael Tretter wrote: > I found the old thread and it sounds exactly like my issue. Different > camera, but same xHCI controller. I have exactly the same issue with the xHCI controller of my laptop and "Oculus Sensor" USB3 isochronous mostly-UVC cameras: 00

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

2018-01-19 Thread Guenter Roeck
On Fri, Jan 19, 2018 at 11:24:13AM +0200, Heikki Krogerus wrote: > Hi, > > On Fri, Jan 19, 2018 at 09:01:24AM +, shufan_lee(?|) wrote: > > Hi Heikki, > > > > For example, the flow of tcpci_init is a little bit different. > > In tcpci_init, there are more parameters need to be set for

Re: Not enough bandwidth with Magewell XI100DUSB-HDMI

2018-01-19 Thread Michael Tretter
On Thu, 18 Jan 2018 17:53:24 +0200, Mathias Nyman wrote: > On 17.01.2018 18:46, Michael Tretter wrote: > > Hello, > > > > I am using a Magewell XI100DUSB-HDMI frame grabber which by itself works > > fine. However, I get a "Not enough bandwidth for new device state." > > error for any other USB dev

[PATCH 17/17] usb: dwc2: pci: Handle error cleanup in probe

2018-01-19 Thread Grigor Tovmasyan
From: Vardan Mikayelyan The probe function doesn't properly handle errors. Fix it so that it properly handles cleanup. Signed-off-by: Vardan Mikayelyan Signed-off-by: John Youn Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH 16/17] usb: dwc2: pci: Move devm_kzalloc() before platform_device_add()

2018-01-19 Thread Grigor Tovmasyan
From: Vardan Mikayelyan After platform_device_add(), if we error out, we must do platform_device_unregister(), which also does the put. So lets move devm_kzalloc() to simplify error handling and avoid calling of platform_device_unregister(). Signed-off-by: Vardan Mikayelyan Signed-off-by: John

[PATCH 15/17] usb: dwc2: pci: Move usb_phy_generic_register()

2018-01-19 Thread Grigor Tovmasyan
From: Vardan Mikayelyan Move usb_phy_generic_register() function call to the top, to simplify error handling. If this fails we can simply return instead of cleaning up. Signed-off-by: Vardan Mikayelyan Signed-off-by: John Youn Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/pci.c | 14 +

[PATCH 13/17] usb: dwc2: Change TxFIFO and RxFIFO flushing flow

2018-01-19 Thread Grigor Tovmasyan
From: Minas Harutyunyan Before flushing fifos required to check AHB master state and lush when AHB master is in IDLE state. Signed-off-by: Minas Harutyunyan Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/core.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/usb/

[PATCH 14/17] usb: dwc2: pci: Replace kzalloc() with devm_kzalloc()

2018-01-19 Thread Grigor Tovmasyan
From: Vardan Mikayelyan Use devm_kzalloc() and remove the unnecessary kfree(). Signed-off-by: Vardan Mikayelyan Signed-off-by: John Youn Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/dwc2/pci.c b/d

[PATCH 12/17] usb: dwc2: host: Fix transaction errors in host mode

2018-01-19 Thread Grigor Tovmasyan
From: Minas Harutyunyan Added missing GUSBCFG programming in host mode, which fixes transaction errors issue on HiKey and Altera Cyclone V boards. These field even if was programmed in device mode (in function dwc2_hsotg_core_init_disconnected()) will be resetting to POR values after core soft r

[PATCH 10/17] usb: dwc2: Remove unnecessary debug prints

2018-01-19 Thread Grigor Tovmasyan
From: Razmik Karapetyan Removed unnecessary debug prints about DMA mode for host side from dwc2_gahbcfg_init() function. Signed-off-by: Razmik Karapetyan Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/hcd.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --

[PATCH 11/17] usb: dwc2: hcd: Fix host channel halt flow

2018-01-19 Thread Grigor Tovmasyan
From: Minas Harutyunyan According databook in Buffer and External DMA mode non-split periodic channels can't be halted. Signed-off-by: Minas Harutyunyan Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/hcd.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/u

[PATCH 09/17] usb: dwc2: Make dwc2_force_mode() static

2018-01-19 Thread Grigor Tovmasyan
Declared dwc2_force_mode() function as static, because it was used only in core.c file, for fixing sparse error. Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c index

[PATCH 08/17] usb: dwc2: Delete unused functionality

2018-01-19 Thread Grigor Tovmasyan
Deleted dwc2_hcd_dump_frrem() function, because it used undefined parameters from dwc2_hsotg structure. The function body was in #ifdef statement and was never compiled. Also removed that parameters from dwc2_hsotg structure, which were used only in dwc2_hcd_dump_frrem() function. And also delete

[PATCH 07/17] usb: dwc2: Rename bit set/clear function names

2018-01-19 Thread Grigor Tovmasyan
From: Razmik Karapetyan Renamed __orr32 and __bic32 function names to more descriptive dwc2_set_bit and dwc2_clear_bit respectively. Signed-off-by: Razmik Karapetyan Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/gadget.c | 44 ++-- 1 file changed

[PATCH 06/17] usb: dwc2: Update GINTSTS_GOUTNAKEFF interrupt handling

2018-01-19 Thread Grigor Tovmasyan
From: Razmik Karapetyan Disabled only unmasked endpoints based on DAINTMSK register. This will allow to minimize GINTSTS_GOUTNAKEFF interrupt handling. Signed-off-by: Razmik Karapetyan Signed-off-by: Minas Harutyunyan Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/gadget.c | 9

[PATCH 05/17] usb: dwc2: Update dwc2_handle_incomplete_isoc_out() function

2018-01-19 Thread Grigor Tovmasyan
From: Razmik Karapetyan In 'for' loop skipped masked and non-ISOC EPs. Also breaked 'for' loop after setting SGOUTNAK in DCTL,when one enabled EP was detected. This will allow to minimize incomplete ISOC OUT interrupt handling. Signed-off-by: Razmik Karapetyan Signed-off-by: Minas Harutyunyan

[PATCH 01/17] usb: dwc2: Update bit polling functionality

2018-01-19 Thread Grigor Tovmasyan
From: Sevak Arakelyan Move dwc2_hsotg_wait_bit_set function to core.c so it can be used anywhere in the code. Added dwc2_hsotg_wait_bit_clear function in core.c. Replace all the parts of register bit polling code with dwc2_hsotg_wait_bit_set or dwc2_hsotg_wait_bit_clear functions calls depends

[PATCH 03/17] usb: dwc2: Set AHB burst size to INCR

2018-01-19 Thread Grigor Tovmasyan
From: Razmik Karapetyan Changed AHB burst size from INCR4 to INCR by default. With this value driver shows excellent DMA performance. Signed-off-by: Razmik Karapetyan Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/core.h | 2 +- drivers/usb/dwc2/params.c | 2 +- 2 files changed, 2 ins

[PATCH 04/17] usb: dwc2: Update dwc2_handle_incomplete_isoc_in() function

2018-01-19 Thread Grigor Tovmasyan
From: Razmik Karapetyan Disabled only that ISOC endpoints,for which interrupt bit was set in the DAINTMSK register. This will allow to minimize incomplete ISOC IN interrupt handling. Signed-off-by: Razmik Karapetyan Signed-off-by: Minas Harutyunyan Signed-off-by: Grigor Tovmasyan --- drivers

[PATCH 02/17] usb: dwc2: Use AHB burst size parameter

2018-01-19 Thread Grigor Tovmasyan
From: Razmik Karapetyan In dwc2_hsotg_core_init_disconnected() function used AHB burst size parameter, instead of calculating already calculated value. Signed-off-by: Razmik Karapetyan Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[PATCH 00/17] usb: dwc2: improvements

2018-01-19 Thread Grigor Tovmasyan
This series contains patches which are already have been sent in "usb: dwc2: fixes, enhancements and new features" series. That patch series was too large, and based on community feedbacks decided to split that series into small pieces. This is a second part. In this series we included only impr

Re: [BUG] SD card reader disappears after suspend

2018-01-19 Thread Samuel Sadok
Hi! I just noticed I hit the wrong reply button. Here's what I replied to Alexander: I just tried `echo 0 > /sys/bus/usb/devices/2-4/power/persist`, however the card reader is still missing after suspend/resume. Here's the new kernel log: [ 2241.861114] pcieport :00:1c.3: Enabling MPC IRBNCE

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

2018-01-19 Thread Heikki Krogerus
Hi, On Fri, Jan 19, 2018 at 09:01:24AM +, shufan_lee(?|) wrote: > Hi Heikki, > > For example, the flow of tcpci_init is a little bit different. > In tcpci_init, there are more parameters need to be set for RT1711H. Different init parameters is really not a reason for a fork of the dr

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

2018-01-19 Thread 李書帆
Hi Heikki, For example, the flow of tcpci_init is a little bit different. In tcpci_init, there are more parameters need to be set for RT1711H. Best Regards, * Shu-Fan Lee Richtek Technology Corporation TEL: +886-3-5526789 #2359 FAX: +886-3-5526612 *

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

2018-01-19 Thread Heikki Krogerus
Hi Shu-Fan, On Fri, Jan 19, 2018 at 05:48:02AM +, shufan_lee(?) wrote: > Hi Jun, > > For now, RT1711H is not fully compatible with TCPCI. So the existing tcpci.c > may not work for it. The datasheet for RT1711H does talk about TCPCi and TCPM+TCPC [1]. What are the differences tha

Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

2018-01-19 Thread 'Greg KH'
On Thu, Jan 18, 2018 at 01:13:15PM +, shufan_lee(李書帆) wrote: > > + > > +#include "rt1711h.h" > > Why a .h file for a single .c file? > > Is the suggestion to move all content in rt1711h.h into rt1711h.c? If it can be, sure, you only need a .h file for things that are shared among other .c fi

Re: [BUG] usbfs "did not claim interface before use"

2018-01-19 Thread Greg Kroah-Hartman
On Thu, Jan 18, 2018 at 07:32:11AM -0800, Matthew Wilcox wrote: > > My laptop just died horribly and I'm picking through the pieces. > I'm running Debian testing, and it was kernel 4.13.0-1-amd64 #1 Debian > 4.13.13-1 although now I've rebooted to 4.14.0-2-amd64 #1 SMP Debian > 4.14.7-1 > > It se