Re: Q: Does mass storage gadget use DMA ?

2018-02-05 Thread Felipe Balbi
Hi, Ran Shalit writes: > Hello, > > I check code in: > https://elixir.free-electrons.com/linux/v3.3/source/drivers/usb/gadget/f_mass_storage.c > but I see no API usage of DMA, yet it is being mentioned as if it is used. but it is used. It's just managed by the UDC driver

Re: Q: Does mass storage gadget use DMA ?

2018-02-05 Thread Felipe Balbi
Hi, Felipe Balbi writes: >> I check code in: >> https://elixir.free-electrons.com/linux/v3.3/source/drivers/usb/gadget/f_mass_storage.c ps: v3.3 realy??? You really need to upgrade that :-) -- balbi -- To unsubscribe from this list: send the line

Re: power management problems in ehci-omap

2018-02-05 Thread Andreas Kemnade
On Sun, 4 Feb 2018 09:43:45 +0100 Michael Nazzareno Trimarchi wrote: > Hi Andreas > > On Sun, Feb 4, 2018 at 9:38 AM, Andreas Kemnade wrote: > > On Sun, 4 Feb 2018 00:10:50 +0100 > > Michael Nazzareno Trimarchi

Re: [PATCH 00/17] usb: dwc2: improvements

2018-02-05 Thread John Youn
On 01/19/2018 02:39 AM, Grigor Tovmasyan wrote: This series contains patches which are already have been sent in "usb: dwc2: fixes, enhancements and new features" series. That patch series was too large, and based on community feedbacks decided to split that series into small pieces. This is a

Re: [PATCH 0/6] usb: dwc2: minor fixes

2018-02-05 Thread John Youn
On 01/16/2018 04:03 AM, Grigor Tovmasyan wrote: This series contains patches which are already have been sent in "usb: dwc2: fixes, enhancements and new features" series. That patch series was too large, and based on community feedbacks decided to split that series into small pieces. This is a

Re: [PATCH] usb: dwc2: gadget: Use true and false for boolean values

2018-02-05 Thread John Youn
On 01/23/2018 07:45 AM, Gustavo A. R. Silva wrote: Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/usb/dwc2/gadget.c | 4 ++-- 1 file changed,

Re: [PATCH] usb: gadget: f_fs: get the correct address of comp_desc

2018-02-05 Thread Jack Pham
Hi William, On Mon, Feb 05, 2018 at 07:33:38PM +0800, William Wu wrote: > Refer to the USB 3.0 spec '9.6.7 SuperSpeed Endpoint Companion', > the companion descriptor follows the standard endpoint descriptor. > This descriptor is only defined for SuperSpeed endpoints. The > f_fs driver gets the

Re: usb: uas: device reset most the time while enumeration- usb3.0

2018-02-05 Thread Tushar Nimkar
Greg, I have cherry-picked 9 patches as follows. d921462 USB: uas and storage: Add US_FL_BROKEN_FUA for another JMicron JMS567 ID d7321ce uas: Add US_FL_IGNORE_RESIDUE for Initio Corporation INIC-3069 b3568a9 uas: Always apply US_FL_NO_ATA_1X quirk to Seagate devices 66215a3 USB: uas: fix

Re: usb: uas: device reset most the time while enumeration- usb3.0

2018-02-05 Thread Greg KH
On Mon, Feb 05, 2018 at 11:34:40PM +0530, Tushar Nimkar wrote: > Hi , > > I am enabling uas support. And facing the issue as follows. > > I have observed that when ( Transcend StoreJet TS256GESD400K ) > connected to my custom board, it detects first then > uas_eh_abort_handler() get call and

usb: uas: device reset most the time while enumeration- usb3.0

2018-02-05 Thread Tushar Nimkar
Hi , I am enabling uas support. And facing the issue as follows. I have observed that when ( Transcend StoreJet TS256GESD400K ) connected to my custom board, it detects first then uas_eh_abort_handler() get call and then reset and enumerates properly.When same device is used with 2.0 HUB their

[PATCH 4.4 v2 2/2] usbip: fix 3eee23c3ec14 tcp_socket address still in the status file

2018-02-05 Thread Shuah Khan
Commit 3eee23c3ec14 ("usbip: prevent vhci_hcd driver from leaking a socket pointer address") backported the following commit from mailine. However, backport error caused the tcp_socket address to still leak. commit 2f2d0088eb93 ("usbip: prevent vhci_hcd driver from leaking a socket pointer

[PATCH 4.4 v2 1/2] usbip: vhci_hcd: clear just the USB_PORT_STAT_POWER bit

2018-02-05 Thread Shuah Khan
Upstream commit 1c9de5bf4286 ("usbip: vhci-hcd: Add USB3 SuperSpeed support") vhci_hcd clears all the bits port_status bits instead of clearing just the USB_PORT_STAT_POWER bit when it handles ClearPortFeature: USB_PORT_FEAT_POWER. This causes vhci_hcd attach to fail in a bad state, leaving

[PATCH 4.4 v2 0/2] Backports for fixes

2018-02-05 Thread Shuah Khan
The first patch in this series isolates and backports a fix to clear just the USB_PORT_STAT_POWER. Without this fix, client can't use the imported device. The second patch is fix to back-ported commit 3eee23c3ec14. tcp_socket address still present in the status file. This is my bad. The bug fixed

Re: [Bug 197863] Thinkpad X240 resume dramatically slower on kernels 4.13+

2018-02-05 Thread Rafael J. Wysocki
On 2/5/2018 3:14 PM, Bjørn Mork wrote: "Rafael J. Wysocki" writes: On 2/4/2018 9:28 PM, Bjørn Mork wrote: But I do wonder if the attached (completely untested!!) patch makes things any better? I don't think so, the macro is needed too. Doh! Obviously. Don't

Re: [PATH 0/4] usbip: make vhci_hcd.* objects independent of vhci_hcd.0

2018-02-05 Thread Shuah Khan
On 01/30/2018 01:36 AM, Salvador Fandino wrote: > Let me start by explaining the problem that have motivated me to write > this patches: > > I work on the QVD, a virtual desktop platform for Linux. This software > runs Linux desktops (i.e. XFCE, KDE) and their applications inside LXC >

Q: Does mass storage gadget use DMA ?

2018-02-05 Thread Ran Shalit
Hello, I check code in: https://elixir.free-electrons.com/linux/v3.3/source/drivers/usb/gadget/f_mass_storage.c but I see no API usage of DMA, yet it is being mentioned as if it is used. Is it that DMA used in this driver ? Why can't I find any DMA APIs inside? Thank you, Ran -- To unsubscribe

Re: [PATCH v2 1/1] usb: host: ehci: always enable interrupt for qtd completion at test mode

2018-02-05 Thread Alan Stern
On Mon, 5 Feb 2018, Peter Chen wrote: > At former code, the SETUP stage does not enable interrupt > for qtd completion, it relies on IAA watchdog to complete > interrupt, then the transcation would be considered timeout > if the flag need_io_watchdog is cleared by platform code. > > In this

Re: [Bug 197863] Thinkpad X240 resume dramatically slower on kernels 4.13+

2018-02-05 Thread Bjørn Mork
"Rafael J. Wysocki" writes: > On 2/4/2018 9:28 PM, Bjørn Mork wrote: > >> But I do wonder if the attached (completely untested!!) patch makes >> things any better? > > I don't think so, the macro is needed too. Doh! Obviously. Don't know how I managed to miss that.

[PATCH] usb: gadget: f_fs: get the correct address of comp_desc

2018-02-05 Thread William Wu
Refer to the USB 3.0 spec '9.6.7 SuperSpeed Endpoint Companion', the companion descriptor follows the standard endpoint descriptor. This descriptor is only defined for SuperSpeed endpoints. The f_fs driver gets the address of the companion descriptor via 'ds + USB_DT_ENDPOINT_SIZE', and actually,

Re: [Bug 197863] Thinkpad X240 resume dramatically slower on kernels 4.13+

2018-02-05 Thread Rafael J. Wysocki
On 2/4/2018 9:28 PM, Bjørn Mork wrote: Greg KH writes: On Sat, Feb 03, 2018 at 07:25:54PM +0100, Markus Demleitner wrote: It's 662591461c4b9a1e3b9b159dbf37648a585ebaae. To my eyes, it even looks plausible that it's causing the problematic behaviour, but since I

RE: [PATCH v4 0/7] typec: tcpm: Add sink side support for PPS

2018-02-05 Thread Adam Thomson
On 30 January 2018 13:25, Heikki Krogerus wrote: > On Tue, Jan 02, 2018 at 03:50:48PM +, Adam Thomson wrote: > > This patch set adds sink side support for the PPS feature introduced in the > > USB PD 3.0 specification. > > > > The source PPS supply is represented using the Power Supply

Re: [RFC PATCH v2 1/5] dt-bindings: add bindings for USB physical connector

2018-02-05 Thread Andrzej Hajda
On 05.02.2018 07:08, Rob Herring wrote: > On Wed, Jan 31, 2018 at 02:44:31PM +0100, Andrzej Hajda wrote: >> These bindings allow to describe most known standard USB connectors >> and it should be possible to extend it if necessary. >> USB connectors, beside USB can be used to route other

Re: power management problems in ehci-omap

2018-02-05 Thread Andreas Kemnade
On Sun, 4 Feb 2018 11:55:02 +0100 Michael Nazzareno Trimarchi wrote: > Hi Andreas > > On Sun, Feb 4, 2018 at 11:50 AM, Andreas Kemnade wrote: > > Hi, > > > > On Sun, 4 Feb 2018 09:43:45 +0100 > > Michael Nazzareno Trimarchi

[PATCH] usb: renesas_usbhs: missed the "running" flag in usb_dmac with rx path

2018-02-05 Thread Yoshihiro Shimoda
This fixes an issue that a gadget driver (usb_f_fs) is possible to stop rx transactions after the usb-dmac is used because the following functions missed to set/check the "running" flag. - usbhsf_dma_prepare_pop_with_usb_dmac() - usbhsf_dma_pop_done_with_usb_dmac() So, if next transaction uses