Re: [v6] usb: ohci: Proper handling of ed_rm_list to handle race condition between usb_kill_urb() and finish_unlinks()

Hi, On 25 March 2018 at 12:21, Jonathan Liu wrote: > Hi, > > On 8 February 2018 at 14:55, Jeffy Chen wrote: >> From: AMAN DEEP >> >> There is a race condition between finish_unlinks->finish_urb() function >> and usb_kill_urb()

Re: [PATCH v6 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

On Sat, 2018-03-24 at 12:19 +1100, Benjamin Herrenschmidt wrote: > > In function ‘memcpy’, > > inlined from ‘ast_vhub_rep_desc’ at > > drivers/usb/gadget/udc/aspeed-vhub/hub.c:276:2: > > ./include/linux/string.h:341:4: error: call to ‘__read_overflow2’ declared > > with attribute error:

Re: [v6] usb: ohci: Proper handling of ed_rm_list to handle race condition between usb_kill_urb() and finish_unlinks()

Hi, On 8 February 2018 at 14:55, Jeffy Chen wrote: > From: AMAN DEEP > > There is a race condition between finish_unlinks->finish_urb() function > and usb_kill_urb() in ohci controller case. The finish_urb calls > spin_unlock(>lock) before

[PATCH] usb: host: Remove the deprecated ATH79 USB host config options

The options USB_EHCI_ATH79 and USB_OHCI_ATH79 only enable the generic EHCI and OHCI platform drivers, and have been marked as deprecated since 2012. These can be safely removed if we make sure that USB_EHCI_ROOT_HUB_TT still get enabled for the EHCI driver. This is now done be selecting this

[PATCH] net: qmi_wwan: add BroadMobi BM806U 2020:2033

BroadMobi BM806U is an Qualcomm MDM9225 based 3G/4G modem. Tested hardware BM806U is mounted on D-Link DWR-921-C3 router. The USB id is added to qmi_wwan.c to allow QMI communication with the BM806U. Tested on 4.14 kernel and OpenWRT. Signed-off-by: Pawel Dembicki ---

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

On Sat 2018-03-24 07:25:17, Tony Lindgren wrote: > * Dan Williams [180324 14:00]: > > On Fri, 2018-03-23 at 21:13 +0100, Pavel Machek wrote: > > > Does ofonod work for you? I could not get that one to work... > > > > Because it's looking for a Gobi modem but the MDM6600 isn't

RE: [PATCH] usb: dwc3: gadget: Correct the logic for queuing sgs

Hi Felipe, Thanks for providing your inputs on this patch. Will send v2 with all your suggestions added. Thanks, Anurag Kumar Vulisha >-Original Message- >From: Felipe Balbi [mailto:ba...@kernel.org] >Sent: Friday, March 23, 2018 4:59 PM >To: Anurag Kumar Vulisha ;

Re: [PATCH v2] USB: announce bcdDevice as well as idVendor, idProduct.

On Sat, Mar 24, 2018 at 12:06:20PM -0400, Alan Stern wrote: > > + dev_info(>dev, > > +"New USB device found, idVendor=%04x, idProduct=%04x, > > bcdDevice=%2x.%02x\n", > > +le16_to_cpu(udev->descriptor.idVendor), > > Unnecessary and incorrect whitespace changes. Thanks

[PATCH v3] USB: announce bcdDevice as well as idVendor, idProduct.

Print bcdDevice which is used by vendors to identify different versions of the same product (or different versions of firmware). Adding this to the logs will be useful for support purposes. Match the %2x.%02x formatting that's used by lsusb -v for this same value. Signed-off-by: Benson Leung

Re: [PATCH v2] USB: announce bcdDevice as well as idVendor, idProduct.

On Fri, 23 Mar 2018, Benson Leung wrote: > Print bcdDevice which is used by vendors to identify different versions > of the same product (or different versions of firmware). > > Adding this to the logs will be useful for support purposes. > > Match the %2x.%02x formatting that's used by lsusb

UVC VGA WebCam: USB2.0 is listed as two video devices

Manjaro Linux x86_64 linux416 4.16.r180324.g99fec39-1 Weird bug. My webcam is listed twice dmesg [    3.264159] uvcvideo: Found UVC 1.00 device USB 2.0 UVC VGA WebCam (13d3:5710) [    3.270673] input: USB 2.0 UVC VGA WebCam: USB2.0  as

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

* Dan Williams [180324 14:00]: > On Fri, 2018-03-23 at 21:13 +0100, Pavel Machek wrote: > > Does ofonod work for you? I could not get that one to work... > > Because it's looking for a Gobi modem but the MDM6600 isn't one and > doesn't expose that layout (and doesn't really need

[RFC usb-next v2 1/2] usb: core: split usb_phy_roothub_{init,alloc}

Before this patch usb_phy_roothub_init served two purposes (from a caller's point of view - like hcd.c): - parsing the PHYs and allocating the list entries - calling phy_init on each list entry While this worked so far it has one disadvantage: if we need to call phy_init for each PHY instance

[RFC usb-next v2 0/2] fix HCD PHY suspend handling

This is a follow-up to my previous series "initialize (multiple) PHYs for a HCD": [0]. Roger Quadros reported [1] that it "is breaking low power cases on TI SoCs when USB is in host mode". He further explains that "Not doing the phy_exit() here [when entering suspend] leaves the clocks enabled on

[RFC usb-next v2 2/2] usb: core: use phy_exit during suspend if wake up is not supported

If the USB controller can wake up the system (which is the case for example with the Mediatek USB3 IP) then we must not call phy_exit during suspend to ensure that the USB controller doesn't have to re-enumerate the devices during resume. However, if the USB controller cannot wake up the system

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

On Fri, 2018-03-23 at 21:13 +0100, Pavel Machek wrote: > On Fri 2018-03-23 12:35:21, Sebastian Reichel wrote: > > Hi, > > > > On Fri, Mar 23, 2018 at 11:54:55AM +0100, Pavel Machek wrote: > > > Hi! > > > > > > > > > Do you have the related dts patches picked from next? > > > > > > > > > > > >

[PATCH usb-next v1] usb: core: phy: fix return value of usb_phy_roothub_exit()

usb_phy_roothub_exit() should return the error code from the phy_exit() call if exiting the PHY failed. However, since a wrong variable is used usb_phy_roothub_exit() currently always returns 0, even if one of the phy_exit calls returned an error. Fix this by assigning the error code from

Re: [PATCH usb-next v10 3/8] usb: core: add a wrapper for the USB PHYs on the HCD

Hi Roger, On Wed, Mar 21, 2018 at 12:30 PM, Roger Quadros wrote: > Martin, > > On 21/03/18 00:01, Martin Blumenstingl wrote: >> Hi Roger, Hi Chunfeng, >> >> On Tue, Mar 20, 2018 at 1:04 PM, Chunfeng Yun >> wrote: >>> Hi Martin & Roger: >>> >>> On Mon,