Re: [RFC usb-next v3 2/2] usb: core: use phy_exit during suspend if wake up is not supported

hi, On Mon, 2018-03-26 at 22:38 +0200, Martin Blumenstingl wrote: > If the USB controller can wake up the system (which is the case for > example with the Mediatek USB3 IP) then we must not call phy_exit during > suspend to ensure that the USB controller doesn't have to re-enumerate > the devices

Re: [RFC usb-next v3 1/2] usb: core: split usb_phy_roothub_{init,alloc}

hi, On Mon, 2018-03-26 at 22:38 +0200, Martin Blumenstingl wrote: > Before this patch usb_phy_roothub_init served two purposes (from a > caller's point of view - like hcd.c): > - parsing the PHYs and allocating the list entries > - calling phy_init on each list entry > > While this worked so far

Re: [PATCH usb-next v1] usb: core: phy: fix return value of usb_phy_roothub_exit()

Hi, On Mon, 2018-03-26 at 22:12 +0200, Martin Blumenstingl wrote: > Hi Chunfeng, > > On Mon, Mar 26, 2018 at 5:43 AM, Chunfeng Yun > wrote: > > On Sat, 2018-03-24 at 14:56 +0100, Martin Blumenstingl wrote: > >> usb_phy_roothub_exit() should return the error code from

Re: [RFC usb-next v2 1/2] usb: core: split usb_phy_roothub_{init,alloc}

On Mon, 2018-03-26 at 22:31 +0200, Martin Blumenstingl wrote: > Hi Chunfeng, > > On Mon, Mar 26, 2018 at 5:37 AM, Chunfeng Yun > wrote: > > On Sat, 2018-03-24 at 15:21 +0100, Martin Blumenstingl wrote: > >> Before this patch usb_phy_roothub_init served two purposes

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

* Dan Williams [180326 15:18]: > On Sun, 2018-03-25 at 13:52 -0700, Tony Lindgren wrote: > > Anyways, looks like qmi_wwan needs to be loaded before > > qcserial module, otherwise we get nine ttyUSB instances > > and ModemManager can't find any modems. > > Use qcaux.c or option,

Re: [PATCH v2 3/5] dt-bindings: usb: fusb302: remove max-sink-* properties

On Fri, Mar 23, 2018 at 10:58:45PM +0800, Li Jun wrote: > Remove max-sink-* properties since they are deprecated. > > Signed-off-by: Li Jun > --- > Documentation/devicetree/bindings/usb/fcs,fusb302.txt | 6 -- > 1 file changed, 6 deletions(-) Reviewed-by: Rob Herring

Re: [PATCH v4 2/2] dt-bindings: usb: rt1711h device tree binding document

On Tue, Mar 20, 2018 at 05:15:04PM +0800, ShuFan Lee wrote: > From: ShuFan Lee > > Add device tree binding document for Richtek RT1711H Type-C chip driver > > Signed-off-by: ShuFan Lee > --- > .../devicetree/bindings/usb/richtek,rt1711h.txt|

[RFC usb-next v3 2/2] usb: core: use phy_exit during suspend if wake up is not supported

If the USB controller can wake up the system (which is the case for example with the Mediatek USB3 IP) then we must not call phy_exit during suspend to ensure that the USB controller doesn't have to re-enumerate the devices during resume. However, if the USB controller cannot wake up the system

[RFC usb-next v3 0/2] fix HCD PHY suspend handling

This is a follow-up to my previous series "initialize (multiple) PHYs for a HCD": [0]. Roger Quadros reported [1] that it "is breaking low power cases on TI SoCs when USB is in host mode". He further explains that "Not doing the phy_exit() here [when entering suspend] leaves the clocks enabled on

[RFC usb-next v3 1/2] usb: core: split usb_phy_roothub_{init,alloc}

Before this patch usb_phy_roothub_init served two purposes (from a caller's point of view - like hcd.c): - parsing the PHYs and allocating the list entries - calling phy_init on each list entry While this worked so far it has one disadvantage: if we need to call phy_init for each PHY instance

Re: [RFC usb-next v2 1/2] usb: core: split usb_phy_roothub_{init,alloc}

Hi Chunfeng, On Mon, Mar 26, 2018 at 5:37 AM, Chunfeng Yun wrote: > On Sat, 2018-03-24 at 15:21 +0100, Martin Blumenstingl wrote: >> Before this patch usb_phy_roothub_init served two purposes (from a >> caller's point of view - like hcd.c): >> - parsing the PHYs and

Re: [PATCH usb-next v1] usb: core: phy: fix return value of usb_phy_roothub_exit()

Hi Chunfeng, On Mon, Mar 26, 2018 at 5:43 AM, Chunfeng Yun wrote: > On Sat, 2018-03-24 at 14:56 +0100, Martin Blumenstingl wrote: >> usb_phy_roothub_exit() should return the error code from the phy_exit() >> call if exiting the PHY failed. >> However, since a wrong

Re: [PATCH 1/2] usb: gadget: udc: core: update usb_ep_queue() documentation

Oops; I was looking at kernel version v4.14-rc2. Tuba Yavuz, Ph.D. Assistant Professor Electrical and Computer Engineering Department University of Florida Gainesville, FL 32611 Webpage: http://www.tuba.ece.ufl.edu/ Email: t...@ece.ufl.edu Phone: (352) 846 0202

Re: [PATCH 1/2] usb: gadget: udc: core: update usb_ep_queue() documentation

On Mon, 26 Mar 2018, Yavuz, Tuba wrote: > I agree with Alan that the spinlock must be dropped before calling > usb_ep_queue. An example can be found in the ep0_queue function of > the f_mass_storage driver. Thanks for the note of support, but you must be looking at a different version of the

Re: [PATCH] usb: host: Remove the deprecated ATH79 USB host config options

On Sat, 24 Mar 2018, Alban Bedel wrote: > The options USB_EHCI_ATH79 and USB_OHCI_ATH79 only enable the > generic EHCI and OHCI platform drivers, and have been marked as > deprecated since 2012. > > These can be safely removed if we make sure that USB_EHCI_ROOT_HUB_TT > still get enabled for the

Re: [PATCH v3] USB: announce bcdDevice as well as idVendor, idProduct.

On Sat, 24 Mar 2018, Benson Leung wrote: > Print bcdDevice which is used by vendors to identify different versions > of the same product (or different versions of firmware). > > Adding this to the logs will be useful for support purposes. > > Match the %2x.%02x formatting that's used by lsusb

Re: [PATCH 1/2] usb: gadget: udc: core: update usb_ep_queue() documentation

I agree with Alan that the spinlock must be dropped before calling usb_ep_queue. An example can be found in the ep0_queue function of the f_mass_storage driver. Best, Tuba Yavuz, Ph.D. Assistant Professor Electrical and Computer Engineering Department University of Florida Gainesville, FL

Re: [PATCH 1/2] usb: gadget: udc: core: update usb_ep_queue() documentation

On Mon, 26 Mar 2018, Felipe Balbi wrote: > Mention that ->complete() should never be called from within > usb_ep_queue(). > > Signed-off-by: Felipe Balbi > --- > drivers/usb/gadget/udc/core.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [PATCHv2] net/usb/qmi_wwan.c: Add USB id for lt4120 modem

From: Torsten Hilbrich Date: Mon, 26 Mar 2018 07:19:57 +0200 > This is needed to support the modem found in HP EliteBook 820 G3. > > Signed-off-by: Torsten Hilbrich Applied, thank you. -- To unsubscribe from this list: send the line

Re: [PATCH] net: qmi_wwan: add BroadMobi BM806U 2020:2033

From: Pawel Dembicki Date: Sat, 24 Mar 2018 22:08:14 +0100 > BroadMobi BM806U is an Qualcomm MDM9225 based 3G/4G modem. > Tested hardware BM806U is mounted on D-Link DWR-921-C3 router. > The USB id is added to qmi_wwan.c to allow QMI communication with > the BM806U. > >

Re: [PATCH 4/4] drivers/net: Use octal not symbolic permissions

From: Joe Perches Date: Fri, 23 Mar 2018 15:54:39 -0700 > Prefer the direct use of octal for permissions. > > Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace > and some typing. > > Miscellanea: > > o Whitespace neatening around these conversions. > >

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

On Sun, 2018-03-25 at 13:52 -0700, Tony Lindgren wrote: > * Pavel Machek [180325 19:00]: > > Hi! > > > > > > Hmm. Interesting. Anyway, for me ttyUSB4 is interesting, as it > > > > seems > > > > to react to AT commands, and in particular reacts to ADT123; (; > > > > is > > > >

Re: [PATCH 4/4] drivers/net: Use octal not symbolic permissions

On Fri, Mar 23, 2018 at 03:54:39PM -0700, Joe Perches wrote: > Prefer the direct use of octal for permissions. > > Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace > and some typing. > > Miscellanea: > > o Whitespace neatening around these conversions. > > Signed-off-by: Joe

Re: [PATCH v7 2/6] Documentation: power: Initial effort to document power_supply ABI

On Mon, Mar 26, 2018 at 12:40:06PM +, Adam Thomson wrote: > On 26 March 2018 10:57, Greg Kroah-Hartman wrote: > > > On Fri, Mar 23, 2018 at 10:12:21AM +, Adam Thomson wrote: > > > This commit adds generic ABI information regarding power_supply > > > properties. This is an initial attempt

RE: [PATCH v7 2/6] Documentation: power: Initial effort to document power_supply ABI

On 26 March 2018 10:57, Greg Kroah-Hartman wrote: > On Fri, Mar 23, 2018 at 10:12:21AM +, Adam Thomson wrote: > > This commit adds generic ABI information regarding power_supply > > properties. This is an initial attempt to try and align the usage > > of these properties between drivers. As

Re: [Regression] xhci: some hard drives cannot be seen using a JMicron JMS56x enclosure

On 24.03.2018 06:37, Cyril Roelandt wrote: Hello, On 03/07/18 17:16, Mathias Nyman wrote: I can try to write a workaround that sets dequeue pointers for both the stream we want, and the current active stream for each URB canceling. Is there a branch from which I could pull the workaround

Re: [PATCH v4] usb: dwc2: dwc2_vbus_supply_init: fix error check

Am Montag, 26. März 2018, 11:00:01 CEST schrieb Tomeu Vizoso: > devm_regulator_get_optional returns -ENODEV if the regulator isn't > there, so if that's the case we have to make sure not to leave -ENODEV > in the regulator pointer. > > Also, make sure we return 0 in that case, but correctly

Re: [PATCH 2/2] usb: dwc3: gadget: never call ->complete() from ->ep_queue()

On Mon, Mar 26, 2018 at 01:14:47PM +0300, Felipe Balbi wrote: > This is a requirement which has always existed but, somehow, wasn't > reflected in the documentation and problems weren't found until now > when Tuba Yavuz found a possible deadlock happening between dwc3 and > f_hid. She described

Re: [PATCH v4] usb: dwc2: dwc2_vbus_supply_init: fix error check

Hi, On 03/26/2018 11:00 AM, Tomeu Vizoso wrote: > devm_regulator_get_optional returns -ENODEV if the regulator isn't > there, so if that's the case we have to make sure not to leave -ENODEV > in the regulator pointer. > > Also, make sure we return 0 in that case, but correctly propagate any >

[PATCH 2/2] usb: dwc3: gadget: never call ->complete() from ->ep_queue()

This is a requirement which has always existed but, somehow, wasn't reflected in the documentation and problems weren't found until now when Tuba Yavuz found a possible deadlock happening between dwc3 and f_hid. She described the situation as follows: spin_lock_irqsave(>write_spinlock, flags); //

[PATCH 1/2] usb: gadget: udc: core: update usb_ep_queue() documentation

Mention that ->complete() should never be called from within usb_ep_queue(). Signed-off-by: Felipe Balbi --- drivers/usb/gadget/udc/core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index

[PATCH] usb: xhci-mtk: remove redundant MODULE_ALIAS entries

From: Sean Wang MODULE_ALIAS exports information to allow the module to be auto-loaded at boot for the drivers registered using legacy platform registration. However, currently the driver is always used by DT-only platform, MODULE_ALIAS is redundant and should be removed

Re: [PATCH v7 2/6] Documentation: power: Initial effort to document power_supply ABI

On Fri, Mar 23, 2018 at 10:12:21AM +, Adam Thomson wrote: > This commit adds generic ABI information regarding power_supply > properties. This is an initial attempt to try and align the usage > of these properties between drivers. As part of this commit, > common Battery and USB related

Re: [RFC usb-next v2 1/2] usb: core: split usb_phy_roothub_{init,alloc}

On 24/03/18 16:21, Martin Blumenstingl wrote: > Before this patch usb_phy_roothub_init served two purposes (from a > caller's point of view - like hcd.c): > - parsing the PHYs and allocating the list entries > - calling phy_init on each list entry > > While this worked so far it has one

Re: [RFC usb-next v2 2/2] usb: core: use phy_exit during suspend if wake up is not supported

Hi, On 24/03/18 16:21, Martin Blumenstingl wrote: > If the USB controller can wake up the system (which is the case for > example with the Mediatek USB3 IP) then we must not call phy_exit during > suspend to ensure that the USB controller doesn't have to re-enumerate > the devices during resume.

Re: Possible deadlock due to double spinlock in /drivers/usb/gadget/function/f_hid

Hi, Greg KH writes: > For some reason, Tuba can't seem to post to linux-usb@vger, so I'm > forwarding on his message below. > > Felipe, sorry if you have seen this 3+ times already :( > > thanks, > > greg k-h > > On Fri, Mar 23, 2018 at 01:05:28PM +, Yavuz, Tuba

Re: [PATCH v1 3/3] usb: dwc2: Add High Bandwidth ISOC OUT support

Hi Minas, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20180309] [cannot apply to v4.16-rc4 v4.16-rc3 v4.16-rc2 v4.16-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH v4] usb: dwc2: dwc2_vbus_supply_init: fix error check

devm_regulator_get_optional returns -ENODEV if the regulator isn't there, so if that's the case we have to make sure not to leave -ENODEV in the regulator pointer. Also, make sure we return 0 in that case, but correctly propagate any other errors. Also propagate the error from _dwc2_hcd_start.

Re: UVC VGA WebCam: USB2.0 is listed as two video devices

> it have buttons? That looks like the input layer This don't have any buttons. Regards, FM dmesg | grep uvc [    3.991743] uvcvideo: Found UVC 1.00 device USB 2.0 UVC VGA WebCam (13d3:5710) [    3.998105] uvcvideo 1-1.3:1.0: Entity type for entity Extension 7 was not initialized! [   

Re: UVC VGA WebCam: USB2.0 is listed as two video devices

Am Samstag, den 24.03.2018, 16:53 +0100 schrieb fademind: > Manjaro Linux x86_64 > > linux416 4.16.r180324.g99fec39-1 > > Weird bug. My webcam is listed twice Hi, does it have buttons? That looks like the input layer gets involved. Please post "lsusb -v". Regards

Cześć słodka

Am Wes ze Stanów Zjednoczonych, ale obecnie przebywa w Syrii na misji pokojowej. Obecnie szukam przyjaźni, która doprowadzi do związku, w którym znowu czuję się kochana ... Chcę cię lepiej poznać, jeśli mogę być odważny. Uważam się za łatwego człowieka .. Proszę wybaczyć moje

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

On 25/03/18 15:39, Ard Biesheuvel wrote: > > >> On 25 Mar 2018, at 15:14, Marc Zyngier wrote: >> >> On Sun, 25 Mar 2018 14:26:58 +0100 >> Ard Biesheuvel wrote: >> On 25 March 2018 at 13:52, Marc Zyngier wrote: On

Re: [PATCH -next] usb: roles: Fix return value check in intel_xhci_usb_probe()

Hi, On 26-03-18 08:43, Wei Yongjun wrote: In case of error, the function devm_ioremap_nocache() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: f6fb9ec02be1 ("usb: roles: Add Intel xHCI USB role switch driver")

[PATCH -next] usb: roles: Fix return value check in intel_xhci_usb_probe()

In case of error, the function devm_ioremap_nocache() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: f6fb9ec02be1 ("usb: roles: Add Intel xHCI USB role switch driver") Signed-off-by: Wei Yongjun