[PATCH 1/1] usb: chipidea: imx: improve the over current handling

2018-12-02 Thread PETER CHEN
The current OC (Over Current) handling does not consider the default and bootloader OC setting well, in this commit, we reset OC setting according to dts value: - If property "disable-over-current" is set, we will disable OC at code; otherwise, we will enable OC. - Since most of USB power control

RE: [PATCH] usb: chipidea: imx: Allow OC polarity active low

2018-12-02 Thread PETER CHEN
> > > -Original Message- > > From: Matthew Starr > > Sent: 2018年11月30日 23:09 > > To: PETER CHEN ; linux-usb@vger.kernel.org; Jun Li > > > > Subject: RE: [PATCH] usb: chipidea: imx: Allow OC polarity active low > > > > > -Original Message- > > > From: PETER CHEN

RE: [PATCH] usb: chipidea: imx: Allow OC polarity active low

2018-12-02 Thread Jun Li
Hi Peter, > -Original Message- > From: Matthew Starr > Sent: 2018年11月30日 23:09 > To: PETER CHEN ; linux-usb@vger.kernel.org; Jun Li > > Subject: RE: [PATCH] usb: chipidea: imx: Allow OC polarity active low > > > -Original Message- > > From: PETER CHEN

[PATCH] USB: qcaux: Add Motorola modem UARTs

2018-12-02 Thread Tony Lindgren
On Motorola Mapphone devices such as Droid 4 there are five USB ports that do not use the same layout as Gobi 1K/2K/etc devices listed in qcserial.c. So we should use qcaux.c or option.c as noted by Dan Williams . The ff/ff/ff interfaces seem to always be UARTs on Motorola devices. And we should

[PATCH v2 3/3] usb: chipidea: imx: allow to configure oc polarity on i.MX25

2018-12-02 Thread Uwe Kleine-König
Up to now the polarity of the over current pin was hard coded to active high. Use the already defined device tree properties to configure polarity on i.MX25, too. In difference to i.MX6/7 use active high behavior if the polarity is unspecified to keep compatibility to existing device trees.

[PATCH v2 2/3] usb: chipidea: imx: Warn if oc polarity isn't specified

2018-12-02 Thread Uwe Kleine-König
The polarity of the over current detection pin isn't configured on i.MX6/7 if it's unspecified in the device tree. So the actual configuration depends on bootloader behavior which is bad. So encourage users to fix their device tree by issuing a warning in this case. Signed-off-by: Uwe

[PATCH v2 1/3] usb: chipidea: imx: support configuring for active low oc signal

2018-12-02 Thread Uwe Kleine-König
The status quo on i.MX6 is that if "over-current-active-high" is specified in the device tree this is configured as expected. If the property is missing polarity isn't changed and so the polarity is kept as setup by the bootloader. Reset default is active high, so active low can only be used with

Re: [PATCH v2] usb: chipidea: imx: Allow OC polarity active low

2018-12-02 Thread Uwe Kleine-König
On Fri, Nov 30, 2018 at 11:29:13PM +, Matthew Starr wrote: > The implementation for setting the over current polarity has always been > the over-current-active-high property. The problem with this is there > is no way to enable over current active low polarity since the default > state of the

Re: Apple Display bound to hid-generic driver instead of appledisplay

2018-12-02 Thread 2...@mok.nu
On 2 Dec 2018, at 12:40, Alexander Theißen wrote: >>> On 1 Dec 2018, at 13:06, Alexander Theißen wrote: [...] >>> How do you use that driver? For me the hid driver always claims the device. >>> I have to manually bind the driver to the display to have it bound to the >>> appledisplay driver.

Re: tusb1210 probe of dwc3.0.auto.ulpi fails with EBUSY on 4.19+

2018-12-02 Thread Stephan Gerhold
Hi, thanks for the quick reply! :) On Sun, Dec 02, 2018 at 03:41:29PM +0100, Hans de Goede wrote: > Hi, > > On 01-12-18 13:22, Stephan Gerhold wrote: > > Hi, > > > > I have been updating my Intel Baytrail tablet from 4.14 to 4.19 and > > noticed that the tusb1210 PHY driver now fails to probe

Re: tusb1210 probe of dwc3.0.auto.ulpi fails with EBUSY on 4.19+

2018-12-02 Thread Hans de Goede
Hi, On 01-12-18 13:22, Stephan Gerhold wrote: Hi, I have been updating my Intel Baytrail tablet from 4.14 to 4.19 and noticed that the tusb1210 PHY driver now fails to probe on 4.19.x and 4.20-rc4: tusb1210: probe of dwc3.0.auto.ulpi failed with error -16 (EBUSY) The commit that broke

Apple Display bound to hid-generic driver instead of appledisplay

2018-12-02 Thread Alexander Theißen
>> On 1 Dec 2018, at 13:06, Alexander Theißen wrote: >> >> Hi Mattias, >> >> I am writing you because you edited the drivers/usb/misc/appledisplay.c >> driver and I am hoping that you are a user of that driver. >> >> How do you use that driver? For me the hid driver always claims the device. >>