Re: [PATCH 4/7] ECHI Platform: Merge ppc-of EHCI driver into the ehci-platform driver

2014-02-23 Thread Alistair Popple
On Fri, 21 Feb 2014 10:41:50 Alan Stern wrote: > On Fri, 21 Feb 2014, Alistair Popple wrote: > > Currently the ppc-of driver uses the compatibility string > > "usb-ehci". This means platforms that use device-tree and implement an > > EHCI compatible interface have

Re: [PATCH 3/7] IBM Akebono: Add support to the OHCI platform driver for PPC476GTR

2014-02-23 Thread Alistair Popple
On Fri, 21 Feb 2014 15:16:52 Arnd Bergmann wrote: > On Friday 21 February 2014 17:31:29 Alistair Popple wrote: > > +static const struct of_device_id ohci_of_match[] = { > > + { .compatible = "usb-ohci", }, > > + {}, > > +}; > > + >

[PATCH 0/7] IBM Akebono/PPC476GTR Support

2014-02-20 Thread Alistair Popple
The IBM Akebono board is a development board for the new PPC476GTR system on chip (SoC). This is just a resubmission of the previous patches rebased on kernel v3.13. Ben H has indicated the subsystem specific changes should be merged via the appropriate kernel trees. Alistair Popple (7): IBM

[PATCH 3/7] IBM Akebono: Add support to the OHCI platform driver for PPC476GTR

2014-02-20 Thread Alistair Popple
reasonable defaults if no platform data is present. This is similar to what is currently done in ehci-platform.c. Signed-off-by: Alistair Popple Acked-by: Alan Stern --- drivers/usb/host/ohci-platform.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH 4/7] ECHI Platform: Merge ppc-of EHCI driver into the ehci-platform driver

2014-02-20 Thread Alistair Popple
iver is removed and the 440EPX specific quirks are added to the ehci-platform driver. Signed-off-by: Alistair Popple --- drivers/usb/host/Kconfig |7 +- drivers/usb/host/ehci-hcd.c |5 - drivers/usb/host/ehci-platform.c | 87 +- drivers/u

Re: [PATCH 4/8] IBM Akebono: Add support to the OHCI platform driver for PPC476GTR

2014-01-12 Thread Alistair Popple
On Sat, 11 Jan 2014 12:06:32 Benjamin Herrenschmidt wrote: > On Fri, 2014-01-10 at 16:52 -0800, Greg KH wrote: > > > >Signed-off-by: Alistair Popple > > > >Acked-by: Alan Stern > > > >Cc: linux-usb@vger.kernel.org > > > > > > >

Re: [PATCH 4/7] IBM Akebono: Add support to the OHCI platform driver for Akebono

2013-11-06 Thread Alistair Popple
On Tue, 5 Nov 2013 10:04:02 Alan Stern wrote: [snip] > > > > + /* Platforms using DT don't always provide platform data. > > +* This should provide reasonable defaults. */ > > /* >* The accepted format for multi-line >* comments is like this. >*/ > Ok, I'll

Re: [RFC PATCH] ehci-platform: Merge ppc-of EHCI driver into the ehci-platform driver

2013-11-06 Thread Alistair Popple
On Thu, 7 Nov 2013 06:57:00 Benjamin Herrenschmidt wrote: > On Wed, 2013-11-06 at 18:39 +1100, Alistair Popple wrote: [snip] > > I would go even further and add the 44x workarounds to the normal > platform device, with a compatible check in there. That isn't the > first time

Re: [RFC PATCH] ehci-platform: Merge ppc-of EHCI driver into the ehci-platform driver

2013-11-06 Thread Alistair Popple
On Wed, 6 Nov 2013 11:14:44 Alan Stern wrote: > On Wed, 6 Nov 2013, Alistair Popple wrote: [snip] > > + /* Initialise platform data from device tree if available. */ > > + if (!dn) { > > Shouldn't this be "if (dn)"? Yep. Thanks. > > +

[RFC PATCH] ehci-platform: Merge ppc-of EHCI driver into the ehci-platform driver

2013-11-05 Thread Alistair Popple
r is renamed to ehci-440epx as it contains platform specific work arounds for the 440EPX SoC. Signed-off-by: Alistair Popple --- So I could submit something like this that essentially merges the ppc-of driver into the platform driver instead of adding the "ibm,akebono-ehci" compatib

Re: [PATCH 5/7] IBM Akebono: Add support to the EHCI platform driver for Akebono

2013-11-05 Thread Alistair Popple
On Wed, 6 Nov 2013 06:52:13 Benjamin Herrenschmidt wrote: [snip] > > Why ? Do we need to add an entry for every platform in there ? Besides, > it probably should be the SoC name not the platform here > > Why not simply a generic compatible "usb-ehci" ? It's a standard > programming interfac

[PATCH 5/7] IBM Akebono: Add support to the EHCI platform driver for Akebono

2013-11-04 Thread Alistair Popple
The IBM Akebono board has an EHCI compliant USB host interface. This patch adds support for it to the EHCI platform driver. Signed-off-by: Alistair Popple Cc: Alan Stern Cc: linux-usb@vger.kernel.org --- drivers/usb/host/ehci-platform.c |5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH 4/7] IBM Akebono: Add support to the OHCI platform driver for Akebono

2013-11-04 Thread Alistair Popple
data is present. This is similar to what is currently done in ehci-platform.c. Signed-off-by: Alistair Popple Cc: Alan Stern Cc: linux-usb@vger.kernel.org --- drivers/usb/host/ohci-platform.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/usb