struct otg_fsm may be embedded to device's context structure.
The callbacks may require pointer to struct otg_fsm to obtain
necessary data for its operation (example: regulator reference
for drv_vbus()).
Signed-off-by: Anton Tikhomirov
---
drivers/usb/phy/phy-fsl-usb.c |
In accordance with OTG and EH supplement, the correct name
of the FSM input is b_ssend_srp.
Signed-off-by: Anton Tikhomirov
---
drivers/usb/phy/phy-fsl-usb.c |4 ++--
drivers/usb/phy/phy-fsm-usb.c |2 +-
drivers/usb/phy/phy-fsm-usb.h |2 +-
3 files changed, 4 insertions(+), 4
Reorder variables in struct otg_fsm as they appear in OTG and EH
supplement to USB2.0.
Signed-off-by: Anton Tikhomirov
---
drivers/usb/phy/phy-fsm-usb.h | 46 +
1 file changed, 24 insertions(+), 22 deletions(-)
diff --git a/drivers/usb/phy/phy-fsm
Get rid of using OTG driver specific timers by passing timer
type to corresponding callbacks.
Signed-off-by: Anton Tikhomirov
---
drivers/usb/phy/phy-fsl-usb.c | 60 +++--
drivers/usb/phy/phy-fsm-usb.c | 28 +--
drivers/usb/phy/phy-fsm
a_bidl_adis_tmr and a_wait_vfall_tmr OTG timers missed in
current FSM implementation. This patch adds and makes use
of the timers as speicfied in OTG and EH supplement to USB2.0.
Signed-off-by: Anton Tikhomirov
---
drivers/usb/phy/phy-fsm-usb.c | 12 +---
drivers/usb/phy/phy-fsm-usb.h
Existence of callback must be checked to avoid NULL pointer
dereferncing.
Signed-off-by: Anton Tikhomirov
---
drivers/usb/phy/phy-fsm-usb.h | 35 ---
1 file changed, 28 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/phy/phy-fsm-usb.h b/drivers/usb/phy
Several input/output variables missed in current FSM implementation.
This patch adds and makes use of them as specified in OTG and EH
supplement to USB2.0.
Signed-off-by: Anton Tikhomirov
---
drivers/usb/phy/phy-fsm-usb.c | 18 +++---
drivers/usb/phy/phy-fsm-usb.h | 36
This patch implements missed helper functions for start_gadget() and
start_host() OTG FSM callbacks.
Signed-off-by: Anton Tikhomirov
---
drivers/usb/phy/phy-fsm-usb.c |8
drivers/usb/phy/phy-fsm-usb.h | 14 ++
2 files changed, 18 insertions(+), 4 deletions(-)
diff
Mark informative variables with suffix '_inf' to distinguish
them from other non-informative variables with the same name.
If such non-informative varialbes were missed, they are created.
Signed-off-by: Anton Tikhomirov
---
drivers/usb/phy/phy-fsl-usb.c |2 +-
drivers/usb/phy/phy
Hello,
This patch set implements several fixes to USB2.0 OTG Final
State Machine. All changes affect the only user of OTG FSM,
Freescale USB OTG Transceiver Driver, as little as possible
and (hope) keep it functional. Further changes to OTG FSM
will require reworking of the driver.
Anton
This patch removes limitation when only one PHY of specific type
could be used.
Signed-off-by: Anton Tikhomirov
---
drivers/usb/phy/phy-samsung-usb2.c |3 ++-
drivers/usb/phy/phy-samsung-usb3.c |3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/phy/phy
This patch removes dependency on Freescale USB UTG Transceiver
driver and makes OTG FSM implementation selectable.
Signed-off-by: Anton Tikhomirov
---
drivers/usb/phy/Kconfig | 10 +-
drivers/usb/phy/Makefile |4 ++--
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git
OTG Final State Machine calls functions which may sleep.
For example, start_gadget callback implementation can use
usb_gadget_vbus_connect(), whose context: can sleep.
If so, mutex should be used instead of spinlock.
Signed-off-by: Anton Tikhomirov
---
drivers/usb/phy/phy-fsl-usb.c |7
Other USB drivers may want to use OTG final state machine
implementation, so make this header available for them.
Signed-off-by: Anton Tikhomirov
---
drivers/usb/phy/phy-fsl-usb.h |1 -
drivers/usb/phy/phy-fsm-usb.c |2 -
drivers/usb/phy/phy-fsm-usb.h | 236
This patchs adds include guard to avoid double inclusion of the header.
Signed-off-by: Anton Tikhomirov
---
include/linux/usb/otg_fsm.h |5 +
1 file changed, 5 insertions(+)
diff --git a/include/linux/usb/otg_fsm.h b/include/linux/usb/otg_fsm.h
index 12ece58..55de52e 100644
--- a
OTG Final State Machine calls functions which may sleep.
For example, start_gadget callback implementation can use
usb_gadget_vbus_connect(), whose context: can sleep.
If so, mutex should be used instead of spinlock.
Signed-off-by: Anton Tikhomirov
---
drivers/usb/phy/phy-fsl-usb.c |7
Other USB drivers may want to use OTG final state machine
implementation, so make this header available for them.
Signed-off-by: Anton Tikhomirov
---
drivers/usb/phy/phy-fsl-usb.h |1 -
drivers/usb/phy/phy-fsm-usb.c |2 --
include/linux/usb
This patch removes dependency on Freescale USB UTG Transceiver
driver and makes OTG FSM implementation selectable.
Signed-off-by: Anton Tikhomirov
---
drivers/usb/phy/Kconfig | 10 +-
drivers/usb/phy/Makefile |4 ++--
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git
Hi Felipe,
> Hi,
>
> On Tue, Nov 26, 2013 at 10:33:44AM -0600, Felipe Balbi wrote:
> > this header uses spinlocks and errno values, so
> > we must include and
> > to avoid build errors.
> >
> > Signed-off-by: Felipe Balbi
>
> Anton, I had to rework your patch series quite a bit in order to ma
Hi,
> On Wed, Nov 27, 2013 at 11:14:56AM +0900, Anton Tikhomirov wrote:
> > Hi Felipe,
> >
> > > Hi,
> > >
> > > On Tue, Nov 26, 2013 at 10:33:44AM -0600, Felipe Balbi wrote:
> > > > this header uses spinlocks and errno values, so
>
Hello,
In drivers/usb/core/hcd.c: usb_hcd_flush_endpoint() uses
list_for_each_entry() to unlink URBs pending on
endpoint. At the same time unlink1() calls usb_rh_urb_dequeue()
where URB is removed from its endpoint queue:
void usb_hcd_unlink_urb_from_ep(struct usb_hcd *hcd, struct urb *urb)
{
Hello,
Sorry for my haste, I missed that. We have situation when CPU
stalls in usb_hcd_flush_endpoint(), so at first glance it looked
strange for me. Will analyze more.
Thank you.
> On Mon, 28 Jan 2013, Anton Tikhomirov wrote:
>
> > Hello,
> >
> > I
Hi Kamil,
...
> +| 3. Supporting SoCs
> ++
> +
> +To support a new SoC a new file should be added to the drivers/phy
> +directory. Each SoC's configuration is stored in an instance of the
> +struct samsung_usb2_phy_config.
> +
> +struct samsung_usb2_phy_config {
> + const
Hello,
> Subject: Re: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver
>
>
>
> On Thursday 06 March 2014 01:56 PM, Anton Tikhomirov wrote:
> > Hi Kamil,
> >
> > ...
> >
> >> +| 3. Supporting SoCs
> >> ++
> &
Hi,
> Subject: Re: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver
>
> Hi,
>
> On Thursday 06 March 2014 02:22 PM, Anton Tikhomirov wrote:
> > Hello,
> >
> >> Subject: Re: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver
> >>
> >&g
Hi,
> Subject: RE: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver
>
> Hi,
>
> > Subject: Re: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver
> >
> > Hi,
> >
> > On Thursday 06 March 2014 02:22 PM, Anton Tikhomirov wrote:
> > >
Hi,
> Subject: Re: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver
>
> Hi,
>
> On Thursday 06 March 2014 02:49 PM, Anton Tikhomirov wrote:
> > Hi,
> >
> >> Subject: RE: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver
> >>
> >> H
.kernel.org; linux-
> arm-ker...@lists.infradead.org; gre...@linuxfoundation.org;
> st...@rowland.harvard.edu; ba...@ti.com; kgene@samsung.com; Vivek
> Gautam; Anton Tikhomirov
> Subject: [PATCH 3/3] usb: dwc3-exynos: Make provision for vdd
> regulators
>
> Facilitate gettin
Hi,
> Hi Anton,
>
>
> On Wed, Apr 23, 2014 at 2:56 PM, Anton Tikhomirov
> wrote:
> > Hello,
> >
> >> -Original Message-
> >> From: Vivek Gautam [mailto:gautamvivek1...@gmail.com] On Behalf Of
> >> Vivek Gautam
> >> Sent: Mo
Hi,
> -Original Message-
> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> ow...@vger.kernel.org] On Behalf Of Vivek Gautam
> Sent: Monday, April 21, 2014 9:17 PM
>
> Facilitate getting required 3.3V and 1.0V VDD supply for
> OHCI controller on Exynos.
>
> With patches for reg
Hi,
> Hi,
>
> > -Original Message-
> > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> > ow...@vger.kernel.org] On Behalf Of Vivek Gautam
> > Sent: Monday, April 21, 2014 9:17 PM
> >
> > Facilitate getting required 3.3V and 1.0V VDD supply for
> > OHCI controller on Exynos.
> >
Hi Praveen,
> -Original Message-
> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> ow...@vger.kernel.org] On Behalf Of Praveen Paneri
> Sent: Wednesday, August 08, 2012 4:41 PM
> To: linux-usb@vger.kernel.org
> Cc: devicetree-disc...@lists.ozlabs.org; linux-arm-
> ker...@lists.i
Hi Kamil,
Same USB2.0 PHY may be used by several HCDs, for example EHCI and OHCI.
Consider the situation, when EHCI stops using the PHY and calls power_off,
then OHCI becomes non-operational. In other words, PHY power_on and
power_off calls must be balanced.
Shall we handle it in your driver? (u
Hi Felipe,
> -static int dwc3_exynos_suspend(struct device *dev)
> +static int __dwc3_exynos_suspend(struct dwc3_exynos *exynos)
> {
> - struct dwc3_exynos *exynos = dev_get_drvdata(dev);
> -
> clk_disable(exynos->clk);
>
> return 0;
> }
>
> +static int __dwc3_exynos_resume(str
Hi Felipe,
> On Fri, Dec 13, 2013 at 02:01:32PM +0900, Anton Tikhomirov wrote:
> > Hi Felipe,
> >
> > > -static int dwc3_exynos_suspend(struct device *dev)
> > > +static int __dwc3_exynos_suspend(struct dwc3_exynos *exynos)
> > > {
> > >
Hi Felipe,
> On Fri, Dec 13, 2013 at 01:56:18PM -0600, Felipe Balbi wrote:
> > On Fri, Dec 13, 2013 at 02:01:32PM +0900, Anton Tikhomirov wrote:
> > > Hi Felipe,
> > >
> > > > -static int dwc3_exynos_suspend(struct device *dev)
> > > > +static i
In accordance with specification, when sent data length is
an exact multiple of wMaxPacketSize for the pipe and less
than requested by host, the function shall return a zero-length
packet (ZLP) to indicate the end of the Data stage to a USB host.
Signed-off-by: Anton Tikhomirov
---
drivers/usb
Hi Kamil,
> Hi Anton,
>
> > From: Anton Tikhomirov [mailto:av.tikhomi...@samsung.com]
> > Sent: Tuesday, December 10, 2013 3:43 AM
> >
> > Hi Kamil,
> >
> > Same USB2.0 PHY may be used by several HCDs, for example EHCI and
> OHCI.
> > Consid
Hi,
> Hi,
>
> On Tue, Dec 17, 2013 at 03:59:31PM +0900, Anton Tikhomirov wrote:
> > In accordance with specification, when sent data length is
>
> please mention section of specification.
USB2.0 spec., 8.5.3.2 Variable-length Data Stage
>
> > an exact multiple
Hi Pratyush,
> Hi Anton,
>
> On Wed, Dec 18, 2013 at 12:11:33PM +0800, Felipe Balbi wrote:
> > Hi,
> >
> > On Tue, Dec 17, 2013 at 03:59:31PM +0900, Anton Tikhomirov wrote:
> > > In accordance with specification, when sent data length is
> >
&
Hi,
> Hi,
>
> On Thu, Dec 19, 2013 at 02:54:31PM +0900, Anton Tikhomirov wrote:
> > > WARN_ON(ret < 0);
> > >
> > > Regards
> > > Pratyush
> >
> > By the way, chaining additional (auxiliary) TRB would allow complying
> with
Hi,
> > On Thu, Dec 19, 2013 at 11:32:08AM +0900, Anton Tikhomirov wrote:
> > > Hi,
> > >
> > > > Hi,
> > > >
> > > > On Tue, Dec 17, 2013 at 03:59:31PM +0900, Anton Tikhomirov wrote:
> > > > > In accordance with specif
Hi,
> > > > On Thu, Dec 19, 2013 at 11:32:08AM +0900, Anton Tikhomirov wrote:
> > > > > Hi,
> > > > >
> > > > > > Hi,
> > > > > >
> > > > > > On Tue, Dec 17, 2013 at 03:59:31PM +0900, An
Hi,
> On Thu, Dec 19, 2013 at 03:38:18PM +0900, Anton Tikhomirov wrote:
> > Hi,
> >
> > > Hi,
> > >
> > > On Thu, Dec 19, 2013 at 02:54:31PM +0900, Anton Tikhomirov wrote:
> > > > > WARN_ON(ret < 0);
> > > > >
Hi Felipe,
> > +
> > + /* handle the case where we have to send a zero packet */
> > + if ((epnum & 1) && ur->zero &&
> > + (ur->length % ep0->endpoint.maxpacket == 0)) {
> > + int ret;
> > +
> > + ret = dwc3_ep0_start_trans(dwc, epnum, dwc->ctrl_req_addr,
> 0,
> > +
Mutex obtained at the beginning of the function should
be released at the end to avoid double locking.
Signed-off-by: Anton Tikhomirov
---
drivers/usb/phy/phy-fsm-usb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-fsm-usb.c b/drivers/usb/phy/phy-fsm
Hi,
> -Original Message-
> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> ow...@vger.kernel.org] On Behalf Of Ido Shayevitz
> Sent: Thursday, July 12, 2012 1:24 AM
> To: ba...@ti.com
> Cc: linux-usb@vger.kernel.org; i...@codeaurora.org
> Subject: [RFC/PATCH v2] usb: dwc3: Intro
Hi Ido,
> -Original Message-
> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> ow...@vger.kernel.org] On Behalf Of Ido Shayevitz
> Sent: Wednesday, July 25, 2012 9:46 PM
> To: ba...@ti.com; av.tikhomi...@samsung.com
> Cc: linux-usb@vger.kernel.org; i...@codeaurora.org
> Subject:
Hi Ido,
Some more comments.
> -Original Message-
> From: Ido Shayevitz [mailto:i...@codeaurora.org]
> Sent: Sunday, July 29, 2012 9:55 PM
> To: Anton Tikhomirov
> Subject: RE: [RFC/PATCH v3] usb: dwc3: Introduce OTG driver for dwc3
>
>
> Hi Anton,
>
> Th
Hi Ido,
> -Original Message-
> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> ow...@vger.kernel.org] On Behalf Of Ido Shayevitz
> Sent: Monday, July 30, 2012 7:53 PM
> To: Anton Tikhomirov
> Cc: 'Ido Shayevitz'; 'Felipe Balbi'; linux-u
Hi Ido,
> -Original Message-
> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> ow...@vger.kernel.org] On Behalf Of Ido Shayevitz
> Sent: Monday, July 30, 2012 10:16 PM
> To: Anton Tikhomirov
> Cc: 'Ido Shayevitz'; 'Felipe Balbi'; linux-u
> -Original Message-
> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> ow...@vger.kernel.org] On Behalf Of Ido Shayevitz
> Sent: Wednesday, August 01, 2012 11:44 PM
> To: Anton Tikhomirov
> Cc: 'Ido Shayevitz'; 'Felipe Balbi'; p
Hi Vivek,
> Exynos7 also has a separate special gate clock going to the IP
> apart from the usual AHB clock. So add support for the same.
As we discussed before, Exynos7 SoCs have 7 clocks to be controlled
by the driver. Adding only sclk is not enough.
>
> Signed-off-by: Vivek Gautam
> ---
>
Hi Vivek,
> Exynos7 SoC has now separate gate control for 125MHz pipe3 phy
> clock, as well as 60MHz utmi phy clock.
> So get the same and control in the phy-exynos5-usbdrd driver.
In case of the PHY the situation is pretty much the same as with
DWC3 core. Here we should control 6 clocks to make
Hi Vivek,
> Some Exynos SoCs have a separate regulator controlling a
I guess you meant the Exynos based *boards* instead of SoCs,
since Exynos SoCs don't have any boost regulators.
> Boost 5V supply which goes as input for VBUS regulator.
> So adding a control for the same in driver, to enable
>
Hello,
> Hi Anton,
>
> On 13.10.2014 06:54, Anton Tikhomirov wrote:
> > Hi Vivek,
> >
> >> Exynos7 also has a separate special gate clock going to the IP
> >> apart from the usual AHB clock. So add support for the same.
> >
> > As we discussed
Hi,
> On Mon, 20 Oct 2014, Paul Zimmerman wrote:
>
> > > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> ow...@vger.kernel.org] On Behalf Of David Laight
> > > Sent: Monday, October 20, 2014 2:48 AM
> > >
> > > From: Felipe Balbi
> > > > According to Section 8.5.3.2 of the USB 2.0 spec
Hi,
On Thu, 23 Oct 2014, Alan Stern wrote:
> On Thu, 23 Oct 2014, Felipe Balbi wrote:
>
> > here's v2:
> >
> > 8<--
> >
> > From 1080b54d66e3e77410b41732e76746ed8e2c01c7 Mon Sep 17 00:00:00
> 2001
> > From: Felipe Balbi
> > Date: Tue,
Hi,
> On Thu, Oct 23, 2014 at 10:18:41PM -0500, Felipe Balbi wrote:
> > HI,
> >
> > On Fri, Oct 24, 2014 at 10:14:19AM +0900, Anton Tikhomirov wrote:
> > >
> > > Hi,
> > >
> > > On Thu, 23 Oct 2014, Alan Stern wrote:
> > > >
According to user manual, pcs_tx_deemph_3p5db field in PHYPARAM1
register is 6bits wide, so mask value should be 0x3f instead
of 0x1f.
Signed-off-by: Anton Tikhomirov
---
drivers/phy/phy-exynos5-usbdrd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/phy
Hi Vivek,
> Hi Anton,
>
>
> On Fri, Sep 19, 2014 at 1:05 PM, Anton Tikhomirov
> wrote:
> > According to user manual, pcs_tx_deemph_3p5db field in PHYPARAM1
> > register is 6bits wide, so mask value should be 0x3f instead
> > of 0x1f.
> &
According to user manual, pcs_tx_deemph_3p5db field in PHYPARAM1
register is 6bits wide, so mask value should be 0x3f instead
of 0x1f. Additionally, this patch renames the macro to correctly
reflect the field name which we see in SoC documentation.
Signed-off-by: Anton Tikhomirov
---
drivers
62 matches
Mail list logo
