[PATCH] Revert "usb: gadget: allow to enable legacy drivers without USB_ETH"

2017-12-11 Thread Bart Van Assche
nymore, so it is useless. It is also possible to select multiple built-in legacy drivers. This builds, but will not work as expected as only one legacy driver can be bound to an USB device controller at a time. Hence revert commit 7a9618a22aad. Signed-off-by: Bart Van Assche <bart.vanass..

Re: [PATCH 1/2] usb: gadget: restore tristate-choice for legacy gadgets

2017-12-11 Thread Bart Van Assche
On Mon, 2017-12-11 at 12:30 +0100, Arnd Bergmann wrote: > One patch that was meant as a cleanup apparently did more than it intended, > allowing all combinations of legacy gadget drivers to be built into the > kernel, and leaving an empty 'choice' statement behind: > >

Re: [PATCH 11/11] usb/gadget: Make it again possible to enable the legacy drivers without enabling USB_ETH

2017-11-22 Thread Bart Van Assche
On Tue, 2017-10-31 at 11:03 -0700, Bart Van Assche wrote: > Considerable time ago the legacy gadget menu was added inside the > USB_ETH choice. I think this was a mistake and that the legacy > gadget menu should have been added after "endchoice" instead of > before. Hence

Re: Seagate External SMR drive USB resets... why? / USB storage debugging

2017-11-15 Thread Bart Van Assche
On Wed, 2017-11-15 at 18:27 -0500, Jérôme Carretero wrote: > OK but I find that a "reset" message without any reason is not > as helpful as it could have been. At the minimum I'll try to scratch my > own itch and see if I can go at the bottom of my issue. If you want more information about SCSI

[PATCH 11/11] usb/gadget: Make it again possible to enable the legacy drivers without enabling USB_ETH

2017-10-31 Thread Bart Van Assche
cleanup - group legacy gadgets") Signed-off-by: Bart Van Assche <bart.vanass...@wdc.com> Cc: Nicholas Bellinger <n...@linux-iscsi.org> Cc: Andrzej Pietrasiewicz <andrze...@samsung.com> Cc: Felipe Balbi <ba...@ti.com> Cc: linux-usb@vger.kernel.org --- drivers/usb/gadget/

Re: USB-related lock inversion complaint

2017-05-01 Thread Bart Van Assche
On Mon, 2017-05-01 at 13:39 -0400, Alan Stern wrote: > On Fri, 28 Apr 2017, Alan Stern wrote: > > On Fri, 28 Apr 2017, Bart Van Assche wrote: > He wrote: > > > There, that's where we hold the lock with interrupts enabled. > > > > So someone forced interru

USB-related lock inversion complaint

2017-04-28 Thread Bart Van Assche
Hello, Every time I boot a particular development server the complaint shown below appears in the system log. I don't know when this behavior has been introduced. But I noticed that I can reproduce this with older kernel versions, e.g. 4.4.63. Does anyone know what is going on or how to fix this?

Re: [PATCH 4.10-rc3 09/13] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Bart Van Assche
274d17b5c 100644 > --- a/drivers/target/iscsi/iscsi_target_login.c > +++ b/drivers/target/iscsi/iscsi_target_login.c > @@ -17,6 +17,7 @@ > > **/ > > #include > +#include > #include > #incl

[PATCH 07/21] usb/gadget: Remove set-but-not-used variables

2015-10-22 Thread Bart Van Assche
Avoid that building with W=1 triggers compiler warnings about set-but-not-used variables. Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com> Acked-by: Felipe Balbi <ba...@ti.com> Reviewed-by: Andy Grover <agro...@redhat.com> Cc: Christoph Hellwig <h...@lst.de>

Re: Kernel crash on usb-storage disconnect, multiqueue in use

2015-02-11 Thread Bart Van Assche
On 02/11/15 22:25, Bruno Prémont wrote: Since 3.19-rcX kernel crashes when I disconnect an external HDD drive (not sure since which kernel revision tough early 3.19-rcs possibly are not affected). It looks like this crash is related to the fact that I enable multiqueue