On Thursday, October 03, 2013 10:31:53 AM Alan Stern wrote:
> On Thu, 3 Oct 2013, manju goudar wrote:
>
> > On Wed, Oct 2, 2013 at 9:22 PM, Alan Stern wrote:
> >
> > > On Wed, 2 Oct 2013, Bartlomiej Zolnierkiewicz wrote:
> > >
> > > >
> > >
Hi,
Does the old phy-samsung-usb3 driver currently work on Exynos5250? If yes,
then this patch should be merged with patch #1 to preserve bisectability.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
On Wednesday, December 04, 2013 03:39:0
Round the write down to an
> @@ -730,8 +739,16 @@ static void s3c_hsotg_start_req(struct s3c_hsotg *hsotg,
> else
> packets = 1;/* send one packet if length is zero. */
>
> + if (length > (hs_ep->mc * hs_ep->ep.maxpacket) && hs_ep->is
your
> nonsense forever and linux wouldn't move.
Pavel, Felipe's remark was valid..
> > No, I'll not polish patch for hardware I don't have and have little
> > interest in. wanted to help you, but according to your first reply,
> > you do not really
off-by: Pavel Machek
[bzolnier: minor fixes]
Signed-off-by: Bartlomiej Zolnierkiewicz
Signed-off-by: Kyungmin Park
---
drivers/usb/gadget/s3c-hsotg.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-h
i->otg, &hcd->self);
>
> @@ -228,7 +219,6 @@ static int exynos_ohci_suspend(struct device *dev)
>
> clk_disable_unprepare(exynos_ohci->clk);
>
> -fail:
> spin_unlock_irqrestore(&ohci->lock, flags);
>
> return rc;
Best regards
Hi,
On Wednesday, October 02, 2013 10:38:58 AM Alan Stern wrote:
> On Wed, 2 Oct 2013, Bartlomiej Zolnierkiewicz wrote:
>
> > Maybe it would make sense to cleanup ohci_suspend() first (before adding
> > new ohci_suspend() users) and remove unused do_wakeup parameter?
>
; exist when apparently it's not needed?
> >>>
> >>> Regardless, there's something broken somewhere.
> >>
> >> Odd, I don't know what to do to fix this up "properly".
> >>
> >> Loc Ho, this came in from your patch
>
> > Let's drop COMPILE_TEST from AHCI_XGENE.
> >
> > Signed-off-by: Tejun Heo
> > Reported-by: Linus Torvalds
> > Cc: Loc Ho
> > Cc: Bartlomiej Zolnierkiewicz
>
> So, apparently, this isn't enough as this would allow enabling
> PHY_XGEN
y: Krzysztof Kozlowski
Acked-by: Bartlomiej Zolnierkiewicz
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
Mo
Kozlowski
[b.zolnierkie: ported over driver changes]
Signed-off-by: Bartlomiej Zolnierkiewicz
---
Eduardo, here is a version which applies on top of pending Exynos
thermal changes (https://lkml.org/lkml/2018/4/16/256).
Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 14
drivers
Mauro Carvalho Chehab
Acked-by: Bartlomiej Zolnierkiewicz # for fbdev part
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vge
| 4 ++--
> lib/test_firmware.c | 14 +---
> lib/test_kmod.c | 14 +---
> sound/soc/omap/mcbsp.c | 4 ++--
> 15 files changed, 49 insertions(+), 80 deletions(-)
For fbdev changes:
Acked-by: Bartlomiej Zolnierkiewicz
Best regards,
-
On Monday, February 26, 2018 04:04:17 PM Kees Cook wrote:
> This is a small series that cleans up struct consw a bit and
> prepares it for Control Flow Integrity checking (i.e. Clang's
> -fsanitize=cfi).
for drivers/video/ parts:
Acked-by: Bartlomiej Zolnierkiewicz
Best regards,
On Wednesday, February 28, 2018 04:09:47 PM Bartlomiej Zolnierkiewicz wrote:
> On Monday, February 26, 2018 04:04:17 PM Kees Cook wrote:
> > This is a small series that cleans up struct consw a bit and
> > prepares it for Control Flow Integrity checking (i.e. Clang's
> >
probably be dropped.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> Signed-off-by: Shuah Khan
> ---
> drivers/usb/dwc3/dwc3-exynos.c | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/us
Hi,
On Tuesday, January 10, 2017 07:36:35 AM Shuah Khan wrote:
> On 01/10/2017 07:16 AM, Shuah Khan wrote:
> > On 01/10/2017 05:05 AM, Bartlomiej Zolnierkiewicz wrote:
> >>
> >> Hi,
> >>
> >> On Monday, January 09, 2017 07:21:31 PM Shuah Khan
Hi,
On Tuesday, January 10, 2017 09:28:52 AM Shuah Khan wrote:
> On 01/10/2017 09:05 AM, Bartlomiej Zolnierkiewicz wrote:
> >
> > Hi,
> >
> > On Tuesday, January 10, 2017 07:36:35 AM Shuah Khan wrote:
> >> On 01/10/2017 07:16 AM, Shuah Khan wrote:
>
Hi,
On Tuesday, January 10, 2017 11:23:38 PM Anand Moon wrote:
> Hi Shuah,
>
> On 10 January 2017 at 21:58, Shuah Khan wrote:
> > On 01/10/2017 09:05 AM, Bartlomiej Zolnierkiewicz wrote:
> >>
> >> Hi,
> >>
> >> On Tuesday, January 10, 2017 0
On Tuesday, January 10, 2017 07:03:57 PM Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On Tuesday, January 10, 2017 11:23:38 PM Anand Moon wrote:
> > Hi Shuah,
> >
> > On 10 January 2017 at 21:58, Shuah Khan wrote:
> > > On 01/10/2017 09:05 AM, Bartlomiej
On Monday, May 22, 2017 12:02:09 AM Wolfram Sang wrote:
> include/linux/i2c is not for client devices. Move the header file to a
> more appropriate location.
>
> Signed-off-by: Wolfram Sang
Acked-by: Bartlomiej Zolnierkiewicz
> ---
> arch/arm/mach-omap1/board-h2-mmc.c
On Monday, May 22, 2017 12:02:10 AM Wolfram Sang wrote:
> include/linux/i2c is not for client devices. Move the header file to a
> more appropriate location.
>
> Signed-off-by: Wolfram Sang
Acked-by: Bartlomiej Zolnierkiewicz
> ---
> arch/arm/mach-omap2/common.h
t")
>
> Signed-off-by: Ladislav Michl
Patch queued for 4.15, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...
to dwc2_of_match_table.
This patch seems to break bisectability. It moves all the gadget probing
to platform.c but Kconfig/Makefile are not updated (platform.c will be
compiled only for CONFIG_USB_DWC2_PLATFORM=y which in turn depends on
CONFIG_USB_DWC2_HOST). IMO patch #7 should be merged into th
and the platform
> +# interface module will be called dwc2_platform.ko.
>
> ifneq ($(CONFIG_USB_DWC2_PCI),)
> - obj-$(CONFIG_USB_DWC2_HOST) += dwc2_pci.o
> + obj-$(CONFIG_USB_DWC2) += dwc2_pci.o
> dwc2_pci-y := pci.o
> endif
&
On Wednesday, October 22, 2014 02:25:46 PM Bartlomiej Zolnierkiewicz wrote:
> BTW It is a bit late but it would be great if you could split your
> patchset on two. First one merging gadget functionality into
> core/platform code and the second one adding USB_DWC2_DUAL_ROLE
> functi
and compile testing, i.e.
depends on ARCH_MVEBU || COMPILE_TEST
> + select USB_XHCI_PLATFORM
> + ---help---
> + Say 'Y' to enable the support for the xHCI host controller
> + found in Marvell Armada 38x ARM SOCs.
> +
> endif # USB_XHCI_HCD
>
>
mp;& MACH_ARMADA_375) || COMPILE_TEST
> + select GENERIC_PHY
> +
> config PHY_EXYNOS_MIPI_VIDEO
> tristate "S5P/EXYNOS SoC series MIPI CSI-2/DSI PHY driver"
> depends on HAS_IOMEM
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsu
gt; * cleanup on completion.
> */
> -static int s3c_hsotg_map_dma(struct s3c_hsotg *hsotg,
> - struct s3c_hsotg_ep *hs_ep,
> - struct usb_request *req)
> +static inline int s3c_hsotg_map_dma(struct s3c_hsotg *hsotg,
> +
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Kyungmin Park
---
drivers/usb/dwc2/gadget.c | 210 +++---
1 file changed, 12 insertions(+), 198 deletions(-)
diff --git a/drivers/usb/dwc2/gad
Hi,
On Tuesday, July 08, 2014 08:04:47 PM Paul Zimmerman wrote:
> > From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com]
> > Sent: Tuesday, July 08, 2014 7:55 AM
> >
> > The commit 5b7d70c6dbf2 ("USB: Gadget driver for Samsung HS/OtG
> > b
drivers/usb/phy/phy-samsung-usb2 driver got replaced by
drivers/phy/phy-samsung-usb2 one. Remove the leftover hook
from Arndale dts file.
Cc: Mark Brown
Cc: Kamil Debski
Cc: Vivek Gautam
Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Kyungmin Park
---
arch/arm/boot/dts/exynos5250
Hi,
This patch series removes the old Samsung USB PHY drivers that
got replaced by the new ones using the generic PHY layer.
Depends on:
- next-20140813 branch of linux-next kernel
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Bartlo
drivers/usb/phy/phy-samsung-usb2 driver got replaced by
drivers/phy/phy-samsung-usb2 one. Remove the leftover
USB2 PHY node (EHCI/OHCI USB nodes are using the new one
already) from Exynos5250 dtsi file.
Cc: Mark Brown
Cc: Kamil Debski
Cc: Vivek Gautam
Signed-off-by: Bartlomiej Zolnierkiewicz
drivers/usb/phy/phy-samsung-usb3 driver got replaced by
drivers/phy/phy-samsung-usb3 one and is no longer used.
Cc: Kamil Debski
Cc: Vivek Gautam
Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Kyungmin Park
---
drivers/usb/phy/Kconfig| 8 -
drivers/usb/phy/Makefile
drivers/usb/phy/phy-samsung-usb2 driver got replaced by
drivers/phy/phy-samsung-usb2 one and is no longer used.
Cc: Kamil Debski
Cc: Vivek Gautam
Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Kyungmin Park
---
drivers/usb/phy/Kconfig| 8 -
drivers/usb/phy/Makefile
drivers/usb/phy/phy-samsung-usb[2,3] drivers got replaced by
drivers/phy/phy-samsung-usb[2,3] ones and the old common Samsung
USB PHY code is no longer used.
Cc: Kamil Debski
Cc: Vivek Gautam
Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Kyungmin Park
---
drivers/usb/phy/Kconfig
Hi,
On Thursday, August 14, 2014 08:07:40 PM Vivek Gautam wrote:
> Hi Bartlomiej Zolnierkiewicz,
>
>
> On Thursday, August 14, 2014 7:55 PM, Bartlomiej Zolnierkiewicz
> wrote
>
> Subject: [PATCH 3/5] usb: phy: samsung: remove old USB 2.0 PHY driver
>
> I would sa
drivers/usb/phy/phy-samsung-usb[2,3] drivers got replaced by
drivers/phy/phy-samsung-usb[2,3] ones and the old common Samsung
USB PHY code is no longer used.
Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Kyungmin Park
Reviewed-by: Vivek Gautam
Reviewed-by: Jingoo Han
Acked-by: Kishon
drivers/usb/phy/phy-samsung-usb2 driver got replaced by
drivers/phy/phy-samsung-usb2 one and is no longer used.
Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Kyungmin Park
Reviewed-by: Vivek Gautam
Reviewed-by: Jingoo Han
Acked-by: Kishon Vijay Abraham I
Cc: Kamil Debski
---
drivers
drivers/usb/phy/phy-samsung-usb2 driver got replaced by
drivers/phy/phy-samsung-usb2 one. Remove the leftover
USB2 PHY node (EHCI/OHCI USB nodes are using the new one
already) from Exynos5250 dtsi file.
Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Kyungmin Park
Reviewed-by: Vivek Gautam
drivers/usb/phy/phy-samsung-usb2 driver got replaced by
drivers/phy/phy-samsung-usb2 one. Remove the leftover hook
from Arndale dts file.
Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Kyungmin Park
Reviewed-by: Vivek Gautam
Reviewed-by: Jingoo Han
Acked-by: Kishon Vijay Abraham I
Cc
drivers/usb/phy/phy-samsung-usb3 driver got replaced by
drivers/phy/phy-samsung-usb3 one and is no longer used.
Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Kyungmin Park
Reviewed-by: Vivek Gautam
Reviewed-by: Jingoo Han
Acked-by: Kishon Vijay Abraham I
Cc: Kamil Debski
---
drivers
Vijay Abraham I
- added Reviewed-by-s from Vivek Gautam and Jingoo Han
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Bartlomiej Zolnierkiewicz (5):
ARM: dts: remove old USB2 PHY node hook for Arndale
ARM: dts: remove old USB2 PHY node for E
Hi,
On Wednesday, August 20, 2014 01:12:44 PM Felipe Balbi wrote:
> Hi,
>
> On Thu, Aug 14, 2014 at 04:25:22PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > Hi,
> >
> > This patch series removes the old Samsung USB PHY drivers that
> > got replaced by the new
atform devices created by
dwc3 Exynos glue layer and later causes Exynos EHCI driver to
fail probe and Exynos OHCI driver to hang on probe (as observed
on Exynos5250 Arndale board). ]
Cc: Olof Johansson
Cc: Kukjin Kim
Cc: Vivek Gautam
Acked-by: Kyungmin Park
Signed-off-by: Bartlomie
drivers/usb/phy/phy-samsung-usb[2,3] drivers got replaced by
drivers/phy/phy-samsung-usb[2,3] ones and the old common Samsung
USB PHY code is no longer used.
Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Kyungmin Park
Reviewed-by: Vivek Gautam
Reviewed-by: Jingoo Han
Acked-by: Kishon
[ added Alan and Greg to cc: ]
Hi,
On Wednesday, August 27, 2014 11:42:25 PM Vivek Gautam wrote:
> Hi Baltlomiej,
>
>
> On Wed, Aug 27, 2014 at 1:22 PM, Bartlomiej Zolnierkiewicz
> wrote:
> > dwc3 driver is using the new Exynos5 SoC series USB DRD PHY driver
> >
On Thursday, August 28, 2014 12:29:52 PM Greg Kroah-Hartman wrote:
> On Thu, Aug 28, 2014 at 08:11:04PM +0200, Bartlomiej Zolnierkiewicz wrote:
> >
> > [ added Alan and Greg to cc: ]
> >
> > Hi,
> >
> > On Wednesday, August 27, 2014 11:42:25 PM
Hi,
On Friday, August 29, 2014 11:33:04 AM Greg Kroah-Hartman wrote:
> On Fri, Aug 29, 2014 at 11:02:52AM +0200, Bartlomiej Zolnierkiewicz wrote:
> > On Thursday, August 28, 2014 12:29:52 PM Greg Kroah-Hartman wrote:
> > > On Thu, Aug 28, 2014 at 08:11:04PM +0200, Bartlomiej Zo
Renesas USBHS controller support should be available only on
Renesas ARM SoCs and SuperH architecture.
Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Kyungmin Park
Cc: Simon Horman
Cc: Magnus Damm
---
drivers/usb/renesas_usbhs/Kconfig |1 +
1 file changed, 1 insertion(+)
Index: b
Renesas USBHS controller support should be available only on
Renesas ARM SoCs and SuperH architecture.
Signed-off-by: Bartlomiej Zolnierkiewicz
Acked-by: Kyungmin Park
Cc: Simon Horman
Cc: Magnus Damm
---
v2:
- s/ARCH_SH/SUPERH/ (thanks to Sergei Shtylyov)
drivers/usb/renesas_usbhs/Kconfig
ally linked
This comment is no longer true after your changes.
> @@ -19,10 +26,4 @@ ifneq ($(CONFIG_USB_DWC2_PCI),)
> dwc2_pci-y := pci.o
> endif
dwc2_pci will still be build as separate module despite what the updated
documentation for USB_DWC2 says.
> -
is implemented.
Sorry but no. In the current form this just breaks gadget support for
Samsung devices as probe function for gadget will no longer be called.
[ This should be done in the same patch that aggregates gadget and host
initializations into one driver. ]
Best regards,
--
Bartlomiej Zoln
b/dwc2/core.h | 176 +---
> drivers/usb/dwc2/gadget.c | 226
> +-
> drivers/usb/dwc2/hcd.h| 10 --
> 3 files changed, 184 insertions(+), 228 deletions(-)
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Ele
t(hsotg, irq, params);
> + if (retval)
> + return retval;
> + } else if (IS_ENABLED(CONFIG_USB_DWC2_PERIPHERAL)) {
> + retval = dwc2_gadget_init(hsotg, irq);
> + if (retval)
> + return retval;
> + }
d
(hsotg->clk);
> }
>
> return ret;
> @@ -3583,7 +3590,8 @@ static int s3c_hsotg_resume(struct dwc2_hsotg *hsotg)
> dev_info(hsotg->dev, "resuming usb gadget %s\n",
>hsotg->driver->driver.name);
>
> - clk_enable(hsotg->clk);
> + if (!IS_ERR(hsotg->clk))
> + clk_enable(hsotg->clk);
> ret = regulator_bulk_enable(ARRAY_SIZE(hsotg->supplies),
> hsotg->supplies);
> }
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
of_usb_get_dr_mode(dev->dev.of_node);
>
> + spin_lock_init(&hsotg->lock);
> if (IS_ENABLED(CONFIG_USB_DWC2_DUAL_ROLE)) {
> retval = dwc2_gadget_init(hsotg, irq);
> if (retval)
Best regards,
--
Bartlomiej Zolnierkiewicz
Sa
g->wq_otg) {
> + spin_unlock(&hsotg->lock);
> + queue_work(hsotg->wq_otg, &hsotg->wf_otg);
> + spin_lock(&hsotg->lock);
> + }
>
> /* Clear interrupt */
> writel(GINTSTS_CONIDSTSCHNG, hsotg->re
t; .name = dwc2_driver_name,
> @@ -213,6 +234,8 @@ static struct platform_driver dwc2_platform_driver = {
> },
> .probe = dwc2_driver_probe,
> .remove = dwc2_driver_remove,
> + .suspend = dwc2_suspend,
> + .resume = dwc2_resume,
Please use the
orry for the late review but people are not yet used to
the fact that dwc2 now also means "our" good old s3c-hsotg. ;-)
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
On Thursday, September 18, 2014 10:54:24 AM Dinh Nguyen wrote:
> Hi Bartlomiej,
>
> On 09/12/2014 10:49 AM, Bartlomiej Zolnierkiewicz wrote:
> >
> > [ added linux-kernel ML to cc: ]
> >
> > Hi,
> >
> > On Tuesday, August 26, 2014 11:19:52
Hi,
On Friday, September 19, 2014 07:02:49 PM Paul Zimmerman wrote:
> > From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com]
> > Sent: Friday, September 19, 2014 7:50 AM
> >
> > Unfortunately after second look there are even more problems with Kconfig
>
63 matches
Mail list logo
