On Thu, Oct 3, 2019 at 2:54 PM Alan Stern wrote:
>
> The syzbot fuzzer found a slab-out-of-bounds write bug in the hid-gaff
> driver. The problem is caused by the driver's assumption that the
> device must have an input report. While this will be true for all
> normal HID input devices, a suitab
Hi Heiner,
On Fri, May 11, 2018 at 12:11 AM, Heiner Kallweit wrote:
> Due to some other issue with one devices supported by hid-led I figured
> out that it's no longer needed to list devices with own driver in
> hid_have_special_driver[].
>
> So I removed the entries for the hid-led devices and g
F0:094A.0003: input: USB HID v1.11 Mouse
> [PixArt HP USB Optical Mouse] on usb-:00:14.0-2/input0
>
> Signed-off-by: Dave Young
> Cc: sta...@vger.kernel.org
> ---
Reviewed-by: Benjamin Tissoires
> v1->v2: rebase to usb tree hid-quirks-cleanup branch
> drivers
On Nov 27 2017 or thereabouts, Greg KH wrote:
> On Mon, Nov 27, 2017 at 09:16:31AM +0100, Benjamin Tissoires wrote:
> > On Nov 25 2017 or thereabouts, Dave Young wrote:
> > > This mouse keep disconnecting in runleve 3 like below, add it needs the
> > > quirk t
On Nov 25 2017 or thereabouts, Dave Young wrote:
> This mouse keep disconnecting in runleve 3 like below, add it needs the
> quirk to mute the anoying messages.
>
> [ 111.230555] usb 2-2: USB disconnect, device number 6
> [ 112.718156] usb 2-2: new low-speed USB device number 7 using xhci_hcd
>
On Oct 24 2017 or thereabouts, Allen Pais wrote:
> Switch to using the new timer_setup() and from_timer()
> for drivers/hid/*
>
> Cc: Kees Cook
> Signed-off-by: Allen Pais
> ---
>
> Note:This patch is only compile tested.
Looks good enough for me:
Reviewed-by: Ben
; multitouch.
>
> Cc: Jiri Kosina
> Cc: Benjamin Tissoires
> Cc: linux-in...@vger.kernel.org
> Cc: linux-usb@vger.kernel.org
> Cc: Thomas Gleixner
> Signed-off-by: Kees Cook
> ---
> This requires commit 686fef928bba ("timer: Prepare to change timer
> callback argume
Reported-by: Olof Johansson
> Tested-by: Olof Johansson
> Fixes: e399396a6b0 ("HID: usbhid: remove custom locking from usbhid_open...")
> Signed-off-by: Dmitry Torokhov
> ---
slightly reviewed and
Acked-by: Benjamin Tissoires
Cheers,
Benjamin
> drivers/hid/usbhid/h
On Jun 15 2017 or thereabouts, Jiri Kosina wrote:
> On Tue, 13 Jun 2017, Benjamin Tissoires wrote:
>
> > BTW, the merge with your for-next branch is going to be tricky :(
>
> I've just pushed the for-next merge. Second/third pair of eyes (scripted
> eyes even better
usbhid has a list of dynamic quirks in addition to a list of static quirks.
There is not much USB specific in that, so move this part of the module
in core so we can have one central place for quirks.
Signed-off-by: Benjamin Tissoires
---
Resent with -M1 -C1 in format-patch to detect the rename
On Jun 14 2017 or thereabouts, Andy Shevchenko wrote:
> On Wed, Jun 14, 2017 at 11:24 AM, Benjamin Tissoires
> wrote:
> > usbhid has a list of dynamic quirks in addition to a list of static quirks.
> > There is not much USB specific in that, so move this part of the module
>
On Jun 14 2017 or thereabouts, Bastien Nocera wrote:
>
>
> > On 14 Jun 2017, at 10:24, Benjamin Tissoires
> > wrote:
> >
> > Hi,
> >
> > As mentioned by Jiri, I found a way to have this horrible list a thing from
> > the past (to some exte
your other
for-4.12/driver-matching-fix branch. I'll resubmit a proper patch that will
apply properly to for-next as soon as for-4.12/driver-matching-fix gets merged.
Cheers,
Benjamin
Benjamin Tissoires (3):
HID: core: move the dynamic quirks handling in core
HID: quirks: move the
usbhid has a list of dynamic quirks in addition to a list of static quirks.
There is not much USB specific in that, so move this part of the module
in core so we can have one central place for quirks.
Signed-off-by: Benjamin Tissoires
---
drivers/hid/Makefile| 2 +-
drivers/hid
hid_have_special_driver[] useless. It
still allows to not see a hid-generic driver bound and removed during
boot, so we can keep it around.
This will also help other people to have a special HID driver without
the need of recompiling hid-core.
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid
-by: Benjamin Tissoires
---
drivers/hid/hid-core.c| 835 +---
drivers/hid/hid-quirks.c | 866 +-
include/linux/hid.h | 1 +
net/bluetooth/hidp/core.c | 2 +-
4 files changed, 856 insertions(+), 848
On Jun 13 2017 or thereabouts, Benjamin Tissoires wrote:
> On Jun 13 2017 or thereabouts, Jiri Kosina wrote:
> > So I've now pushed the latest version to 'for-4.12/driver-matching-fix' of
> > hid.git, and if no more issues are discovered, I'll push that to Linu
On Jun 13 2017 or thereabouts, Jiri Kosina wrote:
> So I've now pushed the latest version to 'for-4.12/driver-matching-fix' of
> hid.git, and if no more issues are discovered, I'll push that to Linus
> this week so that we finally get rid of this long-lasting PITA (while
> still heading towards
back to generic driver is
> figured out.
>
> Signed-off-by: Jiri Kosina
> ---
Thanks for the quick band-aid.
Same as Hans: I started checking the VID/PID with the drivers
association, and got bored after a few.
I _think_ you automated the thing
On Jun 09 2017 or thereabouts, Greg KH wrote:
> On Fri, Jun 09, 2017 at 10:52:42AM +0200, Bjørn Mork wrote:
> > Greg KH writes:
> >
> > > On Fri, Jun 09, 2017 at 10:21:47AM +0200, Jiri Kosina wrote:
> > >> Longer-term, we'd ideally make 'generic' driver special and let it
> > >> attach
> > >> a
On Jun 08 2017 or thereabouts, Philipp Zabel wrote:
> Hi Benjamin,
>
> On Wed, Jun 7, 2017 at 9:11 AM, Benjamin Tissoires
> wrote:
> > Hi Philip,
> >
> > On Jun 07 2017 or thereabouts, Philipp Zabel wrote:
> [...]
> > 2 things:
> > - the 2 patches s
Hi Philip,
On Jun 07 2017 or thereabouts, Philipp Zabel wrote:
> When plugging in an Oculus Rift CV1 HMD, it takes a long time until the hidraw
> devices appear, specifically two control transfers time out querying the HID
> report descriptors:
>
> $ echo 1 > /sys/module/hid/parameters/debug
in
> Cc: Jarkko Sakkinen
> Cc: Jani Nikula
> Cc: Ben Skeggs
> Cc: Benjamin Tissoires
> Cc: Joerg Roedel
> Cc: Adrian Hunter
> Cc: Yisen Zhuang
> Cc: Bjorn Helgaas
> Cc: Zhang Rui
> Cc: Felipe Balbi
> Cc: Mathias Nyman
> Cc: Heikki Krogerus
>
ned-off-by: Benjamin Tissoires
---
changes in v2:
- amended subject (was: HID: get rid of HID_QUIRK_NO_INIT_REPORTS)
- kept around HID_QUIRK_NO_INIT_REPORTS
- force retrieval of reports at HIDIOCGUSAGE(S) in hiddev
---
drivers/hid/i2c-hid/i2c-hid.c | 63 -
d
On Mar 06 2017 or thereabouts, Jiri Kosina wrote:
> On Thu, 5 Jan 2017, Benjamin Tissoires wrote:
>
> > For case 1, the hiddev documentation provides an ioctl to do the
> > init manually. A solution could be to retrieve the requested report
> > when EVIOCGUSAGE is called
ed if descendent above a printk
>
> Signed-off-by: Joe Perches
Looks good to me:
Reviewed-by: Benjamin Tissoires
Cheers,
Benjamin
> ---
> drivers/hid/usbhid/hid-core.c | 16 +++-
> drivers/hid/usbhid/hid-quirks.c | 11 ---
> 2 files changed, 11 insert
On Mar 02 2017 or thereabouts, Jaejoong Kim wrote:
> We need to store the minor number each drivers. In case of hidraw, it's
> minor number stores in struct hidraw. But hiddev's minor is located in
> struct hid_device.
>
> So reallocates for hiddev's minor number.
>
There is not a real need to h
On Mar 02 2017 or thereabouts, Jaejoong Kim wrote:
> The hid-core announces kernel message which driver is loaded if there is
> a hiddev, but hiddev's minor number is always zero even though it's not
> zero.
>
> So, we need to store the minor number asked from usb core and do some
> refactoring wo
Hi,
well, not to undermine your work, I am not a big fan of this kind of
patches. Yes, it's nice to follow checkpatch, but on some rare case, we
just ignore the warning because the end result would be too ugly (I
haven't read the patch, so I am not judging how you solved the issues
raised here and
hiddev. hidraw does use a minor too, but stores it in struct hidraw
directly, so IMO it would make sense to store this in struct hiddev. The
problem is that this struct is not exported, and it's going to be some
refactoring work to do so.
So, in a way, I am tempted to give my:
Acked-by: Benjamin
2 with jspoll=2,
> resulting in a polling rate of 500Hz (verified with evhz).
>
> Signed-off-by: Tobias Jakobi
> ---
Looks good to me.
Acked-by: Benjamin Tissoires
> Documentation/kernel-parameters.txt | 3 +++
> drivers/hid/usbhid/hid-core.c | 18 +++---
Grant Grundler
> ---
> Most of the kernel already uses hard coded strings.
> The few places that don't are easy to fix.
FWIW:
Reviewed-by: Benjamin Tissoires
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vge
e the behavior and hope that we won't break any
userspace tool.
Note that I don't think hidraw would be affected and I checked that
the FF drivers that need to interact with the report fields are all
using output reports, which are not initialized by
usbhid_init_reports().
Signed-o
d36b3a9b2aac5993da1345f3b12e6ac Mon Sep 17 00:00:00 2001
From: Benjamin Tissoires
Date: Sat, 10 Dec 2016 21:58:55 +0100
Subject: [PATCH] HID: fix missing irq field
commit ba18a9314a94 ("Revert "HID: i2c-hid: Add support for ACPI GPIO
interrupts"") removed the need for storing th
> the driver is extended by somebody for supporting another LED device.
> ---
Looks like the receive function is only called from .probe(), so this
should be safe.
However, for the send function, is there a chance there can be a
concurrent access of the buffer? (like 2 userspace processes w
t; So let's remove the old USB LED driver.
>
> Signed-off-by: Heiner Kallweit
> Acked-by: Greg Kroah-Hartman
Acked-by: Benjamin Tissoires
Cheers,
Benjamin
> ---
> drivers/usb/misc/Kconfig | 9 --
> drivers/usb/misc/Makefile | 1 -
> drivers/usb/misc/usbled.c
Hi Heiner,
On Jun 17 2016 or thereabouts, Heiner Kallweit wrote:
> This patch migrates the USB LED driver to the HID subsystem.
> Supported are Dream Cheeky Webmail Notifier / Friends Alert
> and Riso Kagaku Webmail Notifier.
>
> Benefits:
> - Avoid using USB low-level calls and use the HID subsy
On Jun 15 2016 or thereabouts, Heiner Kallweit wrote:
> Am 14.06.2016 um 23:49 schrieb Benjamin Tissoires:
> > On Jun 12 2016 or thereabouts, Heiner Kallweit wrote:
> >> The Riso Kagaku Webmail Notifier (and its clones) is supported as part of
> >> usb/misc/usbled d
On Jun 12 2016 or thereabouts, Heiner Kallweit wrote:
> The Riso Kagaku Webmail Notifier (and its clones) is supported as part of
> usb/misc/usbled driver currently. This patch migrates the driver for this
> device to the HID subsystem.
>
> Benefits:
> - Avoid using USB low-level calls and use the
On May 28 2016 or thereabouts, Heiner Kallweit wrote:
> Am 27.05.2016 um 23:45 schrieb Benjamin Tissoires:
> > On May 27 2016 or thereabouts, Heiner Kallweit wrote:
> >> The Riso Kagaku Webmail Notifier (and its clones) is supported as part of
> >> usb/misc/usbled d
On May 27 2016 or thereabouts, Heiner Kallweit wrote:
> The Riso Kagaku Webmail Notifier (and its clones) is supported as part of
> usb/misc/usbled driver currently. This patch migrates the driver for this
> device to the HID subsystem.
>
> Benefits:
> - Avoid using USB low-level calls and use the
ut your mailer might have mangled the lines.
Jiri might be able to apply the patch, but next time, please make sure
the mailer client does not break lines.
Reviewed-by: Benjamin Tissoires
Cheers,
Benjamin
> drivers/hid/hid-ids.h | 1 +
> drivers/hid/usbhid/hid-quirks.c | 1 +
&
> Signed-off-by: Stafford Horne
Works for me:
Reviewed-by: Benjamin Tissoires
Cheers,
Benjamin
> ---
> Resending the same patch for the keyboard to simply disable init reports,
> as discussed with Oliver there might be some hidden functionality which
> I will look into. At t
crosoft
>>>>> Surface Type Covers.
>>>>>
>>>>> By using MT_CLS_EXPORT_ALL_INPUTS, the keyboards function as
>>>>> well as the multitouch pads do.
>>>>
>>>> I've discussed this a couple of weeks back with Benjamin
ed-off-by: Adrien Vergé
> ---
The HID part is:
Reviewed-by: Benjamin Tissoires
Cheers,
Benjamin
> drivers/hid/hid-ids.h | 5 -
> drivers/hid/usbhid/hid-quirks.c | 9 +++--
> 2 files changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/hid/hid-ids.
Hi Adrien,
On Tue, Nov 24, 2015 at 2:49 PM, Adrien Vergé wrote:
> All ELAN hid devices seem to require the ALWAYS_POLL quirk. Let's use
> this quirk for all devices from this vendor, rather than maintaining a
> list of all its known product IDs.
>
> To achieve that, this patch introduces a new hi
Please try to keep the list ordered by PID.
Maybe Jiri can amend that directly in his tree too.
Reviewed-by: Benjamin Tissoires
Cheers,
Benjamin
> #define USB_DEVICE_ID_CHICONY_TACTICAL_PAD 0x0418
> #define USB_DEVICE_ID_CHICONY_MULTI_TOUCH 0xb19d
> #define USB_DEVICE_ID_CHICONY
I have no clue what this code is doing (don't know much about the ff system).
Quoting your initial 0001/0001, I thing the commit message should be
the following.
Jim, can you please validate it?
"
The FF2 driver (usbhid/hid-pidff.c) does not set the effect ID when
uploading an effect. The result i
You are missing here (before the first '---' the commit message which
should state why you want to have this patch merged.
To rephrase and continue what you wrote in your very first submission
of this series, this could be (including your Signed-of-by):
The FF2 driver (usbhid/hid-pidff.c) sends c
l:
> +hid_device_io_stop(hid);
> +
For the record, we need to close the IO when leaving or the whole IO
mutex will be moot.
Cheers,
Benjamin
> kfree(pidff);
> return error;
> }
>
> ---
>
> On 20/01/2015 14:09, Benjamin Tissoires wrote:
>>
>&g
Hi,
Jim, in addition to what Alan said, here are some comments that I
would like to be fixed in the v2.
On Sun, Jan 18, 2015 at 11:07 AM, Jim Keir wrote:
> From: Jim Keir
> Signed-off-by: Jim Keir
>
The Signed-off-by line is generally at the end of the commit message.
This way, if someone els
If I understood correctly, you just want to dump the hid output.
You can just cat /sys/kernel/debug/hid/*/events if debugfs is mounted.
Or you may want to have a look at these 2 projects:
hid-recorder -> http://bentiss.github.io/hid-replay-docs/
usbhid-dump-> https://github.com/DIGImend/usbhid-du
On Fri, Mar 21, 2014 at 6:08 PM, Yufeng Shen wrote:
>
>
> On Fri, Mar 21, 2014 at 4:58 PM, Benjamin Tissoires
> wrote:
>>
>> On Fri, Mar 21, 2014 at 3:39 PM, Yufeng Shen wrote:
>> > There is timeout error during initialization:
>> > kernel: [ 14.
On Fri, Mar 21, 2014 at 3:39 PM, Yufeng Shen wrote:
> There is timeout error during initialization:
> kernel: [ 14.167086] hid-multitouch 0003:2512:5003.0001:
> usb_submit_urb(ctrl) failed: -1
> kernel: [ 14.167135] hid-multitouch 0003:2512:5003.0001: timeout
> initializing reports
> kernel:
Hi,
On Mon, Jan 27, 2014 at 6:02 PM, Yufeng Shen wrote:
> There is timeout error during initialization:
> kernel: [ 11.733104] hid-multitouch 0003:1870:0110.0001:
> usb_submit_urb(ctrl) failed: -1
> kernel: [ 11.734093] hid-multitouch 0003:1870:0110.0001: timeout
> initializing reports
>
>
On Fri, Aug 23, 2013 at 12:52 PM, Andreas Lillebø Holm
wrote:
> Hi,
>
> I just wanna followup this issue a bit more.
>
> We have now tested on several hardware platform, and it is only on one
> platform it fails. The platform it fails on is Atom Intel e6xx CPU with EG20T
> PCH platform controlle
Hi Peter,
thanks for forwarding this to the appropriate people & mailing list.
Hi Sarah,
thanks for starting investigating this :)
On Fri, Jul 19, 2013 at 1:37 AM, Peter Hurley wrote:
>>>
>>>
>>>
>>> Before we revert to using the workaround, I'd like to suggest that
>>> this new "hidden" probl
Adding Jiri to the recipient list of the patch, otherwise, the thread
may fall in the depth of his mailbox :)
Cheers,
Benjamin
On Thu, Oct 25, 2012 at 7:08 PM, Benjamin Tissoires
wrote:
> Hi Alan,
>
> Yes, I saw that too.
>
> Acked-by: Benjamin Tissoires
>
> On Thu, Oc
Hi Alan,
Yes, I saw that too.
Acked-by: Benjamin Tissoires
On Thu, Oct 25, 2012 at 4:35 PM, Alan Cox wrote:
> From: Alan Cox
>
> Signed-off-by: Alan Cox
> ---
>
> drivers/hid/hid-multitouch.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> d
59 matches
Mail list logo
