Re: [PATCH 1/3] ARM: OMAP4+: hwmod data: Don't prevent RESET of USB Host module

2013-12-09 Thread Benoit Cousson
-by: Roger Quadros rog...@ti.com Acked-by: Paul Walmsley p...@pwsan.com Will you pick this up for the -rc series, or do you want me or Tony to? Roger writes that this one's pretty important. I guess, it is better for you to take it. I don't have anything queued for -rc. Acked-by: Benoit Cousson bcous

Re: [PATCH] ARM: dts: omap3-beagle: Adapt USB OTG to generic PHY framework

2013-10-18 Thread Benoit Cousson
Hi Roger, On 18/10/2013 14:00, Roger Quadros wrote: Hi Benoit, Could you please include this one for 3.13? Without this OTG port will be broken for beagle. Thanks. I've just applied it. Thanks, Benoit cheers, -roger On 10/07/2013 01:46 PM, Roger Quadros wrote: The generic PHY framewrok

Re: [PATCH 1/1] ARM: dts: omap3: Adapt USB OTG to generic PHY framework

2013-10-15 Thread Benoit Cousson
Hi Roger, On 14/10/2013 11:20, Roger Quadros wrote: Hi Benoit, On 10/10/2013 06:34 PM, Felipe Balbi wrote: On Mon, Oct 07, 2013 at 04:28:13PM +0300, Roger Quadros wrote: The generic PHY framewrok expects different properties than the old USB PHY framework. Supply those properties. Fixes USB

Re: [PATCH v3 05/10] ARM: dts: omap3-beagle: Use reset-gpios for hsusb2_reset

2013-10-03 Thread Benoit Cousson
Hi Roger, Yes, I will. I've been waiting for these ones for so long :-) Thanks, Benoit On 03/10/2013 12:34, Roger Quadros wrote: Hi Benoit, Could you please take the device tree related patches [5 to 10] in this series? Thanks. cheers, -roger On 09/24/2013 11:53 AM, Roger Quadros wrote:

Re: [PATCH v3 05/10] ARM: dts: omap3-beagle: Use reset-gpios for hsusb2_reset

2013-10-03 Thread Benoit Cousson
On 03/10/2013 14:05, Benoit Cousson wrote: Hi Roger, Yes, I will. I've been waiting for these ones for so long :-) In fact it does not apply correctly on my for_3.13/dts branch :-( error: arch/arm/boot/dts/omap3-beagle.dts: patch does not apply Patch failed at 0004 ARM: dts: omap3-beagle

Re: [PATCH v3 05/10] ARM: dts: omap3-beagle: Use reset-gpios for hsusb2_reset

2013-10-03 Thread Benoit Cousson
On 03/10/2013 15:58, Roger Quadros wrote: Hi Benoit, On 10/03/2013 04:44 PM, Benoit Cousson wrote: On 03/10/2013 14:05, Benoit Cousson wrote: Hi Roger, Yes, I will. I've been waiting for these ones for so long :-) In fact it does not apply correctly on my for_3.13/dts branch :-( error

Re: [PATCH v3 0/5] ARM: OMAP: DTS/HWMOD/defconfig changes for USB3

2013-08-21 Thread Benoit Cousson
. Tony, I will update my pull-request now before Kevin and Olof pulled it. Regards, Benoit Changes since v1: - split ocp2scp dts and hwmod data into separate patches - reorganize the series in order to group DTS, hwmod and defconfig changes Benoit Cousson (1

Re: [PATCH v2 0/9] USB: phy: phy-nop: Manage RESET GPIO in the driver

2013-08-16 Thread Benoit Cousson
Hi Roger, On 15/08/2013 12:18, Roger Quadros wrote: Hi, Modelling the RESET line as a regulator supply wasn't a good idea as it abuses the regulator framework and makes adaptation code/data more complex. Instead, manage the RESET gpio line directly in the driver. This also makes us easy to

Re: [PATCH v3 7/8] ARM: dts: omap4: update omap-control-usb nodes

2013-08-16 Thread Benoit Cousson
: Benoit Cousson bcous...@baylibre.com Signed-off-by: Roger Quadros rog...@ti.com --- arch/arm/boot/dts/omap4.dtsi | 20 1 files changed, 12 insertions(+), 8 deletions(-) diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi index 22d9f2b..a77dd0a 100644

Re: [PATCH v2 2/8] usb: phy: omap: Add new device types and remove omap_control_usb3_phy_power()

2013-08-15 Thread Benoit Cousson
Hi Roger, On 15/08/2013 15:15, Roger Quadros wrote: Add support for new device types and in the process rid of ti,type device tree property. The correct type of device will be determined from the compatible string instead. Introduce a compatible string for each device type. At the moment we

Re: [PATCH 6/7] ARM: dts: omap4: update omap-control-usb nodes

2013-08-14 Thread Benoit Cousson
Hi Roger, On 01/08/2013 16:05, Roger Quadros wrote: Split otghs_ctrl and USB2 PHY power down into separate omap-control-usb nodes. Update ti,mode property. Nit: I guess you mean ti,type? CC: Benoit Cousson benoit.cous...@linaro.org Signed-off-by: Roger Quadros rog...@ti.com --- arch/arm

Re: [RFC] am33xx: create child nodes for the two musb controllers

2013-06-27 Thread Benoit Cousson
Hi Sebastian, On 06/26/2013 05:33 PM, Sebastian Andrzej Siewior wrote: I've been thinkig about creating two child nodes for the independent musb controllers on the am33. I've been thinking about the following: diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index

Re: [PATCH v4 00/21] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-04-08 Thread Benoit Cousson
Hi Tony, On 04/05/2013 05:43 PM, Tony Lindgren wrote: * Benoit Cousson b-cous...@ti.com [130405 03:00]: On 04/05/2013 10:30 AM, Benoit Cousson wrote: ... ARM: dts: OMAP4: Add HS USB Host IP nodes ARM: dts: OMAP3: Add HS USB Host IP nodes ARM: dts: omap3-beagle: Add USB Host support

Re: [PATCH v4 00/21] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-04-05 Thread Benoit Cousson
Hi Roger, On 03/20/2013 04:44 PM, Roger Quadros wrote: Hi Tony, These patches provide the SoC side code required to support the changes in the OMAP USB Host drivers done in [1], [2] [3]. Device tree support is added for Beagleboard only. I've removed Panda device tree support till we

Re: [PATCH v4 00/21] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-04-05 Thread Benoit Cousson
Hi Roger, On 04/05/2013 10:30 AM, Benoit Cousson wrote: ... ARM: dts: OMAP4: Add HS USB Host IP nodes ARM: dts: OMAP3: Add HS USB Host IP nodes ARM: dts: omap3-beagle: Add USB Host support These 3 DTS patches are good to me, but I cannot applied them on top of the already existing

Re: [PATCH v3 0/7] ARM: dts: omap: Add dts data for USB

2013-03-15 Thread Benoit Cousson
Hi Kishon, On 03/13/2013 10:11 AM, kishon wrote: Benoit, Will you be queuing this patch series? I'm reviewing them right now. Regards, Benoit Thanks Kishon On Thursday 07 March 2013 07:05 PM, Kishon Vijay Abraham I wrote: Hi Benoit, Here are the dt data patches to get usb device

Re: [PATCH v3 0/7] ARM: dts: omap: Add dts data for USB

2013-03-15 Thread Benoit Cousson
+ Jon Hi Kishon, On 03/07/2013 02:35 PM, Kishon Vijay Abraham I wrote: Hi Benoit, Here are the dt data patches to get usb device functional in OMAP platforms. All the patches deal with modifying arch/arm/boot except one which modifies Documentation/../usb/omap-usb.txt Changes from v2:

Re: [PATCH 23/24] ARM: OMAP2+: Allow clock alias provision from device tree

2013-03-12 Thread Benoit Cousson
Hi Roger, On 03/12/2013 12:43 PM, Roger Quadros wrote: Currently on OMAP, it is not possible to specify a clock consumer to any of the OMAP generated clocks using the device tree. This can pose a problem for external devices that run off an OMAP clock as we can't reliably provide a reference

Re: [PATCH v3 0/3] ARM: dts: omap: add dt data for MUSB

2013-01-10 Thread Benoit Cousson
Hi Kishon, On 01/10/2013 07:19 AM, kishon wrote: On Friday 28 December 2012 12:05 AM, Aaro Koskinen wrote: Hi, On Thu, Sep 20, 2012 at 05:21:15AM +0200, Benoit Cousson wrote: On 09/19/2012 11:32 AM, Kishon Vijay Abraham I wrote: This patch series adds dt data to get MUSB working in omap4

Re: [PATCH v4 16/23] ARM: OMAP2+: clock data: Merge utmi_px_gfclk into usb_host_hs_utmi_px_clk

2012-12-17 Thread Benoit Cousson
Hi, On 12/14/2012 07:44 PM, Paul Walmsley wrote: Hi On Fri, 14 Dec 2012, Tony Lindgren wrote: Paul, what about this patch? Looks like you've acked the other clock patches in this series but not this one? I commented on it briefly here: https://patchwork.kernel.org/patch/1838111/

Re: [PATCH v4 16/23] ARM: OMAP2+: clock data: Merge utmi_px_gfclk into usb_host_hs_utmi_px_clk

2012-12-17 Thread Benoit Cousson
On 12/17/2012 05:13 PM, Roger Quadros wrote: On 12/17/2012 10:13 AM, Benoit Cousson wrote: Hi, On 12/14/2012 07:44 PM, Paul Walmsley wrote: Hi On Fri, 14 Dec 2012, Tony Lindgren wrote: Paul, what about this patch? Looks like you've acked the other clock patches in this series

Re: [PATCH 1/4] ARM: OMAP: usb-host: Device tree support for USB Host

2012-11-16 Thread Benoit Cousson
Hi Roger, On 11/15/2012 03:56 PM, Roger Quadros wrote: Provides a means for the OMAP USB host subsystem to be initialized from Device tree. This is a first step for device tree migration where we specify only the board specific stuff. Things like I/O address space and interrupts are not yet

Re: [PATCH 1/4] ARM: OMAP: usb-host: Device tree support for USB Host

2012-11-16 Thread Benoit Cousson
On 11/16/2012 11:55 AM, Roger Quadros wrote: Hi Benoit, On 11/16/2012 12:30 PM, Benoit Cousson wrote: Hi Roger, On 11/15/2012 03:56 PM, Roger Quadros wrote: Provides a means for the OMAP USB host subsystem to be initialized from Device tree. This is a first step for device tree migration

Re: [PATCH v2] usb: musb: dsps: dt binding - add resources, example

2012-11-07 Thread Benoit Cousson
Hi Felipe, On 11/06/2012 07:22 PM, Felipe Balbi wrote: Hi, On Tue, Nov 06, 2012 at 05:58:57PM +0100, Benoit Cousson wrote: On 11/06/2012 05:44 PM, Felipe Balbi wrote: Hi, On Tue, Nov 06, 2012 at 07:26:06PM +0530, Afzal Mohammed wrote: OMAP2+ family of devices are now obtaining resources

Re: [PATCH v2] usb: musb: dsps: dt binding - add resources, example

2012-11-06 Thread Benoit Cousson
On 11/06/2012 05:44 PM, Felipe Balbi wrote: Hi, On Tue, Nov 06, 2012 at 07:26:06PM +0530, Afzal Mohammed wrote: OMAP2+ family of devices are now obtaining resources via DT, earlier it was obtained from hwmod. Update binding document accrodingly, while at it add example. Signed-off-by:

Re: [PATCH v4 2/7] usb: dwc3-omap: use of_platform API to create dwc3 core pdev

2012-10-25 Thread Benoit Cousson
On 10/15/2012 03:27 PM, Kishon Vijay Abraham I wrote: Used of_platform_populate() to populate dwc3 core platform_device from device tree data. Since now the allocation of unique device id is handled by of_*, removed the call to dwc3_get_device_id. Just for my understanding: How are these

Re: [PATCH v3 0/3] ARM: dts: omap: add dt data for MUSB

2012-09-19 Thread Benoit Cousson
Hi Kishon, On 09/19/2012 11:32 AM, Kishon Vijay Abraham I wrote: This patch series adds dt data to get MUSB working in omap4 and omap3 Changes from v2: * Changes the subject of all the patches to include ARM: dts: * Added reg property and interrupt property for usb_otg_hs. Previously these

Re: [PATCH] arm/dts: omap: Add omap-usb2 dt data

2012-09-11 Thread Benoit Cousson
Hi Kishon, On 09/11/2012 08:12 AM, Kishon Vijay Abraham I wrote: Add omap-usb2 data node in omap4 device tree file. Since omap-usb2 is connected to ocp2scp, omap-usb2 dt data is added as a child node of ocp2scp. Could you add more details about the omap-usb2? You must update the

Re: [PATCH v2 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-09-11 Thread Benoit Cousson
to control module, omap2430 will handle the register writes to control module by itself. So a new address space to represent this control module register is added to usb_otg_hs. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com Acked-by: Benoit Cousson b-cous...@ti.com --- arch/arm/mach

Re: [PATCH 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-09-10 Thread Benoit Cousson
driver to write to control module, omap2430 will handle the register writes to control module by itself. So a new address space to represent this control module register is added to usb_otg_hs. Cc: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- arch/arm