> Unnecessary and incorrect whitespace changes.
Thanks Alan. Fixed in v3.
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
Print bcdDevice which is used by vendors to identify different versions
of the same product (or different versions of firmware).
Adding this to the logs will be useful for support purposes.
Match the %2x.%02x formatting that's used by lsusb -v for this same value.
Signed-off-by: Benson
s this (bcdDevice: 0.03 for example) and in my experience
> > it has generally matched up with how hardware manufacturers refer
> > to their firmware.
>
> Nevermind, %x should show bcd properly. looks fine.
I like the way lsusb -v does it better. Take a look at v2.
Thanks,
Benson
--
Print bcdDevice which is used by vendors to identify different versions
of the same product (or different versions of firmware).
Adding this to the logs will be useful for support purposes.
Match the %2x.%02x formatting that's used by lsusb -v for this same value.
Signed-off-by: Benson
Print bcdDevice which is used by vendors to identify different versions
of the same product (or different versions of firmware).
Adding this to the logs will be useful for support purposes.
Signed-off-by: Benson Leung
---
drivers/usb/core/hub.c | 16 +---
1 file changed, 9
Hi Oliver,
On Mon, Sep 11, 2017 at 01:02:52PM -0700, Benson Leung wrote:
> Thanks for the pointer. I'll respin the patch with the no_resume version of
> usb_autopm_get_interface and retest.
>
I went and tried this patch but with usb_autopm_get_interface_no_resume instead
and the
Hi Oliver,
On Sat, Sep 09, 2017 at 09:35:52AM +0200, Oliver Neukum wrote:
> Am Freitag, den 08.09.2017, 10:43 -0700 schrieb Dmitry Torokhov:
> > From: Benson Leung
> >
> > usbhid->intf->needs_remote_wakeup is set when a device is opened, and is
> > cleared whe
came up with this patch.
Thanks for the explanation Raj.
Reviewed-by: Benson Leung
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordo
uirk(hcd, true);
>
> return xhci_suspend(xhci, do_wakeup);
> }
> @@ -334,7 +368,7 @@ static int xhci_pci_resume(struct usb_hcd *hcd, bool
> hibernated)
> usb_enable_intel_xhci_ports(pdev);
>
> if (xhci->quirks & XHCI_PME_STUCK_QUIRK)
> - xhci_pme_quirk(xhci);
> + xhci_pme_quirk(hcd, false);
>
> retval = xhci_resume(xhci, hibernated);
> return retval;
> --
> 1.9.1
>
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Nov 25, 2014 at 7:24 AM, Alan Stern wrote:
> On Mon, 24 Nov 2014, Benson Leung wrote:
>
>> Hi Alan,
>>
>>
>> On Sat, Nov 22, 2014 at 7:55 AM, Alan Stern
>> wrote:
>> > There is no USB wrapper for pm_runtime_idle calls, but one could be
>
e_idle(usbhid->intf->dev.parent);
It did not work. I see the autosuspend_check() that was kicked off as
a result of hid_hw_power, which falls into the "remote wakeup needed
for autosuspend" branch, but I don't see another autosuspend_check()
that picks up the updated value of
om - properly enable runtime PM
5d9efc5 Input: usbtouchscreen - implement runtime power management
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.ker
On Fri, Nov 14, 2014 at 1:08 AM, Oliver Neukum wrote:
> On Thu, 2014-11-13 at 12:16 -0800, Benson Leung wrote:
>
>> In usbhid_open, usb_autopm_get_interface is called
>> before setting the needs_remote_wakeup flag, and
>> usb_autopm_put_interface is called after hid_start
to add get/put around the clear in usbhid_stop as well.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
On Fri, Nov 14, 2014 at 7:17 AM, Alan Stern wrote:
> On Thu, 13 Nov 2014, Benson Leung wrote:
>
>> Hi Alan,
>>
>> On Thu, Nov 13, 2014 at 2:11 PM, Ala
but I saw other
places in the kernel where it was done with a get/put.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info
On Thu, Nov 13, 2014 at 1:18 PM, Alan Stern wrote:
> If you interchange the two lines then the flag _will_ be cleared before
> usb_kill_urb() and autosuspend_check() can run. This means your patch
> description is bogus.
Gotcha. v2 posted. Thanks for the direction.
--
Benson Leung
lag is cleared as a result of usb_kill_urb(usbhid->urbin);
The result is that a device that may otherwise autosuspend will
fail to enter suspend again after all handles to it are closed.
Clear the flag first before usb_kill_urb, which may result in a
autosuspend_check().
Signed-off-by: Ben
usbhid->intf->needs_remote_wakeup = 0;
> + usb_kill_urb(usbhid->urbin);
>
> Have you tried this?
Yes, I tried that as well, and that does work.
I used the get/put because that's the way it was done in other
drivers, for example in synusb_close() in
d
flag, and
usb_autopm_put_interface is called after hid_start_in.
However, when the device is closed in usbhid_close, the same
protection isn't there when clearing needs_remote_wakeup. This will
add that to usbhid_close as well as usbhid_stop.
Signed-off-by: Benson Leung
---
drivers/hid/usbhid/h
On Mon, Nov 3, 2014 at 8:43 AM, Anton Staaf wrote:
> Add support for Google devices that export simple serial
> interfaces using the vendor specific SubClass/Protocol pair
> 0x50/0x01.
>
> Signed-off-by: Anton Staaf
Reviewed-by: Benson Leung
--
Benson Leung
Software Engi
> stable), or if this is just a precaution.
We ran into this on HP Chromebook 14 (Falco). The port reset flag
would be set after a suspend/resume cycle with nothing attached.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line "
21 matches
Mail list logo
