Re: [PATCH V2] USB: initialize or shutdown PHY when add or remove host controller

2013-06-24 Thread Chao Xie
On Tue, Jun 25, 2013 at 3:45 AM, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Jun 21, 2013 at 09:07:59AM +0800, Chao Xie wrote: On Fri, Jun 21, 2013 at 1:25 AM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 20 Jun 2013, Felipe Balbi wrote: In fact, the PHY setting and handling

Re: [PATCH V2] USB: initialize or shutdown PHY when add or remove host controller

2013-06-20 Thread Chao Xie
On Fri, Jun 21, 2013 at 1:25 AM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 20 Jun 2013, Felipe Balbi wrote: In fact, the PHY setting and handling is related to platform or SOC, and for different SOC they can have same EHCI HCD but they PHY handling can be different. Omap'a case

Re: [PATCH V2] USB: initialize or shutdown PHY when add or remove host controller

2013-06-20 Thread Chao Xie
correct for irq. irq number is get by gludriver, while irq is requested by EHCO HCD. On Fri, Jun 21, 2013 at 9:07 AM, Chao Xie xiechao.m...@gmail.com wrote: On Fri, Jun 21, 2013 at 1:25 AM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 20 Jun 2013, Felipe Balbi wrote: In fact, the PHY

Re: [PATCH V2] USB: initialize or shutdown PHY when add or remove host controller

2013-06-19 Thread Chao Xie
On Wed, Jun 19, 2013 at 3:51 PM, Roger Quadros rog...@ti.com wrote: Hi Chao, On 06/19/2013 05:31 AM, Chao Xie wrote: Some controller need software to initialize PHY before add host controller, and shut down PHY after remove host controller. Add the generic code for these controllers so

[PATCH] USB: initialize or shutdown PHY when add or remove host controller

2013-06-18 Thread Chao Xie
Some controller need software to initialize PHY before add host controller, and shut down PHY after remove host controller. Add the generic code for these controllers so they do not need do it in its own host controller driver. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/core

Re: [PATCH] USB: initialize or shutdown PHY when add or remove host controller

2013-06-18 Thread Chao Xie
On Tue, Jun 18, 2013 at 4:48 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Jun 18, 2013 at 11:45:05AM +0300, Roger Quadros wrote: this looks wrong for two reasons: a) you're not grabbing the PHY here. You can't just assume another entity grabbed your PHY for you. Isn't

[PATCH V2] USB: initialize or shutdown PHY when add or remove host controller

2013-06-18 Thread Chao Xie
Some controller need software to initialize PHY before add host controller, and shut down PHY after remove host controller. Add the generic code for these controllers so they do not need do it in its own host controller driver. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/core

Re: [PATCH V2] USB: initialize or shutdown PHY when add or remove host controller

2013-06-18 Thread Chao Xie
On Wed, Jun 19, 2013 at 10:48 AM, Greg KH gre...@linuxfoundation.org wrote: On Tue, Jun 18, 2013 at 10:31:20PM -0400, Chao Xie wrote: Some controller need software to initialize PHY before add host controller, and shut down PHY after remove host controller. Add the generic code

Re: [PATCh V10 04/12] usb: ehci: ehci-mv: use PHY driver for ehci

2013-06-17 Thread Chao Xie
On Sat, Jun 15, 2013 at 4:01 AM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 14 Jun 2013, Roger Quadros wrote: hi The following is my understanding. I think for PHY initialization and shutdown part, it is generic for other parts. PHY initialization need to be called before

Re: [PATCh V10 04/12] usb: ehci: ehci-mv: use PHY driver for ehci

2013-06-13 Thread Chao Xie
On Thu, Jun 13, 2013 at 11:08 PM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 13 Jun 2013, Chao Xie wrote: These operations sound generic enough to be done at HCD layer, no? So no need to replicate the same stuff in ohci, ehci, xhci, etc. The HCD layer handles suspend

Re: [PATCh V10 04/12] usb: ehci: ehci-mv: use PHY driver for ehci

2013-06-13 Thread Chao Xie
On Fri, Jun 14, 2013 at 9:31 AM, Chao Xie xiechao.m...@gmail.com wrote: On Thu, Jun 13, 2013 at 11:08 PM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 13 Jun 2013, Chao Xie wrote: These operations sound generic enough to be done at HCD layer, no? So no need to replicate the same

Re: [PATCh V10 04/12] usb: ehci: ehci-mv: use PHY driver for ehci

2013-05-28 Thread Chao Xie
On Wed, May 29, 2013 at 12:24 AM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, May 13, 2013 at 10:13:44AM -0400, Alan Stern wrote: On Mon, 13 May 2013, Chao Xie wrote: Originaly, ehci driver will call the callbacks in platform data for PHY initialization and shut down. With PHY driver

[V9 PATCH 00/12] mv-usb phy driver

2013-05-12 Thread Chao Xie
to replace udelay V10-V9 Grammar fix in comments. Chao Xie (12): usb: phy: protect phy init and shutdown for mutiple deivces usb: phy: mv_usb2: add PHY driver for marvell usb2 controller usb: gadget: mv_udc: use PHY driver for udc usb: ehci: ehci-mv: use PHY driver for ehci usb: phy: phy-mv

[PATCh V10 03/12] usb: gadget: mv_udc: use PHY driver for udc

2013-05-12 Thread Chao Xie
of enabling device tree for udc driver. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/gadget/mv_udc.h |2 +- drivers/usb/gadget/mv_udc_core.c | 50 +- 2 files changed, 18 insertions(+), 34 deletions(-) diff --git a/drivers/usb/gadget

[PATCh V10 04/12] usb: ehci: ehci-mv: use PHY driver for ehci

2013-05-12 Thread Chao Xie
of enabling device tree for ehci driver. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/host/ehci-mv.c | 49 +++ 1 files changed, 17 insertions(+), 32 deletions(-) diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c index 6bad41a

[PATCh V10 08/12] arm: pxa910: change the defintion of usb devices

2013-05-12 Thread Chao Xie
because phy is seperated from the usb controller driver, we can use the common pxa_device_desc for device register. Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/include/mach/pxa910.h |4 arch/arm/mach-mmp/pxa910.c |4 2 files changed, 8

[PATCh V10 11/12] arm: brownstone: add usb support for the board

2013-05-12 Thread Chao Xie
for brownstone board, add the udc/otg/ehci support Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/brownstone.c | 56 1 files changed, 56 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mmp/brownstone.c b/arch/arm/mach-mmp

[PATCh V10 02/12] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

2013-05-12 Thread Chao Xie
driver will make the usb controller driver to be simple and portable. The PHY driver will be used by marvell udc/otg/ehci. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/phy/Kconfig |9 + drivers/usb/phy/Makefile |1 + drivers/usb/phy/phy-mv-usb2.c | 379

[V9 PATCH 00/12] mv-usb phy driver

2013-05-12 Thread Chao Xie
to replace udelay V10-V9 Grammar fix in comments. Chao Xie (12): usb: phy: protect phy init and shutdown for mutiple deivces usb: phy: mv_usb2: add PHY driver for marvell usb2 controller usb: gadget: mv_udc: use PHY driver for udc usb: ehci: ehci-mv: use PHY driver for ehci usb: phy: phy-mv

[PATCh V10 05/12] usb: phy: phy-mv-usb: use USB2 PHY driver for otg

2013-05-12 Thread Chao Xie
of enabling device tree for otg driver. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/phy/phy-mv-usb.c | 53 ++--- drivers/usb/phy/phy-mv-usb.h |2 +- 2 files changed, 24 insertions(+), 31 deletions(-) diff --git a/drivers/usb/phy/phy-mv-usb.c b

[PATCh V10 06/12] usb: mv_u3d: usb phy drivers for phy operation

2013-05-12 Thread Chao Xie
The phy_init and phy_deinit APIs are removed from the pdata. Directly get the phy driver and invoke the callbacks of phy drivers for phy initialization and shutdown. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/gadget/mv_u3d.h |3 +- drivers/usb/gadget/mv_u3d_core.c

[PATCh V10 07/12] arm: mmp2: change the defintion of usb devices

2013-05-12 Thread Chao Xie
add the udc/otg/ehci devices for mmp2 Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/include/mach/mmp2.h |4 arch/arm/mach-mmp/mmp2.c |4 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mmp/include/mach/mmp2.h b

[PATCh V10 10/12] arm: mmp: remove unused usb devices

2013-05-12 Thread Chao Xie
We defined new usb devices for usb ehci/udc/otg/phy. So remove the old definitions. Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/include/mach/pxa910.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-mmp/include/mach/pxa910.h b/arch

Re: [V9 PATCH 01/12] usb: phy: protect phy init and shutdown for mutiple deivces

2013-05-06 Thread Chao Xie
On Tue, Apr 30, 2013 at 2:24 AM, Felipe Balbi ba...@ti.com wrote: On Wed, Apr 24, 2013 at 02:23:15AM -0400, Chao Xie wrote: diff --git a/include/linux/usb/phy.h b/include/linux/usb/phy.h index 6b5978f..98d7e60 100644 --- a/include/linux/usb/phy.h +++ b/include/linux/usb/phy.h @@ -87,6 +87,14

[V9 PATCH 00/12] mv-usb phy driver

2013-04-24 Thread Chao Xie
to replace udelay Chao Xie (12): usb: phy: protect phy init and shutdown for mutiple deivces usb: phy: mv_usb2: add PHY driver for marvell usb2 controller usb: gadget: mv_udc: use PHY driver for udc usb: ehci: ehci-mv: use PHY driver for ehci usb: phy: phy-mv-usb: use USB2 PHY driver for otg

[V9 PATCH 02/12] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

2013-04-24 Thread Chao Xie
driver will make the usb controller driver to be simple and portable. The PHY driver will be used by marvell udc/otg/ehci. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/phy/Kconfig |9 + drivers/usb/phy/Makefile |1 + drivers/usb/phy/phy-mv-usb2.c | 379

[V9 PATCH 05/12] usb: phy: phy-mv-usb: use USB2 PHY driver for otg

2013-04-24 Thread Chao Xie
of enabling device tree for otg driver. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/phy/phy-mv-usb.c | 53 ++--- drivers/usb/phy/phy-mv-usb.h |2 +- 2 files changed, 24 insertions(+), 31 deletions(-) diff --git a/drivers/usb/phy/phy-mv-usb.c b

[V9 PATCH 04/12] usb: ehci: ehci-mv: use PHY driver for ehci

2013-04-24 Thread Chao Xie
of enabling device tree for ehci driver. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/host/ehci-mv.c | 49 +++ 1 files changed, 17 insertions(+), 32 deletions(-) diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c index

[V9 PATCH 06/12] usb: mv_u3d: usb phy drivers for phy operation

2013-04-24 Thread Chao Xie
The phy_init and phy_deinit APIs are removed from the pdata. Directly get the phy driver and invoke the callbacks of phy drivers for phy initialization and shutdown. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/gadget/mv_u3d.h |3 +- drivers/usb/gadget/mv_u3d_core.c

[V9 PATCH 09/12] arm: ttc_dkb: modify usb support

2013-04-24 Thread Chao Xie
for ttc_dkb board, we use phy driver for usb support. Modify the usb support for udc/otg/ehci support. Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/ttc_dkb.c | 39 ++- 1 files changed, 30 insertions(+), 9 deletions(-) diff --git a/arch

[V9 PATCH 08/12] arm: pxa910: change the defintion of usb devices

2013-04-24 Thread Chao Xie
because phy is seperated from the usb controller driver, we can use the common pxa_device_desc for device register. Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/include/mach/pxa910.h |4 arch/arm/mach-mmp/pxa910.c |4 2 files changed, 8

[V9 PATCH 11/12] arm: brownstone: add usb support for the board

2013-04-24 Thread Chao Xie
for brownstone board, add the udc/otg/ehci support Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/brownstone.c | 56 1 files changed, 56 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mmp/brownstone.c b/arch/arm/mach-mmp

[V9 PATCH 10/12] arm: mmp: remove unused usb devices

2013-04-24 Thread Chao Xie
We defined new usb devices for usb ehci/udc/otg/phy. So remove the old definitions. Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/include/mach/pxa910.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-mmp/include/mach/pxa910.h b/arch

[V9 PATCH 01/12] usb: phy: protect phy init and shutdown for mutiple deivces

2013-04-24 Thread Chao Xie
Some USB devices will share same phy, so make the -init and -shutdown to be protected. Only first device will initialize the phy, and only last device can shutdown phy. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/phy/phy.c |6 ++ include/linux/usb/phy.h | 22

[V9 PATCH 03/12] usb: gadget: mv_udc: use PHY driver for udc

2013-04-24 Thread Chao Xie
of enabling device tree for udc driver. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/gadget/mv_udc.h |2 +- drivers/usb/gadget/mv_udc_core.c | 50 +- 2 files changed, 18 insertions(+), 34 deletions(-) diff --git a/drivers/usb/gadget

[V9 PATCH 12/12] usb: mv_usb: remove the phy callbacks in pdata

2013-04-24 Thread Chao Xie
The phy initialization code will be done by phy driver. Signed-off-by: Chao Xie chao@marvell.com --- include/linux/platform_data/mv_usb.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/include/linux/platform_data/mv_usb.h b/include/linux/platform_data/mv_usb.h

[V9 PATCH 07/12] arm: mmp2: change the defintion of usb devices

2013-04-24 Thread Chao Xie
add the udc/otg/ehci devices for mmp2 Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/include/mach/mmp2.h |4 arch/arm/mach-mmp/mmp2.c |4 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mmp/include/mach/mmp2.h b

Re: [V9 PATCH 00/12] mv-usb phy driver

2013-04-16 Thread Chao Xie
On Wed, Apr 17, 2013 at 9:17 AM, Chao Xie xiechao.m...@gmail.com wrote: On Sun, Apr 7, 2013 at 6:29 PM, Chao Xie chao@marvell.com wrote: The patches create the mv-usb phy driver directly use devm_usb_get_phy_dev return value for error return. v9-v8 Remove u2o_xxx. Add prefix

[V9 PATCH 05/12] usb: phy: phy-mv-usb: use USB2 PHY driver for otg

2013-04-07 Thread Chao Xie
of enabling device tree for otg driver. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/phy/phy-mv-usb.c | 53 ++--- drivers/usb/phy/phy-mv-usb.h |2 +- 2 files changed, 24 insertions(+), 31 deletions(-) diff --git a/drivers/usb/phy/phy-mv-usb.c b

[V9 PATCH 09/12] arm: ttc_dkb: modify usb support

2013-04-07 Thread Chao Xie
for ttc_dkb board, we use phy driver for usb support. Modify the usb support for udc/otg/ehci support. Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/ttc_dkb.c | 39 ++- 1 files changed, 30 insertions(+), 9 deletions(-) diff --git a/arch

[V9 PATCH 03/12] usb: gadget: mv_udc: use PHY driver for udc

2013-04-07 Thread Chao Xie
of enabling device tree for udc driver. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/gadget/mv_udc.h |2 +- drivers/usb/gadget/mv_udc_core.c | 50 +- 2 files changed, 18 insertions(+), 34 deletions(-) diff --git a/drivers/usb/gadget

[V9 PATCH 06/12] usb: mv_u3d: usb phy drivers for phy operation

2013-04-07 Thread Chao Xie
The phy_init and phy_deinit APIs are removed from the pdata. Directly get the phy driver and invoke the callbacks of phy drivers for phy initialization and shutdown. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/gadget/mv_u3d.h |3 +- drivers/usb/gadget/mv_u3d_core.c

[V9 PATCH 12/12] usb: mv_usb: remove the phy callbacks in pdata

2013-04-07 Thread Chao Xie
The phy initialization code will be done by phy driver. Signed-off-by: Chao Xie chao@marvell.com --- include/linux/platform_data/mv_usb.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/include/linux/platform_data/mv_usb.h b/include/linux/platform_data/mv_usb.h

[V9 PATCH 10/12] arm: mmp: remove unused usb devices

2013-04-07 Thread Chao Xie
We defined new usb devices for usb ehci/udc/otg/phy. So remove the old definitions. Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/include/mach/pxa910.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-mmp/include/mach/pxa910.h b/arch

[V9 PATCH 11/12] arm: brownstone: add usb support for the board

2013-04-07 Thread Chao Xie
for brownstone board, add the udc/otg/ehci support Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/brownstone.c | 56 1 files changed, 56 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mmp/brownstone.c b/arch/arm/mach-mmp

[V9 PATCH 01/12] usb: phy: protect phy init and shutdown for mutiple deivces

2013-04-07 Thread Chao Xie
Some USB devices will share same phy, so make the -init and -shutdown to be protected. Only first device will initialize the phy, and only last device can shutdown phy. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/phy/phy.c |6 ++ include/linux/usb/phy.h | 22

[V9 PATCH 08/12] arm: pxa910: change the defintion of usb devices

2013-04-07 Thread Chao Xie
because phy is seperated from the usb controller driver, we can use the common pxa_device_desc for device register. Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/include/mach/pxa910.h |4 arch/arm/mach-mmp/pxa910.c |4 2 files changed, 8

[V9 PATCH 04/12] usb: ehci: ehci-mv: use PHY driver for ehci

2013-04-07 Thread Chao Xie
of enabling device tree for ehci driver. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/host/ehci-mv.c | 49 +++ 1 files changed, 17 insertions(+), 32 deletions(-) diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c index

[V9 PATCH 02/12] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

2013-04-07 Thread Chao Xie
driver will make the usb controller driver to be simple and portable. The PHY driver will be used by marvell udc/otg/ehci. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/phy/Kconfig |9 + drivers/usb/phy/Makefile |1 + drivers/usb/phy/phy-mv-usb2.c | 379

Re: [PATCH V2 0/6] remove the clock name from pdata

2013-03-27 Thread Chao Xie
On Wed, Mar 27, 2013 at 9:14 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Mar 25, 2013 at 03:06:51AM -0400, Chao Xie wrote: The clock is defined by device, so the driver knows how many clocks needed by the device. The orignal way that passing the clock name by pdata is not correct

Re: [PATCH V2 3/6] usb: ehci: mv_ehci: remove unused clock

2013-03-27 Thread Chao Xie
hi, Alan This is the patch for EHCI clock fix. Can you help to review and ack it? Thanks. On Mon, Mar 25, 2013 at 3:06 PM, Chao Xie chao@marvell.com wrote: The origianl understanding of clock is wrong. The EHCI controller only have one clock input. Passing clock name by pdata is wrong

Re: [PATCH V2 4/6] arm: mmp: remove clock from usb pdata for aspenite

2013-03-27 Thread Chao Xie
hi, Haojian The patches correct the wrong usage of clock. It finally do not need pass clock by pdata. Can you help to review the patches relates to arch-mmp, and ack it?Thanks. On Mon, Mar 25, 2013 at 3:06 PM, Chao Xie chao@marvell.com wrote: The clock name will directly get by driver

[PATCH V2 6/6] usb: mv_usb: remove clock name from pdata

2013-03-25 Thread Chao Xie
Using pdata to pass clock name is not correct. Directly get clock from usb drivers. Signed-off-by: Chao Xie chao@marvell.com --- include/linux/platform_data/mv_usb.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/include/linux/platform_data/mv_usb.h b/include

[PATCH V2 3/6] usb: ehci: mv_ehci: remove unused clock

2013-03-25 Thread Chao Xie
The origianl understanding of clock is wrong. The EHCI controller only have one clock input. Passing clock name by pdata is wrong. The clock is defined by device iteself. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/host/ehci-mv.c | 35 ++- 1

[PATCH V2 4/6] arm: mmp: remove clock from usb pdata for aspenite

2013-03-25 Thread Chao Xie
The clock name will directly get by driver. Removing the name from pdata. Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/aspenite.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-mmp/aspenite.c b/arch/arm/mach-mmp/aspenite.c index

[PATCH V2 0/6] remove the clock name from pdata

2013-03-25 Thread Chao Xie
The clock is defined by device, so the driver knows how many clocks needed by the device. The orignal way that passing the clock name by pdata is not correct. The following patches fix it. V2-V1: typo fix rebased on latest usb-next Chao Xie (6): usb: gadget: mv_udc_core: remove unused

[PATCH V2 5/6] arm: mmp: remove clock name from usb pdata for ttc

2013-03-25 Thread Chao Xie
The clock name will directly get by driver. Removing the name from pdata. Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/ttc_dkb.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-mmp/ttc_dkb.c b/arch/arm/mach-mmp/ttc_dkb.c index

Re: [PATCH 2/6] usb: otg: mv_otg: remove unused clock

2013-03-21 Thread Chao Xie
On Wed, Mar 20, 2013 at 9:09 PM, Felipe Balbi ba...@ti.com wrote: On Mon, Mar 18, 2013 at 03:55:29AM -0400, Chao Xie wrote: The origianl understanding of clock is wrong. The OTG controller only have one clock input. Passing clock name by pdata is wrong. The clock is defined by device iteself

[PATCH 1/6] usb: gadget: mv_udc_core: remove unused clock

2013-03-18 Thread Chao Xie
The origianl understanding of clock is wrong. The UDC controller only have one clock input. Passing clock name by pdata is wrong. The clock is defined by device iteself. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/gadget/mv_udc.h |3 +-- drivers/usb/gadget/mv_udc_core.c

[PATCH 2/6] usb: otg: mv_otg: remove unused clock

2013-03-18 Thread Chao Xie
The origianl understanding of clock is wrong. The OTG controller only have one clock input. Passing clock name by pdata is wrong. The clock is defined by device iteself. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/otg/mv_otg.c | 28 +++- drivers/usb/otg

[PATCH 3/6] usb: ehci: mv_ehci: remove unused clock

2013-03-18 Thread Chao Xie
The origianl understanding of clock is wrong. The EHCI controller only have one clock input. Passing clock name by pdata is wrong. The clock is defined by device iteself. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/host/ehci-mv.c | 35 ++- 1

[PATCH 6/6] usb: mv_usb: remove clock name from pdata

2013-03-18 Thread Chao Xie
Using pdata to pass clock name is not correct. Directly get clock from usb drivers. Signed-off-by: Chao Xie chao@marvell.com --- include/linux/platform_data/mv_usb.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/include/linux/platform_data/mv_usb.h b/include

[PATCH 0/6] remove the clock name from pdata

2013-03-18 Thread Chao Xie
The clock is defined by device, so the driver knows how many clocks needed by the device. The orignal way that passing the clock name by pdata is not correct. The following patches fix it. Chao Xie (6): usb: gadget: mv_udc_core: remove unused clock usb: otg: mv_otg: remove unused clock usb

[PATCH 4/6] arm: mmp: remove clock from usb pdata for aspenite

2013-03-18 Thread Chao Xie
The clock name will directly get by driver. Removing the name from pdata. Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/aspenite.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-mmp/aspenite.c b/arch/arm/mach-mmp/aspenite.c index

[PATCH 5/6] arm: mmp: remove clock name from usb pdata for ttc

2013-03-18 Thread Chao Xie
The clock name will directly get by driver. Removing the name from pdata. Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/ttc_dkb.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-mmp/ttc_dkb.c b/arch/arm/mach-mmp/ttc_dkb.c index

Re: [V8 PATCH 01/16] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

2013-03-06 Thread Chao Xie
On Wed, Mar 6, 2013 at 4:53 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Mar 06, 2013 at 04:24:58PM +0800, Chao Xie wrote: On Wed, Mar 6, 2013 at 4:10 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Wed, Mar 06, 2013 at 10:11:41AM +0800, Chao Xie wrote: 3. For the revison register. It exists

Re: [V8 PATCH 01/16] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

2013-03-06 Thread Chao Xie
On Thu, Mar 7, 2013 at 12:48 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Mar 06, 2013 at 04:24:58PM +0800, Chao Xie wrote: The clock numbers and names are depent of SOCes, No they aren't. The clock names used to describe them in your documentation may vary

Re: [V8 PATCH 01/16] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

2013-03-05 Thread Chao Xie
On Tue, Mar 5, 2013 at 7:04 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Mar 05, 2013 at 10:03:01AM +0800, Chao Xie wrote: +enum mv_usb2_phy_type { + PXA168_USB, + PXA910_USB, + MMP2_USB, +}; ewww... you really don't need (and *shouldn't* use) u2o_set

Re: [V8 PATCH 01/16] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

2013-03-04 Thread Chao Xie
On Mon, Mar 4, 2013 at 10:21 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Feb 20, 2013 at 11:07:11PM -0500, Chao Xie wrote: The PHY is seperated from usb controller. The usb controller used in marvell pxa168/pxa910/mmp2 are same, but PHY initialization may be different. the usb controller can

Re: [V8 PATCH 02/16] usb: gadget: mv_udc: use PHY driver for udc

2013-03-04 Thread Chao Xie
On Mon, Mar 4, 2013 at 10:24 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Feb 20, 2013 at 11:07:12PM -0500, Chao Xie wrote: Originaly, udc driver will call the callbacks in platform data for PHY initialization and shut down. With PHY driver, it will call the APIs provided by PHY driver

[V8 PATCH 03/16] usb: ehci: ehci-mv: use PHY driver for ehci

2013-02-20 Thread Chao Xie
of enabling device tree for ehci driver. Signed-off-by: Chao Xie chao@marvell.com Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ehci-mv.c | 48 ++- 1 files changed, 16 insertions(+), 32 deletions(-) diff --git a/drivers/usb/host/ehci

[V8 PATCH 01/16] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

2013-02-20 Thread Chao Xie
driver will make the usb controller driver to be simple and portable. The PHY driver will be used by marvell udc/otg/ehci. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/phy/Kconfig |7 + drivers/usb/phy/Makefile |1 + drivers/usb/phy/mv_usb2_phy.c

[V8 PATCH 04/16] usb: otg: mv_otg: use PHY driver for otg

2013-02-20 Thread Chao Xie
of enabling device tree for otg driver. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/otg/mv_otg.c | 50 ++--- drivers/usb/otg/mv_otg.h |2 +- 2 files changed, 21 insertions(+), 31 deletions(-) diff --git a/drivers/usb/otg/mv_otg.c b/drivers

[V8 PATCH 00/16] mv-usb phy enhancement patches

2013-02-20 Thread Chao Xie
return value for error return. Chao Xie (16): usb: phy: mv_usb2: add PHY driver for marvell usb2 controller usb: gadget: mv_udc: use PHY driver for udc usb: ehci: ehci-mv: use PHY driver for ehci usb: otg: mv_otg: use PHY driver for otg arm: mmp2: change the defintion of usb devices arm

[V8 PATCH 06/16] arm: pxa910: change the defintion of usb devices

2013-02-20 Thread Chao Xie
because phy is seperated from the usb controller driver, we can use the common pxa_device_desc for device register. Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/include/mach/pxa910.h |7 --- arch/arm/mach-mmp/pxa910.c |4 2 files changed, 8

[V8 PATCH 05/16] arm: mmp2: change the defintion of usb devices

2013-02-20 Thread Chao Xie
add the udc/otg/ehci devices for mmp2 Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/include/mach/mmp2.h |4 arch/arm/mach-mmp/mmp2.c |4 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mmp/include/mach/mmp2.h b

[V8 PATCH 08/16] arm: ttc_dkb: add usb support

2013-02-20 Thread Chao Xie
for ttc_dkb board, add udc/otg/ehci support Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/ttc_dkb.c | 50 +- 1 files changed, 39 insertions(+), 11 deletions(-) diff --git a/arch/arm/mach-mmp/ttc_dkb.c b/arch/arm/mach-mmp/ttc_dkb.c

[V8 PATCH 09/16] arm: mmp: remove the usb phy setting

2013-02-20 Thread Chao Xie
phy setting are formatted into a phy driver at drivers/usb/phy, we do not need do the setting in SOC files. Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/devices.c | 278 - arch/arm/mach-mmp/include/mach/regs-usb.h | 253

[V8 PATCH 11/16] usb: phy: mv_usb2_phy: add externel chip support

2013-02-20 Thread Chao Xie
the external chip to detect vbus/idpin can save the power. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/phy/mv_usb2_phy.c| 49 +++ include/linux/platform_data/mv_usb.h | 15 ++ include/linux/usb/mv_usb2.h | 89

[V8 PATCH 10/16] arm: mmp: remove usb devices from pxa168

2013-02-20 Thread Chao Xie
Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/pxa168.c | 42 -- 1 files changed, 0 insertions(+), 42 deletions(-) diff --git a/arch/arm/mach-mmp/pxa168.c b/arch/arm/mach-mmp/pxa168.c index b7f074f..dd3a68b 100644 --- a/arch/arm/mach

[V8 PATCH 07/16] arm: brownstone: add usb support for the board

2013-02-20 Thread Chao Xie
for brownstone board, add the udc/otg/ehci support Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/brownstone.c | 68 1 files changed, 68 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mmp/brownstone.c b/arch/arm/mach-mmp

[V8 PATCH 12/16] usb: gadget: mv_udc: add extern chip support

2013-02-20 Thread Chao Xie
. The PMIC usb drivers will help to register the callbacks in the marvell usb PHY driver. udc/otg/ehci driver will call the callbacks. Then we do not need pass the information in platform data. It will remove another block in the way of enabling device tree for usb. Signed-off-by: Chao Xie chao

[V8 PATCH 14/16] usb: otg: mv_otg: add extern chip support

2013-02-20 Thread Chao Xie
It does the similar things as what we do for udc driver. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/otg/mv_otg.c | 72 +++-- drivers/usb/otg/mv_otg.h |3 ++ 2 files changed, 40 insertions(+), 35 deletions(-) diff --git a/drivers/usb

[V8 PATCH 15/16] arm: mmp: add extern chip support for brownstone

2013-02-20 Thread Chao Xie
Change the board support for usb as extern chip is supported in marvell usb PHY driver Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/brownstone.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-mmp/brownstone.c b/arch/arm/mach-mmp

[V8 PATCH 13/16] usb: ehci: ehci-mv: add extern chip support

2013-02-20 Thread Chao Xie
It does the similar things as what we do for udc driver. Signed-off-by: Chao Xie chao@marvell.com Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ehci-mv.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/ehci-mv.c

[V8 PATCH 16/16] arm: mmp: add extern chip support for ttc_dkb

2013-02-20 Thread Chao Xie
Change the board support for usb as extern chip is supported in marvell usb PHY driver. Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/ttc_dkb.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-mmp/ttc_dkb.c b/arch/arm/mach-mmp/ttc_dkb.c

Re: [V6 PATCH 01/16] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

2013-02-17 Thread Chao Xie
On Thu, Feb 7, 2013 at 1:57 PM, kishon kis...@ti.com wrote: Hi, On Thursday 07 February 2013 07:56 AM, Chao Xie wrote: On Wed, Feb 6, 2013 at 6:35 PM, kishon kis...@ti.com wrote: Hi, On Wednesday 06 February 2013 01:48 PM, Chao Xie wrote: On Wed, Feb 6, 2013 at 4:10 PM, kishon kis

[V7 PATCH 00/16] mv-usb phy enhancement patches

2013-02-17 Thread Chao Xie
this patch series, and they will be submitted in another series. v7-v6 Use usb_add_phy_dev and related APIs to add PHY drivers. Removed the device tree support in PHY driver. It will be added in another patch series. Chao Xie (16): usb: phy: mv_usb2: add PHY driver for marvell usb2

[V7 PATCH 02/16] usb: gadget: mv_udc: use PHY driver for udc

2013-02-17 Thread Chao Xie
of enabling device tree for udc driver. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/gadget/mv_udc.h |2 +- drivers/usb/gadget/mv_udc_core.c | 37 +++-- 2 files changed, 16 insertions(+), 23 deletions(-) diff --git a/drivers/usb/gadget

[V7 PATCH 01/16] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

2013-02-17 Thread Chao Xie
driver will make the usb controller driver to be simple and portable. The PHY driver will be used by marvell udc/otg/ehci. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/phy/Kconfig |7 + drivers/usb/phy/Makefile |1 + drivers/usb/phy/mv_usb2_phy.c

[V7 PATCH 05/16] arm: mmp2: change the defintion of usb devices

2013-02-17 Thread Chao Xie
add the udc/otg/ehci devices for mmp2 Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/include/mach/mmp2.h |4 arch/arm/mach-mmp/mmp2.c |4 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mmp/include/mach/mmp2.h b

[V7 PATCH 03/16] usb: ehci: ehci-mv: use PHY driver for ehci

2013-02-17 Thread Chao Xie
of enabling device tree for ehci driver. Signed-off-by: Chao Xie chao@marvell.com Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ehci-mv.c | 46 ++- 1 files changed, 15 insertions(+), 31 deletions(-) diff --git a/drivers/usb/host/ehci

[V7 PATCH 06/16] arm: pxa910: change the defintion of usb devices

2013-02-17 Thread Chao Xie
because phy is seperated from the usb controller driver, we can use the common pxa_device_desc for device register. Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/include/mach/pxa910.h |7 --- arch/arm/mach-mmp/pxa910.c |4 2 files changed, 8

[V7 PATCH 04/16] usb: otg: mv_otg: use PHY driver for otg

2013-02-17 Thread Chao Xie
of enabling device tree for otg driver. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/otg/mv_otg.c | 51 ++ drivers/usb/otg/mv_otg.h |2 +- 2 files changed, 21 insertions(+), 32 deletions(-) diff --git a/drivers/usb/otg/mv_otg.c b

[V7 PATCH 07/16] arm: brownstone: add usb support for the board

2013-02-17 Thread Chao Xie
for brownstone board, add the udc/otg/ehci support Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/brownstone.c | 68 1 files changed, 68 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mmp/brownstone.c b/arch/arm/mach-mmp

[V7 PATCH 10/16] arm: mmp: remove usb devices from pxa168

2013-02-17 Thread Chao Xie
Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/pxa168.c | 42 -- 1 files changed, 0 insertions(+), 42 deletions(-) diff --git a/arch/arm/mach-mmp/pxa168.c b/arch/arm/mach-mmp/pxa168.c index b7f074f..dd3a68b 100644 --- a/arch/arm/mach

[V7 PATCH 11/16] usb: phy: mv_usb2_phy: add externel chip support

2013-02-17 Thread Chao Xie
the external chip to detect vbus/idpin can save the power. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/phy/mv_usb2_phy.c| 49 include/linux/platform_data/mv_usb.h | 15 ++ include/linux/usb/mv_usb2.h | 81

[V7 PATCH 13/16] usb: ehci: ehci-mv: add extern chip support

2013-02-17 Thread Chao Xie
It does the similar things as what we do for udc driver. Signed-off-by: Chao Xie chao@marvell.com Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ehci-mv.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/ehci-mv.c

[V7 PATCH 15/16] arm: mmp: add extern chip support for brownstone

2013-02-17 Thread Chao Xie
Change the board support for usb as extern chip is supported in marvell usb PHY driver Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/brownstone.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-mmp/brownstone.c b/arch/arm/mach-mmp

[V7 PATCH 16/16] arm: mmp: add extern chip support for ttc_dkb

2013-02-17 Thread Chao Xie
Change the board support for usb as extern chip is supported in marvell usb PHY driver. Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/ttc_dkb.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-mmp/ttc_dkb.c b/arch/arm/mach-mmp/ttc_dkb.c

  1   2   3   >