Hi Johan
> I'll just fix this up this time and submit it to Greg.
thanks! I promise to up my game in git usage for the next patch ;).
-Colin
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http:
Signed-off-by: Colin Leitner
--
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index fb0d537..8c204a5 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@ -2124,10 +2124,20 @@ static void ftdi_set_termios(struct tty_struct *tty
Hello everyone,
I received a bug report, that at least one type of smartcard reader fails to
work with the bugfix to the ftdi_sio driver of commit
caf2e52920cddef72922cbe7c2140e5d3a690bc6 .
It's likely that the device doesn't use a genuine FTDI chip, but implements the
protocol instead and abu
patch reenables this behaviour for all FTDI devices.
Tagged to be added to stable, because it affects a lot of users of
embedded systems which rely on these readers to work properly.
Cc: sta...@vger.kernel.org
Tested-by: Heinrich Siebmanns
Signed-off-by: Colin Leitner
---
drivers/usb/serial
This patch removes an erroneous check of CSIZE, which made it impossible to set
CS5.
Compiles clean, but couldn't test against hardware.
Signed-off-by: Colin Leitner
---
drivers/usb/serial/spcp8x5.c | 30 ++
1 file changed, 14 insertions(+), 16 deletions(-)
This patch removes an erroneous check of CSIZE, which made it impossible to set
CS5.
Compiles clean, but couldn't test against hardware.
Signed-off-by: Colin Leitner
---
drivers/usb/serial/mos7840.c | 32
1 file changed, 16 insertions(+), 16 dele
This patch removes an erroneous check of CSIZE, making it impossible to set
CS5.
Compiles clean, but couldn't test against hardware.
Signed-off-by: Colin Leitner
---
drivers/usb/serial/mos7840.c | 32
drivers/usb/serial/spcp8x5.c |
> Great, all looks good now. Thanks for fixing this. Did you check if
> there are even more (USB) serial drivers with similar problems (i.e.
> testing C_CSIZE(tty) in set_termios)?
I just casually scanned through and, at least CSIZE, seems to be
handled pretty well by the ones with lots of IDs. I'
the patch it's sufficient to call
stty -F /dev/ttyUSB0 cs5
which will succeed without the patch and report an error with the patch
applied.
As an additional fix this patch ensures that the control request will always
include a data bit size.
Signed-off-by: Colin Leitner
---
driver
the patch it's sufficient to call
stty -F /dev/ttyUSB0 cs5
which will succeed without the patch and report an error with the patch
applied.
As an additional fix this patch ensures that the control request will always
include a data bit size, even in error cases.
Signed-off-by: Colin Le
> Comment style should be
>
> /*
>* ...
>*/
I tried sticking to the style of the rest of the code but I'll keep that
in mind from now on. Wouldn't that be something checkpatch.pl could check?
> But I'm not sure you need to be that verbose in this case. You can
> probably ju
the patch it's sufficient to call
stty -F /dev/ttyUSB0 cs5
which will succeed without the patch and report an error with the patch
applied.
Signed-off-by: Colin Leitner
---
drivers/usb/serial/ftdi_sio.c | 41 -
1 file changed, 28 insertions(+
a user visible driver bug and is
simple enough to backport easily.
Cc: sta...@vger.kernel.org
Signed-off-by: Colin Leitner
---
drivers/usb/serial/pl2303.c | 30 ++
1 file changed, 14 insertions(+), 16 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers
a user visible driver bug and is
simple enough to backport easily.
Cc: sta...@vger.kernel.org
Signed-off-by: Colin Leitner
---
drivers/usb/serial/pl2303.c | 30 ++
1 file changed, 14 insertions(+), 16 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers
Unfortunately, the patch is white-space damaged. You should use tabs for
indentation. Please run your patches through checkpatch.pl before
submitting (or fix your mail client if that's where the problem is).
Clearly an end user error. checkpatch.pl didn't complain.
I'll repost the patch with
15 matches
Mail list logo
