Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-11 Thread Dave Chinner
On Mon, Dec 11, 2017 at 02:12:28PM -0800, Joe Perches wrote: > On Tue, 2017-12-12 at 08:43 +1100, Dave Chinner wrote: > > On Sat, Dec 09, 2017 at 09:00:18AM -0800, Joe Perches wrote: > > > On Sat, 2017-12-09 at 09:36 +1100, Dave Chinner wrote: > > > > 1. Usin

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-11 Thread Dave Chinner
On Sun, Dec 10, 2017 at 08:23:15PM -0800, Matthew Wilcox wrote: > On Mon, Dec 11, 2017 at 10:57:45AM +1100, Dave Chinner wrote: > > i.e. the fact the cmpxchg failed may not have anything to do with a > > race condtion - it failed because the slot wasn't empty like we > >

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-11 Thread Dave Chinner
On Sat, Dec 09, 2017 at 09:00:18AM -0800, Joe Perches wrote: > On Sat, 2017-12-09 at 09:36 +1100, Dave Chinner wrote: > > 1. Using lockdep_set_novalidate_class() for anything other > > than device->mutex will throw checkpatch warnings. Nice. (*) > [] > > (*)

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-10 Thread Dave Chinner
On Fri, Dec 08, 2017 at 03:01:31PM -0800, Matthew Wilcox wrote: > On Thu, Dec 07, 2017 at 11:38:43AM +1100, Dave Chinner wrote: > > > > cmpxchg is for replacing a known object in a store - it's not really > > > > intended for doing initial inserts after a lookup t

Re: Lockdep is less useful than it was

2017-12-08 Thread Dave Chinner
use the RCU checking because it knows that every reference is protected > by either the spinlock or the RCU lock. > > Dave was saying that he has a tree which has to be protected by a mutex > because of where it is in the locking hierarchy, and I was vigorously > declining his propo

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-08 Thread Dave Chinner
d to do the same thing with its semaphores. Who-ever adds semaphore checking to lockdep can add those annotations. The externalisation of the development cost of new lockdep functionality is one of the problems here. -Dave. (*) checkpatch.pl is considered mostly harmful round here, too, but that&#

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-07 Thread Dave Chinner
On Fri, Dec 08, 2017 at 01:45:52PM +0900, Byungchul Park wrote: > On Fri, Dec 08, 2017 at 09:22:16AM +1100, Dave Chinner wrote: > > On Thu, Dec 07, 2017 at 11:06:34AM -0500, Theodore Ts'o wrote: > > > On Wed, Dec 06, 2017 at 06:06:48AM -0800, Matthew Wilcox wrote: > >

Re: Lockdep is less useful than it was

2017-12-07 Thread Dave Chinner
> If you didn't > have to hack Kconfig to get rid of this problem, you'd be happier, right? I'd be much happier if it wasn't turned on by default in the first place. We gave plenty of warnings that there were still unsolved false positive problems with the new checks in

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-07 Thread Dave Chinner
; just stop using Lockdep as being too annyoing and a waste of developer > time when trying to figure what is a legitimate locking bug versus > lockdep getting confused. > > I can't even disable the new Lockdep feature which is throwing > lots of new false positives --- it'

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-06 Thread Dave Chinner
On Wed, Dec 06, 2017 at 06:06:48AM -0800, Matthew Wilcox wrote: > On Wed, Dec 06, 2017 at 07:44:04PM +1100, Dave Chinner wrote: > > On Tue, Dec 05, 2017 at 08:45:49PM -0800, Matthew Wilcox wrote: > > > That said, using xa_cmpxchg() in the dquot code looked like the right > &g

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-06 Thread Dave Chinner
On Tue, Dec 05, 2017 at 08:45:49PM -0800, Matthew Wilcox wrote: > On Wed, Dec 06, 2017 at 02:14:56PM +1100, Dave Chinner wrote: > > > The other conversions use the normal API instead of the advanced API, so > > > all of this gets hidden away. For example, the inode cache d

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-05 Thread Dave Chinner
On Tue, Dec 05, 2017 at 06:02:08PM -0800, Matthew Wilcox wrote: > On Wed, Dec 06, 2017 at 12:36:48PM +1100, Dave Chinner wrote: > > > - if (radix_tree_preload(GFP_NOFS)) > > > - return -ENOMEM; > > > - > > > INIT_LIST_HEAD(&am

Re: [PATCH v4 00/73] XArray version 4

2017-12-05 Thread Dave Chinner
On Tue, Dec 05, 2017 at 06:05:15PM -0800, Matthew Wilcox wrote: > On Wed, Dec 06, 2017 at 12:45:49PM +1100, Dave Chinner wrote: > > On Tue, Dec 05, 2017 at 04:40:46PM -0800, Matthew Wilcox wrote: > > > From: Matthew Wilcox > > > > > > I looked through some not

Re: [PATCH v4 00/73] XArray version 4

2017-12-05 Thread Dave Chinner
device. But that is "default y", so should be turned on. But it's not? And there's no obvious HMM menu config option, either What a godawful mess Kconfig has turned into. I'm just going to enable TRANSPARENT_HUGEPAGE - madness awaits me if I follow the oth

Re: [PATCH v4 00/73] XArray version 4

2017-12-05 Thread Dave Chinner
On Wed, Dec 06, 2017 at 12:45:49PM +1100, Dave Chinner wrote: > On Tue, Dec 05, 2017 at 04:40:46PM -0800, Matthew Wilcox wrote: > > From: Matthew Wilcox > > > > I looked through some notes and decided this was version 4 of the XArray. > > Last posted two weeks ago, t

Re: [PATCH v4 00/73] XArray version 4

2017-12-05 Thread Dave Chinner
On Tue, Dec 05, 2017 at 04:40:46PM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > I looked through some notes and decided this was version 4 of the XArray. > Last posted two weeks ago, this version includes a *lot* of changes. > I'd like to thank Dave Chin

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-05 Thread Dave Chinner
nd operations in the MRU structure, not just the radix tree operations. Turning that around so that a larger XFS structure and algorithm is now protected by an opaque internal lock from generic storage structure the forms part of the larger structure seems like a bad design pattern to me... Cheers, Dav

[PATCH v2] HID: add quirk for another PIXART OEM mouse used by HP

2017-12-01 Thread Dave Young
Mouse as /devices/pci:00/:00:14.0/usb2/2-2/2-2:1.0/0003:03F0:094A.0003/input/input15 [ 175.084946] hid-generic 0003:03F0:094A.0003: input: USB HID v1.11 Mouse [PixArt HP USB Optical Mouse] on usb-:00:14.0-2/input0 Signed-off-by: Dave Young Cc: sta...@vger.kernel.org --- v1->v2: reb

Re: [PATCH] usbhid: add quirk for another PIXART OEM mouse used by HP

2017-11-27 Thread Dave Young
On 11/27/17 at 09:49am, Benjamin Tissoires wrote: > On Nov 27 2017 or thereabouts, Greg KH wrote: > > On Mon, Nov 27, 2017 at 09:16:31AM +0100, Benjamin Tissoires wrote: > > > On Nov 25 2017 or thereabouts, Dave Young wrote: > > > > This mouse keep disconnecting i

[PATCH] usbhid: add quirk for another PIXART OEM mouse used by HP

2017-11-24 Thread Dave Young
Mouse as /devices/pci:00/:00:14.0/usb2/2-2/2-2:1.0/0003:03F0:094A.0003/input/input15 [ 175.084946] hid-generic 0003:03F0:094A.0003: input: USB HID v1.11 Mouse [PixArt HP USB Optical Mouse] on usb-:00:14.0-2/input0 Signed-off-by: Dave Young --- drivers/hid/hid-ids.h |1

Re: [PATCH] usb-core: Add MS_INTR_BINTERVAL USB quirk

2017-03-13 Thread Dave Mielke
usage note, they do observe that, so far, they've been unable to achieve a transfer speed faster than 5,000 characters in seven minutes. It looks to me like this is exactly due to their incorrect setting of bInterval. :-) I've sent them a note about it. -- Dave Mielke | 22

Re: [PATCH] usb-core: Add MS_INTR_BINTERVAL USB quirk

2017-03-13 Thread Dave Mielke
SB 2.0, bInterval must still be interpreted the old way if the device is operating at full or low speed. Is that correct? If the above is correct, how can we tell from usbfs which way to interpret bInterval? -- Dave Mielke | 2213 Fox Crescent | The Bible is the very Word of God. Phone: 1

Re: [PATCH] usb-core: Add MS_INTR_BINTERVAL USB quirk

2017-03-12 Thread Dave Mielke
h, or Super speed. Yes, I did know this, so maybe I misunderstood what you were wondering about. Were you wondering why 64ms was too long? -- Dave Mielke | 2213 Fox Crescent | The Bible is the very Word of God. Phone: 1-613-726-0014 | Ottawa, Ontario | http://Mielke.cc/bible/ EMai

Re: [PATCH] usb-core: Add MS_INTR_BINTERVAL USB quirk

2017-03-12 Thread Dave Mielke
t descriptor. Our assumption was that since it says it's USB 2.0 then bInterval must be intterpreted in light of that regardless of the actual speed used for communication. -- Dave Mielke | 2213 Fox Crescent | The Bible is the very Word of God. Phone: 1-613-726-0014 | Ottawa, Ontario |

Re: [PATCH] usb-core: Add MS_INTR_BINTERVAL USB quirk

2017-03-12 Thread Dave Mielke
heard of) run at low speed, and a few of them run at >full speed. I can't remember any running at high speed. According to my collection of data, 5 say 1.00, 15 say 1.1, and 21 say 2.0. -- Dave Mielke | 2213 Fox Crescent | The Bible is the very Word of God. Phone: 1-613-7

[PATCH] usbtmc: Add, clarify and fix comments

2016-09-28 Thread Dave Penkler
Add information regarding lifespan of kref protection: Clarify comment on kref_get for interrupt in urb in usbtmc_probe() Add comment on kref_get in usbtmc_open() Fix endpoint reference in documentation for send_request_dev_dep_msg_in() Signed-off-by: Dave Penkler --- drivers/usb/class

Re: usbtmc: vendor specific i/o

2016-09-28 Thread Dave Penkler
housekeeping. Only one interrupt urb needs to be submitted no matter how many concurrent opens there are for the minor. I will submit a patch to revert the "convert to devm_kzalloc" patch and make the comment more explicit. cheers, -dave -- To unsubscribe from this list: send th

Re: VL805 USB 3.0 does not see connected devices (only on x86_64) (x86 is ok)

2016-09-12 Thread Dave Jiang
On 09/12/2016 03:56 AM, Mathias Nyman wrote: > On 10.09.2016 17:19, Greg KH wrote: >> On Sat, Sep 10, 2016 at 04:33:05PM +0300, c400 wrote: >>> my DMESG file >> >>> [ 13.331618] usb 3-1: device descriptor read/64, error -110 >>> [ 28.535180] usb 3-1: device descriptor read/64, error -110 >>> [

Re: clear halt

2016-06-05 Thread Dave Mielke
host what state to >> reset >> its end to? > >Nope, sorry, see the USB spec for details :( Thanks. I was just hoping that I'd missed something. -- Dave Mielke | 2213 Fox Crescent | The Bible is the very Word of God. Phone: 1-613-726-0014 | Ottawa, Ontario | htt

clear halt

2016-06-05 Thread Dave Mielke
Using USBFS: If a device doesn't support clear halt (or, perhaps, not properly), is there an alternative? For example, is there a way to ask which state the device's data toggle is in and then tell the host what state to reset its end to? -- Dave Mielke | 2213 Fox Cres

ttyACM device issue.

2016-05-30 Thread Dave Mielke
set both VTIME and VMIN to 0. This should do non-blocking reads that return 0 (something our code always successfully does with ttyS devices) but, with the ttyACM device, the read blocks. Is this expected behaviour for ttyACM devices? -- Dave Mielke | 2213 Fox Crescent | The Bible i

Re: question on trust in chaoskey

2016-05-19 Thread Dave Tian
> On May 19, 2016, at 10:59 PM, Dave Tian wrote: > > > >> On May 19, 2016, at 8:06 PM, Keith Packard wrote: >> >> Oliver Neukum writes: >> >>> I think we would need to use a form of public key cryptography >>> in the same manner u

[PATCH v2] usb: usbtmc: Fix disconnect/poll interaction

2016-02-18 Thread Dave Penkler
When the device is disconnected poll waiters were not being woken. Changes for v2: - add commit summary - add Fixes and Reported-by tags Fixes: eb6b92ecc0f9 ("Add support for receiving USBTMC USB488 SRQ notifications via poll/select") Reported-by: Oliver Neukum Signed-of

[PATCH] usb: usbtmc: Fix disconnect/poll interaction

2016-02-17 Thread Dave Penkler
When the device is disconnected poll waiters were not being woken. Fixes issue in commit eb6b92ecc0f9412623ab1584ddd8389b371638d4 reported by Oliver Neukum Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH v7 0/5] usb: usbtmc: Add support for missing functions in USBTMC-USB488 spec

2016-01-29 Thread Dave Penkler
Hi Clemens, On Thu, Jan 28, 2016 at 09:46:59AM +0100, Clemens Ladisch wrote: > Dave Penkler wrote: > > Implement support for the USB488 defined READ_STATUS_BYTE ioctl (1/5) > > and SRQ notifications with fasync (2/5) and poll/select (3/5) in order > > to be able to sync

[PATCH v7 5/5] Add ioctls to enable and disable local controls on an instrument

2016-01-27 Thread Dave Penkler
These ioctls provide support for the USBTMC-USB488 control requests for REN_CONTROL, GO_TO_LOCAL and LOCAL_LOCKOUT Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 70 include/uapi/linux/usb/tmc.h | 6 2 files changed, 76

[PATCH v7 4/5] Add ioctl to retrieve USBTMC-USB488 capabilities

2016-01-27 Thread Dave Penkler
This is a convenience function to obtain an instrument's capabilities from its file descriptor without having to access sysfs from the user program. Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 12 include/uapi/linux/usb/tmc.h | 21 ++--- 2

[PATCH v7 3/5] Add support for receiving USBTMC USB488 SRQ notifications via poll/select

2016-01-27 Thread Dave Penkler
Background: In many situations operations on multiple instruments need to be synchronized. poll/select provide a convenient way of waiting on a number of different instruments and other peripherals simultaneously. Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 23

[PATCH v7 2/5] Add support for USBTMC USB488 SRQ notification with fasync

2016-01-27 Thread Dave Penkler
Background: By configuring an instrument's event status register various conditions can be reported via an SRQ notification. This complements the synchronous polling approach using the READ_STATUS_BYTE ioctl with an asynchronous notification. Signed-off-by: Dave Penkler --- drivers/usb/

[PATCH v7 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.

2016-01-27 Thread Dave Penkler
appropriate condition. This capability is referred to in instrument application notes on synchronizing acquisitions for other platforms. Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 201 +++ include/uapi/linux/usb/tmc.h | 2 + 2 files changed, 203

[PATCH v7 0/5] usb: usbtmc: Add support for missing functions in USBTMC-USB488 spec

2016-01-27 Thread Dave Penkler
- simplify some expressions v3 - Split into multiple patches as per gregkh request V2 - Fix V1 bug: not waking sleepers on disconnect. - Correct sparse warnings. V1 - Original patch Testing: All functions tested ok on an USBTMC-USB488 compliant oscilloscope Dave Penkler (5

Re: [PATCH v6 4/5] Add ioctl to retrieve USBTMC-USB488 capabilities

2016-01-26 Thread Dave Penkler
On Sun, Jan 24, 2016 at 08:42:54PM -0800, Greg KH wrote: > On Sun, Nov 29, 2015 at 01:35:51PM +0100, Dave Penkler wrote: > > This is a convenience function to obtain an instrument's > > capabilities from its file descriptor without having to access sysfs > > from the use

[PATCH v6 5/5] Add ioctls to enable and disable local controls on an instrument

2015-11-29 Thread Dave Penkler
These ioctls provide support for the USBTMC-USB488 control requests for REN_CONTROL, GO_TO_LOCAL and LOCAL_LOCKOUT Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 71 include/uapi/linux/usb/tmc.h | 6 2 files changed, 77

[PATCH v6 4/5] Add ioctl to retrieve USBTMC-USB488 capabilities

2015-11-29 Thread Dave Penkler
This is a convenience function to obtain an instrument's capabilities from its file descriptor without having to access sysfs from the user program. Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 12 include/uapi/linux/usb/tmc.h | 21 ++--- 2

[PATCH v6 3/5] Add support for receiving USBTMC USB488 SRQ notifications via poll/select

2015-11-29 Thread Dave Penkler
Background: In many situations operations on multiple instruments need to be synchronized. poll/select provide a convenient way of waiting on a number of different instruments and other peripherals simultaneously. Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 23

[PATCH v6 2/5] Add support for USBTMC USB488 SRQ notification with fasync

2015-11-29 Thread Dave Penkler
Background: By configuring an instrument's event status register various conditions can be reported via an SRQ notification. This complements the synchronous polling approach using the READ_STATUS_BYTE ioctl with an asynchronous notification. Signed-off-by: Dave Penkler --- drivers/usb/

[PATCH v6 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.

2015-11-29 Thread Dave Penkler
appropriate condition. This capability is referred to in instrument application notes on synchronizing acquisitions for other platforms. Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 200 +++ include/uapi/linux/usb/tmc.h | 2 + 2 files changed, 202

[PATCH v6 0/5] usb: usbtmc: Add support for missing functions in USBTMC-USB488 spec

2015-11-29 Thread Dave Penkler
- simplify some expressions v3 - Split into multiple patches as per gregkh request V2 - Fix V1 bug: not waking sleepers on disconnect. - Correct sparse warnings. V1 - Original patch Testing: All functions tested ok on an USBTMC-USB488 compliant oscilloscope Dave Penkler

Re: [PATCH v5 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.

2015-11-28 Thread Dave Penkler
On Sat, Nov 28, 2015 at 04:57:47PM +0200, Andy Shevchenko wrote: > On Sat, Nov 28, 2015 at 1:55 PM, Dave Penkler wrote: > > On Wed, Nov 25, 2015 at 10:38:39PM +0200, Andy Shevchenko wrote: > >> On Wed, Nov 25, 2015 at 11:18 AM, Dave Penkler wrote: > >> > On Sun, No

Re: [PATCH v5 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.

2015-11-28 Thread Dave Penkler
On Wed, Nov 25, 2015 at 10:38:39PM +0200, Andy Shevchenko wrote: > On Wed, Nov 25, 2015 at 11:18 AM, Dave Penkler wrote: > > On Sun, Nov 22, 2015 at 12:32:41PM +0200, Andy Shevchenko wrote: > >> On Sun, Nov 22, 2015 at 11:19 AM, Dave Penkler wrote: > >> > On Wed, No

Re: [PATCH v5 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.

2015-11-25 Thread Dave Penkler
On Sun, Nov 22, 2015 at 12:32:41PM +0200, Andy Shevchenko wrote: > On Sun, Nov 22, 2015 at 11:19 AM, Dave Penkler wrote: > > On Wed, Nov 18, 2015 at 11:55:27AM +0200, Andy Shevchenko wrote: > >> On Wed, Nov 18, 2015 at 10:37 AM, Dave Penkler wrote: > > >

Re: [PATCH v5 5/5] Add ioctls to enable and disable local controls on an instrument

2015-11-25 Thread Dave Penkler
On Sun, Nov 22, 2015 at 12:36:53PM +0200, Andy Shevchenko wrote: > On Sun, Nov 22, 2015 at 10:51 AM, Dave Penkler wrote: > > On Wed, Nov 18, 2015 at 11:41:30AM +0200, Andy Shevchenko wrote: > >> On Wed, Nov 18, 2015 at 10:38 AM, Dave Penkler wrote: > > &

Re: [PATCH v5 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.

2015-11-22 Thread Dave Penkler
On Wed, Nov 18, 2015 at 11:55:27AM +0200, Andy Shevchenko wrote: > On Wed, Nov 18, 2015 at 10:37 AM, Dave Penkler wrote: > > Background: > > When performing a read on an instrument that is executing a function > > that runs longer than the USB timeout the instrument may h

Re: [PATCH v5 5/5] Add ioctls to enable and disable local controls on an instrument

2015-11-22 Thread Dave Penkler
On Wed, Nov 18, 2015 at 11:41:30AM +0200, Andy Shevchenko wrote: > On Wed, Nov 18, 2015 at 10:38 AM, Dave Penkler wrote: > > These ioctls provide support for the USBTMC-USB488 control requests > > for REN_CONTROL, GO_TO_LOCAL and LOCAL_LOCKOUT > > Couple of comments below

[PATCH v5 2/5] Add support for USBTMC USB488 SRQ notification with fasync

2015-11-18 Thread Dave Penkler
Background: By configuring an instrument's event status register various conditions can be reported via an SRQ notification. This complements the synchronous polling approach using the READ_STATUS_BYTE ioctl with an asynchronous notification. Signed-off-by: Dave Penkler --- drivers/usb/

[PATCH v5 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.

2015-11-18 Thread Dave Penkler
appropriate condition. This capability is referred to in instrument application notes on synchronizing acquisitions for other platforms. Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 212 +++ include/uapi/linux/usb/tmc.h | 2 + 2 files changed, 214

[PATCH v5 5/5] Add ioctls to enable and disable local controls on an instrument

2015-11-18 Thread Dave Penkler
These ioctls provide support for the USBTMC-USB488 control requests for REN_CONTROL, GO_TO_LOCAL and LOCAL_LOCKOUT Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 71 include/uapi/linux/usb/tmc.h | 6 2 files changed, 77

[PATCH v5 3/5] Add support for receiving USBTMC USB488 SRQ notifications via poll/select

2015-11-18 Thread Dave Penkler
Background: In many situations operations on multiple instruments need to be synchronized. poll/select provide a convenient way of waiting on a number of different instruments and other peripherals simultaneously. Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 23

[PATCH v5 4/5] Add ioctl to retrieve USBTMC-USB488 capabilities

2015-11-18 Thread Dave Penkler
This is a convenience function to obtain an instrument's capabilities from its file descriptor without having to access sysfs from the user program. Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 12 include/uapi/linux/usb/tmc.h | 21 ++--- 2

[PATCH v5 0/5] usb: usbtmc: Add support for missing functions in USBTMC-USB488 spec

2015-11-18 Thread Dave Penkler
compliant oscilloscope Dave Penkler (5): Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation. Add support for USBTMC USB488 SRQ notification with fasync Add support for receiving USBTMC USB488 SRQ notifications via poll/select Add ioctl to retrieve USBTMC-USB488

Re: [PATCH v4 5/5] Add ioctls to enable and disable local controls on an instrument

2015-11-18 Thread Dave Penkler
On Sun, Nov 15, 2015 at 10:10:35PM +0200, Andy Shevchenko wrote: > On Sun, Nov 15, 2015 at 8:40 PM, Dave Penkler wrote: > > These ioctls provide support for the USBTMC-USB488 control requests > > for REN_CONTROL, GO_TO_LOCAL and LOCAL_LOCKOUT > > > > + > &g

Re: [PATCH v4 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.

2015-11-18 Thread Dave Penkler
Hi Andy, On Sun, Nov 15, 2015 at 10:04:10PM +0200, Andy Shevchenko wrote: > On Sun, Nov 15, 2015 at 8:39 PM, Dave Penkler wrote: snip > > + > > Redundant empty line. > ok > > > + data->iin_bTag = 2; > > Hmm??? Why 2? > A-ha, below I f

[PATCH v4 2/5] Add support for USBTMC USB488 SRQ notification with fasync

2015-11-15 Thread Dave Penkler
Background: By configuring an instrument's event status register various conditions can be reported via an SRQ notification. This complements the synchronous polling approach using the READ_STATUS_BYTE ioctl with an asynchronous notification. Signed-off-by: Dave Penkler --- drivers/usb/

[PATCH v4 4/5] Add ioctl to retrieve USBTMC-USB488 capabilities

2015-11-15 Thread Dave Penkler
This is a convenience function to obtain an instrument's capabilities from its file descriptor without having to access sysfs from the user program. Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 12 include/uapi/linux/usb/tmc.h | 21 ++--- 2

[PATCH v4 3/5] Add support for receiving USBTMC USB488 SRQ notifications via poll/select

2015-11-15 Thread Dave Penkler
Background: In many situations operations on multiple instruments need to be synchronized. poll/select provide a convenient way of waiting on a number of different instruments and other peripherals simultaneously. Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 23

[PATCH v4 5/5] Add ioctls to enable and disable local controls on an instrument

2015-11-15 Thread Dave Penkler
These ioctls provide support for the USBTMC-USB488 control requests for REN_CONTROL, GO_TO_LOCAL and LOCAL_LOCKOUT Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 76 include/uapi/linux/usb/tmc.h | 6 2 files changed, 82

[PATCH v4 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.

2015-11-15 Thread Dave Penkler
appropriate condition. This capability is referred to in instrument application notes on synchronizing acquisitions for other platforms. Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 219 +++ include/uapi/linux/usb/tmc.h | 2 + 2 files changed, 221

[PATCH v4 0/5] usb: usbtmc: Add support for missing functions in USBTMC-USB488 spec

2015-11-15 Thread Dave Penkler
sleepers on disconnect. - Correct sparse warnings. V1 - Original patch Testing: All functions tested ok on an USBTMC-USB488 compliant oscilloscope Dave Penkler (5): Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation. Add support for USBTMC USB488 SRQ

Re: [PATCH v3 5/5] Add ioctls to enable and disable local controls on an instrument

2015-11-13 Thread Dave Penkler
Hi Andy, On Wed, Nov 11, 2015 at 09:36:41PM +0200, Andy Shevchenko wrote: > On Wed, Nov 11, 2015 at 1:21 PM, Dave Penkler wrote: > > These ioctls provide support for the USBTMC-USB488 control requests > > for REN_CONTROL, GO_TO_LOCAL and LOCAL_LOCKOUT snip > > +

Re: [PATCH v3 00/12] usb: early: add support for early printk through USB3 debug port

2015-11-12 Thread Dave Young
On 11/13/15 at 10:04am, Lu, Baolu wrote: > Hi Dave, > > On 11/12/2015 02:01 PM, Dave Young wrote: > >Hi, Baolu > > > >On 11/12/15 at 10:45am, Lu, Baolu wrote: > >>>Hi Dave, > >>> > >>>Which device are you testing with? This implem

Re: [PATCH v3 00/12] usb: early: add support for early printk through USB3 debug port

2015-11-11 Thread Dave Young
Hi, Baolu On 11/12/15 at 10:45am, Lu, Baolu wrote: > Hi Dave, > > Which device are you testing with? This implementation was developed > and tested on Intel Skylake devices. > > It doesn't surprise me if it doesn't work with other silicons. But it do > remind m

[PATCH v3 5/5] Add ioctls to enable and disable local controls on an instrument

2015-11-11 Thread Dave Penkler
These ioctls provide support for the USBTMC-USB488 control requests for REN_CONTROL, GO_TO_LOCAL and LOCAL_LOCKOUT Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 76 include/uapi/linux/usb/tmc.h | 9 +- 2 files changed, 84

[PATCH v3 4/5] Add ioctl to retrieve USBTMC-USB488 capabilities

2015-11-11 Thread Dave Penkler
This is a convenience function to obtain an instrument's capabilities from its file descriptor without having to access sysfs from the user program. Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 12 include/uapi/linux/usb/tmc.h | 21 ++--- 2

[PATCH v3 3/5] Add support for receiving USBTMC USB488 SRQ notifications via poll/select

2015-11-11 Thread Dave Penkler
Background: In many situations operations on multiple instruments need to be synchronized. poll/select provide a convenient way of waiting on a number of different instruments and other peripherals simultaneously. Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 23

[PATCH v3 2/5] Add support for USBTMC USB488 SRQ notification with fasync

2015-11-11 Thread Dave Penkler
Background: By configuring an instrument's event status register various conditions can be reported via an SRQ notification. This complements the synchronous polling approach using the READ_STATUS_BYTE ioctl with an asynchronous notification. Signed-off-by: Dave Penkler --- drivers/usb/

[PATCH v3 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.

2015-11-11 Thread Dave Penkler
appropriate condition. This capability is refered to in instrument application notes on synchronizing acquisitions for other platforms. Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 223 +++ include/uapi/linux/usb/tmc.h | 2 + 2 files changed, 225

[PATCH v3 0/5] usb: usbtmc: Add support for missing functions in USBTMC-USB488 spec

2015-11-11 Thread Dave Penkler
on an USBTMC-USB488 compliant oscilloscope Dave Penkler (5): Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation. Add support for USBTMC USB488 SRQ notification with fasync Add support for receiving USBTMC USB488 SRQ notifications via poll/select Add ioctl to

Re: [PATCH v3 00/12] usb: early: add support for early printk through USB3 debug port

2015-11-10 Thread Dave Young
Hi, On 11/11/15 at 09:32am, Lu, Baolu wrote: > > > On 11/10/2015 05:39 PM, Dave Young wrote: > >Hi, > > > >On 11/09/15 at 03:38pm, Lu Baolu wrote: > >>This patch series adds support for early printk through USB3 debug port. > >>USB3 debug port is d

Re: [PATCH v3 00/12] usb: early: add support for early printk through USB3 debug port

2015-11-10 Thread Dave Young
. debug host detected the remote device, but later the devie automaticlly disconnected and earlyprintk hangs. I have not got more time, will try your new patchset when I have time. Thanks Dave -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body

Re: [PATCH v3 01/12] usb: xhci: add sysfs file for xHCI debug port

2015-11-10 Thread Dave Young
+ offset = xhci_find_next_cap_offset(base, offset); > + if (!offset) > + break; > + } > + > + spin_unlock_irqrestore(&xhci->lock, flags); I'm not sure spin_lock is good and necessary here, also seems there's alre

Re: [PATCH 00/12] usb: early: add support for early printk through USB3 debug port

2015-11-03 Thread Dave Young
he design document and user guide. > Nice work, I want to try your patches. But I have only one machine with debug capability, I think I can use it as debug target. Can I use another machine with usb 3.0 but no debug capability as the debug host? BTW, I hacked a cable according to usb 3 s

[PATCH V2] USB: usbtmc: Add support for missing USBTMC-USB488 spec

2015-10-19 Thread dave penkler
ioctl to return all device capabilities. Fix PATCH V1 bug: not waking sleepers on disconnect. Correct sparse warnings. Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 359 +++ include/uapi/linux/usb/tmc.h | 42 +++-- 2 files changed, 391

Re: [PATCH] USB: usbtmc: Add support for missing USBTMC-USB488 spec

2015-10-14 Thread dave penkler
Hi Oliver, On Wed, Oct 14, 2015 at 3:33 PM, Oliver Neukum wrote: > On Wed, 2015-10-14 at 15:13 +0200, dave penkler wrote: > > Hi, > > just a few remarks. thank you. > >> >> +static int usbtmc488_ioctl_read_stb(struct usbtmc_device_data *data, >> +

[PATCH] USB: usbtmc: Add support for missing USBTMC-USB488 spec

2015-10-14 Thread dave penkler
ioctl to return all device capabilities. Signed-off-by: Dave Penkler --- drivers/usb/class/usbtmc.c | 359 +++ include/uapi/linux/usb/tmc.h | 42 +++-- 2 files changed, 391 insertions(+), 10 deletions(-) diff --git a/drivers/usb/class/usbtmc.c b/drivers

[PATCH] xhci: fix warning when CONFIG_PM disabled.

2015-08-31 Thread Dave Hansen
From: Dave Hansen I have a .config with CONFIG_PM disabled. I get the following whenever compiling the xhci driver: drivers/usb/host/xhci-pci.c:192:13: warning: ‘xhci_pme_quirk’ defined but not used [-Wunused-function] Looks like we just need to move xhci_pme_quirk() to be underneath

Re: Polling a usbfs file descriptor.

2015-04-21 Thread Dave Mielke
ested >in doing that. Out of curiosity, do you know why one must poll for output (rather than for input)? JDoes "writability" precisely mean that there's at least one user-submitted URB that can now be reaped? -- Dave Mielke | 2213 Fox Crescent | The Bible is the v

Polling a usbfs file descriptor.

2015-04-20 Thread Dave Mielke
or us to use this capability? Can anyone point me to documentation that formally describes how it works? -- Dave Mielke | 2213 Fox Crescent | The Bible is the very Word of God. Phone: 1-613-726-0014 | Ottawa, Ontario | http://Mielke.cc/bible/ EMail: d...@mielke.cc | Canada K2A 1H7 |

Re: [PATCH] usb gadget: remove size limitation for storage cdrom

2015-03-11 Thread Dave Young
On 03/09/15 at 10:22am, Alan Stern wrote: > On Mon, 9 Mar 2015, Dave Young wrote: > > > On 03/08/15 at 11:29am, Alan Stern wrote: > > > On Sun, 8 Mar 2015, Dave Young wrote: > > > > > > > I used usb cdrom emulation to play video dvd for my daught

Re: [PATCH] usb gadget: remove size limitation for storage cdrom

2015-03-08 Thread Dave Young
On 03/08/15 at 11:29am, Alan Stern wrote: > On Sun, 8 Mar 2015, Dave Young wrote: > > > I used usb cdrom emulation to play video dvd for my daughter, but I got > > below > > error: > > > > [dave@darkstar tmp]$ cat /mnt/sr1/VIDEO_TS/VTS_01_5.VOB >/dev/null

[PATCH] usb gadget: remove size limitation for storage cdrom

2015-03-07 Thread Dave Young
I used usb cdrom emulation to play video dvd for my daughter, but I got below error: [dave@darkstar tmp]$ cat /mnt/sr1/VIDEO_TS/VTS_01_5.VOB >/dev/null cat: /mnt/sr1/VIDEO_TS/VTS_01_5.VOB: Input/output error [dave@darkstar tmp]$ dmesg|tail -1 [ 3349.371857] sr1: rw=0, want=8028824, limit=4607

Re: Unable to reap urb after receiving signal using usbfs.

2015-02-12 Thread Dave Mielke
all of them are arbitrarily blocked. That lets each thread safely unblock each signal it cares about. So, I aghree, there's no bug - just a bit of memory loss on my part. -- Dave Mielke | 2213 Fox Crescent | The Bible is the very Word of God. Phone: 1-613-726-0014 | Ottawa, Ontario

Re: Unable to reap urb after receiving signal using usbfs.

2015-02-12 Thread Dave Mielke
- in our case, that's only one of them - shouldn't the handling revert to the default for that signal? Isn't it wrong that, when there are no signalfd file descriptors open for a given signal, the signal still seems to stay pending within the signalfd mechanism? -- Dave Mielke

Re: Unable to reap urb after receiving signal using usbfs.

2015-02-11 Thread Dave Mielke
n the previous attempt is delivered. Flushing the signalfd file descriptor before closing it resolves the problem. I guess we all know a little bit more about signalfd now. :-_) Thank you for bearing with me. -- Dave Mielke | 2213 Fox Crescent | The Bible is the very Word of God. Phone: 1-61

Re: Unable to reap urb after receiving signal using usbfs.

2015-02-11 Thread Dave Mielke
What could cause that? -- Dave Mielke | 2213 Fox Crescent | The Bible is the very Word of God. Phone: 1-613-726-0014 | Ottawa, Ontario | http://Mielke.cc/bible/ EMail: d...@mielke.cc | Canada K2A 1H7 | http://FamilyRadio.com/ -- To unsubscribe from this list: send the line "un

Re: Unable to reap urb after receiving signal using usbfs.

2015-02-11 Thread Dave Mielke
Just like the siginfo data has fields that must be left over from somewhere else, might it be that the user urb is copied, without clearing the signr field, to initialize an underlying system-provided urb? -- Dave Mielke | 2213 Fox Crescent | The Bible is the very Word of God. Phone

Re: Unable to reap urb after receiving signal using usbfs.

2015-02-11 Thread Dave Mielke
What might it mean that ssi_addr is NULL? Is a non-user urb ever submitted underneath that might be causing the notification? -- Dave Mielke | 2213 Fox Crescent | The Bible is the very Word of God. Phone: 1-613-726-0014 | Ottawa, Ontario | http://Mielke.cc/bible/ EMail: d

Re: Unable to reap urb after receiving signal using usbfs.

2015-02-11 Thread Dave Mielke
t sends a >signal mimicking the effect of an URB completion, do you? No, there's none of that kind of stuff in there. -- Dave Mielke | 2213 Fox Crescent | The Bible is the very Word of God. Phone: 1-613-726-0014 | Ottawa, Ontario | http://Mielke.cc/bible/ EMail: d...@miel

Re: Unable to reap urb after receiving signal using usbfs.

2015-02-11 Thread Dave Mielke
d. The entire application (brltty, if you're curious) is a set of event handlers that come and go as needed. The signalfd notification is appearing on the very first call to poll() after the urb is submitted. -- Dave Mielke | 2213 Fox Crescent | The Bible is the very Word of Go

Re: Unable to reap urb after receiving signal using usbfs.

2015-02-11 Thread Dave Mielke
right time whereas a signalfd notification would occur immediately. -- Dave Mielke | 2213 Fox Crescent | The Bible is the very Word of God. Phone: 1-613-726-0014 | Ottawa, Ontario | http://Mielke.cc/bible/ EMail: d...@mielke.cc | Canada K2A 1H7 | http://FamilyRadio.com/ -- To unsubs

Re: Unable to reap urb after receiving signal using usbfs.

2015-02-11 Thread Dave Mielke
eally never does anything to deliver the completion signal until a urb has actually completed then what might it be doing to trigger a signalfd notificatoin earlier than that? -- Dave Mielke | 2213 Fox Crescent | The Bible is the very Word of God. Phone: 1-613-726-0014 | Ottawa, On

  1   2   >