Re: [PATCH net-next 2/2] r8152: adjust rtl_start_rx

2014-11-11 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Wed, 12 Nov 2014 01:45:08 + David Miller [mailto:da...@davemloft.net] Sent: Saturday, November 08, 2014 12:35 AM [...] Does this even work? If you leave a hole in the ring, the device is going to stop there anyways. So better

Re: [PATCH net-next 2/2] r8152: adjust rtl_start_rx

2014-11-11 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Mon, 10 Nov 2014 03:29:27 + The behavior is different for PCI(e) and USB ethernet device. The PCI nic could know the ring buffer by certain way, so the device could fill the data into the buffer one by one automatically. However, for usb nic,

Re: [net-next PATCH v3 0/5] Replace __skb_alloc_pages with simpler function

2014-11-11 Thread David Miller
From: Alexander Duyck alexander.h.du...@redhat.com Date: Tue, 11 Nov 2014 09:26:26 -0800 This patch series replaces __skb_alloc_pages with a much simpler function, __dev_alloc_pages. The main difference between the two is that __skb_alloc_pages had an sk_buff pointer that was being passed as

Re: [PATCH net-next 2/2] r8152: adjust rtl_start_rx

2014-11-11 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Wed, 12 Nov 2014 05:07:40 + How about that when a error occurs, add the remaining rx to the list without submission? Then, the remianing rx could be re-submitted later, and the rtl_start_rx() could be completed as soon as possible. I really

Re: [PATCH net-next 2/2] r8152: adjust rtl_start_rx

2014-11-11 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Wed, 12 Nov 2014 05:23:03 + David Miller [mailto:da...@davemloft.net] Sent: Wednesday, November 12, 2014 1:13 PM [...] I really want to know why you are spending so much effort on this. Is there a real situation that happened very often

Re: [PATCH] usbnet: smsc95xx: dereferencing NULL pointer

2014-11-10 Thread David Miller
From: Sudip Mukherjee sudipm.mukher...@gmail.com Date: Fri, 7 Nov 2014 18:52:40 +0530 we were dereferencing dev to initialize pdata. but just after that we have a BUG_ON(!dev). so we were basically dereferencing the pointer first and then tesing it for NULL. Signed-off-by: Sudip Mukherjee

Re: [PATCH] asix: Do full reset during ax88772_bind

2014-11-07 Thread David Miller
From: Stam, Michel [FINT] m.s...@fugro.nl Date: Fri, 7 Nov 2014 09:27:26 +0100 Please add; Tested-by: Michel Stam m.s...@fugro.nl You're making two critical mistakes here in how you are replying to this patch. First, do not top post. Quote the commit message, then add your Tested-by or

Re: [PATCH net-next 2/2] r8152: adjust rtl_start_rx

2014-11-07 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Fri, 7 Nov 2014 17:55:11 +0800 Submit all the rx buffers, even though a error occurs. Otherwise the buffers which are not submitted would be lost until next rtl_start_rx() is called. Besides, the fail buffer could be re-submitted later.

Re: [PATCH] asix: Do full reset during ax88772_bind

2014-11-07 Thread David Miller
From: Charles Keepax ckee...@opensource.wolfsonmicro.com Date: Thu, 6 Nov 2014 15:49:41 + commit 3cc81d85ee01 (asix: Don't reset PHY on if_up for ASIX 88772) causes the ethernet on Arndale to no longer function. This appears to be because the Arndale ethernet requires a full reset before

Re: [PATCH net-next 0/3] r8152: rtl_ops_init modify

2014-11-06 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Thu, 6 Nov 2014 12:47:37 +0800 Initialize the ops through tp-version. This could skip checking each VID/PID. Series applied, thank you. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to

Re: [PATCH net-next] r8152: disable the tasklet by default

2014-11-05 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Wed, 5 Nov 2014 10:17:02 +0800 Let the tasklet only be enabled after open(), and be disabled for the other situation. The tasklet is only necessary after open() for tx/rx, so it could be disabled by default. Signed-off-by: Hayes Wang

Re: [PATCH net] r8152: stop submitting intr for -EPROTO

2014-10-31 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Fri, 31 Oct 2014 13:35:57 +0800 For Renesas USB 3.0 host controller, when unplugging the usb hub which has the RTL8153 plugged, the driver would get -EPROTO for interrupt transfer. There is high probability to get the information of HC died;

Re: [PATCH net-next v2 2/3] r8152: clear the flag of SCHEDULE_TASKLET in tasklet

2014-10-31 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Fri, 31 Oct 2014 17:56:41 +0800 Clear the flag of SCHEDULE_TASKLET in bottom_half() to avoid re-schedule the tasklet again by workqueue. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 3 +++ 1 file changed, 3

Re: [PATCH net 0/3] r8152: patches for autosuspend

2014-10-30 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Wed, 29 Oct 2014 11:12:14 +0800 There are unexpected processes when enabling autosuspend. These patches are used to fix them. Series applied, thank you. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message

Re: [PATCH net-next] r8152: set RTL8152_UNPLUG when finding -ENODEV

2014-10-30 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Thu, 30 Oct 2014 11:46:40 +0800 Set RTL8152_UNPLUG when finding -ENODEV. This could accelerate unloading the driver when the device is unplugged. Signed-off-by: Hayes Wang hayesw...@realtek.com Applied. -- To unsubscribe from this list: send the

Re: [PATCH net-next 0/2] r8152: support nway_reset

2014-10-29 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Tue, 28 Oct 2014 14:05:50 +0800 Fix the CHECK from checkpatch.pl and support nway_reset. Series applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More

Re: [PATCH net] r8152: return -EBUSY for runtime suspend

2014-10-17 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Fri, 17 Oct 2014 16:55:08 +0800 Remove calling cancel_delayed_work_sync() for runtime suspend, because it would cause dead lock. Instead, return -EBUSY to avoid the device enters suspending if the net is running and the delayed work is pending or

Re: [PATCH v3] Add support for GPIOs for SMSC LAN95xx chips.

2014-10-09 Thread David Miller
From: Evgeny Boger bo...@contactless.ru Date: Thu, 9 Oct 2014 02:14:58 +0400 There might be 11 GPIOs in total. Last three GPIOs (offsets 8-10, 0-based) are shared with FDX, LNKA, SPD LEDs respectively. The LEDs are driven by chip by default at startup time. Once the corresponding GPIO is

Re: [PATCH net-next] r8152: use mutex for hw settings

2014-10-09 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Thu, 9 Oct 2014 07:59:35 + If I use the rtnl_lock(), I get a dead lock when enabling autosuspend. Case 1: autosuspend before calling open. rtnl_lock() call open try to autoresume and rtl8152_resume is called. dead lock

Re: [PATCH net-next v2 0/3] r8152: use mutex for hw settings

2014-10-09 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Thu, 9 Oct 2014 18:00:23 +0800 v2: Make sure the autoresume wouldn't occur inside the mutex, otherwise the dead lock would happen. For the purpose, adjust some code about autosuspend/autoresume. v1: Use mutex to avoid that the serial hw

Re: [PATCH net-next] r8152: use mutex for hw settings

2014-10-08 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Tue, 7 Oct 2014 13:36:30 +0800 Use mutex to avoid that the serial hw settings would be interrupted by other settings. Although there is no problem now, it makes the driver more safe. Signed-off-by: Hayes Wang hayesw...@realtek.com I think a much

Re: [PATCH net-next v2] r8152: nway reset after setting eee

2014-10-06 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Mon, 6 Oct 2014 10:36:04 +0800 Restart autonegotiation is necessary after setting EEE. Signed-off-by: Hayes Wang hayesw...@realtek.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message

Re: [PATCH net-next] r8152: nway reset after setting eee

2014-10-03 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Thu, 2 Oct 2014 16:01:22 +0800 @@ -3480,6 +3480,9 @@ rtl_ethtool_set_eee(struct net_device *net, struct ethtool_eee *edata) ret = tp-rtl_ops.eee_set(tp, edata); + if (ret == 0) + ret = mii_nway_restart(tp-mii); Please

Re: [PATCH net v2] r8152: autoresume before setting MAC address

2014-10-03 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Thu, 2 Oct 2014 17:03:12 +0800 Resume the device before setting the MAC address. Signed-off-by: Hayes Wang hayesw...@realtek.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to

Re: [PATCH net 0/2] r8152: patches about firmware

2014-10-01 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Wed, 1 Oct 2014 13:25:09 +0800 The patches fix the issues when the firmware exists. For the multiple OS, the firmware may be loaded by the driver of the other OS. And the Linux driver has influences on it. Series applied, thanks. -- To

Re: [PATCH net] r8152: fix setting RTL8152_UNPLUG

2014-09-30 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Tue, 30 Sep 2014 16:48:01 +0800 The flag of RTL8152_UNPLUG should only be set when the device is unplugged, not each time the rtl8152_disconnect() is called. Otherwise, the device wouldn't be stopped normally. Signed-off-by: Hayes Wang

Re: [PATCH net-next 0/3] r8152: support setting eee by ethtool

2014-09-28 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Thu, 25 Sep 2014 20:53:59 +0800 Modify some definitions about EEE, and add the support of setting the EEE through ethtool. Series applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to

Re: [PATCH net] r8152: fix the carrier off when autoresuming

2014-09-26 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Tue, 23 Sep 2014 16:31:47 +0800 netif_carrier_off would be called when autoresuming, even though the cable is plugged. This causes some applications do relative actions when detecting the carrier off. Keep the status of the carrier, and let it be

Re: [PATCH net] r8152: disable ALDPS

2014-09-22 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Fri, 19 Sep 2014 15:17:18 +0800 If the hw is in ALDPS mode, the hw may have no response for accessing the most registers. Therefore, the ALDPS should be disabled before accessing the hw in rtl_ops.init(), rtl_ops.disable(), rtl_ops.up(), and

Re: [PATCH net-next v2] r8152: support VLAN

2014-09-13 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Fri, 12 Sep 2014 10:43:11 +0800 Support hw VLAN for tx and rx. And enable them by default. Signed-off-by: Hayes Wang hayesw...@realtek.com Applied. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to

Re: [PATCH net-next] r8152: support VLAN

2014-09-11 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Thu, 11 Sep 2014 20:16:24 +0800 - ocp_data = ocp_read_word(tp, MCU_TYPE_PLA, PLA_CPCR); - ocp_data = ~CPCR_RX_VLAN; - ocp_write_word(tp, MCU_TYPE_PLA, PLA_CPCR, ocp_data); + if (tp-netdev-features NETIF_F_HW_VLAN_CTAG_RX) +

Re: [PATCH net-next] r8152: use usleep_range

2014-09-09 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Tue, 9 Sep 2014 11:40:28 +0800 Replace mdelay with usleep_range to avoid busy loop. Signed-off-by: Hayes Wang hayesw...@realtek.com Applied. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to

Re: [PATCH net-next v3 0/2] r8152: random MAC address

2014-09-05 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Thu, 4 Sep 2014 16:15:40 +0800 If the interface has invalid MAC address, it couldn't be used. In order to let it work normally, give a random one. v3: Remove ether_addr_copy(dev-perm_addr, dev-dev_addr); v2: Use %pM format

Re: [PATCH net-next] r8152: rename rx_buf_sz

2014-09-01 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Tue, 2 Sep 2014 10:27:52 +0800 The variable rx_buf_sz is used by both tx and rx buffers. Replace it with agg_buf_sz. Signed-off-by: Hayes Wang hayesw...@realtek.com Applied. -- To unsubscribe from this list: send the line unsubscribe linux-usb in

Re: [PATCH net-next v2] r8152: reduce the number of Tx

2014-08-31 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Mon, 1 Sep 2014 02:46:38 + From: David Miller [mailto:da...@davemloft.net] [...] This driver has a loop that iterates MAX_TX times to initialize both the RX and TX buffers. So if they are not equal, it can't possibly work. Excuse me. I

Re: [PATCH net-next v2] r8152: reduce the number of Tx

2014-08-29 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Thu, 28 Aug 2014 10:24:18 +0800 Because the Tx has the features of stopping queue and aggregation, We don't need many tx buffers. Change the tx number from 10 to 4 to reduce the usage of the memory. This could save 16K * 6 bytes memory.

Re: [PATCH net-next] r8152: replace strncpy with strlcpy

2014-08-27 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Tue, 26 Aug 2014 10:08:23 +0800 Replace the strncpy with strlcpy, and use sizeof to determine the length. Signed-off-by: Hayes Wang hayesw...@realtek.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-usb in

Re: net: Add ops-ndo_xmit_flush()

2014-08-27 Thread David Miller
From: Dan Carpenter dan.carpen...@oracle.com Date: Tue, 26 Aug 2014 15:21:37 +0300 Hello David S. Miller, The patch 4798248e4e02: net: Add ops-ndo_xmit_flush() from Aug 22, 2014, leads to the following static checker warning: drivers/usb/gadget/function/f_ncm.c:1104 ncm_tx_tasklet()

Re: [PATCH net-next 0/4] r8152: firmware support

2014-08-25 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Mon, 25 Aug 2014 06:43:02 + Except the step 3, 4, 6 and 7, the other steps depend on the context of the firmware. That is, for different firmware, some actions would be removed or added, and some settings would be different. Especially the step

Re: [PATCH net-next] r8152: check code with checkpatch.pl

2014-08-25 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Mon, 25 Aug 2014 15:53:00 +0800 626: CHECK: Alignment should match open parenthesis 646: CHECK: Alignment should match open parenthesis 655: CHECK: Alignment should match open parenthesis 695: CHECK: Alignment should match open parenthesis

Re: [PATCH net-next 0/4] r8152: firmware support

2014-08-24 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Mon, 25 Aug 2014 03:43:04 + From: David Miller [mailto:da...@davemloft.net] [...] You haven't told us why you need to do this. These are just programming registers in the chip, and I see no reason to not keep these in the driver with real

Re: [PATCH net-next 0/4] r8152: firmware support

2014-08-22 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Wed, 20 Aug 2014 16:58:35 +0800 Parsing, checking, and writing the firmware. You haven't told us why you need to do this. These are just programming registers in the chip, and I see no reason to not keep these in the driver with real code. I'm not

Re: [PATCH 1/1] net: fix USB network driver config option.

2014-08-06 Thread David Miller
From: Francois Romieu rom...@fr.zoreil.com Date: Thu, 7 Aug 2014 00:36:40 +0200 From: Francois Romieu rom...@fr.zoreil.com It must be tristate to avoid broken dependencies with kernel built-in usb network drivers when usb support is module only. When net config option is set, least

Re: [PATCH] rtl8150: Check if RSR is already defined

2014-08-06 Thread David Miller
From: Nick Krause xerofoi...@gmail.com Date: Thu, 7 Aug 2014 07:24:54 +0200 I am getting the following warn drivers/net/usb/rtl8150.c:30:0: warning: RSR redefined arch/xtensa/include/asm/processor.h:189:0: note: this is the location of the previous definition I wanted to remove RSR as

Re: [PATCH] net/usb/hso: Add support for Option GTM671WFS

2014-08-05 Thread David Miller
From: Ricardo Ribalda Delgado ricardo.riba...@gmail.com Date: Mon, 4 Aug 2014 11:11:49 +0200 After this patch: [ 32.985530] hso: drivers/net/usb/hso.c: Option Wireless [ 33.000452] hso 2-1.4:1.7: Not our interface [ 33.001849] usbcore: registered new interface driver hso

Re: [PATCH net-next 1/1] net: reduce USB network driver config options.

2014-08-05 Thread David Miller
From: Francois Romieu rom...@fr.zoreil.com Date: Tue, 5 Aug 2014 23:10:52 +0200 From: Francois Romieu rom...@fr.zoreil.com USB network drivers are already handled in drivers/net/usb/Kconfig. Let's save the maintenance burden of dependencies in drivers/net/Makefile. The newly introduced

Re: [PATCH 1/1] AX88179_178A: Add ethtool ops for EEE support

2014-07-31 Thread David Miller
From: fre...@asix.com.tw Date: Thu, 31 Jul 2014 19:06:35 +0800 From: Freddy Xin fre...@asix.com.tw Add functions to support ethtool EEE manipulating, and the EEE is disabled in default setting to enhance the compatibility with certain switch. Signed-off-by: Freddy Xin fre...@asix.com.tw

Re: [PATCH net] r8152: fix the checking of the usb speed

2014-07-25 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Thu, 24 Jul 2014 16:37:43 +0800 When the usb speed of the RTL8152 is not high speed, the USB_DEV_STAT[2:1] should be equal to [0 1]. That is, the STAT_SPEED_FULL should be equal to 2. There is a easy way to check the usb speed by the speed field

Re: [PATCH net,stable] net: qmi_wwan: add two Sierra Wireless/Netgear devices

2014-07-17 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Thu, 17 Jul 2014 13:33:51 +0200 Add two device IDs found in an out-of-tree driver downloadable from Netgear. Signed-off-by: Bjørn Mork bj...@mork.no Applied and queued up for -stable. -- To unsubscribe from this list: send the line unsubscribe linux-usb

Re: [PATCH net,stable] net: huawei_cdc_ncm: add subclass 3 devices

2014-07-17 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Thu, 17 Jul 2014 13:34:09 +0200 Huawei's usage of the subclass and protocol fields is not 100% clear to us, but there appears to be a very strict system. A device with the shared device ID 12d1:1506 and this NCM function was recently reported (showing

Re: [PATCH v2 2/2] hso: fix deadlock when receiving bursts of data

2014-07-14 Thread David Miller
() which is called by the urb completion handler. If there isn't enough room in the tty buffer, discards all the data received in the URB. Cc: David Miller da...@davemloft.net Cc: David Laight david.lai...@aculab.com Cc: One Thousand Gnomes gno...@lxorguk.ukuu.org.uk Cc: Dan Williams d

Re: [PATCH v2 1/2] hso: remove unused workqueue

2014-07-14 Thread David Miller
From: Olivier Sobrie oliv...@sobrie.be Date: Mon, 14 Jul 2014 12:08:49 +0200 The workqueue retry_unthrottle_workqueue is not scheduled anywhere in the code. So, remove it. Signed-off-by: Olivier Sobrie oliv...@sobrie.be Applied. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v2 2/2] hso: fix deadlock when receiving bursts of data

2014-07-11 Thread David Miller
When posting new versions of patches, you must resubmit the entire series, not just the patch which is changing. Thank you. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH net] r8152: fix r8152_csum_workaround function

2014-07-11 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Fri, 11 Jul 2014 16:48:27 +0800 The transport offset of the IPv4 packet should be fixed and wouldn't be out of the hw limitation, so the r8152_csum_workaround() should be used for IPv6 packets. Signed-off-by: Hayes Wang hayesw...@realtek.com

Re: [PATCH] usbnet: smsc95xx: add reset_resume function with reset operation

2014-07-10 Thread David Miller
From: Joonyoung Shim jy0922.s...@samsung.com Date: Thu, 10 Jul 2014 11:49:42 +0900 The smsc95xx needs to resume with reset operation. Otherwise it causes system hang by network error like below after resume. This case appears on odroid u3 board. [9.727600] smsc95xx 1-2:1.0 eth0: kevent

Re: [PATCH net-next v2] r8152: support jumbo frame for RTL8153

2014-07-10 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Thu, 10 Jul 2014 10:58:54 +0800 The maximum jumbo frame size for RTL8153 is 9K bytes. Change the max rx packet size to 9K. Change the use of the shared fifo from 6K (default) to 12K for tx. Signed-off-by: Hayes Wang hayesw...@realtek.com

Re: [PATCH net-next] r8152: support jumbo frame for RTL8153

2014-07-09 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Wed, 9 Jul 2014 16:07:02 +0800 +static int rtl8152_change_mtu(struct net_device *dev, int new_mtu) +{ + struct r8152 *tp = netdev_priv(dev); + + if (dev-mtu == new_mtu) + return 0; This method will never be invoked if the MTU

Re: [PATCH net-next] r8152: increase the tx timeout

2014-07-08 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Thu, 3 Jul 2014 11:55:48 +0800 When the system is too busy to complete the urb, the tx timout function would be called. This causes the other tx urbs would be killed, too. Increase the tx timeout to avoid it. Signed-off-by: Hayes Wang

Re: [PATCH 2/2] hso: fix deadlock when receiving bursts of data

2014-07-08 Thread David Miller
From: Olivier Sobrie oliv...@sobrie.be Date: Mon, 7 Jul 2014 11:06:07 +0200 When the module sends bursts of data, sometimes a deadlock happens in the hso driver when the tty buffer doesn't get the chance to be flushed quickly enough. To avoid this, first, we remove the endless while loop

Re: [PATCH net] r8152: wake up the device before dumping the hw counter

2014-07-08 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Tue, 8 Jul 2014 14:49:28 +0800 The device should be waked up from runtime suspend before dumping the hw counter. Signed-off-by: Hayes Wang hayesw...@realtek.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] net: qmi_wwan: Add ID for Telewell TW-LTE 4G v2

2014-07-07 Thread David Miller
From: Bernd Wachter bernd.wach...@jolla.com Date: Tue, 01 Jul 2014 22:01:09 +0300 There's a new version of the Telewell 4G modem working with, but not recognized by this driver. Signed-off-by: Bernd Wachter bernd.wach...@jolla.com Applied and queued up for -stable, thanks. -- To

Re: [PATCH 1/1] Add support for GPIOs for SMSC LAN95xx chips.

2014-06-23 Thread David Miller
Please do not post updated patches in this way. Instead, make a new, fresh, list posting with a formal commit message and signoff just as you would otherwise properly submit a new change. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to

Re: [PATCH net,stable] net: huawei_cdc_ncm: increase command buffer size

2014-06-21 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Wed, 18 Jun 2014 14:21:24 +0200 Messages from the modem exceeding 256 bytes cause communication failure. The WDM protocol is strictly read on demand, meaning that we only poll for unread data after receiving a notification from the modem. Since we have

Re: [patch net-next 3/5] ipv6: consider net.ipv6.conf.all sysctls when making decisions

2014-06-11 Thread David Miller
From: Milos Vyletel milos.vyle...@gmail.com Date: Tue, 10 Jun 2014 13:49:35 -0400 On Tue, Jun 10, 2014 at 1:13 PM, Stephen Hemminger step...@networkplumber.org wrote: On Tue, 10 Jun 2014 12:19:11 -0400 Milos Vyletel milos.vyle...@gmail.com wrote: As it is right now net.ipv6.conf.all.* are

Re: [PATCH] net: qmi_wwan: interface #11 in Sierra Wireless MC73xx is not QMI

2014-06-02 Thread David Miller
From: Aleksander Morgado aleksan...@aleksander.es Date: Thu, 29 May 2014 13:51:36 +0200 This interface is unusable, as the cdc-wdm character device doesn't reply to any QMI command. Also, the out-of-tree Sierra Wireless GobiNet driver fully skips it. Signed-off-by: Aleksander Morgado

Re: [PATCH] net: qmi_wwan: add additional Sierra Wireless QMI devices

2014-06-02 Thread David Miller
From: Aleksander Morgado aleksan...@aleksander.es Date: Thu, 29 May 2014 13:44:45 +0200 A set of new VID/PIDs retrieved from the out-of-tree GobiNet/GobiSerial Sierra Wireless drivers. Signed-off-by: Aleksander Morgado aleksan...@aleksander.es Applied. -- To unsubscribe from this list: send

Re: [PATCH v2 net-next 0/8] cdc_ncm: fixes and conversion to sysfs API

2014-06-02 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Fri, 30 May 2014 09:31:02 +0200 After considering the comments received after the ethtool coalesce support was commited, I have ended up concluding that we should remove it again, while we can, before it hits a release. The idea was not well enough thought

Re: [PATCH] net: qmi_wwan: add Netgear AirCard 341U

2014-06-01 Thread David Miller
From: Aleksander Morgado aleksan...@aleksander.es Date: Wed, 28 May 2014 21:05:03 +0200 Signed-off-by: Aleksander Morgado aleksan...@aleksander.es Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 14/18] r8152: Use kmemdup instead of kmalloc + memcpy

2014-05-30 Thread David Miller
From: Benoit Taine benoit.ta...@lip6.fr Date: Mon, 26 May 2014 17:21:23 +0200 This issue was reported by coccicheck using the semantic patch at scripts/coccinelle/api/memdup.cocci Signed-off-by: Benoit Taine benoit.ta...@lip6.fr --- Tested by compilation without errors. Applied to

Re: [PATCH net-next 0/8] cdc_ncm: fixes and conversion to sysfs API

2014-05-29 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Thu, 29 May 2014 11:59:07 +0200 I see that this series is now marked Not Applicable in patchwork. But the reason is not obvious to me. May I ask why? I meant to mark it as Changes Requested, because patch 8 had some feedback that you said you'd address. --

Re: skbuff truesize incorrect.

2014-05-27 Thread David Miller
From: David Laight david.lai...@aculab.com Date: Tue, 27 May 2014 15:23:14 + True, you still need to sort out how to handle multiple ethernet frames in the same 4k page, and arbitrary page boundaries within a frame. Multiple ethernet frames in the same 4K page is used by several ethernet

Re: skbuff truesize incorrect.

2014-05-23 Thread David Miller
From: Jim Baxter jim_bax...@mentor.com Date: Fri, 23 May 2014 10:21:19 +0100 On 22/05/14 21:58, David Miller wrote: From: Jim Baxter jim_bax...@mentor.com Date: Thu, 22 May 2014 21:21:55 +0100 If there are multiple clones for an skb all pointing at the same data, will that distort

Re: skbuff truesize incorrect.

2014-05-23 Thread David Miller
From: David Laight david.lai...@aculab.com Date: Fri, 23 May 2014 08:52:13 + The hardware will put multiple ethernet frames into a single USB bulk data message. To handle this the driver generates a URB that is (hopefully) long enough for the longest USB message (typically 32k is assumed

Re: skbuff truesize incorrect.

2014-05-22 Thread David Miller
From: Jim Baxter jim_bax...@mentor.com Date: Thu, 22 May 2014 20:07:41 +0100 My questions are: 1) Which buffer size does truesize represent, is it the total buffer or just the data related to the relevant skb? 2) If truesize is for the skb it is contained within should it be updated

Re: skbuff truesize incorrect.

2014-05-22 Thread David Miller
From: Jim Baxter jim_bax...@mentor.com Date: Thu, 22 May 2014 21:21:55 +0100 If there are multiple clones for an skb all pointing at the same data, will that distort the memory used when they all have the same truesize? What is distorted about it? Each clone references exactly that much

Re: skbuff truesize incorrect.

2014-05-22 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Thu, 22 May 2014 14:03:21 -0700 On Thu, 2014-05-22 at 13:58 -0700, Eric Dumazet wrote: I would set rx_max (rx_urb_size) to SKB_MAX_HEAD(0) so that you do not use high order allocations. Correction, that would need SKB_MAX_HEAD(NET_SKB_PAD +

Re: [PATCH net-next] net: cdc_ncm: fix 64bit division build error

2014-05-20 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Mon, 19 May 2014 09:21:09 +0200 The upper timer_interval limit is arbitrary and much higher than anything usable in the real world. Reducing it from 15s to ~4s to make the timer_interval fit in an u32 does not make much difference. The limit is still

Re: [PATCH net-next v2 00/12] cdc_ncm: add buffer tuning and stats using ethtool

2014-05-18 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Sun, 18 May 2014 16:50:30 +0200 I could be wrong, but my impression is that the userspace API preferences for network devices are 1. ethtool 2. sysfs 3. module param .. 99. ioctl I would swap module param and ioctl, module params are the least

Re: [PATCH net-next v2 00/12] cdc_ncm: add buffer tuning and stats using ethtool

2014-05-16 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Fri, 16 May 2014 21:48:17 +0200 Quoting the previous description of this series (skip to the changelog below if you only want a summary of the changes): Ok I'm fine with this, applied to net-next. Just make doubly sure that you will be ok, for a long time,

Re: [PATCH] [resend] net: get rid of SET_ETHTOOL_OPS

2014-05-13 Thread David Miller
From: Wilfried Klaebe w-l...@lebenslange-mailadresse.de Date: Sun, 11 May 2014 00:12:32 + net: get rid of SET_ETHTOOL_OPS Dave Miller mentioned he'd like to see SET_ETHTOOL_OPS gone. This does that. Mostly done via coccinelle script: @@ struct ethtool_ops *ops; struct net_device

Re: [PATCH net-next v2 0/4] cdc_mbim: cleanups and new features

2014-05-13 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Sun, 11 May 2014 10:47:11 +0200 This series depends on commit 6b5eeb7f874b (net: cdc_mbim: handle unaccelerated VLAN tagged frames), which is currently in net but not yet in net-next. Series applied, thanks a lot. -- To unsubscribe from this list: send the

Re: [PATCH 1/1] Add support for GPIOs for SMSC LAN95xx chips.

2014-05-13 Thread David Miller
From: Evgeny Boger bo...@contactless.ru Date: Sun, 11 May 2014 17:34:14 +0400 There might be 11 GPIOs in total. Last three GPIOs (offsets 8-11, 0-based) are shared with FDX, LNKA, SPD LEDs respectively. The LEDs are driven by chip by default at startup time. Once the corresponding GPIO is

Re: [PATCH net,stable] net: cdc_mbim: handle unaccelerated VLAN tagged frames

2014-05-09 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Fri, 9 May 2014 14:45:00 +0200 This driver maps 802.1q VLANs to MBIM sessions. The mapping is based on a bogus assumption that all tagged frames will use the acceleration API because we enable NETIF_F_HW_VLAN_CTAG_TX. This fails for e.g. frames tagged in

Re: [PATCH net,stable v2] net: cdc_mbim: __vlan_find_dev_deep need rcu_read_lock

2014-05-07 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Sat, 3 May 2014 16:12:47 +0200 Fixes this warning introduced by commit 5b8f15f78e6f (net: cdc_mbim: handle IPv6 Neigbor Solicitations): === [ INFO: suspicious RCU usage. ] 3.15.0-rc3 #213 Tainted: GW O

Re: [PATCH net,stable] net: cdc_ncm: fix buffer overflow

2014-05-05 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Fri, 2 May 2014 23:27:00 +0200 Commit 4d619f625a60 (net: cdc_ncm: no point in filling up the NTBs if we send ZLPs) changed the padding logic for devices with the ZLP flag set. This meant that frames of any size will be sent without additional padding,

Re: [PATCH net,stable 0/7] qmi_wwan: adding a few new devices

2014-04-27 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Fri, 25 Apr 2014 19:00:27 +0200 Adding some new and some old QMI devices. A similar series for usb-serial support will be posted as well. These new device ID patches should also go to all maintained stable kernels where they apply. I believe that should

Re: [PATCH net] r8152: check RTL8152_UNPLUG

2014-04-12 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Fri, 11 Apr 2014 17:54:31 +0800 When the device is unplugged, the driver would try to disable the device. Add checking the flag of RTL8152_UNPLUG to skip setting the device when it is unplugged. This could shorten the time of unloading the driver.

Re: [PATCH net-next v4 0/2] adjust MTU as indicated by MBIM extended functional descriptor

2014-03-20 Thread David Miller
pointed out by Bjørn Mork bj...@mork.no v3: No code changes. Resubmitted to include patch 1/2 as suggested by David Miller da...@davemloft.net v4: No code changes. Resubmitted as suggested by David Miller: - Added a summary of the patch set - Carried the ACK from Greg Kroah-Hartman

Re: [PATCH 2/2] net: cdc_ncm: respect operator preferred MTU reported by MBIM

2014-03-19 Thread David Miller
From: Ben Chan benc...@chromium.org Date: Mon, 17 Mar 2014 21:00:06 -0700 On Mon, Mar 17, 2014 at 6:41 PM, David Miller da...@davemloft.net wrote: From: Ben Chan benc...@chromium.org Date: Mon, 17 Mar 2014 17:46:27 -0700 Thanks again for the review and tip. I've submitted patch v2

Re: [PATCH v3 1/2] USB: cdc: add MBIM extended functional descriptor structure

2014-03-19 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Tue, 18 Mar 2014 09:35:57 +0100 Or will patchwork keep track of tags across different patch versions? It doesn't, and should not. It has no idea if the patch changed or not, the ACK'er might not still agree with the patch if any changes were made. -- To

Re: [PATCH net,stable] net: cdc_ncm: fix control message ordering

2014-03-18 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Mon, 17 Mar 2014 16:25:18 +0100 This is a context modified revert of commit 6a9612e2cb22 (net: cdc_ncm: remove ncm_parm field) which introduced a NCM specification violation, causing setup errors for some devices. These errors resulted in the device and

Re: [PATCH 2/2] net: cdc_ncm: respect operator preferred MTU reported by MBIM

2014-03-17 Thread David Miller
From: Ben Chan benc...@chromium.org Date: Mon, 17 Mar 2014 17:46:27 -0700 Thanks again for the review and tip. I've submitted patch v2 to address the le16_to_cpu conversion. When you update a patch from a series, you should repost the entire patch set, rather than just the patch which changes.

Re: [PATCH net-next v3 1/2] r8152:addRTL8152_EARLY_AGG_TIMEOUT_SUPER

2014-03-14 Thread David Miller
From: hayeswang hayesw...@realtek.com Date: Fri, 14 Mar 2014 15:24:50 +0800 Besides, I don't wish to modify the setting by ethtool when re-loading the driver or rebooting every time. You have code to reset the driver, you can do it when the user asks for the setting to be changed via ethtool.

Re: [PATCH net-next v3 1/2] r8152: add RTL8152_EARLY_AGG_TIMEOUT_SUPER

2014-03-13 Thread David Miller
From: David Laight david.lai...@aculab.com Date: Thu, 13 Mar 2014 13:12:35 + From: Hayes Wang ... I should have spotted this before. /* USB_RX_EARLY_AGG */ -#define EARLY_AGG_SUPPER0x0e832981 +#define EARLY_AGG_SUPER rx_buf_sz - 1522) / 4) 16) | \ +

Re: [PATCH net-next v3 1/2] r8152: addRTL8152_EARLY_AGG_TIMEOUT_SUPER

2014-03-13 Thread David Miller
From: hayeswang hayesw...@realtek.com Date: Fri, 14 Mar 2014 10:37:21 +0800 From: David Miller [mailto:da...@davemloft.net] Sent: Friday, March 14, 2014 1:22 AM [...] And I fundamentally disagree with this being a Kconfig parameter. Make it run-time calculated _or_ settable via ethtool

Re: [PATCH net-next 8/9] lg-vl600: Convert uses of __constant_foo to foo

2014-03-12 Thread David Miller
From: Joe Perches j...@perches.com Date: Wed, 12 Mar 2014 10:22:37 -0700 The use of __constant_foo has been unnecessary for quite awhile now. Make these uses consistent with the rest of the kernel. Signed-off-by: Joe Perches j...@perches.com Applied. -- To unsubscribe from this list: send

Re: [PATCH net-next] r8152: support dumping the hw counters

2014-03-11 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Tue, 11 Mar 2014 16:24:19 +0800 Add dumping the tally counter by ethtool. Signed-off-by: Hayes Wang hayesw...@realtek.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to

Re: [PATCH net-next] r8152: add skb_cow_head

2014-03-10 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Mon, 10 Mar 2014 14:22:31 +0800 Call skb_cow_head() before editing the tx packet header. The header would be reallocated if it is shared. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 13 +++-- 1 file

Re: [PATCH net-next v2 10/13] r8152: support IPv6

2014-03-09 Thread David Miller
From: Ben Hutchings b...@decadent.org.uk Date: Sun, 09 Mar 2014 19:47:55 + On Wed, 2014-03-05 at 14:49 +0800, Hayes Wang wrote: Support hw IPv6 checksum for TCP and UDP packets. Note that the hw has the limitation of the range of the transport offset. Besides, the TCP Pseudo Header of

Re: [PATCH net-next 0/7] r8152: tx/rx improvement

2014-03-07 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Fri, 7 Mar 2014 11:04:33 +0800 - Select the suitable spin lock for each function. - Add additional check to reduce the spin lock. - Up the priority of the tx to avoid interrupted by rx. - Support rx checksum, large send, and IPv6 hw checksum.

<    1   2   3   4   5   6   7   >