sing private registers in XHCI register
>> space. After the PHY is reset we check for the PLL lock status and retry
>> the operation if it fails. From our tests, retrying 4 times is
>> sufficient.
>>
>> Add a new quirk flag XHCI_RESET_PLL_ON_DISCONNECT to invok
g XHCI_RESET_PLL_ON_DISCONNECT to invoke the
>> workaround
>> in handle_xhci_port_status().
>>
>> Signed-off-by: George Cherian
>> ---
>> drivers/usb/host/xhci-pci.c | 5 +
>> drivers/usb/host/xhci-ring.c | 35 ++-
>> d
Hi Alan,
Thanks for the review.
I will update the patch accordingly and send out v2.
On 10/28/2018 10:48 PM, Alan Stern wrote:
>
> On Sat, 27 Oct 2018, Cherian, George wrote:
>
>> Implement workaround for ThunderX2 Errata-129 (documented in
>> CN99XX Known Issues" available at Cavium support s
Hi Alan,
On Tuesday 27 December 2016 08:50 PM, Alan Stern wrote:
On Tue, 27 Dec 2016, Oliver Neukum wrote:
On Thu, 2016-12-22 at 17:44 -0500, Alan Stern wrote:
I don't see how this patch fixes anything. Unless I'm mistaken, it
just avoids the problem by preventing the system from issuing th
Hi Alan,
On Friday 23 December 2016 04:14 AM, Alan Stern wrote:
On Wed, 21 Dec 2016, George Cherian wrote:
Hi Oliver,
I was working with this JMicron device and using the uas driver.
I am seeing the following 2 issues.
1) On connect I see the following messages.
xhci_hcd :00:11.0
=
On Thursday 22 December 2016 07:34 AM, George Cherian wrote:
Hi Oliver,
I will try it out and update you!!
Regards,
-George
On Wednesday 21 December 2016 08:09 PM, Oliver Neukum wrote:
On Wed, 2016-12-21 at 18:17 +0530, George Cherian wrote
Hi Oliver,
I will try it out and update you!!
Regards,
-George
On Wednesday 21 December 2016 08:09 PM, Oliver Neukum wrote:
On Wed, 2016-12-21 at 18:17 +0530, George Cherian wrote:
[ 843.149653] scsi host5: uas_post_reset: alloc streams error -19
after
reset
That would mean the endpoints
On 12/21/2016 05:12 PM, Oliver Neukum wrote:
On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote:
Hi Oliver,
I was working with this JMicron device and using the uas driver.
I am seeing the following 2 issues.
1) On connect I see the following messages.
Thanks. Do you want to submit
On 12/21/2016 05:50 PM, Hans de Goede wrote:
Hi,
On 21-12-16 13:07, George Cherian wrote:
On 12/21/2016 05:12 PM, Oliver Neukum wrote:
On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote:
Hi Oliver,
I was working with this JMicron device and using the uas driver.
I am seeing the
ing
The same error is not seen when it is added to unusual_device
list with US_FL_NO_REPORT_OPCODES passed.
Signed-off-by: George Cherian
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/storage/unusual_uas.h
b/drivers/usb/stor
Hi Robert,
+Roger
On Thu, Mar 19, 2015 at 5:37 PM, Robert Baldyga wrote:
> Hi George,
>
> On 03/19/2015 09:50 AM, George Cherian wrote:
>> Hi Robert,
>>
>> This looks like a extcon driver based on gpio for USB.
>>
>> Roger posted a generic one a while back
Hi Robert,
This looks like a extcon driver based on gpio for USB.
Roger posted a generic one a while back.
https://lkml.org/lkml/2015/2/2/187
Doesn't this serve the purpose rather than adding this driver?
-George
On Wed, Mar 18, 2015 at 7:34 PM, Robert Baldyga wrote:
> This patch adds extcon
Hi Robert,
On Wed, Mar 18, 2015 at 7:34 PM, Robert Baldyga wrote:
>
> This patch introduces OTG support in DWC3 driver. OTG feature is responsible
> for dynamic USB role switching (between host and peripheral modes) based
> on detected cable type.
>
> Each role switch causes complete core reinit
On 02/12/2015 11:52 PM, Felipe Balbi wrote:
On Thu, Feb 12, 2015 at 11:13:16AM +0530, George Cherian wrote:
>In the wrapper the IRQ disable should be done by writing 1's to the
>IRQ*_CLR register. Existing code is broken because it instead writes
>zeros to IRQ*_SET register.
Fixes: 72246da40f37 ("usb: Introduce DesignWare USB3 DRD Driver")
Cc: # v3.2+
Signed-off-by: George Cherian
---
drivers/usb/dwc3/dwc3-omap.c | 30 --
1 file changed, 28 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dw
ff-by: George Cherian
---
drivers/usb/dwc3/dwc3-omap.c | 30 --
1 file changed, 28 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index 172d64e..52e0c4e 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b/drivers/usb
Hi Tony,
On 02/06/2015 10:53 PM, Tony Lindgren wrote:
* George Cherian [150206 05:05]:
Hi Tony,
You also need to add similar things in dsps_musb_reset();
Otherwise you might not recover from a BABBLE condition.
Thank I totally missed that, updated patch below.
Do you have some testcase
Hi Tony,
You also need to add similar things in dsps_musb_reset();
Otherwise you might not recover from a BABBLE condition.
On 02/05/2015 10:05 PM, Tony Lindgren wrote:
We still have a combination of legacy phys and generic phys in
use so we need to support both types of phy for musb_dsps.c.
preserve the already allocated xhci struct for the subsequent
call of usb_add_hcd() from the DRD library.
A new quirk flag XHCI_DRD_SUPPORT is added to differentiate between
normal usb_remove_hcd and drd specific call.
Signed-off-by: George Cherian
---
drivers/usb/host/xhci.c | 22
Extend the platform data to pass XHCI_DRD_SUPPORT quirk to the xhci driver.
Signed-off-by: George Cherian
---
drivers/usb/host/xhci-plat.c | 4
include/linux/usb/xhci_pdriver.h | 1 +
2 files changed, 5 insertions(+)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci
Felipe Balbi (2):
usb: dwc3: core: Adapt to named interrupts
arm: dts: am4372: Add named interrupt property for dwc3
George Cherian (17):
usb: common: drd-lib: Add DRD lib for USB.
usb: host xhci: fix up deallocation code
usb: host: xhci-plat: Add support to pass XHCI_DRD_SUPPORT quirk
IP specific low level start/stop
defined in ll_start/stop
Signed-off-by: George Cherian
---
drivers/usb/Kconfig | 15 ++
drivers/usb/common/Makefile | 1 +
drivers/usb/common/drd-lib.c | 346 +++
include/linux/usb/drd.h | 77 ++
4
OTG interrupt and wrapper is shared
Signed-off-by: George Cherian
---
drivers/usb/dwc3/dwc3-omap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index 172d64e..f99e2ca 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
d-off-by: George Cherian
---
drivers/usb/dwc3/host.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index dcb8ca0..257b5b5 100644
--- a/drivers/usb/dwc3/host.c
+++ b/drivers/usb/dwc3/host.c
@@ -53,6 +53,8 @@ int dwc3_host_init(struct dwc3
Extend the platform data to pass XHCI_NEEDS_LHC_RESET quirk to
the xhci driver.
Signed-off-by: George Cherian
---
drivers/usb/host/xhci-plat.c | 3 +++
include/linux/usb/xhci_pdriver.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci
Adapt the xhci-plat driver to use drd library functions.
In prepration to support DRD on dwc3.
Signed-off-by: George Cherian
---
drivers/usb/host/xhci-plat.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index
and Device modes, it's advbised to do
a LIGHT HC reset else the already configured global registers of the DWC3 IP
gets re-initialized.
Signed-off-by: George Cherian
---
drivers/usb/host/xhci.c | 5 +++--
drivers/usb/host/xhci.h | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
diff --
ed to
re-initialize the EVENT buffer registers for the Device mode to continue
work properly. dwc3_event_buffers_setup() is exported out from core.c via
wrapper dwc3_core_gadget_helper() which will be invoked from dwc3 otg driver.
Signed-off-by: George Cherian
---
drivers/usb/dwc3/core.
Add interrupt names so that the same can be used for OTG easily.
Signed-off-by: George Cherian
---
arch/arm/boot/dts/omap5.dtsi | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
index 256b7f6..a712ad9 100644
Add the Initial OTG driver for dwc3.
Currently support only
* ID based Role switching.
Signed-off-by: George Cherian
---
drivers/usb/dwc3/Makefile | 4 ++
drivers/usb/dwc3/core.c | 10 +---
drivers/usb/dwc3/core.h | 10
drivers/usb/dwc3/otg.c| 126
while switching roles between
HOST and DEVICE modes. If the usb_gadget is not released during
usb_del_gadget_udc,
the subsequent usb_add_gadget_udc would try to initialize an already initialized
kobject. To avoid this make sure we have an easily freeable object.
Signed-off-by: George Cherian
---
dr
Add OTG reggister defines to DWC3 core.h
Signed-off-by: George Cherian
---
drivers/usb/dwc3/core.h | 68 +
1 file changed, 68 insertions(+)
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 7fbe736..eb2e970 100644
--- a/drivers
From: Felipe Balbi
Add interrupt names so that the same can be used for OTG easily.
Signed-off-by: Felipe Balbi
Signed-off-by: George Cherian
---
arch/arm/boot/dts/am4372.dtsi | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/am4372
Adapt the dwc3 gadget to use drd library functions.
In prepration to support DRD on dwc3.
Signed-off-by: George Cherian
---
drivers/usb/dwc3/gadget.c | 128 --
1 file changed, 100 insertions(+), 28 deletions(-)
diff --git a/drivers/usb/dwc3/gadget.c
From: Felipe Balbi
Add support to use interrupt names,
Following are the interrupt names
Peripheral Interrupt - peripheral
HOST Interrupt - host
OTG Interrupt - otg
Signed-off-by: Felipe Balbi
Signed-off-by: George Cherian
---
drivers/usb/dwc3/core.c | 12
drivers/usb/dwc3
Add interrupt names so that the same can be used for OTG easily.
Signed-off-by: George Cherian
---
arch/arm/boot/dts/exynos5250.dtsi | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index f21b9aa
USB1 of am43x EPOS EVM, am437x GP EVM and am437x SK EVM can be used as OTG.
Enable the same.
Signed-off-by: George Cherian
---
arch/arm/boot/dts/am437x-gp-evm.dts | 2 +-
arch/arm/boot/dts/am437x-sk-evm.dts | 2 +-
arch/arm/boot/dts/am43x-epos-evm.dts | 2 +-
3 files changed, 3 insertions
Add interrupt names so that the same can be used for OTG easily.
Signed-off-by: George Cherian
---
arch/arm/boot/dts/dra7.dtsi | 28
1 file changed, 24 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index
On 11/14/2014 02:12 PM, Sebastian Andrzej Siewior wrote:
On 11/14/2014 09:24 AM, George Cherian wrote:
Disable the MUSB interrupts till MUSB is recovered fully from BABBLE
condition. There are chances that we could get multiple interrupts
till the time the babble recover work gets scheduled
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_core.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 3345c94..992c768 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb
3a4)
because platform_get_drvdata(glue->musb) returns a NULL pointer as long as the
device is not fully probed.
Signed-off-by: Sebastian Andrzej Siewior
Tested-by: George Cherian
---
drivers/usb/musb/musb_dsps.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/
Hi Matwey,
On 09/09/2014 01:58 PM, Matwey V. Kornilov wrote:
Hi,
Can you add a few printks around drivers/usb/musb/musb_cppi41.c to
further narrow down where the problem is ? I ran v3.17-rc1 on my
beaglebone black (a while back) and didn't have any issues.
Now I am rebuilding the kernel to se
Remove the x_major calculation logic from the wrapper revision register
to differentiate between OMAP5 and AM437x. This was done to find the
register offsets of wrapper register. Now that We do it using dt
compatible, remove the whole logic.
Signed-off-by: George Cherian
---
drivers/usb/dwc3
Move the extcon related code to its own function.
Improve code readability, decrease the dwc3_probe() size.
Signed-off-by: George Cherian
---
drivers/usb/dwc3/dwc3-omap.c | 65 ++--
1 file changed, 39 insertions(+), 26 deletions(-)
diff --git a/drivers
Move map offset to its own seperate function.
Improve code readability, decrease the dwc3_probe() size.
Signed-off-by: George Cherian
---
drivers/usb/dwc3/dwc3-omap.c | 33 -
1 file changed, 20 insertions(+), 13 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3
Move find and set the utmi mode to its own seperate function.
Improve code readability, decrease the dwc3_probe() size.
Signed-off-by: George Cherian
---
drivers/usb/dwc3/dwc3-omap.c | 44 +---
1 file changed, 25 insertions(+), 19 deletions(-)
diff --git
The series does some refactoring on dwc3_probe()
Patch 1 - Now that we use driver compatible for revision check, remove the
unnecessary logic.
Patch 2-4 - reduce the size of dwc3_probe()
George Cherian (4):
usb: dwc3: dwc3-omap: Remove x_major calculation from revision
register
usb
resetting the IP block. In preperation to add that support
its better to have a rest_done return for musb_platform_reset().
Signed-off-by: George Cherian
Tested-by: Bin Liu
---
drivers/usb/musb/musb_core.c | 10 ++
drivers/usb/musb/musb_core.h | 10 ++
drivers/usb/musb/musb_dsps.c
register reads 0x4 by default in newer silicon as opposed to 0
in old versions of AM335x. Based on this enable the sw babble
control logic.
Signed-off-by: George Cherian
Tested-by: Bin Liu
---
drivers/usb/musb/musb_dsps.c | 89 +---
drivers/usb/musb
-howto.txt
Signed-off-by: George Cherian
Tested-by: Bin Liu
---
drivers/usb/musb/musb_core.c | 15 ---
drivers/usb/musb/musb_core.h | 2 +-
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 0ad9551..c0ce09f
introduced in Patch#5 of v4.
v3 -> v4 : Fixes an issue in gagdet mode - BUS RESET should not
be handled as a BABBLE. Added a check for the same.(Patch #1)
Enable sw babble control properly (Patch #6)
v2 -> v3 : Modify musb_platform_reset() to return zero
BABBLE and RESET share the same interrupt. The interrupt
is considered to be RESET if MUSB is in peripheral mode and
as a BABBLE if MUSB is in HOST mode.
Handle babble condition iff MUSB is in HOST mode.
Signed-off-by: George Cherian
Tested-by: Bin Liu
---
drivers/usb/musb/musb_core.c | 2
Hi Torben,
On 6/24/2014 6:31 PM, Torben Hohn wrote:
On Wed, Jun 18, 2014 at 11:28:25AM +0200, Daniel Mack wrote:
Hi,
Hi Daniel,
I've been debugging issues with musb in host mode and both full-speed
and high-speed USB audio devices with cppi41 DMA mode enabled.
The effect that was observed w
On 6/20/2014 3:50 AM, Daniel Mack wrote:
Hi,
I've been debugging issues with musb in host mode and both full-speed
and high-speed USB audio devices with cppi41 DMA mode enabled.
The effect that was observed with full-speed devices was that CPU load
went up to 100% due to the dma channels dma_co
On 6/19/2014 4:54 PM, Tony Lindgren wrote:
* Daniel Mack [140619 03:51]:
On 06/19/2014 12:43 PM, Tony Lindgren wrote:
* Daniel Mack [140619 03:38]:
On 06/19/2014 12:31 PM, Tony Lindgren wrote:
* Daniel Mack [140619 03:10]:
On 06/19/2014 11:56 AM, Tony Lindgren wrote:
But that also raises
On 5/31/2014 5:35 AM, Paul Zimmerman wrote:
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Friday, May 30, 2014 4:42 PM
On Fri, May 23, 2014 at 11:39:24AM -0700, Paul Zimmerman wrote:
Newer DWC3 controllers can be built for USB 2.0-only mode, where
most of the USB 3.0 circuitry is left out. To
-howto.txt
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_core.c | 15 ---
drivers/usb/musb/musb_core.h | 2 +-
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 0ad9551..c0ce09f 100644
--- a/drivers/usb
BABBLE and RESET share the same interrupt. The interrupt
is considered to be RESET if MUSB is in peripheral mode and
as a BABBLE if MUSB is in HOST mode.
Handle babble condition iff MUSB is in HOST mode.
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_core.c | 2 +-
1 file changed, 1
Fixes an issue in gagdet mode - BUS RESET should not
be handled as a BABBLE. Added a check for the same.(Patch #1)
Enable sw babble control properly (Patch #6)
v2 -> v3 : Modify musb_platform_reset() to return zero on success.
George Cherian (5):
usb
For DSPS platform usb_phy_vbus(_off/_on) are NOPs.
So during musb_platform_reset() call usb_phy(_shutdown/_init)
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_dsps.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb
resetting the IP block. In preperation to add that support
its better to have a rest_done return for musb_platform_reset().
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_core.c | 10 ++
drivers/usb/musb/musb_core.h | 10 ++
drivers/usb/musb/musb_dsps.c | 3 ++-
3 files
register reads 0x4 by default in newer silicon as opposed to 0
in old versions of AM335x. Based on this enable the sw babble
control logic.
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_dsps.c | 89 +---
drivers/usb/musb/musb_regs.h | 7
2
On 5/23/2014 2:12 AM, Bin Liu wrote:
Hi George,
On Mon, May 19, 2014 at 11:32 PM, George Cherian wrote:
Hi Bin,
On 5/19/2014 9:24 PM, Bin Liu wrote:
Hi,
On Mon, May 19, 2014 at 8:39 AM, George Cherian
wrote:
BABBLE and RESET share the same interrupt. The interrupt
is considered to be
set it from musb_cppi41.c. If set, it will make the core do what the
DMA layer decided and complete the urb.
Signed-off-by: Daniel Mack
Since this is used only for rx, Can you name newly added dma flag as
rx_packet_done?
Other than that.
Acked-by: George Cherian
---
drivers/usb/musb/musb_
On 5/25/2014 7:28 PM, Sergei Shtylyov wrote:
Hello.
On 25-05-2014 12:36, Daniel Mack wrote:
The datasheet says that MUSB_TXCSR_FLUSHFIFO is only valid when
MUSB_CSR0_TXPKTRDY is set as well.
With this patch applied, the warning in this function does no longer
kick in when an USB soundcard i
On 5/23/2014 3:00 PM, Daniel Mack wrote:
On AM33xx platforms, unplugging a device in the middle of an active
transfer leads to a drop of MUSB_DEVCTL_HM in MUSB_DEVCTL before the
system is informed about a disconnect. This consequently makes the musb
core call the gadget code to handle the interru
On 5/23/2014 6:58 PM, Daniel Mack wrote:
On 05/23/2014 03:18 PM, George Cherian wrote:
On 5/23/2014 3:01 PM, Daniel Mack wrote:
Before accessing any of an endpoint's CSR registers, make sure the
correct endpoint is selected. Otherwise, data read from or written to
the registers is like
On 5/23/2014 3:01 PM, Daniel Mack wrote:
Before accessing any of an endpoint's CSR registers, make sure the
correct endpoint is selected. Otherwise, data read from or written to
the registers is likely to affect the wrong endpoint as long as the
connected device has more than one endpoint.
This,
On 5/23/2014 3:00 PM, Daniel Mack wrote:
Just a little cleanup that removes unnecessary casts.
Signed-off-by: Daniel Mack
Acked-by: George Cherian
---
drivers/usb/musb/musb_host.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/musb/musb_host.c b
On 5/23/2014 5:04 PM, Daniel Mack wrote:
Hi George,
Thanks for having a look!
On 05/23/2014 01:24 PM, George Cherian wrote:
On 5/23/2014 3:01 PM, Daniel Mack wrote:
The musb/cppi41 glue layer is capable of handling transactions that span
over more than one USB packet by reloading the DMA
On 5/23/2014 3:01 PM, Daniel Mack wrote:
The musb/cppi41 glue layer is capable of handling transactions that span
over more than one USB packet by reloading the DMA descriptors
partially. An urb is considered completed when either its transfer
buffer has been filled entirely (actual_length ==
tra
On 5/22/2014 5:28 PM, Sergei Shtylyov wrote:
Hello.
On 22-05-2014 10:29, George Cherian wrote:
Find whether we are running on newer silicon. The babble control
register reads 0x4 by default in newer silicon as opposed to 0
in old versions of AM335x. Based on this enable the sw babble
control
-howto.txt
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_core.c | 15 ---
drivers/usb/musb/musb_core.h | 2 +-
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index eff3c5c..8920b80 100644
--- a/drivers
e - BUS RESET should not
be handled as a BABBLE. Added a check for the same.(Patch #1)
Enable sw babble control properly (Patch #6)
v2 -> v3 : Modify musb_platform_reset() to return zero on success.
George Cherian (6):
usb: musb: core: Handle Babble condition on
Find whether we are running on newer silicon. The babble control
register reads 0x4 by default in newer silicon as opposed to 0
in old versions of AM335x. Based on this enable the sw babble
control logic.
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_dsps.c | 38
resetting the IP block. In preperation to add that support
its better to have a rest_done return for musb_platform_reset().
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_core.c | 10 ++
drivers/usb/musb/musb_core.h | 10 ++
drivers/usb/musb/musb_dsps.c | 3 ++-
3 files
Add sw_babble_control() logic to differentiate between transient
babble and real babble condition. Also add the SW babble control
register definitions.
Babble control register logic is implemented in the latest
revision of AM335x.
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_dsps.c
BABBLE and RESET share the same interrupt. The interrupt
is considered to be RESET if MUSB is in peripheral mode and
as a BABBLE if MUSB is in HOST mode.
Handle babble condition iff MUSB is in HOST mode.
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_core.c | 2 +-
1 file changed, 1
For DSPS platform usb_phy_vbus(_off/_on) are NOPs.
So during musb_platform_reset() call usb_phy(_shutdown/_init)
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_dsps.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb
Remove the x_major calculation logic from the wrapper revision register
to differentiate between OMAP5 and AM437x. This was done to find the
register offsets of wrapper register. Now that We do it using dt
compatible, remove the whole logic.
Signed-off-by: George Cherian
---
drivers/usb/dwc3
Move find and set the utmi mode to its own seperate function.
Improve code readability, decrease the dwc3_probe() size.
Signed-off-by: George Cherian
---
drivers/usb/dwc3/dwc3-omap.c | 44 +---
1 file changed, 25 insertions(+), 19 deletions(-)
diff --git
7e2a8746ff4fc811 ]---
Segmentation fault
Signed-off-by: George Cherian
---
drivers/usb/dwc3/dwc3-omap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index 7594535..b729cdb 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b
Move map offset to its own seperate function.
Improve code readability, decrease the dwc3_probe() size.
Signed-off-by: George Cherian
---
drivers/usb/dwc3/dwc3-omap.c | 33 -
1 file changed, 20 insertions(+), 13 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3
The dwc3 wrapper driver should not be fiddling with the core interrupts.
Disabling the core interrupts in prepare stops xhci from proper operation.
So remove disable/enable of core interrupts from prepare/complete.
Signed-off-by: George Cherian
---
drivers/usb/dwc3/dwc3-omap.c | 15
Move the extcon related code to its own function.
Improve code readability, decrease the dwc3_probe() size.
Signed-off-by: George Cherian
---
drivers/usb/dwc3/dwc3-omap.c | 65 ++--
1 file changed, 39 insertions(+), 26 deletions(-)
diff --git a/drivers
system sleep.
George Cherian (6):
usb: dwc3: dwc3-omap: Remove x_major calculation from revision
register
usb: dwc3: dwc3-omap: Add dwc3_omap_map_offset() function
usb: dwc3: dwc3-omap: Add dwc3_omap_set_utmi_mode() function
usb: dwc3: dwc3-omap: Add dwc3_omap_extcon_register function
Hi Bin,
On 5/19/2014 9:24 PM, Bin Liu wrote:
Hi,
On Mon, May 19, 2014 at 8:39 AM, George Cherian wrote:
BABBLE and RESET share the same interrupt. The interrupt
is considered to be RESET if MUSB is in peripheral mode and
as a BABBLE if MUSB is in HOST mode.
Handle babble condition iff MUSB
BABBLE and RESET share the same interrupt. The interrupt
is considered to be RESET if MUSB is in peripheral mode and
as a BABBLE if MUSB is in HOST mode.
Handle babble condition iff MUSB is in HOST mode.
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_core.c | 2 +-
1 file changed, 1
or the same.(Patch #1)
Enable sw babble control properly (Patch #6)
v2 -> v3 : Modify musb_platform_reset() to return zero on success.
George Cherian (6):
usb: musb: core: Handle Babble condition only in HOST mode
usb: musb: core: Convert babble recover work to delaye
-howto.txt
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_core.c | 15 ---
drivers/usb/musb/musb_core.h | 2 +-
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index eff3c5c..8920b80 100644
--- a/drivers
resetting the IP block. In preperation to add that support
its better to have a rest_done return for musb_platform_reset().
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_core.c | 38 +-
drivers/usb/musb/musb_core.h | 10 ++
drivers/usb/musb
Add sw_babble_control() logic to differentiate between transient
babble and real babble condition. Also add the SW babble control
register definitions.
Babble control register logic is implemented in the latest
revision of AM335x.
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_dsps.c
For DSPS platform usb_phy_vbus(_off/_on) are NOPs.
So during musb_platform_reset() call usb_phy(_shutdown/_init)
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_dsps.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb
Find whether we are running on newer silicon. The babble control
register reads 0x4 by default in newer silicon as opposed to 0
in old versions of AM335x. Based on this enable the sw babble
control logic.
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_dsps.c | 37
Hi Bin,
On 5/15/2014 8:49 PM, Bin Liu wrote:
George,
On Thu, May 15, 2014 at 1:28 AM, George Cherian wrote:
Hi Bin,
On 5/14/2014 10:13 PM, Bin Liu wrote:
George,
On Wed, May 14, 2014 at 9:34 AM, Bin Liu wrote:
George,
On Wed, May 14, 2014 at 12:37 AM, George Cherian
wrote:
On 5/14
system sleep.
George Cherian (6):
usb: dwc3: dwc3-omap: Remove x_major calculation from revision
register
usb: dwc3: dwc3-omap: Add dwc3_omap_map_offset() function
usb: dwc3: dwc3-omap: Add dwc3_omap_set_utmi_mode() function
usb: dwc3: dwc3-omap: Add dwc3_omap_extcon_register function
Remove the x_major calculation logic from the wrapper revision register
to differentiate between OMAP5 and AM437x. This was done to find the
register offsets of wrapper register. Now that We do it using dt
compatible, remove the whole logic.
Signed-off-by: George Cherian
---
drivers/usb/dwc3
Move map offset to its own seperate function.
Improve code readability, decrease the dwc3_probe() size.
Signed-off-by: George Cherian
---
drivers/usb/dwc3/dwc3-omap.c | 31 +++
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3
Move find and set the utmi mode to its own seperate function.
Improve code readability, decrease the dwc3_probe() size.
Signed-off-by: George Cherian
---
drivers/usb/dwc3/dwc3-omap.c | 44 +---
1 file changed, 25 insertions(+), 19 deletions(-)
diff --git
7e2a8746ff4fc811 ]---
Segmentation fault
Signed-off-by: George Cherian
---
drivers/usb/dwc3/dwc3-omap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index 131d75a..e4f681a 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b
1 - 100 of 251 matches
Mail list logo
