Re: [PATCH net-next 02/13] driver: net: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

Hi Dave Did you have a chance to look at this? Let me know how you want me to fix this. //govind On Mon, 11 Nov 2013, Govindarajulu Varadarajan wrote: On Mon, 4 Nov 2013, David Miller wrote: From: Govindarajulu Varadarajan govindarajul...@gmail.com Date: Sat, 2 Nov 2013 19:17:43 +0530

Re: [PATCH net-next 02/13] driver: net: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

On Mon, 4 Nov 2013, David Miller wrote: From: Govindarajulu Varadarajan govindarajul...@gmail.com Date: Sat, 2 Nov 2013 19:17:43 +0530 @@ -1030,10 +1030,8 @@ static void ni65_xmit_intr(struct net_device *dev,int csr0) } #ifdef XMT_VIA_SKB - if(p-tmd_skb[p

[PATCH net-next 13/13] scripts/checkpatch.pl: Add dev_kfree_skb*(NULL) check to checkpatch

Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 66cad50..e651b8a 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl

[PATCH net-next 05/13] driver: usb/gadget: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

dev_kfree_skb_irq is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/usb/gadget/f_phonet.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget

[PATCH net-next 09/13] driver: s390: remove unnecessary NULL check before dev_kfree_skb_any

dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/s390/net/claw.c | 6 ++ drivers/s390/net/ctcm_mpc.c | 6 ++ drivers/s390/net/qeth_core_main.c

[PATCH net-next 03/13] driver: atm: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

dev_kfree_skb_irq is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/atm/eni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c

[PATCH net-next 06/13] driver: net: remove unnecessary NULL check before dev_kfree_skb_any

dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/net/ethernet/amd/lance.c | 9 +++-- drivers/net/ethernet/atheros/alx/main.c | 6

[PATCH net-next 08/13] driver: isdn: remove unnecessary NULL check before dev_kfree_skb_any

dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/isdn/gigaset/ser-gigaset.c | 3 +-- drivers/isdn/hisax/hfc_usb.c | 6 ++ drivers/isdn/hisax/icc.c

[PATCH net-next 01/13] net: Check skb for NULL in dev_kfree_skb_irq

Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c index 0054c8c..63bd44d 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2146,7 +2146,7 @@ EXPORT_SYMBOL

[PATCH net-next 02/13] driver: net: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

dev_kfree_skb_irq is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/net/ethernet/amd/ni65.c | 6 ++ drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 10

[PATCH net-next 11/13] driver: usb: remove unnecessary NULL check before dev_kfree_skb_any

dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/usb/gadget/u_ether.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget

[PATCH net-next 04/13] driver: staging: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

dev_kfree_skb_irq is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/staging/slicoss/slicoss.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/slicoss

[PATCH net-next 07/13] driver: staging: remove unnecessary NULL check before dev_kfree_skb_any

dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/staging/rtl8187se/ieee80211/ieee80211_rx.c | 3 +-- drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c | 3

[PATCH net-next 10/13] driver: infiniband: remove unnecessary NULL check before dev_kfree_skb_any

dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/infiniband/hw/amso1100/c2.c | 6 ++ drivers/infiniband/hw/nes/nes_hw.c | 3 +-- 2 files changed, 3 insertions(+), 6

[PATCH net-next 12/13] driver: net: fix space before '(' and remove extra variable

Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/net/ethernet/sgi/ioc3-eth.c | 4 +--- drivers/net/usb/usbnet.c| 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/sgi/ioc3-eth.c b/drivers/net/ethernet/sgi/ioc3

[PATCH net-next 00/13] Protect dev_kfree_skb_irq from NULL and remove unnecessary NULL checks

either calls dev_kfree_skb_irq or dev_kfree_skb depending on where your code is running. dev_kfree_skb is NULL safe but dev_kfree_skb_irq is not. This patch fixes it. Govindarajulu Varadarajan (13): net: Check skb for NULL in dev_kfree_skb_irq driver: net: remove unnecessary skb NULL check before