Re: [PATCH 0/3] Enable EHCI-platform driver for use with ACPI

2015-08-13 Thread Graeme Gregory
it looks fine to me. Reviewed-by: Graeme Gregory graeme.greg...@linaro.org Jeremy Linton (3): Honor ACPI _CCA attribute setting Display a DMA error message Add ACPI bindings for the EHCI platform driver. drivers/usb/host/ehci-platform.c | 13 - include/acpi/acpi_bus.h

Re: [PATCH v3] USB: PHY: Palmas USB Transceiver Driver

2013-03-27 Thread Graeme Gregory
On 26/03/13 20:23, Stephen Warren wrote: On 03/26/2013 10:57 AM, Graeme Gregory wrote: On 26/03/13 16:22, Stephen Warren wrote: On 03/26/2013 03:27 AM, Graeme Gregory wrote: ... If we are tightly coupling as above then using platform_irq is an extra inefficiency. You both have to populate

Re: [PATCH v3] USB: PHY: Palmas USB Transceiver Driver

2013-03-26 Thread Graeme Gregory
On 26/03/13 06:03, Kishon Vijay Abraham I wrote: Hi, On Monday 25 March 2013 03:16 PM, Laxman Dewangan wrote: On Monday 25 March 2013 03:02 PM, Kishon Vijay Abraham I wrote: From: Graeme Gregory g...@slimlogic.co.uk This is the driver for the OTG transceiver built into the Palmas chip

Re: [PATCH v3] USB: PHY: Palmas USB Transceiver Driver

2013-03-26 Thread Graeme Gregory
On 26/03/13 09:12, Laxman Dewangan wrote: On Tuesday 26 March 2013 02:31 PM, Graeme Gregory wrote: On 26/03/13 06:03, Kishon Vijay Abraham I wrote: +static int palmas_usb_read(struct palmas *palmas, unsigned int reg, + unsigned int *dest) +{ + unsigned int addr

Re: [PATCH v3] USB: PHY: Palmas USB Transceiver Driver

2013-03-26 Thread Graeme Gregory
On 26/03/13 09:34, Laxman Dewangan wrote: On Tuesday 26 March 2013 02:57 PM, Graeme Gregory wrote: On 26/03/13 09:12, Laxman Dewangan wrote: On Tuesday 26 March 2013 02:31 PM, Graeme Gregory wrote: But still you are using the PALMAS macro here and indirectly it is tied up

Re: [PATCH v3] USB: PHY: Palmas USB Transceiver Driver

2013-03-26 Thread Graeme Gregory
On 26/03/13 16:22, Stephen Warren wrote: On 03/26/2013 03:27 AM, Graeme Gregory wrote: ... If we are tightly coupling as above then using platform_irq is an extra inefficiency. You both have to populate this then parse it afterwards. Why not just use the regmap helper? Ill admit this code