RE: [PATCH v5 02/11] usb: musb: kill global and static for multi instance

2012-07-26 Thread Gupta, Ajay Kumar
Hi > On Thu, Jul 26, 2012 at 12:46:43PM +0000, Gupta, Ajay Kumar wrote: > > Hi, > > > > > > On Wed, Jul 25, 2012 at 05:42:06PM +0530, Ajay Kumar Gupta wrote: > > > > > > > @@ -240,20 +238,24 @@ int __devinit musb_init_debugfs(struct > > >

RE: [PATCH v5 02/11] usb: musb: kill global and static for multi instance

2012-07-26 Thread Gupta, Ajay Kumar
Hi, > > > > On Wed, Jul 25, 2012 at 05:42:06PM +0530, Ajay Kumar Gupta wrote: > > > > > @@ -240,20 +238,24 @@ int __devinit musb_init_debugfs(struct musb > > *musb) > > > > > struct dentry *root; > > > > > struct dentry *file; > > > > > int

RE: [PATCH v5 04/11] usb: otg: nop: add support for multiple tranceiver

2012-07-26 Thread Gupta, Ajay Kumar
Hi, > On Thu, Jul 26, 2012 at 08:29:06AM +0000, Gupta, Ajay Kumar wrote: > > Hi, > > > On Thu, Jul 26, 2012 at 08:22:35AM +, Gupta, Ajay Kumar wrote: > > > > > > @@ -408,7 +408,7 @@ static int am35x_musb_exit(struct musb *musb) > >

RE: [PATCH v5 02/11] usb: musb: kill global and static for multi instance

2012-07-26 Thread Gupta, Ajay Kumar
Hi, > > > On Wed, Jul 25, 2012 at 05:42:06PM +0530, Ajay Kumar Gupta wrote: > > > > @@ -240,20 +238,24 @@ int __devinit musb_init_debugfs(struct musb > *musb) > > > > struct dentry *root; > > > > struct dentry *file; > > > > int ret; >

RE: [PATCH v5 04/11] usb: otg: nop: add support for multiple tranceiver

2012-07-26 Thread Gupta, Ajay Kumar
Hi, > On Thu, Jul 26, 2012 at 08:22:35AM +0000, Gupta, Ajay Kumar wrote: > > > > @@ -408,7 +408,7 @@ static int am35x_musb_exit(struct musb *musb) > > > > data->set_phy_power(0); > > > > > > > > usb_put_phy(

RE: [PATCH v5 02/11] usb: musb: kill global and static for multi instance

2012-07-26 Thread Gupta, Ajay Kumar
Hi, > On Wed, Jul 25, 2012 at 05:42:06PM +0530, Ajay Kumar Gupta wrote: > > @@ -240,20 +238,24 @@ int __devinit musb_init_debugfs(struct musb *musb) > > struct dentry *root; > > struct dentry *file; > > int ret; > > + charnam

RE: [PATCH v5 03/11] usb: musb: am335x: add support for dual instance

2012-07-26 Thread Gupta, Ajay Kumar
Hi, > On Wed, Jul 25, 2012 at 05:37:21PM +0530, Ajay Kumar Gupta wrote: > > AM335x and TI81xx platform has dual musb controller so updating the > > musb_dspc.c to support the same. > > > > Changes: > > - Moved otg_workaround timer to glue structure > > - Moved static local variable last_tim

RE: [PATCH v5 04/11] usb: otg: nop: add support for multiple tranceiver

2012-07-26 Thread Gupta, Ajay Kumar
Hi > On Wed, Jul 25, 2012 at 05:37:22PM +0530, Ajay Kumar Gupta wrote: > > diff --git a/drivers/usb/musb/am35x.c b/drivers/usb/musb/am35x.c > > index 01203eb..eb6220f 100644 > > --- a/drivers/usb/musb/am35x.c > > +++ b/drivers/usb/musb/am35x.c > > @@ -364,7 +364,7 @@ static int am35x_musb_init(stru

RE: [PATCH v5 01/11] usb: musb: add musb->id to identify core instance

2012-07-25 Thread Gupta, Ajay Kumar
Hi, > On Wed, Jul 25, 2012 at 12:30:12PM +0000, Gupta, Ajay Kumar wrote: > > Hi, > > > On Wed, Jul 25, 2012 at 12:19:32PM +, Gupta, Ajay Kumar wrote: > > > > Hi, > > > > > > > > > > On Wed, Jul 25, 2012 at 05:37:19PM +0530, Ajay

RE: [PATCH v5 01/11] usb: musb: add musb->id to identify core instance

2012-07-25 Thread Gupta, Ajay Kumar
Hi, > On Wed, Jul 25, 2012 at 12:19:32PM +0000, Gupta, Ajay Kumar wrote: > > Hi, > > > > > > On Wed, Jul 25, 2012 at 05:37:19PM +0530, Ajay Kumar Gupta wrote: > > > > diff --git a/drivers/usb/musb/musb_core.c > > > > b/drivers/usb/musb/musb

RE: [PATCH v5 01/11] usb: musb: add musb->id to identify core instance

2012-07-25 Thread Gupta, Ajay Kumar
Hi, > > On Wed, Jul 25, 2012 at 05:37:19PM +0530, Ajay Kumar Gupta wrote: > > diff --git a/drivers/usb/musb/musb_core.c > > b/drivers/usb/musb/musb_core.c index 89d1871..f5eb8a7 100644 > > --- a/drivers/usb/musb/musb_core.c > > +++ b/drivers/usb/musb/musb_core.c > > > > > @@ -1889,6 +1921,7 @@

RE: [PATCH v4 02/11] usb: musb: kill global and static for multi instance

2012-07-25 Thread Gupta, Ajay Kumar
Hi, > On Wed, Jul 25, 2012 at 10:34:49AM +0000, Gupta, Ajay Kumar wrote: > > Hi, > > > > > > On Thu, Jul 19, 2012 at 05:15:58PM +0530, Ajay Kumar Gupta wrote: > > > > Moved global variable "musb_debugfs_root" and static variable > > > >

RE: [PATCH] USB: musb: NAK timeout scheme on bulk TX endpoint

2012-07-25 Thread Gupta, Ajay Kumar
Hi, > > On Thu, Jul 19, 2012 at 01:41:59PM +0530, Ajay Kumar Gupta wrote: > > > Fixes endpoint starvation issue when more than one bulk QH is > > > multiplexed on the reserved bulk TX endpoint. > > > > > > This patch sets the NAK timeout interval for such QHs, and when > > > a timeout triggers the

RE: [PATCH v4 02/11] usb: musb: kill global and static for multi instance

2012-07-25 Thread Gupta, Ajay Kumar
Hi, > > On Thu, Jul 19, 2012 at 05:15:58PM +0530, Ajay Kumar Gupta wrote: > > Moved global variable "musb_debugfs_root" and static variable > > "old_state" to 'struct musb' to help support multi instance of musb > > controller as present on AM335x platform. > > > > Also removed the global variable

RE: [PATCH v4 01/11] usb: musb: add musb->id to identify core instance

2012-07-25 Thread Gupta, Ajay Kumar
Hi, > On Thu, Jul 19, 2012 at 05:15:57PM +0530, Ajay Kumar Gupta wrote: > > diff --git a/drivers/usb/musb/musb_core.c > > b/drivers/usb/musb/musb_core.c index 89d1871..3e09984 100644 > > --- a/drivers/usb/musb/musb_core.c > > +++ b/drivers/usb/musb/musb_core.c > > @@ -99,6 +99,7 @@ > > #include >

RE: [PATCH] USB: musb: NAK timeout scheme on bulk TX endpoint

2012-07-25 Thread Gupta, Ajay Kumar
Hi, > On Thu, Jul 19, 2012 at 01:41:59PM +0530, Ajay Kumar Gupta wrote: > > Fixes endpoint starvation issue when more than one bulk QH is > > multiplexed on the reserved bulk TX endpoint. > > > > This patch sets the NAK timeout interval for such QHs, and when > > a timeout triggers the next QH will

RE: [PATCH 4/4] usb: musb: gadget: do read_fifo for non zero data only

2012-07-19 Thread Gupta, Ajay Kumar
Hi, > On 07/19/2012 03:22 PM, Gupta, Ajay Kumar wrote: > > >>> There is no need to call read_fifo for zero byte length. > > >> The same as there's no need to write, and not only here? > > > Yes, it applies to write also but seems write is taken ca

RE: [PATCH v4 09/11] drivers: usb: musb: Add device tree support for omap musb glue

2012-07-19 Thread Gupta, Ajay Kumar
Hi, > Signed-off-by: Kishon Vijay Abraham I > --- > Documentation/devicetree/bindings/usb/omap-usb.txt | 34 - > drivers/usb/musb/omap2430.c| 55 > > 2 files changed, 88 insertions(+), 1 deletions(-) > > diff --git a/Documentation/devi

RE: [PATCH 4/4] usb: musb: gadget: do read_fifo for non zero data only

2012-07-19 Thread Gupta, Ajay Kumar
Hi, > On 19-07-2012 11:55, Ajay Kumar Gupta wrote: > > > There is no need to call read_fifo for zero byte length. > > The same as there's no need to write, and not only here? Yes, it applies to write also but seems write is taken care for zero byte length. > > > Signed-off-by: Ajay Kumar

RE: [PATCH v3 04/11] usb: otg: nop: add support for multiple tranceiver

2012-07-19 Thread Gupta, Ajay Kumar
Hi, > > Currently we have one single nop transceiver support as same is > > defined as a global variable in drivers/usb/otg/nop-usb-xceiv.c. > > This need to be changed to support multiple otg controller each > > using nop transceiver on a platform such as am335x. > > > > Signed-off-by: Ajay Kumar

RE: [PATCH v3 07/11] usb: otg: nop: add dt support

2012-07-19 Thread Gupta, Ajay Kumar
Hi, > > Added device tree support for nop transceiver driver and updated the > > Documentation with device tree binding information for am33xx platform. > > > > Signed-off-by: Ajay Kumar Gupta > > --- > > .../devicetree/bindings/usb/am33xx-usb.txt |3 +++ > > drivers/usb/otg/nop-usb-x

RE: [PATCH v2 06/11] arm/dts: am33xx: Add dt data for usbss

2012-07-18 Thread Gupta, Ajay Kumar
Hi > > On 17-07-2012 13:13, Ajay Kumar Gupta wrote: > > > > > Added device tree data for usbss on am33xx. There are two musb > > controllers > > > on am33xx platform so have port0_mode and port1_mode additional > data. > > > > > Signed-off-by: Ajay Kumar Gupta > > > --- > > > arch/arm/boot/dts/a

RE: [PATCH v2 06/11] arm/dts: am33xx: Add dt data for usbss

2012-07-18 Thread Gupta, Ajay Kumar
Hi, > On 17-07-2012 13:13, Ajay Kumar Gupta wrote: > > > Added device tree data for usbss on am33xx. There are two musb > controllers > > on am33xx platform so have port0_mode and port1_mode additional data. > > > Signed-off-by: Ajay Kumar Gupta > > --- > > arch/arm/boot/dts/am33xx.dtsi | 11

RE: [PATCH v2 08/11] arm/dts: am33xx: add dt data for usb nop phy

2012-07-18 Thread Gupta, Ajay Kumar
Hi, > > AM33xx has two musb controller and they have one NOP PHY each. > > Added the device tree data for NOP PHY. > > > Signed-off-by: Ajay Kumar Gupta > > --- > > arch/arm/boot/dts/am33xx.dtsi |8 > > 1 files changed, 8 insertions(+), 0 deletions(-) > > > diff --git a/arch/arm

RE: [PATCH v2 07/11] usb: otg: nop: add dt support

2012-07-17 Thread Gupta, Ajay Kumar
Hi, > > On 17-07-2012 13:13, Ajay Kumar Gupta wrote: > > > Added device tree support for nop transceiver driver and updated the > > Documentation with device tree binding information for am33xx > platform. > > > Signed-off-by: Ajay Kumar Gupta > > --- > > .../devicetree/bindings/usb/am33xx-us

RE: [PATCH v2 2/3] usb: musb: dsps: add phy control logic to glue

2012-07-11 Thread Gupta, Ajay Kumar
Hi, > On Wed, Jul 11, 2012 at 3:59 PM, Damodar Santhapuri > wrote: > > From: Ajay Kumar Gupta > > > > AM335x uses NOP transceiver driver and need to enable builtin PHY > > by writing into usb_ctrl register available in system control > > module register space. This is being added at musb glue dri

RE: [PATCH 2/3] usb: musb: dsps: add phy control logic to glue

2012-07-11 Thread Gupta, Ajay Kumar
Hi, > > > >> On Mon, Jul 9, 2012 at 7:18 PM, Damodar Santhapuri > [...] > > > >> Avoid getting resource by name.. With dt, you wont be able to do > > > >> those.. > > > > > > > > When we are completely on DT then this would anyways go and we > can > > > > get these resource data for each usb port

RE: [PATCH v1 09/11] drivers: usb: musb: Add device tree support for omap musb glue

2012-07-10 Thread Gupta, Ajay Kumar
Hi, > Documentation/devicetree/bindings/usb/omap-usb.txt | 34 > - > drivers/usb/musb/omap2430.c| 52 > [...] > + of_property_read_u32(np, "mode", (u32 *)&pdata->mode); > + of_property_read_u32(np, "interface_type"

RE: [PATCH 2/3] usb: musb: dsps: add phy control logic to glue

2012-07-09 Thread Gupta, Ajay Kumar
Hi, > On Tue, Jul 10, 2012 at 11:35 AM, Gupta, Ajay Kumar > wrote: > > Hi, > >> > >> On Mon, Jul 9, 2012 at 7:18 PM, Damodar Santhapuri > >> wrote: > >> > From: Ajay Kumar Gupta > >> > > >> > AM335x uses NOP transc

RE: [PATCH 2/3] usb: musb: dsps: add phy control logic to glue

2012-07-09 Thread Gupta, Ajay Kumar
Hi, > > On Mon, Jul 9, 2012 at 7:18 PM, Damodar Santhapuri > wrote: > > From: Ajay Kumar Gupta > > > > AM335x uses NOP transceiver driver and need to enable builtin PHY > > by writing into usb_ctrl register available in system control > > module register space. This is being added at musb glue d