Hi All,
Here is v2 of my patch-set to add support for the musb variant found on
Allwinner sunxi SoCs.
Changes since the original posting:
-Removed the sunxi specific phy functions, instead the id / vbus gpio polling
has been moved to the phy-sun4i-usb driver and their status is exported
on a cubietruck (A20 SoC) and an UTOO P66 tablet
(A13 SoC) with a variety of devices in host mode and with the g_serial gadget
driver in peripheral mode, plugging otg / host cables in/out a lot of times
in all possible imaginable plug orders.
Signed-off-by: Hans de Goede hdego...@redhat.com
Add a node for the otg/drc usb controller to sun5i-a1*.dtsi.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun5i.dtsi | 11 +++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/sun5i.dtsi b/arch/arm/boot/dts/sun5i.dtsi
index c3e11ec..eb5bce5
Enable the otg/drc usb controller on the Chuwi V7 CW0825 tablet.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts | 31 +
1 file changed, 31 insertions(+)
diff --git a/arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts
b
: Benjamin Tissoires benjamin.tissoi...@redhat.com
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/storage/unusual_uas.h
b/drivers/usb/storage
Hi,
On 11-03-15 10:13, Kishon Vijay Abraham I wrote:
Hi,
On Tuesday 10 March 2015 04:33 PM, Hans de Goede wrote:
Hi,
On 10-03-15 11:53, Kishon Vijay Abraham I wrote:
Hi,
On Tuesday 10 March 2015 03:43 PM, Hans de Goede wrote:
Hi,
On 10-03-15 09:57, Arnd Bergmann wrote:
On Tuesday 10
Hi,
On 11-03-15 13:50, Kishon Vijay Abraham I wrote:
Hi,
On Wednesday 11 March 2015 05:09 PM, Hans de Goede wrote:
Hi,
On 11-03-15 10:13, Kishon Vijay Abraham I wrote:
Hi,
On Tuesday 10 March 2015 04:33 PM, Hans de Goede wrote:
Hi,
On 10-03-15 11:53, Kishon Vijay Abraham I wrote:
Hi
Hi,
On 11-03-15 14:07, Kishon Vijay Abraham I wrote:
Hi,
On Wednesday 11 March 2015 06:33 PM, Hans de Goede wrote:
Hi,
On 11-03-15 13:50, Kishon Vijay Abraham I wrote:
Hi,
On Wednesday 11 March 2015 05:09 PM, Hans de Goede wrote:
Hi,
On 11-03-15 10:13, Kishon Vijay Abraham I wrote:
Hi
Hi,
On 10-03-15 09:57, Arnd Bergmann wrote:
On Tuesday 10 March 2015 09:04:43 Hans de Goede wrote:
Hi,
On 09-03-15 22:47, Arnd Bergmann wrote:
On Monday 09 March 2015 21:40:15 Hans de Goede wrote:
+void sun4i_usb_phy_update_iscr(struct phy *_phy, u32 clr, u32 set)
+{
+ struct
Hi,
On 10-03-15 11:53, Kishon Vijay Abraham I wrote:
Hi,
On Tuesday 10 March 2015 03:43 PM, Hans de Goede wrote:
Hi,
On 10-03-15 09:57, Arnd Bergmann wrote:
On Tuesday 10 March 2015 09:04:43 Hans de Goede wrote:
Hi,
On 09-03-15 22:47, Arnd Bergmann wrote:
On Monday 09 March 2015 21:40:15
Hi,
On 03/10/2015 04:07 PM, Maxime Ripard wrote:
Hi Hans,
On Mon, Mar 09, 2015 at 09:40:25PM +0100, Hans de Goede wrote:
Enable the otg/drc usb controller on the Chuwi V7 CW0825 tablet.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts
Hi,
On 09-03-15 22:50, Arnd Bergmann wrote:
On Monday 09 March 2015 21:40:18 Hans de Goede wrote:
The generic fifo functions already use non wrapped accesses in various
cases through the iowrite#_rep functions, and all platforms which override
the default musb_read[b|w] / _write[b|w] functions
Hi,
On 10-03-15 02:46, Chen-Yu Tsai wrote:
Hi Arnd,
On Tue, Mar 10, 2015 at 5:44 AM, Arnd Bergmann a...@arndb.de wrote:
On Monday 09 March 2015 21:40:13 Hans de Goede wrote:
Hi All,
This patch set has been a while in the making, so I'm very happy to present
the end result here, and I hope
Hi,
On 03/10/2015 06:41 PM, Maxime Ripard wrote:
On Mon, Mar 09, 2015 at 09:40:13PM +0100, Hans de Goede wrote:
Hi All,
This patch set has been a while in the making, so I'm very happy to present
the end result here, and I hope everyone likes it.
Before talking about merging this there are 2
Hi,
On 09-03-15 22:47, Arnd Bergmann wrote:
On Monday 09 March 2015 21:40:15 Hans de Goede wrote:
+void sun4i_usb_phy_update_iscr(struct phy *_phy, u32 clr, u32 set)
+{
+ struct sun4i_usb_phy *phy = phy_get_drvdata(_phy);
+ struct sun4i_usb_phy_data *data = to_sun4i_usb_phy_data
Hi,
On 10-03-15 09:50, Arnd Bergmann wrote:
On Tuesday 10 March 2015 08:43:22 Hans de Goede wrote:
On 09-03-15 22:50, Arnd Bergmann wrote:
On Monday 09 March 2015 21:40:18 Hans de Goede wrote:
The generic fifo functions already use non wrapped accesses in various
cases through the iowrite
Hi,
On 10-03-15 00:31, Julian Calaby wrote:
Hi Hans,
On Tue, Mar 10, 2015 at 7:40 AM, Hans de Goede hdego...@redhat.com wrote:
Add a node for the otg/drc usb controller to sun4i-a10.dtsi.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun4i-a10.dtsi | 12
Add sun4i_usb_phy_update_iscr() helper function to allow the otg driver to
update the sun4i usb phy0 Interface Status and Control Register.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/phy/phy-sun4i-usb.c | 13 +
include/linux/phy/phy-sun4i-usb.h | 26
From: Roman Byshko rbys...@gmail.com
Enable the otg/drc usb controller on the cubietruck.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 24
1 file changed, 24 insertions(+)
diff --git a/arch/arm/boot/dts/sun7i-a20
Enable the otg/drc usb controller on the A20-OLinuxIno-Lime.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun7i-a20-olinuxino-lime.dts | 29 ++
1 file changed, 29 insertions(+)
diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime.dts
b/arch
Enable the otg/drc usb controller on the Chuwi V7 CW0825 tablet.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts | 31 +
1 file changed, 31 insertions(+)
diff --git a/arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts
b
For some reason the musb_write_rxfun* and musb_write_rxhub* functions had
a different function prototype and some extra magic needed on the caller side
compared to their tx counterparts, this commit makes them work the same as
their tx counterparts.
Signed-off-by: Hans de Goede hdego
Add a node for the otg/drc usb controller to sun5i-a1*.dtsi.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun5i.dtsi | 12
1 file changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/sun5i.dtsi b/arch/arm/boot/dts/sun5i.dtsi
index 97b4eb1..cf730d4
musb-core was setting the ops to the default indexed or flat handlers after
checking for platform overrides. Reverse the order of this so that platform
overrides actually work.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/musb/musb_core.c | 13 ++---
1 file changed, 6
From: Roman Byshko rbys...@gmail.com
Add a node for the otg/drc usb controller to sun7i-a20.dtsi
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun7i-a20.dtsi | 12
1 file changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm
Enable the OTG controller on the UTOO P66 tablet.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun5i-a13-utoo-p66.dts | 23 +++
1 file changed, 23 insertions(+)
diff --git a/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts
b/arch/arm/boot/dts/sun5i-a13
on a cubietruck (A20 SoC) and an UTOO P66 tablet
(A13 SoC) with a variety of devices in host mode and with the g_serial gadget
driver in peripheral mode, plugging otg / host cables in/out a lot of times
in all possible imaginable plug orders.
Signed-off-by: Hans de Goede hdego...@redhat.com
Add a node for the otg/drc usb controller to sun4i-a10.dtsi.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun4i-a10.dtsi | 12
drivers/usb/musb/Kconfig | 1 +
2 files changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch
the fifo access functions.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/musb/musb_core.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index b71d310..47c1a0a 100644
--- a/drivers/usb/musb
Kuske jensku...@gmail.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun4i-a10.dtsi | 5 +
arch/arm/boot/dts/sun5i.dtsi | 5 +
arch/arm/boot/dts/sun7i-a20.dtsi | 5 +
3 files changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch
The Allwinner (sunxi) implementation of the musb has its busctl registers
indexed by the MUSB_INDEX register rather then in a flat address space.
This commit turns MUSB_BUSCTL_OFFSET from a macro into an io-op which can
be overridden from the platform ops.
Signed-off-by: Hans de Goede hdego
From: Chen-Yu Tsai w...@csie.org
Signed-off-by: Chen-Yu Tsai w...@csie.org
Signed-off-by: Jens Kuske jensku...@gmail.com
Acked-by: Lee Jones lee.jo...@linaro.org
Signed-off-by: Hans de Goede hdego...@redhat.com
---
include/linux/mfd/syscon/sun4i-sc.h | 42 +
1
Hi All,
This patch set has been a while in the making, so I'm very happy to present
the end result here, and I hope everyone likes it.
Before talking about merging this there are 2 things which I would like to
point out:
a) The musb controller in the sunxi SoCs uses some SRAM which needs to be
Like the JMicron JMS567 enclosures with the JMS539 choke on report-opcodes,
so avoid it.
Tested-and-reported-by: Tom Arild Naess tana...@gmail.com
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed
we want to fix:
Acked-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
[as1773]
drivers/usb/core/devio.c | 63
++
include/uapi/linux/usbdevice_fs.h |3 +
2 files changed, 39 insertions(+), 27 deletions(-)
Index: usb-3.19
Hi,
On 26-01-15 16:30, Zhuang Jin Can wrote:
This revert a82b76f7fa6154e8ab2d8071842a3e38b9c0d0ff.
The commit causes an extra reset in remote wakeup as described in:
http://www.spinics.net/lists/linux-usb/msg119080.html
Signed-off-by: Zhuang Jin Can jin.can.zhu...@intel.com
No objection
Like some other uas devices these devices hang when a report-opcodes scsi
command is send to them.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1124119
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 7 +++
1
To help debugging xhci problems.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/host/xhci.c | 4
drivers/usb/host/xhci.h | 2 ++
2 files changed, 6 insertions(+)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 01fcbb5..bb3e328 100644
--- a/drivers/usb
in this scenario to
detect this, and suppress the xHCI xhci_drop_endpoint called with disabled
ep ... message in this case.
Signed-off-by: Hans de Goede hdego...@redhat.com
--
Changes in v2:
Move the ring check to only guard the xhci_warn, so as to avoid side-effects
in case we have a scenario where
Hi Mathias,
These 2 patches which have been sitting in my personal tree for a while now
seem to have fallen through the cracks, hence this resend.
If you're simply just not interested in them let me know and I'll drop them.
Regards,
Hans
--
To unsubscribe from this list: send the line
descriptors are not 100% identical, unlike the previous
models the ASM1153 has bMaxPower == 0, so use that to differentiate it.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas-detect.h | 33 -
drivers/usb/storage/unusual_uas.h | 8
Just like all previous UAS capable Seagate disk enclosures, these need the
US_FL_NO_ATA_1X to not crash when udev probes them.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 14 ++
1 file changed, 14
between port change and the irq is handled always exists,
so it's hard to fix the issue unless we put more strict condtion on the
issue of commit a82b76f7f fixed. Any Idea?
Thanks
Jincan
On Wed, Dec 24, 2014 at 03:12:59PM +0800, Zhuang Jin Can wrote:
Hi Hans de Goede, Sarah, Mathias,
This is about
Hi,
On 07-01-15 16:19, Alan Stern wrote:
On Tue, 6 Jan 2015, Taegil Bae wrote:
Hi all,
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=90791
My machine is Thinkpad Yoga with Onelink dock attached. Onelink dock
is a USB 3.0 dock functioning as a USB 3.0 hub. This has two USB 3.0
ports
Hi Linus,
On 15-12-14 00:06, Linus Torvalds wrote:
On Sun, Dec 14, 2014 at 2:35 PM, Greg KH gre...@linuxfoundation.org wrote:
Hans de Goede (1):
uas: Make uas work with blk-mq
So I got some fairly trivial conflicts on this one (conflicting with
the scsi cleanups mainly by Christoph
. Wong wrote:
On Wed, Dec 10, 2014 at 09:19:04AM +0100, Hans de Goede wrote:
Hi,
On 09-12-14 20:31, Darrick J. Wong wrote:
Hi,
I have an Apricorn USB 3 disk dongle thing that claims to support UAS.
However, the kernel crashes when I plug it in[1].
Yes there are some known issues with uas
Looks good:
Acked-by: Hans de Goede hdego...@redhat.com
Greg, can you add this to your tree please ?
Regards,
Hans
---
drivers/usb/storage/unusual_uas.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/usb/storage/unusual_uas.h
b/drivers/usb/storage/unusual_uas.h
Hi,
On 09-12-14 20:31, Darrick J. Wong wrote:
Hi,
I have an Apricorn USB 3 disk dongle thing that claims to support UAS.
However, the kernel crashes when I plug it in[1].
Yes there are some known issues with uas error handling which are fixed
in 3.18, can you try with a 3.18 kernel please ?
Like the JMicron JMS567 enclosures with the JMS566 choke on report-opcodes,
so avoid it.
Tested-and-reported-by: Takeo Nakayama javh...@gmx.com
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7
Hi,
On 12/05/2014 12:35 AM, Marcin Zajączkowski wrote:
On 2014-12-04 20:21, Hans de Goede wrote:
Hi,
On 12/03/2014 10:22 PM, Marcin Zajączkowski wrote:
On 2014-12-03 10:53, Oliver Neukum wrote:
On Wed, 2014-12-03 at 10:41 +0100, Marcin Zajączkowski wrote:
2014-12-03 Oliver Neukum wrote
controller for
myself to see if I can come up with a better fix then the big hammer, in
the mean time this will make uas devices work again (in usb-storage mode)
for FL1000G users.
Reported-by: Marcin Zajączkowski msz...@wp.pl
Cc: sta...@vger.kernel.org # 3.15
Signed-off-by: Hans de Goede hdego
This is yet another Seagate device which needs the US_FL_NO_ATA_1X quirk
Reported-by: Marcin Zajączkowski msz...@wp.pl
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7 insertions(+)
diff --git
://lists.opensuse.org/archive/opensuse-bugs/2014-07/msg00919.html
I have also seen a patch on that mailing list submitted by Hans de Goede
which disables UAS for ASM1051 devices:
http://www.spinics.net/lists/linux-usb/msg113537.html
What would you propose to do with the issue with that Seagate
This wireless mouse receiver needs a reset-resume quirk to properly come
out of reset.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1165206
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/quirks.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb
Hi,
I'm not the usb-storage maintainer, can you please send a mail about this to
linux-usb linux-usb@vger.kernel.org with me in the CC?
Thanks,
Hans
On 11/23/2014 03:59 AM, 白家驹 wrote:
Dear Sir,
I'm very sorry to trouble you.
Recently I test 15 linux device drivers in runtime and
These disks have a broken uas implementation, the tag field of the status
iu-s is not set properly, so we need to fall-back to usb-storage for these.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file
Hi,
On 11/16/2014 08:39 AM, Jonas Seibert wrote:
Hey Hans,
as I got a 2TB external harddrive and it didn't work with linux for ages
(works with windows though) I decided to give your fix a try.
Said HDD says airy and by CnMemory on the front and on the back
Item-No.68770 (just in case
Hi All,
So when I send the patches to blacklist via xhci controllers with
a product-id of 3432, as well as asmedia 1042 xhci controllers,
I promised I would spend some quality time with both once I
actually got one of each in my hands, and see if I could come
up with a workaround rather then
Hi,
On 10/29/2014 11:32 PM, Alon Levy wrote:
Hey, how are you? have you noticed problems with $SUBJECT? I have a
continuously disconnecting printer. Using XHCI (T440p) getting a repeat of:
[105574.775812] usblp 3-6:1.0: usblp0: USB Bidirectional printer dev 27
if 0 alt 0 proto 2 vid 0x03F0
capable disk enclosures work again by forcing fallback to the usb-storage
driver.
Reported-by: Bogdan Mihalcea bogdan.mihal...@infim.ro
Cc: Bogdan Mihalcea bogdan.mihal...@infim.ro
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/host/xhci-pci.c | 4
These drives hang when receiving ATA12 commands, so set the US_FL_NO_ATA_1X
quirk to filter these out.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 14 ++
1 file changed, 14 insertions(+)
diff --git
involved code anyways also rename the uas_cmd_info stream
field to uas_tag, because when using uas over usb-2 streams are not used.
Cc: Christoph Hellwig h...@infradead.org
Reported-by: Douglas Gilbert dgilb...@interlog.com
Signed-off-by: Hans de Goede hdego...@redhat.com
Reviewed-by: Christoph Hellwig
Hi,
This one seems to have fallen through the cracks.
Regards,
Hans
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
To help debugging xhci problems.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/host/xhci.c | 4
drivers/usb/host/xhci.h | 2 ++
2 files changed, 6 insertions(+)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 2a5d45b..36e3493 100644
--- a/drivers/usb
Hi Greg,
You probably already have this one queued up for merging once 3.18-rc1 is out,
just resending it to make sure, as this fixes a nasty oops which may trigger
when uas devices get unplugged.
Regards,
Hans
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of
, as it is necessary to explicitly free the streams at the xhci
controller level.
Cc: sta...@vger.kernel.org
Signed-off-by: Hans de Goede hdego...@redhat.com
Acked-by: Alan Stern st...@rowland.harvard.edu
---
drivers/usb/core/hcd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/core/hcd.c b
Just like some Seagate enclosures, these devices do not seem to grok ata
pass through commands.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/storage
Hi,
On 10/04/2014 04:46 PM, James Bottomley wrote:
On Sat, 2014-10-04 at 10:53 +0200, Hans de Goede wrote:
Hi,
On 10/03/2014 11:47 PM, Greg Kroah-Hartman wrote:
On Fri, Oct 03, 2014 at 12:08:57PM +0200, Hans de Goede wrote:
With uas over usb-3 the tags inside the uas iu-s must match the usb
Hi,
On 10/04/2014 08:35 PM, Jan Kiszka wrote:
Hi,
my Delock external USB drive stopped working after updating from a
UAS-disabled distro kernel to latest 3.17-rc7 with UAS on. That UAS was
key became clear to me only after looking at storage_probe(): the device
is ignored by usb-storage if
Hi,
On 10/05/2014 11:10 AM, Christoph Hellwig wrote:
On Sun, Oct 05, 2014 at 11:06:00AM +0200, Hans de Goede wrote:
This patch sits on top of a lot of other uas fixes which are already
in usb-next, so this needs to go in through usb-next.
What is the actual conflict? If it's just your
Hi,
On 10/05/2014 11:14 AM, Jan Kiszka wrote:
On 2014-10-05 11:08, Hans de Goede wrote:
Hi,
On 10/04/2014 08:35 PM, Jan Kiszka wrote:
Hi,
my Delock external USB drive stopped working after updating from a
UAS-disabled distro kernel to latest 3.17-rc7 with UAS on. That UAS was
key became
Hi,
On 10/05/2014 11:31 AM, Jan Kiszka wrote:
On 2014-10-05 11:23, Hans de Goede wrote:
Hi,
On 10/05/2014 11:14 AM, Jan Kiszka wrote:
On 2014-10-05 11:08, Hans de Goede wrote:
Hi,
On 10/04/2014 08:35 PM, Jan Kiszka wrote:
Hi,
my Delock external USB drive stopped working after updating
Hi,
On 10/05/2014 11:48 AM, Jan Kiszka wrote:
On 2014-10-05 11:43, Hans de Goede wrote:
Hi,
On 10/05/2014 11:31 AM, Jan Kiszka wrote:
On 2014-10-05 11:23, Hans de Goede wrote:
Hi,
On 10/05/2014 11:14 AM, Jan Kiszka wrote:
On 2014-10-05 11:08, Hans de Goede wrote:
Hi,
On 10/04/2014 08
Hi,
On 10/03/2014 11:47 PM, Greg Kroah-Hartman wrote:
On Fri, Oct 03, 2014 at 12:08:57PM +0200, Hans de Goede wrote:
With uas over usb-3 the tags inside the uas iu-s must match the usb-3 stream
ids, and those go from 1 - qdepth.
Before blk-mq calling scsi_activate_tcq(sdev, qdepth
this assumption. A fix is under way for 3.18, but sits on top of
large changes so can't easily be backported. Set the disable_blk_mq
path so that a uas device can't easily crash the system when using
blk-mq for SCSI.
Signed-off-by: Christoph Hellwig h...@lst.de
Acked-by: Hans de Goede hdego
The stream_id and pipe are already present in uas_cmd_info resp uas_dev_info,
so there is no need to pass a copy along.
Signed-off-by: Hans de Goede hdego...@redhat.com
Reviewed-by: Christoph Hellwig h...@lst.de
---
drivers/usb/storage/uas.c | 29 ++---
1 file changed, 14
involved code anyways also rename the uas_cmd_info stream
field to uas_tag, because when using uas over usb-2 streams are not used.
Cc: Christoph Hellwig h...@infradead.org
Reported-by: Douglas Gilbert dgilb...@interlog.com
Signed-off-by: Hans de Goede hdego...@redhat.com
Reviewed-by: Christoph Hellwig
involved code anyways also rename the uas_cmd_info stream
field to uas_tag, because when using uas over usb-2 streams are not used.
Cc: Christoph Hellwig h...@infradead.org
Reported-by: Douglas Gilbert dgilb...@interlog.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c
The stream_id and pipe are already present in uas_cmd_info resp uas_dev_info,
so there is no need to pass a copy along.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git
Hi,
On 10/02/2014 01:26 PM, Christoph Hellwig wrote:
Looks fine to me (and actually removes code..)
Reviewed-by: Christoph Hellwig h...@lst.de
It's fairly late in 3.17 to get something like this in, but would you
consider Ccing it to stable so we can get it into the first 3.17 stable
Hi,
On 10/02/2014 03:06 PM, Christoph Hellwig wrote:
On Thu, Oct 02, 2014 at 02:35:10PM +0200, Hans de Goede wrote:
This patch sits on top of a whole bunch of uas cleanups / fixes which
are going into 3.18, and which are to big of a change to backport.
Can add a patch to set disable_blk_mq
Hi,
On 10/02/2014 03:12 PM, Christoph Hellwig wrote:
On Thu, Oct 02, 2014 at 03:08:40PM +0200, Hans de Goede wrote:
Yes, although that likely would need to go through stable, without
going into 3.18 .
Greg, is this ok with you and how do I get a patch in stable which
is not in upstream
Hi,
On 10/02/2014 03:25 PM, James Bottomley wrote:
On Thu, 2014-10-02 at 15:18 +0200, Hans de Goede wrote:
Hi,
On 10/02/2014 03:12 PM, Christoph Hellwig wrote:
On Thu, Oct 02, 2014 at 03:08:40PM +0200, Hans de Goede wrote:
Yes, although that likely would need to go through stable, without
Hi,
On 09/28/2014 09:33 PM, Alan Stern wrote:
On Sun, 28 Sep 2014, Hans de Goede wrote:
The problem is the following call sequence (simplified):
1) usb_reset_device
2) usb_reset_and_verify_device
2) hub_port_init
3)hub_port_finish_reset
3) xhci_discover_or_reset_device
, as it is necessary to explicitly free the streams at the xhci
controller level.
Cc: sta...@vger.kernel.org
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/hcd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 487abcf..258e6fe
in this scenario to
detect this, and suppress the xHCI xhci_drop_endpoint called with disabled
ep ... message in this case.
Signed-off-by: Hans de Goede hdego...@redhat.com
--
Changes in v2:
Move the ring check to only guard the xhci_warn, so as to avoid side-effects
in case we have a scenario where
Hi,
On 09/28/2014 04:29 PM, Alan Stern wrote:
On Sat, 27 Sep 2014, Hans de Goede wrote:
This commit fixes the following oops:
[10238.622067] scsi host3: uas_eh_bus_reset_handler start
[10240.766164] usb 3-4: reset SuperSpeed USB device number 3 using xhci_hcd
[10245.779365] usb 3-4
points into the xhci driver.
Cc: sta...@vger.kernel.org
Reported-by: Claudio Bizzarri claudio.bizza...@gmail.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/host/xhci.c | 37 ++---
1 file changed, 26 insertions(+), 11 deletions(-)
diff --git
Silence the xHCI xhci_drop_endpoint called with disabled ep ... messages
appearing on a successful usb device reset.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/host/xhci.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host
Hi,
On 09/27/2014 03:01 PM, Hans de Goede wrote:
Silence the xHCI xhci_drop_endpoint called with disabled ep ... messages
appearing on a successful usb device reset.
Signed-off-by: Hans de Goede hdego...@redhat.com
Note no Cc stable for this one, even though it did get send to stable
As most ASM1051 based devices, this one has unfixable issues with uas too.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/usb/storage/unusual_uas.h
b
https://bbs.archlinux.org/viewtopic.php?pid=1457492
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/storage/unusual_uas.h
b/drivers/usb/storage/unusual_uas.h
index 3e62437..94fb09f
Hi Greg, et al,
Another day, another uas quirk. Although you may not see it that way, this
is
actually a good thing :) With the new uas error handling code (which users
are
testing through a stand-alone version of the uas driver), people are now
actually sending me logs with useful error messages
a quirk
for this, and set it for the JMS567.
*) Which has become a non-issue since we've completely blacklisted uas on
the ASM1051 for other reasons
Cc: sta...@vger.kernel.org
Reported-and-tested-by: Claudio Bizzarri claudio.bizza...@gmail.com
Signed-off-by: Hans de Goede hdego...@redhat.com
Hi Greg,
Sorry for the high number of iterations on this one. After the documentation
issues pointed out during review, I've just received a report from a user
that (as I already suspected) another seagate disk enclosure also benifits
from this quirk. So this version sets the quirk for 2
for usb-storage
quirks.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
--
Changes in v2: Add documentation for new t and u usb-storage.quirks flags
Changes in v3: Fix typo in documentation
Changes in v4: Also apply the quirk to (0bc2:3312)
---
Documentation/kernel
Hi,
On 09/15/2014 10:42 AM, David Laight wrote:
From: Alan Stern
...
p = quirks;
while (*p) {
@@ -543,6 +544,9 @@ void usb_stor_adjust_quirks(struct usb_device *udev,
unsigned long *fflags)
case 's':
f |= US_FL_SINGLE_LUN;
for usb-storage
quirks.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
--
Changes in v2: Add documentation for new t and u usb-storage.quirks flags
Changes in v3: Fix typo in documentation
Changes in v4: Also apply the quirk to (0bc2:3312)
Changes in v5: Rebased
Hi,
On 09/15/2014 04:08 PM, Greg Kroah-Hartman wrote:
On Mon, Sep 15, 2014 at 04:04:12PM +0200, Hans de Goede wrote:
And set this quirk for the Seagate Expansion Desk (0bc2:2312), as that one
seems to hang upon receiving an ATA_12 or ATA_16 command.
https://bugzilla.kernel.org/show_bug.cgi
.
Reported-by: Hans de Goede hdego...@redhat.com
Signed-off-by: Christoph Hellwig h...@lst.de
---
include/scsi/scsi_tcq.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/scsi/scsi_tcq.h b/include/scsi/scsi_tcq.h
index cdcc90b..e645835 100644
--- a/include/scsi
601 - 700 of 1177 matches
Mail list logo