Hi,
On 09/13/2014 09:31 PM, Sergei Shtylyov wrote:
Hello.
On 9/13/2014 1:26 PM, Hans de Goede wrote:
The data urbs are all killed before calling zap_pending, and their completion
handler should have cleared their inflight flag.
Do not 0 the data inflight flags, and add a check
Hi,
On 09/13/2014 07:50 PM, Christoph Hellwig wrote:
On Sat, Sep 13, 2014 at 12:28:41PM +0200, Hans de Goede wrote:
Yes this one does the trick and fixes things. Note the git tree I used for
testing also had your previous fix to split up the blk_tcq union in 2
separate struct members. Let me
While at it also add missing documentation for the u value for usb-storage
quirks.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
--
Changes in v2: Add documentation for new t and u usb-storage.quirks flags
---
Documentation/kernel-parameters.txt
# 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
--
Changes in v2: Add documentation for new t and u usb-storage.quirks flags
Changes in v3: Fix typo in documentation
---
Documentation/kernel-parameters.txt | 3 +++
drivers/usb/storage/uas.c | 13 +
drivers/usb/storage
Hi,
On 09/14/2014 12:29 PM, James Bottomley wrote:
On Sun, 2014-09-14 at 11:26 +0200, Hans de Goede wrote:
Hi,
On 09/13/2014 09:31 PM, Sergei Shtylyov wrote:
Hello.
On 9/13/2014 1:26 PM, Hans de Goede wrote:
The data urbs are all killed before calling zap_pending, and their
completion
And set this quirk for the Seagate Expansion Desk (0bc2:2312), as that one
seems to hang upon receiving an ATA_12 or ATA_16 command.
https://bugzilla.kernel.org/show_bug.cgi?id=79511
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c
Hi Greg,
As the subject indicates, if possible I would like to still get this into
3.17.
For now this impacts only a single usb-id, but looking at
https://bbs.archlinux.org/viewtopic.php?id=183190
It seems more seagate uas capable enclosures are having issues, I'm waiting
for feedback from
Hi Greg, et al,
Here is v2 of my uas error handling rewrite + cleanups series.
Note this has been rebased on top of the
[PATCH fix for 3.17] uas: Add a quirk for rejecting ATA_12 and ATA_16 commands
patch which I've just send, so if that does not make 3.17, you should still
apply that one
If something goes wrong in our communication with an uas device we may get
a response iu in reaction to a cmnd, rather then a status iu. In this case
propagate an error upwards, rather then logging a bogus iu message.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c
in that case.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 61 ++-
1 file changed, 55 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index fca8775..f4fe816 100644
We've removed all hack from the driver for pre-production hardware.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index cbd4312..a77c5e0 100644
Check for both type of cancellation codes for sense and data urbs.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 187e7bf
The data urbs are all killed before calling zap_pending, and their completion
handler should have cleared their inflight flag.
Do not 0 the data inflight flags, and add a check for try_complete succeeding,
as it should always succeed when called from zap_pending.
Signed-off-by: Hans de Goede
change various sanity checks (which should never trigger) from:
scmd_printk(KERN_ERR, cmnd, sanity foo failed\n) to calling the new
uas_log_cmd_state(), so that when they do trigger we get more info.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 52
to the scsi
midlayer without holding the lock due to the midlayer re-claiming ownership
through an abort (which will be handled by a future patch in this series).
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 48 ++-
1
Limit the no-streams case to speeds less then USB_SPEED_SUPER.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index f4fe816..187e7bf 100644
It was only used to sanity check against completing the same cmnd twice,
but that is the case we're likely operating on free-ed memory, and doing
sanity checks on free-ed memory is not really helpful.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 10
It is not strictly necessary for the cmd urb to have a reference to the
cmnd, and without this reference it becomes easier to drop all references to
a cmnd on an abort.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 9 +++--
1 file changed, 3 insertions
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 0b3d3a5..1dcaeee 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers
boundary checking
Instead keep our own list which maps tags - inflight cmnds.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 39 ++-
1 file changed, 18 insertions(+), 21 deletions(-)
diff --git a/drivers/usb/storage/uas.c b
Factor out the mapping of scsi-tags - uas-tags/stream-ids to a helper function
so that there is a single place where this magic happens.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 33 +
1 file changed, 21 insertions(+), 12
We've the same info doubled in both the inflight list and the cmnd array,
drop the list.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/usb/storage/uas.c
are seeing very hard to debug oopses with uas. First let focus on making uas
work reliable, then we can later look into adding more fine grained error
handling.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 177 +-
1
sense iu-s regardless, as can be seen for scsi cmnds where there is sense
data.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 47 +--
1 file changed, 1 insertion(+), 46 deletions(-)
diff --git a/drivers/usb/storage/uas.c
From: Sanjeev Sharma sanjeev_sha...@mentor.com
On some architecture spin_is_locked() always return false in
uniprocessor configuration and therefore it would be advise to replace
with lockdep_assert_held().
Signed-off-by: Sanjeev Sharma sanjeev_sha...@mentor.com
Signed-off-by: Hans de Goede
Do not keep references around to a cmnd which is under error handling.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 47 ---
1 file changed, 44 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/storage/uas.c b
The status urb should not complete before the command has been submitted, nor
should we get a second status urb for the same tag after a IU_ID_STATUS.
Data urbs should not complete before the command has been submitted, but may
complete after the IU_ID_STATUS.
Signed-off-by: Hans de Goede hdego
Drop the whole dance with first moving cmnds to a dead-list. The resetting
flag ensures that no new cmds / urbs will be submitted, and that any urb
completions are short-circuited without trying to complete the scsi cmnd.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage
that accidentally disabled block-based tcq
The scsi blk-mq support accidentally flipped a conditional, which lead to
never enabling block based tcq when using the legacy request path.
Fixes: d285203cf647d7c9 scsi: add support for a blk-mq based I/O path.
Reported-by: Hans de Goede hdego
Now that we no longer drop our lock to unlink the data urbs, we can simply
free them on completion, making their handling consistent with the other urbs.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions
Use scsi_print_command to print commands during errors, rather then printing
the rather meaningless pointer to the command.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/storage
- Make sure we always hold the lock when setting / checking resetting
- Check resetting before checking urb-status
- Add missing check for resetting to uas_data_cmplt
- Add missing check for resetting to uas_do_work
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c
we may have never tried to submit the data urbs
when completing the scsi cmnd, because we never got a READ/WRITE_READY iu
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drivers/usb/storage
# 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
--
Changes in v2: Add documentation for new t and u usb-storage.quirks flags
---
Documentation/kernel-parameters.txt | 3 +++
drivers/usb/storage/uas.c | 13 +
drivers/usb/storage/unusual_uas.h | 16
Hi,
On 09/11/2014 06:13 PM, Christoph Hellwig wrote:
On Thu, Sep 11, 2014 at 12:01:13PM +0200, Hans de Goede wrote:
So we're initializing the tag map, but scsi_activate_tcq doesn't pick it
up. I can't really come up with a good explanation for it, but there
even without
Hi,
On 09/10/2014 10:54 PM, Douglas Gilbert wrote:
On 14-09-10 08:13 AM, Hans de Goede wrote:
Hi All,
I'm mailing all of you because you've reported various problems
with the new uas support in kernel 3.16 and later.
I've been working on making the uas driver more resilient to
errors
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas-detect.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/storage/uas-detect.h b/drivers/usb/storage/uas-detect.h
index 1e298ec..8a6f371 100644
Hi,
On 09/10/2014 05:45 PM, Christoph Hellwig wrote:
On Wed, Sep 10, 2014 at 09:21:24AM +0200, Hans de Goede wrote:
I've applied the patch, this results in the following new dmesg output
when using uas:
[ 120.602632] initialized host-wide tag map!
Thank you for looking into this.
So
Hi,
On 09/09/2014 05:27 PM, Christoph Hellwig wrote:
On Tue, Sep 09, 2014 at 11:15:24AM +0200, Hans de Goede wrote:
Taking the uas.c file from 3.17, and building it for 3.16 restores
the use of tcq (debugged by adding a printk blk_rq_tagged + request-tag).
So either uas is doing something
Hi,
On 09/09/2014 09:21 PM, Hans de Goede wrote:
Hi,
On 09/09/2014 06:01 PM, Christoph Hellwig wrote:
On Tue, Sep 09, 2014 at 04:59:59PM +0200, Hans de Goede wrote:
asm1051e usb - sata bridges hang when receiving a report opcodes scsi
cmnd.
Take a page out of the usb-storage book
to disable uas for
the ASM1051. When connected over USB-2, simply disable uas alltogether for
devices with the shared usb-id.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas-detect.h | 27 +++
1 file changed, 23
Hi Greg,
Here is v2 of my ASM1051 blacklist patch. The commit message and some of
the log messages have been changed to reflect that my vision on the ASM1051
woes has shifted from: too bad we need to blacklist this because it does not
work in some cases, to: this thing is just too buggy to try
Hi Greg, et al,
Since we've been receiving multiple bug reports with crashes / oopses related
to uas error handling, I've spend the last 7 days rewriting the error handling
code. This new code has been extensively tested, doing externally triggered
usb-device-resets and scsi bus resets while
sense iu-s regardless, as can be seen for scsi cmnds where there is sense
data.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 47 +--
1 file changed, 1 insertion(+), 46 deletions(-)
diff --git a/drivers/usb/storage/uas.c
to the scsi
midlayer without holding the lock due to the midlayer re-claiming ownership
through an abort (which will be handled by a future patch in this series).
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 48 ++-
1
boundary checking
Instead keep our own list which maps tags - inflight cmnds.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 39 ++-
1 file changed, 18 insertions(+), 21 deletions(-)
diff --git a/drivers/usb/storage/uas.c b
Use scsi_print_command to print commands during errors, rather then printing
the rather meaningless pointer to the command.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/storage
We've the same info doubled in both the inflight list and the cmnd array,
drop the list.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 31 ---
1 file changed, 16 insertions(+), 15 deletions(-)
diff --git a/drivers/usb/storage/uas.c
Limit the no-streams case to speeds less then USB_SPEED_SUPER.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index aaca65b..685eb37 100644
we may have never tried to submit the data urbs
when completing the scsi cmnd, because we never got a READ/WRITE_READY iu
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drivers/usb/storage
It is not strictly necessary for the cmd urb to have a reference to the
cmnd, and without this reference it becomes easier to drop all references to
a cmnd on an abort.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 9 +++--
1 file changed, 3 insertions
The status urb should not complete before the command has been submitted, nor
should we get a second status urb for the same tag after a IU_ID_STATUS.
Data urbs should not complete before the command has been submitted, but may
complete after the IU_ID_STATUS.
Signed-off-by: Hans de Goede hdego
We've removed all hack from the driver for pre-production hardware.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 23c0b97..a7f16c4 100644
From: Sanjeev Sharma sanjeev_sha...@mentor.com
On some architecture spin_is_locked() always return false in
uniprocessor configuration and therefore it would be advise to replace
with lockdep_assert_held().
Signed-off-by: Sanjeev Sharma sanjeev_sha...@mentor.com
Signed-off-by: Hans de Goede
are seeing very hard to debug oopses with uas. First let focus on making uas
work reliable, then we can later look into adding more fine grained error
handling.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 177 +-
1
Check for both type of cancellation codes for sense and data urbs.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 685eb37
in that case.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 61 ++-
1 file changed, 55 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 6ee61bd..aaca65b 100644
Drop the whole dance with first moving cmnds to a dead-list. The resetting
flag ensures that no new cmds / urbs will be submitted, and that any urb
completions are short-circuited without trying to complete the scsi cmnd.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage
It was only used to sanity check against completing the same cmnd twice,
but that is the case we're likely operating on free-ed memory, and doing
sanity checks on free-ed memory is not really helpful.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 10
Do not keep references around to a cmnd which is under error handling.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 47 ---
1 file changed, 44 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/storage/uas.c b
Factor out the mapping of scsi-tags - uas-tags/stream-ids to a helper function
so that there is a single place where this magic happens.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 33 +
1 file changed, 21 insertions(+), 12
- Make sure we always hold the lock when setting / checking resetting
- Check resetting before checking urb-status
- Add missing check for resetting to uas_data_cmplt
- Add missing check for resetting to uas_do_work
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c
Now that we no longer drop our lock to unlink the data urbs, we can simply
free them on completion, making their handling consistent with the other urbs.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions
Hi,
Note this series is NOT intended for stable, but I accidentally
had cc = sta...@vger.kernel.org in my .git/config when sending
this series, please ignore for stable.
NACK for stable.
Sorry Regards,
Hans
On 09/10/2014 01:46 PM, Hans de Goede wrote:
From: Sanjeev Sharma sanjeev_sha
Hi,
On 09/10/2014 01:56 PM, Oliver Neukum wrote:
On Wed, 2014-09-10 at 13:48 +0200, Hans de Goede wrote:
Hi,
Note this series is NOT intended for stable, but I accidentally
had cc = sta...@vger.kernel.org in my .git/config when sending
this series, please ignore for stable.
NACK
Hi,
On 09/10/2014 02:54 PM, Oliver Neukum wrote:
On Wed, 2014-09-10 at 14:00 +0200, Hans de Goede wrote:
Hi,
On 09/10/2014 01:56 PM, Oliver Neukum wrote:
On Wed, 2014-09-10 at 13:48 +0200, Hans de Goede wrote:
Hi,
Note this series is NOT intended for stable, but I accidentally
had cc
Hi,
First of all, thank you for reviewing this.
On 09/10/2014 03:40 PM, Oliver Neukum wrote:
On Wed, 2014-09-10 at 13:46 +0200, Hans de Goede wrote:
- Make sure we always hold the lock when setting / checking resetting
- Check resetting before checking urb-status
- Add missing check
Hi,
On 09/10/2014 04:00 PM, Oliver Neukum wrote:
On Wed, 2014-09-10 at 13:46 +0200, Hans de Goede wrote:
Check for both type of cancellation codes for sense and data urbs.
Then you should also check for -ESHUTDOWN (unplug of HC)
The intent here is to stop log pollution when cancelling
Hi,
On 09/10/2014 04:06 PM, Oliver Neukum wrote:
On Wed, 2014-09-10 at 13:46 +0200, Hans de Goede wrote:
I've access to a number of different uas devices now, and none of them use
old style sense urbs. The only case where these code-paths trigger is with
the asm1051 and there they do
Hi,
On 09/10/2014 04:10 PM, Oliver Neukum wrote:
On Wed, 2014-09-10 at 13:46 +0200, Hans de Goede wrote:
uas_log_cmd_state(cmnd, __func__);
- /* all urbs are killed, clear inflight bits */
- cmdinfo-state = ~(COMMAND_INFLIGHT
Hi,
On 09/10/2014 04:38 PM, Peter Hurley wrote:
[ +cc Peter Zijlstra, Ingo Molnar ]
On 09/10/2014 07:46 AM, Hans de Goede wrote:
From: Sanjeev Sharma sanjeev_sha...@mentor.com
On some architecture spin_is_locked() always return false in
uniprocessor configuration and therefore it would
Hi Robert,
On 09/10/2014 06:08 PM, Elliott, Robert (Server Storage) wrote:
-Original Message-
From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
ow...@vger.kernel.org] On Behalf Of Hans de Goede
Sent: Wednesday, 10 September, 2014 6:47 AM
To: Greg Kroah-Hartman
Cc: linux
Hi All,
While working on making error handling in the uas driver more robust,
I noticed that all the commands being send to a sata ssd hooked up
over uas were untagged, where I would expect tcq to be used, as that
is the big advantage of uas over usb-storage / bot.
Taking the uas.c file from
Hi,
On 09/07/2014 04:36 PM, Laszlo T. wrote:
2014-08-04 20:07 GMT+02:00 Hans de Goede hdego...@redhat.com:
Hi Laszlo,
On 08/03/2014 12:40 AM, Laszlo T. wrote:
*) usb devices return different descriptors at different speeds
All tests were on usb2.
I don't have usb3 ports but I will try
asm1051e usb - sata bridges hang when receiving a report opcodes scsi cmnd.
Take a page out of the usb-storage book, and simple disable no_report_opcodes
outright.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas.c | 2 ++
1 file
Hi Greg,
I've received a number of bug-reports from users related to uas on ASM1051
chipset using devices. After some searching around I've managed to get myself
an ASM1051 device.
As a result I've spend the last 4 days trying to get the ASM1051 chipset to
work. After some initial success which
users can re-enable uas.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/storage/uas-detect.h | 34 ++
1 file changed, 30 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/storage/uas-detect.h b/drivers/usb
Hi,
On 09/09/2014 05:23 PM, Alan Stern wrote:
On Tue, 9 Sep 2014, Hans de Goede wrote:
Even with REPORT SUPPORTED OPERATION CODES blacklisted the ASM1051 chipset
still does not work when combined with some disks, e.g. a Crucial M500 ssd.
When used with a troublesome disk, the chipset throws
Hi,
On 09/02/2014 06:18 AM, Chunwei Chen wrote:
Dear all:
The kernel version is 3.16.1-1-ARCH
Today I keep getting this panic when booting up.
http://i.imgur.com/0Rx93Kr.jpg
It might be that the UAS device was in some strange state,
because that after I unplugged and power-cycled the
Hi,
On 08/25/2014 08:14 PM, Greg Kroah-Hartman wrote:
On Mon, Aug 25, 2014 at 12:21:56PM +0200, Hans de Goede wrote:
This is a bit bigger hammer then I would like to use for this, but for now
it will have to make do. I'm working on getting my hands on one of these so
that I can try to get
disk enclosures work again by forcing
fallback to the usb-storage driver.
https://bugzilla.kernel.org/show_bug.cgi?id=79511
Cc: sta...@vger.kernel.org # 3.15
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/host/xhci-pci.c | 5 +
1 file changed, 5 insertions(+)
diff --git
Hi,
On 08/15/2014 09:44 AM, Claudio Bizzarri wrote:
On Thu, Aug 14, 2014 at 11:46:33AM +0200, Hans de Goede wrote:
Hi,
...
Can you collect lsusb -v output for the drive in question when connected
through an usb-3 port (the uas module does not need to be loaded).
Here lsusb output, full
Hi,
On 08/14/2014 10:39 AM, Claudio Bizzarri wrote:
Ciao,
thank you very much for replay, you are right: it's UAS module. Now I'm
using Ubuntu 14.04 with kernel 3.16.1 from
http://kernel.ubuntu.com/~kernel-ppa/mainline/, there is no /proc/config.gz,
but but there is a config file in /boot:
Hi,
On 08/12/2014 05:29 PM, Udo van den Heuvel wrote:
On 2014-08-12 17:07, Hans de Goede wrote:
lspci -nn
# lspci -nn
00:00.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Family
15h (Models 10h-1fh) Processor Root Complex [1022:1410]
00:00.2 IOMMU [0806]: Advanced Micro Devices
:
incorporated review comment suggested by Greg
Thanks, this is still:
Acked-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
drivers/usb/storage/uas.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index
Hi Udo,
On 08/07/2014 04:49 PM, Udo van den Heuvel wrote:
On 2014-08-04 11:17, Laurent Pinchart wrote:
(CC'ing Hans de Goede, the pwc maintainer, and the linux-media mailing list)
Thanks for the bug report. I've been looking into this, and there
seem to be 2 problems:
1: xhci_hcd :02:00.0
Hi,
On 08/11/2014 08:19 PM, Guenter Roeck wrote:
On Mon, Aug 11, 2014 at 01:29:26PM +0530, Sanjeev Sharma wrote:
spin_is_locked() always return false in uniprocessor configuration and
therefore it
would be advise to repalce with assert_spin_locked().
Signed-off-by: Sanjeev Sharma
Hi,
On 08/11/2014 09:59 AM, Sanjeev Sharma wrote:
spin_is_locked() always return false in uniprocessor configuration and
therefore it
would be advise to repalce with assert_spin_locked().
Signed-off-by: Sanjeev Sharma sanjeev_sha...@mentor.com
Looks sane / good to me:
Acked-by: Hans de
Hi,
On 08/11/2014 09:08 PM, Guenter Roeck wrote:
On Mon, Aug 11, 2014 at 08:55:07PM +0200, Hans de Goede wrote:
Hi,
On 08/11/2014 08:19 PM, Guenter Roeck wrote:
On Mon, Aug 11, 2014 at 01:29:26PM +0530, Sanjeev Sharma wrote:
spin_is_locked() always return false in uniprocessor configuration
WARN_ON_ONCE() with lockdep_assert_held() to
avoid runtime overhead instead of assert_spin_locked()
Thanks!
Acked-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
drivers/usb/storage/uas.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/storage/uas.c b
Hi,
On 08/04/2014 05:24 PM, Alan Stern wrote:
On Mon, 4 Aug 2014, Mathias Nyman wrote:
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -1718,10 +1718,12 @@ cleanup:
* TRB in this TD, this function returns that TRB's segment. Otherwise it
* returns 0.
*/
Hi,
On 08/02/2014 10:41 AM, Hans de Goede wrote:
Hi,
On 08/02/2014 12:58 AM, Greg Kroah-Hartman wrote:
On Fri, Jul 25, 2014 at 10:01:20PM +0200, Hans de Goede wrote:
Lately (with the use of uas / bulk-streams) we have been seeing several
cases where this error triggers (which should never
Hi All,
Here is a resend of my pending xhci fixes / cleanups.
Note the first one is a bug-fix which really should go into
3.17-rc2 (too late for rc1 I assume) the rest can wait I think.
Changes in v2:
-rebased on top of usb-next
-merged
xhci: Log ep-index and comp-code on TRB DMA ptr not part
)
The following error gets logged to dmesg:
xhci error: Transfer event TRB DMA ptr not part of current TD
Treating COMP_STOP the same as COMP_STOP_INVAL when no event_seg gets found
fixes this.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/host/xhci-ring.c | 3 ++-
1 file
ring they will be simply
skipped.
So the SET_DEQ_PENDING flag in the endpoint is sufficient protection against
starting the endpoing before all stream rings are cleaned up.
Signed-off-by: Hans de Goede hdego...@redhat.com
Acked-by: Mathias Nyman mathias.ny...@linux.intel.com
---
drivers/usb/host
checks in
queue_set_tr_deq(), avoiding leaking the command if those fail
4) Since queue_set_tr_deq now owns the command it can free it if queue_command
fails
5) It reduces code duplication
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/host/xhci-ring.c | 35
Even if the stream for which the command was intended has been freed in the
mean time. This ensures that things start rolling again after an unlink / halt.
Signed-off-by: Hans de Goede hdego...@redhat.com
Acked-by: Mathias Nyman mathias.ny...@linux.intel.com
---
drivers/usb/host/xhci-ring.c | 4
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/host/xhci-hub.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
index aa79e87..bb54783 100644
--- a/drivers/usb/host/xhci-hub.c
+++ b
xhci_queue_new_dequeue_state is the only caller of queue_set_tr_deq
and queue_set_tr_deq checks for SET_DEQ_PENDING, where as
xhci_queue_new_dequeue_state sets it which is inconsistent.
Simply fold the 2 into one is a nice cleanup and fixes the inconsistency.
Signed-off-by: Hans de Goede hdego
Lately (with the use of uas / bulk-streams) we have been seeing several
cases where this error triggers (which should never happen).
Add some extra logging to make debugging these errors easier.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/host/xhci-mem.c | 4 +++-
drivers
701 - 800 of 1177 matches
Mail list logo
