considerable and makes it much
easier to for example add support for big endian systems
later on.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/ucsi/displayport.c | 18 +--
drivers/usb/typec/ucsi/trace.c | 11 --
drivers/usb/typec/ucsi/trace.h | 50 +-
drivers/usb/typec
The drivers now only use the new API, so removing the old one.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/ucsi/displayport.c | 8 +-
drivers/usb/typec/ucsi/trace.h | 17 --
drivers/usb/typec/ucsi/ucsi.c| 346 +++
drivers/usb/typec/ucsi/ucsi.h
We can't use bit fields with data that is received or send
to/from the device.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/ucsi/trace.h | 12 ++---
drivers/usb/typec/ucsi/ucsi.c | 52 +++
drivers/usb/typec/ucsi/ucsi.h | 93 +-
3
/or
complete pending command completions based on it.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/ucsi/ucsi_acpi.c | 96 --
1 file changed, 77 insertions(+), 19 deletions(-)
diff --git a/drivers/usb/typec/ucsi/ucsi_acpi.c
b/drivers/usb/typec/ucsi/ucsi_acpi.
nd completions based on it.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/ucsi/ucsi_ccg.c | 172 +++---
1 file changed, 87 insertions(+), 85 deletions(-)
diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c
b/drivers/usb/typec/ucsi/ucsi_ccg.c
index d772fce51905..bbe87
Supplying the operation callbacks as part of a struct
typec_operations instead of as part of struct
typec_capability during port registration.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/tcpm/tcpm.c | 47 ---
1 file changed, 21 insertions(+), 26
ucsi.c, and that should
allow for example quirks to be handled completely in the
drivers without the need to touch ucsi.c.
The old API is kept until all drivers have been converted to
the new API.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/ucsi/ucsi.c | 326
Supplying the operation callbacks as part of a struct
typec_operations instead of as part of struct
typec_capability during port registration.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/ucsi/ucsi.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff
Copying everything from struct typec_capability to struct
typec_port during port registration.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 55 +--
1 file changed, 35 insertions(+), 20 deletions(-)
diff --git a/drivers/usb/typec/class.c b
Introducing struct typec_operations which has the same
callbacks as struct typec_capability. The old callbacks are
kept for now, but after all users have been converted, they
will be removed.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 90
Leaving the private driver_data pointer of the port device
to the port drivers.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 11 +++
include/linux/usb/typec.h | 4
2 files changed, 15 insertions(+)
diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec
h ccg_read() and
ccg_write() are called with the mutex already taken at least
from ccg_send_command(). In ccg_read() and ccg_write, the
mutex is only acquired so that run_isr flag can be set.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/ucsi/ucsi_ccg.c | 42 +++--
Supplying the operation callbacks as part of a struct
typec_operations instead of as part of struct
typec_capability during port registration. After this there
is not need to keep the capabilities stored anywhere in the
driver.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/tps6598x.c
ccg.c alone. There should
not be any problem with that anymore.
thanks,
Heikki Krogerus (14):
usb: typec: Copy everything from struct typec_capability during
registration
usb: typec: Introduce typec_get_drvdata()
usb: typec: Separate the operations vector
usb: typec: tcpm: Start usin
There are no more users for them.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 65 +--
include/linux/usb/typec.h | 17 --
2 files changed, 22 insertions(+), 60 deletions(-)
diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec
Hi Ajay,
On Mon, Sep 23, 2019 at 06:15:59PM +, Ajay Gupta wrote:
> Hi Heikki,
>
> > -Original Message-
> > From: linux-usb-ow...@vger.kernel.org
> > On Behalf Of Heikki Krogerus
> > Sent: Monday, September 23, 2019 6:31 AM
> > To: Ajay Gupt
so that run_isr flag can be set.
Signed-off-by: Heikki Krogerus
---
Hi Ajay,
Before going forward with this I would like to get confirmation from
you that it is OK, and that I'm not missing anything. I did not see
any real purpose for that run_isr flag. The only thing that I can see
it preve
On Tue, Sep 17, 2019 at 09:41:49PM +, Ajay Gupta wrote:
> Hi Heikki,
>
> > -Original Message-
> > From: Heikki Krogerus
> > Sent: Friday, September 13, 2019 8:20 AM
> > To: Ajay Gupta
> > Cc: linux-usb@vger.kernel.org; Ajay Gupta
> > Sub
Hi Ajay,
On Fri, Sep 06, 2019 at 09:55:16AM -0700, Ajay Gupta wrote:
> From: Ajay Gupta
>
> CCGx controller used on NVIDIA GPU card has two separate display
> altmode for two DP pin assignments. UCSI specification doesn't
> prohibits using separate display altmode.
>
> Current UCSI Type-C frame
On Wed, Sep 04, 2019 at 09:27:14AM -0700, Ajay Gupta wrote:
> From: Ajay Gupta
>
> CCGx controller used on NVIDIA GPU card has two separate display
> altmode for two DP pin assignments. UCSI specification doesn't
> prohibits using separate display altmode.
>
> Current UCSI Type-C framework expec
sed. But, do not enable
> static DRD mode for Cherrytrail devices which rely on firmware
> for role switch.
>
> Signed-off-by: Saranya Gopal
> Signed-off-by: Balaji Manoharan
Reviewed-by: Heikki Krogerus
> ---
> changes since v3: Initialized drd_config variable to fix war
abled in
> Cherrytrail devices.
>
> Signed-off-by: Saranya Gopal
> Signed-off-by: Balaji Manoharan
> Suggested-by: Heikki Krogerus
Reviewed-by: Heikki Krogerus
> ---
> changes since v3: none
> changes since v2: Added suggested-by tag
> changes since v1:
Hi,
> static int intel_xhci_usb_set_role(struct device *dev, enum usb_role role)
> @@ -44,7 +52,7 @@ static int intel_xhci_usb_set_role(struct device *dev, enum
> usb_role role)
> struct intel_xhci_usb_data *data = dev_get_drvdata(dev);
> unsigned long timeout;
> acpi_status st
sed. But, do not enable
> static DRD mode for Cherrytrail devices which rely on firmware
> for role switch.
>
> Signed-off-by: Saranya Gopal
> Signed-off-by: Balaji Manoharan
> Signed-off-by: Heikki Krogerus
Ditto. Can't use my SoB anymore.
Note. Since I only proposed
abled in
> Cherrytrail devices.
>
> Signed-off-by: Saranya Gopal
> Signed-off-by: Balaji Manoharan
> Signed-off-by: Heikki Krogerus
You can't use my SoB anymore. With this patch you should probable put
here something like "Suggested-by: Heikki..." instead.
thanks,
--
heikki
On Tue, Aug 27, 2019 at 03:39:18PM +0200, Hans de Goede wrote:
> Hi,
>
> On 26-08-19 16:32, Heikki Krogerus wrote:
> > From: Saranya Gopal
> >
> > Enable static DRD mode in Intel platforms which guarantees
> > successful role switch all the time. This fixes iss
Signed-off-by: Balaji Manoharan
Signed-off-by: Heikki Krogerus
---
drivers/usb/host/xhci-ext-caps.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/drivers/usb/host/xhci-ext-caps.c b/drivers/usb/host/xhci-ext-caps.c
index 399113f9fc5c..f498160df969 100644
--- a/drivers/usb
devices which rely on firmware
for role switch.
Signed-off-by: Saranya Gopal
Signed-off-by: Balaji Manoharan
Signed-off-by: Heikki Krogerus
---
.../usb/roles/intel-xhci-usb-role-switch.c| 26 ++-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/roles/intel
Hi Hans,
These have been in my queue for a while now. For some reason I've been
under the impression that there was still an issue with them, but that
was a misunderstanding. Saranya and Balaji, I'm really sorry about
that.
Hans, I don't know if you remember these, but they address an issue
where
Hi Ajay,
On Mon, Aug 19, 2019 at 10:23:29PM +, Ajay Gupta wrote:
> > > diff --git a/drivers/usb/typec/ucsi/ucsi.h
> > > b/drivers/usb/typec/ucsi/ucsi.h index de87d0b8319d..7bbdf83c8d4a
> > > 100644
> > > --- a/drivers/usb/typec/ucsi/ucsi.h
> > > +++ b/drivers/usb/typec/ucsi/ucsi.h
> > > @@ -27
eve this
> is a typo. Fix this.
>
> Addresses-Coverity: ("Copy-paste error")
> Fixes: 5007e1b5db73 ("typec: tcpm: Validate source and sink caps")
> Signed-off-by: Colin Ian King
Reviewed-by: Heikki Krogerus
> ---
> drivers/usb/typec/tcpm/tcpm.c | 2 +-
&g
dev_name() (on the same device) for the debugfs
> entry name. So we also prefix dev_name() with "tcpm-" here to avoid a
> name conflict.
>
> Signed-off-by: Hans de Goede
Reviewed-by: Heikki Krogerus
> ---
> drivers/usb/typec/tcpm/tcpm.c | 17 +
>
On Thu, Aug 15, 2019 at 09:18:14PM +0200, Hans de Goede wrote:
> Use usb_debug_root as root for our debugfs entry instead of creating our
> own subdirectory under the debugfs root.
>
> Signed-off-by: Hans de Goede
I have one question below. Otherwise:
Reviewed-by: Hei
006f0
> Call Trace:
> ? find_held_lock+0x39/0x90
> ? _fusb302_log+0x81/0x1d0 [fusb302]
> ? vsnprintf+0x3aa/0x4f0
> ? _fusb302_log+0x81/0x1d0 [fusb302]
> _fusb302_log+0x81/0x1d0 [fusb302]
> ...
>
> Signed-off-by: Hans de Goede
Reviewed-by: Heikki Krogerus
&g
Hi Ajay,
I'm really sorry for being so late with the review.
On Mon, Aug 05, 2019 at 11:24:13AM -0700, Ajay Gupta wrote:
> From: Ajay Gupta
>
> CCGx controller used on NVIDIA GPU card has two separate display
> altmode for two DP pin assignments. UCSI specification doesn't
> prohibits using sep
On Thu, Aug 15, 2019 at 02:54:41PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Aug 13, 2019 at 01:52:16PM +0300, Heikki Krogerus wrote:
> > Hi Hans,
> >
> > On Tue, Aug 13, 2019 at 12:15:24PM +0200, Hans de Goede wrote:
> > > tcpm_register_port() will call some o
On Wed, Aug 14, 2019 at 03:42:46PM +0200, Hans de Goede wrote:
> Hi,
>
> On 14-08-19 15:24, Heikki Krogerus wrote:
> > Hi,
> >
> > This series removes the deprecated fusb302 specific properties, and
> > stops using struct tcpc_config in the driver.
>
> Se
Removing the deprecated fusb302 specific properties. There
are no more platforms using them.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/tcpm/fusb302.c | 31 +++
1 file changed, 3 insertions(+), 28 deletions(-)
diff --git a/drivers/usb/typec/tcpm/fusb302.c
There are no platforms using them anymore.
Signed-off-by: Heikki Krogerus
---
Documentation/devicetree/bindings/usb/fcs,fusb302.txt | 7 ---
1 file changed, 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
b/Documentation/devicetree/bindings/usb/fcs
Hi,
This series removes the deprecated fusb302 specific properties, and
stops using struct tcpc_config in the driver.
thanks,
Heikki Krogerus (3):
usb: typec: fusb302: Remove unused properties
dt-bindings: usb: fusb302: Remove deprecated properties
usb: typec: fusb302: Always provide
By registering a software fwnode for the port when the
firmware does not supply one, we can always provide tcpm the
connector capabilities by using the common USB connector
device properties instead of using tcpc_config platform data.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/tcpm
On Wed, Aug 14, 2019 at 10:17:14AM +0800, Chunfeng Yun wrote:
> On Tue, 2019-08-13 at 13:52 +0300, Heikki Krogerus wrote:
> > Hi Hans,
> >
> > On Tue, Aug 13, 2019 at 12:15:24PM +0200, Hans de Goede wrote:
> > > tcpm_register_port() will call some of the fusb302
On Tue, Aug 13, 2019 at 02:13:45PM +0200, Hans de Goede wrote:
> Hi Heikki,
>
> On 13-08-19 12:52, Heikki Krogerus wrote:
> > Hi Hans,
> >
> > On Tue, Aug 13, 2019 at 12:15:24PM +0200, Hans de Goede wrote:
> > > tcpm_register_port() will call some of the fu
On Tue, Aug 13, 2019 at 07:27:10PM +0800, Chunfeng Yun wrote:
> From: Heikki Krogerus
>
> The fwnode_usb_role_switch_get() function is exactly the
> same as usb_role_switch_get(), except that it takes struct
> fwnode_handle as parameter instead of struct device.
>
>
Hi Hans,
On Tue, Aug 13, 2019 at 12:15:24PM +0200, Hans de Goede wrote:
> tcpm_register_port() will call some of the fusb302 code's callbacks
> wich in turn will call fusb302_log(). So we need to call
> fusb302_debugfs_init() before we call tcpm_register_port().
>
> This fixes the following warni
Hi Ajay,
On Mon, Aug 05, 2019 at 11:24:13AM -0700, Ajay Gupta wrote:
> From: Ajay Gupta
>
> CCGx controller used on NVIDIA GPU card has two separate display
> altmode for two DP pin assignments. UCSI specification doesn't
> prohibits using separate display altmode.
>
> Current UCSI Type-C frame
Hi,
> +real_role = cdsn3_real_role_switch_get(cdns->dev);
> +
> +current_role = role;
> +dev_dbg(cdns->dev, "Switching role");
> +
> +ret = cdns3_role_start(cdns, real_role);
> +if (ret) {
> +/* Back to
t; of trying to create sysfs files "by hand".
>
> Cc: Heikki Krogerus
> Cc: Ajay Gupta
> Cc: Wolfram Sang
> Cc: Wei Yongjun
> Signed-off-by: Greg Kroah-Hartman
Reviewed-by: Heikki Krogerus
> ---
> drivers/usb/typec/ucsi/ucsi_ccg.c | 13 +++--
&g
On Thu, Aug 01, 2019 at 06:07:09PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 31, 2019 at 12:55:55PM +0300, Heikki Krogerus wrote:
> > On Tue, Jul 30, 2019 at 06:28:52AM -0700, Guenter Roeck wrote:
> > > On 7/30/19 5:07 AM, Heikki Krogerus wrote:
> > > > On M
me, however attempting to enable both
> of them will fail.
> The returned error message is:
> xrandr: Configure crtc 2 failed
>
>
> On Tue, 30 Jul 2019 at 15:27, Heikki Krogerus
> wrote:
> >
> > Hi Matthew,
> >
> > Copying the respective mailing list.
Fix smatch error:
drivers/usb/typec/ucsi/ucsi_ccg.c:975 ccg_fw_update() error: uninitialized
symbol 'err'.
Fixes: 5c9ae5a87573 ("usb: typec: ucsi: ccg: add firmware flashing support")
Cc: sta...@vger.kernel.org
Reported-by: kbuild test robot
Signed-off-by: Heikki Kroger
On Tue, Jul 30, 2019 at 06:28:52AM -0700, Guenter Roeck wrote:
> On 7/30/19 5:07 AM, Heikki Krogerus wrote:
> > On Mon, Jul 29, 2019 at 10:31:04AM -0700, Guenter Roeck wrote:
> > > On Mon, Jul 29, 2019 at 05:04:57PM +0300, Heikki Krogerus wrote:
> > > > Hi,
> >
Hi Matthew,
Copying the respective mailing list.
On Wed, Jul 17, 2019 at 09:22:10AM +0100, Matthew Nicholson wrote:
> Hi,
>
> Thanks for your work on the linux.
>
> I am using dell xps13 with a wd15 type-c docking station, on Archlinux.
> Under kernel version 5.2 (and 5.2.1) I was running into
On Mon, Jul 29, 2019 at 10:31:04AM -0700, Guenter Roeck wrote:
> On Mon, Jul 29, 2019 at 05:04:57PM +0300, Heikki Krogerus wrote:
> > Hi,
> >
> > On Wed, Jul 24, 2019 at 09:30:37PM -0700, Guenter Roeck wrote:
> > > TCPM may receive PD messages associat
> Cc: Alexander Aring
> Cc: Alexander Shishkin
> Cc: Alexandre Belloni
> Cc: Arnd Bergmann
> Cc: Dan Murphy
> Cc: Greg Kroah-Hartman
> Cc: Harald Freudenberger
> Cc: Heikki Krogerus
> Cc: Heiko Carstens
> Cc: Jacek Anaszewski
> Cc: Lee Jon
On Tue, Jul 23, 2019 at 10:47:26PM +0300, Andy Shevchenko wrote:
> Use fwnode_property_count_uXX() directly, that makes code neater.
>
> Signed-off-by: Andy Shevchenko
Acked-by: Heikki Krogerus
> ---
> drivers/usb/typec/mux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 del
On Tue, Jul 23, 2019 at 10:37:50PM +0300, Andy Shevchenko wrote:
> Use use fwnode_property_count_uXX() directly, that makes code neater.
>
> Signed-off-by: Andy Shevchenko
Acked-by: Heikki Krogerus
> ---
> drivers/usb/typec/tcpm/tcpm.c | 6 ++
> 1 file changed,
Miller"
> Cc: Doug Ledford
> Cc: Greg Kroah-Hartman
> Cc: Heikki Krogerus
> Cc: Jason Gunthorpe
> Cc: linux-usb@vger.kernel.org
> Cc: "Rafael J. Wysocki"
> Cc: Greg Kroah-Hartman
> Cc: Ulf Hansson
> Cc: Joe Perches
> Cc: Mathieu Poirier
> Cc:
xists.
>
> Signed-off-by: Heikki Krogerus
I don't think I actually wrote the patch. I may have proposed the code
for you, but I never prepared a patch out out that. Please drop the
above Signed-off-by line if that is the case. I case I really did
write the patch, then you are missing
ptional when registering a Type-C port. Since it is optional, we have
> to check if it is NULL before dereferencing it.
>
> Reported-by: Douglas Gilbert
> Cc: Douglas Gilbert
> Fixes: 96232cbc6c994 ("usb: typec: tcpm: support get typec and pd config from
> device propert
Hi,
On Wed, Jul 24, 2019 at 09:30:37PM -0700, Guenter Roeck wrote:
> TCPM may receive PD messages associated with unknown or unsupported
> alternate modes. If that happens, calls to typec_match_altmode()
> will return NULL. The tcpm code does not currently take this into
> account. This results in
On Thu, Jun 27, 2019 at 10:45:47PM -0700, Ajay Gupta wrote:
> CCGx controller used on NVIDIA GPU card has two separate display
> altmode for two DP pin assignments. UCSI specification doesn't
> prohibits using separate display altmode.
>
> Current UCSI Type-C framework expects only one display alt
Adding check to typec_altmode_get_partner() to prevent
potential NULL pointer dereference.
Reported-by: Vladimir Yerilov
Fixes: ad74b8649bea ("usb: typec: ucsi: Preliminary support for alternate
modes")
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/bus.c | 2 +-
1 file
On Wed, Jun 12, 2019 at 10:57:35PM +1000, Vladimir Yerilov wrote:
> Oh, you are right. I meant... You know what I meant :)
> I hope the fix will get there eventually in one way or another. Should
> you need any further tests from my side, just ask and I will make my
> faulty machine work on it.
>
n't see anything the driver is doing wrong. I'm attaching
a patch. Can you test if it fixes the issue?
Br,
--
heikki
>From d6979950ee911194dab9ae7513fe36dc3730f7a9 Mon Sep 17 00:00:00 2001
From: Heikki Krogerus
Date: Tue, 11 Jun 2019 11:10:25 +0300
Subject: [PATCH] usb: typec: Make su
Hi Vladimir,
On Sun, Jun 02, 2019 at 09:24:43PM +1000, Vladimir Yerilov wrote:
> Good day,
>
> There's a problem with ucsi starting from 5.2-rc1 (maybe earlier
> versions of 5.2 are affected too).
> Recently I've tried these versions of rc3 (commits), all have this issue:
> 3ab4436f688c2d2f221793
first bad commit
> > commit ad74b8649beaf1a22cf8641324e3321fa0269d16
> > Author: Heikki Krogerus
> > Date: Tue Apr 23 17:21:48 2019 +0300
> >
> >usb: typec: ucsi: Preliminary support for alternate modes
> >
> >With UCSI the alternate modes, just like everything
is that i2c bus driver will call pm_request_resume()
> to runtime resume ucsi_ccg driver. CCG driver will call the ISR
> for any connector change event for NVIDIA GPU card and only if it has
> old CCG firmware with the known issue.
>
> Signed-off-by: Ajay Gupta
Acked-by: Heikki Krogerus
>
bols in ucsi.c for modular build.
>
> Signed-off-by: Ajay Gupta
Was the idea that Wolfram picks these? In that case:
Acked-by: Heikki Krogerus
> ---
> Changes from v3->v4 : None
>
> drivers/usb/typec/ucsi/ucsi.c | 10
> drivers/usb/typec/ucsi/ucsi.h |
On Tue, May 21, 2019 at 05:44:50PM +, Ajay Gupta wrote:
> Hi Heikki
>
> > > +static int ucsi_ccg_resume(struct device *dev) {
> > > + struct i2c_client *client = to_i2c_client(dev);
> > > + struct ucsi_ccg *uc = i2c_get_clientdata(client);
> > > + struct ucsi *ucsi = uc->ucsi;
> > > + struct u
On Tue, May 21, 2019 at 04:37:27PM +0300, Heikki Krogerus wrote:
> Hi,
>
> On Mon, May 20, 2019 at 11:37:48AM -0700, Ajay Gupta wrote:
> > +static int ucsi_ccg_resume(struct device *dev)
> > +{
> > + struct i2c_client *client = to_i2c_client(dev);
Hi,
On Mon, May 20, 2019 at 11:37:48AM -0700, Ajay Gupta wrote:
> +static int ucsi_ccg_resume(struct device *dev)
> +{
> + struct i2c_client *client = to_i2c_client(dev);
> + struct ucsi_ccg *uc = i2c_get_clientdata(client);
> + struct ucsi *ucsi = uc->ucsi;
> + struct ucsi_control
> Cc: Biju Das
> Cc: Yu Chen
> Signed-off-by: Chunfeng Yun
Who is meant to pick this? Can you include this in your series where
you introduce that USB Type-B GPIO connector driver?
FWIW:
Reviewed-by: Heikki Krogerus
> ---
> v3:
> add property type, modify d
Hi,
On Fri, May 17, 2019 at 01:37:36PM +0300, Heikki Krogerus wrote:
> On Tue, May 14, 2019 at 04:47:21PM +0800, Chunfeng Yun wrote:
> > Add fwnode_usb_role_switch_get() to make easier to get
> > usb_role_switch by fwnode which register it.
> > It's useful when ther
de which register
> usb_role_switch.
>
> Signed-off-by: Chunfeng Yun
> Tested-by: Biju Das
Acked-by: Heikki Krogerus
> ---
> v5 changes:
> 1. remove linux/of.h suggested by Biju
> 2. add tested by Biju
>
> Note: still depends on [1]
> [1]: [v6,08/13] usb: r
y: Wei Yongjun
Acked-by: Heikki Krogerus
> ---
> drivers/usb/typec/ucsi/ucsi_ccg.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c
> b/drivers/usb/typec/ucsi/ucsi_ccg.c
> index 4632b91a04a6..9d46aa9e4e35 100644
> --- a/drivers/us
driver has.
Tested-by: Ajay Gupta
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/ucsi/Makefile | 15 +-
drivers/usb/typec/ucsi/displayport.c | 315 +++
drivers/usb/typec/ucsi/ucsi.c| 21 +-
drivers/usb/typec/ucsi/ucsi.h| 21 ++
4 files ch
and user threads.
PD port number information is added which is required while sending
PD_PORT_ENABLE command
Signed-off-by: Ajay Gupta
[ heikki: Added ABI documentation. ]
Signed-off-by: Heikki Krogerus
---
.../ABI/testing/sysfs-driver-ucsi-ccg | 6 +
drivers/usb/typec/ucsi/ucsi_ccg.c
eikki Krogerus
Signed-off-by: Ajay Gupta
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/altmodes/displayport.c | 12 +++-
drivers/usb/typec/altmodes/displayport.h | 8
2 files changed, 15 insertions(+), 5 deletions(-)
create mode 100644 drivers/usb/typec/altmodes/displayp
From: Ajay Gupta
Latest NVIDIA GPUs support VirtualLink device. Since USBIF
has not assigned a Standard ID (SID) for VirtualLink
so using NVIDA VID 0x955 as SVID.
Signed-off-by: Ajay Gupta
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/altmodes/Kconfig | 10 +++
drivers/usb/typec
to an alternate mode will
not be possible until support for that alternate mode is
added to the UCSI driver.
Tested-by: Ajay Gupta
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/ucsi/trace.c | 12 +
drivers/usb/typec/ucsi/trace.h | 26 +++
drivers/usb/typec/ucsi/ucsi.c | 385
-gpu: Supply CCGx driver the fw build info
usb: typec: ucsi: ccg: add firmware flashing support
usb: typec: displayport: Export probe and remove functions
usb: typec: Add driver for NVIDIA Alt Modes
Heikki Krogerus (2):
usb: typec: ucsi: Preliminary support for alternate modes
usb: typec: u
From: Ajay Gupta
Adding device property "ccgx,firmware-build" for the CCGx
device, so the CCGx driver knows which firmware binary to
use for a specific vendor.
Suggested-by: Heikki Krogerus
Signed-off-by: Ajay Gupta
Signed-off-by: Heikki Krogerus
---
drivers/i2c/busses/i2c-nvidia
From: Ajay Gupta
Function is to get the details of ccg firmware and device version.
It will be useful in debugging and also during firmware update.
Signed-off-by: Ajay Gupta
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/ucsi/ucsi_ccg.c | 66 ++-
1 file
On Wed, Apr 17, 2019 at 02:47:43PM +0300, Heikki Krogerus wrote:
> Hi Greg,
>
> This is the third version of this collection of UCSI driver related
> changes. I fixed the header problem I caused in Ajay's patch adding the
> NVIDIA alt mode support (patch 7/7), and I also
: ucsi: ccg: add get_fw_info function
i2c: nvidia-gpu: Supply CCGx driver the fw build info
usb: typec: ucsi: ccg: add firmware flashing support
usb: typec: displayport: Export probe and remove functions
usb: typec: Add driver for NVIDIA Alt Modes
Heikki Krogerus (2):
usb: typec: ucsi: Preli
to an alternate mode will
not be possible until support for that alternate mode is
added to the UCSI driver.
Tested-by: Ajay Gupta
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/ucsi/trace.c | 12 ++
drivers/usb/typec/ucsi/trace.h | 26 +++
drivers/usb/typec/ucsi/ucsi.c | 358
and user threads.
PD port number information is added which is required while sending
PD_PORT_ENABLE command
Signed-off-by: Ajay Gupta
[ heikki: Added ABI documentation. ]
Signed-off-by: Heikki Krogerus
---
.../ABI/testing/sysfs-driver-ucsi-ccg | 6 +
drivers/usb/typec/ucsi/ucsi_ccg.c
From: Ajay Gupta
Function is to get the details of ccg firmware and device version.
It will be useful in debugging and also during firmware update.
Signed-off-by: Ajay Gupta
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/ucsi/ucsi_ccg.c | 66 ++-
1 file
eikki Krogerus
Signed-off-by: Ajay Gupta
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/altmodes/displayport.c | 12 +++-
drivers/usb/typec/altmodes/displayport.h | 8
2 files changed, 15 insertions(+), 5 deletions(-)
create mode 100644 drivers/usb/typec/altmodes/displayp
From: Ajay Gupta
Latest NVIDIA GPUs support VirtualLink device. Since USBIF
has not assigned a Standard ID (SID) for VirtualLink
so using NVIDA VID 0x955 as SVID.
Signed-off-by: Ajay Gupta
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/altmodes/Kconfig | 10 +++
drivers/usb/typec
driver has.
Tested-by: Ajay Gupta
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/ucsi/Makefile | 15 +-
drivers/usb/typec/ucsi/displayport.c | 306 +++
drivers/usb/typec/ucsi/ucsi.c| 21 +-
drivers/usb/typec/ucsi/ucsi.h| 21 ++
4 files ch
From: Ajay Gupta
Adding device property "ccgx,firmware-build" for the CCGx
device, so the CCGx driver knows which firmware binary to
use for a specific vendor.
Suggested-by: Heikki Krogerus
Signed-off-by: Ajay Gupta
Signed-off-by: Heikki Krogerus
---
drivers/i2c/busses/i2c-nvidia
> the original functionality is fully restored.
>
> Fixes: ea3b4d5523bc ("usb: typec: fusb302: Resolve fixed power role ...")
> Cc: Adam Thomson
> Signed-off-by: Hans de Goede
Acked-by: Heikki Krogerus
> ---
> Changes in v2:
> -No changes
> ---
> dr
oggling for all port-types, so that connection-detection works
> on single-role ports too.
>
> Fixes: ea3b4d5523bc("usb: typec: fusb302: Resolve fixed power role ...")
> Cc: Adam Thomson
> Signed-off-by: Hans de Goede
Acked-by Heikki Krogerus
> ---
> Chang
_toggling,
> but also get a port_type check added and return -EOPNOTSUPP when port_type
> is not DRP.
>
> Fixes: ea3b4d5523bc("usb: typec: fusb302: Resolve fixed power role ...")
> Cc: Adam Thomson
> Signed-off-by: Hans de Goede
Acked-by Heikki Krogerus
> --
On Tue, Apr 16, 2019 at 12:19:53PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Feb 22, 2019 at 03:11:58PM +0100, Hans de Goede wrote:
> > The 2 callers of fusb302_set_cc_polarity both call fusb302_set_cc_pull
> > directly before calling fusb302_set_cc_polarity, this is not ideal for
> > 2 reasons:
>
On Tue, Apr 16, 2019 at 09:27:03AM +0300, Heikki Krogerus wrote:
> On Tue, Apr 16, 2019 at 12:45:12AM +, Ajay Gupta wrote:
> > Hi Heikki,
> >
> > > -Original Message-
> > > From: linux-usb-ow...@vger.kernel.org On
> > > Behalf Of Heikki Kro
On Tue, Apr 16, 2019 at 12:45:12AM +, Ajay Gupta wrote:
> Hi Heikki,
>
> > -Original Message-
> > From: linux-usb-ow...@vger.kernel.org On
> > Behalf Of Heikki Krogerus
> > Sent: Monday, April 15, 2019 5:10 AM
> > To: Greg Kroah-Hartman
> >
g: add get_fw_info function
usb: typec: ucsi: ccg: add firmware flashing support
usb: typec: displayport: Export probe and remove functions
usb: typec: Add driver for NVIDIA Alt Modes
Heikki Krogerus (2):
usb: typec: ucsi: Preliminary support for alternate modes
usb: typec: ucsi: Support f
101 - 200 of 1358 matches
Mail list logo
