[PATCH v4] usb: chipidea: Use extcon framework for VBUS and ID detect

2015-09-07 Thread Ivan T. Ivanov
On recent Qualcomm platforms VBUS and ID lines are not routed to USB PHY LINK controller. Use extcon framework to receive connect and disconnect ID and VBUS notification. Signed-off-by: Ivan T. Ivanov --- Changes sice v3 [1]: * Migrate to new extcon framework API * Address comments from Peter

Re: [PATCH v3] usb: chipidea: Use extcon framework for VBUS and ID detect

2015-09-07 Thread Ivan T. Ivanov
On Fri, 2015-06-05 at 17:26 +0800, Peter Chen wrote: > On Fri, Jun 05, 2015 at 10:37:07AM +0300, Ivan T. Ivanov wrote: > > > > > + > > > > +static int ci_id_notifier(struct notifier_block *nb, unsigned long > > > > event, > > >

[PATCH] usb: phy: qcom: Switch to new extcon framework API

2015-09-07 Thread Ivan T. Ivanov
[un]register_interest and reading cable state by name have been deprecated. Switch to new API. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-qcom-8x16-usb.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/usb/phy/phy-qcom-8x16-usb.c b

[PATCH v2] usb: phy: msm: Unregister VBUS and ID events notifiers

2015-09-07 Thread Ivan T. Ivanov
ction") Reported-by: Tim Bird Signed-off-by: Ivan T. Ivanov --- Patch reworked to use new extcon API. drivers/usb/phy/phy-msm-usb.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-u

Re: [PATCH] usb: phy: msm: Unregister driver interest for VBUS and ID events

2015-09-07 Thread Ivan T. Ivanov
On Mon, 2015-08-24 at 10:11 -0700, Tim Bird wrote: > On 08/18/2015 12:56 AM, Ivan T. Ivanov wrote: > > Right now even if driver failed to probe extcon framework will > > still deliver its VBUS and ID events, which will lead to random > > exception codes. > > >

Re: repeat... Re: BUG: usb: phy: msm: problem with EPROBE defer and extcon cleanup

2015-08-18 Thread Ivan T. Ivanov
On Mon, 2015-08-17 at 16:46 -0700, Tim Bird wrote: > Sorry - I mistyped Ivan's e-mail the first time. > > On 08/17/2015 04:43 PM, Tim Bird wrote: > > Ivan, > > > > I'm seeing a bug in the phy-msm-usb.c code, when I get an EPROBE defer > > during probing the driver. > > The code is statically li

[PATCH] usb: phy: msm: Unregister driver interest for VBUS and ID events

2015-08-18 Thread Ivan T. Ivanov
nd ID detection") Reported-by: Tim Bird Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index 00c49bb1bd29..a9082567f

Re: [PATCH v3] usb: chipidea: Use extcon framework for VBUS and ID detect

2015-07-29 Thread Ivan T. Ivanov
On Wed, 2015-07-29 at 12:10 -0700, Tim Bird wrote: > On Tue, Jun 2, 2015 at 6:14 AM, Ivan T. Ivanov iva...@linaro.org> wrote: > > On recent Qualcomm platforms VBUS and ID lines are not routed to > > USB PHY LINK controller. Use extcon framework to receive connect > > an

[PATCH v2] usb: phy: msm: Add D+/D- lines route control

2015-07-28 Thread Ivan T. Ivanov
apq8016-sbc board is using Dual SPDT USB Switch (TC7USB40MU), witch is controlled by GPIO to de/multiplex D+/D- USB lines to USB2513B Hub and uB connector. Add support for this. Signed-off-by: Ivan T. Ivanov --- * Rebased on current testing/next. .../devicetree/bindings/usb/msm-hsusb.txt

[PATCH] usb: phy: qcom: New APQ8016/MSM8916 USB transceiver driver

2015-07-08 Thread Ivan T. Ivanov
Driver handles PHY initialization, clock management, power management and workarounds required after resetting the hardware. Signed-off-by: Ivan T. Ivanov --- .../devicetree/bindings/usb/qcom,usb-8x16-phy.txt | 76 drivers/usb/phy/Kconfig| 14 + drivers/usb

[PATCH] usb: phy: msm: Add D+/D- lines route control

2015-07-08 Thread Ivan T. Ivanov
apq8016-sbc board is using Dual SPDT USB Switch (TC7USB40MU), witch is controlled by GPIO to de/multiplex D+/D- USB lines to USB2513B Hub and uB connector. Add support for this. Signed-off-by: Ivan T. Ivanov --- .../devicetree/bindings/usb/msm-hsusb.txt | 4 ++ drivers/usb/phy/phy-msm

Re: [PATCH v2 1/2] extcon: fix hang and extcon_get/set_cable_state().

2015-07-07 Thread Ivan T. Ivanov
6ecdb93e8 ("extcon: Redefine the unique id of supported > external connectors without 'enum extcon' type") > Cc: Greg Kroah-Hartman > Signed-off-by: Roger Quadros > --- Thank you. It is fine now. For both patches. Tested-by: Ivan T. Ivanov -- To unsubscribe

Re: [PATCH 1/2] extcon: fix hang and extcon_get/set_cable_state().

2015-07-07 Thread Ivan T. Ivanov
On Mon, 2015-07-06 at 17:46 +0300, Roger Quadros wrote: > > -static int find_cable_index_by_name(struct extcon_dev *edev, const char > *name) > +static int find_cable_id_by_name(struct extcon_dev *edev, const char *name) > { > - unsigned int id = EXTCON_NONE; > + unsigned int id =

[PATCH v3] usb: chipidea: Use extcon framework for VBUS and ID detect

2015-06-02 Thread Ivan T. Ivanov
On recent Qualcomm platforms VBUS and ID lines are not routed to USB PHY LINK controller. Use extcon framework to receive connect and disconnect ID and VBUS notification. Signed-off-by: Ivan T. Ivanov --- Changes sice v2 [1]. * Simulate IRQ on extcon event - used to trigger OTG state machine

Re: [PATCH v3 4/6] dt-bindings: Consolidate ChipIdea USB ci13xxx bindings

2015-06-01 Thread Ivan T. Ivanov
ned-off-by: Rob Herring > Cc: Ivan T. Ivanov > Cc: Peter Chen c...@freescale.com> > Cc: Daniel Tang ta...@gmail.com> > Cc: Pawel Moll m...@arm.com> > Cc: Mark Rutland rutl...@arm.com> > Cc: Ian Campbell > Cc: Kumar Gala > Cc: devicet...@vger.kernel.org &

Re: [PATCH v2] usb: chipidea: Use extcon framework for VBUS and ID detect

2015-05-26 Thread Ivan T. Ivanov
On Wed, 2015-04-15 at 16:35 +0300, Ivan T. Ivanov wrote: > On recent Qualcomm platforms VBUS and ID lines are not routed to > USB PHY LINK controller. Use extcon framework to receive connect > and disconnect ID and VBUS notification. > > Signed-off-by: Ivan T. Ivanov iv

[PATCH v2] Revert "usb: host: ehci-msm: Use devm_ioremap_resource instead of devm_ioremap"

2015-04-27 Thread Ivan T. Ivanov
mmand registers. Cc: Vivek Gautam Signed-off-by: Ivan T. Ivanov --- Changes since v0: * Add note to patch description that also commit e507bf577e5a is reverted. drivers/usb/host/ehci-msm.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/ehci

Re: [PATCH] Revert "usb: host: ehci-msm: Use devm_ioremap_resource instead of devm_ioremap"

2015-04-21 Thread Ivan T. Ivanov
On Tue, 2015-04-21 at 11:04 -0400, Alan Stern wrote: > On Tue, 21 Apr 2015, Ivan T. Ivanov wrote: > > > This reverts commit 70843f623b58 ("usb: host: ehci-msm: Use > > devm_ioremap_resource instead of devm_ioremap"), because msm_otg > > and this driver are usin

Re: [PATCH] Revert "usb: host: ehci-msm: Use devm_ioremap_resource instead of devm_ioremap"

2015-04-21 Thread Ivan T. Ivanov
On Tue, 2015-04-21 at 16:46 +0530, Vivek Gautam wrote: > Hi, > > On Tuesday, April 21, 2015 12:41 PM "Ivan T. Ivanov" > iva...@linaro.org> wrote: > > This reverts commit 70843f623b58 ("usb: host: ehci-msm: Use > > devm_ioremap_resource instead of de

Re: [PATCH 1/2] usb: phy: msm: Use extcon framework for VBUS and ID detection

2015-04-21 Thread Ivan T. Ivanov
On Thu, 2015-04-09 at 11:34 +0300, Ivan T. Ivanov wrote: > On recent Qualcomm platforms VBUS and ID lines are not routed to > USB PHY LINK controller. Use extcon framework to receive connect > and disconnect ID and VBUS notification. > > Signed-off-by: Ivan T. Ivanov iva...@

[PATCH] Revert "usb: host: ehci-msm: Use devm_ioremap_resource instead of devm_ioremap"

2015-04-21 Thread Ivan T. Ivanov
This reverts commit 70843f623b58 ("usb: host: ehci-msm: Use devm_ioremap_resource instead of devm_ioremap"), because msm_otg and this driver are using same address space to access AHB mode and USB command registers. Cc: Vivek Gautam Signed-off-by: Ivan T. Ivanov --- drivers/usb/host/

Re: [PATCH] usb: ehci-msm: Don't ioremap configuration space exclusively

2015-04-20 Thread Ivan T. Ivanov
On Mon, 2015-04-20 at 10:14 -0400, Alan Stern wrote: > On Mon, 20 Apr 2015, Ivan T. Ivanov wrote: > > > Hi Alan, > > > > Perhaps I have to resend this patch with updated commit > > message? Are they any other obstacles? > > Instead of submitting this new patc

Re: [PATCH] usb: ehci-msm: Don't ioremap configuration space exclusively

2015-04-20 Thread Ivan T. Ivanov
On Thu, 2015-04-16 at 10:42 +0300, Ivan T. Ivanov wrote: > Hi, > > On Wed, 2015-04-15 at 21:28 +0530, Vivek Gautam wrote: > > On Thu, Apr 9, 2015 at 8:19 PM, Alan Stern > > wrote: > > > On Thu, 9 Apr 2015, Ivan T. Ivanov wrote: > > > > > > >

Re: [PATCH] usb: ehci-msm: Don't ioremap configuration space exclusively

2015-04-16 Thread Ivan T. Ivanov
Hi, On Wed, 2015-04-15 at 21:28 +0530, Vivek Gautam wrote: > On Thu, Apr 9, 2015 at 8:19 PM, Alan Stern wrote: > > On Thu, 9 Apr 2015, Ivan T. Ivanov wrote: > > > > > This allow same IO space to be shared between HCD and Device > > > controller driver. Which

Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection

2015-04-16 Thread Ivan T. Ivanov
Hi, On Thu, 2015-04-16 at 16:00 +0900, Chanwoo Choi wrote: > Hi Peter, > > On 04/16/2015 10:59 AM, Peter Chen wrote: > > > > Ok, from USB point, external id/vbus value can't decide > > which role the controller will be, the controller driver > > will decide role according to many things, eg, us

Re: [PATCH v2] usb: chipidea: Use extcon framework for VBUS and ID detect

2015-04-15 Thread Ivan T. Ivanov
Hi Robert, On Wed, 2015-04-15 at 16:11 +0200, Robert Baldyga wrote: > Hi Ivan, > > On 04/15/2015 03:35 PM, Ivan T. Ivanov wrote: > > On recent Qualcomm platforms VBUS and ID lines are not routed to > > USB PHY LINK controller. Use extcon framework to receive connect >

[PATCH v2] usb: chipidea: Use extcon framework for VBUS and ID detect

2015-04-15 Thread Ivan T. Ivanov
On recent Qualcomm platforms VBUS and ID lines are not routed to USB PHY LINK controller. Use extcon framework to receive connect and disconnect ID and VBUS notification. Signed-off-by: Ivan T. Ivanov --- Changes since v0 [1], as per Peter Chen suggestions: * Moved external connector parsing

Re: [PATCH] usb: chipidea: Use extcon framework for VBUS and ID detection

2015-04-13 Thread Ivan T. Ivanov
> On Apr 13, 2015, at 6:53 AM, Peter Chen wrote: > > On Thu, Apr 09, 2015 at 11:33:38AM +0300, Ivan T. Ivanov wrote: >> On recent Qualcomm platforms VBUS and ID lines are not routed to >> USB PHY LINK controller. Use extcon framework to receive connect >> and disconne

[PATCH] usb: ehci-msm: Don't ioremap configuration space exclusively

2015-04-09 Thread Ivan T. Ivanov
This allow same IO space to be shared between HCD and Device controller driver. Which can be loaded simultaneously and started/stopped on demand by USB OTG PHY driver. Signed-off-by: Ivan T. Ivanov --- drivers/usb/host/ehci-msm.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions

[PATCH 1/2] usb: phy: msm: Use extcon framework for VBUS and ID detection

2015-04-09 Thread Ivan T. Ivanov
On recent Qualcomm platforms VBUS and ID lines are not routed to USB PHY LINK controller. Use extcon framework to receive connect and disconnect ID and VBUS notification. Signed-off-by: Ivan T. Ivanov --- .../devicetree/bindings/usb/msm-hsusb.txt | 7 ++ drivers/usb/phy/Kconfig

[PATCH 2/2] usb: phy: msm: Manual PHY and LINK controller VBUS change notification

2015-04-09 Thread Ivan T. Ivanov
VBUS is not routed to USB PHY on recent Qualcomm platforms. USB controller must see VBUS in order to pull-up DP when setting RS bit. Henc configure USB PHY and LINK registers sense VBUS and enable manual pullup on D+ line. Cc: Vamsi Krishna Cc: Mayank Rana Signed-off-by: Ivan T. Ivanov

[PATCH] usb: chipidea: Use extcon framework for VBUS and ID detection

2015-04-09 Thread Ivan T. Ivanov
On recent Qualcomm platforms VBUS and ID lines are not routed to USB PHY LINK controller. Use extcon framework to receive connect and disconnect ID and VBUS notification. Signed-off-by: Ivan T. Ivanov --- Suggestions for better solution are welcome! .../devicetree/bindings/usb/ci-hdrc

[PATCH] usb: phy: Fix USB_ULPI_VIEWPORT Kconfig dependency

2015-03-21 Thread Ivan T. Ivanov
USB_ULPI_VIEWPORT didn't depend on USB_ULPI, while USB_ULPI is using non user selectable USB_ULPI_VIEWPORT. Fix this. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kc

Re: [PATCH v4 1/1] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-03-17 Thread Ivan T. Ivanov
Fixed spelling error. On Tue, 2015-03-17 at 09:52 +0200, Ivan T. Ivanov wrote: > Hi, > > On Tue, 2015-03-17 at 11:01 +0900, Chanwoo Choi wrote: > > Hi Ivan, > > > > On 03/16/2015 11:23 PM, Ivan T. Ivanov wrote: > > > Hi Roger, > > > > > >

Re: [PATCH v4 1/1] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-03-17 Thread Ivan T. Ivanov
Hi, On Tue, 2015-03-17 at 11:01 +0900, Chanwoo Choi wrote: > Hi Ivan, > > On 03/16/2015 11:23 PM, Ivan T. Ivanov wrote: > > Hi Roger, > > > > On Mon, 2015-03-16 at 15:11 +0200, Roger Quadros wrote: > > > Hi Ivan, > > > > > &g

Re: [PATCH v4 1/1] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-03-16 Thread Ivan T. Ivanov
Hi Roger, On Mon, 2015-03-16 at 15:11 +0200, Roger Quadros wrote: > Hi Ivan, > > On 16/03/15 14:32, Ivan T. Ivanov wrote: > > Hi, > > > > On Mon, 2015-02-02 at 12:21 +0200, Roger Quadros wrote: > > > This driver observes the USB ID pin connected over a

Re: [PATCH v4 1/1] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-03-16 Thread Ivan T. Ivanov
Hi, On Mon, 2015-02-02 at 12:21 +0200, Roger Quadros wrote: > This driver observes the USB ID pin connected over a GPIO and > updates the USB cable extcon states accordingly. > > The existing GPIO extcon driver is not suitable for this purpose > as it needs to be taught to understand USB cable s

Re: [PATCH] USB: Remove .owner field for driver

2014-09-25 Thread Ivan T. Ivanov
for drivers which > use the module_platform_driver API, as this is overriden in > platform_driver_register anyway." > > Signed-off-by: Kiran Padwal Thank you Kiran. Reviewed-by: Ivan T. Ivanov -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in

Re: Fwd: Status of chipidea msm USB reset patch

2014-09-10 Thread Ivan T. Ivanov
On Fri, 2014-09-05 at 09:01 +0800, Peter Chen wrote: > On Thu, Sep 04, 2014 at 07:47:40AM -0700, Tim Bird wrote: > > On Fri, Aug 15, 2014 at 12:08 AM, Ivan T. Ivanov wrote: > > > On Fri, 2014-08-15 at 08:23 +0800, Peter Chen wrote: > > >> On Thu, Aug 14, 2014 at

[PATCH 2/2] usb: chipidea: msm: Initialize PHY on reset event

2014-08-25 Thread Ivan T. Ivanov
Initialize USB PHY after every Link controller reset Signed-off-by: Ivan T. Ivanov --- drivers/usb/chipidea/ci_hdrc_msm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c index 30bdd51..4935ac3 100644 --- a/drivers/usb

[PATCH 1/2] usb: chipidea: msm: Use USB PHY API to control PHY state

2014-08-25 Thread Ivan T. Ivanov
PHY drivers keep track of the current state of the hardware, so don't change PHY settings under it. Signed-off-by: Ivan T. Ivanov Acked-by: Felipe Balbi --- drivers/usb/chipidea/ci_hdrc_msm.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/chi

Re: [PATCH RESEND] usb: chipidea: msm: Use USB PHY API to control PHY state

2014-08-25 Thread Ivan T. Ivanov
On Tue, 2014-08-19 at 14:06 -0500, Felipe Balbi wrote: > On Fri, Aug 15, 2014 at 12:21:19PM +0300, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > PHY drivers keep track of the current state of the hardware, > > so don't change PHY setting

[PATCH RESEND] usb: chipidea: msm: Use USB PHY API to control PHY state

2014-08-15 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" PHY drivers keep track of the current state of the hardware, so don't change PHY settings under it. Signed-off-by: Ivan T. Ivanov --- drivers/usb/chipidea/ci_hdrc_msm.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drive

Re: Fwd: Status of chipidea msm USB reset patch

2014-08-15 Thread Ivan T. Ivanov
On Fri, 2014-08-15 at 08:23 +0800, Peter Chen wrote: > On Thu, Aug 14, 2014 at 11:54:02AM -0500, Felipe Balbi wrote: > > Hi, > > > > On Thu, Aug 14, 2014 at 09:53:10AM -0700, Tim Bird wrote: > > > Ping. Anybody know the status of this patch? Is it queued in someone's > > > tree? > > > Without i

Re: [Patch v7 3/3] usb: dwc3: qcom: Add device tree binding

2014-07-02 Thread Ivan T. Ivanov
Hi, On Tue, 2014-07-01 at 14:47 -0500, Rob Herring wrote: > On Tue, Jul 1, 2014 at 1:01 PM, Andy Gross wrote: > > On Tue, Jul 01, 2014 at 12:04:35AM -0500, Rob Herring wrote: > > > > > >> > + > >> > + ranges; > >> > + > >> > + status = "disabled";

Re: [patch] usb: phy: msm: fix bug in probe()

2014-05-20 Thread Ivan T. Ivanov
nd CI device controller driver. > > Fixes: 10f0577aa5cb ('usb: phy: msm: change devm_ioremap() to > devm_ioremap_resource()') > Reported-by:"Ivan T. Ivanov" > Signed-off-by: Dan Carpenter > > diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/

Re: [patch v2] usb: phy: msm: change devm_ioremap() to devm_ioremap_resource()

2014-05-19 Thread Ivan T. Ivanov
On Wed, 2014-05-14 at 16:54 +0300, Dan Carpenter wrote: > There are several issues here: > 1) platform_get_resource() can return NULL and that wasn't handled. > 2) We should request the memory before we remap it, and >devm_ioremap_resource() does that. > 3) devm_ioremap() returns a NULL but we

Re: [PATCH v2] usb: phy: msm: reset controller is mandatory now

2014-05-14 Thread Ivan T. Ivanov
l_get(&pdev->dev, "link"); > ^ > > Since the usb-ehci-msm driver currently selects the OTG driver, > we could still get a broken dependency here. To solve that, > this patch also removes the 'select', which turns out to be > unnecessary. > > Sig

Re: usb: phy: msm: Migrate to Managed Device Resource allocation

2014-05-14 Thread Ivan T. Ivanov
On Tue, 2014-05-13 at 23:20 +0300, Dan Carpenter wrote: > Hello Ivan T. Ivanov, > > The patch 6b99c68ec1f9: "usb: phy: msm: Migrate to Managed Device > Resource allocation" from Apr 28, 2014, leads to the following static > checker warning: > > dri

Re: [PATCH] usb: phy: msm: make it depend on RESET_CONTROLLER

2014-05-13 Thread Ivan T. Ivanov
On Tue, 2014-05-13 at 12:07 -0400, Alan Stern wrote: > On Tue, 13 May 2014, Bird, Tim wrote: > > > I don't think so. I haven't tested, but I believe the driver now relies > > on operational (not stub) resets. I think this comment is a bit off. > > I think it would be better to just say that the

Re: [PATCH 5/8] usb: phy: msm: reset controller is mandatory now

2014-05-08 Thread Ivan T. Ivanov
On Thu, 2014-05-08 at 16:27 +0200, Arnd Bergmann wrote: > On Thursday 08 May 2014 17:21:49 Ivan T. Ivanov wrote: > > > @@ -168,7 +168,7 @@ config USB_EHCI_HCD_AT91 > > > > > > config USB_EHCI_MSM > > > tristate "Support for Qualcomm QSD/MSM on-c

Re: [PATCH 5/8] usb: phy: msm: reset controller is mandatory now

2014-05-08 Thread Ivan T. Ivanov
reset_control_get(&pdev->dev, "link"); > ^ > > Signed-off-by: Arnd Bergmann > Cc: "Ivan T. Ivanov" > --- > drivers/usb/host/Kconfig | 2 +- > drivers/usb/phy/Kconfig | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff

Re: [PATCH 3/3] usb: phy: msm: enable build on other architectures

2014-05-03 Thread Ivan T. Ivanov
> Signed-off-by: Felipe Balbi Reviewed-by: Ivan T. Ivanov > --- > drivers/usb/phy/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig > index 0c668a3..fbbced8 100644 > --- a/drivers/usb/phy/

Re: [PATCH 2/3] usb: phy: msm: switch over to writel()

2014-05-02 Thread Ivan T. Ivanov
On Wed, 2014-04-30 at 11:38 -0500, Felipe Balbi wrote: > Remove that single instance of writel_relaxed() > call which is only available on ARM architecture. > > This will let us build test this driver on all > different architectures. > > Signed-off-by: Felipe Balbi Review

Re: [PATCH 1/3] usb: phy: msm: cast to unsigned long int

2014-05-02 Thread Ivan T. Ivanov
On Wed, 2014-04-30 at 11:38 -0500, Felipe Balbi wrote: > this solves the following build warning found when > running compile tests. > > drivers/usb/phy/phy-msm-usb.c: In function ‘msm_otg_read_dt’: > drivers/usb/phy/phy-msm-usb.c:1459:20: warning: cast from pointer \ > to integer of differe

Re: [PATCH v8 17/20] usb: phy: msm: Select secondary PHY via TCSR

2014-05-02 Thread Ivan T. Ivanov
On Mon, 2014-04-28 at 16:34 +0300, Ivan T. Ivanov wrote: > From: Tim Bird > > Select the secondary PHY using the TCSR register, if phy-num=1 > in the DTS (or phy_number is set in the platform data). The > SOC has 2 PHYs which can be used with the OTG port, and this > code allo

Re: [PATCH v7 16/20] usb: phy: msm: Fix PTS definitions for MSM USB controller

2014-05-01 Thread Ivan T. Ivanov
On Wed, 2014-04-30 at 11:27 -0500, Felipe Balbi wrote: > On Thu, Apr 24, 2014 at 06:48:11PM +0300, Ivan T. Ivanov wrote: > > From: Tim Bird > > > > Fix the value used for Parallel Transceiver Select (PTS) for the MSM USB > > controller. This is a standard chipidea POR

Re: [PATCH v4 0/3] usb: chipidea: msm: Clean and fix glue layer driver

2014-04-28 Thread Ivan T. Ivanov
On Tue, 2014-04-29 at 08:45 +0800, Peter Chen wrote: > > Applied, thanks Thank you, Ivan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v8 02/20] usb: phy: msm: Remove __init macro from driver probe method

2014-04-28 Thread Ivan T. Ivanov
On Mon, 2014-04-28 at 12:54 -0500, Felipe Balbi wrote: > On Mon, Apr 28, 2014 at 08:52:48PM +0300, Ivan T. Ivanov wrote: > > On Mon, 2014-04-28 at 12:03 -0500, Felipe Balbi wrote: > > > On Mon, Apr 28, 2014 at 09:00:43PM +0400, Sergei Shtylyov wrote: > > > > Hello.

Re: [PATCH v8 02/20] usb: phy: msm: Remove __init macro from driver probe method

2014-04-28 Thread Ivan T. Ivanov
On Mon, 2014-04-28 at 12:03 -0500, Felipe Balbi wrote: > On Mon, Apr 28, 2014 at 09:00:43PM +0400, Sergei Shtylyov wrote: > > Hello. > > > > On 04/28/2014 05:34 PM, Ivan T. Ivanov wrote: > > > > >From: "Ivan T. Ivanov" > > > > >T

Re: [PATCH v4 0/3] usb: chipidea: msm: Clean and fix glue layer driver

2014-04-28 Thread Ivan T. Ivanov
On Fri, 2014-04-25 at 03:10 +, Peter Chen wrote: > > > > > On Thu, 2014-04-24 at 08:38 +0800, Peter Chen wrote: > > > On Wed, Apr 23, 2014 at 03:28:01PM +0300, Ivan T. Ivanov wrote: > > > > From: "Ivan T. Ivanov" > > > > > &

[PATCH v8 10/20] usb: phy: msm: Remove HSUSB prefix from regulator names

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Prefix did not bring any useful information. Currently none of the MSM platforms define these regulators, so it is safe to rename them. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletion

[PATCH v8 13/20] usb: phy: msm: Use reset framework for LINK and PHY resets

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Using reset framework eliminate need of platform specific callbacks and enable reset lines to be specified in DT files. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 29 + include/linux/usb/msm_hsusb.h | 3 ++

[PATCH v8 12/20] usb: phy: msm: Add device tree support and binding information

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Allows controller to be specified via device tree. Signed-off-by: Ivan T. Ivanov --- .../devicetree/bindings/usb/msm-hsusb.txt | 67 drivers/usb/phy/phy-msm-usb.c | 113 + include/linux/usb/m

[PATCH v8 00/20] usb: phy: msm: Fixes, cleanups and DT support

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Hi, This is a new version of patches posted earlier[1]. Changes since v7 - Use bulk regulator request function in patch #05 - Fix errors in patch #20 commit message [1] http://www.spinics.net/lists/linux-arm-msm/msg08997.html Ivan T. Ivanov (18): usb

[PATCH v8 01/20] usb: phy: msm: Make driver selectable on ARCH_QCOM

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Controller could be found on APQ and MSM platforms, make configuration description more generic. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/phy/Kconfig b/drive

[PATCH v8 04/20] usb: phy: msm: Enable deferred driver probing

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Using platform_driver_probe() prevent driver from requesting probe deferral. Fix this. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drive

[PATCH v8 08/20] usb: phy: msm: Replace custom enum usb_mode_type with enum usb_dr_mode

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Use enum usb_dr_mode and drop default usb_dr_mode from platform data. USB DT bindings states: dr_mode: "...In case this attribute isn't passed via DT, USB DRD controllers should default to OTG...", so remove redundand field. Signed-off-by: Ivan T

[PATCH v8 06/20] usb: phy: msm: Remove unnecessarily check for valid regulators.

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Whether regulators are available or not is checked at driver probe. If they are not available driver will refuse to load, so no need to check them again. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 10 -- 1 file changed, 10

[PATCH v8 05/20] usb: phy: msm: Migrate to Managed Device Resource allocation

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Move memory, regulators, clocks and irq allocation to devm_* variants. Properly check for valid clk handles. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 187 +++--- 1 file changed, 68 insertions(+), 119

[PATCH v8 11/20] usb: phy: msm: Properly check result from platform_get_irq()

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Function return negative code on error. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index bd9e286..7e968aa 10

[PATCH v8 15/20] usb: phy: msm: Correct USB PHY Reset sequence for newer platform

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" On few legacy platforms, USB PHY is having dedicated reset clk. It is used to reset USB PHY after putting USB PHY into low power mode and for calibration of USB PHY. Putting USB PHY into low power mode is causing ulpi read/write timeout as expected. USB PHY re

[PATCH v8 07/20] usb: phy: msm: Fix checkpatch.pl warnings

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This fixes following: WARNING: quoted string split across lines WARNING: Prefer seq_puts to seq_printf Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 39 ++- 1 file changed, 14 insertions(+), 25 deletion

[PATCH v8 09/20] usb: phy: msm: Remove unused pclk_src_name

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" There are no references to 'pclk_src_name' in plaform code, so it is unused. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 26 +- include/linux/usb/msm_hsusb.h | 5 - 2 files changed, 1 insertion(+), 3

[PATCH v8 18/20] usb: phy: msm: Handle disconnect events

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Put the transceiver in non-driving mode. Otherwise host may not detect soft-disconnection. Signed-off-by: Ivan T. Ivanov Cc: Pavankumar Kondeti --- drivers/usb/phy/phy-msm-usb.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/u

[PATCH v8 16/20] usb: phy: msm: Fix PTS definitions for MSM USB controller

2014-04-28 Thread Ivan T. Ivanov
From: Tim Bird Fix the value used for Parallel Transceiver Select (PTS) for the MSM USB controller. This is a standard chipidea PORTSC definition, where a PHY_TYPE of 10b (<<30) is ULPI and 11b (<<30) is SERIAL. Fix the definitions and use them correctly in the driver code. Signed-off-by: Tim B

[PATCH v8 20/20] usb: phy: msm: Use usb_add_phy_dev() to register device

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" There could be more than one USB2.0 PHY's on the platform. This will allow all of them to be registered successfully. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/

[PATCH v8 02/20] usb: phy: msm: Remove __init macro from driver probe method

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This fixes following: WARNING: drivers/usb/phy/built-in.o(.data+0x68): Section mismatch in reference from the variable msm_otg_driver to the function .init.text:msm_otg_probe() The variable msm_otg_driver references the function __init msm_otg_probe() Sig

[PATCH v8 14/20] usb: phy: msm: Add support for secondary PHY control

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Allow support to use 2nd HSPHY with USB2 Core. Some platforms may have configuration to allow USB controller work with any of the two HSPHYs present. By default driver configures USB core to use primary HSPHY. Add support to allow user select 2nd HSPHY using DT

[PATCH v8 17/20] usb: phy: msm: Select secondary PHY via TCSR

2014-04-28 Thread Ivan T. Ivanov
From: Tim Bird Select the secondary PHY using the TCSR register, if phy-num=1 in the DTS (or phy_number is set in the platform data). The SOC has 2 PHYs which can be used with the OTG port, and this code allows configuring the correct one. Note: This resolves the problem I was seeing where I co

[PATCH v8 19/20] usb: phy: msm: Vote for corner of VDD CX instead of voltage of VDD CX

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" New platform uses RBCPR hardware feature, with that voting for absolute voltage of VDD CX is not required. Hence vote for corner of VDD CX which uses nominal corner voltage on VDD CX. Signed-off-by: Ivan T. Ivanov Cc: Mayank Rana --- .../devicetree/bindin

[PATCH v8 03/20] usb: phy: msm: Move global regulators variables to driver state

2014-04-28 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Eliminating global variables allows driver to handle multiple device instances. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 82 --- include/linux/usb/msm_hsusb.h | 3 ++ 2 files changed, 42 inserti

Re: [PATCH v7 20/20] usb: phy: msm: Use usb_add_phy_dev() to register device

2014-04-28 Thread Ivan T. Ivanov
On Fri, 2014-04-25 at 15:53 -0500, Felipe Balbi wrote: > On Thu, Apr 24, 2014 at 09:06:24PM +0400, Sergei Shtylyov wrote: > > Hello. > > > > On 04/24/2014 07:48 PM, Ivan T. Ivanov wrote: > > > > >From: "Ivan T. Ivanov" > > > >

Re: [PATCH v7 05/20] usb: phy: msm: Migrate to Managed Device Resource allocation

2014-04-28 Thread Ivan T. Ivanov
On Fri, 2014-04-25 at 15:53 -0500, Felipe Balbi wrote: > On Thu, Apr 24, 2014 at 01:49:38PM -0300, Fabio Estevam wrote: > > On Thu, Apr 24, 2014 at 12:48 PM, Ivan T. Ivanov wrote: > > > > > + motg->vddcx = devm_regulator_get(motg->phy.dev, "HSUSB_VDD

[PATCH v7 06/20] usb: phy: msm: Remove unnecessarily check for valid regulators.

2014-04-24 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Whether regulators are available or not is checked at driver probe. If they are not available driver will refuse to load, so no need to check them again. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 10 -- 1 file changed, 10

[PATCH v7 10/20] usb: phy: msm: Remove HSUSB prefix from regulator names

2014-04-24 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Prefix did not bring any useful information. Currently none of the MSM platforms define these regulators, so it is safe to rename them. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletion

[PATCH v7 07/20] usb: phy: msm: Fix checkpatch.pl warnings

2014-04-24 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This fixes following: WARNING: quoted string split across lines WARNING: Prefer seq_puts to seq_printf Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 39 ++- 1 file changed, 14 insertions(+), 25 deletion

[PATCH v7 00/20] usb: phy: msm: Fixes, cleanups and DT support

2014-04-24 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Hi, This is a next version of patches posted earlier[1]. Hopefully comments from Felipe, Srinivas and Sergei have been addressed. Changes since v6 - New patch "Enable deferred driver probing" - Add log to patches wich did not have long descriptio

[PATCH v7 05/20] usb: phy: msm: Migrate to Managed Device Resource allocation

2014-04-24 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Move memory, regulators, clocks and irq allocation to devm_* variants. Properly check for valid clk handles. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 192 -- 1 file changed, 73 insertions(+), 119

[PATCH v7 12/20] usb: phy: msm: Add device tree support and binding information

2014-04-24 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Allows controller to be specified via device tree. Signed-off-by: Ivan T. Ivanov --- .../devicetree/bindings/usb/msm-hsusb.txt | 67 drivers/usb/phy/phy-msm-usb.c | 113 + include/linux/usb/m

[PATCH v7 08/20] usb: phy: msm: Replace custom enum usb_mode_type with enum usb_dr_mode

2014-04-24 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Use enum usb_dr_mode and drop default usb_dr_mode from platform data. USB DT bindings states: dr_mode: "...In case this attribute isn't passed via DT, USB DRD controllers should default to OTG...", so remove redundand field. Signed-off-by: Ivan T

[PATCH v7 09/20] usb: phy: msm: Remove unused pclk_src_name

2014-04-24 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" There are no references to 'pclk_src_name' in plaform code, so it is unused. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 26 +- include/linux/usb/msm_hsusb.h | 5 - 2 files changed, 1 insertion(+), 3

[PATCH v7 11/20] usb: phy: msm: Properly check result from platform_get_irq()

2014-04-24 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Function return negative code on error. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index 5d64038..8a7a324 10

[PATCH v7 14/20] usb: phy: msm: Add support for secondary PHY control

2014-04-24 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Allow support to use 2nd HSPHY with USB2 Core. Some platforms may have configuration to allow USB controller work with any of the two HSPHYs present. By default driver configures USB core to use primary HSPHY. Add support to allow user select 2nd HSPHY using DT

[PATCH v7 16/20] usb: phy: msm: Fix PTS definitions for MSM USB controller

2014-04-24 Thread Ivan T. Ivanov
From: Tim Bird Fix the value used for Parallel Transceiver Select (PTS) for the MSM USB controller. This is a standard chipidea PORTSC definition, where a PHY_TYPE of 10b (<<30) is ULPI and 11b (<<30) is SERIAL. Fix the definitions and use them correctly in the driver code. Signed-off-by: Tim B

[PATCH v7 17/20] usb: phy: msm: Select secondary PHY via TCSR

2014-04-24 Thread Ivan T. Ivanov
From: Tim Bird Select the secondary PHY using the TCSR register, if phy-num=1 in the DTS (or phy_number is set in the platform data). The SOC has 2 PHYs which can be used with the OTG port, and this code allows configuring the correct one. Note: This resolves the problem I was seeing where I co

[PATCH v7 02/20] usb: phy: msm: Remove __init macro from driver probe method

2014-04-24 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This fixes following: WARNING: drivers/usb/phy/built-in.o(.data+0x68): Section mismatch in reference from the variable msm_otg_driver to the function .init.text:msm_otg_probe() The variable msm_otg_driver references the function __init msm_otg_probe() Sig

[PATCH v7 15/20] usb: phy: msm: Correct USB PHY Reset sequence for newer platform

2014-04-24 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" On few legacy platforms, USB PHY is having dedicated reset clk. It is used to reset USB PHY after putting USB PHY into low power mode and for calibration of USB PHY. Putting USB PHY into low power mode is causing ulpi read/write timeout as expected. USB PHY re

[PATCH v7 13/20] usb: phy: msm: Use reset framework for LINK and PHY resets

2014-04-24 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Using reset framework eliminate need of platform specific callbacks and enable reset lines to be specified in DT files. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 29 + include/linux/usb/msm_hsusb.h | 3 ++

[PATCH v7 18/20] usb: phy: msm: Handle disconnect events

2014-04-24 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Put the transceiver in non-driving mode. Otherwise host may not detect soft-disconnection. Signed-off-by: Ivan T. Ivanov Cc: Pavankumar Kondeti --- drivers/usb/phy/phy-msm-usb.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/u

  1   2   3   4   >