Re: [PATCH 1/3] treewide: Lift switch variables out of switches

2019-01-23 Thread Jann Horn
On Wed, Jan 23, 2019 at 1:04 PM Greg KH wrote: > On Wed, Jan 23, 2019 at 03:03:47AM -0800, Kees Cook wrote: > > Variables declared in a switch statement before any case statements > > cannot be initialized, so move all instances out of the switches. > > After this, future always-initialized stack

Re: [PATCH 1/2] USB: yurex: Fix buffer over-read in yurex_write()

2018-08-15 Thread Jann Horn
On Wed, Aug 15, 2018 at 10:44 PM Ben Hutchings wrote: > > If the written data starts with a digit, yurex_write() tries to parse > it as an integer using simple_strtoull(). This requires a null- > terminator, and currently there's no guarantee that there is one. Oh, good catch. > (The sample pro