his makes it easer for subsystem maintainers to introduce and maintain
> symbol namespaces into their codebase.
>
> Co-developed-by: Martijn Coenen
> Signed-off-by: Martijn Coenen
> Signed-off-by: Matthias Maennich
Acked-by: Julia Lawall
> ---
> MAINTAINERS
Hello,
Should the out: label be moved up one line?
julia
-- Forwarded message --
Date: Tue, 23 Jul 2019 10:54:22 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH v4 4/6] usb: gadget: u_serial: allow more console gadget
ports
CC: kbuild
These patches fix cases where a subsequent statement is aligned
with the right hand side of an assignment rather than the left
hand side. This was done using the following semantic match
(http://coccinelle.lip6.fr/). It has a lot of false positives,
because Coccinelle doesn't record the differenc
Delete tab aligning a statement with the right hand side of a
preceding assignment rather than the left hand side.
Found with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/usb/gadget/udc/snps_udc_core.c | 17 -
1 file changed, 8 insertions(+), 9 deletions
: scripts/coccinelle/misc/boolconv.cocci
Fixes: 0772a5bf580c ("usb: misc: add driver for FT232H based FPGA configuration
devices")
CC: Anatolij Gustschin
Signed-off-by: kbuild test robot
Signd-off-by: Julia Lawall
---
url:
https://github.com/0day-ci/linux/commits/Anatolij-Gus
The usb_gadget_ops structure can be const as it is only stored in
the ops field of a usb_gadget structure and this field is const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/usb/gadget/udc/aspeed-vhub/dev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion
The vb2_ops structure can be const as it is only stored in the ops
field of a vb2_queue structure and this field is const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/usb/gadget/function/uvc_queue.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
The vb2_ops structures can be const as they are only stored in the ops
field of a vb2_queue structure and this field is const.
Done with the help of Coccinelle.
---
drivers/media/i2c/video-i2c.c |2 +-
drivers/usb/gadget/function/uvc_queue.c |2 +-
2 files changed, 2 insertion
From: kbuild test robot
Use kmemdup rather than duplicating its implementation
Generated by: scripts/coccinelle/api/memdup.cocci
Fixes: fe1c559e1567 ("ACS ACR122U not working: pn533_usb 1-1:1.0: NFC: Couldn't
poweron...")
CC: Greg KH
Signed-off-by: kbuild test robot
Signe
It looks like the breaks on lines starting with 2235 are indented too
much. I don't have line 946, but please check whether there is an issue
there.
julia
-- Forwarded message --
Date: Sat, 17 Mar 2018 04:56:27 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia L
800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH v3 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub
CC: kbuild-...@01.org
In-Reply-To: <2018012716.7039-2-b...@kernel.crashing.org>
References: <2018012716.7039-2-b...@kernel.crashing.
On Wed, 20 Dec 2017, Joe Perches wrote:
> On Wed, 2017-12-20 at 10:59 +0100, Greg Kroah-Hartman wrote:
> > > > Why you didn't send that patch to the sysfs maintainer is a bit odd...
> > > > :)
> > >
> > > So here's an opportunity for you:
> > >
> > > The sysfs maintainer hasn't added include/l
On Wed, 6 Dec 2017, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Wed, 6 Dec 2017 13:03:21 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring
> ---
> driver
On Thu, 23 Nov 2017, Greg Kroah-Hartman wrote:
> On Wed, Nov 22, 2017 at 10:20:49PM +0100, Julia Lawall wrote:
> >
> >
> > On Wed, 22 Nov 2017, Joe Perches wrote:
> >
> > > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote:
> > > > There
On Wed, 22 Nov 2017, Joe Perches wrote:
> On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote:
> > There is no need to #define the license of the driver, just put it in
> > the MODULE_LICENSE() line directly as a text string.
> >
> > This allows tools that check that the module license m
On Wed, 22 Nov 2017, Joe Perches wrote:
> On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote:
> > There is no need to #define the license of the driver, just put it in
> > the MODULE_LICENSE() line directly as a text string.
> >
> > This allows tools that check that the module license m
On Thu, 19 Oct 2017, Laurent Pinchart wrote:
> Hi Christoph,
>
> On Thursday, 19 October 2017 17:06:57 EEST Christoph Hellwig wrote:
> > > Now we have 9 const instances of the config_item_type structure that are
> > > identical, with only the .ct_owner field set. Should they be all merged
> > >
On Tue, 17 Oct 2017, Greg KH wrote:
> On Mon, Oct 16, 2017 at 05:18:39PM +0200, Bhumika Goyal wrote:
> > Make the ci_type field and some function arguments as const. After this
> > change, make config_item_type structures as const.
> >
> > * Changes in v2- Combine all the followup patches and th
It looks like an unlock is needed before line 1707.
julia
-- Forwarded message --
Date: Thu, 5 Oct 2017 19:35:31 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [usb:usb-testing 9/39] drivers/usb/host/max3421-hcd.c:1707:2-8:
preceding lock on line
These snd_rawmidi_ops structures are only passed as the third
argument of snd_rawmidi_set_ops. This argument is const, so the
snd_rawmidi_ops structures can be const too.
Done with the help of Coccinelle.
---
drivers/hid/hid-prodikeys.c |2 +-
drivers/usb/gadget/function/f_midi.c
These snd_rawmidi_ops structures are only passed as the third
argument of snd_rawmidi_set_ops. This argument is const, so the
snd_rawmidi_ops structures can be const too.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/usb/gadget/function/f_midi.c |4 ++--
1
These videobuf_queue_ops structures are only passed as the second
argument to videobuf_queue_vmalloc_init, which is declared as const.
Thus the videobuf_queue_ops structures themselves can be const.
Done with the help of Coccinelle.
---
drivers/media/pci/cx18/cx18-streams.c
r.i;
@@
static
+const
struct videobuf_queue_ops i = { ... };
//
Signed-off-by: Julia Lawall
---
drivers/media/usb/zr364xx/zr364xx.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/zr364xx/zr364xx.c
b/drivers/media/usb/zr364xx/zr364xx.c
index efdcd5b..24d
qe_ep0_desc is only passed as the second argument to qe_ep_init, which is
const, so qe_ep0_desc can be const too.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
I got a lot of warnings when compiling this file, but none seemed to be
related to the change.
drivers/usb
GFP_KERNEL used when a lock is held. Convert to GFP_ATOMIC to avoid
the possibility of deadlock.
Fixes: 725d53536473 ("usb: xhci: Add DbC support in xHCI driver")
Signed-off-by: Julia Lawall
Signed-off-by: Fengguang Wu
---
I don't have access to any more of the context than wha
The mmc_host_ops structure is only stored in the ops field of an
mmc_host structure, which is declared as const. Thus the mmc_host_ops
structure itself can be const.
Done with the help of Coccinelle.
---
drivers/mmc/host/bcm2835.c |2 +-
drivers/mmc/host/davinci_mmc.c |2 +-
drive
-off-by: Julia Lawall
---
drivers/mmc/host/vub300.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
index fbeea1a..6e08597 100644
--- a/drivers/mmc/host/vub300.c
+++ b/drivers/mmc/host/vub300.c
@@ -2079,7 +2079,7 @@ stat
The hc_driver structure is only passed as the first argument to
usb_create_hcd, which is declared as const. Thus the hc_driver structure
itself can be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/usb/host/isp1362-hcd.c |2 +-
1 file changed, 1
The hc_driver structure is only passed as the first argument to
usb_create_hcd, which is declared as const. Thus the hc_driver structure
itself can be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/usb/host/max3421-hcd.c |2 +-
1 file changed, 1
The hc_driver structure is only passed as the first argument to
usb_create_hcd, which is declared as const. Thus the hc_driver structure
itself can be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/usb/host/sl811-hcd.c |2 +-
1 file changed, 1 insertion
The hc_driver structure is only passed as the first argument to
usb_create_hcd, which is declared as const. Thus the hc_driver structure
itself can be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/usb/host/r8a66597-hcd.c |2 +-
1 file changed, 1
The hc_driver structure is only passed as the first argument to
usb_create_hcd, which is declared as const. Thus the hc_driver structure
itself can be const.
Done with the help of Coccinelle.
//
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct hc_driver i@p = { ... };
The hc_driver structure is only passed as the first argument to
usb_create_hcd, which is declared as const. Thus the hc_driver structure
itself can be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/usb/host/u132-hcd.c |2 +-
1 file changed, 1 insertion
The hc_driver structure is only passed as the first argument to
usb_create_hcd, which is declared as const. Thus the hc_driver structure
itself can be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/usb/renesas_usbhs/mod_host.c |2 +-
1 file changed, 1
The hc_driver structure is only passed as the first argument to
usb_create_hcd, which is declared as const. Thus the hc_driver structure
itself can be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/usb/host/isp116x-hcd.c |2 +-
1 file changed, 1
The hc_driver structure is only passed as the first argument to
usb_create_hcd, which is declared as const. Thus the hc_driver structure
itself can be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/usb/host/hwa-hc.c |2 +-
1 file changed, 1 insertion
The hc_driver structure is only passed as the first argument to
usb_create_hcd, which is declared as const. Thus the hc_driver structure
itself can be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/usb/c67x00/c67x00-hcd.c |2 +-
1 file changed, 1
The hc_driver structure is only passed as the first argument to
usb_create_hcd, which is declared as const. Thus the hc_driver structure
itself can be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/usb/host/whci/hcd.c |2 +-
1 file changed, 1 insertion
On Fri, 14 Jul 2017, Gargi Sharma wrote:
> Earlier bitmap was traversed to find the pid greater or equal to nr
> (passed as a parameter). Now a call to idr_get_next fetches the id
> greater than or equal to nr.
>
> Signed-off-by: Gargi Sharma
> ---
> kernel/pid.c | 8 +---
> 1 file changed
On Fri, 14 Jul 2017, Gargi Sharma wrote:
> In pid_alloc function, idr_preload function is used along with
> idr_alloc_cyclic.
> idr_alloc_cyclic is used instead of idr_alloc because we might want to
> reuse the unassigned integers. The rest of the code is same as the previous
> alloc_pid, which
TTR(x, \(0444\|S_IRUGO\), x_show, NULL);
+ DEVICE_ATTR_RO(x);
//
Signed-off-by: Julia Lawall
---
drivers/usb/wusbcore/dev-sysfs.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/wusbcore/dev-sysfs.c b/drivers/usb/wusbcore/dev-sysfs.c
index 415b140..d4de56b 10
_ATTR_RW;
identifier rw.x,rw.x_show,rw.x_store;
@@
- DEVICE_ATTR(x, \(0644\|S_IRUGO|S_IWUSR\), x_show, x_store);
+ DEVICE_ATTR_RW(x);
//
Signed-off-by: Julia Lawall
---
drivers/usb/wusbcore/wusbhc.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/wus
Use DEVICE_ATTR_RO etc. for read only attributes etc. This simplifies the
source code, improves readbility, and reduces the chance of
inconsistencies.
The complete semantic patch is as follows:
(http://coccinelle.lip6.fr/)
//
@ro@
declarer name DEVICE_ATTR;
identifier x,x_show;
@@
DEVICE_ATTR
On Fri, 28 Oct 2016, Bin Liu wrote:
> On Fri, Oct 28, 2016 at 04:53:03PM -0400, Greg Kroah-Hartman wrote:
> > On Fri, Oct 28, 2016 at 10:33:19PM +0200, Julia Lawall wrote:
> > >
> > >
> > > On Fri, 28 Oct 2016, Julia Lawall wrote:
> > >
> > >
On Fri, 28 Oct 2016, Greg Kroah-Hartman wrote:
> On Fri, Oct 28, 2016 at 10:33:19PM +0200, Julia Lawall wrote:
> >
> >
> > On Fri, 28 Oct 2016, Julia Lawall wrote:
> >
> > > The file drivers/usb/musb/musb_core.c contains the code:
> > >
> > &
[Corrected email for Felipe]
On Fri, 28 Oct 2016, Greg Kroah-Hartman wrote:
> On Fri, Oct 28, 2016 at 10:33:19PM +0200, Julia Lawall wrote:
> >
> >
> > On Fri, 28 Oct 2016, Julia Lawall wrote:
> >
> > > The file drivers/usb/musb/musb_core.c contains the code
On Fri, 28 Oct 2016, Julia Lawall wrote:
> The file drivers/usb/musb/musb_core.c contains the code:
>
> static DEVICE_ATTR(srp, 0644, NULL, musb_srp_store);
>
> Is it correct to have NULL in the third argument for an attribute that can
> be read? Should the permission be 04
The file drivers/usb/musb/musb_core.c contains the code:
static DEVICE_ATTR(srp, 0644, NULL, musb_srp_store);
Is it correct to have NULL in the third argument for an attribute that can
be read? Should the permission be 0444 instead?
thanks,
julia
--
To unsubscribe from this list: send the line
On Thu, 15 Sep 2016, Rehas Sachdeva wrote:
> Fixes checkpatch.pl warning:
> WARNING: void function return statements are not generally useful.
It would be better to say what you did, rather than saying fix. Here you
could say:
Remove unnecessary void return at the end of a function. Issue dete
On Mon, 12 Sep 2016, Jarkko Sakkinen wrote:
> On Mon, Sep 12, 2016 at 04:43:58PM +0300, Felipe Balbi wrote:
> >
> > Hi,
> >
> > Jarkko Sakkinen writes:
> > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote:
> > >>
> >
On Mon, 12 Sep 2016, Felipe Balbi wrote:
>
> Hi,
>
> Jarkko Sakkinen writes:
> > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote:
> >>
> >>
> >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote:
> >>
> >> > On Sun, Sep 1
On Mon, 12 Sep 2016, Jarkko Sakkinen wrote:
> On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote:
> >
> >
> > On Sun, 11 Sep 2016, Jarkko Sakkinen wrote:
> >
> > > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote:
> > > >
On Sun, 11 Sep 2016, Jarkko Sakkinen wrote:
> On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote:
> > Constify local structures.
> >
> > The semantic patch that makes this change is as follows:
> > (http://coccinelle.lip6.fr/)
>
> Just my two cents b
On Sun, 11 Sep 2016, Joe Perches wrote:
> On Sun, 2016-09-11 at 15:05 +0200, Julia Lawall wrote:
> > Constify local structures.
>
> Thanks Julia.
>
> A few suggestions & questions:
>
> Perhaps the script should go into scripts/coccinelle/
> so that future cases
in a
variable.
Declare structures having all of these properties as const.
Done using Coccinelle.
Based on a suggestion by Joe Perches .
Signed-off-by: Julia Lawall
---
The semantic patch seems too long for a commit log, but is in the cover
letter.
drivers/usb/misc/ezusb.c |2 +-
1 file
Constify local structures.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
// The first rule ignores some cases that posed problems
@r disable optional_qualifier@
identifier s != {peri_clk_data,threshold_attr,tracer_flags,tracer};
identifier i != {s5k5baf
Constify ethtool_ops structures.
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c |2 +-
drivers/net/ethernet/synopsys/dwc_eth_qos.c |2 +-
drivers/net/ethernet/xilinx/xilinx_axienet_main.c |2 +-
drivers/net/usb/r8152.c |2 +-
drivers/staging
r.i;
expression e;
position p;
@@
netdev_set_default_ethtool_ops(e, &i@p)
@bad@
position p != {r.p,ok1.p,ok2.p};
identifier r.i;
@@
i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct ethtool_ops i = { ... };
//
Suggested-by: Stephen Hemminger
Signed-off-b
On Fri, 5 Aug 2016, Robin Murphy wrote:
> Hi Julia,
>
> On 05/08/16 09:56, Julia Lawall wrote:
> > Use of_property_read_bool to check for the existence of a property.
>
> This caught my eye since Rob told me off for doing the same recently[1].
>
> > The semantic p
;
+ x = of_property_read_bool(e1,e2);
//
Signed-off-by: Julia Lawall
---
v2: special case for propagating true and false
drivers/usb/host/fsl-mph-dr-of.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host
else S2
//
Signed-off-by: Julia Lawall
---
drivers/usb/host/fsl-mph-dr-of.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
index 1044b0f..8bbca74 100644
--- a/drivers/usb/host/fsl-mph-dr-of.c
+++ b
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
@@
expression e1,e2;
statement S2,S1;
@@
- if (of_get_property(e1,e2,NULL))
+ if (of_property_read_bool(e1,e2))
S1 else
On Tue, 2 Aug 2016, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the
> corresponding macro,
> and that using ma
The ftdi_sio_quirk structures are never modified, so declare them as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/usb/serial/ftdi_sio.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/serial/ftdi_sio.c b
Please check. As far as I can see, the call to early_xdbc_read ends up at
xdbc_bulk_transfer, which return negative error codes on failure.
julia
On Tue, 26 Jan 2016, kbuild test robot wrote:
> CC: kbuild-...@01.org
> In-Reply-To: <1453781665-4714-11-git-send-email-baolu...@linux.intel.com>
> T
The index variable of list_for_each_entry_safe is an offset from a list
pointer, and thus should not be NULL.
Generated by: scripts/coccinelle/iterators/itnull.cocci
CC: Geliang Tang
Signed-off-by: Fengguang Wu
Signed-off-by: Julia Lawall
---
tree: https://git.kernel.org/pub/scm/linux
On Tue, 5 Jan 2016, Felipe Ferreri Tonello wrote:
> Hi Dan,
>
> On 05/01/16 12:44, Dan Carpenter wrote:
> > On Tue, Jan 05, 2016 at 01:28:11PM +0100, Julia Lawall wrote:
> >>
> >>
> >> On Tue, 5 Jan 2016, kbuild test robot wrote:
> >>
> >
On Tue, 5 Jan 2016, kbuild test robot wrote:
> Hi Dan,
>
> [auto build test WARNING on balbi-usb/next]
> [also build test WARNING on v4.4-rc8 next-20160105]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improving the system]
>
> url:
> https://github.com
PTR_ERR should access the value just tested by IS_ERR
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
CC: Nobuo Iwata
Signed-off-by: Fengguang Wu
Signed-off-by: Julia Lawall
---
I haven't checked the complete context, but the code looks suspicious.
usbip_ux.c |2 +-
1
The usbhs_pkt_handle structures are never modified, so declare them as
const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/usb/renesas_usbhs/fifo.c | 20 ++--
drivers/usb/renesas_usbhs/fifo.h | 20 ++--
drivers/usb/renesas_usbhs
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
@@
expression e1,e2;
statement S1,S2;
@@
+e1 = e2;
if (IS_ERR(
e1
- = e2
)) S1 else S2
//
Signed-off-by: Julia Lawall
---
drivers/usb/mon/mon_text.c |6 --
1 file changed, 4 insertions
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
@@
expression e1,e2;
statement S1,S2;
@@
+e1 = e2;
if (IS_ERR(
e1
- = e2
)) S1 else S2
//
---
drivers/usb/mon/mon_text.c |6 --
ipc/mqueue.c |3 ++-
2 files changed, 6
The complate semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@ok exists@
identifier f,ret,i;
expression e;
constant c;
@@
// identify a function that returns a negative return value at least once.
f(...) {
... when any
(
return -c@i;
|
ret = -c@i;
... when !
amp;ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
//
Signed-off-by: Julia Lawall
---
drivers/usb/gadget/legacy/acm_ms.c |4 +++-
drivers/usb/gadget/legacy/audio.c|4 +++-
drivers/usb/gadget/legacy/cdc2.c |4 +++-
drivers/usb/gadget
On Tue, 22 Dec 2015, Felipe Balbi wrote:
> Julia Lawall writes:
>
> > The index variable of list_for_each_entry_safe is never NULL.
> >
> > Generated by: scripts/coccinelle/iterators/itnull.cocci
> >
> > CC: Geliang Tang
> > Signed-off-by: Fen
The call on line 1120 looks suspicious, because qtd could be non-null but
also not a valid element, if the loop has exited normally.
julia
On Sat, 19 Dec 2015, kbuild test robot wrote:
> CC: kbuild-...@01.org
> In-Reply-To:
>
> TO: Geliang Tang
> CC: John Youn , Greg Kroah-Hartman
>
> CC:
The index variable of list_for_each_entry_safe is never NULL.
Generated by: scripts/coccinelle/iterators/itnull.cocci
CC: Geliang Tang
Signed-off-by: Fengguang Wu
Signed-off-by: Julia Lawall
---
rndis.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/usb/gadget
Geliang,
Please check whether it is acceptable that last_unlinked_td point to the
dummy entry at th beginning of the list, in the case where the
list_for_each_entry loop runs out normally.
It seems that you have sent a bunch of these patches. Please recheck them
all to see if they really follow
Geliang,
Please check whether line 762 can be reached in the case where the
list_for_each_entry reaches the end of the list. If that can happen,
max3421_ep should not be dereferenced.
julia
On Sat, 19 Dec 2015, kbuild test robot wrote:
> CC: kbuild-...@01.org
> In-Reply-To:
> <45e8397e370ed99
The usb_mon_operations structure is never modified, so declare it as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
v2: Merge the previous 1/2 and 2/2 patches.
drivers/usb/core/hcd.c |4 ++--
drivers/usb/mon/mon_main.c |2 +-
include/linux/usb/hcd.h
The usb_mon_operations structure is never modified, so declare it as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/usb/core/hcd.c |4 ++--
drivers/usb/mon/mon_main.c |2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers
The usb_mon_operations structure is never modified, so declare it as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
include/linux/usb/hcd.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
Please check. The code, with the blank line on line 692, looks strange.
julia
On Tue, 17 Nov 2015, kbuild test robot wrote:
> CC: kbuild-...@01.org
> In-Reply-To: <1447760410-3426-1-git-send-email-saurabh.tr...@gmail.com>
> TO: Saurabh Sengar
> CC: m...@mansr.com, peter.c...@freescale.com, gre
Move constants to the right of binary operators.
Semantic patch information:
Depends on personal taste in some cases.
Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
CC: Dave Penkler
Signed-off-by: Fengguang Wu
Signed-off-by: Julia Lawall
---
This is what Coccinelle generates
Coccinelle suggests the following patch. But the code is curious. Is the
function expected to always return a failure value?
thanks,
julia
On Thu, 17 Sep 2015, kbuild test robot wrote:
> TO: Andrzej Pietrasiewicz
> CC: kbuild-...@01.org
> CC: Felipe Balbi
> CC: Laurent Pinchart
> CC: "Greg
Remove unneeded NULL test.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
@@ expression x; @@
-if (x != NULL)
\(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
//
Signed-off-by: Julia Lawall
---
drivers/usb/host/xhci-mem.c | 12
Recent commits to kernel/git/torvalds/linux.git have made the following
functions able to tolerate NULL arguments:
kmem_cache_destroy (commit 3942d29918522)
mempool_destroy (commit 4e3ca3e033d1)
dma_pool_destroy (commit 44d7175da6ea)
These patches remove the associated NULL tests for the files th
Remove unneeded NULL test.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
@@ expression x; @@
-if (x != NULL)
\(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
//
Signed-off-by: Julia Lawall
---
drivers/usb/gadget/udc/bdc/bdc_core.c
Remove unneeded NULL test.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
@@ expression x; @@
-if (x != NULL)
\(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
//
Signed-off-by: Julia Lawall
---
drivers/usb/host/whci/init.c |3
\|mempool_destroy\|dma_pool_destroy\)(x);
x = NULL;
-}
//
Signed-off-by: Julia Lawall
---
drivers/usb/host/fotg210-hcd.c | 12
drivers/usb/host/fusbh200-hcd.c | 12
2 files changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host
Please take a look.
thanks,
julia
On Wed, 25 Mar 2015, kbuild test robot wrote:
> TO: Peter Chen
> CC: "Greg Kroah-Hartman"
> CC: linux-usb@vger.kernel.org
> CC: linux-ker...@vger.kernel.org
>
> drivers/usb/chipidea/usbmisc_imx.c:277:5-8: Unneeded variable: "ret". Return
> "0" on line 297
>
These patches group a call to init_timer and initialization of the function
and data fields into a call to setup_timer. Is there is no initialization
of the data field before add_timer is called, the the data value is set to
0UL. If the data value has a cast to something other than unsigned long,
tup_timer(&t,f,d);
-t.function = f;
-t.data = d;
//
Signed-off-by: Julia Lawall
---
drivers/usb/host/sl811-hcd.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/host/sl811-hcd.c b/drivers/usb/host/sl811-hcd.c
index 25fb1da..cef3140 100644
--- a/dri
tup_timer(&t,f,d);
-t.data = d;
-t.function = f;
//
Signed-off-by: Julia Lawall
---
drivers/usb/host/xhci.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 01fcbb5..ae6d650 100644
--- a/drivers/usb/host
tup_timer(&t,f,d);
-t.data = d;
-t.function = f;
//
Signed-off-by: Julia Lawall
---
drivers/usb/host/xhci-mem.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
index 5cb3d7a..e72265c 100644
--- a/dri
tup_timer(&t,f,d);
-t.function = f;
-t.data = d;
//
Signed-off-by: Julia Lawall
---
drivers/usb/host/oxu210hp-hcd.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/host/oxu210hp-hcd.c b/drivers/usb/host/oxu210hp-hcd.c
index 036924e..ea0ecbc 100644
---
tup_timer(&t,f,d);
-t.function = f;
-t.data = d;
//
Signed-off-by: Julia Lawall
---
drivers/usb/host/isp1760-hcd.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/host/isp1760-hcd.c b/drivers/usb/host/isp1760-hcd.c
index 395649f..79261d5 100644
---
tup_timer(&t,f,d);
-t.function = f;
-t.data = d;
//
Signed-off-by: Julia Lawall
---
drivers/usb/host/r8a66597-hcd.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/host/r8a66597-hcd.c b/drivers/usb/host/r8a66597-hcd.c
index c4bcfae..a048b8e
On Mon, 8 Dec 2014, Julian Calaby wrote:
> Hi Julia,
>
> On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall wrote:
> > These patches replace what appears to be a reference to the name of the
> > current function but is misspelled in some way by either the name of the
> > fu
On Sun, 7 Dec 2014, Jeremiah Mahler wrote:
> Julia,
>
> On Sun, Dec 07, 2014 at 08:20:50PM +0100, Julia Lawall wrote:
> > Replace a misspelled function name by %s and then __func__.
> >
> > The function name starts with isp, not ips.
> >
> > This was d
1 - 100 of 173 matches
Mail list logo