[PATCH] usb: chipidea: imx: check data->usbmisc_data against NULL before access

2019-10-08 Thread jun . li
From: Li Jun As usbmisc_data is optional, so add the check before access its member, this fix below static checker warning: drivers/usb/chipidea/ci_hdrc_imx.c:438 ci_hdrc_imx_probe() warn: 'data->usbmisc_data' can also be NULL which is introduced by Patch 15b80f7c3a7f: "usb: chipidea: imx: enable

RE: [bug report] usb: chipidea: imx: enable vbus and id wakeup only for OTG events

2019-10-07 Thread Jun Li
Hi Dan, > -Original Message- > From: Dan Carpenter > Sent: 2019年10月2日 19:30 > To: Jun Li > Cc: Pengutronix Kernel Team ; dl-linux-imx > ; linux-usb@vger.kernel.org > Subject: [bug report] usb: chipidea: imx: enable vbus and id wakeup only for > OTG events >

[PATCH v2] usb: chipidea: imx: enable vbus and id wakeup only for OTG events

2019-09-08 Thread jun . li
From: Li Jun If ID or VBUS is from external block, don't enable its wakeup because it isn't used at all. Signed-off-by: Li Jun --- drivers/usb/chipidea/ci_hdrc_imx.c | 8 drivers/usb/chipidea/ci_hdrc_imx.h | 2 ++ drivers/usb/chipidea/usbmisc_imx.c | 31 +++--

[PATCH v4] usb: chipidea: add role switch class support

2019-08-26 Thread jun . li
From: Li Jun USB role is fully controlled by usb role switch consumer(e.g. typec), usb port can be at host mode(USB_ROLE_HOST), device mode connected to host(USB_ROLE_DEVICE), or not connecting any partner(USB_ROLE_NONE). Signed-off-by: Li Jun --- changes for v4: - Add spinlock for role set().

[PATCH v3] usb: chipidea: add role switch class support

2019-08-14 Thread jun . li
From: Li Jun USB role is fully controlled by usb role switch consumer(e.g. typec), usb port can be at host mode(USB_ROLE_HOST), device mode connected to host(USB_ROLE_DEVICE), or not connecting any partner(USB_ROLE_NONE). Signed-off-by: Li Jun --- Changes for v3: - Remove the patch usb: chipid

RE: [PATCH v2 2/2] usb: chipidea: add role switch class support

2019-08-09 Thread Jun Li
> -Original Message- > From: Peter Chen > Sent: 2019年8月8日 17:31 > To: Jun Li > Cc: gre...@linuxfoundation.org; Jun Li ; dl-linux-imx > ; linux-usb@vger.kernel.org > Subject: RE: [PATCH v2 2/2] usb: chipidea: add role switch class support > > > > USB rol

[PATCH v2 2/2] usb: chipidea: add role switch class support

2019-08-07 Thread jun . li
From: Li Jun USB role is fully controlled by usb role switch consumer(e.g. typec), usb port can be at host mode(USB_ROLE_HOST), device mode connected to host(USB_ROLE_DEVICE), or not connecting any parter(USB_ROLE_NONE). Signed-off-by: Li Jun --- Change for v2: - Support USB_ROLE_NONE, which f

[PATCH v2 1/2] usb: chipidea: replace ci_role with usb_role

2019-08-07 Thread jun . li
From: Li Jun Since there is usb_role which has similar definition like ci_role, switch to use usb_role, then we can directly compare usb role with a common definition, this can benifit on usb role switch class support. Signed-off-by: Li Jun --- v1 -> v2 No change for this patch. drivers/usb/c

RE: [PATCH 2/5] usb: chipidea: add role switch class support

2019-08-07 Thread Jun Li
> -Original Message- > From: Peter Chen > Sent: 2019年8月7日 10:41 > To: Jun Li ; Peter Chen > Cc: Greg Kroah-Hartman ; dl-linux-imx > ; USB list > Subject: RE: [PATCH 2/5] usb: chipidea: add role switch class support > > > > > > > > >

RE: [PATCH 2/5] usb: chipidea: add role switch class support

2019-08-06 Thread Jun Li
> -Original Message- > From: Peter Chen > Sent: 2019年8月6日 15:52 > To: Jun Li ; Peter Chen > Cc: Greg Kroah-Hartman ; dl-linux-imx > ; USB list > Subject: RE: [PATCH 2/5] usb: chipidea: add role switch class support > > > > > > > > You may

RE: [PATCH 2/5] usb: chipidea: add role switch class support

2019-08-05 Thread Jun Li
Hi > -Original Message- > From: Peter Chen > Sent: 2019年8月5日 12:57 > To: Jun Li ; Peter Chen > Cc: Greg Kroah-Hartman ; dl-linux-imx > ; USB list > Subject: RE: [PATCH 2/5] usb: chipidea: add role switch class support > > > > > > > > US

RE: [PATCH 2/5] usb: chipidea: add role switch class support

2019-08-04 Thread Jun Li
> -Original Message- > From: Peter Chen > Sent: 2019年8月5日 11:15 > To: Jun Li > Cc: Peter Chen ; Greg Kroah-Hartman > ; dl-linux-imx ; USB list > > Subject: Re: [PATCH 2/5] usb: chipidea: add role switch class support > > > > > > > >

RE: [PATCH 2/5] usb: chipidea: add role switch class support

2019-08-04 Thread Jun Li
> -Original Message- > From: Peter Chen > Sent: 2019年8月2日 17:41 > To: Jun Li > Cc: Peter Chen ; Greg Kroah-Hartman > ; dl-linux-imx ; USB list > > Subject: Re: [PATCH 2/5] usb: chipidea: add role switch class support > > > USB role is fully controlle

Re: [PATCH v2] usb: typec: tcpm: Add NULL check before dereferencing config

2019-07-24 Thread Jun Li
registering a Type-C port. Since it is optional, we have > to check if it is NULL before dereferencing it. > > Reported-by: Douglas Gilbert > Cc: Douglas Gilbert > Fixes: 96232cbc6c994 ("usb: typec: tcpm: support get typec and pd config from > device properties") > Signed-off

[PATCH 2/2] usb: typec: tcpm: remove tcpm dir if no children

2019-07-17 Thread jun . li
From: Li Jun If config tcpm as module, module unload will not remove tcpm dir, then the next module load will have problem: the rootdir is NULL but tcpm dir is still there, so tcpm_debugfs_init() will create tcpm dir again with failure, fix it by remove the tcpm dir if no children. Cc: sta...@vg

[PATCH 1/2] usb: typec: tcpm: free log buf memory when remove debug file

2019-07-17 Thread jun . li
From: Li Jun The logbuffer memory should be freed when remove debug file. Cc: sta...@vger.kernel.org # v4.15+ Fixes: 4b4e02c83167 ("typec: tcpm: Move out of staging") Signed-off-by: Li Jun --- drivers/usb/typec/tcpm/tcpm.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/us

Re: [PATCH 3/3] usb: typec: mux: Use the "compatible" property instead of a boolean property

2019-07-15 Thread Jun Li
Hi Heikki, Heikki Krogerus 于2019年3月28日周四 上午12:45写道: > > Instead of searching for a boolean property, matching > against the "compatible" property. > > Signed-off-by: Heikki Krogerus > --- > drivers/usb/typec/mux.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/

[PATCH 1/5] usb: chipidea: replace ci_role with usb_role

2019-07-03 Thread jun . li
From: Li Jun Since there is usb_role which has similar definition like ci_role, switch to use usb_role, then we can directly compare usb role with a common definition, this can benifit on usb role switch class support. Signed-off-by: Li Jun --- drivers/usb/chipidea/ci.h | 28 -

[PATCH 2/5] usb: chipidea: add role switch class support

2019-07-03 Thread jun . li
From: Li Jun USB role is fully controlled by usb role switch consumer(e.g. typec), usb port either at host mode, or at device connected mode, will not stay at USB_ROLE_NONE mode. Signed-off-by: Li Jun --- drivers/usb/chipidea/ci.h | 2 + drivers/usb/chipidea/core.c | 125 ++

[PATCH v2] usb: dwc3: move core validation to be after clks enable

2019-05-08 Thread Jun Li
From: Jun Li Register access in core validation may hang before the bulk clks are enabled. Fixes: b873e2d0ea1e ("usb: dwc3: Do core validation early on probe") Signed-off-by: Jun Li --- Change for v2: - Update ret to be -ENODEV in case dwc3_core_is_valid() fail. drivers/usb/dwc3/c

RE: [PATCH] usb: dwc3: move core validation to be after clks enable

2019-05-08 Thread Jun Li
Hi Sriharsha, > -Original Message- > From: Sriharsha Allenki > Sent: 2019年5月8日 18:26 > To: Jun Li ; ba...@kernel.org; gre...@linuxfoundation.org > Cc: thi...@synopsys.com; linux-usb@vger.kernel.org; dl-linux-imx > > Subject: Re: [PATCH] usb: dwc3: move core valida

[PATCH] usb: dwc3: move core validation to be after clks enable

2019-05-07 Thread Jun Li
From: Jun Li Register access in core validation may hang before the bulk clks are enabled. Fixes: b873e2d0ea1e ("usb: dwc3: Do core validation early on probe") Signed-off-by: Jun Li --- drivers/usb/dwc3/core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) di

RE: [PATCH v3 1/2] dt-bindings: usb: add documentation for typec switch via GPIO

2019-03-18 Thread Jun Li
> -Original Message- > From: Heikki Krogerus > Sent: 2019年3月13日 17:36 > To: Rob Herring > Cc: Jun Li ; gre...@linuxfoundation.org; hdego...@redhat.com; > andy.shevche...@gmail.com; linux-usb@vger.kernel.org; > devicet...@vger.kernel.org; dl-linux-imx > Subjec

RE: [PATCH v3 1/2] dt-bindings: usb: add documentation for typec switch via GPIO

2019-03-18 Thread Jun Li
> -Original Message- > From: Rob Herring > Sent: 2019年3月12日 22:45 > To: Jun Li > Cc: heikki.kroge...@linux.intel.com; gre...@linuxfoundation.org; > hdego...@redhat.com; andy.shevche...@gmail.com; linux-usb@vger.kernel.org; > devicet...@vger.kernel.org; dl-lin

RE: [PATCH v3 1/2] dt-bindings: usb: add documentation for typec switch via GPIO

2019-03-18 Thread Jun Li
> -Original Message- > From: Hans de Goede > Sent: 2019年3月11日 19:12 > To: Jun Li ; robh...@kernel.org; > heikki.kroge...@linux.intel.com > Cc: gre...@linuxfoundation.org; andy.shevche...@gmail.com; > linux-usb@vger.kernel.org; devicet...@vger.kernel.org; dl-linux

RE: [PATCH v3 1/2] dt-bindings: usb: add documentation for typec switch via GPIO

2019-03-12 Thread Jun Li
Hi Hans > -Original Message- > From: Hans de Goede > Sent: 2019年3月11日 19:03 > To: Jun Li ; robh...@kernel.org; > heikki.kroge...@linux.intel.com > Cc: gre...@linuxfoundation.org; andy.shevche...@gmail.com; > linux-usb@vger.kernel.org; devicet...@vger.kernel.org; dl-l

[PATCH v3 1/2] dt-bindings: usb: add documentation for typec switch via GPIO

2019-03-11 Thread Jun Li
Some typec super speed active channel switch can be controlled via a GPIO, this binding can be used to specify the switch node by a GPIO and the remote endpoint of its consumer. Signed-off-by: Li Jun --- .../devicetree/bindings/usb/typec-switch-gpio.txt | 30 ++ 1 file chang

[PATCH v3 2/2] usb: typec: add typec switch via GPIO control

2019-03-11 Thread Jun Li
s/usb/typec/mux/gpio-switch.c @@ -0,0 +1,105 @@ +// SPDX-License-Identifier: GPL-2.0 +/** + * Typec switch via a simple GPIO control driver. + * + * Copyright 2019 NXP + * Author: Jun Li + * + */ + +#include +#include +#include +#include +#include +#include +#include + +struct gp

RE: [PATCH 1/2] Documentation: usb: dwc3: add power down clock scale property

2019-03-10 Thread Jun Li
> -Original Message- > From: Rob Herring > Sent: 2019年2月23日 8:33 > To: Jun Li > Cc: mark.rutl...@arm.com; ba...@kernel.org; linux-usb@vger.kernel.org; > devicet...@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH 1/2] Documentation: usb: dwc3: add power down c

RE: [PATCH v2 2/2] usb: typec: add typec switch via GPIO control

2019-03-04 Thread Jun Li
Hi Andy, > -Original Message- > From: Andy Shevchenko > Sent: 2019年3月3日 0:27 > To: Jun Li > Cc: robh...@kernel.org; heikki.kroge...@linux.intel.com; > gre...@linuxfoundation.org; hdego...@redhat.com; linux-usb@vger.kernel.org; > devicet...@vger.kernel.org; dl-lin

RE: [PATCH 1/2] usb: chipiea: add flags for id and vbus from external block

2019-03-04 Thread Jun Li
Hi Peter, > -Original Message- > From: Peter Chen > Sent: 2019年3月1日 11:04 > To: Jun Li > Cc: gre...@linuxfoundation.org; linux-usb@vger.kernel.org; dl-linux-imx > > Subject: RE: [PATCH 1/2] usb: chipiea: add flags for id and vbus from > external block > >

[PATCH v2 1/2] dt-bindings: usb: add documentation for typec switch via GPIO

2019-02-28 Thread Jun Li
Some typec super speed active channel switch can be controlled via a GPIO, this binding can be used to specify the switch node by a GPIO and the remote endpoint of its consumre. Signed-off-by: Li Jun --- No change on v2 for this patch. .../devicetree/bindings/usb/typec-switch-gpio.txt | 30 +++

[PATCH v2 2/2] usb: typec: add typec switch via GPIO control

2019-02-28 Thread Jun Li
imple GPIO control. + * + * Copyright 2019 NXP + * Author: Jun Li + * + */ + +#include +#include +#include +#include +#include +#include +#include + +struct gpio_typec_switch { + struct typec_switch sw; + struct mutex lock; + struct gpio_desc *ss_sel; +}; + +static int switc

RE: [PATCH 2/2] usb: typec: add typec switch via GPIO control

2019-02-28 Thread Jun Li
> -Original Message- > From: Heikki Krogerus > Sent: 2019年2月27日 17:41 > To: Jun Li > Cc: robh...@kernel.org; gre...@linuxfoundation.org; hdego...@redhat.com; > andy.shevche...@gmail.com; linux-usb@vger.kernel.org; > devicet...@vger.kernel.org; dl-linux-imx >

RE: [PATCH 2/2] usb: typec: add typec switch via GPIO control

2019-02-28 Thread Jun Li
Hi > -Original Message- > From: Andy Shevchenko > Sent: 2019年2月26日 15:25 > To: Jun Li > Cc: robh...@kernel.org; heikki.kroge...@linux.intel.com; > gre...@linuxfoundation.org; hdego...@redhat.com; linux-usb@vger.kernel.org; > devicet...@vger.kernel.org; dl-lin

RE: [PATCH 1/2] usb: chipiea: add flags for id and vbus from external block

2019-02-28 Thread Jun Li
> -Original Message- > From: Peter Chen > Sent: 2019年2月26日 14:53 > To: Jun Li > Cc: gre...@linuxfoundation.org; linux-usb@vger.kernel.org; dl-linux-imx > > Subject: RE: [PATCH 1/2] usb: chipiea: add flags for id and vbus from > external block > > &g

[PATCH 2/2] usb: typec: add typec switch via GPIO control

2019-02-24 Thread Jun Li
ode 100644 index 000..a51da68 --- /dev/null +++ b/drivers/usb/typec/mux/gpio-switch.c @@ -0,0 +1,105 @@ +// SPDX-License-Identifier: GPL-2.0 +/** + * gpio-switch.c - typec switch via a simple GPIO control. + * + * Copyright 2019 NXP + * Author: Jun Li + * + */ + +#include +#include +#include

[PATCH 1/2] dt-bindings: usb: add documentation for typec switch via GPIO

2019-02-24 Thread Jun Li
Some typec super speed active channel switch can be controlled via a GPIO, this binding can be used to specify the switch node by a GPIO and the remote endpoint of its consumre. Signed-off-by: Li Jun --- .../devicetree/bindings/usb/typec-switch-gpio.txt | 30 ++ 1 file chang

[PATCH 1/2] usb: chipiea: add flags for id and vbus from external block

2019-02-24 Thread Jun Li
Add 2 flags for id and vbus if the state is from external blocks instead of OTG block inside of USB controller. Signed-off-by: Li Jun --- drivers/usb/chipidea/core.c | 2 ++ include/linux/usb/chipidea.h | 4 2 files changed, 6 insertions(+) diff --git a/drivers/usb/chipidea/core.c b/drive

[PATCH 2/2] usb: chipidea: imx: enable vbus and id wakeup only for OTG events

2019-02-24 Thread Jun Li
If ID or VBUS is from external block, don't enable its wakeup because it isn't used at all. Signed-off-by: Li Jun --- drivers/usb/chipidea/ci_hdrc_imx.c | 6 ++ drivers/usb/chipidea/ci_hdrc_imx.h | 2 ++ drivers/usb/chipidea/usbmisc_imx.c | 17 - 3 files changed, 24 inserti

Re: [PATCH v2 07/10] usb: dwc3: Registering a role switch in the DRD code.

2019-02-18 Thread Jun Li
Hi Yu Chen 于2019年2月18日周一 下午7:34写道: > > The Type-C drivers use USB role switch API to inform the > system about the negotiated data role, so registering a role > switch in the DRD code in order to support platforms with > USB Type-C connectors. > > Cc: John Stultz > Cc: Felipe Balbi > Cc: Greg Kr

RE: [PATCH v2 0/9] device connection: Add support for device graphs

2019-02-12 Thread Jun Li
Hi > -Original Message- > From: Heikki Krogerus > Sent: 2019年1月31日 0:03 > To: Greg Kroah-Hartman > Cc: Andy Shevchenko ; Chen Yu > ; Jun Li ; Hans de Goede > ; linux-usb@vger.kernel.org; > linux-ker...@vger.kernel.org > Subject: [PATCH v2 0/9] device connect

RE: [PATCH v2 6/9] usb: roles: Find the muxes by also matching against the device node

2019-02-12 Thread Jun Li
Hi > -Original Message- > From: Heikki Krogerus > Sent: 2019年2月12日 16:51 > To: Jun Li > Cc: Greg Kroah-Hartman ; Andy Shevchenko > ; Chen Yu ; Hans de > Goede ; linux-usb@vger.kernel.org; > linux-ker...@vger.kernel.org > Subject: Re: [PATCH v2 6/9] usb: ro

RE: [PATCH v2 6/9] usb: roles: Find the muxes by also matching against the device node

2019-02-11 Thread Jun Li
> -Original Message- > From: Heikki Krogerus > Sent: 2019年2月11日 18:46 > To: Jun Li > Cc: Greg Kroah-Hartman ; Andy Shevchenko > ; Chen Yu ; Hans de > Goede ; linux-usb@vger.kernel.org; > linux-ker...@vger.kernel.org > Subject: Re: [PATCH v2 6/9] usb: ro

RE: [PATCH v2 6/9] usb: roles: Find the muxes by also matching against the device node

2019-02-11 Thread Jun Li
Hi Heikki, > @@ -84,7 +85,12 @@ enum usb_role usb_role_switch_get_role(struct > usb_role_switch *sw) } EXPORT_SYMBOL_GPL(usb_role_switch_get_role); > > -static int __switch_match(struct device *dev, const void *name) > +static int switch_fwnode_match(struct device *dev, const void *fwnode) > +{

[PATCH] usb: chipidea: imx: remove unused header files

2019-01-22 Thread Jun Li
Those 2 headers files are not required now. Signed-off-by: Li Jun --- drivers/usb/chipidea/ci_hdrc_imx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c index 9b45aa4..076d8c0 100644 --- a/drivers/usb/chipidea/ci_hdrc_

[PATCH 2/2] dwc3: add power down clock scale setting when init core

2019-01-22 Thread Jun Li
Set the right power down clock scale if the property "snps,power-down-scale" is specified. Signed-off-by: Li Jun --- drivers/usb/dwc3/core.c | 15 +++ drivers/usb/dwc3/core.h | 1 + 2 files changed, 16 insertions(+) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c ind

[PATCH 1/2] Documentation: usb: dwc3: add power down clock scale property

2019-01-22 Thread Jun Li
The USB3 suspend_clk input replaces pipe3_rx_pclk as a clock source to a small part of the USB3 core that operates when the SS PHY is in its lowest power(P3) state, and therefore does not provide a clock. The power down scale specifies how many suspend_clk periods fit into a 16 KHz clock period, de

[PATCH] usb: typec: tpcm: improve error handling of tcpm_register_port

2019-01-22 Thread Jun Li
Remove debugfs if tcpm register port fails. Signed-off-by: Li Jun --- drivers/usb/typec/tcpm/tcpm.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index 4f1f421..4cdc53d 100644 --- a/drivers/usb/typec/tcpm

Re: [RFC PATCH 3/5] usb: roles: Find the muxes by also matching against the device node

2019-01-21 Thread Jun Li
Hi Heikki, Heikki Krogerus 于2018年10月24日周三 下午11:06写道: > > When the connections are defined in firmware, struct > device_connection will have the fwnode member pointing to > the device node (struct fwnode_handle) of the requested > device, and the endpoint will not be used at all in that > case. > >

RE: [PATCH] usb: chipidea: imx: Allow OC polarity active low

2018-12-02 Thread Jun Li
Hi Peter, > -Original Message- > From: Matthew Starr > Sent: 2018年11月30日 23:09 > To: PETER CHEN ; linux-usb@vger.kernel.org; Jun Li > > Subject: RE: [PATCH] usb: chipidea: imx: Allow OC polarity active low > > > -Original Message- > > From: PETE

RE: USB Type C ptn5110

2018-11-04 Thread Jun Li
Hi Angus > -Original Message- > From: Angus Ainslie > Sent: 2018年11月1日 21:53 > To: Jun Li > Subject: USB Type C ptn5110 > > Hi Li, > > We have a custom PCB that has a PTN5110 on it. The board can power from the > USB C no problem but we are starting t

RE: [PATCH v3] usb: typec: get the vbus source and charge values from the devicetree

2018-09-13 Thread Jun Li
Hi > -Original Message- > From: Guenter Roeck On Behalf Of Guenter Roeck > Sent: 2018年9月14日 1:35 > To: Angus Ainslie > Cc: Peter Chen ; Heikki Krogerus > ; Greg Kroah-Hartman > ; linux-usb@vger.kernel.org; lkml > ; Peter Chen ; Jun Li > > Subject: Re: [PATC

RE: [PATCH v3] usb: typec: get the vbus source and charge values from the devicetree

2018-09-13 Thread Jun Li
Hi > -Original Message- > From: Angus Ainslie > Sent: 2018年9月13日 19:10 > To: Peter Chen > Cc: li...@roeck-us.net; Heikki Krogerus ; > Greg > Kroah-Hartman ; linux-usb@vger.kernel.org; lkml > ; Peter Chen ; Jun Li > ; Guenter Roeck > Subject: Re: [PATC

RE: [PATCH v7 06/14] usb: typec: tcpm: support get typec and pd config from device properties

2018-06-26 Thread Jun Li
Hi > -Original Message- > From: Adam Thomson [mailto:adam.thomson.opensou...@diasemi.com] > Sent: 2018年6月25日 18:46 > To: Jun Li ; robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com; li...@roeck-us.net > Cc: a.ha...@samsung.com; cw00.c...@sa

RE: [PATCH v6 12/15] usb: typec: tcpm: set cc for drp toggling attach

2018-06-13 Thread Jun Li
Hi > -Original Message- > From: Jun Li > Sent: 2018年6月13日 19:07 > To: Guenter Roeck ; Heikki Krogerus > ; shufan_...@richtek.com > Cc: robh...@kernel.org; gre...@linuxfoundation.org; cw00.c...@samsung.com; > a.ha...@samsung.com; Peter Chen ; > garsi...@embedded

RE: [PATCH v6 12/15] usb: typec: tcpm: set cc for drp toggling attach

2018-06-13 Thread Jun Li
Hi, > -Original Message- > From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter Roeck > Sent: 2018年6月11日 21:35 > To: Heikki Krogerus ; Jun Li > Cc: robh...@kernel.org; gre...@linuxfoundation.org; cw00.c...@samsung.com; > a.ha...@samsung.com; shufan_...@

RE: [PATCH v6 05/15] usb: typec: add API to get typec basic port power and data config

2018-06-13 Thread Jun Li
Hi Heikki, > -Original Message- > From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > Sent: 2018年6月11日 19:09 > To: Jun Li > Cc: robh...@kernel.org; gre...@linuxfoundation.org; li...@roeck-us.net; > cw00.c...@samsung.com; a.ha...@samsung.com; shufan_...@ri

RE: [PATCH v6 00/15] staging: typec: tcpci: move out of staging

2018-06-06 Thread Jun Li
Hi Mats, > -Original Message- > From: Mats Karrman [mailto:mats.dev.l...@gmail.com] > Sent: 2018年6月7日 5:45 > To: Jun Li ; robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com; li...@roeck-us.net > Cc: cw00.c...@samsung.com; a.ha...@sa

RE: [PATCH v6 05/15] usb: typec: add API to get typec basic port power and data config

2018-05-29 Thread Jun Li
Hi > -Original Message- > From: kbuild test robot [mailto:l...@intel.com] > Sent: 2018年5月30日 12:26 > To: Jun Li > Cc: kbuild-...@01.org; robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com; li...@roeck-us.net; > cw00.c...@samsung.com

RE: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-22 Thread Jun Li
Hi Heikki, > -Original Message- > From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > Sent: 2018年5月21日 21:13 > To: Jun Li > Cc: Mats Karrman ; robh...@kernel.org; > gre...@linuxfoundation.org; li...@roeck-us.net; a.ha...@samsung.com; > cw00.c...

RE: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-17 Thread Jun Li
Hi > -Original Message- > From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > Sent: 2018年5月17日 22:24 > To: Jun Li > Cc: Mats Karrman ; robh...@kernel.org; > gre...@linuxfoundation.org; li...@roeck-us.net; a.ha...@samsung.com; > cw00.c...@samsung.com; s

RE: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-17 Thread Jun Li
Hi Heikki, > > I reread this patch and tried to see it more in the context of the > > other patches and the existing code. The naming of the existing string > > tables doesn't help in getting this right, however I have a proposal: > > > > typec_find_port_power_role() to get to TYPEC_PORT_SRC/SNK/D

RE: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-17 Thread Jun Li
Hi Mats > I reread this patch and tried to see it more in the context of the other > patches > and the existing code. The naming of the existing string tables doesn't help > in > getting this right, however I have a proposal: > > typec_find_port_power_role() to get to TYPEC_PORT_SRC/SNK/DRP > t

RE: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-17 Thread Jun Li
Hi > -Original Message- > From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > Sent: 2018年5月16日 20:25 > To: Jun Li ; Mats Karrman > Cc: robh...@kernel.org; gre...@linuxfoundation.org; li...@roeck-us.net; > a.ha...@samsung.com; cw00.c...@samsung.com; shuf

RE: [PATCH v5 12/14] staging: typec: tcpci: keep the not connecting cc line open

2018-05-17 Thread Jun Li
> -Original Message- > From: Peter Chen > Sent: 2018年5月16日 16:36 > To: Jun Li ; robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com; li...@roeck-us.net > Cc: a.ha...@samsung.com; cw00.c...@samsung.com; > shufan_...@richtek.com; gso.

RE: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-17 Thread Jun Li
Hi Mats, > > Uhm, typing too fast again, I am. A better name would be just > typec_find_role(). > What I mean is that the function could be used for any situation when > someone wants to map a string to a TYPEC_{SOURCE,SINK} constant so it is > unnecessary to limit its usage to just preferred role

RE: [PATCH v5 01/14] dt-bindings: connector: add properties for typec

2018-05-17 Thread Jun Li
Hi > -Original Message- > From: Peter Chen > Sent: 2018年5月16日 15:22 > To: Jun Li ; robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com; li...@roeck-us.net > Cc: a.ha...@samsung.com; cw00.c...@samsung.com; > shufan_...@richtek.com; gso.

RE: [PATCH v5 14/14] staging: typec: tcpci: move tcpci driver out of staging

2018-05-14 Thread Jun Li
Hi > -Original Message- > From: Mats Karrman [mailto:mats.dev.l...@gmail.com] > Sent: 2018年5月12日 5:37 > To: Jun Li ; robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com; li...@roeck-us.net > Cc: a.ha...@samsung.com; cw00.c...@sams

RE: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

2018-05-14 Thread Jun Li
Hi > -Original Message- > From: Mats Karrman [mailto:mats.dev.l...@gmail.com] > Sent: 2018年5月12日 3:56 > To: Jun Li ; robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com; li...@roeck-us.net > Cc: a.ha...@samsung.com; cw00.c...@sams

RE: [PATCH v5 03/14] staging: typec: tcpci: add compatible string for nxp ptn5110

2018-05-14 Thread Jun Li
Hi > -Original Message- > From: Mats Karrman [mailto:mats.dev.l...@gmail.com] > Sent: 2018年5月12日 3:52 > To: Jun Li ; robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com; li...@roeck-us.net > Cc: a.ha...@samsung.com; cw00.c...@sams

RE: [PATCH v5 01/14] dt-bindings: connector: add properties for typec

2018-05-14 Thread Jun Li
Hi > -Original Message- > From: Mats Karrman [mailto:mats.dev.l...@gmail.com] > Sent: 2018年5月12日 3:49 > To: Jun Li ; robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com; li...@roeck-us.net > Cc: a.ha...@samsung.com; cw00.c...@sams

RE: [PATCH v5 01/14] dt-bindings: connector: add properties for typec

2018-05-09 Thread Jun Li
Hi > -Original Message- > From: Oliver Neukum [mailto:oneu...@suse.com] > Sent: 2018年5月8日 18:03 > To: Jun Li ; robh...@kernel.org; > heikki.kroge...@linux.intel.com; gre...@linuxfoundation.org; > li...@roeck-us.net > Cc: gso...@gmail.com; dl-linux-imx ; P

RE: [PATCH v5 01/14] dt-bindings: connector: add properties for typec

2018-05-07 Thread Jun Li
> -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: 2018年5月7日 23:59 > To: Jun Li > Cc: gre...@linuxfoundation.org; heikki.kroge...@linux.intel.com; > li...@roeck-us.net; a.ha...@samsung.com; cw00.c...@samsung.com; > shufan_...@richtek.co

RE: [PATCH v5 01/14] dt-bindings: connector: add properties for typec

2018-05-04 Thread Jun Li
Hi > -Original Message- > From: Oliver Neukum [mailto:oneu...@suse.com] > Sent: 2018年5月3日 17:18 > To: Jun Li ; robh...@kernel.org; > heikki.kroge...@linux.intel.com; gre...@linuxfoundation.org; > li...@roeck-us.net > Cc: gso...@gmail.com; dl-linux-imx ; P

RE: [PATCH v5 01/14] dt-bindings: connector: add properties for typec

2018-05-03 Thread Jun Li
Hi > -Original Message- > From: Oliver Neukum [mailto:oneu...@suse.com] > Sent: 2018年5月3日 15:27 > To: Jun Li ; robh...@kernel.org; > heikki.kroge...@linux.intel.com; gre...@linuxfoundation.org; > li...@roeck-us.net > Cc: gso...@gmail.com; dl-linux-imx ; P

RE: [PATCH v4 01/13] dt-bindings: connector: add properties for typec

2018-05-01 Thread Jun Li
Hi > -Original Message- > From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > Sent: 2018年4月30日 19:24 > To: Jun Li > Cc: robh...@kernel.org; gre...@linuxfoundation.org; li...@roeck-us.net; > a.ha...@samsung.com; shufan_...@richtek.com; Peter Chen > ; devic

RE: [PATCH v4 02/13] dt-bindings: usb: add documentation for typec port controller(TCPCI)

2018-05-01 Thread Jun Li
Hi, > -Original Message- > From: Mats Karrman [mailto:mats.dev.l...@gmail.com] > Sent: 2018年4月30日 15:41 > To: Jun Li > Cc: robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com; li...@roeck-us.net; a.ha...@samsung.com; > shufan_...@ri

RE: [PATCH RFC] usb: typec: tcpm: remove operating_snk_mw for rdo

2018-04-20 Thread Jun Li
> -Original Message- > From: Hans de Goede [mailto:hdego...@redhat.com] > Sent: 2018年4月20日 17:21 > To: Jun Li ; li...@roeck-us.net; > heikki.kroge...@linux.intel.com > Cc: gre...@linuxfoundation.org; linux-usb@vger.kernel.org; dl-linux-imx > > Subject: Re: [PAT

RE: [PATCH RFC] usb: typec: tcpm: remove operating_snk_mw for rdo

2018-04-20 Thread Jun Li
> -Original Message- > From: Hans de Goede [mailto:hdego...@redhat.com] > Sent: 2018年4月18日 19:40 > To: Jun Li ; li...@roeck-us.net; > heikki.kroge...@linux.intel.com > Cc: gre...@linuxfoundation.org; linux-usb@vger.kernel.org; dl-linux-imx > > Subject: Re: [PAT

RE: [PATCH v4 02/13] dt-bindings: usb: add documentation for typec port controller(TCPCI)

2018-04-19 Thread Jun Li
> -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: 2018年4月16日 22:28 > To: Jun Li > Cc: gre...@linuxfoundation.org; heikki.kroge...@linux.intel.com; > li...@roeck-us.net; a.ha...@samsung.com; shufan_...@richtek.com; Peter > Chen ; devicet...@vge

RE: [PATCH v4 02/13] dt-bindings: usb: add documentation for typec port controller(TCPCI)

2018-04-16 Thread Jun Li
Hi > -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: 2018年4月10日 4:04 > To: Jun Li > Cc: gre...@linuxfoundation.org; heikki.kroge...@linux.intel.com; > li...@roeck-us.net; a.ha...@samsung.com; shufan_...@richtek.com; Peter > Chen ; devic

RE: [PATCH v4 3/5] dt-bindings: usb: fusb302: remove max-sink-* properties

2018-04-13 Thread Jun Li
Hi Guenter, > -Original Message- > From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter Roeck > Sent: 2018年4月14日 11:03 > To: Jun Li > Cc: gre...@linuxfoundation.org; robh...@kernel.org; > heikki.kroge...@linux.intel.com; hdego...@redhat.com; rmf...@g

RE: [PATCH v4 1/5] usb: typec: tcpm: pdo matching optimization

2018-04-13 Thread Jun Li
> -Original Message- > From: Hans de Goede [mailto:hdego...@redhat.com] > Sent: 2018年4月14日 0:54 > To: Guenter Roeck ; Jun Li > Cc: gre...@linuxfoundation.org; robh...@kernel.org; > heikki.kroge...@linux.intel.com; rmf...@gmail.com; yueyao@gmail.com; > linux-us

RE: [PATCH v4 3/5] dt-bindings: usb: fusb302: remove max-sink-* properties

2018-04-13 Thread Jun Li
> -Original Message- > From: Guenter Roeck [mailto:li...@roeck-us.net] > Sent: 2018年4月14日 0:04 > To: Jun Li > Cc: gre...@linuxfoundation.org; robh...@kernel.org; > heikki.kroge...@linux.intel.com; hdego...@redhat.com; rmf...@gmail.com; > yueyao@gmail.com; linu

RE: [PATCH v4 2/5] usb: typec: fusb302: remove max_snk_* for sink config

2018-04-13 Thread Jun Li
Hi > -Original Message- > From: Guenter Roeck [mailto:li...@roeck-us.net] > Sent: 2018年4月14日 0:03 > To: Jun Li > Cc: gre...@linuxfoundation.org; robh...@kernel.org; > heikki.kroge...@linux.intel.com; hdego...@redhat.com; rmf...@gmail.com; > yueyao@gmail.com; linu

RE: [PATCH v4 1/5] usb: typec: tcpm: pdo matching optimization

2018-04-13 Thread Jun Li
Hi > -Original Message- > From: Guenter Roeck [mailto:li...@roeck-us.net] > Sent: 2018年4月13日 23:58 > To: Jun Li > Cc: gre...@linuxfoundation.org; robh...@kernel.org; > heikki.kroge...@linux.intel.com; hdego...@redhat.com; rmf...@gmail.com; > yueyao@gmail.com; linu

Re: [PATCH v4 01/13] dt-bindings: connector: add properties for typec

2018-04-13 Thread Jun Li
2018-04-03 16:29 GMT+08:00 Andrzej Hajda : > > On 28.03.2018 18:06, Li Jun wrote: > > Add bingdings supported by current typec driver, so user can pass > > all those properties via dt. > > > > Signed-off-by: Li Jun > > --- > > .../bindings/connector/usb-connector.txt | 39 > > +

RE: [PATCH v2 2/5] usb: typec: fusb302: remove max_snk_* for sink config

2018-04-09 Thread Jun Li
> -Original Message- > From: Hans de Goede [mailto:hdego...@redhat.com] > Sent: 2018年4月5日 4:13 > To: Mats Karrman ; Jun Li ; > gre...@linuxfoundation.org; robh...@kernel.org; mark.rutl...@arm.com; > heikki.kroge...@linux.intel.com > Cc: li...@roeck-us.net; rmf

RE: [PATCH v2 2/5] usb: typec: fusb302: remove max_snk_* for sink config

2018-04-09 Thread Jun Li
Hi > -Original Message- > From: Mats Karrman [mailto:mats.dev.l...@gmail.com] > Sent: 2018年4月4日 20:07 > To: Jun Li ; gre...@linuxfoundation.org; robh...@kernel.org; > mark.rutl...@arm.com; heikki.kroge...@linux.intel.com; > hdego...@redhat.com > Cc: li...@roeck-us.

RE: [PATCH v2 2/5] usb: typec: fusb302: remove max_snk_* for sink config

2018-04-09 Thread Jun Li
Hi > -Original Message- > From: Hans de Goede [mailto:hdego...@redhat.com] > Sent: 2018年4月3日 23:26 > To: Jun Li ; gre...@linuxfoundation.org; robh...@kernel.org; > mark.rutl...@arm.com; heikki.kroge...@linux.intel.com > Cc: li...@roeck-us.net; rmf...@gmail.com; yu

RE: [PATCH v2 1/5] usb: typec: tcpm: pdo matching optimization

2018-04-08 Thread Jun Li
Hi > -Original Message- > From: Hans de Goede [mailto:hdego...@redhat.com] > Sent: 2018年4月3日 23:17 > To: Jun Li ; gre...@linuxfoundation.org; robh...@kernel.org; > mark.rutl...@arm.com; heikki.kroge...@linux.intel.com > Cc: li...@roeck-us.net; rmf...@gmail.com; yu

RE: [PATCH v4 11/13] staging: typec: tcpci: keep the not connecting cc line open

2018-03-30 Thread Jun Li
Hi > -Original Message- > From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter Roeck > Sent: 2018年3月30日 23:16 > To: Jun Li ; robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com > Cc: a.ha...@samsung.com; shufan_...@richt

RE: [PATCH v4 10/13] usb: typec: tcpm: set cc for drp toggling attach

2018-03-30 Thread Jun Li
> -Original Message- > From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter Roeck > Sent: 2018年3月30日 6:49 > To: Jun Li > Cc: robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com; a.ha...@samsung.com; > shufan_...@ri

RE: [PATCH v4 10/13] usb: typec: tcpm: set cc for drp toggling attach

2018-03-30 Thread Jun Li
Hi > -Original Message- > From: Mats Karrman [mailto:mats.dev.l...@gmail.com] > Sent: 2018年3月30日 5:19 > To: Jun Li ; robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com; li...@roeck-us.net > Cc: a.ha...@samsung.com; shufan_...@richt

RE: [PATCH v4 01/13] dt-bindings: connector: add properties for typec

2018-03-30 Thread Jun Li
Hi > -Original Message- > From: Mats Karrman [mailto:mats.dev.l...@gmail.com] > Sent: 2018年3月30日 3:54 > To: Jun Li ; robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com; li...@roeck-us.net > Cc: a.ha...@samsung.com; shufan_...@richt

RE: [PATCH v4 04/13] usb: typec: add fwnode to tcpc

2018-03-30 Thread Jun Li
Hi > -Original Message- > From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > Sent: 2018年3月29日 20:58 > To: Jun Li > Cc: robh...@kernel.org; gre...@linuxfoundation.org; li...@roeck-us.net; > a.ha...@samsung.com; shufan_...@richtek.com; Peter Chen > ; devic

RE: [PATCH v4 07/13] staging: typec: tcpci: register port before request irq

2018-03-30 Thread Jun Li
Hi > -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: 2018年3月29日 18:52 > To: Jun Li > Cc: robh...@kernel.org; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com; li...@roeck-us.net; > de...@driverdev.osuosl.org; devic

RE: [PATCH 1/5] usb: typec: tcpm: source pdo selection update

2018-03-23 Thread Jun Li
Hi > -Original Message- > From: Jun Li > Sent: 2018年3月21日 19:14 > To: Hans de Goede ; gre...@linuxfoundation.org; > robh...@kernel.org; mark.rutl...@arm.com; > heikki.kroge...@linux.intel.com; li...@roeck-us.net; rmf...@gmail.com; > yueyao@gmail.com > Cc: l

RE: [PATCH 2/5] usb: typec: fusb302: remove max_snk_* for sink config

2018-03-21 Thread Jun Li
> -Original Message- > From: Hans de Goede [mailto:hdego...@redhat.com] > Sent: 2018年3月20日 20:29 > To: Jun Li ; gre...@linuxfoundation.org; > robh...@kernel.org; mark.rutl...@arm.com; > heikki.kroge...@linux.intel.com; li...@roeck-us.net; rmf...@gmail.com; > yuey

  1   2   3   >