rintk statement and an unused
> printk-based macro.
>
> Signed-off-by: Laurent Pinchart
Great - looks good to me.
Reviewed-by: Kieran Bingham
> ---
> drivers/usb/gadget/function/f_uvc.c | 41
> ++---
> drivers/usb/gadget/function/uvc.h
d can't thus report a stall. The usb_ep_set_halt()
> call returns an error when using isochronous endpoints, which we happily
> ignore, but some UDCs complain in the kernel log. Fix this by only
> trying to halt the endpoint in bulk mode.
>
Agreed,
> Signed-off-by: Laurent Pin
ocking. Win win.
Reviewed-by: Kieran Bingham
> ---
> drivers/usb/gadget/function/uvc_video.c | 30 --
> 1 file changed, 20 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/usb/gadget/function/uvc_video.c
> b/drivers/usb/gadget/function
Hi Laurent,
On 18/09/18 13:25, Laurent Pinchart wrote:
> The function is never called, remove it.
It does seem that way :)
> Signed-off-by: Laurent Pinchart
Reviewed-by: Kieran Bingham
> ---
> drivers/usb/gadget/function/f_uvc.c | 6 --
> 1 file changed, 6 deletions(-)
Hi Laurent,
On 24/09/18 17:00, Laurent Pinchart wrote:
> Hi Kieran,
>
> On Monday, 24 September 2018 15:22:57 EEST Kieran Bingham wrote:
>> On 01/08/18 22:55, Laurent Pinchart wrote:
>>> From: Joel Pepper
>>>
>>> - Add bFrameIndex as a UVCG_FRAME_ATTR_R
lare here?
Couldn't we move the uvcg_format_set_indices() implementation up ?
Or is it preferred to keep that code down in the lower section.
With a decision made on that, and the typo fixed in the commit message:
Reviewed-by: Kieran Bingham
> static int uvcg_streaming_header_allow_link(s
t, invalidating the protections.
That explains what's wrong, but not what we do about it. How about adding:
"Update the flag as appropriate in the header link calls."
>
> Signed-off-by: Joel Pepper
Missing and S-o-B from Laurent here? (I guess that will be added later?)
Otherwis
n.
>
> Signed-off-by: Laurent Pinchart
> ---
>
> Changes since v1:
>
> - Squash patch "usb: gadget: uvc: configfs: Document the bFormatIndex
> attribute".
Thanks,
Reviewed-by: Kieran Bingham
> ---
> Documentation/ABI/testing/configfs-usb-gad
ment the new attribute
Perfect, Thank you.
Reviewed-by: Kieran Bingham
> ---
> Documentation/ABI/testing/configfs-usb-gadget-uvc | 8 +++
> drivers/usb/gadget/function/f_uvc.c | 2 +
> drivers/usb/gadget/function/u_uvc.h | 3 ++
>
Changes since v1:
>
> - Free groups by implementing .release() handler and removing children
> explicitly.
Great - that resolves my concerns from the previous iteration.
Reviewed-by: Kieran Bingham
> ---
> drivers/usb/gadget/function/f_uvc.c| 8 +-
off-by: Laurent Pinchart
Reviewed-by: Kieran Bingham
> ---
> drivers/usb/gadget/function/uvc_configfs.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/gadget/function/uvc_configfs.c
> b/drivers/usb/gadget/function/uvc_configfs.c
> index dbc95c9558de.
Hi Laurent,
On 01/08/18 01:29, Laurent Pinchart wrote:
> Document for the bFormatIndex attribute of the format descriptors is
> missing. Add it.
It might be missing, but only just since the previous patch.
Perhaps this should squash into [5/8] ?
> Signed-off-by: Laurent Pinchart
> ---
>
Hi Laurent,
Thank you for the patch,
On 01/08/18 01:29, Laurent Pinchart wrote:
> The video control and video streaming interface numbers are needed in
> the UVC gadget userspace stack to reply to UVC requests. They are
> hardcoded to fixed values at the moment, preventing configurations with
>
Hi Laurent,
Thank you for the patch,
On 01/08/18 01:29, Laurent Pinchart wrote:
> The UVC configfs implementation creates all groups as global static
> variables. This prevents creationg of multiple UVC function instances,
/creationg/creation/
> as they would all require their own configfs
Hi Laurent,
A trivial but nice improvement.
On 01/08/18 01:29, Laurent Pinchart wrote:
> The UVC configfs implementation is large and difficult to navigate. Add
> a bit more air to the code to make it easier to read.
>
> Signed-off-by: Laurent Pinchart
Acked-by: Ki
phew. Well that is some terse reading of macro modifications.
But except for the trivial spellings above, I can't see anything wrong.
And this definitely moves the right way :D
Reviewed-by: Kieran Bingham
> ---
> drivers/usb/gadget/function/uvc_configfs.c | 302
> +++
From: Kieran Bingham <kieran.bing...@ideasonboard.com>
When utilising multiple instantiations of a UVC gadget on a composite
device, there is no clear method to link a particular configuration to
its respective video node.
Provide a means for identifying the correct video node by ex
From: Kieran Bingham <kieran.bing...@ideasonboard.com>
When utilising multiple instantiations of a UVC gadget on a composite
device, there is no clear method to link a particular configuration to
its respective video node.
Provide a means for identifying the correct video node by ex
From: Kieran Bingham <kieran.bing...@ideasonboard.com>
With multiple UVC gadgets on a composite device, the device names become
indistinguishable from one another.
Extend the gadget video name to incorporate the function instance name,
along side the existing UDC controller name.
Sign
Hi Bin, Felipe,
We have been trying to get a UVC gadget operational on the Pandaboard ES
platform, and we believe we've hit an issue with short packets on the MUSB in
DMA mode.
Using the g_webcam module, I can instantiate a UVC video node, and use the
uvc-gadget helper application [0] to handle
20 matches
Mail list logo
