Re: kernel BUG at ./include/linux/mm.h:LINE! (3)

2018-01-03 Thread Kirill A. Shutemov
On Wed, Jan 03, 2018 at 01:02:38AM -0600, Pete Zaitcev wrote: > On Fri, 29 Dec 2017 16:24:20 +0300 > "Kirill A. Shutemov" <kir...@shutemov.name> wrote: > > > Looks like MON_IOCT_RING_SIZE reallocates ring buffer without any > > serialization wrt mon_bin

Re: Fw: kernel BUG at ./include/linux/mm.h:LINE! (3)

2017-12-29 Thread Kirill A. Shutemov
On Thu, Dec 28, 2017 at 04:03:46PM -0800, Andrew Morton wrote: > > Is anyone able to reproduce this? The VM_BUG_ON_PAGE() in get_page() > went bang. Yep, it triggers for me. Looks like MON_IOCT_RING_SIZE reallocates ring buffer without any serialization wrt mon_bin_vma_fault(). By the time of

Re: [PATCH v5 06/78] xarray: Change definition of sibling entries

2017-12-27 Thread Kirill A. Shutemov
On Tue, Dec 26, 2017 at 07:13:26PM -0800, Matthew Wilcox wrote: > On Tue, Dec 26, 2017 at 08:21:53PM +0300, Kirill A. Shutemov wrote: > > > +/** > > > + * xa_is_internal() - Is the entry an internal entry? > > > + * @entry: Entry retrieved from the XArray >

Re: [PATCH v5 05/78] xarray: Replace exceptional entries

2017-12-27 Thread Kirill A. Shutemov
On Tue, Dec 26, 2017 at 07:05:34PM -0800, Matthew Wilcox wrote: > On Tue, Dec 26, 2017 at 08:15:42PM +0300, Kirill A. Shutemov wrote: > > > 28 files changed, 249 insertions(+), 240 deletions(-) > > > > Everything looks fine to me after quick scan, but hat's a lot of c

Re: [PATCH v5 03/78] xarray: Add the xa_lock to the radix_tree_root

2017-12-27 Thread Kirill A. Shutemov
NULL); > spin_unlock_irqrestore(>pages.xa_lock, flags); > > More details here: https://9p.io/sys/doc/compiler.html Yeah, that's neat. Dealing with old compilers is frustrating... -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH v5 03/78] xarray: Add the xa_lock to the radix_tree_root

2017-12-27 Thread Kirill A. Shutemov
On Tue, Dec 26, 2017 at 07:43:40PM -0800, Matthew Wilcox wrote: > On Tue, Dec 26, 2017 at 07:54:40PM +0300, Kirill A. Shutemov wrote: > > On Fri, Dec 15, 2017 at 02:03:35PM -0800, Matthew Wilcox wrote: > > > From: Matthew Wilcox <mawil...@microsoft.com> > > >

Re: [PATCH v5 06/78] xarray: Change definition of sibling entries

2017-12-26 Thread Kirill A. Shutemov
entry"? Is it just a term for non-value and non-data pointer entry? Do we allow anybody besides xarray implementation to use internal entires? Do we have it documented? -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 05/78] xarray: Replace exceptional entries

2017-12-26 Thread Kirill A. Shutemov
if (index > end) > break; > > - if (radix_tree_exceptional_entry(page)) { > + if (xa_is_value(page)) { > if (!invalidate_exceptional_entry2(mapping, >

Re: [PATCH v5 04/78] page cache: Use xa_lock

2017-12-26 Thread Kirill A. Shutemov
gt; since we don't really care that it's a tree. Take the opportunity to > rearrange the elements of address_space to pack them better on 64-bit, > and make the comments more useful. The description sounds a lot like three commits ;) -- Kirill A. Shutemov -- To unsubscribe from this list:

Re: [PATCH v5 03/78] xarray: Add the xa_lock to the radix_tree_root

2017-12-26 Thread Kirill A. Shutemov
subject and commit message. At first I was confused why do you need to touch idr here. It took few minutes to figure it out. Could you please add more into commit message about lockname and xa_ locking interface since you introduce it here? -- Kirill A. Shutemov -- To unsubscribe from this l

Re: Does vm_operations_struct require a .owner field?

2016-01-05 Thread Kirill A. Shutemov
closed from kernel POV until vma is gone and you cannot unload relevant module. See get_file() in mmap_region(). -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html