Re: [PATCH] extcon: palmas: Handle ID interrupt properly using USB_ID_INT_SRC

2013-10-21 Thread Laxman Dewangan
is set wrongly. This uses the previous Link stat to determine the new state. Looks good to me. Acked-by: Laxman Dewangan ldewan...@nvidia.com -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v5 2/3] extcon: Palmas Extcon Driver

2013-05-27 Thread Laxman Dewangan
On Monday 27 May 2013 11:38 AM, Chanwoo Choi wrote: On 05/27/2013 02:54 PM, Kishon Vijay Abraham I wrote: Hi, On Monday 27 May 2013 11:04 AM, Chanwoo Choi wrote: Hi Kishon, I have some comment about this patch and upload modified patch to following repository (extcon-for-palmas). -

Re: [PATCH v5 2/3] extcon: Palmas Extcon Driver

2013-05-27 Thread Laxman Dewangan
On Monday 27 May 2013 12:11 PM, Kishon Vijay Abraham I wrote: Hi, On Monday 27 May 2013 12:06 PM, Laxman Dewangan wrote: On Monday 27 May 2013 12:01 PM, Kishon Vijay Abraham I wrote: Hi, On Monday 27 May 2013 11:52 AM, Laxman Dewangan wrote: On Monday 27 May 2013 11:38 AM, Chanwoo Choi

Re: [PATCH 1/3] drivers: regulator: palmas: add an API to set/clear the switch bit on SMPS10

2013-05-25 Thread Laxman Dewangan
Hi Kishon/Graeme, On Friday 24 May 2013 08:01 PM, Kishon Vijay Abraham I wrote: From: Graeme Gregory g...@slimlogic.co.uk Added an API to set/clear the switch bit on SMPS10 which can be used by palmas usb. The switch bit should be set in order for palmas to supply VBUS and is needed when OMAP

Re: [PATCH v5 2/3] extcon: Palmas Extcon Driver

2013-05-25 Thread Laxman Dewangan
Hi Graeme/Kishon, On Friday 24 May 2013 08:01 PM, Kishon Vijay Abraham I wrote: From: Graeme Gregory g...@slimlogic.co.uk This is the driver for the USB comparator built into the palmas chip. It handles the various USB OTG events that can be generated by cable insertion/removal. I have

Re: [PATCH v3] USB: PHY: Palmas USB Transceiver Driver

2013-03-26 Thread Laxman Dewangan
On Tuesday 26 March 2013 02:31 PM, Graeme Gregory wrote: On 26/03/13 06:03, Kishon Vijay Abraham I wrote: +static int palmas_usb_read(struct palmas *palmas, unsigned int reg, + unsigned int *dest) +{ + unsigned int addr; + int slave; + + slave =

Re: [PATCH v3] USB: PHY: Palmas USB Transceiver Driver

2013-03-26 Thread Laxman Dewangan
On Tuesday 26 March 2013 02:57 PM, Graeme Gregory wrote: On 26/03/13 09:12, Laxman Dewangan wrote: On Tuesday 26 March 2013 02:31 PM, Graeme Gregory wrote: But still you are using the PALMAS macro here and indirectly it is tied up. It is not completely independent. If need to be independent

Re: [PATCH v3] USB: PHY: Palmas USB Transceiver Driver

2013-03-26 Thread Laxman Dewangan
On Tuesday 26 March 2013 03:51 PM, Felipe Balbi wrote: * PGP Signed by an unknown key Hi, On Tue, Mar 26, 2013 at 09:01:42AM +, Graeme Gregory wrote: From: Graeme Gregory g...@slimlogic.co.uk This is the driver for the OTG transceiver built into the Palmas chip. It handles the various

Re: [PATCH v3] USB: PHY: Palmas USB Transceiver Driver

2013-03-26 Thread Laxman Dewangan
On Tuesday 26 March 2013 03:21 PM, Graeme Gregory wrote: On 26/03/13 09:34, Laxman Dewangan wrote: Kishon, I think it is very much possible. You can pass the interrupt throough IRQ_RESOURCE and populate it from DT. If you provide proper interrupt parent and irq number then irq framework take

Re: [PATCH v3] USB: PHY: Palmas USB Transceiver Driver

2013-03-25 Thread Laxman Dewangan
On Monday 25 March 2013 03:02 PM, Kishon Vijay Abraham I wrote: From: Graeme Gregory g...@slimlogic.co.uk This is the driver for the OTG transceiver built into the Palmas chip. It handles the various USB OTG events that can be generated by cable insertion/removal. Signed-off-by: Graeme Gregory

Re: [PATCH 4/4] regulator: fixed: Properly use input_supply parameter from device tree

2012-11-15 Thread Laxman Dewangan
: Laxman Dewangan ldewan...@nvidia.com CC: Mark Brown broo...@opensource.wolfsonmicro.com --- regulator-boot-on; gpio-open-drain; - vin-supply = parent_reg; + vin-supply = input-supply-name; This is not correct as per the regulator binding

Re: [PATCH v.2] usb: host: tegra: pass correct pointer in ehci_setup()

2012-07-12 Thread Laxman Dewangan
On Thursday 12 July 2012 08:04 PM, Alan Stern wrote: From: Laxman Dewanganldewan...@nvidia.com The ehci_setup() require the pointer of usb_hcd. Passing the correct pointer in place of ehci_hcd pointer. This is side effect of change: commit 1a49e2ac9651df7349867a5cf44e2c83de1046af Author: Alan