Hi Miquel,
On Fri, Mar 29, 2019 at 4:16 PM Miquel Raynal wrote:
>
> Hi Martin,
>
> Martin Blumenstingl wrote on Tue,
> 26 Mar 2019 18:29:25 +0100:
>
> > Hello Miquel,
> >
> > On Tue, Mar 26, 2019 at 9:39 AM Miquel Raynal
> > wrote:
> > >
&g
eneric PHY initialization within
> the HCD core (as there is none); or they use a single 'phy' and the
> code flow does not pass through the block setting
> hcd->skip_phy_initialization anyway.
>
> While there is not users of both PHY types at the same time, drop this
> l
s, and
> setups the on-chip OTG mode selection for this PHY.
>
> The PHYs phandles are passed to the Glue node since the Glue controls the
> interface with the PHY, not the DWC3 controller.
>
> Signed-off-by: Neil Armstrong
Reviewed-by: Martin Blumensting
ce to which the controller is connected
provides power, thus the regulator has to be disabled
Add the dt-bindings documentation for this property so .dts authors know
that this property exists and how it behaves.
Fixes: 531ef5ebea9639 ("usb: dwc2: add support for host mode ext
Hi Neil,
On Mon, Mar 4, 2019 at 11:40 AM Neil Armstrong wrote:
[...]
> +static int phy_g12a_usb3_init(struct phy *phy)
> +{
> + struct phy_g12a_usb3_pcie_priv *priv = phy_get_drvdata(phy);
> + int data, ret;
> +
> + /* Switch PHY to USB3 */
> + regmap_update_bits(priv->reg
Hi Neil,
On Mon, Mar 4, 2019 at 11:40 AM Neil Armstrong wrote:
[...]
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
there's a "regmap" include right above. this driver doesn't use syscon
so this include can be dropped
[...]
> +static int phy_meson_g12a
Hi Neil,
On Mon, Mar 4, 2019 at 11:38 AM Neil Armstrong wrote:
>
> Add the Amlogic G12A Family USB3 + PCIE Combo PHY Bindings.
>
> This PHY can provide exclusively USB3 or PCIE support on shared I/Os.
>
> Signed-off-by: Neil Armstrong
> Reviewed-by: Martin Blumenstingl
Hi Neil,
> > +static int dwc3_meson_g12a_debugfs_init(struct dwc3_meson_g12a *priv)
> > +{
> > + priv->root = debugfs_create_dir("dwc3-meson-g12a", NULL);
> > + if (IS_ERR(priv->root))
> > + return PTR_ERR(priv->root);
> > +
> > + debugfs_create_file("mode_force", 0
Hi Neil,
thank you for working on this!
I have few questions and comments below, but overall it looks good :)
On Tue, Feb 12, 2019 at 4:17 PM Neil Armstrong wrote:
>
> Adds support for Amlogic G12A USB Control Glue HW.
>
> The Amlogic G12A SoC Family embeds 2 USB Controllers :
> - a DWC3 IP conf
Hi Neil,
On Tue, Feb 12, 2019 at 4:15 PM Neil Armstrong wrote:
[...]
> +
> +Example device nodes:
> + usb: usb@ffe09000 {
> + compatible = "amlogic,meson-g12a-usb-ctrl";
> + reg = <0x0 0xffe09000 0x0 0xa0>;
> + interrupts = ;
Hi Neil,
On Tue, Feb 12, 2019 at 4:16 PM Neil Armstrong wrote:
>
> This adds support for the shared USB3 + PCIE PHY found in the
> Amlogic G12A SoC Family.
>
> It supports USB3 Host mode or PCIE 2.0 mode, depending on the layout of
> the board.
>
> Selection is done by the #phy-cells, making the
L_USB3) += phy-meson-gxl-usb3.o
> diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb2.c
> b/drivers/phy/amlogic/phy-meson-g12a-usb2.c
> new file mode 100644
> index ..3b6271a8be02
> --- /dev/null
> +++ b/drivers/phy/amlogic/phy-meson-g12a-usb2.c
> @@
Hi Neil,
On Tue, Feb 12, 2019 at 4:15 PM Neil Armstrong wrote:
>
> Adds the specific compatible string for the DWC2 IP found in the
> Amlogic G12A SoC Family.
>
> Signed-off-by: Neil Armstrong
Reviewed-by: Martin Blumenstingl
> ---
> Documentation/devicetree/bindings/us
On Tue, Feb 12, 2019 at 4:15 PM Neil Armstrong wrote:
>
> Add the Amlogic G12A Family USB3 + PCIE Combo PHY Bindings.
>
> This PHY can provide exclusively USB3 or PCIE support on shared I/Os.
>
> Signed-off-by: Neil Armstrong
one nit-pick below, but apart from that:
R
PHY
Bindings. The PHY works for host or peripheral modes. Configuration of
the mode is part of the USBCTRL registers which are outside of the PHY
registers."
> Signed-off-by: Neil Armstrong
with the patch description nit-pick addressed:
Reviewed-by: Martin Blumenstingl
Regards
Martin
arameter (which then got renamed to
"power_down" to support other modes) was changed in the v4.17 merge
window with:
commit 6d23ee9caa6790 ("Merge tag 'usb-for-v4.17' of
git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb into usb-testing").
Cc: # 4.19
Sug
v" as a workaround)
Christian Hewitt made me aware of a similar issue that was fixed for
Rockchip devices. This single patch applies the same fix to the
Amlogic devices as well.
[0] http://lists.infradead.org/pipermail/linux-amlogic/2018-May/007310.html
Martin Blumenstingl (1):
usb: dwc
/2018/4/19/88
> [1] https://patchwork.kernel.org/patch/10160181/
>
> Signed-off-by: Chunfeng Yun
> Reviewed-by: Johan Hovold
Reviewed-by: Martin Blumenstingl
thanks to both of you for fixing my code!
Regards
Martin
HANG! AHB Idle timeout
> GRSTCTL GRSTCTL_AHBIDLE
> [2.015176] dwc2: probe of 5000.usb failed with error -16
>
> The proposed patch changes the location where dwc2_check_core_endianness
> is called, allowing the clock peripheral to be enabled first.
>
> Signed-off-by: B
On Wed, Jul 4, 2018 at 4:16 PM Martin Blumenstingl
wrote:
[...]
> unfortunately it seems that plugging in seems to fill the kmsg buffer
> instantly, so I cannot (at least I don't know how - do you have any
> idea how to get around this?) get the information from the second
> wher
Hello Arthur, Hello Minas,
On Wed, Jul 4, 2018 at 1:43 PM Artur Petrosyan
wrote:
>
> Hello Martin,
>
> On 7/4/2018 01:39, Martin Blumenstingl wrote:
> > Hello Minas,
> >
> > On Thu, May 10, 2018 at 11:44 AM Martin Blumenstingl
> > wrote:
> >>
> &g
Hello Minas,
On Thu, May 10, 2018 at 11:44 AM Martin Blumenstingl
wrote:
>
> Hello Minas,
>
> On Mon, May 7, 2018 at 3:27 PM, Minas Harutyunyan
> wrote:
> > Hi Martin,
> >
> > On 5/7/2018 12:28 AM, Martin Blumenstingl wrote:
> >> Hello,
> >>
to struct usb_hcd")
> Cc: Martin Blumenstingl
> Reported-by: Mats Karrman
> Signed-off-by: Peter Chen
Acked-by: Martin Blumenstingl
> ---
> drivers/usb/chipidea/host.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/us
Hello Minas,
On Mon, May 7, 2018 at 3:27 PM, Minas Harutyunyan
wrote:
> Hi Martin,
>
> On 5/7/2018 12:28 AM, Martin Blumenstingl wrote:
>> Hello,
>>
>> I was a bit surprised to see that hot-plugging USB devices on Amlogic
>> Meson8b (for example: Odroid-C1) is br
Hello,
I was a bit surprised to see that hot-plugging USB devices on Amlogic
Meson8b (for example: Odroid-C1) is broken.
to be fair: I *think* it worked before, but I cannot guarantee it nor
can I say when it broke
all examples below are from an Odroid-C1 board with Amlogic Meson8b (S805) SoC.
th
(adding Yixun from Amlogic to this mail)
On Sat, Apr 28, 2018 at 4:41 AM, Masahiro Yamada
wrote:
> Hi Martin,
>
>
> 2018-04-24 2:44 GMT+09:00 Martin Blumenstingl
> :
>> Hello,
>>
>> On Thu, Apr 19, 2018 at 1:03 PM, Masahiro Yamada
>> wrote:
>>> Hi
Hello,
On Thu, Apr 19, 2018 at 1:03 PM, Masahiro Yamada
wrote:
> Historically, the clocks and resets are handled on the glue layer
> side instead of the DWC3 core. For simple cases, dwc3-of-simple.c
> takes care of arbitrary number of clocks and resets. The DT node
> structure typically looks l
Hi Greg,
On Sun, Apr 22, 2018 at 3:01 PM, Greg KH wrote:
> On Wed, Apr 18, 2018 at 09:39:51PM +0200, Martin Blumenstingl wrote:
>> This clarifies the license of the code. While here also add an include
>> guard to the header file.
>>
>> Fixes: 07dbff0ddbd86c ("
Hello Johan,
On Thu, Apr 19, 2018 at 9:43 AM, Johan Hovold wrote:
> On Wed, Apr 18, 2018 at 09:18:30PM +0200, Martin Blumenstingl wrote:
>> Hi Johan,
>>
>> On Fri, Apr 13, 2018 at 5:15 PM, Johan Hovold wrote:
>> > I've been carrying a patch out-of-tree sinc
HY is disabled). All
existing usb_phy_roothub_* functions are already NULL-safe, so no
special handling is required there.
Fixes: 07dbff0ddbd8 ("usb: core: add a wrapper for the USB PHYs on the HCD")
Reported-by: Stefan Wahren
Signed-off-by: Martin Blumenstingl
---
drivers/usb/core/phy.c
bc1 ("usb: core: hcd: integrate the PHY wrapper into the HCD
core")
Reported-by: Roger Quadros
Suggested-by: Roger Quadros
Suggested-by: Chunfeng Yun
Signed-off-by: Martin Blumenstingl
Tested-by: Chunfeng Yun
Reviewed-by: Roger Quadros
Tested-by: Keerthy
---
drivers/usb/core/hcd.c | 8 ++
https://www.spinics.net/lists/linux-usb/msg167472.html
[8] http://lists.infradead.org/pipermail/linux-amlogic/2018-March/006882.html
[9] http://lists.infradead.org/pipermail/linux-amlogic/2018-April/007009.html
Martin Blumenstingl (6):
usb: core: phy: fix return value of usb_phy_roothub_exit()
usb:
This clarifies the license of the code. While here also add an include
guard to the header file.
Fixes: 07dbff0ddbd86c ("usb: core: add a wrapper for the USB PHYs on the HCD")
Suggested-by: Masahiro Yamada
Signed-off-by: Martin Blumenstingl
---
drivers/usb/core/phy.h | 12 ++
x27;t include any of the struct device API headers.
Fixes: 07dbff0ddbd86c ("usb: core: add a wrapper for the USB PHYs on the HCD")
Suggested-by: Masahiro Yamada
Signed-off-by: Martin Blumenstingl
---
drivers/usb/core/phy.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/u
that failed somewhere).
This is a preparation step for adding proper suspend support for some
hardware that requires phy_exit to be called during suspend and phy_init
to be called during resume.
Signed-off-by: Martin Blumenstingl
Tested-by: Chunfeng Yun
Reviewed-by: Roger Quadros
Tested-by: Ke
;usb: core: add a wrapper for the USB PHYs on the HCD")
Signed-off-by: Martin Blumenstingl
Signed-off-by: Rishabh Bhatnagar
Tested-by: Keerthy
---
drivers/usb/core/phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/core/phy.c b/drivers/usb/core/phy.c
in
Hi Johan,
On Fri, Apr 13, 2018 at 5:15 PM, Johan Hovold wrote:
> I've been carrying a patch out-of-tree since my work on improving the
> USB device-tree support which is needed to be able to describe USB
> topologies for musb based controllers.
>
> This patch, which associates the platform contro
This clarifies the license of the code. While here also add an include
guard to the header file.
Fixes: 07dbff0ddbd86c ("usb: core: add a wrapper for the USB PHYs on the HCD")
Suggested-by: Masahiro Yamada
Signed-off-by: Martin Blumenstingl
---
drivers/usb/core/phy.h | 12 ++
HY is disabled). All
existing usb_phy_roothub_* functions are already NULL-safe, so no
special handling is required there.
Fixes: 07dbff0ddbd8 ("usb: core: add a wrapper for the USB PHYs on the HCD")
Reported-by: Stefan Wahren
Signed-off-by: Martin Blumenstingl
---
drivers/usb/core/phy.c
x27;t include any of the struct device API headers.
Fixes: 07dbff0ddbd86c ("usb: core: add a wrapper for the USB PHYs on the HCD")
Suggested-by: Masahiro Yamada
Signed-off-by: Martin Blumenstingl
---
drivers/usb/core/phy.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/u
amlogic/2018-March/006819.html
[4] http://lists.infradead.org/pipermail/linux-amlogic/2018-March/006794.html
[5] http://lists.infradead.org/pipermail/linux-amlogic/2018-March/006820.html
[6] http://lists.infradead.org/pipermail/linux-amlogic/2018-March/006847.html
[7] https://www.spinics.net/lists/
;usb: core: add a wrapper for the USB PHYs on the HCD")
Signed-off-by: Martin Blumenstingl
Signed-off-by: Rishabh Bhatnagar
---
drivers/usb/core/phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/core/phy.c b/drivers/usb/core/phy.c
index 09b7c43c0ea4..f19
that failed somewhere).
This is a preparation step for adding proper suspend support for some
hardware that requires phy_exit to be called during suspend and phy_init
to be called during resume.
Signed-off-by: Martin Blumenstingl
Tested-by: Chunfeng Yun
Reviewed-by: Roger Quadros
---
drivers/usb
bc1 ("usb: core: hcd: integrate the PHY wrapper into the HCD
core")
Reported-by: Roger Quadros
Suggested-by: Roger Quadros
Suggested-by: Chunfeng Yun
Signed-off-by: Martin Blumenstingl
Tested-by: Chunfeng Yun
Reviewed-by: Roger Quadros
---
drivers/usb/core/hcd.c | 8 +--
Hello,
thank you for finding this!
On Sat, Apr 7, 2018 at 1:04 AM, Rishabh Bhatnagar
wrote:
> In file drivers/usb/core/phy.c line 114, ret variable is assigned to
> itself. The following error was observed:
>
> kernel/drivers/usb/core/phy.c:114:8: warning: explicitly assigning value of
> variabl
On Fri, Apr 6, 2018 at 5:48 AM, Masahiro Yamada
wrote:
> 2018-04-06 5:04 GMT+09:00 Martin Blumenstingl
> :
>> Hello,
>>
>> (great to hear that this might be useful on Socionext SoCs as well :))
>>
>> On Wed, Apr 4, 2018 at 2:10 PM, Masahiro Yamada
>> w
Hi Greg,
On Thu, Apr 5, 2018 at 3:38 PM, Greg KH wrote:
> On Thu, Apr 05, 2018 at 11:47:11AM +0300, Roger Quadros wrote:
>> Greg,
>>
>> On 28/03/18 00:26, Martin Blumenstingl wrote:
>> > This is a follow-up to my previous series "initialize (multiple) PHYs
&g
Hello,
(great to hear that this might be useful on Socionext SoCs as well :))
On Wed, Apr 4, 2018 at 2:10 PM, Masahiro Yamada
wrote:
> 2018-03-04 6:43 GMT+09:00 Martin Blumenstingl
> :
>> Many SoC platforms have separate devices for the USB PHY which are
>> registered throu
Hello Stefan,
On Sat, Mar 31, 2018 at 9:28 PM, Stefan Wahren wrote:
> If the generic PHY support is disabled the stub of devm_of_phy_get_by_index
> returns ENOSYS. This corner case isn't handled properly by
> usb_phy_roothub_add_phy and at least breaks USB support on Raspberry Pi
> (bcm2835_defco
that failed somewhere).
This is a preparation step for adding proper suspend support for some
hardware that requires phy_exit to be called during suspend and phy_init
to be called during resume.
Signed-off-by: Martin Blumenstingl
Tested-by: Chunfeng Yun
Reviewed-by: Roger Quadros
---
drivers/usb
bc1 ("usb: core: hcd: integrate the PHY wrapper into the HCD
core")
Reported-by: Roger Quadros
Suggested-by: Roger Quadros
Suggested-by: Chunfeng Yun
Signed-off-by: Martin Blumenstingl
Tested-by: Chunfeng Yun
Reviewed-by: Roger Quadros
---
drivers/usb/core/hcd.c | 8 +--
g/pipermail/linux-amlogic/2018-March/006819.html
[4] http://lists.infradead.org/pipermail/linux-amlogic/2018-March/006794.html
[5] http://lists.infradead.org/pipermail/linux-amlogic/2018-March/006820.html
[6] http://lists.infradead.org/pipermail/linux-amlogic/2018-March/006847.html
Martin Blumensti
bc1 ("usb: core: hcd: integrate the PHY wrapper into the HCD
core")
Reported-by: Roger Quadros
Suggested-by: Roger Quadros
Suggested-by: Chunfeng Yun
Signed-off-by: Martin Blumenstingl
---
drivers/usb/core/hcd.c | 8 +---
drivers/usb/core/phy.c | 35 ++
radead.org/pipermail/linux-amlogic/2018-March/006737.html
[2] http://lists.infradead.org/pipermail/linux-amlogic/2018-March/006758.html
[3] http://lists.infradead.org/pipermail/linux-amlogic/2018-March/006819.html
[4] http://lists.infradead.org/pipermail/linux-amlogic/2018-March/006794.html
[5] http://
that failed somewhere).
This is a preparation step for adding proper suspend support for some
hardware that requires phy_exit to be called during suspend and phy_init
to be called during resume.
Signed-off-by: Martin Blumenstingl
---
drivers/usb/core/hcd.c | 10 +++---
drivers/usb/core/phy.c
Hi Chunfeng,
On Mon, Mar 26, 2018 at 5:37 AM, Chunfeng Yun wrote:
> On Sat, 2018-03-24 at 15:21 +0100, Martin Blumenstingl wrote:
>> Before this patch usb_phy_roothub_init served two purposes (from a
>> caller's point of view - like hcd.c):
>> - parsing the PHYs and a
Hi Chunfeng,
On Mon, Mar 26, 2018 at 5:43 AM, Chunfeng Yun wrote:
> On Sat, 2018-03-24 at 14:56 +0100, Martin Blumenstingl wrote:
>> usb_phy_roothub_exit() should return the error code from the phy_exit()
>> call if exiting the PHY failed.
>> However, since a w
that failed somewhere).
This is a preparation step for adding proper suspend support for some
hardware that requires phy_exit to be called during suspend and phy_init
to be called during resume.
Signed-off-by: Martin Blumenstingl
---
drivers/usb/core/hcd.c | 10 +++---
drivers/usb/core/phy.c
h/006819.html
[4] http://lists.infradead.org/pipermail/linux-amlogic/2018-March/006794.html
Martin Blumenstingl (2):
usb: core: split usb_phy_roothub_{init,alloc}
usb: core: use phy_exit during suspend if wake up is not supported
drivers/usb/core/hcd.c | 18 +++
drivers/usb/core/phy.c
the PHY wrapper into the HCD
core")
Reported-by: Roger Quadros
Suggested-by: Roger Quadros
Suggested-by: Chunfeng Yun
Signed-off-by: Martin Blumenstingl
---
drivers/usb/core/hcd.c | 8 +---
drivers/usb/core/phy.c | 37 +
drivers/usb/core/phy.h |
() to the "ret"
variable to propagate the error correctly.
Fixes: 07dbff0ddbd86c ("usb: core: add a wrapper for the USB PHYs on the HCD")
Signed-off-by: Martin Blumenstingl
---
drivers/usb/core/phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driv
Hi Roger,
On Wed, Mar 21, 2018 at 12:30 PM, Roger Quadros wrote:
> Martin,
>
> On 21/03/18 00:01, Martin Blumenstingl wrote:
>> Hi Roger, Hi Chunfeng,
>>
>> On Tue, Mar 20, 2018 at 1:04 PM, Chunfeng Yun
>> wrote:
>>> Hi Martin & Roger:
>
Hi Roger, Hi Chunfeng,
On Tue, Mar 20, 2018 at 1:04 PM, Chunfeng Yun wrote:
> Hi Martin & Roger:
>
> On Mon, 2018-03-19 at 17:12 +0100, Martin Blumenstingl wrote:
>> Hi Roger,
>>
>> On Mon, Mar 19, 2018 at 9:49 AM, Roger Quadros wrote:
>> > Hi,
>>
Hello Kishon,
On Tue, Mar 20, 2018 at 12:27 PM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Monday 19 March 2018 09:42 PM, Martin Blumenstingl wrote:
>> Hi Roger,
>>
>> On Mon, Mar 19, 2018 at 9:49 AM, Roger Quadros wrote:
>>> Hi,
>>>
>>>
Hi Roger,
On Mon, Mar 19, 2018 at 9:49 AM, Roger Quadros wrote:
> Hi,
>
> On 19/03/18 00:29, Martin Blumenstingl wrote:
>> Hi Roger,
>>
>> On Fri, Mar 16, 2018 at 3:32 PM, Roger Quadros wrote:
>>> +some TI folks
>>>
>>> Hi Martin,
>>&
Hi Roger,
On Fri, Mar 16, 2018 at 3:32 PM, Roger Quadros wrote:
> +some TI folks
>
> Hi Martin,
>
> On 18/02/18 20:44, Martin Blumenstingl wrote:
>> Many SoC platforms have separate devices for the USB PHY which are
>> registered through the generic PHY frame
Hello Felipe, Hello Greg,
On Tue, Feb 20, 2018 at 11:39 PM, Martin Blumenstingl
wrote:
> Hello Felipe,
>
> On Sun, Feb 11, 2018 at 10:15 PM, Martin Blumenstingl
> wrote:
>> Amlogic Meson AXG and GXL SoCs can use the dwc3-of-simple with little
>> modifications. These SoC
to be initialized (if one of the USB
PHYs it not initialized then none of USB port works at all).
Signed-off-by: Martin Blumenstingl
Tested-by: Yixun Lan
Cc: Neil Armstrong
Cc: Chunfeng Yun
---
drivers/usb/core/Makefile | 2 +-
drivers/usb/core/phy.c
-by: Martin Blumenstingl
---
drivers/usb/host/xhci-mtk.c | 98 +
1 file changed, 2 insertions(+), 96 deletions(-)
diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
index b0ab4d5e2751..7334da9e9779 100644
--- a/drivers/usb/host/xhci
A USB HCD may have several PHYs which need to be configured before the
the HCD starts working.
This adds the documentation for such a USB HCD as well as a reference to
the new "usb-hcd.txt" from all bindings that implement a USB HCD which
support one USB PHY per port.
Signed-off-
so the "multiple PHY" handling is
disabled for drivers that opted out of the management logic of a single
PHY.
Signed-off-by: Martin Blumenstingl
Acked-by: Alan Stern
Acked-by: Chunfeng Yun
Tested-by: Yixun Lan
---
drivers/usb/core/hcd.c | 31 +++
include/l
.
Signed-off-by: Martin Blumenstingl
Acked-by: Alan Stern
---
drivers/usb/host/ehci-platform.c | 55 +++-
1 file changed, 4 insertions(+), 51 deletions(-)
diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c
index b91eea8c73ae
With the new PHY wrapper in place we can now handle multiple PHYs.
Remove the code which handles only one generic PHY as this is now
covered (with support for multiple PHYs as well as suspend/resume
support) by the new PHY wrapper.
Signed-off-by: Martin Blumenstingl
---
drivers/usb/core/hcd.c
.
Signed-off-by: Martin Blumenstingl
Acked-by: Alan Stern
---
drivers/usb/host/ohci-platform.c | 56
1 file changed, 5 insertions(+), 51 deletions(-)
diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c
index 62ef36a9333f
agement provided by the USB HCD core
driver. This means that for these drivers the new "multiple PHY"
handling (which will be added in a follow-up patch) will be disabled as
well.
Signed-off-by: Martin Blumenstingl
Acked-by: Peter Chen
---
drivers/usb/chipidea/host.c | 6 ++
nux-amlogic/2017-October/005124.html
[9] http://lists.infradead.org/pipermail/linux-amlogic/2017-October/005192.html
[10] http://lists.infradead.org/pipermail/linux-amlogic/2018-January/006274.html
[11] https://marc.info/?l=linux-usb&m=151683941207898&w=2
[12]
http://lists.infradead.org/pipermail/
Hello Felipe,
On Sun, Feb 11, 2018 at 10:15 PM, Martin Blumenstingl
wrote:
> Amlogic Meson AXG and GXL SoCs can use the dwc3-of-simple with little
> modifications. These SoCs use:
> - a gate clock for the USB components (DWC3, USB PHYs)
> - a reset line which is shared across all US
agement provided by the USB HCD core
driver. This means that for these drivers the new "multiple PHY"
handling (which will be added in a follow-up patch) will be disabled as
well.
Signed-off-by: Martin Blumenstingl
---
drivers/usb/chipidea/host.c | 6 ++
drivers/usb/core/hcd.c
.
Signed-off-by: Martin Blumenstingl
Acked-by: Alan Stern
---
drivers/usb/host/ohci-platform.c | 56
1 file changed, 5 insertions(+), 51 deletions(-)
diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c
index 62ef36a9333f
-by: Martin Blumenstingl
---
drivers/usb/host/xhci-mtk.c | 98 +
1 file changed, 2 insertions(+), 96 deletions(-)
diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
index b0ab4d5e2751..7334da9e9779 100644
--- a/drivers/usb/host/xhci
A USB HCD may have several PHYs which need to be configured before the
the HCD starts working.
This adds the documentation for such a USB HCD as well as a reference to
the new "usb-hcd.txt" from all bindings that implement a USB HCD which
support one USB PHY per port.
Signed-off-
to be initialized (if one of the USB
PHYs it not initialized then none of USB port works at all).
Signed-off-by: Martin Blumenstingl
Tested-by: Yixun Lan
Cc: Neil Armstrong
Cc: Chunfeng Yun
---
drivers/usb/core/Makefile | 2 +-
drivers/usb/core/phy.c
With the new PHY wrapper in place we can now handle multiple PHYs.
Remove the code which handles only one generic PHY as this is now
covered (with support for multiple PHYs as well as suspend/resume
support) by the new PHY wrapper.
Signed-off-by: Martin Blumenstingl
---
drivers/usb/core/hcd.c
ml
[7] http://lists.infradead.org/pipermail/linux-amlogic/2017-October/005121.html
[8] http://lists.infradead.org/pipermail/linux-amlogic/2017-October/005124.html
[9] http://lists.infradead.org/pipermail/linux-amlogic/2017-October/005192.html
[10] http://lists.infradead.org/pipermail/linux-amlogic/2018-J
so the "multiple PHY" handling is
disabled for drivers that opted out of the management logic of a single
PHY.
Signed-off-by: Martin Blumenstingl
Acked-by: Alan Stern
Acked-by: Chunfeng Yun
Tested-by: Yixun Lan
---
drivers/usb/core/hcd.c | 31 +++
include/l
.
Signed-off-by: Martin Blumenstingl
Acked-by: Alan Stern
---
drivers/usb/host/ehci-platform.c | 55 +++-
1 file changed, 4 insertions(+), 51 deletions(-)
diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c
index b91eea8c73ae
Hi Alan,
On Mon, Feb 12, 2018 at 4:15 PM, Alan Stern wrote:
> On Sun, 11 Feb 2018, Martin Blumenstingl wrote:
>
>> The USB HCD core driver parses the device-tree node for "phys" and
>> "usb-phys" properties. It also manages the power state of these PHYs
>
For now this falls back to the old defaults, which are:
- reset lines are exclusive
- level resets are being used
Signed-off-by: Martin Blumenstingl
Tested-by: Yixun Lan
---
drivers/usb/dwc3/dwc3-of-simple.c | 23 +--
1 file changed, 17 insertions(+), 6 deletions(-)
diff --
level reset (reset_control_{assert,deassert}).
Signed-off-by: Martin Blumenstingl
Tested-by: Yixun Lan
---
drivers/usb/dwc3/dwc3-of-simple.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/usb/dwc3/dwc3-of-simple.c
b/drivers/usb/dwc3/dwc3-of-simple.c
index d2e4928c8d62
the Amlogic Meson AXG SoC
[0] http://lists.infradead.org/pipermail/linux-amlogic/2018-January/006274.html
[1] http://lists.infradead.org/pipermail/linux-amlogic/2018-January/006286.html
Martin Blumenstingl (3):
dt-bindings: usb: add support for dwc3 controller on Amlogic Meson GX
usb: dwc3: o
Amlogic Meson GX SoCs (GXL and AXG) come with a (host-only) dwc3 USB
controller. This requires a clock to be enabled and a reset line to be
pulsed to get the hardware into a known state.
Add the documentation for this IP block, similar to "qcom,dwc3.txt".
Signed-off-by: Martin Bl
-by: Martin Blumenstingl
---
drivers/usb/host/xhci-mtk.c | 98 +
1 file changed, 2 insertions(+), 96 deletions(-)
diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
index b0ab4d5e2751..7334da9e9779 100644
--- a/drivers/usb/host/xhci
.
Signed-off-by: Martin Blumenstingl
Acked-by: Alan Stern
---
drivers/usb/host/ehci-platform.c | 55 +++-
1 file changed, 4 insertions(+), 51 deletions(-)
diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c
index 40fbc4925378
.
Signed-off-by: Martin Blumenstingl
Acked-by: Alan Stern
---
drivers/usb/host/ohci-platform.c | 56
1 file changed, 5 insertions(+), 51 deletions(-)
diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c
index bd605e79ae7d
A USB HCD may have several PHYs which need to be configured before the
the HCD starts working.
This adds the documentation for such a USB HCD as well as a reference to
the new "usb-hcd.txt" from all bindings that implement a USB HCD which
support one USB PHY per port.
Signed-off-
With the new PHY wrapper in place we can now handle multiple PHYs.
Remove the code which handles only one generic PHY as this is now
covered (with support for multiple PHYs as well as suspend/resume
support) by the new PHY wrapper.
Signed-off-by: Martin Blumenstingl
---
drivers/usb/core/hcd.c
new flag if they
want to opt out of the PHY management provided by the USB HCD core
driver. This means that for these drivers the new "multiple PHY"
handling (which will be added in a follow-up patch) will be disabled as
well.
Signed-off-by: Martin Blumenstingl
---
drivers/usb/chipid
so the "multiple PHY" handling is
disabled for drivers that opted out of the management logic of a single
PHY.
Signed-off-by: Martin Blumenstingl
Acked-by: Alan Stern
Acked-by: Chunfeng Yun
Tested-by: Yixun Lan
---
drivers/usb/core/hcd.c | 31 +++
include/l
amlogic/2017-October/005049.html
[7] http://lists.infradead.org/pipermail/linux-amlogic/2017-October/005121.html
[8] http://lists.infradead.org/pipermail/linux-amlogic/2017-October/005124.html
[9] http://lists.infradead.org/pipermail/linux-amlogic/2017-October/005192.html
[10] http://lists.infradead.o
to be initialized (if one of the USB
PHYs it not initialized then none of USB port works at all).
Signed-off-by: Martin Blumenstingl
Tested-by: Yixun Lan
Cc: Neil Armstrong
Cc: Chunfeng Yun
---
drivers/usb/core/Makefile | 2 +-
drivers/usb/core/phy.c
1 - 100 of 220 matches
Mail list logo
