[PATCH] rtl8150: Check if RSR is already defined

2014-08-06 Thread Nick Krause
. undefining should be enough. Signed-off-by: Nick Krause xerofo...@gmail.com --- drivers/net/usb/rtl8150.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c index 6e87e57..7d9a6ba 100644 --- a/drivers/net/usb/rtl8150.c +++ b/drivers/net/usb

Re: [PATCH] xhci: Merge and Update debugging for patches from 3.6 kernel tree

2014-08-05 Thread Nick Krause
On Tue, Aug 5, 2014 at 3:27 AM, Mateusz Guzik mgu...@redhat.com wrote: On Tue, Aug 05, 2014 at 01:55:34AM -0400, Nick Krause wrote: On Tue, Aug 5, 2014 at 1:45 AM, Greg KH gre...@linuxfoundation.org wrote: On Tue, Aug 05, 2014 at 12:56:57AM -0400, Nicholas Krause wrote: I am adding the fixes

Re: Kernel Debugging Support

2014-08-04 Thread Nick Krause
On Mon, Aug 4, 2014 at 5:55 PM, Paul Zimmerman paul.zimmer...@synopsys.com wrote: From: valdis.kletni...@vt.edu [mailto:valdis.kletni...@vt.edu] Sent: Monday, August 04, 2014 1:28 PM On Mon, 04 Aug 2014 19:40:15 -, Paul Zimmerman said: Ah, you didn't read far enough down the page :)

Re: Kernel Debugging Support

2014-08-04 Thread Nick Krause
On Mon, Aug 4, 2014 at 7:03 PM, Paul Zimmerman paul.zimmer...@synopsys.com wrote: From: Nick Krause [mailto:xerofo...@gmail.com] Sent: Monday, August 04, 2014 3:50 PM On Mon, Aug 4, 2014 at 5:55 PM, Paul Zimmerman paul.zimmer...@synopsys.com wrote: From: valdis.kletni...@vt.edu

Re: Kernel Debugging Support

2014-08-04 Thread Nick Krause
On Mon, Aug 4, 2014 at 8:12 PM, Sarah Sharp sarah.a.sh...@linux.intel.com wrote: On Mon, Aug 04, 2014 at 07:11:07PM -0400, Nick Krause wrote: On Mon, Aug 4, 2014 at 7:03 PM, Paul Zimmerman paul.zimmer...@synopsys.com wrote: From: Nick Krause [mailto:xerofo...@gmail.com] [snip] Paul

Re: Kernel Debugging Support

2014-08-04 Thread Nick Krause
On Mon, Aug 4, 2014 at 9:33 PM, Nick Krause xerofo...@gmail.com wrote: On Mon, Aug 4, 2014 at 8:12 PM, Sarah Sharp sarah.a.sh...@linux.intel.com wrote: On Mon, Aug 04, 2014 at 07:11:07PM -0400, Nick Krause wrote: On Mon, Aug 4, 2014 at 7:03 PM, Paul Zimmerman paul.zimmer...@synopsys.com wrote

Re: Kernel Debugging Support

2014-08-04 Thread Nick Krause
On Mon, Aug 4, 2014 at 11:18 PM, Nick Krause xerofo...@gmail.com wrote: On Mon, Aug 4, 2014 at 9:33 PM, Nick Krause xerofo...@gmail.com wrote: On Mon, Aug 4, 2014 at 8:12 PM, Sarah Sharp sarah.a.sh...@linux.intel.com wrote: On Mon, Aug 04, 2014 at 07:11:07PM -0400, Nick Krause wrote: On Mon

Re: [PATCH] xhci: Merge and Update debugging for patches from 3.6 kernel tree

2014-08-04 Thread Nick Krause
On Tue, Aug 5, 2014 at 1:45 AM, Greg KH gre...@linuxfoundation.org wrote: On Tue, Aug 05, 2014 at 12:56:57AM -0400, Nicholas Krause wrote: I am adding the fixes to the tree send for adding debugging to the kernel tree from a patch sent in 2013 on the the 3.6 release. The patch adds debugging

Re: Work on Usb subsystem

2014-08-03 Thread Nick Krause
On Sun, Aug 3, 2014 at 4:50 AM, Jassi Brar jassisinghb...@gmail.com wrote: On Sun, Aug 3, 2014 at 11:07 AM, Nick Krause xerofo...@gmail.com wrote: Hey Guys, I assume after my other fuck ups , you assume I can't do kernel work and I understand. But if you want to give me a second case

Re: [PATCH] scatterlist.h: Change CONFIG_DEBUG_SG for ifdef statement in sg_set_bf

2014-08-03 Thread Nick Krause
On Sun, Aug 3, 2014 at 8:28 AM, Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: Hello. On 03-08-2014 6:56, Nicholas Krause wrote: This changes the ifdef statement in sg_set_bg to !CONFIG_DEBUG_SG in order to avoid a bug with xhci dequence/enquence functions.

Re: 3.15.6 USB issue with pwc cam

2014-08-03 Thread Nick Krause
On Sat, Aug 2, 2014 at 9:10 AM, Udo van den Heuvel udo...@xs4all.nl wrote: Hello, I moved a PWC webcam to a USB3 port, and this happened: [53008.911811] usb 5-2: new full-speed USB device number 2 using xhci_hcd [53009.213504] usb 5-2: New USB device found, idVendor=0471, idProduct=0311

Re: 3.15.6 USB issue with pwc cam

2014-08-03 Thread Nick Krause
On Sun, Aug 3, 2014 at 3:59 PM, Nick Krause xerofo...@gmail.com wrote: On Sat, Aug 2, 2014 at 9:10 AM, Udo van den Heuvel udo...@xs4all.nl wrote: Hello, I moved a PWC webcam to a USB3 port, and this happened: [53008.911811] usb 5-2: new full-speed USB device number 2 using xhci_hcd

Re: Kernel Debugging Support

2014-08-02 Thread Nick Krause
On Sat, Aug 2, 2014 at 9:48 AM, Alan Stern st...@rowland.harvard.edu wrote: On Sat, 2 Aug 2014, Nick Krause wrote: Hey Sharp, After reading around seems people want support for usb debugging in kgdb or other usb based solutions. If you and the other developers are able to help me out a bit

Re: [PATCH] scatterlist.h: Change CONFIG_DEBUG_SG for ifdef statement in sg_set_bf

2014-08-02 Thread Nick Krause
On Sat, Aug 2, 2014 at 11:59 PM, Mateusz Guzik mgu...@redhat.com wrote: On Sat, Aug 02, 2014 at 10:56:13PM -0400, Nicholas Krause wrote: This changes the ifdef statement in sg_set_bg to !CONFIG_DEBUG_SG in order to avoid a bug with xhci dequence/enquence functions. Signed-off-by: Nicholas

Re: [PATCH] scatterlist.h: Change CONFIG_DEBUG_SG for ifdef statement in sg_set_bf

2014-08-02 Thread Nick Krause
On Sun, Aug 3, 2014 at 1:02 AM, Mateusz Guzik mgu...@redhat.com wrote: On Sun, Aug 03, 2014 at 12:31:30AM -0400, Nick Krause wrote: On Sat, Aug 2, 2014 at 11:59 PM, Mateusz Guzik mgu...@redhat.com wrote: On Sat, Aug 02, 2014 at 10:56:13PM -0400, Nicholas Krause wrote: This changes the ifdef

Re: [PATCH] scatterlist.h: Change CONFIG_DEBUG_SG for ifdef statement in sg_set_bf

2014-08-02 Thread Nick Krause
On Sun, Aug 3, 2014 at 1:18 AM, Nick Krause xerofo...@gmail.com wrote: On Sun, Aug 3, 2014 at 1:02 AM, Mateusz Guzik mgu...@redhat.com wrote: On Sun, Aug 03, 2014 at 12:31:30AM -0400, Nick Krause wrote: On Sat, Aug 2, 2014 at 11:59 PM, Mateusz Guzik mgu...@redhat.com wrote: On Sat, Aug 02

Work on Usb subsystem

2014-08-02 Thread Nick Krause
Hey Guys, I assume after my other fuck ups , you assume I can't do kernel work and I understand. But if you want to give me a second case and allow me to help out with the usb subsystem that would be great too. Regards , Nick -- To unsubscribe from this list: send the line unsubscribe linux-usb in

Kernel Debugging Support

2014-08-01 Thread Nick Krause
Hey Sharp, After reading around seems people want support for usb debugging in kgdb or other usb based solutions. If you and the other developers are able to help me out a bit as I am new I can definitively write this area of kgdb support. Regards Nick P.S. If you want Sharp I can change the

Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

2014-07-24 Thread Nick Krause
On Thu, Jul 24, 2014 at 9:07 AM, Vlastimil Babka vba...@suse.cz wrote: On 07/23/2014 05:24 AM, Nick Krause wrote: On Tue, Jul 22, 2014 at 8:44 PM, Sasha Levin sas...@kernel.org wrote: On 07/18/2014 10:52 PM, Nick Krause wrote: Please explain exactly why it's not needed, why it can never

Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

2014-07-22 Thread Nick Krause
On Tue, Jul 22, 2014 at 8:44 PM, Sasha Levin sas...@kernel.org wrote: On 07/18/2014 10:52 PM, Nick Krause wrote: On Fri, Jul 18, 2014 at 10:45 PM, Nick Krause xerofo...@gmail.com wrote: Sorry didn't run spell check. I will resend this patch with the correct information as needed. Thanks

Re: hcd.c Fix me statements

2014-07-18 Thread Nick Krause
On Fri, Jul 18, 2014 at 10:45 AM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 18 Jul 2014, Nick Krause wrote: I am assuming this is a stupid question but since I am new I will ask it anyway. Can the usb_bus structure be Null? If can I will send it a patch removing the fix mes

Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

2014-07-18 Thread Nick Krause
On Fri, Jul 18, 2014 at 3:09 PM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 18 Jul 2014, Nicholas Krause wrote: I am removing two fix mes in this file as after dicussing then it seems there is no reason to check against Null for usb_device as it can never be NULL and this is check

Re: Build Errors when building usb directory

2014-07-18 Thread Nick Krause
On Fri, Jul 18, 2014 at 2:10 PM, Randy Dunlap rdun...@infradead.org wrote: On 07/18/2014 10:45 AM, Nick Krause wrote: Hey Greg and others, When I built the usb directory today to check a patch I am also sending to. I seem to hitting a few compiler errors and a lot of warnings. I am going

Re: Build Errors when building usb directory

2014-07-18 Thread Nick Krause
On Fri, Jul 18, 2014 at 7:29 PM, Randy Dunlap rdun...@infradead.org wrote: On 07/18/2014 12:59 PM, Nick Krause wrote: On Fri, Jul 18, 2014 at 2:10 PM, Randy Dunlap rdun...@infradead.org wrote: On 07/18/2014 10:45 AM, Nick Krause wrote: Hey Greg and others, When I built the usb directory today

Re: [PATCH] usb-core: Remove Fix mes in file hcd.c

2014-07-18 Thread Nick Krause
Sorry didn't run spell check. I will resend this patch with the correct information as needed. Thanks for the advice, Sasha. Cheers Nick On Fri, Jul 18, 2014 at 10:36 PM, Sasha Levin sas...@kernel.org wrote: On 07/18/2014 01:34 PM, Nicholas Krause wrote: I am removing two fix mes in this file

hcd.c Fix me statements

2014-07-17 Thread Nick Krause
I am assuming this is a stupid question but since I am new I will ask it anyway. Can the usb_bus structure be Null? If can I will send it a patch removing the fix mes on lines 854 and 878 of hcd.c . Cheers Nick -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of

Re: [PATCH] Removes FIXME message in usb.c

2014-07-09 Thread Nick Krause
Greg KH wrote on July 9th at 1:19 P.M. Ok, this has been fun to watch on lkml for a while now, but really, please, just stop doing this. Randomly searching the kernel source for FIXME lines and just commenting them out, isn't ok. Almost always, those lines are there because the original

Re: [PATCH] mach-omap1: Fix call to omap_cfg_reg

2014-07-07 Thread Nick Krause
Hey Tony, This seems to be a false positive then.Please reply if it is so I can remove the Fix me message. Cheers Nick On Mon, Jul 7, 2014 at 4:14 AM, Tony Lindgren t...@atomide.com wrote: * Nicholas Krause xerofo...@gmail.com [140704 10:03]: This patch fixes the call to

Usb Bugs

2012-10-15 Thread Nick Krause
Hey Linux Usb Forum , Do you have any bugs or work that a Linux kernel newbie can do?  Nick  -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at