On 29/08/2018 at 22:01, Rob Herring wrote:
The name is always non-NULL and then is not used anywhere in this function,
so remove it.
Indeed.
Cc: Nicolas Ferre
Acked-by: Nicolas Ferre
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: Alexandre Belloni
Cc: linux-arm-ker
usb: gadget: udc: atmel: Remove obsolete include
usb: gadget: udc: atmel: Fix indenting
To the whole series:
Acked-by: Nicolas Ferre <nicolas.fe...@microchip.com>
Thank you Romain.
Best regards,
Nicolas
drivers/usb/gadget/udc/atmel_usba_udc.c | 22 ++
drive
On 23/01/2018 at 00:05, Ladislav Michl wrote:
> As devm_ioremap_resource() checks for valid resource,
> make use of it instead of testing ourselves. As a bonus
> memory region is requested.
>
> Signed-off-by: Ladislav Michl <la...@linux-mips.org>
Acked-by: Nico
Felipe Balbi <ba...@kernel.org>
> Cc: Nicolas Ferre <nicolas.fe...@microchip.com>
[..]
> drivers/usb/gadget/udc/at91_udc.c | 5 -
> drivers/usb/gadget/udc/at91_udc.h | 5 -
> drivers/usb/gadget/udc/atmel_usba_udc.c | 4
> drivers/
On 15/09/2017 at 16:04, Romain Izard wrote:
> Save and restore registers for the PWM on suspend and resume, which
> makes hibernation and backup modes possible.
>
> Signed-off-by: Romain Izard <romain.izard@gmail.com>
Seems good to me:
Acked-by: Nicolas Ferre <nicola
lse);
> + ehci_resume(hcd, false);
> + return 0;
Ok, I agree with that as the underlying function takes care about the
controller, in any case (even for !B+S-R case). So we don't have any
added value to propagate this information.
Acked-by: Nicolas Ferre <nicolas.fe...@microchip.com
d <romain.izard@gmail.com>
And here is my:
Acked-by: Nicolas Ferre <nicolas.fe...@microchip.com>
> ---
> drivers/clk/at91/pmc.c | 24
> 1 file changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at9
On 14/09/2017 at 18:15, Romain Izard wrote:
> 2017-09-13 14:15 GMT+02:00 Nicolas Ferre <nicolas.fe...@microchip.com>:
>> On 08/09/2017 at 17:35, Romain Izard wrote:
>>> Wait for the syncronization of all clocks when resuming, not only the
>>> UPLL clock. Do
er saves and restores the Programmable Clock registers to support
> the backup mode for these clocks.
>
> Signed-off-by: Romain Izard <romain.izard@gmail.com>
Romain,
Some nitpicking and one comment. But on the overall patch, here is my:
Acked-by: Nicolas Ferre <nicolas.fe...@microchip.
those changes, atmel_tx_empty can return "empty" on suspend, the
> warning in uart_suspend_port disappears, and suspending is 20ms shorter
> for each enabled Atmel serial port.
>
> Signed-off-by: Romain Izard <romain.izard@gmail.com>
Tested-by: Nicolas Ferre <nico
d <romain.izard@gmail.com>
Tested-by: Nicolas Ferre <nicolas.fe...@microchip.com>
On sama5d2 Xplained board (i2c0 from flexcom 4).
and obviously:
Acked-by: Nicolas Ferre <nicolas.fe...@microchip.com>
Thanks Romain!
Regards,
> ---
On 14/09/2017 at 09:41, romain izard wrote:
> 2017-09-13 19:03 GMT+02:00 Alexandre Belloni
> <alexandre.bell...@free-electrons.com>:
>> On 13/09/2017 at 14:29:35 +0200, Nicolas Ferre wrote:
>>> On 08/09/2017 at 17:35, Romain Izard wrote:
>>>> From: Romai
pmc_cache.pcr[registered_ids[i]] |
>AT91_PMC_PCR_CMD);
> }
> + for (i = 0; i < 3; i++)
> + regmap_write(pmcreg, AT91_PMC_PCKR(i), pmc_cache.pckr[i]);
>
> if (pmc_cache.uckr & AT91_PMC_UPLLEN)
>
mask |= AT91_PMC_LOCKU;
> +
> + while (!pmc_ready(mask))
> + cpu_relax();
Okay, but I would prefer to keep the timeout property in it. So we may
need to re-implement a timeout way-out here.
Regards,
> }
>
> static struct syscore_ops pmc_syscore_ops = {
&
pcsr0);
> regmap_write(pmcreg, AT91_CKGR_UCKR, pmc_cache.uckr);
> regmap_write(pmcreg, AT91_CKGR_MOR, pmc_cache.mor);
>
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ent_rate);
> +
> + err = clk_prepare_enable(st->per_clk);
> + return err;
> +}
> +#endif
> +
> +static SIMPLE_DEV_PM_OPS(at91_adc_pm_ops, at91_adc_suspend, at91_adc_resume);
> +
> static struct platform_driver at91_adc_driver = {
> .probe = at91_adc_prob
trigger the connection with host but only on some
bouncing signal conditions and thus lose connecting events.
Signed-off-by: Nicolas Ferre <nicolas.fe...@microchip.com>
Cc: stable <sta...@vger.kernel.org> # v4.4+
---
drivers/usb/gadget/udc/atmel_usba_udc.c | 4 +++-
1 file changed, 3 inse
From: Nicolas Ferre <nicolas.fe...@atmel.com>
The driver triggers actions on both edges of the vbus signal.
The former PIO controller was triggering IRQs on both falling and rising edges
by default. Newer PIO controller don't, so it's better to set it explicitly to
IRQF_TRIGGER_F
values against device tree" patch
As for previous revision, the whole series:
Acked-by: Nicolas Ferre <nicolas.fe...@microchip.com>
Regards,
> Cristian Birsan (4):
> usb: gadget: udc: atmel: Check fifo configuration values against
> device tree
> usb: gadget:
>
> Cc: Wenyou Yang <wenyou.y...@atmel.com>
> Cc: Alexandre Belloni <alexandre.bell...@free-electrons.com>
> Cc: Nicolas Ferre <nicolas.fe...@atmel.com>
Acked-by: Nicolas Ferre <nicolas.fe...@microchip.com>
Thanks
> Cc: Alan Stern <st...@rowland.harvard.edu>
&
c | 47
> ++---
> 2 files changed, 35 insertions(+), 17 deletions(-)
I'm okay with the whole series:
Acked-by: Nicolas Ferre <nicolas.fe...@microchip.com>
Thanks, regards,
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe l
way as the other code.
>>
>> Fixes: 741d2558bf0a ("usb: gadget: udc: atmel: Update endpoint allocation
>> scheme")
>> Signed-off-by: Arnd Bergmann <a...@arndb.de>
> Acked-by: Alexandre Belloni <alexandre.bell...@free-electrons.com>
Acked-by: Nicolas Fe
et/cadence/macb.h:862:2: error: unknown type name
> 'phy_interface_t'
> phy_interface_t phy_interface;
> ^~~
>
> Add linux/phy.h to macb.h
>
> Signed-off-by: Russell King <rmk+ker...@armlinux.org.uk>
Acked-by: Nicolas Ferre <nicolas.fe...@atmel.co
Le 27/01/2017 à 14:47, Cristian Birsan a écrit :
> I will send a fixup patch with updates based on the comments received from
> Nicolas.
>
> On 01/26/2017 05:02 PM, Nicolas Ferre wrote:
>> Le 23/01/2017 à 15:45, cristian.bir...@microchip.com a écrit :
>>> From: Cr
BA_EPT_SIZE_8);
> + else
> + /* LSB is bit 1, not 0 */
> + ep->ept_cfg =
> + USBA_BF(EPT_SIZE, fls(ep->fifo_size - 1) - 3);
> +
> + ep->ept_cfg |= USBA_BF(BK_NUMBER, ep->nr_banks);
> + }
> +
> if (i)
> list_add_tail(>ep.ep_list, >gadget.ep_list);
>
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.h
> b/drivers/usb/gadget/udc/atmel_usba_udc.h
> index b03b2eb..9551b70 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.h
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.h
> @@ -275,6 +275,12 @@ struct usba_dma_desc {
> u32 ctrl;
> };
>
> +struct usba_fifo_cfg {
> + u8 hw_ep_num;
> + u16 fifo_size;
> + u8 nr_banks;
> +};
> +
> struct usba_ep {
> int state;
> void __iomem*ep_regs;
> @@ -293,7 +299,7 @@ struct usba_ep {
> unsigned intcan_isoc:1;
> unsigned intis_isoc:1;
> unsigned intis_in:1;
> -
> + unsigned long ept_cfg;
> #ifdef CONFIG_USB_GADGET_DEBUG_FS
> u32 last_dma_status;
> struct dentry *debugfs_dir;
> @@ -338,6 +344,8 @@ struct usba_udc {
> int vbus_pin;
> int vbus_pin_inverted;
> int num_ep;
> + int configured_ep;
> + struct usba_fifo_cfg *fifo_cfg;
> struct clk *pclk;
> struct clk *hclk;
> struct usba_ep *usba_ep;
>
Regards,
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Le 01/12/2016 à 11:26, Alexandre Belloni a écrit :
> Use devm_kasprintf instead of simple kasprintf to free the allocated memory
> when needed.
>
> Suggested-by: Peter Rosin <p...@axentia.se>
> Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com&g
Le 31/10/2016 à 11:48, Felipe Balbi a écrit :
> Now that usb_endpoint_maxp() only returns the lowest
> 11 bits from wMaxPacketSize, we can remove the &
> operation from this driver.
>
> Cc: Nicolas Ferre <nicolas.fe...@atmel.com>
Acked-by: Nicolas Ferre <nicolas.fe
Le 31/10/2016 à 11:48, Felipe Balbi a écrit :
> We have introduced a helper to calculate multiplier
> value from wMaxPacketSize. Start using it.
>
> Cc: Nicolas Ferre <nicolas.fe...@atmel.com>
Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com>
> Cc: <linux-usb
Le 26/09/2016 à 09:18, Felipe Balbi a écrit :
>
> Hi,
>
> Greg Kroah-Hartman <gre...@linuxfoundation.org> writes:
>> On Fri, Sep 23, 2016 at 04:20:45PM +0200, Nicolas Ferre wrote:
>>> Le 16/09/2016 à 10:36, Nicolas Ferre a écrit :
>>>> Le
Le 18/10/2016 à 13:05, Peter Rosin a écrit :
> Signed-off-by: Peter Rosin <p...@axentia.se>
Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com>
We may take it in a future at91-x.y-dt branch which will go through arm-soc.
Thanks
> ---
> Documentation/devicetree/bindings/u
Le 28/09/2016 à 15:05, Felipe Balbi a écrit :
> We have introduced a helper to calculate multiplier
> value from wMaxPacketSize. Start using it.
>
> Cc: Nicolas Ferre <nicolas.fe...@atmel.com>
Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com>
> Cc: <linux-usb
Le 28/09/2016 à 15:05, Felipe Balbi a écrit :
> Now that usb_endpoint_maxp() only returns the lowest
> 11 bits from wMaxPacketSize, we can remove the &
> operation from this driver.
>
> Cc: Nicolas Ferre <nicolas.fe...@atmel.com>
Acked-by: Nicolas Ferre <nicolas.fe
| 9 -
> drivers/usb/gadget/function/u_serial.c | 4 ++--
> drivers/usb/gadget/udc/at91_udc.h | 2 +-
> drivers/usb/gadget/udc/atmel_usba_udc.c | 4 ++--
For AT91 and Atmel parts:
Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com>
Thanks
> drivers/usb/gadget/
Le 16/09/2016 à 10:36, Nicolas Ferre a écrit :
> Le 15/09/2016 à 17:07, Alexandre Belloni a écrit :
>> Since commit c32b5bcfa3c4 ("ARM: dts: at91: Fix USB endpoint nodes"),
>> atmel_usba_udc fails with:
>>
>> [ cut here ]
>>
008078)
> ---[ end trace e7cf9dcebf4815a6 ]---
>
> Fixes: c32b5bcfa3c4 ("ARM: dts: at91: Fix USB endpoint nodes")
> Reported-by: Richard Genoud <richard.gen...@gmail.com>
> Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com>
Acked-
be done before the USB clock is disabled,
> resume after the USB clock is enabled.
>
> Signed-off-by: Wenyou Yang <wenyou.y...@atmel.com>
Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com>
Alan, can you take it as it doesn't have dependency on the at91 material
anymore.
Th
R, we don't use the bits, and we come
back to the situation that we've always experienced ; with the same
compatibility sting for OHCI as the IP never actually changed...
In conclusion: try Alexandre's solution and we'll certainly find that
it's actually simpler.
Bonus point: it voids the discussion on the OHCI compatible string
descriptions!
Bye,
>>> Alexandre Belloni, Free Electrons
>>> Embedded Linux, Kernel and Android engineering http://free-electrons.com
>>
>>
>> Best Regards,
>> Wenyou Yang
>
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Le 08/06/2016 12:04, Nicolas Ferre a écrit :
> Le 08/06/2016 06:15, Wenyou Yang a écrit :
>> In order to the save power consumption, as a workaround, suspend
>> forcibly the USB PORTA/B/C via set the SUSPEND_A/B/C bits of OHCI
>> Interrupt Configuration Register in the SFRs w
reg = <0x0040 0x10>;
> interrupts = <41 IRQ_TYPE_LEVEL_HIGH 2>;
> clocks = <_clk>, <_clk>, <>;
>
Bye,
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + */
> +#ifndef __AT91_SFR_H__
> +#define __AT91_SFR_H__
> +
> +#define SFR_DDRCFG 0x04/* DDR Configuration Register */
> +/* 0x08 ~ 0x0c:
t;> That may be why you need this now, but that is irrelevant to having a chip
>> specific
>> compatible string.
>
> Maybe a property is better.
It seems that it's not an issue to the binding that Rob is talking about
but the description that you used: "for SAMA5D2 which can force
suspend". Don't modify it to use a property for this: a compatible sting
makes a lot of sense.
So just listing the new compatible string is enough. If the "force
suspend" is not needed anymore in next product, we will come back to the
"atmel,at91rm9200-ohci" compatible string or add a new one if needed...
bye,
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Le 29/03/2016 11:28, Felipe Balbi a écrit :
> coccicheck found this pattern which could be
> converted to PTR_ERR_OR_ZERO(). No functional
> changes.
>
> Signed-off-by: Felipe Balbi <felipe.ba...@linux.intel.com>
Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com>
Tha
uses a __maybe_unused
> annotation to let the compiler know it can silently drop
> the function definition.
>
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com>
> ---
> drivers/usb/host/ehci-atmel.c | 6 ++
> 1 f
uses a __maybe_unused
> annotation to let the compiler know it can silently drop
> the function definition.
>
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com>
Thanks Arnd, bye.
> ---
> drivers/usb/host/ohci-at91.c |
: ohci-at91: merge loops in
> ohci_hcd_at91_drv_probe)
Yes, with:
Cc: sta...@vger.kernel.org # 4.3+
> Reported-by: Peter Rosin <p...@axentia.se>
> Tested-by: Peter Rosin <p...@axentia.se>
> Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com>
Acked-b
>>>>
>>>> drivers/usb/gadget/udc/atmel_usba_udc.c: In function ‘usba_start’:
>>>> drivers/usb/gadget/udc/atmel_usba_udc.c:1783:25: error: ‘USBA_ENABLE_MASK’
>>>> undeclared (first use in this function)
>>>> usba_writel(udc,
es (and DT modifications like the 06/16 patch actually).
So, I think that Alexandre would agree with me that we should take the
whole series with us through the arm-soc tree. An alternative would be
to delay the inclusion of the USB part a little bit...
Thanks for the heads-up Felipe, Bye,
--
N
Le 30/09/2015 18:53, Sudip Mukherjee a écrit :
> On Wed, Sep 30, 2015 at 06:34:28PM +0200, Nicolas Ferre wrote:
>> Le 30/09/2015 18:24, Sudip Mukherjee a écrit :
>>> On Wed, Sep 30, 2015 at 11:04:54AM -0500, Felipe Balbi wrote:
>>>> On Wed, Sep 23, 2015 at 09:22:48P
Le 10/08/2015 16:29, Alexandre Belloni a écrit :
> Definitions from linux/platform_data/atmel.h are not used, remove the
> include.
>
> Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com>
> --
Le 10/08/2015 16:46, Alexandre Belloni a écrit :
> struct at91_udc_data is now only used inside the driver, move it to its
> include.
>
> Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com>
Thank
model when driver is
bound to a device tree as well.
Signed-off-by: Sylvain Rochet <sylvain.roc...@finsecur.com>
Fixes: 47bef3865115 ("usb: gadget: atmel_usba_udc: add ep capabilities support")
Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com>
---
Felipe,
As you've just
Le 07/07/2015 16:02, Robert Baldyga a écrit :
Add missing return value check. In case of error print debug message
and return error code.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
Yes, it's indeed missing:
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
Thanks, bye
Le 01/07/2015 22:35, Kevin Hilman a écrit :
Nicolas Ferre nicolas.fe...@atmel.com writes:
From: Boris Brezillon boris.brezil...@free-electrons.com
at91sam9g45, at91sam9x5 and sama5 SoCs should not use
atmel,at91sam9rl-udc for their USB device compatible property since
this compatible
To please checkpatch and the tiresome reader, add the atmel, prefix to the
USB udc compatible string.
Signed-off-by: Nicolas Ferre nicolas.fe...@atmel.com
Cc: sta...@vger.kernel.org #4.0+
---
Documentation/devicetree/bindings/usb/atmel-usb.txt | 6 +++---
1 file changed, 3 insertions(+), 3
-electrons.com
Acked-by: Alexandre Belloni alexandre.bell...@free-electrons.com
Tested-by: Bo Shen voice.s...@atmel.com
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
Cc: sta...@vger.kernel.org #4.0+
---
Hi,
This patch was forgotten while dealing with the series usb: atmel_usba_udc:
Rework errata
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
Thanks Felipe!
Bye,
---
drivers/usb/gadget/udc/atmel_usba_udc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c
b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 4c01953a0869
: remove useless usb clock
^ can be queued in at91-4.2-dt. They will go through the arm-soc route.
And BTW:
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
Thanks Boris, bye.
.../devicetree/bindings/usb/atmel-usb.txt | 25 ++
arch/arm/boot/dts/at91rm9200.dtsi
in a follow-up patch.
I'm fine with this too. Is this targetted at v4.2 ?
Yes, although we may move it to the soc specific include directories
to avoid adding more to linux/
BTW, Ben, what _oc_ stands for in the new macro name?
Bye,
--
Nicolas Ferre
--
To unsubscribe from this list: send
boris.brezil...@free-electrons.com
Acked-by: Alan Stern st...@rowland.harvard.edu
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
Hi Alan,
As I don't have any other drivers patch for 4.1, would you mind taking
this patch with your tree?
I'll take care of the remaining ones dealing with Device Tree
parent clock (the usb clock),
thus preventing any rate change because of 1/
Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com
Acked-by: Alan Stern st...@rowland.harvard.edu
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
and:
Fixes: 3440ef169100 (ARM: at91/dt: fix USB high
drivers/usb/gadget/udc/atmel_usba_udc.h | 4 +
2 files changed, 159 insertions(+), 53 deletions(-)
--
Nicolas Ferre
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Shen (2):
ARM: at91: dt: at91sam9n12: add udp device node
ARM: at91: dt: at91sam9n12ek: enable udp
Any comments for this patch series? (aka ping?)
Hi,
For the 2 patches:
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
And I've just taken these 2 patches on top of the at91-4.1-dt branch
-by: Nicolas Ferre nicolas.fe...@atmel.com
---
drivers/usb/gadget/udc/atmel_usba_udc.c | 57
+
1 file changed, 57 insertions(+)
diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c
b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 999e2f2..d019b6c 100644
= {
.remove = __exit_p(usba_udc_remove),
.driver = {
.name = atmel_usba_udc,
+ .pm = usba_udc_pm_ops,
.of_match_table = of_match_ptr(atmel_udc_dt_ids),
},
};
--
Nicolas Ferre
--
To unsubscribe
usba_udc_errata *errata;
+const struct usba_udc_caps *caps;
int irq;
int vbus_pin;
int vbus_pin_inverted;
--
Nicolas Ferre
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info
.
Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com
Suggested-by: Boris Brezillon boris.brezil...@free-electrons.com
Acked-by: Boris Brezillon boris.brezil...@free-electrons.com
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
---
drivers/usb/gadget/udc/atmel_usba_udc.c | 9 ++---
1
___
linux-arm-kernel mailing list
linux-arm-ker...@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Nicolas Ferre
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More
Le 20/01/2015 12:02, Sylvain Rochet a écrit :
Hello,
On Mon, Jan 19, 2015 at 12:55:47PM -0600, Felipe Balbi wrote:
On Mon, Jan 19, 2015 at 03:09:44PM +0100, Nicolas Ferre wrote:
Le 18/01/2015 18:24, Sylvain Rochet a écrit :
If vbus gpio is high at init, we should set vbus_prev to true
/host/ohci-at91.c | 126
++
2 files changed, 154 insertions(+), 74 deletions(-)
As already mentioned for the v5, I'm okay with the whole series:
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
So Sylvain, as said by Alan, I think you can now collect all
...@finsecur.com
Indeed:
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
We can also add the following tags:
Fixes: 914a3f3b3754 (USB: add atmel_usba_udc driver)
Cc: sta...@vger.kernel.org # 2.6.x-ish
Bye,
---
drivers/usb/gadget/udc/atmel_usba_udc.c | 2 ++
1 file changed, 2 insertions(+)
diff
devstatus;
Otherwise, it looks okay, so once little corrections done, you can add my:
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
Thanks, bye,
--
Nicolas Ferre
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo
kernel support
usb: gadget: at91_udc: Update DT binding documentation
usb: gadget: at91_udc: Allocate udc instance
I'm fine with all this:
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
Great, I plan to add them all to the at91-3.20-drivers branch now.
Thanks, best regards
value
Signed-off-by: Songjun Wu songjun...@atmel.com
[nicolas.fe...@atmel.com: reworked the commit message]
Signed-off-by: Nicolas Ferre nicolas.fe...@atmel.com
Fixes: 914a3f3b3754 (USB: add atmel_usba_udc driver)
Cc: sta...@vger.kernel.org # 2.6.x-ish
---
Felipe,
I tried to collect all
Le 19/12/2014 15:02, Ronald Wahl a écrit :
On 19.12.2014 14:51, Luis Henriques wrote:
Hi Felipe,
On Thu, Nov 20, 2014 at 01:50:49PM -0600, Felipe Balbi wrote:
On Wed, Nov 19, 2014 at 04:37:27PM +0100, Nicolas Ferre wrote:
From: Ronald Wahl ronald.w...@raritan.com
Commit
...@atmel.com
Seems okay, even if I am not used to these aspects:
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
I would also add a stable tag to these patches, something like this:
Fixes: 914a3f3b3754 (USB: add atmel_usba_udc driver)
Cc: sta...@vger.kernel.org # always been there...
Felipe,
Can you
, this bit RXRDY has been cleared.
So, after the receive_data() function return, this bit should
not be cleared again, or else it may cause the accessing FIFO
corrupt, which will make the data loss.
Signed-off-by: Bo Shen voice.s...@atmel.com
Seems okay:
Acked-by: Nicolas Ferre nicolas.fe
there for the same reason. Move clock
preparation and setting clock rate into process context (at91udc_probe).
Signed-off-by: Ronald Wahl ronald.w...@raritan.com
Acked-by: Alexandre Belloni alexandre.bell...@free-electrons.com
Acked-by: Boris Brezillon boris.brezil...@free-electrons.com
Acked-by: Nicolas Ferre
there for the same reason. Move clock
preparation and setting clock rate into process context (at91udc_probe).
Signed-off-by: Ronald Wahl ronald.w...@raritan.com
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
---
v3 - v4:
- no code changes
- update commit message
- add changelog
v2 - v3
...@free-electrons.com
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
Thanks,
---
drivers/usb/gadget/atmel_usba_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/atmel_usba_udc.c
b/drivers/usb/gadget/atmel_usba_udc.c
index 9f65324f9ae0
On 12/02/2014 14:03, Nicolas Ferre :
From: Jean-Jacques Hiblot jjhib...@traphandler.com
When using dt resources retrieval (interrupts and reg properties) there is
no predefined order for these resources in the platform dev resource
table. Also don't expect the number of resource to be always
On 12/03/2014 16:31, Greg Kroah-Hartman :
On Wed, Mar 12, 2014 at 03:57:48PM +0100, Nicolas Ferre wrote:
On 12/02/2014 14:03, Nicolas Ferre :
From: Jean-Jacques Hiblot jjhib...@traphandler.com
When using dt resources retrieval (interrupts and reg properties) there is
no predefined order
jjhib...@traphandler.com
Acked-by: Boris BREZILLON b.brezil...@overkiz.com
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
Cc: stable sta...@vger.kernel.org # 3.4
---
drivers/usb/gadget/at91_udc.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/usb/gadget/at91_udc.c b/drivers
. So, okay.
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
return eps;
err:
return ERR_PTR(ret);
--
Nicolas Ferre
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
data for non-dt kernel,
or parse from dt node.
Signed-off-by: Bo Shen voice.s...@atmel.com
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
---
Changes in v2:
- Make the commit message more clearer.
drivers/usb/gadget/atmel_usba_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
.
So, define a new micro USBA_NR_DMAs for DMA channels. And the
s/micro/macro/
USBA_NR_ENDPOINS is not used anymore, remove it at the same time.
Signed-off-by: Bo Shen voice.s...@atmel.com
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
---
Changes in v2:
- Make the commit message more
jjhib...@traphandler.com
Acked-by: Boris BREZILLON b.brezil...@overkiz.com
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
Cc: stable sta...@vger.kernel.org # 3.4
---
drivers/usb/gadget/at91_udc.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/usb/gadget/at91_udc.c b/drivers
)) {
if (ep_is_control(udc-usba_ep[i]))
usba_control_irq(udc,
udc-usba_ep[i]);
--
1.8.5.2
Best Regards,
Bo Shen
Best Regards,
Bo Shen
--
Nicolas Ferre
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body
On 17/01/2014 03:59, Bo Shen :
In sama5d3 SoC, there are 16 endpoints. As the USBA_NR_ENDPOINTS
is only 7. So, fix it for sama5d3 SoC using the udc-num_ep.
Signed-off-by: Bo Shen voice.s...@atmel.com
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
---
drivers/usb/gadget
-by: Nicolas Ferre nicolas.fe...@atmel.com
---
drivers/usb/gadget/atmel_usba_udc.c | 2 +-
drivers/usb/gadget/atmel_usba_udc.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/atmel_usba_udc.c
b/drivers/usb/gadget/atmel_usba_udc.c
index 7e67a81..5cded1c
@samsung.com
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
Thanks.
---
drivers/usb/gadget/atmel_usba_udc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/atmel_usba_udc.c
b/drivers/usb/gadget/atmel_usba_udc.c
index 409a055..55ae5ef 100644
-rsrc_len);
usb_put_hcd(hcd);
-
- if (IS_ENABLED(CONFIG_COMMON_CLK))
- clk_put(uclk);
- clk_put(hclk);
- clk_put(fclk);
- clk_put(iclk);
fclk = iclk = hclk = NULL;
}
--
Nicolas Ferre
--
To unsubscribe from this list: send the line unsubscribe
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
---
drivers/usb/host/ohci-at91.c | 24 +---
1 file changed, 5 insertions(+), 19 deletions(-)
diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
index 7aec6ca..c406f1e 100644
--- a/drivers/usb/host/ohci-at91
to avoid resource type mismatch.
Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com
Tested-by: Robert Nelson robertcnel...@gmail.com
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
---
drivers/usb/host/ohci-at91.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions
On 03/12/2013 15:07, Boris BREZILLON :
Replace clk_get calls by devm_clk_get calls.
Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com
Tested-by: Robert Nelson robertcnel...@gmail.com
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
Thanks Boris for these fixes.
Alan, Greg, can you take
create mode 100644 include/dt-bindings/clk/at91.h
rename {arch/arm/mach-at91/include/mach = include/linux/clk}/at91_pmc.h (98%)
--
1.7.9.5
--
Nicolas Ferre
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More
.
This configuration was formely done in mach-at91/clock.c, but will be
bypassed when moving to common clk framework.
This patch adds support for usb clock retrieval and configuration only if
CCF is enabled (CONFIG_COMMON_CLK).
Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com
Acked-by: Nicolas Ferre
On 17/10/2013 18:55, Boris BREZILLON :
This patch adds new at91 usb clock implementation using common clk framework.
This clock is used to clock usb ports (ohci, ehci and udc).
Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
Ok, this one
.h
rename {arch/arm/mach-at91/include/mach = include/linux/clk}/at91_pmc.h (98%)
--
Nicolas Ferre
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
...@overkiz.com
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
---
drivers/clk/Makefile |1 +
drivers/clk/at91/Makefile |5 +
drivers/clk/at91/pmc.c| 283 +
drivers/clk/at91/pmc.h| 58 ++
4 files changed, 347 insertions
On 11/10/2013 10:41, Boris BREZILLON :
This patch adds a new macro file for PMC macros.
This macro file includes the definitions of SR (status register) bit
offsets and will be use to reference PMC irqs.
Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com
Acked-by: Nicolas Ferre
1 - 100 of 136 matches
Mail list logo
