I'm reproducing the steps of Alan Ott from his ELC 2014 talk:
https://elinux.org/images/6/66/Elc_2014_usb.pdf
Alan reports up to 211 Mbit/sec when using 64kB transfers while I can
get only around 120 Mbit/sec when using 64kB transfers. My first
question is:
- is the beaglebone black expected to
On Wed, Apr 19, 2017 at 01:03:23PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 4/19/2017 9:14 AM, Peter Senna Tschudin wrote:
>
> > We need the SMSC USB3315 clock and regulator to always be initialized.
> > We also need the PHY driver to take the PHY out of reset. Th
cide which
initialization path to use.
CC: Peter Chen
CC: Stephen Boyd
CC: Fabien Lahoudere
Signed-off-by: Peter Senna Tschudin
---
This is a follow-up of previous discussion:
https://www.spinics.net/lists/linux-usb/msg146680.html
drivers/usb/phy/phy-generic.c | 33 +---
igned-off-by: Romain Perier
> > Acked-by: Peter Senna Tschudin
> > Tested-by: Peter Senna Tschudin
> > ---
> > drivers/net/ethernet/intel/e100.c | 12 ++--
> > 1 file changed, 6 insertions(+), 6 deletions(-)
>
> Acked-by: Jeff Kirsher
>
> My onl
On Sun, Feb 26, 2017 at 08:24:17PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
Reviewed-by: Peter Senna Tschudin
> Signed-off-by: Romain Perier
> ---
> dr
On Sun, Feb 26, 2017 at 08:24:18PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
Reviewed-by: Peter Senna Tschudin
> Signed-off-by: Romain Perier
> ---
>
On Sun, Feb 26, 2017 at 08:24:22PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
Reviewed-by: Peter Senna Tschudin
> Signed-off-by: Romain Perier
> ---
> driv
On Sun, Feb 26, 2017 at 08:24:16PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
Reviewed-by: Peter Senna Tschudin
> Signed-off-by: Romain Perier
> ---
> dri
On Sun, Feb 26, 2017 at 08:24:24PM +0100, Romain Perier wrote:
> Now that all the drivers use dma pool API, we can remove the macro
> functions for PCI pool.
>
Reviewed-by: Peter Senna Tschudin
> Signed-off-by: Romain Perier
> ---
> include/linux/pci.h | 9 -
&g
hes did sent some comments for this one, did you address
them?
Reviewed-by: Peter Senna Tschudin
> Signed-off-by: Romain Perier
> ---
> scripts/checkpatch.pl | 9 -
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpat
On Sun, Feb 26, 2017 at 08:24:05PM +0100, Romain Perier wrote:
> The current PCI pool API are simple macro functions direct expanded to
> the appropriated dma pool functions. The prototypes are almost the same
> and semantically, they are very similar. I propose to use the DMA pool
> API directly a
Reviewed-by: Peter Senna Tschudin
> Signed-off-by: Romain Perier
> ---
> drivers/scsi/csiostor/csio_hw.h | 2 +-
> drivers/scsi/csiostor/csio_init.c | 11 ++-
> drivers/scsi/csiostor/csio_scsi.c | 6 +++---
> 3 files changed, 10 insertions(+), 9 deletions(-)
>
>
On Sun, Feb 26, 2017 at 08:24:23PM +0100, Romain Perier wrote:
> This replaces remaining occurences of pci_pool by dma_pool, as
> this is the new API that could be used for that purpose.
>
Reviewed-by: Peter Senna Tschudin
> Signed-off-by: Romain Perier
> ---
> drivers/u
On Sun, Feb 26, 2017 at 08:24:12PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
Reviewed-by: Peter Senna Tschudin
> Signed-off-by: Romain Perier
> ---
> dr
On Sun, Feb 26, 2017 at 08:24:11PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
Reviewed-by: Peter Senna Tschudin
> Signed-off-by: Romain Perier
> ---
> dr
On Sun, Feb 26, 2017 at 08:24:15PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API. It also updates
> some comments, accordingly.
>
Reviewed-by: Peter Senna Tschudin
>
s-Coverity-ID: 1230257
Reviewed-by: Peter Senna Tschudin
> Signed-off-by: Gustavo A. R. Silva
> ---
> drivers/usb/misc/lvstest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/misc/lvstest.c b/drivers/usb/misc/lvstest.c
> index c7c21
On Sat, Feb 18, 2017 at 09:35:47AM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
Did not apply on linux-next-20170217
>
> Signed-off-by: Romain Perier
> ---
> drivers/scsi/megaraid
On Sat, Feb 18, 2017 at 09:35:36AM +0100, Romain Perier wrote:
Tested all patches by compilation and checkpatch. All of them compile
fine, but patches 11 and 12 need some fixes. You can resend as
PATCH instead of RFC.
> The current PCI pool API are simple macro functions direct expanded to
> the
On Sat, Feb 18, 2017 at 09:35:48AM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
Please run checkpatch, fix the style issue and resend.
>
> Signed-off-by: Romain Perier
> ---
> driv
On Sat, Feb 18, 2017 at 09:35:47AM +0100, Romain Perier wrote:
Hi Romain,
Checkpatch gives some warnings you can fix related to NULL tests before
dma_pool_destroy(), and you changed indentation style in some of your
changes. Some times it is important to keep consistency within a file
even if the
Acked-by: Peter Senna Tschudin
> Tested-by: Peter Senna Tschudin
> ---
> drivers/block/DAC960.c | 36 ++--
> drivers/block/DAC960.h | 4 ++--
> 2 files changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/block/DAC960.c b/dr
R. Silva
Reviewed-by: Peter Senna Tschudin
> ---
> drivers/usb/class/cdc-wdm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c
> index 0a63695..8fda45a 100644
> --- a/drivers/usb/cl
On Wed, Feb 08, 2017 at 05:34:49PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
> Signed-off-by: Romain Perier
> ---
> drivers/scsi/megaraid/megaraid_mbox.c | 30 ++--
On Wed, Feb 08, 2017 at 05:34:48PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
> Signed-off-by: Romain Perier
> ---
> drivers/scsi/lpfc/lpfc.h | 10 +++
> drivers/scsi/lp
On Wed, Feb 08, 2017 at 05:34:52PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
Tested by compilation only.
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna
On Wed, Feb 08, 2017 at 05:34:57PM +0100, Romain Perier wrote:
> pci_pool_*() functions should be replaced by the corresponding functions
> in the DMA pool API. This adds support to check for use of these pci
> functions and display a warning when it is the case.
Don't know if relevant, but did no
On Wed, Feb 08, 2017 at 05:34:38PM +0100, Romain Perier wrote:
Hi Romain,
Nice set of patches! Thank you.
I sent a few comments, but basically you missed to run checkpatch.pl on
your patches. Also you can take the chance to fix some white space
issues that are on the lines you are changing like s
On Wed, Feb 08, 2017 at 05:34:43PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
Tested by compilation only.
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna Tschudin
&g
On Wed, Feb 08, 2017 at 05:34:56PM +0100, Romain Perier wrote:
> Now that all the drivers use dma pool API, we can remove the macro
> functions for PCI pool.
Good news: make allyesconfig;make succeed after the changes until this
point, but:
$ grep -R pci_pool
...
drivers/usb/gadget/udc/pch_udc.c:
On Wed, Feb 08, 2017 at 05:34:42PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
Tested by compilation only.
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna Tschudin
&g
On Wed, Feb 08, 2017 at 05:34:53PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
Tested by compilation only.
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna
On Wed, Feb 08, 2017 at 05:34:55PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
> Signed-off-by: Romain Perier
> ---
> drivers/usb/gadget/udc/pch_udc.c | 28 ++-
On Wed, Feb 08, 2017 at 05:34:40PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
Tested by compilation only.
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna
On Wed, Feb 08, 2017 at 05:34:54PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
Tested by compilation only.
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna
On Wed, Feb 08, 2017 at 05:34:50PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
> Signed-off-by: Romain Perier
> ---
> drivers/scsi/mpt3sas/mpt3sas_base.c | 64
> +
On Wed, Feb 08, 2017 at 05:34:51PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
> Signed-off-by: Romain Perier
> ---
> drivers/scsi/mvsas/mv_init.c | 4 ++--
> drivers/scsi/mvsas/m
On Wed, Feb 08, 2017 at 05:34:41PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
Tested by compilation only.
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna Ts
On Wed, Feb 08, 2017 at 05:34:44PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
> Signed-off-by: Romain Perier
> ---
> drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 10 +--
the patch do not
add new ones.
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna Tschudin
> ---
> drivers/block/DAC960.c | 36 ++--
> drivers/block/DAC960.h | 4 ++--
> 2 files changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/dr
On Wed, Feb 08, 2017 at 05:34:45PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
> Signed-off-by: Romain Perier
> ---
> drivers/net/wireless/intel/ipw2x00/ipw2200.c | 12 ++--
On Wed, Feb 08, 2017 at 05:34:47PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
> Signed-off-by: Romain Perier
> ---
> drivers/scsi/csiostor/csio_hw.h | 2 +-
> drivers/scsi/csio
On Wed, Feb 08, 2017 at 05:34:46PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
Tested by compilation only.
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna
On Wed, Jan 06, 2016 at 09:28:41PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 1/5/2016 7:54 PM, Peter Senna Tschudin wrote:
>
> >From: Peter Senna Tschudin
> >
> >This patch remove four calls to dev_err() from sisusb_probe() as
> >reporting mem
On Tue, Jan 05, 2016 at 10:53:24AM -0800, Joe Perches wrote:
> On Tue, 2016-01-05 at 17:54 +0100, Peter Senna Tschudin wrote:
> []
> > Patch 1 is the biggest and fix only whitespace, tab and newline issues. I
> > used
> >
> > $ git diff -w --word-diff=porcel
From: Peter Senna Tschudin
This patch remove four calls to dev_err() from sisusb_probe() as
reporting memory allocation failures is redundant:
- Remove a call to dev_err() that was reporting unsuccesful call to
kzalloc().
- Remove two calls to dev_err() that were reporting unsuccesful
From: Peter Senna Tschudin
This patch removes null test before calls to kfree() as kfree() can
handle null pointers safely.
Signed-off-by: Peter Senna Tschudin
---
Tested by compilation only.
drivers/usb/misc/sisusbvga/sisusb.c | 12
1 file changed, 4 insertions(+), 8 deletions
From: Peter Senna Tschudin
This patch change only spaces, tabs, and newlines.
The file drivers/usb/misc/sisusbvga/sisusb.c contained entire statements
using 4 spaces for the last level of indetantion, and many other space
and tab related issues. This patch fixes the following issues:
- 83
From: Peter Senna Tschudin
The file drivers/usb/misc/sisusbvga/sisusb.c had 6 assignments inside if
tests. This patch move the assignement outside the test.
Signed-off-by: Peter Senna Tschudin
---
Tested by compilation only.
drivers/usb/misc/sisusbvga/sisusb.c | 18 --
1 file
From: Peter Senna Tschudin
The file drivers/usb/misc/sisusbvga/sisusb.c contained coding style
issues reported by checkpatch. This patch fixes the following
errors:
- 12 WARNING: braces {} are not necessary for single statement blocks
- 4 ERROR: return is not a function, parentheses are not
pointer. The patch change the
problematic error path to cleanup previously allocated resources and abort the
probe with -ENOMEM instead of only calling dev_err() and continue with the
probe.
Patch 5 remove null tests before calls to kfree().
Peter Senna Tschudin (5):
usb-misc: sisusbvga: Fix
On Wed, Dec 09, 2015 at 07:15:37PM -0300, Geyslan G. Bem wrote:
> This patch moves the constant 0x3ff to right and put spaces
> in the right shift.
>
> Caught by coccinelle:
> scripts/coccinelle/misc/compare_const_fl.cocci
>
> Signed-off-by: Geyslan G. Bem
Acked-by:
t other than that the patch
looks good to me.
Acked-by: Peter Senna Tschudin
> ---
> drivers/usb/host/ehci.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
> index 15de5bf..81e609a 100644
> --
ut other than that the patch
looks good to me.
Acked-by: Peter Senna Tschudin
> ---
> drivers/usb/host/ehci.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
> index ea56147..15de5bf 100644
> --- a
On Wed, Dec 09, 2015 at 07:32:35PM -0300, Geyslan G. Bem wrote:
> Put space after comma.
>
> This patch also changes QH_NEXT macro for better reading.
>
> Caught by checkpatch: "ERROR: space required after that ','"
>
> Signed-off-by: Geyslan G. Bem
> ---
> drivers/usb/host/ehci.h | 5 +++--
>
-by: Geyslan G. Bem
As with previous, missing the changelog, but other than that the patch
looks good to me.
Acked-by: Peter Senna Tschudin
> ---
> drivers/usb/host/ehci.h | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/host/ehci.h b/drive
: Geyslan G. Bem
As with previous, missing the changelog, but other than that the patch
looks good to me.
Acked-by: Peter Senna Tschudin
> ---
> drivers/usb/host/ehci.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/ehci.h b/drive
. Bem
> ---
As with previous, missing the changelog here, but other than that the patch
looks good to me.
Acked-by: Peter Senna Tschudin
> drivers/usb/host/ehci.h | 22 +++---
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/usb/
the changelog, but other than that the patch
looks good to me.
Acked-by: Peter Senna Tschudin
> ---
> drivers/usb/host/ehci.h | 20 ++--
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
> index
what changed from V1.
Other than that:
Acked-by: Peter Senna Tschudin
Not related to this patch, I did not receive patch 9/9v2.
> drivers/usb/host/ehci.h | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci
ff-by: Geyslan G. Bem
Acked-by: Peter Senna Tschudin
> ---
> drivers/usb/host/ehci-hcd.c | 2 +-
> drivers/usb/host/ohci-hcd.c | 4 ++--
> drivers/usb/host/u132-hcd.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-hcd.c b/
On Wed, Dec 2, 2015 at 11:18 PM, Geyslan G. Bem wrote:
> Replace BUG() with BUG_ON().
>
> Caught by coccinelle.
I would mention the path to the .cocci script, but other than that:
Acked-by: Peter Senna Tschudin
>
> Signed-off-by: Geyslan G. Bem
> ---
> drivers/usb/ho
On Wed, Dec 2, 2015 at 10:45 PM, Geyslan G. Bem wrote:
> Get rid of bool explicit comparisons.
>
> Caught by Coccinelle.
I would mention the path to the .cocci script, but other than that:
Acked-by: Peter Senna Tschudin
>
> Signed-off-by: Geyslan G. Bem
> ---
> driver
On Wed, Dec 2, 2015 at 9:43 PM, Geyslan G. Bem wrote:
> Replace dma_pool_alloc and memset with a single call to dma_pool_zalloc.
>
> Caught by coccinelle.
I would mention which script was used, but other than that:
Acked-by: Peter Senna Tschudin
>
> Signed-off-by:
This patch make changes to an if else statement which simplifies the code
allowing to remove a return.
CC: Joe Perches
Signed-off-by: Peter Senna Tschudin
---
Subject was: [PATCH 3/9] usb/host/fotg210: Remove useless else statement
To be applied on top of V1.
Changes from V1:
Instead of
This patch remove an else statement after a return to make the code
easier to understand.
Signed-off-by: Peter Senna Tschudin
---
drivers/usb/host/fotg210-hcd.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210
This patch remove KERN_WARNING from a call to pr_warn().
Signed-off-by: Peter Senna Tschudin
---
drivers/usb/host/fotg210-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c
index d80b2e8..25885ef 100644
--- a
This patch fix coding style issues reported by checkpatch that do not
change semantics of the code.
Signed-off-by: Peter Senna Tschudin
---
This patch introduces one checkpatch warning for line over 80
characters, but my personal feeling is that it looks better
and easier to read this way
This patch remove NULL checks before calls to dma_pool_destroy() as the
function now can handle NULL pointers.
Signed-off-by: Peter Senna Tschudin
---
drivers/usb/host/fotg210-hcd.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/host/fotg210-hcd.c b
This patch convert the macro speed_char in an inline function. The goal
of this patch is to make the code easier to read.
Signed-off-by: Peter Senna Tschudin
---
drivers/usb/host/fotg210-hcd.c | 27 ---
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git a
a
new function named output_buf_tds_dir(). This change makes the code
easier to read and calm down checkpatch. This patch changes it to:
fill_periodic_buffer() -> for() -> do -> switch() -> if() ->
output_buf_tds_dir()
Signed-off-by: Peter Senna Tschudin
---
drive
msleep under 20ms can result in sleeping up to 20ms, which may not be
intended. Replace msleep(5) by usleep_range(5000, 1). The range of 5
ms is to reduce the chances of creating an interrupt while reducing the
maximum wait time in 50%.
Signed-off-by: Peter Senna Tschudin
---
drivers/usb
This patch replaces:
kmalloc(DBG_SCHED_LIMIT * sizeof(*seen), GFP_ATOMIC)
by:
kmalloc_array(DBG_SCHED_LIMIT, sizeof(*seen), GFP_ATOMIC)
as kmalloc_array() should be used for allocating arrays.
Signed-off-by: Peter Senna Tschudin
---
drivers/usb/host/fotg210-hcd.c | 2 +-
1 file changed, 1
d scan_frame_queue() containing
the last 4 nesting levels, and removes the need of backwards goto,
making the code easier to read. After the patch it becomes:
scan_iosoc() -> for() -> while() -> scan_frame_queue()
Signed-off-by: Peter Senna Tschudin
---
drivers/u
This patch series fix warnings reported by checkpatch on the
FOTG210 EHCI-like driver.
Peter Senna Tschudin (9):
usb/host/fotg210: Fix coding style issues
usb/host/fotg210: remove KERN_WARNING from pr_warn
usb/host/fotg210: Remove useless else statement
usb/host/fotg210: Remove NULL
On Fri, Oct 2, 2015 at 7:52 PM, Alan Stern wrote:
> On Fri, 2 Oct 2015, Felipe Balbi wrote:
>
>> On Mon, Sep 21, 2015 at 05:01:10PM +0200, Peter Senna Tschudin wrote:
>> > msleep under 20ms can result in sleeping up to 20ms, which may not be
>> > intended. Replace
On Fri, Oct 2, 2015 at 7:39 PM, Felipe Balbi wrote:
> On Fri, Oct 02, 2015 at 01:18:27PM +0200, Peter Senna Tschudin wrote:
>> fusbh200 and fotg210 are very similar. The initial idea was to consolidate
>> both drivers but I'm afraid fusbh200 is not being used.
>>
>>
On Tue, Sep 15, 2015 at 6:50 PM, Felipe Balbi wrote:
> Hi,
>
> On Tue, Sep 15, 2015 at 06:41:55PM +0200, Peter Senna Tschudin wrote:
>> On Tue, Sep 15, 2015 at 4:33 PM, Felipe Balbi wrote:
>> > On Mon, Sep 14, 2015 at 07:50:02PM +0200, Peter Senna Tschudin wrote:
>>
This patch removes a macro from a call to snprintf() and moves it's
content to just before the call to snprintf() assigning a value to a new
variable named tmp. The goal of this patch is to make the code easier to
understand.
Signed-off-by: Peter Senna Tschudin
---
drivers/usb/host/fo
This patch remove KERN_WARNING from a call to pr_info().
Signed-off-by: Peter Senna Tschudin
---
drivers/usb/host/fotg210-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c
index 48eac34..36413b2 100644
--- a
hes 06, 09 and 10 that may
have impact on performance? Or should I wait until I can get some hw to
test?
- Do you know easy to find and cheap devices using this two host controllers?
- Should I worry about drivers/usb/gadget/udc/fotg210-udc.c?
Peter Senna Tschudin (14):
usb/host/fotg210:
This patch remove an else statement after a return to make the code
easier to understand.
Signed-off-by: Peter Senna Tschudin
---
drivers/usb/host/fotg210-hcd.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210
This patch convert the macro speed_char in an inline function. The goal
of this patch is to make the code easier to read.
Signed-off-by: Peter Senna Tschudin
---
drivers/usb/host/fotg210-hcd.c | 27 ---
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git a
This patch fix coding style issues reported by checkpatch that do not
change semantics of the code.
Signed-off-by: Peter Senna Tschudin
---
drivers/usb/host/fotg210-hcd.c | 1248 +---
drivers/usb/host/fotg210.h | 36 +-
2 files changed, 558 insertions
d scan_frame_queue() containing
the last 4 nesting levels, and removes the need of backwards goto,
making the code easier to read. After the patch it becomes:
scan_iosoc() -> for() -> while() -> scan_frame_queue()
Signed-off-by: Peter Senna Tschudin
---
drivers/u
This patch remove NULL checks before calls to dma_pool_destroy() as the
function now can handle NULL pointers.
Signed-off-by: Peter Senna Tschudin
---
drivers/usb/host/fotg210-hcd.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/host/fotg210-hcd.c b
to a
new inline function named output_buf_tds_dir(). This change makes the
code easier to read and calm down checkpatch. This patch changes it to:
fill_periodic_buffer() -> for() -> do -> switch() -> if() ->
output_buf_tds_dir()
Signed-off-by: Peter Senna Tschudin
---
drive
This patch adds FUSBH200 parameters to faraday-hcd.h.
Signed-off-by: Peter Senna Tschudin
---
drivers/usb/host/faraday-hcd.h | 50 +-
1 file changed, 49 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/faraday-hcd.h b/drivers/usb/host/faraday
This patch change:
kmalloc(DBG_SCHED_LIMIT * sizeof(*seen), GFP_ATOMIC)
by:
kmalloc_array(DBG_SCHED_LIMIT, sizeof(*seen), GFP_ATOMIC)
as kmalloc_array() should be used for allocating arrays.
Signed-off-by: Peter Senna Tschudin
---
drivers/usb/host/fotg210-hcd.c | 2 +-
1 file changed, 1
For making the code more readable and to facilitate supporting multiple
hardware versions, move #defines to outside the struct declaration. This
patch also renames fhcd2xx_regs to fotg210_regs as this struct is
specific to fotg210.
Signed-off-by: Peter Senna Tschudin
---
drivers/usb/host
msleep under 20ms can result in sleeping up to 20ms, which may not be
intended. Replace msleep(5) by usleep_range(5000, 6000).
Signed-off-by: Peter Senna Tschudin
---
drivers/usb/host/fotg210-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/fotg210
On Tue, Sep 15, 2015 at 4:33 PM, Felipe Balbi wrote:
> On Mon, Sep 14, 2015 at 07:50:02PM +0200, Peter Senna Tschudin wrote:
>> On Mon, Sep 14, 2015 at 5:01 PM, Felipe Balbi wrote:
>> > On Sat, Sep 12, 2015 at 03:14:50PM +0200, Peter Senna Tschudin wrote:
>> >
On Mon, Sep 14, 2015 at 5:01 PM, Felipe Balbi wrote:
> On Sat, Sep 12, 2015 at 03:14:50PM +0200, Peter Senna Tschudin wrote:
>> >> Should these files be consolidated? And if so how?
>> > if you can find an easy way, that would be a very, very welcome patch.
>&g
>> Should these files be consolidated? And if so how?
> if you can find an easy way, that would be a very, very welcome patch.
Is the ideal solution to consolidate both fusbh200-hcd.c and
fotg210-hcd.c in a single module? If this is the case, how to detect
at run time which version of the hw is pr
I executed a clone detection tool* on drivers source code and I found
that the files
drivers/usb/host/fusbh200-hcd.c
and
drivers/usb/host/fotg210-hcd.c
are very similar. The main difference between the two files are
replacing the string 'USBH20' by 'OTG21' and some white space fixes.
Some chang
On Sat, May 31, 2014 at 6:17 PM, Sergei Shtylyov
wrote:
> Hello.
>
>
> On 05/31/2014 05:14 PM, Peter Senna Tschudin wrote:
>
>> This patch remove variables that are initialized with a constant,
>> are never updated, and are only used as parameter of return.
>> Ret
On Sat, May 31, 2014 at 11:58 AM, Johan Hovold wrote:
> On Sat, May 31, 2014 at 10:14:01AM -0300, Peter Senna Tschudin wrote:
>> This patch remove variables that are initialized with a constant,
>> are never updated, and are only used as parameter of return.
>> Return th
This patch remove the function klsi_105_tiocmset which was only
returning -EINVAL. It also removes the function prototype and
the .tiocmset entry in the struct usb_serial_driver.
Verified by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Changes from V1:
- remove the function
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
//
Signed-off-by: Peter Senna Tschudin
---
drivers/usb/serial/kl5kusb105.c | 23 +--
1 file changed, 1 insertion(+), 22 deletions(-)
diff --git a/drivers/usb/serial/kl5kusb105.c b/drivers/usb
From: Peter Senna Tschudin
removes unnecessary semicolon
Found by Coccinelle: http://coccinelle.lip6.fr/
Signed-off-by: Peter Senna Tschudin
---
drivers/usb/host/xhci-ring.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb
1 - 100 of 103 matches
Mail list logo