No need to do extra endianness conversion in
usb_set_isoch_delay because it is already done
in usb_control_msg()
Fixes: 886ee36e7205 ("usb: core: add support for USB_REQ_SET_ISOCH_DELAY")
Cc: Dmytro Panchenko
Cc: Felipe Balbi
Cc: stable # v4.16+
Signed-off-by: Ruslan Bilovol
---
d
Hi Felipe,
On Mon, Dec 4, 2017 at 1:36 PM, Felipe Balbi wrote:
>
> Hi,
>
> Ruslan Bilovol writes:
>> On Tue, Nov 7, 2017 at 3:52 AM, Ruslan Bilovol
>> wrote:
>>> Hi,
>>>
>>> This patch adds USB Audio Device Class 3.0 [1] function
>>>
On Tue, Nov 7, 2017 at 3:52 AM, Ruslan Bilovol wrote:
> Hi,
>
> This patch adds USB Audio Device Class 3.0 [1] function
> support to gadget subsystem.
> I didn't add UAC3 support to legacy gadget as it will
> make preprocessor configuration too complex (UAC3 device
> mu
0 > configs/c.2/MaxPower
ln -s functions/uac3.0 configs/c.2
echo 0x0101 > idProduct
echo 0x1d6b > idVendor
echo my-serial-num > strings/0x409/serialnumber
echo my-manufacturer > strings/0x409/manufacturer
echo musb-hdrc.0 > UDC
[1] http://www.usb.org/developers/docs/devclass_d
example volume, mute and
power management handling has dummy implementation
in some places
Signed-off-by: Ruslan Bilovol
---
Documentation/ABI/testing/configfs-usb-gadget-uac3 | 14 +
Documentation/usb/gadget-testing.txt | 41 +
drivers/usb/gadget/Kconfig
USB spec says that multiple byte fields are stored in
little-endian order (see chapter 8.1 of USB2.0 spec and
chapter 7.1 of USB3.0 spec), thus mark such fields as LE
for UAC1 and UAC2 headers
Signed-off-by: Ruslan Bilovol
---
include/linux/usb/audio-v2.h | 14 +++---
include/uapi
As per USB spec, multiple-bytes fields are stored
in little-endian order. Use CPU<->LE helpers for
such fields.
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/function/f_uac1.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/
big endian case tested only build which also
doesn't produce sparse warnings anymore.
Ruslan Bilovol (3):
include: usb: audio: specify exact endiannes of descriptors
usb: gadget: f_uac1: endianness fixes.
usb: gadget: f_uac2: endianness fixes.
drivers/usb/gadget/function/f_uac1.c
As per USB spec, multiple-bytes fields are stored
in little-endian order. Use CPU<->LE helpers for
such fields.
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/function/f_uac2.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/drive
ningful
- rebased on top of balbi/next
v3 changes:
- renamed u_audio exported symbols so they don't
conflict with old f_uac1 if both are built-in.
v2 changes:
- do not touch f_uac1, instead created f_uac1_newapi
- added documentation for f_uac1_newapi
- rebased on top of v4.8-rc
Simplify f_uac2 by removing platform driver/device
creation; use composite's usb_gadget device as
parent for sound card and for debug prints.
This removes extra layer of code without any functional
change.
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/function/f_uac2.c
ALSA sound card's name configurable
- add [in/out]_ep_maxpsize
- allocate snd_uac_chip structure during g_audio_setup
- add u_audio_[start/stop]_[capture/playback] functions
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/Kconfig| 4 +
drivers/usb/gadget/function/Mak
uac1_legacy, that there is no any
reason to keep them in the same file/module,
and separate function was created.
g_audio can be built using one of existing
UAC functions (f_uac1, f_uac1_legacy or f_uac2)
Signed-off-by: Ruslan Bilovol
---
Documentation/ABI/testing/configfs-usb-gadget-uac1
Before introducing new f_uac1 function (with virtual
ALSA card) make current implementation legacy.
This includes renaming of existing files, some
variables, config options and documentation
Signed-off-by: Ruslan Bilovol
---
...gadget-uac1 => configfs-usb-gadget-uac1_legacy} |
e it looks like:
[424339.017711] 21:1:1: usb_set_interface failed (-32)
Since host can't set altsetting 1, it can't start
playing audio.
In order to fix it implemented get_alt along with
minor improvements (error conditions checking)
similar to what existing f_uac2 has.
Cc: Krzysztof Opasi
On Tue, Jun 6, 2017 at 12:41 PM, Felipe Balbi wrote:
>
> Hi,
>
> Greg KH writes:
>>> > I'm OK with dropping legacy f_uac1 implementation.
>>> >
>>> > Another idea I was thinking about is to implement simple in-kernel
>>> > driver which will do the same as existing alsaloop tool userspace
>>> > to
From: Ruslan Bilovol
These flags and structures are deprecated and there is
no anymore users of them, so it's safe to remove them.
Signed-off-by: Ruslan Bilovol
---
Although this patch was acked-by Felipe Balbi and Roger Quadros back
in 2013, it was never picked up by maintainers.
Hi,
On Fri, Jun 2, 2017 at 12:42 PM, Felipe Balbi wrote:
>
> Hi,
>
> Ruslan Bilovol writes:
>> I came to this patch series when wanted to do two things:
>> - use UAC1 as virtual ALSA sound card on gadget side,
>>just like UAC2 is used so it's possible to
Hi Felipe,
On Fri, Jun 2, 2017 at 12:34 PM, Felipe Balbi wrote:
>
> Hi,
>
> Ruslan Bilovol writes:
>> Abstract the peripheral side ALSA sound card code from
>> the f_uac2 function into a component that can be called
>> by various functions, so the various fla
On Fri, May 26, 2017 at 6:52 PM, Julian Scheel wrote:
> On 18.05.2017 00:37, Ruslan Bilovol wrote:
>>
>> This patch adds a new function 'f_uac1_acard'
>> (f_uac1 with virtual "ALSA card") that
>> uses recently created u_audio API. Comparing
On Mon, May 22, 2017 at 6:58 PM, Jassi Brar wrote:
> On Thu, May 18, 2017 at 4:07 AM, Ruslan Bilovol
> wrote:
>> Abstract the peripheral side ALSA sound card code from
>> the f_uac2 function into a component that can be called
>> by various functions, so the various flavo
f_uac1_newapi
- rebased on top of v4.8-rc1
[1] https://lkml.org/lkml/2016/5/23/649
Ruslan Bilovol (3):
usb: gadget: f_uac2: remove platform driver/device creation
usb: gadget: f_uac2: split out audio core
usb: gadget: add f_uac1 variant based on a new u_audio api
.../ABI/testing/con
ALSA sound card's name configurable
- add [in/out]_ep_maxpsize
- allocate snd_uac_chip structure during g_audio_setup
- add u_audio_[start/stop]_[capture/playback] functions
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/Kconfig| 4 +
drivers/usb/gadget/function/Mak
ers are so different comparing
to legace f_uac1, that there is no any
reason to keep them in the same file/module,
and separate function was created.
g_audio can be built using one of existing
UAC functions (f_uac1, f_uac1_acard or f_uac2)
Signed-off-by: Ruslan Bilovol
---
.../ABI/testing/configf
Simplify f_uac2 by removing platform driver/device
creation; use composite's usb_gadget device as
parent for sound card and for debug prints.
This removes extra layer of code without any functional
change.
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/function/f_uac2.c
Hi Felipe,
On Mon, Aug 29, 2016 at 11:05 AM, Felipe Balbi wrote:
>
> Hi,
>
> Ruslan Bilovol writes:
>> I came to this patch series when wanted to do two things:
>> - use UAC1 as virtual ALSA sound card on gadget side,
>>just like UAC2 is used so it's p
u_audio exported symbols so they don't
conflict with old f_uac1 if both are built-in.
v2 changes:
- do not touch f_uac1, instead created f_uac1_newapi
- added documentation for f_uac1_newapi
- rebased on top of v4.8-rc1
[1] https://lkml.org/lkml/2016/5/23/649
Ruslan Bilovol (3):
Simplify f_uac2 by removing platform driver/device
creation; use composite's usb_gadget device as
parent for sound card and for debug prints.
This removes extra layer of code without any functional
change.
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/function/f_uac2.c
nd never had real volume control or mute
functionality.
g_audio can be built using one of existing
uac functions (f_uac1, f_uac1_newapi or f_uac2)
Signed-off-by: Ruslan Bilovol
---
.../ABI/testing/configfs-usb-gadget-uac1_newapi| 12 +
Documentation/usb/gadget-testing.txt
ALSA sound card's name configurable
- add [in/out]_ep_maxpsize
- allocate snd_uac_chip structure during g_audio_setup
- add u_audio_[start/stop]_[capture/playback] functions
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/Kconfig| 4 +
drivers/usb/gadget/function/Mak
t;
> url:
> https://github.com/0day-ci/linux/commits/Ruslan-Bilovol/USB-Audio-Gadget-refactoring/20160814-185318
> base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
> config: x86_64-randconfig-a0-08162223 (attached as .config)
> compiler: gcc-4.
On Tue, Aug 16, 2016 at 12:16 PM, Peter Chen wrote:
> On Sun, Aug 14, 2016 at 01:21:21AM +0300, Ruslan Bilovol wrote:
>> I came to this patch series when wanted to do two things:
>> - use UAC1 as virtual ALSA sound card on gadget side,
>>just like UAC2 is used so it&
On Tue, Aug 16, 2016 at 5:52 AM, Peter Chen wrote:
> On Sun, Aug 14, 2016 at 01:21:24AM +0300, Ruslan Bilovol wrote:
>> This patch adds new function f_uac1_newapi that
>> uses recently created u_audio api. This makes
>> f_uac1_newapi implementation much simpler by
>> re
Simplify f_uac2 by removing platform driver/device
creation; use composite's usb_gadget device as
parent for sound card and for debug prints.
This removes extra layer of code without any functional
change.
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/function/f_uac2.c
nd never had real volume control or mute
functionality.
g_audio can be built using one of existing
uac functions (f_uac1, f_uac1_newapi or f_uac2)
Signed-off-by: Ruslan Bilovol
---
.../ABI/testing/configfs-usb-gadget-uac1_newapi| 12 +
Documentation/usb/gadget-testing.txt
ALSA sound card's name configurable
- add [in/out]_ep_maxpsize
- allocate snd_uac_chip structure during gaudio_setup
- add gaudio_[start/stop]_[capture/playback] functions
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/Kconfig| 4 +
drivers/usb/gadget/function/Mak
do not touch f_uac1, instead created f_uac1_newapi
- added documentation for f_uac1_newapi
- rebased on top of v4.8-rc1
[1] https://lkml.org/lkml/2016/5/23/649
Ruslan Bilovol (3):
usb: gadget: f_uac2: remove platform driver/device creation
usb: gadget: f_uac2: split out audio core
usb: gadget: a
On Tue, Jul 26, 2016 at 3:02 PM, Krzysztof Opasiak
wrote:
>
>
> On 07/26/2016 10:53 AM, Jassi Brar wrote:
>> On Tue, Jul 26, 2016 at 7:01 AM, Ruslan Bilovol
>> wrote:
>>> On Fri, Jul 15, 2016 at 10:43 AM, Clemens Ladisch
>>> wrote:
>>>>
On Tue, Jul 26, 2016 at 11:53 AM, Jassi Brar wrote:
> On Tue, Jul 26, 2016 at 7:01 AM, Ruslan Bilovol
> wrote:
>> On Fri, Jul 15, 2016 at 10:43 AM, Clemens Ladisch wrote:
>>>>> On Tue, May 24, 2016 at 2:50 AM, Ruslan Bilovol
>>>>> wrote:
>>&
On Tue, Jul 26, 2016 at 11:06 AM, Clemens Ladisch wrote:
> Ruslan Bilovol wrote:
>> On Fri, Jul 15, 2016 at 10:43 AM, Clemens Ladisch wrote:
>>>>> On Tue, May 24, 2016 at 2:50 AM, Ruslan Bilovol
>>>>> wrote:
>>>>>> it may break current
On Fri, Jul 15, 2016 at 10:43 AM, Clemens Ladisch wrote:
>>> On Tue, May 24, 2016 at 2:50 AM, Ruslan Bilovol
>>> wrote:
>>>> it may break current usecase for some people
>
> And what are the benefits that justify breaking the kernel API?
Main limitation wi
Ping?
On Wed, Jun 8, 2016 at 11:03 AM, Ruslan Bilovol
wrote:
> Hi guys,
>
> Any feedback on this patch series? Has anybody had a chance to test it?
>
> Regards,
> Ruslan
>
> On Tue, May 24, 2016 at 2:50 AM, Ruslan Bilovol
> wrote:
>> I came to this patch se
Hi guys,
Any feedback on this patch series? Has anybody had a chance to test it?
Regards,
Ruslan
On Tue, May 24, 2016 at 2:50 AM, Ruslan Bilovol
wrote:
> I came to this patch series when wanted to do two things:
> - use UAC1 as virtual ALSA sound card on gadget side,
>just lik
needed handlers
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/function/f_uac1.c | 182 +--
1 file changed, 5 insertions(+), 177 deletions(-)
diff --git a/drivers/usb/gadget/function/f_uac1.c
b/drivers/usb/gadget/function/f_uac1.c
index f2ac0cb..ba498af
ALSA sound card's name configurable
- add [in/out]_ep_maxpsize
- allocate snd_uac_chip structure during gaudio_setup
- add gaudio_[start/stop]_[capture/playback] functions
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/Kconfig| 4 +
drivers/usb/gadget/function/Mak
to fix it in next versions.
Comments, testing are welcome.
Ruslan Bilovol (5):
usb: gadget: f_uac2: remove platform driver/device creation
usb: gadget: f_uac2: split out audio core
usb: gadget: f_uac1: drop volume/mute functionality
usb: gadget: f_uac1: switch to u_audio core utilities
Simplify f_uac2 by removing platform driver/device
creation; use composite's usb_gadget device as
parent for sound card and for debug prints.
This removes extra layer of code without any functional
change.
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/function/f_uac2.c
as playback channel has.
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/Kconfig | 7 +-
drivers/usb/gadget/function/f_uac1.c | 265 ---
drivers/usb/gadget/function/u_uac1.h | 6 +
drivers/usb/gadget/legacy/audio.c| 18 +++
4 files changed,
by userspace tools.
As a side effect, using u_audio it will be much
easier to create gadget -> PC Host audio stream
in the future
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/Kconfig | 8 +-
drivers/usb/gadget/function/Makefile | 2 +-
drivers/usb/gadget/function/f_uac
but just
>>> focused on the USB gadget driver kconfig issue initially reported by
>>> Sebastian. I saw the issue exists in 3.14, but does not in 3.16,
>>> unless I messed up with my test. I will test 3.16 again some time next
>>> week.
>>
>
musb device is allocated with PLATFORM_DEVID_AUTO, fix
incorrect lookup name in non-dt case.
This fixes issue with musb initialization on Nokia N900
in boardfile boot mode.
Signed-off-by: Ruslan Bilovol
---
drivers/phy/phy-twl4030-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
On Thu, Mar 10, 2016 at 3:59 PM, Oliver Neukum wrote:
> Adding the descriptors of chapter 9.2 of the Power Delivery spec.
>
> Signed-off-by: Oliver Neukum
> ---
> include/uapi/linux/usb/ch9.h | 98
>
> 1 file changed, 98 insertions(+)
>
> diff --git
Hi,
On Thu, Mar 10, 2016 at 12:45 PM, Felipe Balbi
wrote:
>
> Hi,
>
> Oliver Neukum writes:
>> [ text/plain ]
>> Adding the descriptors of chapter 9.2 of the Power Delivery spec.
>>
>> Signed-off-by: Oliver Neukum
>> ---
>> include/uapi/linux/usb/ch9.h | 94
>>
8b 57 08 48 89 e5
> 48 39 c8 74 29 48 b9 00 02 00 00 00 00 ad de 48 39 ca 74 3a <4c> 8b 02 4c 39
> c7 75 52 4c 8b 40 08 4c 39 c7 75 66 48 89 50 08
> RIP [] __list_del_entry+0x29/0xc0
> RSP
> CR2:
> ---[ end trace e6cfe1de661dcffe ]---
>
> Reverting t
Hi Marek,
On Mon, Nov 23, 2015 at 10:56 AM, Marek Szyprowski
wrote:
> Hello,
>
> This is a resurrection of the patches initially submitted by Ruslan
> Bilovol in the following thread: https://lkml.org/lkml/2015/6/22/554
>
> The changes since the original submission (v5) in
Hi Maxime,
On Mon, Oct 19, 2015 at 11:11 AM, Maxime Ripard
wrote:
> Hi,
>
> On Tue, Jun 23, 2015 at 01:01:09AM +0300, Ruslan Bilovol wrote:
>> This patchset adds independent registration of gadgets
>> and gadget drivers to udc-core. This is very useful for
>> built-
Hi Alan,
On Tue, Jun 23, 2015 at 5:08 PM, Alan Stern wrote:
> On Tue, 23 Jun 2015, Ruslan Bilovol wrote:
>
>> Change behavior during registration of gadgets and
>> gadget drivers in udc-core. Instead of previous
>> approach when for successful probe of usb gadget dr
Hi Krzysztof,
On Tue, Jun 23, 2015 at 9:54 AM, Krzysztof Opasiak
wrote:
> Hello,
>
> On 06/23/2015 12:01 AM, Ruslan Bilovol wrote:
>>
>> Now when udc-core supports binding to specific UDC by passing
>> its name via 'udc_name' member of usb_gadget_driver struc
stage due to no any UDC added.
Also it is useful for modules case - now there is no
difference what module to insert first: gadget module
or gadget driver one.
Tested-by: Maxime Ripard
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/udc/udc-c
Now when last user of usb_udc_attach_driver() is switched
to passing UDC name via usb_gadget_driver struct, it's safe
to remove this function
Tested-by: Maxime Ripard
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/udc/udc-core.c | 26 --
include/linux/usb/gad
Now when udc-core supports binding to specific UDC by passing
its name via 'udc_name' member of usb_gadget_driver struct,
switch to this generic approach.
Tested-by: Maxime Ripard
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/configfs.c | 27 ++-
1 fi
In order to prepare to independent gadgets and
gadget drivers registration in udc-core, some of the
functions can't have __init/__exit attributes (almost
only bind/unbind callbacks are affected)
Tested-by: Maxime Ripard
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/legacy/acm
Introduce new 'udc_name' member to usb_gadget_driver structure.
The 'udc_name' is a name of UDC that usb_gadget_driver should
be bound to. If udc_name is NULL, it will be bound to any
available UDC.
Tested-by: Maxime Ripard
Signed-off-by: Ruslan Bilovol
---
drivers/usb/g
ed behavior will be required)
- rebased to latest 'next' branch of Felipe Balbi's tree
Ruslan Bilovol (5):
usb: gadget: bind UDC by name passed via usb_gadget_driver structure
usb: gadget: configfs: pass UDC name via usb_gadget_driver struct
usb: gadget: udc-core: remove unuse
HI Alan,
On Fri, Mar 13, 2015 at 4:39 PM, Alan Stern wrote:
> On Thu, 12 Mar 2015, Ruslan Bilovol wrote:
>
>> Change behavior during registration of gadgets and
>> gadget drivers in udc-core. Instead of previous
>> approach when for successful probe of usb gadget dr
some more complicated behavior will be required)
- rebased to latest 'next' branch of Felipe Balbi's tree
Ruslan Bilovol (5):
usb: gadget: bind UDC by name passed via usb_gadget_driver structure
usb: gadget: configfs: pass UDC name via usb_gadget_driver struct
usb: gad
Now when last user of usb_udc_attach_driver() is switched
to passing UDC name via usb_gadget_driver struct, it's safe
to remove this function
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/udc/udc-core.c | 26 --
include/linux/usb/gadget.h| 2 --
2
stage due to no any UDC added.
Also it is useful for modules case - now there is no
difference what module to insert first: gadget module
or gadget driver one.
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/udc/udc-core.c | 49 ---
include/linux/us
Now when udc-core supports binding to specific UDC by passing
its name via 'udc_name' member of usb_gadget_driver struct,
switch to this generic approach.
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/configfs.c | 27 ++-
1 file changed, 14 inserti
In order to prepare to independent gadgets and
gadget drivers registration in udc-core, some of the
functions can't have __init/__exit attributes (almost
only bind/unbind callbacks are affected)
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/legacy/acm_ms.c | 6 +++---
driver
Introduce new 'udc_name' member to usb_gadget_driver structure.
The 'udc_name' is a name of UDC that usb_gadget_driver should
be bound to. If udc_name is NULL, it will be bound to any
available UDC.
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget
Hi Sergei,
On Wed, Feb 18, 2015 at 2:05 PM, Sergei Shtylyov
wrote:
> Hello.
>
> On 2/18/2015 12:17 AM, Ruslan Bilovol wrote:
>
>> Introduce new 'udc_name' member to usb_gadget_driver structure.
>> The 'udc_name' is a name of UDC that usb_gadget_drive
Hi Alan,
On Tue, Feb 17, 2015 at 11:51 PM, Alan Stern wrote:
> On Tue, 17 Feb 2015, Ruslan Bilovol wrote:
>
>> Change behavior during registration of gadgets and
>> gadget drivers in udc-core. Instead of previous
>> approach when for successful probe of usb gadget dr
stage due to no any UDC added.
Also it is useful for modules case - now there is no
difference what module to insert first: gadget module
or gadget driver one.
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/udc/udc-core.c | 51 ++-
include/linux/us
Now when last user of usb_udc_attach_driver() is switched
to passing UDC name via usb_gadget_driver struct, it's safe
to remove this function
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/udc/udc-core.c | 26 --
include/linux/usb/gadget.h| 2 --
2
In order to prepare to independent gadgets and
gadget drivers registration in udc-core, some of the
functions can't have __init/__exit attributes (almost
only bind/unbind callbacks are affected)
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/legacy/acm_ms.c | 6 +++---
driver
Introduce new 'udc_name' member to usb_gadget_driver structure.
The 'udc_name' is a name of UDC that usb_gadget_driver should
be bound to. If udc_name is NULL, it will be bound to any
available UDC.
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget
Now when udc-core supports binding to specific UDC by passing
its name via 'udc_name' member of usb_gadget_driver struct,
switch to this generic approach.
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/configfs.c | 27 ++-
1 file changed, 14 inserti
hat became unused
and not needed now
v2:
- changed first patch to have only deferred probe part
(because Gadget Bus seems to be better variant when
some more complicated behavior will be required)
- rebased to latest 'next' branch of Felipe Balbi's tree
Ruslan Bilovol (5):
Hi Andrzej,
On Mon, Feb 16, 2015 at 10:07 AM, Andrzej Pietrasiewicz
wrote:
> W dniu 15.02.2015 o 23:43, Ruslan Bilovol pisze:
>
>
>
>>>
>>> In my opinion all things which you have described are working out-of-box
>>> when you use configfs interfa
Hi Krzysztof,
On Tue, Feb 10, 2015 at 10:47 AM, Krzysztof Opasiak
wrote:
>
>
>> -Original Message-----
>> From: Ruslan Bilovol [mailto:ruslan.bilo...@gmail.com]
>> Sent: Tuesday, February 10, 2015 12:46 AM
>> To: Alan Stern
>> Cc: Krzysztof Opasiak; P
Hi Alan,
On Mon, Feb 9, 2015 at 10:00 PM, Alan Stern wrote:
> On Mon, 9 Feb 2015, Krzysztof Opasiak wrote:
>
>> > Why bother matching by name? Why not simply take the first
>> > available
>> > UDC?
>>
>> Because you may have more than one udc. This would allow to pick one by
>> name just like us
Hi guys,
On Mon, Feb 9, 2015 at 10:00 PM, Alan Stern wrote:
> On Mon, 9 Feb 2015, Krzysztof Opasiak wrote:
>
>> > Why bother matching by name? Why not simply take the first
>> > available
>> > UDC?
>>
>> Because you may have more than one udc. This would allow to pick one by
>> name just like us
Hi Alan,
On Thu, Jan 29, 2015 at 5:56 PM, Alan Stern wrote:
> On Thu, 29 Jan 2015, Ruslan Bilovol wrote:
>
>> Change behavior during registration of gadgets and
>> gadget drivers in udc-core. Instead of previous
>> approach when for successful probe of usb gadget dr
for each gadget driver)
Ruslan Bilovol (2):
usb: gadget: udc-core: independent registration of gadgets and gadget
drivers
usb: gadget: legacy: don't use __init/__exit attributes for
bind/unbind path
drivers/usb/gadget/legacy/acm_ms.c | 6 +-
drivers/usb/gadget/legacy/
stage due to no any UDC added.
Also it is useful for modules case - now there is no
difference what module to insert first: gadget module
or gadget driver one.
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/udc/udc-core.c | 113 +++---
1 file changed, 105
Since it's possible now to do independent gadget and
gadget driver registration in udc-core, some of the
functions can't have __init/__exit attributes (almost
bind/unbind callbacks are affected)
Signed-off-by: Ruslan Bilovol
---
drivers/usb/gadget/legacy/acm_ms.c | 6 +++---
d
Hi Enric
On Wed, Oct 29, 2014 at 1:44 PM, Enric Balletbo Serra
wrote:
>
> Hi all,
>
> 2014-10-26 10:10 GMT+01:00 Angelo Dureghello :
> > Had some progresses:
> >
> > on kernel 3.17, musb controller driver is set to start as OTG mode as
> > default. So as first thing, since my board has ID pin sho
On Thu, Jun 27, 2013 at 10:24 PM, Michael Trimarchi
wrote:
> Hi
>
> On Thu, Jun 27, 2013 at 09:59:35PM +0300, Ruslan Bilovol wrote:
>> Hello guys,
>>
>> On Thu, Jun 27, 2013 at 8:56 PM, Michael Trimarchi
>> wrote:
>> > Hi Roger
>> >
>>
Hello guys,
On Thu, Jun 27, 2013 at 8:56 PM, Michael Trimarchi
wrote:
> Hi Roger
>
> On Thu, Jun 27, 2013 at 05:49:41PM +0300, Roger Quadros wrote:
>> +Ruslan
>>
>> On 06/27/2013 05:17 PM, Michael Trimarchi wrote:
>> > Hi Roger
>> >
>> > On Thu, Jun 27, 2013 at 04:59:38PM +0300, Roger Quadros wro
Hi Frederik,
On Fri, May 10, 2013 at 2:22 PM, Frederik Schmid
wrote:
> Hi Ruslan,
>
> Thanks for the tips! A few comments below:
>
> On Friday 10 May 2013 13.54.53 Ruslan Bilovol wrote:
>> Hello Frederic,
>>
>> On Fri, May 10, 2013 at 12:54 PM, Frederik S
Hello Frederic,
On Fri, May 10, 2013 at 12:54 PM, Frederik Schmid
wrote:
> Well, my conclusion is that this setup, IDS-camera + musb, is horribly
> sensitive to interrupt latency.
>
> If the musb-interrupt is blocked for ~100us the pipe is stalled. Most of the
> interrupts on my target were route
t; >> for USB2.0 devices.
>> >
>> > You mean the usb2.0 musb controller (in device mode) connected to USB3.0
>> host?
>>
>> Correct. USB2.0 musb controller in device mode, connected to USB3.0
>> host that runs
>> USB30CV utility for USB2.0 dev
ean the usb2.0 musb controller (in device mode) connected to USB3.0 host?
Correct. USB2.0 musb controller in device mode, connected to USB3.0
host that runs
USB30CV utility for USB2.0 devices
>
>> Usually 'Addressed state/TD9.1: Device Descriptor Test' will fail
>>
>&
sually 'Addressed state/TD9.1: Device Descriptor Test' will fail
The fix consists in checking CSR0L.DataEnd state and assigning
the device address in the first ep0 interrupt handling, so
delay is as minimal as possible
Signed-off-by: Ruslan Bilovol
---
drivers/usb/musb/musb_gad
mode is slow and it's better
to align buffers properly before passing them to MUSB
This increased throughput 80->120 MBits/s over musb@omap4 with
USB Gigabit Ethernet adapter attached.
Some ideas are taken from ehci-tegra.c
Signed-off-by: Ruslan Bilovol
---
drivers/usb/musb/musb_host.
has been little bit changed
to keep MUSB struct hc_driver as 'const' (as per
Felipe's comments). Verified on top of 3.9-rc4.
Ruslan Bilovol (1):
usb: musb: implement (un)map_urb_for_dma hooks
drivers/usb/musb/musb_host.c | 117 ++
Hi Felipe,
On Wed, Mar 27, 2013 at 3:17 PM, Felipe Balbi wrote:
> Hi,
>
> On Thu, Mar 14, 2013 at 08:12:09PM +0200, Ruslan Bilovol wrote:
>> MUSB controller cannot work in DMA mode with misaligned buffers,
>> switching in PIO mode.
>>
>> HCD core has hooks that
mode is slow and it's better
to align buffers properly before passing them to MUSB
This increased throughput 80->120 MBits/s over musb@omap4 with
USB Gigabit ethernet adapter attached.
Some ideas taken from ehci-tegra.c
Signed-off-by: Ruslan Bilovol
---
drivers/usb/musb/musb_core.
Hi guys,
This is a resend of my patch:
http://permalink.gmane.org/gmane.linux.usb.general/67238
At this moment it has been successfully tested and
used on top of 3.0 and 3.4 kernels on omap4 devices
so it would be great to have it in upstream too.
Regards,
Ruslan
Ruslan Bilovol (1):
usb
1 - 100 of 109 matches
Mail list logo