[PATCH] usb: core: log higher level message on malformed LANGID descriptor

2014-09-25 Thread Scot Doyle
Commit 0cce2eda19923e5e5ccc8b042dec5af87b3ffad0 USB: fix LANGID=0 regression defaults to a langid of 0x0409 if it's not properly implemented by the device. Explain with a higher level error message what this means. Signed-off-by: Scot Doyle lkm...@scotdoyle.com --- drivers/usb/core

[PATCH v2] usb: core: log higher level message on malformed LANGID descriptor

2014-09-25 Thread Scot Doyle
Commit 0cce2eda19923e5e5ccc8b042dec5af87b3ffad0 USB: fix LANGID=0 regression defaults to a langid of 0x0409 if it's not properly implemented by the device. Explain with a higher level error message what this means. Signed-off-by: Scot Doyle lkm...@scotdoyle.com --- drivers/usb/core

Re: [RFC PATCH] usb: core: log more general message on malformed LANGID descriptor

2014-09-24 Thread Scot Doyle
On Tue, 23 Sep 2014, Greg Kroah-Hartman wrote: On Tue, Sep 23, 2014 at 10:28:49PM +, Scot Doyle wrote: I'd like to change this error message: [3.325837] usb 1-4: string descriptor 0 malformed (err = -61), defaulting to 0x0409 into an error message followed by a debug message

Re: [PATCH v2] usb: core: downgrade log severity to info when descriptor unavailable

2014-09-24 Thread Scot Doyle
On Tue, 23 Sep 2014, Greg Kroah-Hartman wrote: On Tue, Sep 23, 2014 at 07:12:40PM +, Scot Doyle wrote: According to commit 0cce2eda19923e5e5ccc8b042dec5af87b3ffad0 USB: fix LANGID=0 regression usb devices are not required to report string descriptors. Since they are optional, log

[PATCH v2] usb: core: downgrade log severity to info when descriptor unavailable

2014-09-23 Thread Scot Doyle
According to commit 0cce2eda19923e5e5ccc8b042dec5af87b3ffad0 USB: fix LANGID=0 regression usb devices are not required to report string descriptors. Since they are optional, log an info message instead of an error message. Signed-off-by: Scot Doyle lkm...@scotdoyle.com --- drivers/usb/core

[RFC PATCH] usb: core: log more general message on malformed LANGID descriptor

2014-09-23 Thread Scot Doyle
I'd like to change this error message: [3.325837] usb 1-4: string descriptor 0 malformed (err = -61), defaulting to 0x0409 into an error message followed by a debug message: [3.324726] usb 1-4: malformed string descriptor; unknown language, defaulting to English [3.327514] usb 1-4:

[PATCH] usb: core: downgrade log severity to info when descriptor missing

2014-09-22 Thread Scot Doyle
to a debug message. Tested with USB device 0930:021c. Signed-off-by: Scot Doyle lkm...@scotdoyle.com --- drivers/usb/core/message.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c index 0c8a7fc..6b95de7