Re: XHCI ISSUE: xhci_hcd: disabling already-disabled device

On Wed, 2019-02-13 at 08:38 +0100, Greg KH wrote: > On Fri, Jan 25, 2019 at 02:45:05PM -0800, Todd Brandt wrote: > > Hi Greg, we run weekly 48-hour S3/S2idle stress tests on each > > release > > candidate, and I found a single instance (out of 2794 runs) of this > > war

Re: XHCI ISSUE: xhci_hcd: disabling already-disabled device

On Mon, 2019-01-28 at 14:39 +0200, Mathias Nyman wrote: > On 26.01.2019 15:57, Greg KH wrote: > > On Sat, Jan 26, 2019 at 02:56:24PM +0100, Greg KH wrote: > > > On Fri, Jan 25, 2019 at 03:02:11PM -0800, Todd Brandt wrote: > > > > Hi Greg, we run weekly 48-hour

XHCI ISSUE: xhci_hcd: disabling already-disabled device

Hi Greg, we run weekly 48-hour S3/S2idle stress tests on each release candidate, and I found a single instance (out of 2794 runs) of this warning on the Lenovo Yoga 920 with linux 5.0.0-rc2 running S3 suspend/resume. I noticed a similar issue in bugzilla and you commented that these issues should

Re: [PATCH v5 1/2] USB: add switch to turn off padding of resume time delays

On Sat, 2017-01-07 at 11:58 -0500, Alan Stern wrote: > On Fri, 6 Jan 2017, Todd Brandt wrote: > > > Add a kernel parameter that replaces the USB_RESUME_TIMEOUT > > and other hardcoded delay numbers with the USB spec minimums. > > > > The USB subsystem currently u

Re: [PATCH v5 1/2] USB: add switch to turn off padding of resume time delays

On Mon, 2017-01-09 at 09:44 +0100, Oliver Neukum wrote: > On Fri, 2017-01-06 at 16:45 -0800, Todd Brandt wrote: > > Add a kernel parameter that replaces the USB_RESUME_TIMEOUT > > and other hardcoded delay numbers with the USB spec minimums. > > Hi, > > the proble

[PATCH v5 0/2] USB: resume time optimization by using spec minimums

test cases illustrating the benefits: - https://01.org/suspendresume/blogs/tebrandt/2016/usb-resume-optimization-using-spec-minimum-delays Todd Brandt (2): USB: add switch to turn off padding of resume time delays USB: usb timing value debug Documentation/admin-guide/kernel-parameter

[PATCH v5 1/2] USB: add switch to turn off padding of resume time delays

Signed-off-by: Todd Brandt --- v2: - moved the core code from hub.c to usb.c - param name is now usb_timing_minimum - configured isp1362-hcd and ohci-hub to use the new values v3: - changed param to usbcore.timing_minimum v4: - moved usb_timing object to usb-common v5: - added tdrstr and used it

[PATCH v5 2/2] USB: usb timing value debug

add debugfs support for experimenting with USB timing delay values on the fly. Values are read/written from debugfs at /sys/kernel/debug/usb/timing. Signed-off-by: Todd Brandt --- v2: - moved the debug code from hub.c to usb.c - use debugfs instead of /sys/kernel/usb v5: - allow setting

Re: [PATCH v4 1/2] USB: add switch to turn off padding of resume time delays

On Wed, 2016-12-14 at 11:36 -0500, Alan Stern wrote: > On Wed, 14 Dec 2016, Todd Brandt wrote: > > > Add a kernel parameter that replaces the USB_RESUME_TIMEOUT > > and other hardcoded delay numbers with the USB spec minimums. > > > > The USB subsystem currently

Re: [PATCH v4 2/2] USB: usb resume time delay values debug

On Wed, 2016-12-14 at 10:33 -0500, Alan Stern wrote: > On Wed, 14 Dec 2016, Todd Brandt wrote: > > > add debugfs support for experimenting with USB timing delay > > values on the fly. Values are read/written from debugfs at > > /sys/kernel/debug/usb/timing. > >

[PATCH v4 0/2] USB: resume time optimization by using spec minimums

usb-resume-optimization-using-spec-minimum-delays Todd Brandt (2): USB: add switch to turn off padding of resume time delays USB: usb resume time delay values debug Documentation/admin-guide/kernel-parameters.txt | 7 +++ drivers/usb/common/common.c | 7 +++ drivers/usb/

[PATCH v4 1/2] USB: add switch to turn off padding of resume time delays

Signed-off-by: Todd Brandt --- v2 changes: - moved the core code from hub.c to usb.c - param name is now usb_timing_minimum - configured isp1362-hcd and ohci-hub to use the new values v3 changes: - changed param to usbcore.timing_minimum v4 changes: - moved usb_timing object to usb-common

[PATCH v4 2/2] USB: usb resume time delay values debug

add debugfs support for experimenting with USB timing delay values on the fly. Values are read/written from debugfs at /sys/kernel/debug/usb/timing. Signed-off-by: Todd Brandt --- v2 changes: - moved the debug code from hub.c to usb.c - use debugfs instead of /sys/kernel/usb drivers/usb/core

[PATCH v3 1/2] USB: add switch to turn off padding of resume time delays

: https://01.org/suspendresume/blogs/tebrandt/2016/usb-resume-optimization-using-spec-minimum-delays Signed-off-by: Todd Brandt --- v2 changes: - moved the core code from hub.c to usb.c - param name is now usb_timing_minimum - configured isp1362-hcd and ohci-hub to use the new values v3 changes

[PATCH v3 2/2] USB: usb resume time delay debug

add debugfs support for experimenting with USB timing delay values on the fly. Values are read/written from debugfs at /sys/kernel/debug/usb/timing. Signed-off-by: Todd Brandt --- drivers/usb/core/usb.c | 55 ++ 1 file changed, 55 insertions

[PATCH v3 0/2] USB: resume time optimization by using spec minimums

usb-resume-optimization-using-spec-minimum-delays Todd Brandt (2): USB: add switch to turn off padding of resume time delays USB: usb resume time delay debug Documentation/admin-guide/kernel-parameters.txt | 7 +++ drivers/usb/core/hub.c | 12 ++--- drivers/usb/

Re: [PATCH v2 0/2] USB: resume time optimization by using spec minimums

e, 2016-12-13 at 17:22 -0800, Todd Brandt wrote: > The USB resume code in the kernel currently uses a set of hard coded > delay values that are defined in the USB 2.0 spec. Specifically these > three have the most effect on resume time: > > - tdrsmdn: resume signal time (20ms - infin

[PATCH v2 0/2] USB: resume time optimization by using spec minimums

usb-resume-optimization-using-spec-minimum-delays Todd Brandt (2): USB: add switch to turn off padding of resume time delays USB: usb resume time delay debug Documentation/admin-guide/kernel-parameters.txt | 7 +++ drivers/usb/core/hub.c | 12 ++--- drivers/usb/

[PATCH v2 2/2] USB: usb resume time delay debug

add debugfs support for experimenting with USB timing delay values on the fly. Values are read/written from debugfs at /sys/kernel/debug/usb/timing. Signed-off-by: Todd Brandt --- v2 changes: - moved the debug code from hub.c to usb.c - use debugfs instead of /sys/kernel/usb drivers/usb/core

[PATCH v2 1/2] USB: add switch to turn off padding of resume time delays

://01.org/suspendresume/blogs/tebrandt/2016/usb-resume-optimization-using-spec-minimum-delays Signed-off-by: Todd Brandt --- v2 changes: - moved the core code from hub.c to usb.c - changed the module param to a core param - param name is now usb_timing_minimum - configured isp1362-hcd and ohci

Re: [PATCH 1/2] USB: turn off padding of resume time delays

On Mon, 2016-12-05 at 12:06 +0200, Felipe Balbi wrote: > Hi, > > Todd Brandt writes: > > Add a module parameter that replaces the USB_RESUME_TIMEOUT > > and other hardcoded delay numbers with the USB spec minimums. > > By default the patch retains the current values

Re: [PATCH 2/2] USB: resume timing debug

On Sat, 2016-12-03 at 12:24 -0500, Alan Stern wrote: > On Fri, 2 Dec 2016, Todd Brandt wrote: > > > Add debug support for experimenting with USB timing delay > > values on the fly. This provides a debug interface through > > /sys/kernel/usb where a user can tweak the value

Re: [PATCH 1/2] USB: turn off padding of resume time delays

On Sat, 2016-12-03 at 12:20 -0500, Alan Stern wrote: > On Fri, 2 Dec 2016, Todd Brandt wrote: > > > Add a module parameter that replaces the USB_RESUME_TIMEOUT > > and other hardcoded delay numbers with the USB spec minimums. > > By default the patch retains the current

Re: [PATCH 2/2] USB: resume timing debug

On Sat, 2016-12-03 at 10:04 +0100, Greg KH wrote: > On Fri, Dec 02, 2016 at 10:37:01PM -0800, Todd Brandt wrote: > > Add debug support for experimenting with USB timing delay > > values on the fly. This provides a debug interface through > > /sys/kernel/usb where a user can

Re: [PATCH 0/2] USB: resume time optimization by using spec minimums

On Sat, 2016-12-03 at 10:05 +0100, Greg KH wrote: > On Fri, Dec 02, 2016 at 10:36:59PM -0800, Todd Brandt wrote: > > The USB resume code in the kernel currently uses a set of hard coded > > delay values that are defined in the USB 2.0 spec. Specifically these > > three ha

[PATCH 1/2] USB: turn off padding of resume time delays

, but if the kernel is booted with usbcore.padding=0 they are set to the spec minimums with no padding. The result is significant performance improvement in usb device resume. Signed-off-by: Todd Brandt --- Documentation/kernel-parameters.txt | 3 +++ drivers/usb/core/hub.c | 27

[PATCH 2/2] USB: resume timing debug

Add debug support for experimenting with USB timing delay values on the fly. This provides a debug interface through /sys/kernel/usb where a user can tweak the values. The code enforces the spec minimums so that a user can't set them too low. Signed-off-by: Todd Brandt --- drivers/usb

[PATCH 0/2] USB: resume time optimization by using spec minimums

with some analyze_suspend test cases illustrating the benefits: - https://01.org/suspendresume/blogs/tebrandt/2016/usb-resume-optimization-using-spec-minimum-delays Todd Brandt (2): USB: turn off padding of resume time delays USB: resume timing debug Documentation/kernel-parameters.txt | 3