RE: [RFC] xhci: free legacy irq in xhci driver.

2014-07-31 Thread Wang, Yu Y
> On Fri, Aug 01, 2014 at 11:00:08AM +0800, Wang, Yu wrote: > > From: "Wang, Yu" > > > > By current xhci ISR request/release flow, the IRQ request be done by > > xhci driver(xhci_run) whatever it is legacy irq or MSI. But the IRQ > > release flow is a little mess, MSI release be handled by xhci >

RE: [Intel-linux-usb] RE: One question about Linux xHCI driver

2014-06-19 Thread Wang, Yu Y
> On Thu, 19 Jun 2014, Wang, Yu Y wrote: > > > > I'm not sure of the right way to solve this problem. Probably > > > xhci_resume() should check the root-hub statuses to see if either > > > root hub really needs to be resumed before calling > > > us

RE: [Intel-linux-usb] RE: One question about Linux xHCI driver

2014-06-18 Thread Wang, Yu Y
> On Wed, 18 Jun 2014, Mathias Nyman wrote: > > > On 06/17/2014 05:17 AM, Wang, Yu Y wrote: > > > > > > Hi All, > > > > > > I have one question about Linux xHCI driver. Need your help to introduce > more backgrounds. > > > About the S3 f

RE: [PATCH 4/4] xhci-plat: Don't enable legacy PCI interrupts.

2013-08-15 Thread Wang, Yu Y
> On Fri, Aug 16, 2013 at 04:01:50AM +0000, Wang, Yu Y wrote: > > > On Fri, Aug 16, 2013 at 02:22:43AM +0000, Wang, Yu Y wrote: > > > > > On Thu, Aug 15, 2013 at 06:43:59PM -0700, Sarah Sharp wrote: > > > > > > The xHCI platform driver calls into usb_ad

RE: [PATCH 4/4] xhci-plat: Don't enable legacy PCI interrupts.

2013-08-15 Thread Wang, Yu Y
> On Fri, Aug 16, 2013 at 02:22:43AM +0000, Wang, Yu Y wrote: > > > On Thu, Aug 15, 2013 at 06:43:59PM -0700, Sarah Sharp wrote: > > > > The xHCI platform driver calls into usb_add_hcd to register the > > > > irq for its platform device. It does not wan

RE: About the hibernation feature implementation in dwc3 driver

2013-08-15 Thread Wang, Yu Y
> > From: Wang, Yu Y [mailto:yu.y.w...@intel.com] > > Sent: Wednesday, August 14, 2013 8:09 PM > > > > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > > Sent: Tuesday, August 13, 2013 1:30 PM > > > > > > > > On Tue, Aug 13

RE: [PATCH 4/4] xhci-plat: Don't enable legacy PCI interrupts.

2013-08-15 Thread Wang, Yu Y
> On Thu, Aug 15, 2013 at 06:43:59PM -0700, Sarah Sharp wrote: > > The xHCI platform driver calls into usb_add_hcd to register the irq > > for its platform device. It does not want the xHCI generic driver to > > register an interrupt for it at all. The original code did that by > > setting the XH

RE: About the hibernation feature implementation in dwc3 driver

2013-08-14 Thread Wang, Yu Y
> > > > > On Mon, Aug 05, 2013 at 03:41:57PM +, Wang, Yu Y wrote: > > > > > Hi Balbi, > > > > > > > > > > Please check the attached logs. The kernel base one kernel3.10. > > > > > > > > you didn't take th

RE: About the hibernation feature implementation in dwc3 driver

2013-08-13 Thread Wang, Yu Y
> > Hi, > > > > On Tue, Aug 13, 2013 at 08:04:26PM +, Paul Zimmerman wrote: > > > > From: Felipe Balbi > > > > Sent: Tuesday, August 13, 2013 12:20 PM > > > > > > > > On Mon, Aug 05, 2013 at 03:41:57PM +, Wang, Yu Y wrote:

RE: About the hibernation feature implementation in dwc3 driver

2013-08-13 Thread Wang, Yu Y
> Hi, > > On Tue, Aug 13, 2013 at 08:04:26PM +, Paul Zimmerman wrote: > > > From: Felipe Balbi > > > Sent: Tuesday, August 13, 2013 12:20 PM > > > > > > On Mon, Aug 05, 2013 at 03:41:57PM +, Wang, Yu Y wrote: > > > > Hi Balbi, &

RE: DWC3 role switch cause IRQ request failed

2013-08-12 Thread Wang, Yu Y
> On Fri, Aug 09, 2013 at 03:16:20PM +0000, Wang, Yu Y wrote: > > > On Fri, Aug 09, 2013 at 01:34:09PM +0000, Wang, Yu Y wrote: > > > > > On Wed, Aug 07, 2013 at 12:03:34PM +, Wang, Yu Y wrote: > > > > > > Hi Balbi, > > > > > >

RE: DWC3 role switch cause IRQ request failed

2013-08-09 Thread Wang, Yu Y
> On Fri, Aug 09, 2013 at 01:34:09PM +0000, Wang, Yu Y wrote: > > > On Wed, Aug 07, 2013 at 12:03:34PM +0000, Wang, Yu Y wrote: > > > > Hi Balbi, > > > > > > > > Because dwc3 driver request_threaded_irq with flags IRQF_ONESHOT > > >

RE: DWC3 role switch cause IRQ request failed

2013-08-09 Thread Wang, Yu Y
> On Wed, Aug 07, 2013 at 12:03:34PM +0000, Wang, Yu Y wrote: > > Hi Balbi, > > > > Because dwc3 driver request_threaded_irq with flags IRQF_ONESHOT and > > IRQF_SHARED. > > But xHCI driver will not set IRQF_ONESHOT. Then will met IRQ request > > failed

RE: xHCI ISR be registered twice

2013-08-08 Thread Wang, Yu Y
> On Thu, Aug 08, 2013 at 03:38:53AM +0000, Wang, Yu Y wrote: > > > Hi Felipe, > > > > > > This patch brings up an interesting point: will a dwc3 PCI host use > > > the xhci platform driver instead of the xhci PCI driver? > > > > > >

RE: [RFT] xhci-plat: Don't enable legacy PCI interrupts.

2013-08-08 Thread Wang, Yu Y
> Hi Yu, > > Please test this patch, and make sure that interrupts aren't registered twice. > I think this approach is better, since it creates a new quirk specifically > for xhci > platform devices, so we can tell them apart from PCI devices. [Yu:] Yes. This patch is working for me. This is one

RE: xHCI ISR be registered twice

2013-08-07 Thread Wang, Yu Y
decide whether we need to apply the patch. If the bug > was only hit with a specific configuration, that needs to be included in the > patch > description, so that distros know whether they need to apply the patch. > [Yu:] Get it. I will provide more details in the comment. > Co

RE: About the hibernation feature implementation in dwc3 driver

2013-08-05 Thread Wang, Yu Y
Hi Balbi, Please check the attached logs. The kernel base one kernel3.10. Thanks, Yu > > > > On Fri, Aug 02, 2013 at 03:42:20PM +0000, Wang, Yu Y wrote: > > > > Hi, > > > > > > > > On Fri, Aug 02, 2013 at 10:54:18AM +, Wang, Yu

RE: About the hibernation feature implementation in dwc3 driver

2013-08-03 Thread Wang, Yu Y
> > Hi, > > On Fri, Aug 02, 2013 at 03:42:20PM +0000, Wang, Yu Y wrote: > > > Hi, > > > > > > On Fri, Aug 02, 2013 at 10:54:18AM +, Wang, Yu Y wrote: > > > > Check my comments as follows. > > > > > > weird, you sent plain t

RE: About the hibernation feature implementation in dwc3 driver

2013-08-02 Thread Wang, Yu Y
> Hi, > > On Fri, Aug 02, 2013 at 10:54:18AM +0000, Wang, Yu Y wrote: > > Check my comments as follows. > > weird, you sent plain text email, but there are no quotation marks... it > makes it > very difficult to read. Please go through our netiquette, there is a c

RE: About the hibernation feature implementation in dwc3 driver

2013-08-02 Thread Wang, Yu Y
Hi Balibi, Check my comments as follows. Thanks, Regards, Yu -Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Friday, August 02, 2013 6:34 PM To: Wang, Yu Y Cc: ba...@ti.com; Li, Jiebing; Linux USB Mailing List; Zhuang, Jin Can; Wu, Hao; Yuan, Hang Subject: Re

RE: About the hibernation feature implementation in dwc3 driver

2013-08-02 Thread Wang, Yu Y
ware initialization during kernel boot. And just use GCTL.PORTCAP to do the role switch. I haven't try this solution on intel platform. And not sure if is working with hibernation feature. Thanks, Regards, Yu -Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Friday, Au