On 12/15/2012 11:12 AM, Bernd Krumböck wrote:
This informations could be useful for configuration scripts. Various
drivers do the same.
Well, could be is not a strong argument. Is there a real use-case? If
not I'm also in favor of removing these entries, as I already said.
Wolfgang.
--
To
:
+ CAN_ERR_CRTL_RX_WARNING;
+ priv-can.can_stats.error_warning++;
+ break;
+ case USB_8DEV_STATUSMSG_BUSHEAVY:
+ priv-can.state = CAN_STATE_ERROR_WARNING;
s/WARNING/PASSIVE/ ?
You can add my Acked-by: Wolfgang Grandegger w...@grandegger.com
Hi Bernd,
still a few issues with error handling.
+/* Send open command to device */
+static int usb_8dev_cmd_open(struct usb_8dev *dev)
+{
+struct can_bittiming *bt = dev-can.bittiming;
+struct usb_8dev_cmd_msg outmsg;
+struct usb_8dev_cmd_msg inmsg;
+u32 flags = 0;
+
On 12/05/2012 05:00 PM, Marc Kleine-Budde wrote:
On 12/05/2012 04:49 PM, Oliver Hartkopp wrote:
On 05.12.2012 11:13, Wolfgang Grandegger wrote:
+outmsg.command = USB_8DEV_OPEN;
+outmsg.opt1 = USB_8DEV_BAUD_MANUAL;
+outmsg.data[0] = (bt-prop_seg + bt-phase_seg1);
Minor issue
On 12/04/2012 09:44 PM, krumbo...@universalnet.at wrote:
Add device driver for USB2CAN interface from 8 devices
(http://www.8devices.com).
Signed-off-by: Bernd Krumboeck krumbo...@universalnet.at
---
drivers/net/can/usb/Kconfig|6 +
drivers/net/can/usb/Makefile |1 +
On 12/04/2012 11:20 PM, Bernd Krumboeck wrote:
Hi Wolfgang!
Am 2012-12-04 21:44, schrieb Wolfgang Grandegger:
On 12/04/2012 09:44 PM, krumbo...@universalnet.at wrote:
Add device driver for USB2CAN interface from 8 devices
(http://www.8devices.com).
Signed-off-by: Bernd Krumboeck krumbo
Hi, at a closer look I see a few more issues:
Please use s/dev_warn(netdev-dev.parent,/netdev_warn(/ for dev_warn and
friends.
You can drop the do_set_bittiming callback if it's not needed. There is
no need for a dummy function, IIRC.
And please also drop the remaining sysfs files for firmware
On 12/03/2012 09:32 PM, krumbo...@universalnet.at wrote:
Hi Wolfgang!
And please also drop the remaining sysfs files for firmware and
hardware. I thinks it's enough that the versions are printed when the
device is probed.
Systemadministrators often use versions for configuration scripts.
On 09/21/2012 11:54 AM, Marc Kleine-Budde wrote:
On 09/20/2012 07:06 AM, Olivier Sobrie wrote:
This driver provides support for several Kvaser CAN/USB devices.
Such kind of devices supports up to three CAN network interfaces.
It has been tested with a Kvaser USB Leaf Light (one network
Hi Oliver,
On 08/08/2012 08:14 AM, Olivier Sobrie wrote:
Hi Wolfgang,
On Tue, Aug 07, 2012 at 08:26:38AM +0200, Wolfgang Grandegger wrote:
On 08/06/2012 07:21 AM, Olivier Sobrie wrote:
This driver provides support for several Kvaser CAN/USB devices.
Such kind of devices supports up
On 08/08/2012 03:30 PM, Olivier Sobrie wrote:
On Wed, Aug 08, 2012 at 10:25:35AM +0200, Wolfgang Grandegger wrote:
Hi Oliver,
On 08/08/2012 08:14 AM, Olivier Sobrie wrote:
Hi Wolfgang,
On Tue, Aug 07, 2012 at 08:26:38AM +0200, Wolfgang Grandegger wrote:
On 08/06/2012 07:21 AM, Olivier
On 08/06/2012 07:21 AM, Olivier Sobrie wrote:
This driver provides support for several Kvaser CAN/USB devices.
Such kind of devices supports up to three can network interfaces.
s/can/CAN/
It has been tested with a Kvaser USB Leaf Light (one network interface)
connected to a pch_can
12 matches
Mail list logo
