David Miller [mailto:da...@davemloft.net]
> Sent: Wednesday, October 30, 2013 5:50 AM
> To: Hayeswang
> Cc: net...@vger.kernel.org; nic_swsd;
> linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org
> Subject: Re: [PATCH net 2/3] r8152: modify the tx flow
>
> From: Hayes
From: David Miller [mailto:da...@davemloft.net]
Sent: Thursday, October 31, 2013 5:05 AM
>
> From: Hayes Wang
> Date: Wed, 30 Oct 2013 15:13:39 +0800
[...]
> Basically, your driver will now queue up to 1,000 packets onto
> this tx_queue list, because that is what tx_queue_len will be
> for alloc
David Miller [mailto:da...@davemloft.net]
> Sent: Tuesday, November 05, 2013 4:53 AM
> To: Hayeswang
> Cc: net...@vger.kernel.org; nic_swsd;
> linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org
> Subject: Re: [PATCH net v2 2/3] r8152: modify the tx flow
[...]
> The mor
David Miller [mailto:da...@davemloft.net]
> Sent: Saturday, November 16, 2013 6:40 AM
> To: Hayeswang
> Cc: net...@vger.kernel.org; nic_swsd;
> linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org
> Subject: Re: [PATCH net v3 1/4] r8152: fix tx/rx memory overflow
>
> Fro
David Miller [mailto:da...@davemloft.net]
[...]
> This is racy.
>
> You have nothing which synchronizes r8152_tx_agg_fill() and
> rtl8152_start_xmit(),
> therefore:
>
> > + if (netif_queue_stopped(tp->netdev))
> > + netif_wake_queue(tp->netdev);
> > +
>
> A netif_stop_queue() can
David Miller [mailto:da...@davemloft.net]
[...]
> > If the situation occurs, it means there is no tx buffer at
> that time. If the
> > netif_wake_queue() is called, only one more packet would be
> queued and the tx
> > queue would be stopped again after calling
> rtl8152_start_xmit(). That is,
Oliver Neukum [mailto:oneu...@suse.de]
> Sent: Tuesday, August 13, 2013 4:49 PM
> To: Hayeswang
> Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;
> linux-usb@vger.kernel.org
> Subject: Re: [PATCH net-next 1/3] net/usb/r8152: support aggregation
>
[...]
> >
David Miller [mailto:da...@davemloft.net]
> Sent: Wednesday, August 14, 2013 7:41 AM
> To: oneu...@suse.de
> Cc: Hayeswang; net...@vger.kernel.org;
> linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org
> Subject: Re: [PATCH net-next 1/3] net/usb/r8152: support aggregation
Francois Romieu [mailto:rom...@fr.zoreil.com]
> Sent: Thursday, August 15, 2013 8:26 PM
> To: Hayeswang
> Cc: net...@vger.kernel.org; nic_swsd;
> linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org; David Miller
> Subject: Re: [PATCH net-next v2 1/3] net/usb/r8152: support
Some USB buffers use stack which may not be DMA-able.
Use the buffers from kmalloc to replace those one.
Signed-off-by: Hayes Wang
---
drivers/net/usb/r815x.c | 44 +++-
1 file changed, 27 insertions(+), 17 deletions(-)
diff --git a/drivers/net/usb/r815
Allocate the required memory before calling usb_control_msg. And
the additional memory copy is necessary.
Signed-off-by: Hayes Wang
---
drivers/net/usb/r8152.c | 60 -
1 file changed, 35 insertions(+), 25 deletions(-)
diff --git a/drivers/net/usb/
- fix the conversion between cpu and __le32
- replace some pla_ocp and usb_ocp functions with generic_ocp function
Signed-off-by: Hayes Wang
---
drivers/net/usb/r8152.c | 66 +
1 file changed, 23 insertions(+), 43 deletions(-)
diff --git a/drive
Oliver Neukum [mailto:oneu...@suse.de]
> Sent: Friday, April 26, 2013 7:57 PM
> To: Hayeswang
> Cc: gre...@linuxfoundation.org; net...@vger.kernel.org;
> linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org; nic_swsd
> Subject: Re: [PATCH net-next] net/usb: new dri
Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Friday, May 03, 2013 10:33 AM
> To: Hayeswang
> Cc: oli...@neukum.org; net...@vger.kernel.org;
> linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org; nic_swsd
> Subject: Re: [PATCH v3 net-next] net/usb: new driver for RTL8
Any response?
> -Original Message-
> From: Hayeswang [mailto:hayesw...@realtek.com]
> Sent: Wednesday, November 20, 2013 5:31 PM
> To: net...@vger.kernel.org
> Cc: nic_swsd; linux-ker...@vger.kernel.org;
> linux-usb@vger.kernel.org; Hayeswang
> Subject: [PATCH
Bjørn Mork [mailto:bj...@mork.no]
> Sent: Thursday, January 02, 2014 10:25 PM
> To: Hayeswang
> Cc: oli...@neukum.org; net...@vger.kernel.org; nic_swsd;
> linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org
> Subject: Re: [PATCH net-next v2 6/6] r8152: support RTL8153
&g
David Miller [mailto:da...@davemloft.net]
> Sent: Saturday, January 04, 2014 9:38 AM
> To: Hayeswang
> Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;
> linux-usb@vger.kernel.org
> Subject: Re: [PATCH net-next] r8152: fix the wrong return value
>
> From: Hayes
Bjørn Mork [mailto:bj...@mork.no]
[...]
> Sorry, but then this makes even less sense. The active USB
> configuration is user selectable and you should make any of
> them work if
> possible. Why can't the drivers figure out this at runtime?
Excuse me. I have no idea about how to switch the con
Bjørn Mork [mailto:bj...@mork.no]
> Sent: Monday, January 06, 2014 5:22 PM
> To: Hayeswang
> Cc: oli...@neukum.org; net...@vger.kernel.org; nic_swsd;
> linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org
> Subject: Re: [PATCH net-next v2 6/6] r8152: support RTL8153
[...]
>
Florian Fainelli [mailto:f.faine...@gmail.com]
> Sent: Wednesday, February 19, 2014 1:19 AM
> To: Hayes Wang
> Cc: netdev; nic_s...@realtek.com;
> linux-ker...@vger.kernel.org; linux-usb
> Subject: Re: [PATCH net-next 07/14] r8152: combine PHY reset
> with set_speed
[...]
> > +static void rtl_p
Francois Romieu [mailto:rom...@fr.zoreil.com]
> Sent: Wednesday, February 19, 2014 7:29 AM
> To: Hayes Wang
> Cc: net...@vger.kernel.org; nic_s...@realtek.com;
> linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org
> Subject: Re: [PATCH net-next 12/14] r8152: replace netif_rx
> withnetif_rec
Francois Romieu [mailto:rom...@fr.zoreil.com]
> Sent: Wednesday, February 19, 2014 3:47 PM
> To: hayeswang
> Cc: net...@vger.kernel.org; nic_s...@realtek.com;
> linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org
> Subject: Re: [PATCH net-next 12/14]
David Laight [mailto:david.lai...@aculab.com]
> Sent: Tuesday, March 04, 2014 8:12 PM
> To: 'Hayes Wang'; net...@vger.kernel.org
> Cc: nic_s...@realtek.com; linux-ker...@vger.kernel.org;
> linux-usb@vger.kernel.org
> Subject: RE: [PATCH net-next 08/12] r8152: support TSO
>
> From: Hayes Wang
>
David Miller [mailto:da...@davemloft.net]
> Sent: Saturday, March 08, 2014 5:28 AM
> To: hayesw...@realtek.com
> Cc: net...@vger.kernel.org; nic_s...@realtek.com;
> linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org
> Subject: Re: [PATCH net-next 0/7] r8152: tx/rx improvement
[...]
> Note t
From: David Miller [mailto:da...@davemloft.net]
Sent: Friday, March 14, 2014 1:22 AM
[...]
> And I fundamentally disagree with this being a Kconfig parameter.
>
> Make it run-time calculated _or_ settable via ethtool.
Excuse me. How should I make it run-time calculated without a
Kconfig parame
From: David Miller [mailto:da...@davemloft.net]
Sent: Friday, March 14, 2014 12:08 PM
[...]
> >> And I fundamentally disagree with this being a Kconfig parameter.
> >>
> >> Make it run-time calculated _or_ settable via ethtool.
> >
> > Excuse me. How should I make it run-time calculated withou
From: David Miller [mailto:da...@davemloft.net]
> Sent: Saturday, March 15, 2014 2:43 AM
[...]
> > Besides, I don't wish to modify the setting by ethtool when re-loading
> > the driver or rebooting every time.
>
> You have code to reset the driver, you can do it when the user asks
> for the sett
From: Francois Romieu [mailto:rom...@fr.zoreil.com]
> Sent: Saturday, March 15, 2014 7:43 AM
[...]
> > Besides, I don't wish to modify the setting by ethtool when re-loading
> > the driver or rebooting every time.
>
> Why ?
>
> The recipe is different but there isn't much setup difference
> be
Grant Grundler [mailto:grund...@google.com]
> Sent: Wednesday, March 26, 2014 4:12 AM
[...]
> Hayes,
> I believe this patch was dropped after the series was split.
> Can you please repost this patch by itself?
There is no problem for current behavior, and I don't get the
issue of tx timeout, yet
29 matches
Mail list logo
