Re: [RFC][PATCH 0/4 v4] usb: host: ehci-platform: add platform specific .power callback

2012-08-06 Thread kuninori . morimoto . gx
Hi Alan, Felipe, Greg These are v4 of ehci/ohci-platform patches Kuninori Morimoto (4): usb: host: ehci-platform: BUG_ON() to WARN_ON() on probe usb: host: ohci-platform: BUG_ON() to WARN_ON() on probe usb: host: ehci-platform: add platform specific power callback usb: ho

[RFC][PATCH 4/4 v3] usb: host: ohci-platform: add platform specific power callback

2012-08-05 Thread kuninori . morimoto . gx
This patch enables to call platform specific power callback function. Signed-off-by: Kuninori Morimoto --- v2 -> v3 - add power multi functions - call it by macro drivers/usb/host/ohci-platform.c | 36 +--- include/linux/usb/ohci_pdriver.h |5 + 2 fi

[RFC][PATCH 3/4 v3] usb: host: ehci-platform: add platform specific power callback

2012-08-05 Thread kuninori . morimoto . gx
This patch enables to call platform specific power callback function. Signed-off-by: Kuninori Morimoto --- v2 -> v3 - add power multi functions - call it by macro drivers/usb/host/ehci-platform.c | 40 ++--- include/linux/usb/ehci_pdriver.h |5 2 fi

[RFC][PATCH 2/4 v3] usb: host: ohci-platform: BUG_ON() to WARN_ON() on probe

2012-08-05 Thread kuninori . morimoto . gx
We should avoid using BUG_ON() in drivers. This patch switch to use WARN_ON() from BUG_ON(), and avoid NULL pointer access by new macro. Signed-off-by: Kuninori Morimoto --- v2 -> v3 - BUG_ON -> WARN_ON drivers/usb/host/ohci-platform.c | 10 ++ 1 files changed, 6 insertions(+), 4 de

[RFC][PATCH 1/4 v3] usb: host: ehci-platform: BUG_ON() to WARN_ON() on probe

2012-08-05 Thread kuninori . morimoto . gx
We should avoid using BUG_ON() in drivers. This patch switch to use WARN_ON() from BUG_ON(), and avoid NULL pointer access by new macro. Signed-off-by: Kuninori Morimoto --- v2 -> v3 - BUG_ON -> WARN_ON drivers/usb/host/ehci-platform.c | 18 ++ 1 files changed, 10 insertions

Re: [RFC][PATCH 0/4 v3] usb: host: ehci-platform: add platform specific .power callback

2012-08-05 Thread kuninori . morimoto . gx
Hi Alan, Felipe, Greg These are v3 of ehci/ohci-platform patches Kuninori Morimoto (4): usb: host: ehci-platform: BUG_ON() to WARN_ON() on probe usb: host: ohci-platform: BUG_ON() to WARN_ON() on probe usb: host: ehci-platform: add platform specific power callback usb: ho

[RFC][PATCH 2/2 v2] usb: host: ohci-platform: add platform specific .power callback

2012-08-02 Thread kuninori . morimoto . gx
This patch enables to call platform specific power callback function. Signed-off-by: Kuninori Morimoto --- drivers/usb/host/ohci-platform.c | 29 ++--- include/linux/usb/ohci_pdriver.h |2 ++ 2 files changed, 28 insertions(+), 3 deletions(-) diff --git a/drivers/us

[RFC][PATCH 1/2 v2] usb: host: ehci-platform: add platform specific .power callback

2012-08-02 Thread kuninori . morimoto . gx
This patch enables to call platform specific power callback function. Signed-off-by: Kuninori Morimoto --- drivers/usb/host/ehci-platform.c | 33 + include/linux/usb/ehci_pdriver.h |2 ++ 2 files changed, 31 insertions(+), 4 deletions(-) diff --git a/driver

Re: [RFC][PATCH v2] usb: host: ehci-platform: add pm_runtime_xx()

2012-08-02 Thread kuninori . morimoto . gx
Hi Alan, Felipe, Greg These are v2 of ehci/ohci-platform patches. These are based on latest linus/master (and linux-next/mastere) I tested these patches on R-Car H1 marzen board. But I couldn't test suspend/resume. So, I added [RFC] on this patch. Please check these patches carefully Kuninori M

Re: [PATCH] usb: host: ehci-platform: add pm_runtime_xx()

2012-08-01 Thread kuninori . morimoto . gx
Hi Alan, Rafael, Magnus Thank you for your reply > The problem is that the ehci-platform driver currently doesn't know > anything about clocks or power sources. We need to add that > information in a generic fashion, somehow. Until that's done, you > can't really use ehci-platform as your driv