Re: [PATCH] staging: usbip: Fix build on Debian ppc

2013-09-19 Thread navin patidar
covered that dma_mask is only set on PowerPC > at the moment (in arch/powerpc/kernel/setup-common.c, > arch_setup_pdev_archdata()). > > All of our testing was done in QEMU emulating Debian on POWER7. > I have already submitted a patch to remove mentioned code block. patch link : ht

[PATCH 2/3] staging: usbip: vhci_hcd: correctly handle return value

2013-09-09 Thread navin patidar
ret == 0 means success, anything else is failure. Signed-off-by: navin patidar --- drivers/staging/usbip/vhci_hcd.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c index d7974cb..b3c9217 100644 --- a

[PATCH 1/3] staging: usbip: stub_main: correctly handle return value

2013-09-09 Thread navin patidar
ret == 0 means success, anything else is failure. Signed-off-by: navin patidar --- drivers/staging/usbip/stub_main.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/usbip/stub_main.c b/drivers/staging/usbip/stub_main.c index 33027cc..baf857f 100644

[PATCH 3/3] staging: usbip: vhci_hcd: remove check for dma

2013-09-09 Thread navin patidar
vhci_hcd is a virtual usb host controller, so no need to check for dma. Signed-off-by: navin patidar --- drivers/staging/usbip/vhci_hcd.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c index b3c9217..e810ad5 100644

Re: [PATCH v4] staging: usbip: replace pr_warning() with dev_warn().

2013-07-25 Thread navin patidar
On Thu, Jul 25, 2013, Greg KH said: > On Thu, Jul 25, 2013 at 10:19:31AM +0530, navin patidar wrote: >> >> -pr_warning("Unable to start control thread\n"); >> >> +struct device *dev; >> >> + >> >> +if (ud-&

Re: [PATCH v4] staging: usbip: replace pr_warning() with dev_warn().

2013-07-24 Thread navin patidar
On Wed, Jul 24, 2013, Greg KH said: > On Thu, Jun 27, 2013 at 03:34:52PM +0530, navin patidar wrote: >> dev_warn() is preferred over pr_warning(). >> >> container_of() is used to get usb_driver pointer from usbip_device container >> (stub_device or vhci_device), to ge

[PATCH v4] staging: usbip: replace pr_warning() with dev_warn().

2013-06-27 Thread navin patidar
dev_warn() is preferred over pr_warning(). container_of() is used to get usb_driver pointer from usbip_device container (stub_device or vhci_device), to get device structure required for dev_warn(). Signed-off-by: navin patidar --- drivers/staging/usbip/usbip_event.c | 11 ++- 1 file

[PATCH v3] staging: usbip: replace pr_warning() with dev_warn().

2013-06-26 Thread navin patidar
dev_warn() is preferred over pr_warning(). container_of() is used to get usb_driver pointer from usbip_device container (stub_device or vhci_device), to get device structure required for dev_warn(). Signed-off-by: navin patidar --- drivers/staging/usbip/usbip_event.c | 17

[PATCH v2] staging: usbip: replace pr_warning() with dev_warn().

2013-06-26 Thread navin patidar
dev_warn() is preferred over pr_warning(). container_of() is used to get usb_driver pointer from usbip_device container (stub_device or vhci_device), to get device structure required for dev_warn(). Signed-off-by: navin patidar --- drivers/staging/usbip/usbip_event.c | 14 +- 1

Re: [PATCH] staging: usbip: replace pr_warning() with pr_warn()

2013-06-25 Thread navin patidar
On Tue, Jun 25, 2013, Greg KH said: > On Tue, Jun 25, 2013 at 04:27:18PM +0530, navin patidar wrote: >> On Tue, Jun 25, 2013, Greg KH said: >> >> > On Fri, Jun 21, 2013 at 03:01:04PM +0530, navin patidar wrote: >> >> pr_warn() is preferred over pr_wa

[no subject]

2013-06-25 Thread navin patidar
On Tue, Jun 25, 2013, Greg KH said: > On Tue, Jun 25, 2013 at 04:27:18PM +0530, navin patidar wrote: >> On Tue, Jun 25, 2013, Greg KH said: >> >> > On Fri, Jun 21, 2013 at 03:01:04PM +0530, navin patidar wrote: >> >> pr_warn() is preferred over pr_wa

Re: [PATCH] staging: usbip: replace pr_warning() with pr_warn()

2013-06-25 Thread navin patidar
On Tue, Jun 25, 2013, Greg KH said: > On Fri, Jun 21, 2013 at 03:01:04PM +0530, navin patidar wrote: >> pr_warn() is preferred over pr_warning(). > > And dev_warn() is preferred over both of them, can you convert the code > to use that instead? > struct device is not availa

[PATCH] staging: usbip: replace pr_warning() with pr_warn()

2013-06-21 Thread navin patidar
pr_warn() is preferred over pr_warning(). Signed-off-by: navin patidar --- drivers/staging/usbip/usbip_event.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/usbip/usbip_event.c b/drivers/staging/usbip/usbip_event.c index 82123be..64933b9 100644 --- a

[PATCH v2] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

2012-09-19 Thread navin patidar
70353] RSP [ 1504.370354] CR2: [ 1504.401376] ---[ end trace 1971ce612a16727a ]--- Signed-off-by: navin patidar --- drivers/staging/usbip/stub_dev.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/usbip/stub_dev.c b/drivers/staging/usbip

[PATCH v2] staging: usbip: vhci_hcd: Fixed oops during removal of vhci_hcd

2012-09-19 Thread navin patidar
00 00 00 00 f0 ff 0f 0f 94 c0 84 c0 [ 312.229663] RIP [] exit_creds+0x1f/0x70 [ 312.231696] RSP [ 312.233648] CR2: [ 312.256464] ---[ end trace 1971ce612a167279 ]--- Signed-off-by: navin patidar --- drivers/staging/usbip/vhci_hcd.c |9 ++--- 1 file changed, 6 inser

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

2012-09-18 Thread navin patidar
set pointers to NULL in stub_shutdown_connection() but i used stub_device_reset() which is intended to reset usbip_device stuct member variables. i'll resend patches, if maintainer ask for that. thanks --navin-patidar On Tue, Sep 18, 2012 at 3:06 PM, Dan Carpenter wrote: > On Tue, Sep 18, 2012 a

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

2012-09-18 Thread navin patidar
On Tue, Sep 18, 2012 at 1:10 PM, Dan Carpenter wrote: > On Tue, Sep 18, 2012 at 09:30:06AM +0530, navin patidar wrote: >> stub_device_reset should set kernel thread pointers to NULL. >> so that at the time of usbip_host removal stub_shoutdown_connection >> doesn't try to

[PATCH] staging: usbip: vhci_hcd: Fixed oops during removal of vhci_hcd

2012-09-17 Thread navin patidar
cd removal vhci_shoutdown_connection tries to kill kernel threads which are already killed. Signed-off-by: navin patidar --- drivers/staging/usbip/vhci_hcd.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c index 12a9a5f..eea8298 100644 ---

[PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

2012-09-17 Thread navin patidar
stub_device_reset should set kernel thread pointers to NULL. so that at the time of usbip_host removal stub_shoutdown_connection doesn't try to kill kernel threads which are already killed. Signed-off-by: navin patidar --- drivers/staging/usbip/stub_dev.c |7 --- 1 file chang

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

2012-09-14 Thread navin patidar
hi, I have sent this patch again with corrections. thank for reviewing the patch. --navin-patidar On 9/14/12, Sebastian Andrzej Siewior wrote: > On Fri, Sep 14, 2012 at 03:42:42PM +0400, Sergei Shtylyov wrote: >> >diff --git a/drivers/staging/usbip/stub_dev.c >> > b/

[PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

2012-09-14 Thread navin patidar
stub_device_reset should set kernel thread pointers to NULL. so that at the time of usbip_host removal stub_shoutdown_connection doesn't try to kill kernel threads which are already killed. Signed-off-by: navin patidar --- drivers/staging/usbip/stub_dev.c |7 --- 1 file chang

[PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

2012-09-14 Thread navin patidar
stub_device_reset should set kernel thread pointers to NULL. so that at the time of usbip_host removal stub_shoutdown_connection doesn't try to kill kernel threads which are already killed. Signed-off-by: navin patidar --- drivers/staging/usbip/stub_dev.c | 14 +- 1 file ch

[PATCH] staging: usbip: vhci_hcd: Fixed oops during removal of vhci_hcd

2012-09-14 Thread navin patidar
cd removal vhci_shoutdown_connection tries to kill kernel threads which are already killed. Signed-off-by: navin patidar --- drivers/staging/usbip/vhci_hcd.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c index 6076f42..b1f427c 100644 ---

[PATCH] staging: usbip: vhci_hcd: fixed suspend-resume loop

2012-09-06 Thread navin patidar
, again autosuspend puts it in suspend state and this goes on. vhci_hub_status should resume hub only when hub port is in suspend state and hub port status has changed. Signed-off-by: navin patidar --- drivers/staging/usbip/vhci_hcd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff