Re: [PATCH] Documentation: usb: the dumb conversion to Sphinx

2016-10-24 Thread Oliver Neukum
On Thu, 2016-10-20 at 10:29 -0600, Jonathan Corbet wrote: > On Thu, 20 Oct 2016 18:22:28 +0200 > Oliver Neukum wrote: > > > > Why does this not remove the .tmpl file? > > > > 1. We might want to keep it > > 2. It is an operation beyond the scope of this

Re: [PATCH v2 0/4] ch341 cleanup and parity etc support

2016-10-23 Thread Oliver Neukum
it looks like your patch #2 should also go into stable. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] USB: update intro of documentation

2016-10-21 Thread Oliver Neukum
On Fri, 2016-10-21 at 15:17 -0600, Jonathan Corbet wrote: > On Thu, 20 Oct 2016 15:15:00 +0200 > Oliver Neukum wrote: > > > It does no good to mention The 2.4 kernel series and neglect > > USB 3.x and XHCI. Also with type C and micro/mini USB we better > > not talk ab

Re: [PATCH] Documentation: usb: the dumb conversion to Sphinx

2016-10-20 Thread Oliver Neukum
On Thu, 2016-10-20 at 18:04 +0300, Jani Nikula wrote: > On Thu, 20 Oct 2016, Oliver Neukum wrote: Hi, > > This just is the result of the conversion script and its addition > > to the index. Just the plain automatic conversion. > > How does this relate to [1]? It is the

[PATCH] Documentation: usb: the dumb conversion to Sphinx

2016-10-20 Thread Oliver Neukum
This just is the result of the conversion script and its addition to the index. Just the plain automatic conversion. Signed-off-by: Oliver Neukum --- Documentation/index.rst | 1 + Documentation/usb/conf.py | 5 + Documentation/usb/usb.rst | 750

[PATCH] USB: update intro of documentation

2016-10-20 Thread Oliver Neukum
It does no good to mention The 2.4 kernel series and neglect USB 3.x and XHCI. Also with type C and micro/mini USB we better not talk about the shape of connectors. Signed-off-by: Oliver Neukum --- Documentation/DocBook/usb.tmpl | 68 +++--- 1 file changed

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-10-18 Thread Oliver Neukum
On Mon, 2016-10-17 at 17:20 +0200, Wim Osterholt wrote: > On Mon, Oct 17, 2016 at 04:10:45PM +0200, Oliver Neukum wrote: > > Hi, > > > > I got one of those devices. However, I don't get a crash. > > Could you please give me instructions on how you trigger it?

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-10-17 Thread Oliver Neukum
On Thu, 2016-09-08 at 14:58 +0200, Wim Osterholt wrote: > On Thu, Sep 08, 2016 at 02:20:38PM +0200, Oliver Neukum wrote: > > > > > > The oops tells things that I didn't all write down, but it says > > > null pointer dereference at 0246 > > > &

Re: USB crash on BeagleBoard-xM

2016-10-17 Thread Oliver Neukum
On Fri, 2016-10-14 at 01:16 +0100, Snaper wrote: > Hi Oliver, > > On 10/10/2016 08:19, Oliver Neukum wrote: > > it is very hard for us to say something about that specific kernel. > > We don't know the kernel tree. And the error seems to be in the OF > > code. I

Re: USB crash on BeagleBoard-xM

2016-10-10 Thread Oliver Neukum
tree. And the error seems to be in the OF code. I think you are in the wrong list, or can you reproduce teh problem with a mainline kernel? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a messa

Re: Fwd: HSO driver patch

2016-10-07 Thread Oliver Neukum
ee whether he reads this list. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Fwd: HSO driver patch

2016-10-07 Thread Oliver Neukum
one, > plese advise me which one. Hi, patches need to go to the maintainer and the list. Please repost them to the list and if the maintainer still doesnät answer we will need to bother Greg. HTH Oliver -- To unsubscribe from this list: send the line "unsubscr

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-10-06 Thread Oliver Neukum
On Thu, 2016-09-29 at 15:26 +0200, Wim Osterholt wrote: > On Wed, Sep 28, 2016 at 05:23:30PM +0200, Oliver Neukum wrote: > > > > > > HP src # sync > > > HP src # [ 3744.914184] BUG: unable to handle kernel NULL pointer > > > dereference at 0249 > >

Re: [PATCH] USB: serial: ftdi_sio: add support for Infineon TriBoard TC2X7

2016-10-06 Thread Oliver Neukum
and do an independent post and all will be well. HTH Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: USB hot-plug not working (ASUS TP301UA-C4028T)

2016-10-06 Thread Oliver Neukum
k that specific combination. But why put the code for a potentially common problem into xhci? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] USB: serial: ftdi_sio: add support for Infineon TriBoard TC2X7

2016-10-05 Thread Oliver Neukum
On Wed, 2016-10-05 at 10:29 +0200, Stefan Tauner wrote: > On Wed, 05 Oct 2016 09:31:29 +0200 > Oliver Neukum wrote: > > > On Fri, 2016-09-30 at 17:39 +0200, Stefan Tauner wrote: > > > Signed-off-by: Stefan Tauner > > > > A minimal change log entry w

Re: [PATCH] USB: serial: ftdi_sio: add support for Infineon TriBoard TC2X7

2016-10-05 Thread Oliver Neukum
On Fri, 2016-09-30 at 17:39 +0200, Stefan Tauner wrote: > Signed-off-by: Stefan Tauner A minimal change log entry would be good. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vg

request for testers

2016-09-28 Thread Oliver Neukum
Hi, does anybody here want to test patches to improve UAS error handling? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-09-28 Thread Oliver Neukum
On Wed, 2016-09-28 at 17:08 +0200, Wim Osterholt wrote: > On Wed, Sep 28, 2016 at 11:16:04AM +0200, Oliver Neukum wrote: > > this should show you where it crashes. In addition I've attached > > a patch with paranoid debugging. Could you compile and test a kernel > > wit

Re: usbtmc: vendor specific i/o

2016-09-28 Thread Oliver Neukum
need to check "zombie" in open() or you open up to another race. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-09-28 Thread Oliver Neukum
On Tue, 2016-09-27 at 18:34 +0200, Wim Osterholt wrote: > On Thu, Sep 22, 2016 at 04:40:50PM +0200, Oliver Neukum wrote: > > > > dmesg -c > > echo 9 > /proc/sysrq-trigger > > modprobe cdc_acm > > echo "module cdc_acm +mpf" > /sys/kernel/debug/dy

Re: [Umap2][7/11][160a:3184] NULL pointer dereference

2016-09-26 Thread Oliver Neukum
On Mon, 2016-09-26 at 18:57 +0100, Malcolm Priestley wrote: > > On 26/09/16 09:48, Oliver Neukum wrote: > > On Sat, 2016-09-24 at 01:21 +0100, Malcolm Priestley wrote: > >> > >> On 22/09/16 20:50, Malcolm Priestley wrote: > >>> > >>> >

Re: [umap2] status of issues

2016-09-26 Thread Oliver Neukum
.c open Is that correct? And do we need more fixes for the stable trees? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Umap2][7/11][160a:3184] NULL pointer dereference

2016-09-26 Thread Oliver Neukum
On Sat, 2016-09-24 at 01:21 +0100, Malcolm Priestley wrote: > > On 22/09/16 20:50, Malcolm Priestley wrote: > > > > > > On 22/09/16 15:25, Oliver Neukum wrote: > >> On Thu, 2016-09-22 at 14:46 +0300, Binyamin Sharet wrote: > >> > >>>> -- B

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-09-22 Thread Oliver Neukum
On Wed, 2016-09-21 at 18:41 +0200, Wim Osterholt wrote: > On Wed, Sep 21, 2016 at 02:21:17PM +0200, Oliver Neukum wrote: > > in sysfs. > > Google pointed me to /sys/bus/usb/drivers/usb/* > where I find all kinds of 'bConfigurationValue'. > Now is the problem t

Re: [Umap2][7/11][160a:3184] NULL pointer dereference

2016-09-22 Thread Oliver Neukum
tch? Regards Oliver From e0f6d09babd9f30d952389ff98a2a25df9a158a5 Mon Sep 17 00:00:00 2001 From: Oliver Neukum Date: Thu, 22 Sep 2016 16:22:06 +0200 Subject: [PATCH] vt6656: avoid double free This data structure is fred in disconnect(). It must not be freed earlier. Signed-off-by: Oliver

Re: [PATCH] mmc: rtsx_usb_sdmmc: Handle runtime PM while changing led

2016-09-22 Thread Oliver Neukum
On Wed, 2016-09-21 at 10:35 -0400, Alan Stern wrote: > On Wed, 21 Sep 2016, Oliver Neukum wrote: > > Yes, but this is not the point. A heuristic with a timeout makes > > sense only if the uses are unpredictable. If you know with a high > > degree of probability when the nex

Re: [Umap2][7/11][160a:3184] NULL pointer dereference

2016-09-22 Thread Oliver Neukum
On Thu, 2016-09-22 at 14:46 +0300, Binyamin Sharet wrote: > On Thu, Sep 22, 2016 at 11:18 AM, Binyamin Sharet > wrote: > > On Thu, Sep 22, 2016 at 11:02 AM, Oliver Neukum wrote: > >> On Thu, 2016-09-22 at 10:50 +0300, Binyamin Sharet wrote: > >>> On Thu, Sep 22

Re: [Umap2][7/11][160a:3184] NULL pointer dereference

2016-09-22 Thread Oliver Neukum
On Thu, 2016-09-22 at 10:50 +0300, Binyamin Sharet wrote: > On Thu, Sep 22, 2016 at 10:35 AM, Oliver Neukum wrote: > > On Thu, 2016-09-22 at 09:53 +0300, Binyamin Sharet wrote: > >> On Wed, Sep 21, 2016 at 11:09 PM, Malcolm Priestley > >> wrote: > >> > &g

Re: [Umap2][7/11][160a:3184] NULL pointer dereference

2016-09-22 Thread Oliver Neukum
you prepare a test kernel without BPF? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Umap2][7/11][160a:3184] NULL pointer dereference

2016-09-21 Thread Oliver Neukum
On Thu, 2016-08-18 at 13:50 +0300, Binyamin Sharet wrote: > On 08/18/2016 01:31 PM, Oliver Neukum wrote: > > On Wed, 2016-08-17 at 14:34 +0300, Binyamin Sharet wrote: > >>> After connecting such a device, NULL pointer dereference in the > >> kernel. > >>>

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-09-21 Thread Oliver Neukum
On Tue, 2016-09-20 at 17:45 +0200, Wim Osterholt wrote: > On Tue, Sep 20, 2016 at 03:05:14PM +0200, Oliver Neukum wrote: > > > > I cannot replicate it. Could you please provide "lsusb -v"? > > > > Regards > > Oliver > > It concer

Re: [PATCH] mmc: rtsx_usb_sdmmc: Handle runtime PM while changing led

2016-09-21 Thread Oliver Neukum
On Tue, 2016-09-20 at 10:12 -0400, Alan Stern wrote: > On Tue, 20 Sep 2016, Oliver Neukum wrote: > That shouldn't be an issue in this case, at least, not with the current > code. The sdmmc and memstick drivers block autosuspend if media is > present. Good. > &g

[PATCH] cdc-acm: hardening against malicious devices

2016-09-20 Thread Oliver Neukum
This should fix the last holes against malicious devices still open in cdc-acm. It cannot go into stable due to the introduction of the common parser. The fix for stable already merged also covers the problems this patch fixes. Signed-off-by: Oliver Neukum --- drivers/usb/class/cdc-acm.c | 5

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-09-20 Thread Oliver Neukum
ease provide "lsusb -v"? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: 4.8-rc: runtime PM trying to activate child device host6 but parent (2-1.2:1.0) is not active

2016-09-20 Thread Oliver Neukum
to activate child device host6 but parent > (2-1.2:1.0) is not active I see no obvious culprit. Could you bisect? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.o

Re: [PATCH] mmc: rtsx_usb_sdmmc: Handle runtime PM while changing led

2016-09-20 Thread Oliver Neukum
mmediately suspended. The timer is sensible only if the next wakeup is unknown. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: USB hot-plug not working (ASUS TP301UA-C4028T)

2016-09-20 Thread Oliver Neukum
On Tue, 2016-09-20 at 20:58 +1200, Pierre de Villemereuil wrote: > Hi Oliver! > > Here you are. > > dmesg signals when plugging AC in: > http://paste.opensuse.org/57485b34 > > dmesg signals when unplugging AC: > http://paste.opensuse.org/5a8e9910 > > And

Re: cdc_acm bug? read buffer bytes shifted

2016-09-20 Thread Oliver Neukum
o debugs and it doesn't appear > in the logs), but I enabled cdc_acm debugs. Nothing is observable in the > logs when the bug appears. I logged everything as a comment of the gist: > https://gist.github.com/Julio-Guerra/b6529994f814771c825649bdb8d927c2#gistcomment-1875985 > &g

Re: USB hot-plug not working (ASUS TP301UA-C4028T)

2016-09-20 Thread Oliver Neukum
On Tue, 2016-09-20 at 11:11 +1200, Pierre de Villemereuil wrote: > Dear Oliver, > > Sorry about my last message, the bug is actually still going on. I found > something interesting though: when AC is plugged, USB is working totally OK, > but when on battery, then here comes t

Re: [PATCH] usb: misc: legousbtower: Fix NULL pointer deference

2016-09-20 Thread Oliver Neukum
for you? As far as I can tell, your patches are identical. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: USB hot-plug not working (ASUS TP301UA-C4028T)

2016-09-19 Thread Oliver Neukum
hat happens if you unload and reload the xhci_hcd modules? And please do echo "module xhci_hcd +mpf" > /sys/kernel/debug/dynamic_debug/control (as root) and check dmesg again. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe lin

Re: VL805 USB 3.0 does not see connected devices (only on x86_64) (x86 is ok)

2016-09-14 Thread Oliver Neukum
On Wed, 2016-09-14 at 15:22 +0300, c400 wrote: > may be i can help to test something else? I am ready and have enough free time You may need to mount debugfs at /sys/kernel/debug HTH Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb

[PATCH 1/2] cdc-acm: cleanup debugging in submission path

2016-09-13 Thread Oliver Neukum
Actually make it retutn useful information. Signed-off-by: Oliver Neukum --- drivers/usb/class/cdc-acm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index fef0d8f..faab151 100644 --- a/drivers/usb/class

[PATCH 2/2] cdc-acm: cleaning up debug in data submission path

2016-09-13 Thread Oliver Neukum
Further cleanup making the debug messages more precise, useful and removing mere trace points. Signed-off-by: Oliver Neukum --- drivers/usb/class/cdc-acm.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc

Re: [PATCH 2/3] cdc-acm: cleanup debugging in submission path

2016-09-12 Thread Oliver Neukum
On Fri, 2016-09-09 at 14:15 +0200, Greg KH wrote: > On Wed, Sep 07, 2016 at 02:30:02PM +0200, Oliver Neukum wrote: > > Actually make it retutn useful information. > > > > Signed-off-by: Oliver Neukum > > --- > > drivers/usb/class/cdc-acm.c | 8 > &

[PATCH] scsi: introduce a quirk for false cache reporting

2016-09-12 Thread Oliver Neukum
Some SATA to USB bridges fail to cooperate with some drives resulting in no cache being present being reported to the host. That causes the host to skip sending a command to synchronize caches. That causes data loss when the drive is powered down. Signed-off-by: Oliver Neukum Reviewed-by: Martin

Re: [uas] ORICO 2588US3 USB HDD enclosure goes offline after idle

2016-09-12 Thread Oliver Neukum
On Fri, 2016-09-09 at 04:03 +0300, Dmitry Gutov wrote: > On 06.09.2016 12:56, Oliver Neukum wrote: > > > Could you apply the attached patch, > > Thanks, will do as soon as I have a chance to reboot. > > > enable SCSI logging (with > > scsi_logging_level) a

Re: [PATCH net-next 0/3] r8152: configuration setting

2016-09-08 Thread Oliver Neukum
for the phy. What is unacceptable is to override the configuration mechanism in the kernel. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-09-08 Thread Oliver Neukum
On Thu, 2016-09-08 at 14:58 +0200, Wim Osterholt wrote: > On Thu, Sep 08, 2016 at 02:20:38PM +0200, Oliver Neukum wrote: > > > > > > The oops tells things that I didn't all write down, but it says > > > null pointer dereference at 0246 > > > &

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-09-08 Thread Oliver Neukum
help you. Please capture it dmesg > /root/oops.txt and report it. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi: introduce a quirk for false cache reporting

2016-09-08 Thread Oliver Neukum
On Thu, 2016-08-18 at 22:19 -0400, Martin K. Petersen wrote: > >>>>> "Oliver" == Oliver Neukum writes: > > Oliver> Some SATA to USB bridges fail to cooperate with some drives > Oliver> resulting in no cache being present being reported to the > Oliv

[PATCH 2/3] cdc-acm: cleanup debugging in submission path

2016-09-07 Thread Oliver Neukum
Actually make it retutn useful information. Signed-off-by: Oliver Neukum --- drivers/usb/class/cdc-acm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index ea7d361..7c21567 100644 --- a/drivers/usb/class

[PATCH 1/3] cdc-acm: delete obsolete debug messages

2016-09-07 Thread Oliver Neukum
Some debug messages merely provide a function trace without additional debug data. They predate ftrace and can be replaced by it. Drop them without replacement. Signed-off-by: Oliver Neukum --- drivers/usb/class/cdc-acm.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletions

[PATCH 3/3] cdc-acm: cleaning up debug in data submission path

2016-09-07 Thread Oliver Neukum
Further cleanup making the debug messages more precise, useful and removing mere trace points. Signed-off-by: Oliver Neukum --- drivers/usb/class/cdc-acm.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc

Re: Problem(s) with Seagate Backup Plus 4TB portable drive in UAS mode

2016-09-06 Thread Oliver Neukum
at the > > beginning. > > Here's an excerpt from the full log, from the very first message after > I physically plugged in the drive: Please use the scsi_logging_level tool to capture the error the drive reports. Regards Oliver -- To unsubscribe from this l

Re: [uas] ORICO 2588US3 USB HDD enclosure goes offline after idle

2016-09-06 Thread Oliver Neukum
On Mon, 2016-09-05 at 14:31 +0300, Dmitry Gutov wrote: > On 05.09.2016 14:19, Oliver Neukum wrote: > > > You add the device to the kernel quirks list. But if > > you don't use autosuspend, the point is moot. > > The device does get spinned down (after not using it f

Re: [uas] ORICO 2588US3 USB HDD enclosure goes offline after idle

2016-09-05 Thread Oliver Neukum
On Mon, 2016-09-05 at 14:01 +0300, Dmitry Gutov wrote: > On 05.09.2016 13:42, Oliver Neukum wrote: > > > This very much looks like power saving misbehaving. > > It does. But it doesn't seem like my distro enables autosuspend there by > default. > > > Are y

Re: [uas] ORICO 2588US3 USB HDD enclosure goes offline after idle

2016-09-05 Thread Oliver Neukum
power saving misbehaving. Are you using autosuspend on this device? Have you tried the RESET_RESUME quirk on the USB level? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RESEND PATCH 1/4] usb: dbc: early driver for xhci debug capability

2016-09-01 Thread Oliver Neukum
On Thu, 2016-09-01 at 10:21 +0800, Lu Baolu wrote: > Hi Oliver, > > Thanks for review. > > On 08/31/2016 05:53 PM, Oliver Neukum wrote: > > On Mon, 2016-08-29 at 13:26 +0800, Lu Baolu wrote: > >> + /* > >> +* Memory barrier to ensure hardware

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

2016-08-31 Thread Oliver Neukum
On Wed, 2016-08-31 at 12:48 +0300, Binyamin Sharet wrote: > Sure, but could you send me the cdc-acm.c file that this patch applies to? > Otherwise I need to patch it manually each time... Patch already applied. HTH Oliver /* * cdc-acm.c * * Copyright (c) 1999

Re: [RESEND PATCH 2/4] x86: add support for earlyprintk via USB3 debug port

2016-08-31 Thread Oliver Neukum
ttySn[,baudrate] > earlyprintk=dbgp[debugController#] > earlyprintk=pciserial,bus:device.function[,baudrate] > + earlyprintk=xdbc[xhciController#] > How is that defined? Should there be a PCI address? Regards

Re: [RESEND PATCH 1/4] usb: dbc: early driver for xhci debug capability

2016-08-31 Thread Oliver Neukum
else > + trb->field[3] &= cpu_to_le32(~TRB_CYCLE); And this manipulation you don't need the hardware to see? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to ma

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

2016-08-31 Thread Oliver Neukum
t line of code in skip_normal_probe) which may cause the > first check to dereference > a NULL pointer. Hi, could you test this updated patch? Regards Oliver From 4274cf2a7f8bf0b97b6d5ecc27882b9d946bf7f0 Mon Sep 17 00:00:00 2001 From: Oliver Neukum Date: Wed, 17

Re: [PATCHv6 1/3] usb: USB Type-C connector class

2016-08-30 Thread Oliver Neukum
On Tue, 2016-08-30 at 13:04 +0300, Heikki Krogerus wrote: > On Tue, Aug 30, 2016 at 11:32:01AM +0200, Oliver Neukum wrote: Hi, > > On Mon, 2016-08-29 at 15:36 +0300, Heikki Krogerus wrote: > > > +What: /sys/class/typec//current_data_role > > > +Date:

Re: Problem(s) with Seagate Backup Plus 4TB portable drive in UAS mode

2016-08-30 Thread Oliver Neukum
in your case, albeit with a performance penalty. But the actual cause of kicking in the error handler is missing in your log. You cut too much at the beginning. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a mess

Re: [PATCHv6 1/3] usb: USB Type-C connector class

2016-08-30 Thread Oliver Neukum
te operation does not mean > successful > + swap. > + That is badly formulated. Does it mean that poll() or select() can be used or does the value need to be repearedly read? And how would you learn about an error? Regards Oliver -- To unsubscribe from

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

2016-08-25 Thread Oliver Neukum
> Hi Oliver, > > It will take me some time to test it on v4.4.6-v7, so I have tried applying > the patch > to v4.4 but it failed in the 4th hunk (line 47). > > Please advise, should I: > > - manually edit the file on v4.4 and retest? Please do that. Reg

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

2016-08-25 Thread Oliver Neukum
On Thu, 2016-08-25 at 13:53 +, Binyamin Sharet (bsharet) wrote: > > > It’s a good thing you asked, as I forgot to test this one… > > Just to be sure - which tag should I use for testing this one? > Is v4.4 OK? Yes, perfect. Thanks Oliver -- T

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

2016-08-25 Thread Oliver Neukum
On Wed, 2016-08-17 at 15:26 +0200, Oliver Neukum wrote: > On Tue, 2016-08-16 at 16:46 +0300, Binyamin Sharet wrote: > > Kernel version: raspberrypi 4.4.6-v7+ #871 > > Driver source file: drivers/usb/class/cdc-acm.c > > Umap2 command line: umap2vsscan -P -s 22b8:2d93 > >

Re: [PATCH] usbnet: ax88179_178a: Add support for writing the EEPROM

2016-08-25 Thread Oliver Neukum
On Thu, 2016-08-25 at 12:07 +0200, Alban Bedel wrote: > On Thu, 25 Aug 2016 11:16:36 +0200 > Oliver Neukum wrote: > > > On Wed, 2016-08-24 at 16:40 +0200, Alban Bedel wrote: > > > On Wed, 24 Aug 2016 16:30:39 +0200 > > > Oliver Neukum wrote: > > >

Re: [PATCH] usbnet: ax88179_178a: Add support for writing the EEPROM

2016-08-25 Thread Oliver Neukum
On Wed, 2016-08-24 at 16:40 +0200, Alban Bedel wrote: > On Wed, 24 Aug 2016 16:30:39 +0200 > Oliver Neukum wrote: > > > On Wed, 2016-08-24 at 15:52 +0200, Alban Bedel wrote: > > > + if (block != data) > > > + kfree(block); > >

Re: [RESEND PATCH, v5 4/5] usb: Add MediaTek USB3 DRD Driver

2016-08-25 Thread Oliver Neukum
tic int ssusb_mode_open(struct inode *inode, struct file *file) > +{ > + return single_open(file, ssusb_mode_show, inode->i_private); > +} > + > +static ssize_t ssusb_mode_write(struct file *file, > + const char __user *ubuf, size_t count, loff_t *ppos) > +{ > + st

Re: [PATCH] usbnet: ax88179_178a: Add support for writing the EEPROM

2016-08-24 Thread Oliver Neukum
(offset + i) >> 1, > + AX_EEPROM_BLOCK >> 1, > + AX_EEPROM_BLOCK, &block[i]); > + } > + > + if (block != data) > + kfree(block); And if block == dta, what frees the memory? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Hotplug not working for USB 3.1 docking station on Dell XPS 13

2016-08-24 Thread Oliver Neukum
On Wed, 2016-08-24 at 14:43 +0100, Richard van der Hoff wrote: > On 24/08/16 13:17, Oliver Neukum wrote: > > On Wed, 2016-08-24 at 11:27 +0100, Richard van der Hoff wrote: > >> I'm having problems with a Plugable USB-C docking station, with my > >> laptop, a De

Re: Hotplug not working for USB 3.1 docking station on Dell XPS 13

2016-08-24 Thread Oliver Neukum
me dmesg > traces > and lspci logs attached to that bug. It looks like your initial diagnosis was correct. This is a PCI issue. What did you do at 814s after boot? Please don't just add a log without comments if you do something. One cannot tell what happens in response to what.

Re: [PATCH V5, 0/5] Add MediaTek USB3 DRD Driver

2016-08-24 Thread Oliver Neukum
he series? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Bug 153551: Kernel panic on Nexus 5X USB unplug while tethering

2016-08-23 Thread Oliver Neukum
finally times out. The fun > part happens when I unplug the phone. I consistently get a kernel panic. The HC has crashed thoroughly. Do other devices work after S3? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the

Re: cdc_acm bug? read buffer bytes shifted

2016-08-22 Thread Oliver Neukum
and > re-open() the device. The next read buffer is then correct. > Please activate dynamic debugging for the tty and cdc_acm driver. We need to know where the corruption happens. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: How the EHCI HC driver make the decision to suspend some USB devices?

2016-08-22 Thread Oliver Neukum
, either a) remote wakeup is not requested b) remote wakeup is requested and I) the device supports it II) the RESET_RESUME quirk is not set for the device 4) it is enabled in sysfs HTH Oliver -- To unsubscribe from this lis

Re: cdc_acm bug? read buffer bytes shifted

2016-08-20 Thread Oliver Neukum
the usb payload > "00 00 00 00 00 00 00 01". Hi, how many bytes does read() return? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Umap2][4/11][0557:2002] NULL pointer dereference

2016-08-18 Thread Oliver Neukum
On Thu, 2016-08-18 at 15:41 +0300, Binyamin Sharet wrote: > On 08/18/2016 12:12 PM, Oliver Neukum wrote: > > On Thu, 2016-08-18 at 12:10 +0300, Binyamin Sharet wrote: > >> On 08/18/2016 12:02 PM, Oliver Neukum wrote: > >>> On Thu, 2016-08-18 at 12:03 +0300, Binyamin

Re: [Umap2][11/11][9022:d483] kernel is unable to handle paging address

2016-08-18 Thread Oliver Neukum
t; << Attached: 9022_d483_dmesg_2.log >> > > << Attached: 9022_d483_kernel.log >> > kernel: 4.8-rc2 > result: reproduced > attached an update dmesg log > Hi, could you try the attached patch? Regards Oliver From 7ac7f7f000b69c47a7012

Re: [Umap2][7/11][160a:3184] NULL pointer dereference

2016-08-18 Thread Oliver Neukum
m and I was not able to retrieve the dmesg log. > I took a photo of the screen, should I send it as an attachment? Yes, that is better than nothing at all. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

your patch "USB: validate wMaxPacketValue entries in endpoint descriptors"

2016-08-18 Thread Oliver Neukum
Hi, I was wondering about the fate of this patch. As it fixes a security issue it should even go into atable and I fear it has been lost. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message

Re: [Umap2][4/11][0557:2002] NULL pointer dereference

2016-08-18 Thread Oliver Neukum
On Thu, 2016-08-18 at 12:10 +0300, Binyamin Sharet wrote: > On 08/18/2016 12:02 PM, Oliver Neukum wrote: > > On Thu, 2016-08-18 at 12:03 +0300, Binyamin Sharet wrote: > >> On 08/18/2016 11:37 AM, Oliver Neukum wrote: > >>> On Wed, 2016-08-17 at 17:33 +0300, Binyamin

Re: [Umap2][4/11][0557:2002] NULL pointer dereference

2016-08-18 Thread Oliver Neukum
On Wed, 2016-08-17 at 17:33 +0300, Binyamin Sharet wrote: > On 08/17/2016 05:19 PM, Oliver Neukum wrote: > > On Wed, 2016-08-17 at 17:07 +0300, Binyamin Sharet wrote: > >> Downloading firmware... > >> Firmware loaded. I'll be back... > >> probe of 1-1.1

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

2016-08-18 Thread Oliver Neukum
kind. > > Where exactly would you like to see this implemented if it isn't going > into those specific usbnet drivers? Higher up. I'd prefer a flag to tell the network core that a driver is unsure about the MAC and the core should deal with it. Regards

Re: [RFC PATCH v2 0/4] Type-C Port Manager

2016-08-18 Thread Oliver Neukum
point. Hi, a question on design. What happens if the system wants to suspend while we are in the middle of a power negotiation? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kerne

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

2016-08-18 Thread Oliver Neukum
On Thu, 2016-08-18 at 10:11 +0300, Binyamin Sharet wrote: > Hi, > > On 08/17/2016 04:26 PM, Oliver Neukum wrote: > > On Tue, 2016-08-16 at 16:46 +0300, Binyamin Sharet wrote: > >> Kernel version: raspberrypi 4.4.6-v7+ #871 > >> Driver source file: drivers/usb/c

Re: [Umap2][4/11][0557:2002] NULL pointer dereference

2016-08-17 Thread Oliver Neukum
USB disconnection, and the machine keeps working as > before. > > If you have any suggestion on how to perform it better, I'd be very > glad > to hear. The kaweth driver was loaded and performed as it should. Whence did you get your kernel sources? Regards

[PATCH v2 1/2] kaweth: fix firmware download

2016-08-17 Thread Oliver Neukum
This fixes the oops discovered by the Umap2 project and Alan Stern. The intf member needs to be set before the firmware is downloaded. Signed-off-by: Oliver Neukum --- drivers/net/usb/kaweth.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/usb/kaweth.c b

[PATCH v2 0/2]fixes to kaweth in response to Umap2 testing

2016-08-17 Thread Oliver Neukum
These patches fix an oops in firmware downloading and an oops due to a memory allocation failure -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2 2/2] kaweth: fix oops upon failed memory allocation

2016-08-17 Thread Oliver Neukum
Just return an error upon failure. Signed-off-by: Oliver Neukum --- drivers/net/usb/kaweth.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c index 37bf715..528b9c9 100644 --- a/drivers/net/usb/kaweth.c +++ b/drivers

Re: [PATCH 2/2] kaweth: fix oops upon failed memory allocation

2016-08-17 Thread Oliver Neukum
On Wed, 2016-08-17 at 15:15 +0200, Bjørn Mork wrote: > Oliver Neukum writes: > Eh, that should be "goto err_free_netdev;", shouldn't it? Right, thanks. Fixed version coming up. Regards Oliver -- To unsubscribe from this list: send the line "

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

2016-08-17 Thread Oliver Neukum
n go into stable? Regards Oliver From d741851d2b51a4693368487bc0046836b8458d98 Mon Sep 17 00:00:00 2001 From: Oliver Neukum Date: Wed, 17 Aug 2016 15:19:28 +0200 Subject: [PATCH] cdc-acm: added sanity checking for probe() This is analter

Re: [Umap2][4/11][0557:2002] NULL pointer dereference

2016-08-17 Thread Oliver Neukum
to majord...@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > kernel: 4.8-rc2 > result: not reproduced > > This is getting odd. There have been no substantial changes to kaweth between v4.4 and v4.8-rc2. I still think Alan's

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

2016-08-17 Thread Oliver Neukum
Thanks Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

2016-08-17 Thread Oliver Neukum
> and USB stops responding. That was before a major rewrite of the parser. Could you retest with v4.7? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo inf

[PATCH 1/2] kaweth: fix firmware download

2016-08-17 Thread Oliver Neukum
This fixes the oops discovered by the Umap2 project and Alan Stern. The intf member needs to be set before the firmware is downloaded. Signed-off-by: Oliver Neukum --- drivers/net/usb/kaweth.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/usb/kaweth.c b

<    2   3   4   5   6   7   8   9   10   11   >